[02:45:41] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality, 7user-notice: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1752259 (10Mattflaschen) >>! In T108190#1635874, @Tgr wrote: > This can be controlled by the `section` [[https://www.m... [03:29:06] 10Pywikibot-Flow, 5Patch-For-Review: Update bot to support Flow and demo it - https://phabricator.wikimedia.org/T108969#1752262 (10Mattflaschen) >>! In T108969#1664461, @Quiddity wrote: > @happy5214 Is there a clear description somewhere, that other bot authors/maintainers should follow in order to update thei... [09:39:56] 6Collaboration-Team-Backlog, 10Flow: Better distinguish rich text (VE) from code (wikitext) modes in Flow - https://phabricator.wikimedia.org/T116567#1752473 (10Pginer-WMF) 3NEW [09:59:46] 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1752516 (10Trizek-WMF) Found some spam [[ https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Contributions/Sandrine121234 | on frwp ]]. I'll investigate to see if there is spam elsewhere. [10:31:10] 6Collaboration-Team-Backlog, 10Flow, 7Design: Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#1752583 (10Esanders) 3NEW [10:45:02] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1752597 (10Pginer-WMF) I think there are multip... [11:31:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [13:10:43] hey mlitn, how is it going? [13:10:56] hey man [13:11:00] I’m good [13:11:02] how are you? [13:11:46] good [13:12:01] mlitn: could you try replying to any topic on that page: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA [13:13:06] sure [13:15:27] hmm [13:15:38] POST says the reply was committed [13:15:48] but then it isn’t rendered… [13:18:02] can it be the new cache keys? [13:18:26] or is it possible for a spam filter to silently reject it? [13:19:24] I can reproduce it locally on master. I just wanted to check if you knew about it already or had ideas before I debug into it. [13:19:34] if a spam filter rejects, there should always be an error (Block::addError) [13:19:57] and the post output likely wouldn’t say it’s committed; I think it’d abort [13:20:06] so cache key sounds more plausible [13:20:22] I’ve tried an action=purge, although that changed nothing [13:23:57] the revision gets created in the db [13:24:22] it there a way to purge the entire cache? [13:25:35] purge: no [13:25:45] but you can invalidate all existing cache by changing $wgFlowCacheVersion [13:25:49] I changed $wgFlowCacheVersion and reloaded, all my responses are there [13:25:51] (that is prefixed to every key) [13:26:05] so there’s indeed something wrong with cache [13:28:08] maybe test Flow with and without this patch: https://gerrit.wikimedia.org/r/#/c/248368/ [13:28:23] 3Collaboration-Team-Current, 10Flow: Beta: Cannot reply to any topic - https://phabricator.wikimedia.org/T116582#1752874 (10SBisson) 3NEW [13:28:31] that seems to be the only recent cache change [13:31:24] mlitn: it's weird, even by checking out a revision before this patch I still see the problem locally [13:33:02] and what about https://gerrit.wikimedia.org/r/#/c/247782/? [13:33:05] also cache-related [13:34:15] I'll try, but I have to also rewind core for this to work [13:45:48] mlitn: I can't find where to go back to avoid this error: "Declaration of Flow\Data\BagOStuff\BufferedBagOStuff::set() must be compatible with that of BagOStuff::set()" [13:47:46] in core? [13:47:46] https://gerrit.wikimedia.org/r/#/c/247182/ [13:47:53] that’s the equivalent change in core [13:53:39] ok, before those 2 it was ok [14:06:50] 6Collaboration-Team-Backlog, 10Flow: Allow preloading summary with explicit text - https://phabricator.wikimedia.org/T94283#1752977 (10Mattflaschen) >>! In T94283#1682017, @Trizek-WMF wrote: > Other cases: > * [[ https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Forum_des_nouveaux/relecture | proofreading page on... [14:09:58] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Make deleting boards turns topic links red - https://phabricator.wikimedia.org/T108135#1752981 (10Mattflaschen) [14:19:14] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Make deleting boards turns topic links red - https://phabricator.wikimedia.org/T108135#1753028 (10Mattflaschen) >>! In T108135#1682716, @SBisson wrote: > It doesn't. > > Deleting a board seems to make the topics read-only but they are still a... [14:36:51] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Editing-Analysis: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1753058 (10matthiasmullie) a:3matthiasmullie [15:56:40] (03CR) 10Matthias Mullie: [C: 032] Display "Unknown topic" when the requested topic is from another wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248100 (https://phabricator.wikimedia.org/T113311) (owner: 10Sbisson) [15:59:18] (03Merged) 10jenkins-bot: Display "Unknown topic" when the requested topic is from another wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248100 (https://phabricator.wikimedia.org/T113311) (owner: 10Sbisson) [16:05:29] 6Collaboration-Team-Backlog, 10Echo: Minimal exposure of cross-wiki notifications in the Notification Panel - https://phabricator.wikimedia.org/T114354#1753592 (10Pginer-WMF) >>! In T114354#1749021, @Jdforrester-WMF wrote: > I don't think spending users' conceptual space (and developer effort) on building some... [16:06:18] (03CR) 10Matthias Mullie: [C: 032] Do not hide menu behind page footer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248154 (https://phabricator.wikimedia.org/T116077) (owner: 10Sbisson) [16:08:58] (03Merged) 10jenkins-bot: Do not hide menu behind page footer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248154 (https://phabricator.wikimedia.org/T116077) (owner: 10Sbisson) [16:21:08] 6Collaboration-Team-Backlog, 10Echo, 10Wikidata, 7Regression: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1753672 (10Legoktm) p:5Triage>3High [16:29:37] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 7Performance: Static data should go in ResourceLoaderGetConfigVars or data module, not MakeGlobalVariablesScript - https://phabricator.wikimedia.org/T73539#1753714 (10Krinkle) 5Open>3declined a:3Krinkle Per previous comments, contrary to opening post, I bel... [16:32:17] (03PS1) 10Legoktm: Require $user parameter in DataOutputFormatter::formatOutput() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248901 [16:32:20] (03PS1) 10Legoktm: Don't use $wgLang in DataOutputFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248902 [16:32:23] (03PS1) 10Legoktm: ApiEchoNotifications: Remove unused variable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248903 [16:32:25] 6Collaboration-Team-Backlog, 10Flow: Flow: Flow board history shouldn't usurp action=history (prio from Nick) - https://phabricator.wikimedia.org/T75538#1753729 (10Mattflaschen) It's related, but not a duplicate. If Flow used a separate URL for history, pointing to Special:History would have the same effect a... [16:32:26] (03PS1) 10Legoktm: API: Remove pre-1.25 compat code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248904 [16:32:39] (03PS1) 10Legoktm: [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [16:36:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [16:46:38] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikimedia-Site-Requests: Enable the Wikidata personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1753818 (10Jdforrester-WMF) 3NEW [16:47:00] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikimedia-Site-Requests: Enable the Wikidata personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1753828 (10Jdforrester-WMF) p:5Triage>3Normal [16:51:41] 6Collaboration-Team-Backlog, 10Echo, 7Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612#1753838 (10Legoktm) 3NEW a:3Legoktm [16:51:50] 3Collaboration-Team-Current, 10Echo, 7Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612#1753854 (10Legoktm) [16:56:54] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Echo is passing wrong type for eventId - https://phabricator.wikimedia.org/T116205#1753875 (10Etonkovidova) From https://meta.wikimedia.org/wiki/Schema:Echo - recipientUserId and recipientEditCount do not need e... [17:11:11] 3Collaboration-Team-Current, 10Flow: Beta: Cannot reply to any topic - https://phabricator.wikimedia.org/T116582#1753945 (10SBisson) It seems to be happening since https://gerrit.wikimedia.org/r/#/c/248539 [17:14:33] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1753980 (10Pginer-WMF) > I don't think 'discard' is the best word for us to use here. It's not being discarded, just marked read. I agree. This is not terminology to be exp... [17:15:39] (03PS2) 10Mattflaschen: Pull out isModeratedChange to check if something is a moderation action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248473 [17:16:37] 3Collaboration-Team-Current, 10Flow: Beta: Cannot reply to any topic - https://phabricator.wikimedia.org/T116582#1753991 (10SBisson) a:3SBisson [17:19:54] stephanebisson: FYI, https://gerrit.wikimedia.org/r/#/c/248368/ is also related to that patch [17:20:30] (03CR) 10Mattflaschen: "This was originally part of my draft patch for an RC issue, but I think it should be useful in itself." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248473 (owner: 10Mattflaschen) [17:20:34] RoanKattouw: indeed but it doesn't seem to be causing the issue [17:20:47] OK [17:20:50] Just making sure you were aware [17:20:54] thanks [17:27:04] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: flow-menu-js-drop menu options are cut off for topics at the bottom of the page - https://phabricator.wikimedia.org/T107235#1754056 (10Etonkovidova) [17:28:46] 3Collaboration-Team-Current, 10Flow: Beta: Cannot reply to any topic - https://phabricator.wikimedia.org/T116582#1754087 (10Mattflaschen) Maybe also related to {cdb543272883b18000c6a522c6526fa7d72f4c1c}. [17:31:26] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1754090 (10Etonkovidova) Also related to {T114177} [17:37:43] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 7Regression: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1754117 (10Legoktm) a:3Legoktm [17:44:21] (03CR) 10Alex Monk: [C: 032] Require $user parameter in DataOutputFormatter::formatOutput() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248901 (owner: 10Legoktm) [17:47:21] (03Merged) 10jenkins-bot: Require $user parameter in DataOutputFormatter::formatOutput() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248901 (owner: 10Legoktm) [17:48:00] (03CR) 10Alex Monk: [C: 032] Don't use $wgLang in DataOutputFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248902 (owner: 10Legoktm) [17:48:31] (03CR) 10Alex Monk: [C: 032] ApiEchoNotifications: Remove unused variable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248903 (owner: 10Legoktm) [17:49:17] (03CR) 10Alex Monk: [C: 032] API: Remove pre-1.25 compat code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248904 (owner: 10Legoktm) [17:50:52] (03Merged) 10jenkins-bot: Don't use $wgLang in DataOutputFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248902 (owner: 10Legoktm) [17:53:25] (03Merged) 10jenkins-bot: ApiEchoNotifications: Remove unused variable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248903 (owner: 10Legoktm) [17:53:28] (03Merged) 10jenkins-bot: API: Remove pre-1.25 compat code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248904 (owner: 10Legoktm) [17:54:05] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1754190 (10matthiasmullie) Note that "yesterday" may not be the same as "a/1 day ago": yesterday refers to the day prior to the current day. If now i... [18:41:08] (03CR) 10Catrope: "Why is this C+2 V+2 but not merged?" [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/248599 (owner: 10Ori.livneh) [18:42:52] mooeypoo: https://github.com/wikimedia/generator-wikimedia-php-library [18:50:18] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 7Performance: Static data should go in data module, not MakeGlobalVariablesScript - https://phabricator.wikimedia.org/T73539#1754490 (10Mattflaschen) [18:50:49] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 7Performance: Static data should go in data module, not MakeGlobalVariablesScript - https://phabricator.wikimedia.org/T73539#1754493 (10Mattflaschen) 5declined>3Open Do you think it makes sense to do it in a data module? [18:53:09] (03CR) 10Gilles: "I wondered the same thing and merged it ;)" [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/248599 (owner: 10Ori.livneh) [18:53:51] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-AbuseFilter: Make AbuseFilter groups one or more, rather than just one - https://phabricator.wikimedia.org/T116642#1754503 (10Mattflaschen) 3NEW [18:56:22] If we went through 100 of the ones in the untriaged column every triage meeting, wouldn't take long to triage them. [19:02:41] 3Collaboration-Team-Current, 10Flow: [betalabs] Link inspector displayed differently at the bottom of a Flow board - https://phabricator.wikimedia.org/T116643#1754528 (10Etonkovidova) 3NEW [19:04:06] stephanebisson: can you please take a look at https://phabricator.wikimedia.org/T116643 which I just filed? just take a look - looks very mysterious to me... [19:04:26] sure [19:04:52] stephanebisson: maybe you can add some info to it - cause there are no errors in the Console [19:05:09] stephanebisson: many thanks [19:05:54] etonkovidova: the clipping at the bottom is probably the same issue I have fixed for the other menu [19:06:36] but it's to far left, I would say it's related to VE or our integration with it [19:06:52] can't tell you more [19:15:55] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Echo is passing wrong type for eventId - https://phabricator.wikimedia.org/T116205#1754578 (10Etonkovidova) Already done: 'recipientEditCount' => (int)$user->getEditCount() recipientUserId is always integer (p... [19:18:19] stephanebisson: sigh - ok [19:40:12] 6Collaboration-Team-Backlog, 10WikiLove, 10Possible-Tech-Projects, 10UI-Standardization: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1754684 (10Mattflaschen) I would lean towards adding one more, with the additional one being small-medium. {T104298} would be a goo... [19:44:15] (03CR) 10Mattflaschen: "CSS classes should be namespaced with flow-. I'll tweak this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248154 (https://phabricator.wikimedia.org/T116077) (owner: 10Sbisson) [19:49:49] 3Collaboration-Team-Current, 10Echo, 6Design-Research, 5Design Research and product team collaboration, and 2 others: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1754707 (10Capt_Swing) The findings from our first user study have been prese... [20:13:03] 6Collaboration-Team-Backlog, 10Flow: id of element on board page set to null - https://phabricator.wikimedia.org/T116657#1754847 (10Mattflaschen) [20:24:07] Is anyone else getting "Warning: Cannot read property '1' of null Use --force to continue." from banana on the pre-commit hook? [20:25:27] 3Collaboration-Team-Current, 10Flow: [betalabs] Link inspector displayed differently at the bottom of a Flow board - https://phabricator.wikimedia.org/T116643#1754896 (10Etonkovidova) ve-ui-educationPopup-header" seems to be a new feature that appears only first time when you click on the Link Inpsector during... [20:25:32] (03PS1) 10Mattflaschen: Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 [20:31:18] 3Collaboration-Team-Current, 10Flow: [betalabs] First invocation of a Link inspector displayed cut off on a Flow board - https://phabricator.wikimedia.org/T116643#1754908 (10Etonkovidova) [20:31:46] matt_flaschen: is everything ok when you `grunt lint`? [20:31:47] etonkovidova, stephanebisson: Ugh, that's VE's new user education thing. I don't think we want that to be displayed at all [20:32:43] arg. and that's rolling out this week. [20:34:00] Yeah [20:34:07] I've asked over in -visualeditor how we can disable it [20:34:20] But I might also dig around the code a bit to see if it's easy to do that [20:54:40] (03PS1) 10Catrope: Add hack to make VE education popups go away [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248992 (https://phabricator.wikimedia.org/T116643) [20:57:07] (03PS2) 10Catrope: Add hack to make VE education popups go away [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248992 (https://phabricator.wikimedia.org/T116643) [20:57:27] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: [betalabs] First invocation of a Link inspector displayed cut off on a Flow board - https://phabricator.wikimedia.org/T116643#1755102 (10Catrope) a:3Catrope [21:02:48] stephanebisson, no, same issue. Sorry, missed your ping somehow. [21:03:39] matt_flaschen: maybe `npm install` to make sure you have the proper versions of packages [21:05:34] (03CR) 10Alex Monk: "I think this will work, we should come up with a better way to do this though" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248992 (https://phabricator.wikimedia.org/T116643) (owner: 10Catrope) [21:05:47] stephanebisson, it doesn't make any changes, just: [21:05:49] npm WARN prefer global jshint@2.5.11 should be installed with -g [21:05:52] which has been there for a long time. [21:06:04] stephanebisson, unrelatedly, found one of our maintenance scripts written in French. [21:06:07] :) [21:06:28] matt_flaschen: is it me? [21:06:58] stephanebisson, nope. [21:07:22] It's in core, only part of the script really (function names and associated modes). [21:10:46] (03PS8) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [21:13:48] (03PS9) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [21:14:29] (03PS6) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 [21:14:46] (03PS10) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [21:32:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Exception when viewing https://es.wikiquote.org/wiki/Tema:Sobaaiky57zs7py7 - https://phabricator.wikimedia.org/T113311#1755209 (10Etonkovidova) Checked in betalabs - checking topics between ruwiki, enwiki, and... [21:36:22] Wait, we have a French maintenance script? How did I not know this [21:36:32] Now I wonder if it was hashar who did that or ialex [21:37:54] (03CR) 10Catrope: [C: 04-1] Use flow- prefix for the CSS classes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen) [21:42:12] (03CR) 10Catrope: [C: 032] BagOStuff::delete no longer accepts 2 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247574 (owner: 10Matthias Mullie) [21:44:58] (03Merged) 10jenkins-bot: BagOStuff::delete no longer accepts 2 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247574 (owner: 10Matthias Mullie) [21:53:13] SQL inside bash inside Puppet. If I have to add an ERB, it will be Inception. [21:53:30] RoanKattouw, in one. [21:54:24] https://phabricator.wikimedia.org/diffusion/MW/browse/master/maintenance/userOptions.inc [21:57:55] hah, lister/usager/changer, nice [21:58:26] (03CR) 10Catrope: [C: 032] Remove RC spam for moderated topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248314 (https://phabricator.wikimedia.org/T116058) (owner: 10Matthias Mullie) [22:01:01] (03Merged) 10jenkins-bot: Remove RC spam for moderated topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248314 (https://phabricator.wikimedia.org/T116058) (owner: 10Matthias Mullie) [22:05:04] (03PS1) 10Sbisson: Fix cache key construction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249003 (https://phabricator.wikimedia.org/T116582) [22:08:13] matt_flaschen: RoanKattouw: ^ for the "cannot reply to post" bug [22:09:12] (03PS7) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 [22:10:03] Yeah I figured it was probably something like that [22:10:12] stephanebisson: Where does 'tree' come from? [22:10:22] that's a good example of something that took me all day that could have been very quick for someone who understand how/where the cache is used [22:11:43] (03PS2) 10Sbisson: Fix cache key construction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249003 (https://phabricator.wikimedia.org/T116582) [22:11:57] RoanKattouw: MultiGetList.php:42 [22:12:22] TreeRepository.php:68 [22:12:52] Oh, I see [22:12:55] I think this could be more tight [22:13:06] key generation in ONE place [22:14:00] Yeah [22:14:01] but I also wanted to be sure we have a fix before no post can be replied to on mw.org tomorrow [22:14:27] Yeah, same for me with https://gerrit.wikimedia.org/r/248992 [22:15:15] Your fix looks good to me, two nitpicks: you changed a param name in the signature but not in the documentation comment (you also changed its type, but the docs were already wrong and are now right), and the reuse of $type for the exception is confusing [22:15:40] RoanKattouw: sure, will address that right away [22:17:57] (03PS3) 10Sbisson: Fix cache key construction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249003 (https://phabricator.wikimedia.org/T116582) [22:18:18] RoanKattouw: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:ET9 [22:18:43] hah that's an elegant solution [22:23:30] (03CR) 10Catrope: [C: 032] Fix cache key construction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249003 (https://phabricator.wikimedia.org/T116582) (owner: 10Sbisson) [22:23:38] (03PS1) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [22:25:54] 6Collaboration-Team-Backlog, 10Echo: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#1755483 (10matmarex) [22:26:04] (03Merged) 10jenkins-bot: Fix cache key construction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249003 (https://phabricator.wikimedia.org/T116582) (owner: 10Sbisson) [22:28:21] mooeypoo: https://gerrit.wikimedia.org/r/248992 [22:36:15] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1755566 (10Etonkovidova) Two cases when not all options of flow-menu-js-drop are dis... [22:36:22] (03CR) 10Catrope: [C: 031] "Let's merge this after the branch cut" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247575 (https://phabricator.wikimedia.org/T94028) (owner: 10Matthias Mullie) [22:38:33] (03CR) 10Mooeypoo: [C: 032] "meh." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248992 (https://phabricator.wikimedia.org/T116643) (owner: 10Catrope) [22:50:48] 6Collaboration-Team-Backlog, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755617 (10Quiddity) 3NEW [22:53:07] (03Merged) 10jenkins-bot: Add hack to make VE education popups go away [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248992 (https://phabricator.wikimedia.org/T116643) (owner: 10Catrope) [22:56:30] 6Collaboration-Team-Backlog, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755640 (10Mattflaschen) p:5Triage>3Unbreak! [22:56:35] 6Collaboration-Team-Backlog, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755644 (10Mattflaschen) a:3Mattflaschen [22:56:51] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755617 (10Mattflaschen) [22:58:47] 3Collaboration-Team-Current, 10Echo, 6Design-Research, 5Design Research and product team collaboration, and 2 others: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1755660 (10Catrope) >>! In T114086#1754707, @Capt_Swing wrote: > The findings... [23:00:55] Parsoid is broken again in production. [23:01:09] Also, we really need to make it blow up early so it's caught immediately, rather than act like it's only required for certain special features. [23:01:28] Yeah this whole thing of trying to fall back to the PHP parser doesn't make much sense to me [23:01:41] The indirection results in confusing error messages [23:01:50] Oh and yeah, it needs to be monitored properly [23:01:59] matt_flaschen: In what way is it broken? [23:02:15] RoanKattouw, see quiddity's bug https://phabricator.wikimedia.org/T116685#1755640 . Working on it now. [23:02:23] Yeah I saw that [23:02:41] RoanKattouw, I assume someone either turned off a service or changed mediawiki-config, still working on it. [23:02:45] What I meant was (and feel free to answer later once it's fixed or whatever), in what way is Parsoid broken that causes it [23:02:47] I didn't attempt to save any edits to that board-header, in case that helped disagnose [23:02:47] OK [23:02:50] I would also like to get rid of support for the PHP parser entirely, but first we need to run Parsoid tests on Jenkins. [23:02:56] Right, yeah [23:04:44] Also, exception.log takes forever to grep through since it's now 4.7 GB, and that's all from today. [23:06:45] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755715 (10Mattflaschen) [23:07:24] Oh it's from the outage [23:07:35] 6Collaboration-Team-Backlog, 10Flow: [betalabs] Safari displays a blue line when editors switched - https://phabricator.wikimedia.org/T116689#1755717 (10Etonkovidova) 3NEW [23:08:15] RoanKattouw, why is it working on MediaWiki.org? [23:08:17] And what outage? [23:09:03] Sorry I meant the exception.log spam was from this morning's outage [23:11:49] RoanKattouw, well, it's (back to/still?) giving us the IDs instead of data-parsoid, but other than that not easily reproducible in console. [23:12:06] Hmm did my change for that ever get cherry-picked? [23:12:12] Or is it just going to ride the train [23:12:21] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755725 (10Mattflaschen) Doesn't show up in console. ``` mattflaschen@terbium:~$ mwscript eval.php --wik... [23:13:26] RoanKattouw, no, you didn't cherry-pick it turns out. [23:13:34] ARGH [23:13:40] (unrelated) [23:14:04] quiddity, is there a sandbox on zhwiki? [23:14:12] ARGH because ContributionsQuery::queryRevisions can perform three completely different queries based on a switch-case [23:14:32] matt_flaschen https://zh.wikipedia.org/wiki/Wikipedia_talk:Flow_tests [23:19:02] Well, I haven't fixed that, but I found another bad VE interaction. [23:23:22] 3Collaboration-Team-Current, 10Flow: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1755762 (10Mattflaschen) 3NEW [23:23:59] ^ RoanKattouw, can you look at that unless you have something else urgent? I'll keep working on the original issue. [23:24:52] WTF?!? [23:25:11] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755778 (10Mattflaschen) It's also specific to that page, not just the wiki: https://zh.wikipedia.org/w/... [23:29:33] 3Collaboration-Team-Current, 10Flow: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1755809 (10Catrope) WTF, there is a whole lot of stuff missing from view-source:https://zh.wikipedia.org/wiki/Wikipedia_talk:Flow_tests?action=history . The entire blob with expor... [23:29:49] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-ResourceLoader, 6Performance-Team: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1755810 (10Catrope) [23:38:25] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755829 (10Mattflaschen) Our integration of Parsoid/RESTBase refuses to convert the last revision to wiki... [23:40:53] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755840 (10Mattflaschen) The second is fine with direct http://parsoid-lb.eqiad.wikimedia.org/_html/ (unl... [23:41:57] RoanKattouw, what are the specific known issues that we are tracking with RESTBase/Flow? The ones I know about are: [23:42:04] 1. Dirty diffs due to lost data-parsoid. [23:42:13] 2. Some weird thing with {{{ I don't understand. [23:42:30] Trying to decide whether to file this. [23:42:42] AFAIK just those two [23:43:12] I guess we might as well cherry-pick your patch, since it *might* fix it, and if not, it will just be the same as it would have been tomorrow anyway. [23:44:11] #2 is an issue where if you do wt2html and then html2wt starting with "{{{foo}}}", Parsoid 500s when html2wt'ing [23:44:19] Right [23:44:22] And it's a simple patch [23:49:35] 3Collaboration-Team-Current, 10Flow: Stop falling back to PHP parser if a specific Parsoid call fails - https://phabricator.wikimedia.org/T116699#1755857 (10Mattflaschen) 3NEW a:3Mattflaschen [23:51:26] 3Collaboration-Team-Current, 10Flow: Issue with converting a specific post from HTML to wikitext with RESTBase - https://phabricator.wikimedia.org/T116700#1755879 (10Mattflaschen) 3NEW a:3Mattflaschen [23:52:49] (03PS1) 10Mattflaschen: Temporarily disable RESTbase support to avoid data-parsoid issues [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249026 (https://phabricator.wikimedia.org/T115236) [23:56:59] (03CR) 10Alex Monk: [C: 032] Temporarily disable RESTbase support to avoid data-parsoid issues [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249026 (https://phabricator.wikimedia.org/T115236) (owner: 10Mattflaschen) [23:59:42] (03Merged) 10jenkins-bot: Temporarily disable RESTbase support to avoid data-parsoid issues [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249026 (https://phabricator.wikimedia.org/T115236) (owner: 10Mattflaschen)