[00:10:41] (03PS5) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [00:13:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [00:59:16] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1747250 (10Quiddity) See also T94648#1178640 wherein I researched a large number of other websites. The community is strongly in favour of the secon... [02:17:49] 6Collaboration-Team-Backlog, 10Flow: Delete unneeded LQT/Flow templates from wikis that didn't have LQT - https://phabricator.wikimedia.org/T115518#1747324 (10Liuxinyu970226) [06:37:36] 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1747489 (10matthiasmullie) Also added https://www.mediawiki.org/wiki/Special:AbuseFilter/44, which should stop most keyboard-smashing input. Clusters of multiple consecutive conso... [07:53:14] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1747529 (10Pginer-WMF) >>! In T111596#1746745, @SBisson wrote: > Which one is better, "a day ago" or "1 day ago"? @pginer-wmf In this context, I thi... [08:02:23] 3Collaboration-Team-Current, 10Flow: Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1747533 (10matthiasmullie) a:3matthiasmullie [10:39:33] (03PS1) 10Matthias Mullie: Remove RC spam for moderated topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248314 (https://phabricator.wikimedia.org/T116058) [11:17:06] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1747772 (10Trizek-WMF) [[ https://meta.wikimedia.org/wiki/Tech/News/2015/43 | Too late ]]. [11:28:51] 6Collaboration-Team-Backlog, 10Flow: Flow: It's too easy to accidentally edit when logged-out - https://phabricator.wikimedia.org/T60696#1747778 (10SBisson) >>! In T60696#1747126, @He7d3r wrote: > Will that warning appear when you attempt to save and edit? > (e.g. if you start writing a comment, and is logged... [12:43:55] 6Collaboration-Team-Backlog, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1747862 (10Trizek-WMF) A user [[ https://fr.wikipedia.org/w/index.php?title=Sujet:Sqsccaf41ercbdaq&topic_showPostId=sqtsyrdrdzk309os#flow-post-sqtsyrdrdzk309os | c... [12:57:46] 6Collaboration-Team-Backlog, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1747890 (10Pginer-WMF) > Create a minima a way to personalize VE and wikitext toolbars with a gadget would be a good idea. Adding media is a reasonable usecase fo... [13:12:05] 6Collaboration-Team-Backlog, 10Flow: TOC: Newly created topics are not added to the top of the toc - https://phabricator.wikimedia.org/T86798#1747907 (10SBisson) This appears to be fixed. @etonkovidova can you confirm? [13:17:44] 6Collaboration-Team-Backlog, 10Flow, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1747920 (10Trizek-WMF) >>! In T78346#1747890, @Pginer-WMF wrote: >> Create a minima a way to personalize VE and wikitext toolbars with a gadget would be a good ide... [13:31:31] Morning [13:38:47] morning! [15:08:00] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow pages are dissimilar from regular pages (tracking) - https://phabricator.wikimedia.org/T85260#1748078 (10Mattflaschen) [15:08:02] 6Collaboration-Team-Backlog, 10Flow: Flow API: Let code append to the board header with action=edit&appendtext - https://phabricator.wikimedia.org/T85197#1748075 (10Mattflaschen) 5Open>3declined a:3Mattflaschen Declining for the same reason as {T59989}. It's very hard to shim an existing API (one that u... [15:08:17] 6Collaboration-Team-Backlog, 10Flow: Flow API: Let code append to the board header with action=edit&appendtext - https://phabricator.wikimedia.org/T85197#1748083 (10Mattflaschen) a:5Mattflaschen>3None [15:13:17] (03PS1) 10Mattflaschen: Update comments to reflect removal of wgFlowOccupyNamespaces. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248347 [15:13:38] (03CR) 10Sbisson: [C: 031] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo) [15:14:21] (03CR) 10Mattflaschen: [C: 032] "Self-merging minor comment fix" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248347 (owner: 10Mattflaschen) [15:16:32] 6Collaboration-Team-Backlog, 10Flow: future of wgFlowOccupyNamespaces - https://phabricator.wikimedia.org/T76781#1748110 (10Mattflaschen) 5Open>3Resolved a:3Mattflaschen wgFlowOccupyNamespaces has been removed entirely. The only remaining mechanisms are: * [wgNamespaceContentModels](https://www.mediawi... [15:16:55] (03Merged) 10jenkins-bot: Update comments to reflect removal of wgFlowOccupyNamespaces. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248347 (owner: 10Mattflaschen) [15:17:08] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [15:19:27] 6Collaboration-Team-Backlog, 10Flow: Flow:action=query&list=flow has exceptions on enwiki, bogus workflow UUID on ee-flow - https://phabricator.wikimedia.org/T65930#1748120 (10Mattflaschen) 5Open>3Invalid a:3Mattflaschen This API has been removed entirely. [15:27:16] 6Collaboration-Team-Backlog, 10Flow, 10SyntaxHighlight: Flow: syntax highlighting tags (GeSHi) don't work - https://phabricator.wikimedia.org/T59159#1748129 (10Mattflaschen) [15:43:01] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1748182 (10Mattflaschen) >>! In T112900#1665780, @Petrb wrote: > OK, I guess I will need to read some docume... [15:44:23] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1748187 (10Mattflaschen) There are some wikis where Flow is not enabled on any user talk at all yet, but I d... [15:47:59] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow: Flow should support making actions as a bot and set rc_bot accordingly - https://phabricator.wikimedia.org/T73197#1748204 (10Mattflaschen) [15:48:00] 6Collaboration-Team-Backlog, 10Flow: Flow API - need a way for bots to edit posts, without adjusting the timestamp - https://phabricator.wikimedia.org/T94711#1748203 (10Mattflaschen) [15:48:20] 6Collaboration-Team-Backlog, 10Flow: Flow API - need a way for bots to edit posts, without notifying author, maybe without affecting 'updated' topic ordering - https://phabricator.wikimedia.org/T94711#1748207 (10Mattflaschen) [15:48:43] 6Collaboration-Team-Backlog, 10Flow: Flow API - need a way for bots to edit posts, without notifying author by default, maybe without affecting 'updated' topic ordering - https://phabricator.wikimedia.org/T94711#1170747 (10Mattflaschen) [15:54:49] (03PS1) 10Sbisson: Browser tests: using mw_selenium 1.5 because 1.6 is broken [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248353 (https://phabricator.wikimedia.org/T114368) [15:56:38] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-API: Include Flow revisions in RecentChanges API - https://phabricator.wikimedia.org/T104083#1748245 (10Mattflaschen) [16:03:42] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-API: Include Flow revisions in RecentChanges API - https://phabricator.wikimedia.org/T104083#1748252 (10Mattflaschen) [16:04:10] 6Collaboration-Team-Backlog, 10Flow: Support Flow changes in Usercontribs API - https://phabricator.wikimedia.org/T88753#1019557 (10Mattflaschen) [16:20:46] (03CR) 10Mattflaschen: [C: 032] Browser tests: using mw_selenium 1.5 because 1.6 is broken [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248353 (https://phabricator.wikimedia.org/T114368) (owner: 10Sbisson) [16:23:36] (03Merged) 10jenkins-bot: Browser tests: using mw_selenium 1.5 because 1.6 is broken [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248353 (https://phabricator.wikimedia.org/T114368) (owner: 10Sbisson) [16:41:34] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1748333 (10Mattflaschen) [16:46:40] Damn it [16:46:58] I forgot to claim T116058 before I started working on it yesterday. [16:47:24] hah [16:47:32] * RoanKattouw waves BTW [16:56:54] RoanKattouw, hey. [16:57:17] Welcome back. How was vacation? [16:57:21] It was cool [16:57:42] I had relatives over who had never been to the US before, so it was nice to show them around [16:57:50] And to bike around SF with people who can keep up for once :D [16:58:08] :) [16:58:21] That sounds really nice. [16:58:24] What all happened while I was gone? I'm still catching up on email and I've barely even looked at the Phabricator board or Gerrit so far [16:58:59] Nothing too dramatic. One of the main things is helping MediaWiki.org deal with a spam outbreak. [17:00:17] https://phabricator.wikimedia.org/T116211 [17:00:46] ouch [17:02:16] We wrote an AbuseFilter filter, deployed the RateLimits patch yesterday, and I started working on the RC one... but yeah, I'm an idiot. [17:02:27] How so? [17:02:43] I mean my "ouch" was mainly about "crap that's a lot of work interrupting everything else" [17:03:33] I started working on it (and continued today), didn't claim it, then Matthias apparently finished it [17:03:53] Oh the RC one, right ,yeah [17:08:52] (03PS1) 10Ori.livneh: Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 [17:09:46] matt_flaschen, mlitn: ---^^ [17:10:39] (03CR) 10jenkins-bot: [V: 04-1] Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [17:11:13] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1748523 (10Luke081515) Maybe with a query, search for "contentmodel"? [17:17:49] RoanKattouw, reviewing it. [17:17:54] I'm looking for work [17:17:59] matt_flaschen: any reason why I shouldn't pick up https://phabricator.wikimedia.org/T114456 ? [17:19:58] stephanebisson, no, go ahead. I haven't specifically worked on it. It might be partly fixed for the ID case, but I haven't tested. [17:20:45] matt_flaschen: it seems to require a lot of context that you have and I don't [17:21:01] that's probably a good reason for me to look at it [17:21:41] 3Collaboration-Team-Current, 10Flow: Main topic list pagination can only paginate at most 500 topics - https://phabricator.wikimedia.org/T114456#1748553 (10SBisson) a:3SBisson [17:23:13] stephanebisson, yep, ping me anytime. [17:24:18] Pro-tip, don't set your git color variables to 'always'. Weird things will happen when you pipe. 'auto' is fine. [17:26:42] I think I originally put it on that so I could pipe to the pager, but it fails if you e.g. try to grep the output. [17:35:59] legoktm, standup [17:56:49] 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1748788 (10Volker_E) The most recent proposal by @Pginer-WMF fulfills questioned fine-graining of notifications well in my understanding. On the other hand I don't think intro... [17:59:50] 3Collaboration-Team-Current, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter, and 2 others: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1748801 (10Legoktm) 5Open>3Resolved [18:05:43] Getting lunch [18:13:27] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 7user-notice: Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1748865 (10Quiddity) Ha! Ok, I'll add it back, and move to archive, for completeness. [18:22:55] mlitn: Could you review https://gerrit.wikimedia.org/r/248368 ? [18:24:06] I’ll take a look [18:24:35] Thanks [18:38:02] (03CR) 10Matthias Mullie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [18:38:28] change seems fine at first sight, but there are test failures [18:48:50] Yeah I was mostly worried about any operational impact this might have [18:49:00] These cache keys essentially disappearing all at once [18:49:18] But I don't know this code well enough to understand which cache keys this affects, how much they're used, etc [18:49:36] OTOH I guess we were considering reducing/eliminating memc usage anyway... [18:49:38] 6Collaboration-Team-Backlog, 10Echo: Minimal exposure of cross-wiki notifications in the Notification Panel - https://phabricator.wikimedia.org/T114354#1749021 (10Jdforrester-WMF) I don't think spending users' conceptual space (and developer effort) on building something we don't think is the real solution is... [18:54:10] RoanKattouw: cache keys disappearing shouldn’t be a big deal [18:55:56] OK [18:57:28] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 6WMF-Design, 7Design: Switch editor-mode button, is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Quiddity) 3NEW [18:58:34] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749062 (10Jdforrester-WMF) [19:00:47] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749066 (10Whatamidoing-WMF) I'm particularly c... [19:18:42] RoanKattouw_away, it will have an effect, but we've done it before. That's what happens when $wgFlowCacheVersion is bumped. [19:23:51] mlitn, are you working on fixing the test failures in the memcached patch. I was looking at it before lunch, but I can take something else if you want to finish it. [19:48:00] (03CR) 10Mattflaschen: [C: 04-1] "So I started working on this, and foolishly forgot to claim it." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248314 (https://phabricator.wikimedia.org/T116058) (owner: 10Matthias Mullie) [19:54:26] matt_flaschen:Database locked for http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences Do you know something about it? [19:56:50] etonkovidova, do you know what replication lag is? [19:57:28] matt_flaschen: no :( [19:58:12] (03PS1) 10Mattflaschen: Pull out isModeratedChange to check if somethign is a moderation action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248473 [19:58:38] etonkovidova, for performance reasons, read queries are done from different database servers from writes. The ones where they do the reads are called 'slaves'. [19:58:44] The writes are done to 'masters'. [19:58:54] The changes to the database are copied from the masters to the slaves. [19:59:36] The slaves are usually slightly behind; this is called replication lag, and is normal as long as it's small. [19:59:47] However, if it becomes large it will cause problems. [19:59:48] matt_flaschen: I know that ...:) I've just never seem 'Database blocked' messages before [20:00:15] Basically, MW prevents writes to the master if replication lag gets too large. It *shouldn't* happen, but that is the fail safe. [20:00:35] matt_flaschen: was scared that it somehow related to backfilling and recent schema chages [20:00:55] No, shouldn't be. [20:01:17] matt_flaschen: right - shouldn't be [20:01:42] etonkovidova, I think the changes have been done on Beta for a long time now, since that uses update.php. [20:01:46] mooeypoo, going up to a meeting room now. [20:04:20] matt_flaschen, no problems, I had an issue connecting as well [20:07:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow Browser tests fail with "Error modules: ext.thanks.flowthank." on beta - https://phabricator.wikimedia.org/T116146#1749298 (10Krinkle) >>! In T116146#1742430, @SBisson wrote: > I see a few ways to solve this: > > # Create a `jquery.findWithParen... [20:34:25] matt_flaschen: I’m not working on those test failures (I have people over, can’t really work atm) [20:35:28] mlitn, no problem, I'll take it. Have a good weekend. [21:09:26] (03PS5) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 [21:09:38] (03PS6) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [21:12:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [21:13:19] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1749461 (10Mattflaschen) >>! In T114356#1727735, @Pginer-WMF wrote: > Yes. Discarding the bundle marks all notifications as read. This aligns with the current behaviour, wh... [21:14:06] 6Collaboration-Team-Backlog, 10Echo: Implement compressed rendering of notifications - https://phabricator.wikimedia.org/T115422#1749463 (10Mattflaschen) [21:17:19] mooeypoo, turns out people already asked all those questions. [21:20:39] matt_flaschen, yeah I remember having several conversations about a few of these, but I didn't remember which of them were actually raised [21:20:47] legoktm: Is the NotificationFormatter patch ready for final review (i.e. merging)? [21:21:09] RoanKattouw: I believe so, yes. [21:21:18] OK it'll be the first thing I review then [21:23:19] mooeypoo, oh, except for what happens if you click the bundle. :) [21:24:23] it unbundles, except when it doesn't ? [21:24:31] :D [21:34:06] (03CR) 10Mattflaschen: "I'm working on fixing the test failures." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [21:38:02] (03PS7) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [22:01:15] I'm going to run out. I'll be back briefly, but probably signoff 4ish Pacific. [22:03:47] Run, Flaschen, run [22:03:56] Do I get a box of chocolate for this reference? [22:07:54] You never know what you're gonna get. [22:55:21] legoktm: matt_flaschen: re https://gerrit.wikimedia.org/r/#/c/247892/ -- recipientUserId and recipientEditCount do not need explicit converting to int? [22:57:10] looks like not [22:57:20] well, recipientEditCount already has (int) in front [22:57:29] and User::getId() appears to always return an integer [23:17:14] (03CR) 10Catrope: [C: 032] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [23:17:16] BOOM [23:17:49] legoktm: So... now I guess we need to file tasks for migrating the other 23 notification types or however many there are? [23:20:03] (03Merged) 10jenkins-bot: Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [23:20:29] (03PS2) 10Mattflaschen: Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [23:21:04] (03CR) 10Catrope: [C: 032] Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [23:21:38] Alright, going to head out for today. [23:22:09] (03CR) 10jenkins-bot: [V: 04-1] Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [23:22:50] Or not [23:23:53] It's just "invalid argument supplied for foreach()" [23:23:59] But how the hell does your change cause that... [23:24:13] RoanKattouw, don't know, unless it's decoding the keys somewhere... [23:24:18] Oh, ahm [23:24:19] I think I know [23:24:22] I only re-ran the failing test, that's why I didn't see it locally. [23:24:24] I think . binds too loosely [23:24:35] No, wait, it couldn't [23:24:42] This can't be a syntactic ambiguity thing, can it [23:25:19] RoanKattouw, I don't think so, or FeatureIndexTest would fail, and that at least I fixed. [23:25:34] Not without a different time-wasting syntax error, though. [23:28:57] RoanKattouw: yay. yes, but lets hold off on merging anything until after the branch cut [23:29:12] OK [23:29:17] Does "anything" include: [23:29:22] [16:20] grrrit-wm (Merged) jenkins-bot: Clean up and refactor formatting system [extensions/Echo] - https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: Legoktm) [23:29:30] :P [23:29:33] er no [23:29:34] (Merged at 4:20 no less) [23:29:36] I meant other conversions :P [23:29:40] haha OK yeah sure [23:29:45] I did test both of the notif types you converted [23:30:05] But also, let's make a list of these, file tasks for them, and spread that work among multiple people [23:31:14] That way you don't have to do all of them, other people get their feet wet with the new system, and we find out if the formatter API is something other people can program against [23:31:20] yeah [23:31:27] I can do that if you don't already have a list of them handy [23:31:47] I'm going to work on implementing the rest of the formatters, specifically email since it has some weird not-template system [23:31:52] yes please :) [23:32:05] Oh yes, email and Special:Notifs [23:32:22] Ug, we have two PagerTest.php [23:32:54] WTF really? [23:33:11] (Relatedly, TIL we have servers named terbium, ytterbium, and erbium) [23:33:54] Merging them [23:37:36] (03PS1) 10Mattflaschen: Merge two PagerTest together [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248570 [23:38:23] (03PS2) 10Mattflaschen: Merge two PagerTest together [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248570 [23:41:07] Oh never mind, those were already there, just "errors" rather than "failures". [23:41:14] it would be really nice if we had better PHPUnit output formatting on Jenkins... [23:41:33] But... wait, I didn't see any failures. Or did I just not look closely enough? [23:42:20] (03CR) 10Catrope: [C: 032] Merge two PagerTest together [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248570 (owner: 10Mattflaschen) [23:43:01] RoanKattouw, there were 2 failures and 8 errors in patch set 1. I fixed only the failure since I didn't notice the errors due to the crappy formatting. [23:43:06] only the failures [23:43:09] Ooh I see [23:43:24] And when I ran it locally I only ran the file with failures to save time. [23:44:47] (03Merged) 10jenkins-bot: Merge two PagerTest together [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248570 (owner: 10Mattflaschen) [23:50:26] (03PS3) 10Mattflaschen: Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [23:52:17] Oooh [23:52:19] I see [23:52:46] (03CR) 10Catrope: [C: 032] Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh) [23:55:06] (03Merged) 10jenkins-bot: Ensure memcached keys are valid ASCII [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248368 (owner: 10Ori.livneh)