[00:06:22] <matt_flaschen>	 mooeypoo, are BoardDescriptionWidget, EditPostWidget, EditTopicSummaryWidget, NewTopicWidget, and ReplyWidget the only ones that accept user input to be saved?
[00:07:17] <mooeypoo>	 matt_flaschen, uhm... I think so? I need to go over the other widgets to be sure. Why?
[00:08:44] <matt_flaschen>	 mooeypoo, you don't need to check, I'm pretty sure.  Just wondering if you could think of any others of the top of your head.
[00:08:51] <matt_flaschen>	 For the CAPTCHA patch which I'm finally finishing.
[00:10:00] <mooeypoo>	 Yeah, I think those are the only ones
[00:13:26] <matt_flaschen>	 Got to go.  I'll be back on later at home.
[01:40:09] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Add $flags to set() to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247782 (owner: 10Aaron Schulz)
[01:42:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add $flags to set() to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247782 (owner: 10Aaron Schulz)
[08:02:54] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: moderated content inconsistencies - https://phabricator.wikimedia.org/T60725#1744889 (10Nemo_bis) >>! In T60725#1739813, @Mattflaschen wrote: > @Nemo_bis, this is when the whole topic was deleted using Flow's delete topic UI?  No idea. As a user I don't care what butt...
[08:07:26] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1744893 (10Pginer-WMF) Thanks @MGChecker and @PerfektesChaos for describing your scenario.  From what I understand alerts are perceived as high priority information that requi...
[08:28:20] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#1744927 (10Pginer-WMF) > I think some of the most basic settings sholud be handled via Special:Preferences, because there is no sense to change the Settings I mean via the...
[11:12:47] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1745155 (10He7d3r) Personally, I'm leaning towards simply breaking eventual links to the old addresses of these LQT discussion pages just so that we can have Flow t...
[11:14:17] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7Browser-Support-Firefox, 7Browser-Support-Google-Chrome: Offer system tray area desktop notifications - https://phabricator.wikimedia.org/T116243#1745156 (10Aklapper)
[12:55:46] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1745303 (10MGChecker) I don't think it's necessary to split the panel in too, if Notifications are bundled and there is a clearer panel in general, but I thinkk the first opti...
[13:10:48] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745319 (10jcrespo)
[13:48:28] <matt_flaschen>	 Going to try to get my USB -> Ethernet adapter working.  The wifi is somewhat unreliable in the ground floor phone booth area here.
[13:48:40] <matt_flaschen>	 I'm taking the wifi down while testing that.
[13:52:24] <matt_flaschen>	 That was easier than expected (plug and play).  I tried it once before and it didn't work, but that must have been for other reasons.
[13:54:18] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745346 (10jcrespo) I've applied the change to flowdb schema. This is the new st...
[14:04:22] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745352 (10jcrespo) This is officewiki now:  ``` CREATE TABLE `flow_ext_ref` (...
[14:05:15] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745354 (10jcrespo) 5Open>3Resolved
[14:07:21] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745360 (10Mattflaschen) >>! In T111084#1745346, @jcrespo wrote: > I've seen no...
[14:07:41] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change, 7WorkType-NewFunctionality: Run patch-reference_wiki-phase5.sql in production - https://phabricator.wikimedia.org/T113778#1745361 (10Mattflaschen)
[14:07:42] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745362 (10Mattflaschen)
[14:11:44] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1745382 (10jcrespo) Now that T111084 has been applied, please ping me to proceed with this when you are r...
[14:16:59] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1745387 (10Mattflaschen)
[14:17:01] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1745386 (10Mattflaschen)
[14:17:02] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1745388 (10Mattflaschen)
[15:58:28] <grrrit-wm>	 (03PS4) 10Mattflaschen: Refactor CAPTCHA support into data model and widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) 
[15:59:29] <grrrit-wm>	 (03CR) 10Mattflaschen: "Thanks for the recommendations, Stephane. I think it came together pretty well." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen)
[16:00:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor CAPTCHA support into data model and widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen)
[16:03:02] <grrrit-wm>	 (03PS5) 10Mattflaschen: Refactor CAPTCHA support into data model and widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) 
[16:41:27] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: Navpopups doesn't function with Flow links - https://phabricator.wikimedia.org/T65713#1745745 (10Trizek-WMF)
[16:49:18] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 2 others: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#1745769 (10demon)
[16:49:29] <grrrit-wm>	 (03CR) 10Mooeypoo: Add an APIHandler to Echo notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 (owner: 10Mooeypoo)
[16:49:41] <grrrit-wm>	 (03PS3) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 
[16:52:28] <grrrit-wm>	 (03CR) 10Mooeypoo: [WIP^n] Create a notifications widget demo (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo)
[16:52:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 (owner: 10Mooeypoo)
[16:54:50] <grrrit-wm>	 (03PS2) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 
[16:55:13] <grrrit-wm>	 (03PS3) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 
[16:57:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo)
[16:58:02] <grrrit-wm>	 (03PS4) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 
[16:58:13] <grrrit-wm>	 (03PS4) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 
[16:58:33] <grrrit-wm>	 (03PS1) 10Sbisson: Depend on jquery.findWithParent from Core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248070 (https://phabricator.wikimedia.org/T116146) 
[17:01:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo)
[17:01:41] <grrrit-wm>	 (03CR) 10Sbisson: [C: 031] Refactor CAPTCHA support into data model and widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen)
[17:01:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Depend on jquery.findWithParent from Core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248070 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson)
[17:05:16] <grrrit-wm>	 (03PS1) 10Sbisson: Depend on jquery.findWithParent from Core [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/248072 (https://phabricator.wikimedia.org/T116146) 
[17:06:05] <grrrit-wm>	 (03CR) 10Sbisson: [C: 04-1] "Can only be merged after I48450d1518ac4e0cb4f0bd5f39f4c060f72f5f9e" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248070 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson)
[17:06:21] <grrrit-wm>	 (03CR) 10Sbisson: [C: 04-1] "Can only be merged after I48450d1518ac4e0cb4f0bd5f39f4c060f72f5f9e" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/248072 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson)
[17:11:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Depend on jquery.findWithParent from Core [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/248072 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson)
[17:12:36] <grrrit-wm>	 (03CR) 10Siebrand: [WIP^n] Create a notifications widget demo (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo)
[17:13:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo)
[17:33:38] <quiddity>	 mooeypoo, standup?
[17:54:13] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1745953 (10Quiddity) p:5High>3Unbreak! Raising priority per discussion in standup
[17:57:07] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1745960 (10Mattflaschen) a:5matthiasmullie>3Mattflaschen
[17:57:30] <grrrit-wm>	 (03Abandoned) 10EBernhardson: [WIP] Make events temporarily cancelable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163289 (owner: 10EBernhardson)
[18:02:15] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Allow revision deletion for Flow edits - https://phabricator.wikimedia.org/T116301#1745994 (10Mattflaschen) 3NEW
[18:05:12] <grrrit-wm>	 (03PS1) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[18:06:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo)
[18:07:05] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[18:08:34] <grrrit-wm>	 (03PS3) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[18:10:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo)
[18:27:50] <mlitn>	 matt_flaschen: for anti-spam
[18:28:55] <mlitn>	 I’m mostly seeing:
[18:29:20] <mlitn>	 * huge walls of repetitive text (e.g. https://www.mediawiki.org/w/index.php?title=Topic:Sr78dx9nno73ljno&topic_showPostId=sr78dxab1iptocec#flow-post-sr78dxab1iptocec)
[18:29:46] <mlitn>	 * very short, nonsensical words (e.g. https://www.mediawiki.org/w/index.php?title=Topic:Qp4y52jkpp5457s7&topic_showPostId=sr78drirsdv7ftcu#flow-post-sr78drirsdv7ftcu)
[18:30:39] <mlitn>	 * or even “normal” content (e.g. https://www.mediawiki.org/w/index.php?title=Topic:Sr5qtdkciporq55w&topic_showPostId=sr5qtdl7p6dqhvhg#flow-post-sr5qtdl7p6dqhvhg)
[18:31:09] <mlitn>	 that last one is going to be near-impossible to block, but is probably not the biggest problem
[18:31:40] <mlitn>	 for the huge walls of text, I would suggest blocking large texts with a low percentage of stopwords usage
[18:34:40] <matt_flaschen>	 mlitn, yeah, that could help.  I'll check if that's AbuseFilter-able.  We could special case it, but I'd rather focus on giving the community tools.
[18:34:56] <mlitn>	 rcount(“a|an|the|and|are|…”, new_wikitext) & count(“ “, new_wikitext) & some math should do that
[18:35:20] <mlitn>	 what kind of tool are you thinking about?
[18:35:56] <mlitn>	 (AbuseFilter seems to be that kind of tool?)
[18:36:03] <matt_flaschen>	 Probably https://phabricator.wikimedia.org/T116058 , https://phabricator.wikimedia.org/T115695 , https://phabricator.wikimedia.org/T115128 in that order.
[18:36:15] <matt_flaschen>	 Yeah, I don't mean like a new tool from scratch.
[18:36:34] <mlitn>	 ah, yeah, those need to be fixed
[18:37:14] <mlitn>	 I was under the impression we urgently needed filters to stop the current spam onslaught asap :p
[18:39:03] <matt_flaschen>	 mlitn, yeah, I'm going to try that first.
[18:56:36] <matt_flaschen>	 mlitn, quiddity, so far I've got:
[18:58:47] <matt_flaschen>	 https://phabricator.wikimedia.org/P2219
[18:59:26] <matt_flaschen>	 Does that look right (I will change the real one to use new_wikitext, and probably a different percentage), and can I test it at https://www.mediawiki.org/wiki/Special:AbuseFilter/tools ?
[19:00:29] <matt_flaschen>	 Oh, I see it's not supposed to end with a semi-colon.
[19:05:14] <matt_flaschen>	 quiddity, do you know AbuseFilter syntax, or know someone who might be around and willing to pair on it?
[19:05:34] <quiddity>	 matt_flaschen, I don't.  I thought it was just regex?
[19:07:20] <quiddity>	 matt_flaschen, any of the folk who have edited the existing one, would probably be best. https://www.mediawiki.org/wiki/Special:AbuseFilter/history/41
[19:07:55] <matt_flaschen>	 No, it's a language.  regex is just one of the features.
[19:11:02] <matt_flaschen>	 mlitn, are you still around?
[19:11:11] <mlitn>	 matt_flaschen: yeah
[19:11:53] <matt_flaschen>	 mlitn, can you take a look at https://phabricator.wikimedia.org/P2219 ?  I'm trying to test it at https://www.mediawiki.org/wiki/Special:AbuseFilter/tools (hence fake input), but it doesn't seem to be working.
[19:12:00] <quiddity>	 matt_flaschen, re: testing, I think not, per https://phabricator.wikimedia.org/T115128
[19:12:09] <quiddity>	 (but I might be misunderstanding)
[19:12:40] <matt_flaschen>	 quiddity, yeah, but I'm not testing it on a real edit, just fake input (but I don't know for certain if that's possible)
[19:13:46] <mlitn>	 matt_flaschen: wow, is AbuseFilter able to interpret stuff that complex?
[19:13:50] <mlitn>	 like variables and stuff
[19:14:08] <mlitn>	 or is that just pseudo code?
[19:14:48] <matt_flaschen>	 mlitn, it says it supports variables: https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format#Variables .
[19:14:59] <mlitn>	 damn nice :)
[19:15:10] <matt_flaschen>	 Nice if anyone knows how to use them... :)
[19:15:27] <quiddity>	 Glaisher, hi. Would you be awake/available to help matt_flaschen with AbuseFilter syntax? Or know someone who would be good (and available) to talk to?
[19:15:28] <mlitn>	 or knows they exist :)
[19:17:20] <mlitn>	 if I evaluate, stopword_fraction seems to equal 1
[19:17:35] <mlitn>	 stopword_fraction) == 1
[19:17:44] <mlitn>	 seems to evaluate to true
[19:17:59] <mlitn>	 not sure exactly what it validates against though, by default
[19:18:25] <matt_flaschen>	 mlitn, yeah, but it shouldn't really matter since I'm not using the real fields.  Have you used that test interface before?
[19:18:56] <mlitn>	 not this exact one
[19:19:10] <mlitn>	 but it’s possible to evaluate against a certain revision
[19:19:17] <mlitn>	 (well, not Flow revisions, but other stuff)
[19:19:18] <mlitn>	 let me check
[19:21:05] <matt_flaschen>	 Oh, it uses integer division (still doesn't explain why it equals 1...)
[19:22:21] <matt_flaschen>	 How the heck is stopword_count 3?
[19:23:09] <matt_flaschen>	 Forgot I need word boundaries.
[19:24:18] <mlitn>	 ah, yeah
[19:24:26] <mlitn>	 bar & baz both have ‘a’ :p
[19:25:01] <matt_flaschen>	 Got it now. :)
[19:25:49] <mlitn>	 might also want to check that user is not autoconfirmed, or account is younger than a certain period or something?
[19:26:20] <mlitn>	 and that the text has a certain length (things like “good idea” are valid but have no stopword)
[19:26:41] <mlitn>	 it should probably only start checking stopwords if text if > 50 words or so? idk
[19:27:12] <matt_flaschen>	 mlitn, sounds about right (and autoconfirmed will probably do).  At least 5% stopwords?
[19:27:19] <matt_flaschen>	 Could probably go higher, don't know.
[19:27:36] <mlitn>	 ehm
[19:27:56] <mlitn>	 let’s start with 5
[19:28:02] <mlitn>	 and monitor
[19:28:12] <mlitn>	 if the filter doesn’t block enough, we can increase percentage
[19:28:20] <mlitn>	 if it blocks too much, it’ll eventually auto-disable
[19:28:30] <legoktm>	 is flow currently enforcing rate limits?
[19:28:34] <grrrit-wm>	 (03PS1) 10Sbisson: Display "Unknown topic" when the requested topic is from another wiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248100 (https://phabricator.wikimedia.org/T113311) 
[19:28:39] <legoktm>	 i.e. $user->pingLimiter() / $wgRateLimits?
[19:29:54] <matt_flaschen>	 legoktm, I don't think so.  Do you know if core does/where it is?
[19:30:06] <matt_flaschen>	 It looks like the AbuseFilters tend to use edit count, so I'll just use that.
[19:30:37] <mlitn>	 I’m not aware of any rate limits in flow
[19:33:50] <legoktm>	 matt_flaschen: in EditPage.php, look for $wgUser->pingLimiter() (or any other call to that, like the one in Thanks)
[19:34:12] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Exception when viewing https://es.wikiquote.org/wiki/Tema:Sobaaiky57zs7py7 - https://phabricator.wikimedia.org/T113311#1746257 (10SBisson) The uploaded patch doesn't do redirect. It will display "Unknown topic" when the topic is unknown on this wiki, wh...
[19:36:33] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Echo is passing wrong type for eventId - https://phabricator.wikimedia.org/T116205#1746285 (10SBisson) a:3Legoktm
[19:38:00] <legoktm>	 I think we should just increment it on every post
[19:38:06] * legoktm will put up a patch
[19:39:18] <legoktm>	 can I make it a spamfilter?
[19:39:25] <legoktm>	 those are only called on save right?
[19:39:40] <matt_flaschen>	 legoktm, yeah.
[19:46:08] <grrrit-wm>	 (03PS1) 10Legoktm: Add RateLimits SpamFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248117 
[19:46:11] <grrrit-wm>	 (03PS1) 10Legoktm: Run contentlength filter first, as it's the fastest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248118 
[19:46:12] <legoktm>	 haven't tested ^
[19:46:25] <matt_flaschen>	 mlitn, quiddity, I tested it and it triggered on a post as expected.  I'll put it on "prevent the action" but not yet have it block.
[19:48:00] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1746302 (10Mattflaschen) Matthias and I wrote https://www.mediawiki.org/wiki/Special:AbuseFilter/43 .  It's currently just on "Prevent the user from performing the action in quest...
[19:48:59] <mlitn>	 matt_flaschen: yeah, non-blocking sounds fine
[19:50:09] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "I'll amend and test." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248117 (owner: 10Legoktm)
[19:51:02] <legoktm>	 >.>
[19:52:27] <mlitn>	 seems to work at first sight
[19:52:48] <mlitn>	 although the warning message shows html tags :p
[19:53:42] <matt_flaschen>	 Hmm, didn't work for me, not sure why yet.
[19:53:49] <legoktm>	 I guess we need a custom message then?
[19:54:06] <legoktm>	 matt_flaschen: did you set $wgRateLimits? and use a user without the 'noratelimits' right?
[19:54:29] <matt_flaschen>	 Yes, I set it, tested with anon.
[19:54:57] <matt_flaschen>	 $wgRateLimits['edit']['newbie'] = array( 1, 60 );
[19:55:38] <matt_flaschen>	 Newbie might only apply for logged in.
[19:55:41] <matt_flaschen>	 I'll try IP.
[19:56:39] <matt_flaschen>	 mlitn, worked for me now, no tags.  Which action did you use?  I used 'reply'.
[19:56:47] <matt_flaschen>	 legoktm, probably a client-side issue.
[19:56:50] <mlitn>	 also reply
[19:57:09] <mlitn>	 let me check again
[19:57:28] <matt_flaschen>	 Hmm, works for me both inline and top-level.
[19:58:41] <mlitn>	 damn, one of the other filters has blocked me already :D
[19:59:06] <matt_flaschen>	 LOL, locally?  Which one.
[20:00:12] <grrrit-wm>	 (03PS1) 10Sbisson: Do not hide menu behind page footer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248154 (https://phabricator.wikimedia.org/T116077) 
[20:00:28] <grrrit-wm>	 (03PS2) 10Mattflaschen: Add RateLimits SpamFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248117 (owner: 10Legoktm)
[20:00:56] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 031] "LGTM, waiting for Matthias to confirm we're not exposing HTML markup to user. I don't see that, though." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248117 (owner: 10Legoktm)
[20:02:06] <mlitn>	 no, not locally, mw.org
[20:02:13] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1746339 (10SBisson) a:3SBisson
[20:02:26] <mlitn>	 the exposed html is probably some mw-specific abusefilter i18n msg override
[20:03:36] <grrrit-wm>	 (03PS2) 10Mattflaschen: Run contentlength filter first, as it's the fastest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248118 (owner: 10Legoktm)
[20:03:56] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 031] Run contentlength filter first, as it's the fastest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248118 (owner: 10Legoktm)
[20:04:29] <matt_flaschen>	 mlitn, oh, I thought you were testing legoktm's RateLimits filter.
[20:04:46] <mlitn>	 oh no, I was testing your AbuseFilter :)
[20:04:54] <wikibugs>	 3Collaboration-Team-Current, 10Flow: 'wgTitle' and 'wgPageName' are null on history of Flow pages - https://phabricator.wikimedia.org/T113833#1746350 (10SBisson) This appears to be fixed. Could you confirm @legoktm or @etonkovidova?
[20:05:34] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Never mind, I misunderstood what he was testing. This works fine for me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248117 (owner: 10Legoktm)
[20:06:41] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] Run contentlength filter first, as it's the fastest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248118 (owner: 10Legoktm)
[20:08:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add RateLimits SpamFilter [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248117 (owner: 10Legoktm)
[20:08:50] <wikibugs>	 3Collaboration-Team-Current, 10Flow: 'wgTitle' and 'wgPageName' are null on history of Flow pages - https://phabricator.wikimedia.org/T113833#1746370 (10Etonkovidova) https://www.mediawiki.org/w/index.php?title=User_talk:Shirayuki&action=history&debug=true   mw.config.get('wgTitle')  and mw.config.get( 'wgPage...
[20:09:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Run contentlength filter first, as it's the fastest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248118 (owner: 10Legoktm)
[20:11:30] <grrrit-wm>	 (03PS1) 10Mattflaschen: Add RateLimits SpamFilter [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248229 
[20:14:35] <wikibugs>	 3Collaboration-Team-Current, 10Flow: 'wgTitle' and 'wgPageName' are null on history of Flow pages - https://phabricator.wikimedia.org/T113833#1746385 (10SBisson) 5Open>3Resolved a:3SBisson
[20:14:44] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: 'wgTitle' and 'wgPageName' are null on history of Flow pages - https://phabricator.wikimedia.org/T113833#1746389 (10SBisson)
[20:15:47] <matt_flaschen>	 I scheduled a SWAT for the RateLimits thing (plus anything else we come up with in the next 3 hours :) ).
[20:16:45] <matt_flaschen>	 mooeypoo, can you be the designated SWAT-watcher?  It varies (they officially close at 6), but I might have to leave 7-ish or even earlier.
[20:17:04] <mooeypoo>	 matt_flaschen, what does that entail?
[20:18:04] <matt_flaschen>	 mooeypoo, I list you at https://wikitech.wikimedia.org/wiki/Deployments#Thursday.2C.C2.A0October.C2.A022 then you have to in #wikimedia-operations from 4 PM to 5 PM your time.  And test the deployment afterwards (at least to make sure it doesn't blow up).
[20:20:15] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1746404 (10Mattflaschen)
[20:20:35] <matt_flaschen>	 quiddity, I'm going to do https://phabricator.wikimedia.org/T116058 ("Deleted topics deleted edits shouldn't appear in recent changes") next, unless you have another priority.
[20:21:01] <quiddity>	 sounds good to me
[20:21:37] <mooeypoo>	 matt_flaschen, I can do that. Do I need to know how to test that patch specifically in production?
[20:22:24] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow Browser tests fail with "Error modules: ext.thanks.flowthank." on beta - https://phabricator.wikimedia.org/T116146#1746410 (10Legoktm) >>! In T116146#1742430, @SBisson wrote: >   # Create a `jquery.findWithParent` module in Core and have both Flow...
[20:23:32] <matt_flaschen>	 mooeypoo, thanks, I appreciate it.
[20:24:04] <matt_flaschen>	 mooeypoo, if you want to test it, the rate limit on MediaWiki.org is 8/minute for anons.
[20:24:13] <matt_flaschen>	 So, uh, click fast. :)
[20:24:19] <matt_flaschen>	 Or you can write a curl loop.
[20:24:35] <mooeypoo>	 rofl
[20:24:41] <mooeypoo>	 okay, I'll verify nothing breaks, at least
[20:24:49] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow Browser tests fail with "Error modules: ext.thanks.flowthank." on beta - https://phabricator.wikimedia.org/T116146#1746418 (10SBisson) >3 is probably easiest, I'd rather not do 2, and 1 could be a good idea if it meets core guidelines. I've impleme...
[20:24:52] <mooeypoo>	 hm, I wonder if I can run the browser tests in production
[20:25:22] <matt_flaschen>	 It's actually doable.  Someone just has to queue up 9 reply boxes, then click them all in close succession.  Doesn't matter how long it takes to type.
[20:25:29] <matt_flaschen>	 mooeypoo, not allowed for writes IIRC.
[20:25:40] <legoktm>	 stephanebisson: sounds good :)
[20:36:28] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 5Patch-For-Review: Don't use a * selector to set box-sizing in Flow - https://phabricator.wikimedia.org/T96513#1746454 (10SBisson) 5Open>3Resolved a:3SBisson
[20:42:43] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: Flow: "Deleting a topic" browser test is confused by Locked topic - https://phabricator.wikimedia.org/T74993#1746479 (10SBisson) 5Open>3Resolved a:3SBisson
[20:44:16] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#1746490 (10SBisson)
[20:47:08] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: It's too easy to accidentally edit when logged-out - https://phabricator.wikimedia.org/T60696#1746502 (10SBisson) We now display a big blue warning when you're logged out. Does it address the issue?  {F2757879}
[20:54:13] <grrrit-wm>	 (03PS4) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[20:55:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo)
[20:56:51] <grrrit-wm>	 (03PS5) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[20:57:25] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Remove broken calls to $( ... ).flow - https://phabricator.wikimedia.org/T85392#1746540 (10SBisson) 5Open>3Invalid a:3SBisson Not valid anymore.
[20:58:26] <grrrit-wm>	 (03PS6) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[20:59:35] <grrrit-wm>	 (03PS7) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[21:00:51] <mooeypoo>	 hm. okay, I think this is done. I'm going to run all of Flow's browser tests
[21:01:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo)
[21:05:25] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1746591 (10Mattflaschen)
[21:06:20] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Hide all actions connected to deleted boards from RC and watchlist - https://phabricator.wikimedia.org/T116326#1746598 (10Mattflaschen)
[21:15:33] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Topic without history link - https://phabricator.wikimedia.org/T94813#1746633 (10SBisson) I also see a history link on https://fr.wikipedia.org/wiki/Sujet:Seonrm6aomfui2nc Can we close this?
[21:16:26] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Topic without history link - https://phabricator.wikimedia.org/T94813#1746644 (10Mattflaschen) 5Open>3Resolved
[21:16:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Topic without history link - https://phabricator.wikimedia.org/T94813#1173180 (10Mattflaschen) Please reopen if it occurs again.
[21:20:42] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 7user-notice: Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1746655 (10Quiddity) I don't think this warrants a mention in Tech/News.
[21:20:49] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1746656 (10Quiddity)
[21:23:04] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow pages without history have "undefined" message - https://phabricator.wikimedia.org/T91200#1746664 (10SBisson)
[21:23:06] <wikibugs>	 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-A-2015-05-06, 10Flow, 5Patch-For-Review: undefined Flow history - https://phabricator.wikimedia.org/T96910#1746666 (10SBisson)
[21:25:57] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: No placeholder text in Flow lock topic textarea - https://phabricator.wikimedia.org/T86377#1746683 (10SBisson) 5Open>3Invalid a:3SBisson "Lock" doesn't exist anymore. It was replace by Resolve/Reopen and both have placeholders when they prompt for a topic summary.
[21:27:18] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Primary key error running Flow update.php - https://phabricator.wikimedia.org/T86992#1746687 (10SBisson) Is there anything that needs to be done here?
[21:34:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Primary key error running Flow update.php - https://phabricator.wikimedia.org/T86992#1746700 (10Mattflaschen) 5Open>3declined a:3Mattflaschen Unlikely to affect production.
[21:34:54] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Primary key error running Flow update.php - https://phabricator.wikimedia.org/T86992#1746703 (10Mattflaschen) a:5Mattflaschen>3None
[21:41:25] <grrrit-wm>	 (03PS8) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[21:43:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo)
[21:47:16] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: "Lock topic" preview doesn't work (error msg: "Content parameter must be set") - https://phabricator.wikimedia.org/T75006#1746726 (10SBisson) 5Open>3Invalid a:3SBisson Lock/Unlock do not exist anymore.
[21:48:42] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1746732 (10Etonkovidova) 1) General regression on test.wikipedia.org 2) Recent s...
[21:49:59] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1746734 (10Etonkovidova) Checked  - see comments on https://phabricator.wikimedia.org/T111084.
[21:50:58] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1746745 (10SBisson) Which one is better, "a day ago" or "1 day ago"? @pginer-wmf
[21:51:25] <grrrit-wm>	 (03PS9) 10Mooeypoo: [wip] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[22:04:41] <matt_flaschen>	 quiddity, if a topic is hidden (not deleted or suppressed), should the posts within be hidden from RC and watchlist?
[22:06:15] <quiddity>	 matt_flaschen, no, because anyone (incl non-explicitly-trusted editors) can hide (similar to revert) hence it needs to be easily reviewable.
[22:06:36] <matt_flaschen>	 quiddity, that was where I was leaning as well.
[22:06:47] <matt_flaschen>	 Thanks
[22:06:50] <quiddity>	 :)
[22:07:36] <wikibugs>	 6Collaboration-Team-Backlog, 6Language-Engineering, 10Parsoid, 10RESTBase, and 2 others: Dummy version number bump for Parsoid html to nail down process for making changes to HTML format - https://phabricator.wikimedia.org/T98540#1746824 (10GWicke)
[22:40:10] <grrrit-wm>	 (03PS10) 10Mooeypoo: Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 
[23:07:27] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 032] Add RateLimits SpamFilter [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248229 (owner: 10Mattflaschen)
[23:09:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add RateLimits SpamFilter [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/248229 (owner: 10Mattflaschen)
[23:14:53] <mooeypoo>	 matt_flaschen, I see you're still around - can I run out for a couple of quick minutes, or do you need me to stick around right now?
[23:19:05] <matt_flaschen>	 mooeypoo, you should be fine to head out.
[23:20:00] <matt_flaschen>	 mooeypoo, clicking fast was a little more challenging than anticipating, since I forgot the whole topic re-renders (so all the text boxes I laid out disappeared).  Luckily I have a super-fast gaming mouse. ;)
[23:20:14] <matt_flaschen>	 I was indeed able to verify the limit.
[23:20:39] <mooeypoo>	 haha
[23:20:49] <mooeypoo>	 I was planning to try and have a few tabs open
[23:20:59] <mooeypoo>	 one next to the other... but I'm not sure I'm fast enough
[23:28:11] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1747087 (10Mattflaschen) https://gerrit.wikimedia.org/r/#/c/248117/ will hopefully also help with this.  It adds a ping-limiter.  Currently it uses the standard 'edit' limiter, wh...
[23:54:06] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: It's too easy to accidentally edit when logged-out - https://phabricator.wikimedia.org/T60696#1747126 (10He7d3r) Will that warning appear when you attempt to save and edit? (e.g. if you start writing a comment, and is logged out before submitting it, and then tries to...