[00:23:18] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Categories flash and disappear on Flow pages - https://phabricator.wikimedia.org/T115411#1737140 (10Etonkovidova) The main issue is fixed - but Categories at the bottom of...
[00:38:55] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Categories always arranged in alphanumeric ascending order - https://phabricator.wikimedia.org/T115963#1737190 (10Etonkovidova) 3NEW
[03:14:41] <grrrit-wm>	 (03PS2) 10Mattflaschen: WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[03:14:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[03:18:00] <grrrit-wm>	 (03PS3) 10Mattflaschen: WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[03:20:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[03:27:38] <matt_flaschen>	 See you tomorrow.
[06:43:05] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: moderated content inconsistencies - https://phabricator.wikimedia.org/T60725#1737375 (10Nemo_bis) 5Resolved>3Open This bug is still current. Deleted pages must not be shown in watchlist, yet they are.  {F2739047}
[07:21:31] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: Personal feed v1 (design) - https://phabricator.wikimedia.org/T100858#1737399 (10Nemo_bis)
[07:28:01] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Topic namespace can't be (de)selected in recent changes - https://phabricator.wikimedia.org/T115971#1737407 (10Nemo_bis) 3NEW
[08:07:42] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[10:25:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1737747 (10Pginer-WMF)
[11:11:40] <grrrit-wm>	 (03CR) 10Sbisson: "Do you want to add tests for "category: vs. categories:" as mentioned by Roan or can I merge this as-is?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246794 (owner: 10Mooeypoo)
[11:44:37] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Exception when viewing https://es.wikiquote.org/wiki/Tema:Sobaaiky57zs7py7 - https://phabricator.wikimedia.org/T113311#1737903 (10SBisson) a:3SBisson
[12:44:58] <grrrit-wm>	 (03PS2) 10Sbisson: Avoid loading the old editor system if we can. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247028 (owner: 10Catrope)
[12:49:21] <grrrit-wm>	 (03CR) 10Sbisson: "Are we now ready to completely remove the old editor system?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/244369 (https://phabricator.wikimedia.org/T114448) (owner: 10Mooeypoo)
[12:50:30] <grrrit-wm>	 (03CR) 10Sbisson: "I guess this change is no longer relevant after https://gerrit.wikimedia.org/r/#/c/244369/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247028 (owner: 10Catrope)
[12:51:27] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1738028 (10Pginer-WMF) > The user will see the highest priority at a glance, and may put attention only at red or yellow level, reading less important things at coffee break....
[12:55:25] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1738031 (10Pginer-WMF) >>! In T115845#1736592, @MGChecker wrote: > I think it would be the best if the user could decide himself which type of messages has which priority. In...
[12:57:47] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Wrap body-only HTML in <body> tags when parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247027 (https://phabricator.wikimedia.org/T115362) (owner: 10Catrope)
[12:59:06] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Prefill loads all template contents, including <noinclude> elements - https://phabricator.wikimedia.org/T116002#1738035 (10Trizek-WMF) 3NEW
[12:59:18] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Make sure mw-vagrant Flow role creates users/groups required for Flow browser tests - https://phabricator.wikimedia.org/T115515#1738043 (10SBisson) What is the blocker here?
[12:59:21] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Prefill loads all template contents, including <noinclude> elements - https://phabricator.wikimedia.org/T116002#1738045 (10Trizek-WMF)
[12:59:22] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1738044 (10Trizek-WMF)
[13:00:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: Wrap body-only HTML in <body> tags when parsing [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247027 (https://phabricator.wikimedia.org/T115362) (owner: 10Catrope)
[13:04:33] <grrrit-wm>	 (03CR) 10Sbisson: "23:02:56 OK, but incomplete or skipped tests!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246798 (owner: 10Mattflaschen)
[13:44:54] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1738119 (10Aklapper) This task has [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | "Unbre...
[14:00:50] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: [betalabs]Opening VE produces dmDoc.getNearestCursorOffset is not a function - https://phabricator.wikimedia.org/T115507#1738161 (10SBisson)
[14:01:51] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Talk Flow pages do not display correct info in mw-search-result-data - https://phabricator.wikimedia.org/T114169#1738168 (10SBisson)
[14:02:11] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Notifications display references to [No page] if page was deleted - https://phabricator.wikimedia.org/T114140#1738171 (10SBisson)
[14:04:23] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1738181 (10SBisson)
[14:05:20] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Community-Advocacy, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1738185 (10SBisson)
[14:52:09] <grrrit-wm>	 (03PS1) 10Matthias Mullie: BagOStuff::delete no longer accepts 2 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247574 
[14:52:12] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Stop reading from DB_MASTER [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247575 (https://phabricator.wikimedia.org/T94028) 
[15:05:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#1738438 (10Pginer-WMF)
[15:07:25] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1738444 (10matthiasmullie) Implementing WANObjectCache is likely going to be more work than I had anticipated. We use BufferedBagOStuff, whi...
[15:50:57] <roux_>	 hello -- is this the right place to talk about the flow project? was curious if it were possible to deploy this to a non-wmf wiki
[15:55:03] <MatmaRex>	 it should be possible
[15:55:39] <MatmaRex>	 (but probably not as easy as with other extensions)
[16:27:42] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7Wikimedia-log-errors: "Title::newFromTitle: $text must be a string" from Echo - https://phabricator.wikimedia.org/T116034#1738844 (10Krinkle) 3NEW
[17:03:47] <etonkovidova>	 mooeypoo: https://integration.wikimedia.org/ci/view/BrowserTests/view/Echo/job/browsertests-Echo-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/
[17:27:18] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Broken Echo notification popup widget in testwiki - https://phabricator.wikimedia.org/T114853#1739121 (10Etonkovidova) Checked in betalabs and https://test.wikipedia.org/...
[17:27:28] <Krenair>	 https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&action=undo-edit-header&header_startId=sp7z59lvjge0dor9&header_endId=sr58lsggsri2r6xc
[17:27:41] <Krenair>	 form starts to load but then disappears
[17:33:03] <mattflaschen1>	 My internet stopped responding, so I had to rejoin the network.
[17:40:13] <mattflaschen1>	 Standup summary: Topic title is almost done, have a PHPUnit test and need to finish browser test.  Will also work on Nick's thing.
[17:50:13] <Glaisher>	 https://www.mediawiki.org/wiki/Special:NewPages?namespace=2600&tagfilter=&username= Is this supposed to be like this?
[17:50:41] <Glaisher>	 I think it's lying..
[17:57:00] <legoktm>	 Glaisher: Maybe flow isn't adding RC_NEW events to the table?
[17:57:42] <Glaisher>	 probably
[17:59:22] <mattflaschen1>	 legoktm, yes, we use EDIT_SUPPRESS_RC when creating the core-level pages.  Probably to avoid redundant RC entries.
[18:00:10] <mattflaschen1>	 roux_, yes.  It varies how much time we might have to assist (if needed), but several people have installed it on non-WMF wikis.
[18:04:23] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Special:NewPages doesn't show pages in Topic namespace - https://phabricator.wikimedia.org/T116057#1739383 (10Glaisher)
[18:04:31] <Glaisher>	 mattflaschen1: legoktm ^
[18:05:42] <mattflaschen1>	 Thanks, Glaisher
[18:10:00] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1739395 (10Glaisher) 3NEW
[18:21:20] <wikibugs>	 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10MediaWiki-extensions-Disambiguator: Disambiguation pages should not be marked as "No citations" - https://phabricator.wikimedia.org/T76198#1739457 (10Swpb) This is still a problem on NewPagesFeed, although the message does not appear under t...
[18:48:17] <wikibugs>	 3Collaboration-Team-Current, 10MediaWiki-extensions-LiquidThreads, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): ResourcesTest::testFileExistence failures for LiquidThreads - https://phabricator.wikimedia.org/T113497#1739658 (10Legoktm) 5Open>3Resolved
[18:54:23] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Design: Add a customizable field for text or template on top of Flow boards - https://phabricator.wikimedia.org/T115690#1739675 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF Declined in favour of pinnable tabs for important announcements. We don't want mul...
[19:04:23] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Allow pinnable tabs for important announcements on Flow boards - https://phabricator.wikimedia.org/T116076#1739722 (10Trizek-WMF) 3NEW
[19:12:24] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1739787 (10Quiddity) 3NEW
[19:13:39] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: moderated content inconsistencies - https://phabricator.wikimedia.org/T60725#1739813 (10Mattflaschen) @Nemo_bis, this is when the whole topic was deleted using Flow's delete topic UI?
[19:20:03] <grrrit-wm>	 (03CR) 10Mattflaschen: "Yeah, this is a known issue. I think they're mostly the Parsoid ones: https://phabricator.wikimedia.org/T76586 . It's definitely a probl" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246798 (owner: 10Mattflaschen)
[19:20:27] <grrrit-wm>	 (03Abandoned) 10Mattflaschen: DON'T MERGE: See if test runs in Jenkins [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246798 (owner: 10Mattflaschen)
[19:22:44] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1739871 (10Mattflaschen) {T113245} is in QA Review (done, but pending QA); I will ping @Etonkovidova about that.  {T111084} is being...
[19:23:45] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1739881 (10Mattflaschen)
[19:23:46] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Set wgFlowMigrateReferenceWiki to false in production - https://phabricator.wikimedia.org/T113245#1739880 (10Mattflaschen)
[19:24:08] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Set wgFlowMigrateReferenceWiki to false in production - https://phabricator.wikimedia.org/T113245#1659739 (10Mattflaschen) I removed an inaccurate blocker.
[19:24:19] <matt_flaschen>	 etonkovidova, can you QA https://phabricator.wikimedia.org/T113245 when you have a chance.  I removed a blocker that was not really a blocker.
[19:25:42] <etonkovidova>	 matt_flaschen: I still see that  T107204 is blocked by T111084: Do backfill and final schema change for "Segregate Reference objects by source wiki."  and T113245: Set wgFlowMigrateReferenceWiki to false in production
[19:25:48] <etonkovidova>	 matt_flaschen: hmm...
[19:26:55] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1739897 (10Quiddity)
[19:28:10] <etonkovidova>	 matt_flaschen: ah ok... I see. will QA https://phabricator.wikimedia.org/T113245 
[19:35:15] <matt_flaschen>	 Thanks, etonkovidova.  Nothing is blocking T113245 anymore; I removed one that I don't think was accurate.
[19:52:06] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1739956 (10Peachey88) p:5Triage>3Normal This does hamper deleting spam for some.
[19:54:51] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow should use standard delete messages dropdown messages from [[MediaWiki:Deletereason-dropdown]] - https://phabricator.wikimedia.org/T116079#1739961 (10Peachey88) 3NEW
[20:32:17] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Design Research Archive, 5Design Research and product team collaboration: Learn about use of notifications - https://phabricator.wikimedia.org/T100650#1740051 (10Capt_Swing)
[20:47:21] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Set wgFlowMigrateReferenceWiki to false in production - https://phabricator.wikimedia.org/T113245#1740105 (10Etonkovidova) Checked on https://test.wikipedia.org/wiki/ - all references to $wgFlowMigrateReferenceWiki are deleted i...
[20:50:03] <etonkovidova>	 matt_flaschen: sorry for nit-picking... "Set wgFlowMigrateReferenceWiki to false in production" - is actually deleted entirely not set to false
[20:52:04] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2), 7WorkType-NewFunctionality: Remove wgFlowMigrateReferenceWiki - https://phabricator.wikimedia.org/T108104#1740116 (10Etonkovidova) See comment on T113245: Set wgFlowMigrateReferenceWiki to false in production
[21:02:13] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: History:  'undo' for topic summary still has the old-style icon - https://phabricator.wikimedia.org/T116085#1740147 (10Etonkovidova) 3NEW
[21:02:19] <matt_flaschen>	 etonkovidova, it's fine.  https://gerrit.wikimedia.org/r/#/c/238111/2 overrode the custom setting in production, causing it to use the default setting.  That default setting was false prior to it being removed entirely: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow/7acdd0fa72c193966f82ee486d7c20eb6d66c245/Flow.php#L414
[21:09:06] <grrrit-wm>	 (03PS4) 10Mattflaschen: WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[21:09:14] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Investigate the uses of the old editor system in Flow, and clean up the uses in handlebars - https://phabricator.wikimedia.org/T114448#1740161 (10Etonkovidova) Summary:   >Clicking "undo" from the history page  -...
[21:11:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[21:28:37] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Board description: Switching to VE and clicking Save  removes Categories - https://phabricator.wikimedia.org/T115362#1740192 (10Etonkovidova) Checked in betalabs.
[21:29:39] <grrrit-wm>	 (03PS5) 10Mattflaschen: WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[21:31:10] <matt_flaschen>	 mooeypoo, I might ask you for some browser test help later today, if I get stuck.
[21:31:51] <mooeypoo>	 Sure thin
[21:31:52] <mooeypoo>	 g
[21:32:53] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1740203 (10Etonkovidova) Checked in betalabs.   - Blocking issues are resolved. T115357: Adding/removing categories to Board descrip...
[21:55:13] <matt_flaschen>	 mooeypoo, do you know how I can log in as an admin, or some privileged user?  I just want it to not trigger ConfirmEdit.
[21:55:59] <matt_flaschen>	 Does 'I am logged in' use a privileged user?
[22:04:27] <matt_flaschen>	 Figured out how to log on as Selenium user.
[22:08:16] <mooeypoo>	 It should log in as admin in vagrant 
[22:08:26] <mooeypoo>	 depending on your user definition
[22:08:41] <matt_flaschen>	 mooeypoo, I'm using:L
[22:08:43] <matt_flaschen>	 export MEDIAWIKI_ENVIRONMENT=local; bundle exec cucumber features/new_topic.feature:13
[22:09:12] <matt_flaschen>	 mooeypoo, do you know why it's not using Admin?
[22:09:14] <matt_flaschen>	 https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/tests/browser/environments.yml;1a85ea155b4fbbcb85b73769821fee7ea1ad7258$25
[22:10:18] <mooeypoo>	 I'm trying, hang on
[22:10:45] <matt_flaschen>	 I'll upload my WIP.
[22:11:21] <grrrit-wm>	 (03PS6) 10Mattflaschen: WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[22:12:00] <mooeypoo>	 yeah I need to commit my initializer change first so I don't lose it
[22:15:21] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: error message "Insufficient permissions to execute this action" - https://phabricator.wikimedia.org/T95091#1740352 (10Quiddity)
[22:15:22] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: moderation action when already moderated gives misleading Insufficient permissions error - https://phabricator.wikimedia.org/T66568#1740353 (10Quiddity)
[22:15:49] <matt_flaschen>	 It looks like maybe other environment variables (e.g. MEDIAWIKI_USER) are overriding it.  I'm running it inside the VM.
[22:16:11] <mooeypoo>	 err something's going on with my computer
[22:16:11] <mooeypoo>	 it's not running the tests now. Stuck on activating the browser. Let me try and reboot vagrant
[22:16:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow: moderation action when already moderated gives misleading Insufficient permissions error - https://phabricator.wikimedia.org/T66568#690076 (10Quiddity)
[22:18:43] <matt_flaschen>	 mooeypoo, I've got it.  I had to unset MEDIAWIKI_USER AND MEDIAWIKI_PASSWORD inside vagrant.  There is a comment in the Puppet that says those are there for repos using the old style, but they apparently still take effect on Flow.
[22:40:32] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Give admins deleting a board, an option to delete all topics at the same time. - https://phabricator.wikimedia.org/T116095#1740439 (10Quiddity) 3NEW
[22:44:37] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Give admins deleting a board, an option to delete all topics at the same time. - https://phabricator.wikimedia.org/T116095#1740456 (10Quiddity)
[22:51:37] <matt_flaschen>	 mooeypoo, one of tests seems to work when I run just that scenario, but not when I run the whole feature file.  Any thoughts?
[22:51:53] <matt_flaschen>	 mooeypoo, one possibility I considered is that it's caching one of the selectors from a prior test.
[23:08:15] <mooeypoo>	 matt_flaschen, am I here?
[23:08:38] <matt_flaschen>	 mooeypoo, yep.
[23:09:06] <mooeypoo>	 ... testing, testing.
[23:09:08] <mooeypoo>	 ha!
[23:09:10] <mooeypoo>	 ok http://pastebin.com/E3bWLybf
[23:09:12] <mooeypoo>	 matt_flaschen, this is the bash process I have that I run before tests
[23:09:14] <mooeypoo>	 I have it in .bashrc of vagrant itself, since I run the tests from within vagrant
[23:09:22] <mooeypoo>	 it should reset the variables properly
[23:10:41] <matt_flaschen>	 Okay, thanks.  i don't think that is my current issue, but I will install it just in case.
[23:12:46] <mooeypoo>	 matt_flaschen, do you have the commit up in gerrit so I can test if i get the same?
[23:14:45] <grrrit-wm>	 (03PS7) 10Mattflaschen: WIP: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[23:15:06] <matt_flaschen>	 mooeypoo, https://gerrit.wikimedia.org/r/#/c/243066/1 .  I appreciate it.
[23:16:28] <matt_flaschen>	 For me:
[23:16:33] <matt_flaschen>	 cd /vagrant/mediawiki/extensions/Flow/tests/browser/; export MEDIAWIKI_ENVIRONMENT=local; unset MEDIAWIKI_USER; unset MEDIAWIKI_PASSWORD; bundle exec cucumber features/new_topic.feature:13 works
[23:16:34] <matt_flaschen>	 but:
[23:16:40] <matt_flaschen>	 cd /vagrant/mediawiki/extensions/Flow/tests/browser/; export MEDIAWIKI_ENVIRONMENT=local; unset MEDIAWIKI_USER; unset MEDIAWIKI_PASSWORD; bundle exec cucumber features/new_topic.feature
[23:16:42] <matt_flaschen>	 does not.
[23:17:38] <mooeypoo>	 O.O
[23:17:40] <mooeypoo>	 hm
[23:21:53] <mooeypoo>	 matt_flaschen, both fail for me
[23:22:28] <mooeypoo>	 When I run all tests in new_topic.feature, then :13 fails for "Then there should be a link to the main page in the first topic title "
[23:22:42] <mooeypoo>	 when I run only :13 it fails for "there should be a media link in the first topic title"
[23:22:53] <mooeypoo>	 weird
[23:23:24] <matt_flaschen>	 mooeypoo, what does the actual topic look like?  When you mouse over them, do they point the right places.  It should be main page, a red link, and a direct link to the jpg file.
[23:24:04] <mooeypoo>	 Main page and a red link to something Earth.jpg
[23:24:21] <mooeypoo>	 I'm going over the page in recent changes, hang on
[23:24:24] <matt_flaschen>	 Sounds right.
[23:24:43] <mooeypoo>	 I have a feeling the selectors are wonky... can that be?
[23:24:53] <matt_flaschen>	 Sure, could be, but I don't know why :13 works for me.
[23:24:57] <mooeypoo>	 I am usually weary on selecting by text or url, but I don't know if there's any other way
[23:24:57] <matt_flaschen>	 I'm going to try having it create a new Flow board, just for experimentation sake.
[23:25:13] <mooeypoo>	 Also, why is "NewTopicBoard" a page on its own?
[23:25:28] <mooeypoo>	 I think you can use FlowPage?
[23:25:29] <matt_flaschen>	 mooeypoo, just because I thought it was crufty to put that stuff in a general-purpose Page.
[23:25:40] <mooeypoo>	 yeah doesn't really matter
[23:25:42] <matt_flaschen>	 Okay, I can move it in there.
[23:26:02] <mooeypoo>	 i would inherit from AbstractFlowPage though, for consistency
[23:26:10] <mooeypoo>	 I don't think that's the problem anyways
[23:28:09] <mooeypoo>	 ok, hm, the link looks different, maybe that mattered..?
[23:28:38] <mooeypoo>	 I don't have "https://upload.wikimedia.org/wikipedia/commons/3/36/Earth.jpg" link in the second page created, I have it as if it's local
[23:28:57] <mooeypoo>	 matt_flaschen, that link is actually "http://localhost:8080/w/index.php?title=Media:Earth.jpg&action=edit&redlink=1" 
[23:29:01] <mooeypoo>	 so the test can't find it for me
[23:29:36] <matt_flaschen>	 mooeypoo, oh, enable the multimedia role.
[23:29:46] <matt_flaschen>	 I'll add it to a related patch.
[23:29:50] * mooeypoo nods
[23:30:16] <mooeypoo>	 the weird thing is the inconsistent behavior
[23:30:33] <mooeypoo>	 i would have suspected that the selector is wonky, but it works when you run it separately. wtf.
[23:32:25] <matt_flaschen>	 mooeypoo, actually, I don't know if multimedia should be needed.  Can you check in the PHP shell what your value of $wgUseInstantCommons is?
[23:33:27] <mooeypoo>	 can you remind me how I open mw's php eval thing?
[23:33:35] <matt_flaschen>	 vagrant ssh
[23:33:37] <matt_flaschen>	 hhvmsh
[23:33:50] <matt_flaschen>	 var_export( $wgUseInstantCommons );
[23:34:02] <mooeypoo>	 "false"
[23:34:12] <mooeypoo>	 also, that is entirely not what roan showed me last time. This looks better
[23:34:21] <matt_flaschen>	 :)
[23:35:31] <mooeypoo>	 ok it finish provisioning
[23:36:17] <matt_flaschen>	 mooeypoo, I forgot I have hacks around InstantCommons.  Let me see if they're still necessary.
[23:37:26] <mooeypoo>	 yeah, it's still failing
[23:37:32] <mooeypoo>	 maybe you shouldn't test on the url, though
[23:37:42] <mooeypoo>	 the test checks links, no? not specific media links?
[23:40:20] <matt_flaschen>	 mooeypoo, well, it uses the parser at https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/Linker.php;3c0432fcb399aa09ee1fb453d0c92b8c0404f2fa$1392 .  Media links are one of the few "special" features implemented there.
[23:40:34] <mooeypoo>	 hmm
[23:40:36] <matt_flaschen>	 mooeypoo, at the same time, we're not testing that core functionality, and it's unlikely our integration would stop working just for Media links.  What do you think?
[23:41:28] <mooeypoo>	 I think it's problematic enough to rethink how to test. The urls can be different depending on the installation and config, no?
[23:42:19] <matt_flaschen>	 mooeypoo, Main_Page should always exist. (Not always, always, but always in a test environment.)  Red link should always be a red link.
[23:42:34] <matt_flaschen>	 Media link will always work as long as it's accessing the Commons repo (which InstantCommons is designed to do).
[23:42:59] <mooeypoo>	 matt_flaschen, yes, but not necessarily as /wiki/Main_Page
[23:43:08] <mooeypoo>	 hence my worry about testing via url
[23:43:31] <mooeypoo>	 If we care about where the link leads, we can test that the link is there, click it, and verify that we're in the main page
[23:43:33] <matt_flaschen>	 mooeypoo, yeah, but it doesn't need to work on every environment ever, just the ones we run browser tests on.  There's lots of things in our browser tests that will fail on some random wiki.
[23:43:47] <mooeypoo>	 hm, yeah, I guess so
[23:44:33] <mooeypoo>	 I am completely not sure why it would fail when you run all tests together, though.
[23:44:38] <matt_flaschen>	 I'll take out Media for now.  I don't think it's critical (it would be if I was testing formatLinksInComment, but I'm not.
[23:45:03] <mooeypoo>	 Yeah it might be good to put it in its own test later.
[23:45:27] <mooeypoo>	 You mentioned having a problem with logging in not as Admin -- my tests are logged in as admin, but I don't see why the failure would be related to logging it?
[23:45:32] <mooeypoo>	 am I missing something maybe?
[23:46:05] <matt_flaschen>	 mooeypoo, I solved that with the unsets.
[23:46:14] <mooeypoo>	 oh oh ok
[23:46:17] <matt_flaschen>	 The environment variables shadow the yml file.
[23:46:24] <mooeypoo>	 ... why would it not work, then.
[23:46:28] <mooeypoo>	 what the hell 
[23:48:44] <matt_flaschen>	 mooeypoo, I'm going to try creating a new board between tests.  It will slow it down, but hopefully at least work.
[23:48:55] <matt_flaschen>	 I mean between scenarios.
[23:49:22] <mooeypoo>	 That's probably a good idea in general, since it's looking for a link i the first title, and that might clash with other concurrent tests
[23:49:31] <mooeypoo>	 There's already a step for that
[23:50:04] <matt_flaschen>	 mooeypoo, is there one that actually navigates to the new board, or just creates it?
[23:50:07] <matt_flaschen>	 I see a create one.
[23:50:08] <mooeypoo>	 "I am on a new board"
[23:50:37] <mooeypoo>	 It creates it, navigates to it, waits until it's fully loaded and verifies there are no ResourceLoader issues
[23:50:50] <mooeypoo>	 it's in flow_steps.rb
[23:51:00] <matt_flaschen>	 mooeypoo, oh, nice. :)
[23:51:09] <mooeypoo>	 yeah super useful
[23:55:20] <matt_flaschen>	 mooeypoo, any idea what:
[23:55:22] <matt_flaschen>	 [6582d8ba] /wiki/Flow_test_talk:Foo Flow\Exception\InvalidInputException from line 21 of /vagrant/mediawiki/extensions/Flow/includes/OOUI/BoardDescriptionWidget.php: You must specify a descriptionFormat
[23:55:23] <matt_flaschen>	 might be?
[23:57:04] <matt_flaschen>	 mooeypoo, never mind, it works on master, so it must be broken by my change.
[23:57:24] <mooeypoo>	 Yeah, it's if you instantiate BoardDescriptionWidget.php without giving it a format...
[23:57:46] <mooeypoo>	 It takes revision.content.format and revision.content.content
[23:57:59] <mooeypoo>	 Although to be honest, it probably shouldn't. The format for the php-side should *always* be html
[23:58:45] <mooeypoo>	 flow_header_detail.partial has the {{ oouify ... }} helper that builds it
[23:59:38] <matt_flaschen>	 mooeypoo, shouldn't it be fixed-html?
[23:59:52] <matt_flaschen>	 Also, I've been working on this commit way too long. :(
[23:59:58] <matt_flaschen>	 I forgot I added that exception...