[01:41:22] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7WorkType-Maintenance: Delete button on VE link inspector is not easy to use - https://phabricator.wikimedia.org/T115727#1733709 (10Jdforrester-WMF) [06:18:37] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, and 2 others: Notify inactive translators that new suggestions are available - https://phabricator.wikimedia.org/T113586#1733811 (10Amire80) [06:43:44] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, and 2 others: Encourage users to publish old inactive unpublished translations - https://phabricator.wikimedia.org/T89707#1733845 (10Amire80) [06:44:00] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 6WMF-Design, and 2 others: Notify that your article has been translated by another user - https://phabricator.wikimedia.org/T88581#1733846 (10Amire80) [08:04:32] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [08:18:09] 6Collaboration-Team-Backlog, 10Flow: See which Flow posts contain the latest updates, via the 'cur' in history pages - https://phabricator.wikimedia.org/T114302#1734027 (10Trizek-WMF) [08:18:10] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow history system - https://phabricator.wikimedia.org/T113581#1734026 (10Trizek-WMF) [08:19:38] 6Collaboration-Team-Backlog, 10Flow: People tend not to notice new messages highlights on a Flow board - https://phabricator.wikimedia.org/T115832#1734034 (10Trizek-WMF) 3NEW a:3Pginer-WMF [08:19:49] 6Collaboration-Team-Backlog, 10Flow: People tend not to notice new messages highlights on a Flow board - https://phabricator.wikimedia.org/T115832#1734046 (10Trizek-WMF) [08:19:50] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow history system - https://phabricator.wikimedia.org/T113581#1670021 (10Trizek-WMF) [08:20:40] 6Collaboration-Team-Backlog, 10Flow: See which Flow posts contain the latest updates, via the 'cur' in history pages - https://phabricator.wikimedia.org/T114302#1734049 (10Trizek-WMF) See also {T115832} [08:21:19] 6Collaboration-Team-Backlog, 10Flow: People tend not to notice new messages highlights on a Flow board - https://phabricator.wikimedia.org/T115832#1734034 (10Trizek-WMF) [08:21:21] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T85563#1734056 (10Trizek-WMF) [09:28:00] (03CR) 10Hashar: [C: 04-1] build: Add composer test, initially with just parallel-test (036 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [09:30:43] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552#1734214 (10Aklapper) https://www.mediawiki.org/wiki/Extension:PageTriage says "some of the configuration and code is specific to the English-language Wikipedia's w... [09:41:18] Hello, can someone of the team take a look at https://phabricator.wikimedia.org/T50552#1733522? Thanks! [10:03:57] Correct link: https://phabricator.wikimedia.org/T50552#1733522 [11:14:58] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1734509 (10Pginer-WMF) 3NEW [11:17:41] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization, 7Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#1734531 (10Pginer-WMF) After some research sessions, the approach described as "Use icons as the refe... [11:18:11] 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1734509 (10Pginer-WMF) [14:55:14] 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1734970 (10PerfektesChaos) Another approach has been discussed recently on [[https://www.mediawiki.org/wiki/Topic:Sobaaiky57zs7py7 | mw:Talk:Echo]] – show one badge at all, bu... [14:59:42] (03PS1) 10Anomie: ElsaticaConnection doesnt have a constructor [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247283 [14:59:55] (03PS1) 10Anomie: ElsaticaConnection doesnt have a constructor [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/247284 [15:01:27] (03CR) 10Anomie: [C: 032] "SWAT" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/247284 (owner: 10Anomie) [15:02:20] (03CR) 10jenkins-bot: [V: 04-1] ElsaticaConnection doesnt have a constructor [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247283 (owner: 10Anomie) [15:04:09] (03CR) 10Hashar: "The jscs is unrelated, I have no idea how it managed to leak in though. You probably want to force merge :-/" [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247283 (owner: 10Anomie) [15:04:22] (03Merged) 10jenkins-bot: ElsaticaConnection doesnt have a constructor [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/247284 (owner: 10Anomie) [15:04:28] (03CR) 10Anomie: [C: 032 V: 032] "Force merge because unit testing is *all* screwed up." [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247283 (owner: 10Anomie) [15:05:19] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552#1734985 (10Legoktm) PageTriage is essentially abandonware at this point. The grand plan is to design a workflow system (as mentioned [[https://lists.wikimedia.org/... [15:38:17] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552#1735086 (10Legoktm) Related: https://meta.wikimedia.org/wiki/User:Okeyes_%28WMF%29/Localising_page_curation [15:45:26] (03PS8) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [15:45:40] (03PS9) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [15:46:15] (03CR) 10Sbisson: Add templates to talkpage and Flow board during opt-out (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246858 (https://phabricator.wikimedia.org/T112957) (owner: 10Sbisson) [15:47:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [15:47:42] (03CR) 10Legoktm: "PS8 added the GENDER hack, PS9 is a rebase" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [16:47:29] mornin' everyone. [16:48:52] stephanebisson, you have a second? I actually ran into a lot of problems trying to make the tests more standalone and brief :\ I ended up using steps from the other tests for that reason. Should I duplicate the steps with adjustments, instead? [16:51:24] stephanebisson, the "BoardHistoryPage" for example, is set to have page_url "Talk:Flow_QA?action=history" so I can't use a random new board for it, can I ? Doesn't it lead to the specific Flow_QA history? [16:54:51] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1735326 (10Glaisher) 3NEW [16:55:15] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1735334 (10Legoktm) p:5Triage>3High [16:57:46] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter examine/test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1735349 (10Glaisher) Probably same issue: {T115887} [16:57:51] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1735326 (10Glaisher) See also {T115128} [16:59:28] (03CR) 10Mooeypoo: "I'm working on a refactoring of flow-initialize to use a dedicated "Initializer" that will organize all operations, but that is in a separ" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) (owner: 10Mooeypoo) [17:00:32] (03PS10) 10Legoktm: Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [17:01:07] (03PS4) 10Mooeypoo: Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) [17:01:29] stephanebisson, also, when you get a moment, my local rubocop doesn't flag the things the rubocop in CI does. Is there a way to make them match? [17:03:29] mooeypoo: I'm back, let's see [17:04:20] mooeypoo: what happens when you run `rubocop tests/browser/**/*.rb`? [17:04:27] mooeypoo, etonkovidova, you coming to the pre-deployment review? [17:04:47] matt_flaschen: I guess... [17:05:17] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1735423 (10Legoktm) Flow reads and stores the value of `$wgUser` during `$wgExtensionFunctions` in... [17:05:26] If no one wants to come, I can just do it myself. [17:05:49] matt_flaschen, I wasn't planning on it, but I can if you want? [17:06:00] It's fine, I'll just do it. [17:06:14] stephanebisson, I am getting unrelated errors without the error that rubocop complained about in CI [17:06:36] mooeypoo: rubocop -v [17:06:41] stephanebisson, before I fixed the error, I got this: http://pastebin.com/qAjHuff7 [17:06:53] 0.34.2 [17:07:04] mooeypoo: I have the same version [17:07:17] Is there a definition file, like jshint and jscs ? [17:07:37] mooeypoo: I have fixed the gsub/tr issue in another patch [17:08:03] stephanebisson, but it should still have shown the error CI complained about in my file, no? [17:08:07] there's a .rubocop.yml [17:08:34] Hm, I assume it's the same for the entire repo [17:08:45] as in, there shouldn't be a difference between my local one and yours [17:09:10] weird [17:09:15] Never mind, according to https://www.mediawiki.org/wiki/MediaWiki_1.27/Roadmap a new branch isn't being cut tomorrow. They're just resuming wmf3 starting Wed. [17:09:36] (03PS5) 10Sbisson: Add templates to talkpage and Flow board during opt-out [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246858 (https://phabricator.wikimedia.org/T112957) [17:11:00] mooeypoo: same here, I don't get the rubocop error in your commit locally [17:11:27] (03PS5) 10Mooeypoo: Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) [17:11:36] stephanebisson, hm, so the definition file may be different in CI ? [17:11:45] We should match it [17:12:00] or... match whatever is different. Version is the same? [17:13:26] (03PS1) 10Legoktm: AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) [17:15:05] (03CR) 10jenkins-bot: [V: 04-1] AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) (owner: 10Legoktm) [17:17:15] * legoktm grumbles [17:17:31] mooeypoo: ok, I installed the same version as CI (0.32.1) and I still don't have the same error [17:19:34] ... hm. Does CI have the same.rubocop.yml? [17:19:41] (03PS2) 10Legoktm: AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) [17:21:21] stephanebisson, why is "NewFlowPage" not inheriting "AbstractFlowPage'? Is that intentional? [17:21:24] (03CR) 10jenkins-bot: [V: 04-1] AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) (owner: 10Legoktm) [17:22:06] mooeypoo: because it was not needed [17:22:21] ok, I may have to change it [17:23:30] mooeypoo: what do you mean by "I actually ran into a lot of problems trying to make the tests more standalone and brief :\ I ended up using steps from the other tests for that reason." [17:23:54] (03PS3) 10Legoktm: AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) [17:25:31] (03CR) 10jenkins-bot: [V: 04-1] AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) (owner: 10Legoktm) [17:25:33] stephanebisson, I initially tried to make the tests standalone, as in, using their own random new boards. The problem I ran to, though, is that there were several steps, like "visit board history", that required remembering the title and coming back to it. But "I am on a new board" doesn't keep the title, and "BoardHistoryPage" defines a specific URL that's attached to Talk:Flow_QA [17:26:10] stephanebisson, so I started going in circles starting to re-implement a lot of the logic there to fit the tests. Instead, I reused the steps we already have like you see in the current undo.feature file [17:27:04] mooeypoo: you know you can have both: write your feature file with high-level custom steps AND implement them using existing steps [17:27:16] I could create a step that internally reuses other steps, but that won't solve the problem you're pointing out about clashing tests in Talk:Flow_QA [17:27:22] with `step 'I do blah'` in ruby [17:27:31] yep, but that won't solve going to a new board [17:27:39] I'll do that for the first scenario [17:28:43] having url hardcoded to Talk:Flow_QA is annoying [17:30:26] (03PS4) 10Legoktm: AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) [17:31:56] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability: DB master connections requested by Flow on GET/HEAD requests - https://phabricator.wikimedia.org/T94028#1735556 (10matthiasmullie) a:3matthiasmullie [17:32:04] 3Collaboration-Team-Current, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter, 5Patch-For-Review: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1735558 (10Legoktm) a:3Legoktm [17:32:52] stephanebisson, yeah :\ part of the issue is also that this is an unbreak now, and a frustrating one, so I was trying to be a little quicker. We shouldn't sacrifice proper tests for that, though.... eh. [17:40:55] (03CR) 10Matthias Mullie: [C: 032] AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) (owner: 10Legoktm) [17:41:27] mooeypoo: I could also +2 and put a follow up patch later today mostly to fix the concurency issue with the description [17:42:01] mooeypoo: would you prefer that? [17:42:41] stephanebisson, I am just worried about the fact that the fix needs to be back ported before tomorrow. I don't mind continuing working on it, but I am afraid it will delay things and then we will run into problems with the deployment [17:43:39] (03Merged) 10jenkins-bot: AbuseFilter: Get user from context instead of at initialization [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247301 (https://phabricator.wikimedia.org/T115887) (owner: 10Legoktm) [17:43:42] I understand, that's why I'm proposing that as a compromise [18:07:16] 6Collaboration-Team-Backlog, 10Flow, 7Design: Add a customizable field for text or template on top of Flow boards - https://phabricator.wikimedia.org/T115690#1735734 (10Mattflaschen) It used to be at the top and be called the 'header'. We deliberately moved it to the right (for desktop/laptop, at least) and... [18:09:28] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-Maintenance: Fatal exception of type "Flow\Exception\DataModelException" - https://phabricator.wikimedia.org/T115696#1735748 (10Mattflaschen) I'm not sure precisely what's causing this, but there are known problems with the pagination that should be fixed by htt... [18:13:30] stephanebisson, a little ruby help, if you may. I am trying to change NewFlowPage to accept a title parameter, but I want it to be "backwards compatible" to set up its own random title so I don't have to change all other tests... is this legal? http://pastebin.com/GhBA0T6k [18:14:04] So if a parameter is given, use that, otherwise do your own random string like before... [18:14:30] not legal as-is, let me see [18:15:23] stackoverflow claims "params.has_key?(:pagetitle)" is the way to go for checking whether a parameter exists, but I am not sure. We're using "I am on a new board" a *LOT* [18:15:41] ... wait, no we're not [18:15:55] maybe <%= params[:pagetitle] || Random.srand.to_s %> [18:16:19] or <%= params.has_key(:pagetitle) ? params[:pagetitle] : Random.srand.to_s %> [18:16:39] or wrap it in a function but you'd have to pass params in [18:16:55] undefined method `has_key' for {}:Hash (NoMethodError) [18:17:01] seems I need to also check if params exist [18:18:01] .has_key? [18:18:17] has_key seems to assume params is an object. I need to first check that that's true [18:18:22] since it isn't if we're not giving parameters [18:19:28] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1735803 (10jcrespo) After some days away, I will put this back on the backlog an... [18:19:54] but why do you want to control the url of NewFlowPage, it exist only for the purspose of giving you a new random page? [18:21:38] because if I want to then go to that board's history, I need to preserve its title for reuse [18:21:42] stephanebisson, okay, this works: [18:21:46] page_url "./Flow_test_talk:New_page_<%= params[:pagetitle] ? params[:pagetitle] : Random.srand.to_s %>" [18:45:10] 6Collaboration-Team-Backlog, 10Flow: 'Newest topics' sort option might be confusing - https://phabricator.wikimedia.org/T107095#1735897 (10Mattflaschen) [18:46:51] 6Collaboration-Team-Backlog, 10Flow: Track references in topic titles - https://phabricator.wikimedia.org/T115910#1735900 (10Mattflaschen) 3NEW [18:47:10] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#600971 (10Mattflaschen) See {T115910}. [18:54:41] (03PS1) 10Hashar: Trivial jscs fix [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247326 [18:55:38] (03CR) 10Hashar: "When removing the block of code, two consecutive blank lines were left behind in the js file. That causes jscs to complains and block futu" [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/246079 (https://phabricator.wikimedia.org/T115339) (owner: 10Catrope) [18:56:15] (03CR) 10Hashar: "Introduced by https://gerrit.wikimedia.org/r/#/c/246079/" [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247326 (owner: 10Hashar) [18:58:15] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1735937 (10Mattflaschen) [19:19:10] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1735993 (10Mattflaschen) a:5Mattflaschen>3jcrespo [19:23:38] stephanebisson, I am running into a really annoying issue. The first test works now on a separate board, but I am trying to adjust the second one (editing/undoing description) and i am stuck on trying to get the test to go to the history page based on the pagetitle parameter, like we just did for "NewFlowPage" [19:23:54] thing is, even though I send the parameter it still goes to the default Talk:Flow_QA [19:24:10] visit(BoardHistoryPage, using_params: { pagetitle: 'Flow_test_talk:New_page_' + @boardTitle }) [19:24:21] and in BoardHistoryPage I have [19:24:26] page_url ( params[:pagetitle] ? params[:pagetitle] : "Talk:Flow_QA" ) + "?action=history" [19:24:39] ... and it still goes, always, to Talk:Flow_QA. waaaat [19:34:29] 6Collaboration-Team-Backlog, 10Flow, 7Design: Add a customizable field for text or template on top of Flow boards - https://phabricator.wikimedia.org/T115690#1736030 (10Trizek-WMF) >>! In T115690#1735734, @Mattflaschen wrote: > It used to be at the top and be called the 'header'. We deliberately moved it to... [19:35:49] marxarelli, can you remind me how to debug? I forgot the gem name and debugger command (also, is there a reference page for this to bookmark? [19:35:51] ) [19:36:32] mooeypoo: the gem is called pry-byebug, and you set breakpoints by calling `binding.pry` [19:36:38] awesomesauce [19:37:17] mooeypoo: https://www.mediawiki.org/wiki/Quality_Assurance/Browser_testing/Debugging [19:37:51] oh great, thanks! [19:37:58] docs seem to be a little out of date [19:38:08] i'm tweak them [19:38:11] *i'll* [19:38:24] can I use this in the page object too? [19:38:41] mooeypoo: yeah, it should work just about anywhere [19:38:52] it's a general ruby debugg [19:38:54] debugger [19:39:10] * marxarelli can't type today [19:39:48] goddamnit, params is empty [19:39:55] ... wait a minute [19:39:59] * mooeypoo grunts [19:40:49] aaaaaa. help :( stephanebisson marxarelli I have this in my step: visit(BoardHistoryPage, using_params: { pagetitle: 'Flow_test_talk:New_page_' + @boardTitle }) [19:41:16] but when I debug in BoardHistoryPage, then the output of "params" is {} [19:41:21] how can that be and what am I doing wrong [19:42:13] mooeypoo: judging by the scrollback, i think you may defining the page_url incorrectly [19:42:37] marxarelli, that is the second problem; the params variable is empty.... I can't even define things right if it's empty [19:42:58] marxarelli, also, I have this in my NewFlowPage PageObject -- page_url "./Flow_test_talk:New_page_<%= params[:pagetitle] ? params[:pagetitle] : Random.srand.to_s %>" [19:43:01] and that works perfectly [19:43:37] the expression you provide to page_url within the class definition is being evaluated immediately, not each time you invoke visit/on [19:43:47] you need to use erb there [19:43:51] erb? [19:44:04] and how does it work for the NewFlowPage ? [19:44:06] i.e. the weird <%= foo %> syntax within the string [19:44:10] oh [19:44:15] eh, really? [19:44:40] * marxarelli wishes they implemented it with a block syntax instead of awkward erb [19:44:49] ok, stupid question, but how do I add a raw string in there [19:45:56] mooeypoo: the text between <%= and %> can be any valid ruby, including a string literal [19:46:33] what are you trying to implement exact? [19:46:37] exactly [19:46:55] ok, this works! page_url "./<%=params[:pagetitle] ? params[:pagetitle] + '?action=history' : 'Talk:Flow_QA?action=history' %>" [19:46:57] aaa. [19:47:37] I need to check that "I am on the board history" goes to the board history I give it, not the hard-coded board, but that rule is used in our tests before, so it also has to fall back on the hard-coded board [19:50:25] mooeypoo: that works. another option might be to subclass the page-object class and change the page_url for that specific case [19:51:15] mooeypoo: you have the erb syntax right, though [19:54:35] meh [19:55:01] is there a condition to say "when page changed" [19:55:20] I have a form, the stp clicks "Save" and that leads to redirect. I need that step to WAIT until that redirect happened [19:57:28] mooeypoo: your best bet is to wait for something on the final page [20:04:48] omg, it works and passes [20:04:51] this is exhausting [20:06:17] (03PS6) 10Mooeypoo: Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) [20:06:19] stephanebisson, ^^ [20:07:59] (03CR) 10jenkins-bot: [V: 04-1] Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) (owner: 10Mooeypoo) [20:08:30] (03PS7) 10Mooeypoo: Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) [20:08:35] * mooeypoo mutters at rubocop [20:09:29] (03PS8) 10Mooeypoo: Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) [20:09:49] pass.. pass... passs... [20:10:15] ok I need food. [20:41:36] (03CR) 10Sbisson: [C: 032] Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) (owner: 10Mooeypoo) [20:44:18] (03Merged) 10jenkins-bot: Refactor the initialization of 'undo' actions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247075 (https://phabricator.wikimedia.org/T115525) (owner: 10Mooeypoo) [20:47:16] bbiab [20:57:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1736267 (10Mattflaschen) [20:57:20] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#600971 (10Mattflaschen) [21:33:08] (03PS8) 10Paladox: build: Add composer test, initially with just parallel-test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 [22:28:06] 6Collaboration-Team-Backlog, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1736592 (10MGChecker) I think it would be the best if the user could decide himself which type of messages has which priority. In this way, every user could configure his Noti... [23:38:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): [Regression wmf3] 'undo' for Board description edits is not functioning - https://phabricator.wikimedia.org/T115525#1736914 (10Etonkovidova) Checked in betalabs.