[00:35:04] 3Collaboration-Team-Current, 10Echo, 6Editing-Analysis: Measure the notification types that are most abundantly received at 5 sample wikis - https://phabricator.wikimedia.org/T113664#1727079 (10Neil_P._Quinn_WMF) [00:37:58] 3Collaboration-Team-Current, 10Echo, 6Editing-Analysis: Measure the notification types that are most abundantly received at 5 sample wikis - https://phabricator.wikimedia.org/T113664#1727088 (10Neil_P._Quinn_WMF) Good point. Since it's not actually blocked, I should be able to work on it tomorrow. [00:41:02] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: simplify notification items - https://phabricator.wikimedia.org/T114357#1727092 (10Catrope) Notes from talking through this with @MSchottlender-WMF: - There are two ways to mark something as read (the X icon and the one in the action menu) - Should... [00:41:11] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1727094 (10Catrope) Notes from talking through this with @MSchottlender-WMF: - When clicking a sub-notification, do we take the primary action (follow the link to the page)... [00:42:21] 6Collaboration-Team-Backlog, 10Echo: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1727102 (10Catrope) [00:42:22] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1727101 (10Catrope) [00:50:46] 6Collaboration-Team-Backlog, 10Echo: Create a notification demo page - https://phabricator.wikimedia.org/T115551#1727123 (10Catrope) 3NEW [00:50:57] 3Collaboration-Team-Current, 10Echo: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1723840 (10Catrope) [00:50:58] 6Collaboration-Team-Backlog, 10Echo: Create a notification demo page - https://phabricator.wikimedia.org/T115551#1727133 (10Catrope) [00:58:11] 6Collaboration-Team-Backlog, 10Echo: Determine secondary action data for all existing notification types - https://phabricator.wikimedia.org/T115553#1727155 (10Catrope) [03:41:40] Ug, I had to do Windows tech support for a friend. [03:41:44] The horror, the horror... [03:42:11] That's why I never got back to it tonight. [03:42:17] It escalated, as Windows tech support always does. [03:43:24] matt_flaschen: did you hand them a Linux live CD? [03:43:48] legoktm, I should, she probably could get away with it. [03:44:05] linux mint looks very similar to windows ;) [03:47:16] matt_flaschen, legoktm, i have added a Newsletter extension into my repo [03:47:32] i am updating the table(DB) but i am having some errors [03:47:44] the extension is Newsletter [03:48:21] but i can't update the DB tables using update.php script in maintainance. Is there another way? [03:49:00] As in update.php gives an error, or you can't for some other reason? [03:50:53] ohhh, i see it now. I need a to update composer for an extension [03:50:56] oojs/oojs-ui: 0.12.10 installed, 0.12.11 required. [03:50:59] Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies [03:52:45] matt_flaschen: but even when i try to access the Newsletter Special page, i see this [03:52:48] Database error [03:52:50] A database query error has occurred. This may indicate a bug in the software. [03:52:56] any idea on that? [03:56:40] matt_flaschen: Can't we make it in such a way that when an extension is added into the LocalSetting.php file, once Wiki is loaded on the browser, the update.php script should run at once? [03:57:03] If any database table exist? [04:09:39] legoktm, worked like a charm. Thanks for the reminder. [04:09:57] Luckily she has a wired connection, so I didn't have to worry about stupid drivers. [04:10:19] d3r1ck, you wouldn't want one random user to have a really slow load when the database updated. [04:10:40] You have to do composer update, then after than run update.php manually. [04:11:30] matt_flaschen: that makes sense though. I was just thinking. I am running composer update noow. [04:11:33] *now [04:11:42] I used a Debian KDE DVD I had lying around. [04:12:46] haha... [04:13:13] I have done that already. composer.lock is up-to-date. DB is updated [04:13:34] i can now access the Special:Newsletter page withou any DB errors [04:14:37] matt_flaschen: i have submitted a patch: https://gerrit.wikimedia.org/r/#/c/246458/ [04:14:58] i have added you as a reviewer. [04:15:22] also i have a patch that has been lying in gerrit for days now, i just hope it will be looked at :) [04:15:42] https://gerrit.wikimedia.org/r/#/c/244439/ [04:15:48] let me add you on this one [04:15:51] too [04:23:25] matt_flaschen: niceee :D [10:32:34] (03CR) 10Matthias Mullie: Fix history pagination and give user the number of entries they requested (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [10:36:21] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1727677 (10matthiasmullie) a:3matthiasmullie [11:13:10] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1727735 (10Pginer-WMF) > When clicking a sub-notification, do we take the primary action (follow the link to the page) or do we expand the notification into full rendering... [11:34:41] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1727764 (10Pginer-WMF) [12:17:14] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7Epic: Notification panel: allow to mark read notifications back to "unread" - https://phabricator.wikimedia.org/T115581#1727829 (10Pginer-WMF) 3NEW [12:18:45] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: simplify notification items - https://phabricator.wikimedia.org/T114357#1692936 (10Pginer-WMF) > There are two ways to mark something as read (the X icon and the one in the action menu) Regarding the scope of this ticket, the important aspects is to hav... [12:20:04] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7Epic: Notification panel: Mark read notifications back to "unread" - https://phabricator.wikimedia.org/T115581#1727851 (10Pginer-WMF) [12:20:53] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#1727854 (10Pginer-WMF) [16:36:41] 3Collaboration-Team-Current, 10Flow: Beta features: "Discussion" link should go to Talk:Flow - https://phabricator.wikimedia.org/T114197#1728502 (10Jdforrester-WMF) Do it. [16:49:59] (03PS1) 10Sbisson: Optin beta feature links to mw.org [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246705 (https://phabricator.wikimedia.org/T114197) [16:50:07] 3Collaboration-Team-Current, 10Flow: Beta features: "Discussion" link should go to Talk:Flow - https://phabricator.wikimedia.org/T114197#1728565 (10SBisson) a:3SBisson [16:50:13] (03PS7) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [16:50:25] (03CR) 10Legoktm: [WIP] Clean up and refactor formatting system (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [16:51:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [17:02:27] 3Collaboration-Team-Current, 10MediaWiki-extensions-LiquidThreads, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-10-20_(1.27.0-wmf.4): ResourcesTest::testFileExistence failures for LiquidThreads - https://phabricator.wikimedia.org/T113497#1728624 (10Etonkovidova) Checked https://integration.wikime... [17:29:29] (03CR) 10Catrope: [C: 032] Optin beta feature links to mw.org [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246705 (https://phabricator.wikimedia.org/T114197) (owner: 10Sbisson) [17:32:22] (03Merged) 10jenkins-bot: Optin beta feature links to mw.org [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246705 (https://phabricator.wikimedia.org/T114197) (owner: 10Sbisson) [17:56:15] mooeypoo, you know RoanKattouw_away is out next week, though, right? [17:59:22] stephanebisson: Do you know of reproduction steps for the ext.thank error on beta? (Outside of browser tests) [18:00:06] RoanKattouw: trying to reproduce it now, so far I can't [18:01:07] it's a resource loader error, we run some js to get them: https://phabricator.wikimedia.org/P2205 [18:01:33] 3Collaboration-Team-Current, 10Flow: Adding Categories makes Board description unavailable for editing - https://phabricator.wikimedia.org/T115415#1728791 (10Mooeypoo) a:3Mooeypoo [18:04:39] OK, so that suggests that mw.loader.getState( 'ext.thanks.flowthank' ) returns 'error [18:04:57] When I run it on Talk:Flow on beta, it says 'ready' [18:46:35] (03PS1) 10Catrope: Revert "Remove existing categories from DOM after the widget ate them" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246722 [18:46:38] (03PS1) 10Catrope: Revert "Add categories to the sidebar" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246723 [18:49:40] (03CR) 10Catrope: [WIP] Clean up and refactor formatting system (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [18:51:32] RoanKattouw: I copied it from DefaultSettings.php [18:51:59] (03CR) 10Catrope: [WIP] Clean up and refactor formatting system (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [18:52:19] https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdpar it means "Paragraph" [18:53:07] Yeah I figured :) [18:54:44] I gotta go to a meeting, but you said this was almost in a mergeable state, right? [18:55:00] Can you ping me while it is? And I'll give it a final once-over and test it some [18:55:31] ok, will do [18:55:37] I just need to fix qqq and test a bit more [19:03:45] 6Collaboration-Team-Backlog, 10Flow: Impossible to filter Topic namespace on the contributions search form - https://phabricator.wikimedia.org/T114996#1728920 (10Quiddity) See this other task for a full explanation of this: {T72595} [19:04:36] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 7Technical-Debt: Define namespace 2601 - https://phabricator.wikimedia.org/T95645#1728924 (10Quiddity) See also {T72595} [19:07:53] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Scribunto, 5Patch-For-Review: Change of namespaces on Telugu wikipedia - https://phabricator.wikimedia.org/T103657#1728939 (10Quiddity) 5Open>3Resolved a:3Quiddity Appears to be fully resolved. E.g. Module_talk: https://te.wikipedia.org/wiki... [19:13:28] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10MediaWiki-extensions-ContentTranslation, 7WorkType-NewFunctionality: View translated messages in Flow - https://phabricator.wikimedia.org/T98728#1728978 (10Amire80) [20:07:10] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Echo notification icons should be white in MonoBook to match Vector - https://phabricator.wikimedia.org/T112290#1729163 (10Esanders) I just set the background to transparent, color to back, the font size back to 1em, and opacity to 0.7 ish. [20:50:19] (03PS1) 10Mooeypoo: Style categories the same in nojs and js Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246779 (https://phabricator.wikimedia.org/T115411) [20:50:21] * mooey|lunch shakes her fist to the sky [20:57:51] (03PS2) 10Mooeypoo: Style categories the same in nojs and js Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246779 (https://phabricator.wikimedia.org/T115411) [21:00:22] 3Collaboration-Team-Current, 10Flow: Adding Categories makes Board description unavailable for editing - https://phabricator.wikimedia.org/T115415#1729363 (10Mooeypoo) I can't reproduce this at all in master... is this still happening? [21:08:48] stephanebisson, guess what I 'm doing now [21:09:07] adding browser tests for categories..... \o/ [21:09:08] mooeypoo: surviving an earthquake? [21:09:14] I did that earlier with Elena [21:09:20] great! [21:09:22] I think she survived better, though [21:10:12] mooeypoo: so what's the status, you still have 1 failure? [21:10:50] stephanebisson, nope, it passed [21:11:01] I'll run all of them again later to verify [21:11:06] but it seems they are all passing now [21:11:09] woooo [21:11:15] mooeypoo: fantastic [21:11:23] no excuses now ;) [21:12:07] stephanebisson, indeed [21:34:50] stephanebisson, is there a test for 'existing' ? [21:34:55] exists? i think? [21:35:16] mooeypoo: more context please [21:35:33] I'm trying to figure out in the text whether my category item exists after adding it [21:35:40] When I add category "Footegory" to the description [21:35:40] Then the categories contain "Footegory" [21:35:44] ^^ the first step I have. [21:36:11] The second step, I defined a method to find the category item [21:36:30] stephanebisson, Im not sure I did it right, but here it is: http://pastebin.com/bmLhtrtL [21:36:47] this is in the board_description .rb [21:37:22] sorry, stephanebisson, refresh that pastebin, I added the definintion of categories [21:37:49] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 7Design, 7WorkType-NewFunctionality: Notify inactive translators that new suggestions are available - https://phabricator.wikimedia.org/T113586#1729583 (10Amire80) [21:37:54] is it working? [21:38:10] stephanebisson, I didn't test yet because I don't know what condition to put on it in the actual step [21:38:20] When(/^The categories contain "(.*?)"$/) do |category_text| [21:38:20] on(FlowPage) do |page| [21:38:20] page.category_item(category_text) [21:38:20] end [21:38:22] end [21:38:28] .exists? visible? [21:38:36] maybe I can use visible [21:46:24] present is like exists [21:48:10] ooh progress [21:48:19] I was waiting on the wrong thing to appear. [21:49:32] stephanebisson, it works! \o/ [21:55:39] (03CR) 10Catrope: [C: 032] Revert "Remove existing categories from DOM after the widget ate them" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246722 (owner: 10Catrope) [21:55:42] (03CR) 10Catrope: [C: 032] Revert "Add categories to the sidebar" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246723 (owner: 10Catrope) [21:56:26] (03PS1) 10Catrope: Update compiled handlebars for reverts [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246792 [21:57:02] (03CR) 10Catrope: [C: 032] Update compiled handlebars for reverts [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246792 (owner: 10Catrope) [21:58:17] stephanebisson, can I have multiple parameters in "do" ? Like When(/^I add categories "(.*?)" and "(.*?)" to the description$/) do |cat1|, |cat2| [21:58:17] ? [21:58:19] (03Merged) 10jenkins-bot: Revert "Remove existing categories from DOM after the widget ate them" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246722 (owner: 10Catrope) [21:58:23] I can't find the syntax [21:58:43] mooeypoo: do |a1, a2| [21:58:47] oh that's how [22:01:21] (03Merged) 10jenkins-bot: Revert "Add categories to the sidebar" [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246723 (owner: 10Catrope) [22:01:24] (03Merged) 10jenkins-bot: Update compiled handlebars for reverts [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246792 (owner: 10Catrope) [22:09:26] (03PS1) 10Mooeypoo: Add browser tests for adding/removing categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246794 [22:12:04] (03CR) 10jenkins-bot: [V: 04-1] Add browser tests for adding/removing categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246794 (owner: 10Mooeypoo) [22:14:34] (03PS2) 10Mooeypoo: Add browser tests for adding/removing categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246794 [22:22:17] 3Collaboration-Team-Current, 10Flow: Adding Categories makes Board description unavailable for editing - https://phabricator.wikimedia.org/T115415#1729731 (10Mooeypoo) Closing according to Elena. [22:22:24] 3Collaboration-Team-Current, 10Flow: Adding Categories makes Board description unavailable for editing - https://phabricator.wikimedia.org/T115415#1729732 (10Mooeypoo) 5Open>3Resolved [22:23:01] 3Collaboration-Team-Current, 10Flow: Board description: Switching to VE and clicking Save removes Categories - https://phabricator.wikimedia.org/T115362#1729733 (10Mooeypoo) a:3Catrope [22:36:12] mooeypoo, what do you get for: [22:36:13] sudo -u www-data php /vagrant/mediawiki/tests/phpunit/phpunit.php /vagrant/mediawiki/extensions/Flow/tests/phpunit/LinksTableTest.php [22:36:20] ? It's giving errors for me on master. [22:50:22] matt_flaschen, me too, lots of failures [22:53:36] Hmm, we need to figure out why it's not failing on Jenkins. [22:54:55] [22:54:56] colors="true" [22:55:07] Ha ha, too bad, Windows! [22:55:23] That's from the test suite file. [22:55:38] O.O [22:55:55] phpunit can laugh all they want, but RTL works on Windows and not anywhere else, pretty much [22:56:00] so .. ah aH [22:56:28] mooeypoo, hey, you said it works on Konsole! I use KDE for personal computer (switched to XFCE for work, seeing how it goes). [22:56:42] That's from our file, not PHPUnit itself. [22:57:13] https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/tests/phpunit/flow.suite.xml;249d65e5e8c7987f6a182d0fea9d9dcbd72d8d68$3 [23:00:43] uhm [23:00:52] we don't use that phpunit file anymore afaik [23:01:09] (03PS1) 10Mattflaschen: DON'T MERGE: See if test runs in Jenkins [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246798 [23:04:41] I guess the answer is no. [23:05:57] ohh [23:05:58] matt_flaschen: [23:06:00] // Check for Parsoid [23:06:00] try { [23:06:00] Utils::convert( 'html', 'wikitext', 'Foo', $this->workflow->getOwnerTitle() ); [23:06:00] } catch ( WikitextException $excep ) { [23:06:01] $this->markTestSkipped( 'Parsoid not enabled' ); [23:06:04] } [23:06:56] Yeah, figured it out like the same time as you. We really need to fix that... [23:07:00] :) [23:07:52] There's already a bug about Parsoid not running in Jenkins, natch [23:36:41] (03PS1) 10Legoktm: Don't remove content model in action=info for Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246800 [23:37:47] (03CR) 10Mattflaschen: [C: 032] Don't remove content model in action=info for Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246800 (owner: 10Legoktm) [23:40:27] (03Merged) 10jenkins-bot: Don't remove content model in action=info for Flow pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246800 (owner: 10Legoktm)