[00:20:00] 6Collaboration-Team-Backlog, 10Echo, 7Browser-Support-Firefox, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Formatting of footer in Echo notification drop-downs is messed up in Firefox - https://phabricator.wikimedia.org/T115052#1720385 (10Harshkothari410) Problem #2 and #3 is in Safari as w... [00:24:04] (03CR) 10Alex Monk: [C: 032] Move Flow DM population to the bottom [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/245596 (https://phabricator.wikimedia.org/T115265) (owner: 10Catrope) [00:26:30] (03Merged) 10jenkins-bot: Move Flow DM population to the bottom [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/245596 (https://phabricator.wikimedia.org/T115265) (owner: 10Catrope) [00:26:39] 3Collaboration-Team-Current, 10Flow, 10BetaFeatures, 5Patch-For-Review: Activate Flow as a beta feature on zh.wp - https://phabricator.wikimedia.org/T115100#1720390 (10Catrope) Was deployed just now, and looks to be working: {F2714456} [00:40:18] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1720407 (10Catrope) >>! In T106302#1720360, @gerritbot wrote: > Change 245588 merged by jenkins-bot: > Flow-oc... [00:56:34] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1720412 (10Catrope) >>! In T106302#1720407, @Catrope wrote: > We had to roll that back because it broke LQT ar... [00:57:59] (03CR) 10Catrope: [C: 032] Use the new editor when editing topic summary in a new window [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245579 (https://phabricator.wikimedia.org/T114448) (owner: 10Mooeypoo) [01:00:28] (03Merged) 10jenkins-bot: Use the new editor when editing topic summary in a new window [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245579 (https://phabricator.wikimedia.org/T114448) (owner: 10Mooeypoo) [01:02:28] (03PS1) 10Catrope: Make review notifications less scary by explicitly saying they're about a page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245611 (https://phabricator.wikimedia.org/T114415) [01:03:51] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review: PageTriage's "patrolled" notifications are jargony and scary - https://phabricator.wikimedia.org/T114415#1720432 (10Catrope) >>! In T114415#1720427, @gerritbot wrote: > Change 245611 had a related patch set uploade... [01:04:21] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review: PageTriage's "patrolled" notifications are jargony and scary - https://phabricator.wikimedia.org/T114415#1720437 (10Catrope) a:3Catrope [01:07:04] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-skins-Modern, 5Patch-For-Review, and 2 others: css bugs in modern skin with the latest echo spilt notifications. - https://phabricator.wikimedia.org/T114080#1720442 (10Catrope) 5Open>3Resolved [01:07:28] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 7user-notice: Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1720447 (10Catrope) 5Open>3Resolved [01:08:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): 'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work - https://phabricator.wikimedia.org/T114043#1720451 (10Catrope) >>! In... [01:10:54] 6Collaboration-Team-Backlog, 10Flow: Scrolling to the bottom of undelete preview causes exception in infinite scroll code - https://phabricator.wikimedia.org/T115295#1720456 (10Catrope) 3NEW [01:11:27] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): 'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work - https://phabricator.wikimedia.org/T114043#1720466 (10Catrope) 5Open... [01:26:33] (03PS1) 10Catrope: Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) [01:28:26] (03CR) 10Catrope: [C: 032] build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245019 (owner: 10Legoktm) [01:32:02] (03CR) 10jenkins-bot: [V: 04-1] build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245019 (owner: 10Legoktm) [01:44:46] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review: PageTriage's "patrolled" notifications are jargony and scary - https://phabricator.wikimedia.org/T114415#1720524 (10Jorm) Looks good to me! [02:38:22] (03PS1) 10Mattflaschen: WIP: Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) [02:40:55] (03CR) 10jenkins-bot: [V: 04-1] WIP: Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [02:48:01] (03CR) 10Mattflaschen: "Do we want quotes around the page name?" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245611 (https://phabricator.wikimedia.org/T114415) (owner: 10Catrope) [02:49:32] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1720577 (10Mattflaschen) a:3Mattflaschen [02:49:42] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1517279 (10Mattflaschen) [02:50:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1517279 (10Mattflaschen) I did this because it was affecting testing of https://gerrit.wikimedia.org/r/245621 . [06:42:44] (03CR) 10Catrope: [C: 032] build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245019 (owner: 10Legoktm) [06:42:54] * legoktm waves [06:50:09] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245019 (owner: 10Legoktm) [07:18:29] (03PS1) 10Siebrand: Update indentation to use tabs [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/245819 [07:33:07] (03CR) 10Siebrand: [C: 032] Update indentation to use tabs [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/245819 (owner: 10Siebrand) [07:36:40] (03Merged) 10jenkins-bot: Update indentation to use tabs [extensions/WikiLovesMonuments] - 10https://gerrit.wikimedia.org/r/245819 (owner: 10Siebrand) [07:57:44] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Flow posts being serialized from HTML -> WT without providing Parsoid data-parsoid attributes? - https://phabricator.wikimedia.org/T115236#1720756 (10mobrovac) >>! In T115236#1720317, @Catrope wrote: > As far as I know, Flow expects to receive HTM... [08:11:06] (03PS1) 10Siebrand: Remove double spaces in messages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245840 [08:11:24] (03CR) 10Siebrand: [C: 032] Remove double spaces in messages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245840 (owner: 10Siebrand) [08:11:55] (03Merged) 10jenkins-bot: Remove double spaces in messages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245840 (owner: 10Siebrand) [09:48:05] (03PS8) 10Hashar: Add composer.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [09:50:31] (03CR) 10Hashar: [C: 032] "CI change deployed which adds composer test https://gerrit.wikimedia.org/r/#/c/243679/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [09:53:15] (03Merged) 10jenkins-bot: Add composer.json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243678 (owner: 10Paladox) [10:49:16] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#1721000 (10Pginer-WMF) 3NEW [10:50:01] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#1721006 (10Pginer-WMF) [11:59:27] (03CR) 10Siebrand: "i18n/L10n reviewed. Not using quotes is fine, I think. We are dealing with this in an inconsistent way in MediaWiki. Quotes do make the pa" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245611 (https://phabricator.wikimedia.org/T114415) (owner: 10Catrope) [11:59:34] (03CR) 10Siebrand: [C: 032] Make review notifications less scary by explicitly saying they're about a page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245611 (https://phabricator.wikimedia.org/T114415) (owner: 10Catrope) [11:59:58] (03Merged) 10jenkins-bot: Make review notifications less scary by explicitly saying they're about a page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/245611 (https://phabricator.wikimedia.org/T114415) (owner: 10Catrope) [13:24:04] 6Collaboration-Team-Backlog, 10Thanks, 7JavaScript: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735#1721362 (10matmarex) I don't think it's possible to animate this the way we do if we allow line-breaking (it relies on `display: inline-blo... [14:14:23] (03PS1) 10Sbisson: Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 [14:53:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Performance, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Flow JS loading / deferred loading is very slow - https://phabricator.wikimedia.org/T108313#1721700 (10Trizek-WMF) I get important feedback from sv.wp, fr.wp and zh.wp, where people have seen nota... [14:56:00] 3Collaboration-Team-Current, 10Flow, 10BetaFeatures, 5Patch-For-Review: Activate Flow as a beta feature on zh.wp - https://phabricator.wikimedia.org/T115100#1721711 (10Shizhao) 5Open>3Resolved [15:23:02] 3Collaboration-Team-Current, 10Flow, 10BetaFeatures: Activate Flow as a beta feature on zh.wp - https://phabricator.wikimedia.org/T115100#1721808 (10revi) [15:25:40] 3Collaboration-Team-Current, 10Flow: Resolve topic does not start summarize - https://phabricator.wikimedia.org/T115337#1721827 (10SBisson) 3NEW a:3SBisson [15:26:14] (03PS1) 10Sbisson: Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) [15:31:14] (03CR) 10Mattflaschen: "The downside of putting the filtering in HistoryPager is that it has to request 500 * OVERFETCH_FACTOR overall, which in turn leads to 100" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [15:34:51] 6Collaboration-Team-Backlog, 10Flow: Impossible to edit Flow board description - https://phabricator.wikimedia.org/T115339#1721859 (10Trizek-WMF) 3NEW [15:38:39] (03PS5) 10Paladox: Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [15:39:15] (03CR) 10Paladox: "This adds the php code sniffer, composer.json was added in a different patch." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [15:42:00] (03CR) 10jenkins-bot: [V: 04-1] Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [15:42:47] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 10MediaWiki-extensions-GettingStarted, and 3 others: undefined method `last_session_ids=' for MediawikiSelenium::BrowserFactory::Chrome:Class (NoMethodError) - https://phabricator.wikimedia.org/T114368#1721894 (10dduvall) a:3dduvall [15:48:39] 3Collaboration-Team-Current, 10Flow: Impossible to edit Flow board description - https://phabricator.wikimedia.org/T115339#1721939 (10SBisson) a:3SBisson [15:51:33] (03PS1) 10Sbisson: Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) [15:53:26] (03PS6) 10Paladox: Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [15:55:25] (03CR) 10jenkins-bot: [V: 04-1] Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:02:35] (03CR) 10Paladox: [C: 04-1] "Fails." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:06:13] (03CR) 10Paladox: "Probaly you should get the php code sniffer to ignore certain files since it is causing some files to cause errors. By adding // codingSta" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:08:23] (03PS7) 10Paladox: Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:10:17] (03CR) 10jenkins-bot: [V: 04-1] Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:13:29] (03PS8) 10Paladox: Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:15:17] (03CR) 10jenkins-bot: [V: 04-1] Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:15:47] (03CR) 10Paladox: [C: 04-1] "Not sure how to fix this." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [16:50:56] (03PS2) 10Matthias Mullie: [WIP] Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) [16:50:59] (03PS7) 10Matthias Mullie: [WIP] Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [16:55:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [16:58:35] 6Collaboration-Team-Backlog, 10Flow: Adding/removing categories to Board description/topic's Summary requires additional page refresh - https://phabricator.wikimedia.org/T115357#1722194 (10Etonkovidova) 3NEW [17:05:41] 6Collaboration-Team-Backlog, 10Flow: Adding/removing categories to Board description/topic's Summary requires additional page refresh - https://phabricator.wikimedia.org/T115357#1722258 (10Etonkovidova) [17:20:06] 3Collaboration-Team-Current, 10Flow: Board description: Switching to VE and clicking Save removes Categories - https://phabricator.wikimedia.org/T115362#1722362 (10Etonkovidova) 3NEW [17:23:25] 3Collaboration-Team-Current, 10Flow, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1722377 (10Etonkovidova) > 2. Adding/removing categories requires additional page refresh after Save to view updates in Categories f... [17:26:20] (03CR) 10Sbisson: [C: 032] Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [17:29:04] (03Merged) 10jenkins-bot: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [17:39:29] (03CR) 10Catrope: [C: 032] Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) (owner: 10Sbisson) [17:40:25] (03CR) 10Catrope: [C: 032] Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) (owner: 10Sbisson) [17:41:04] (03CR) 10Catrope: [C: 032] Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 (owner: 10Sbisson) [17:42:26] (03CR) 10jenkins-bot: [V: 04-1] Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) (owner: 10Sbisson) [17:46:04] (03CR) 10jenkins-bot: [V: 04-1] Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) (owner: 10Sbisson) [17:47:08] (03CR) 10Catrope: [C: 032] Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) (owner: 10Sbisson) [17:48:07] (03CR) 10Catrope: [C: 032] Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) (owner: 10Sbisson) [17:49:07] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 (owner: 10Sbisson) [17:53:11] (03CR) 10jenkins-bot: [V: 04-1] Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) (owner: 10Sbisson) [17:55:22] (03CR) 10jenkins-bot: [V: 04-1] Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) (owner: 10Sbisson) [17:55:55] * RoanKattouw stabs Jenkins [17:56:49] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Flow posts being serialized from HTML -> WT without providing Parsoid data-parsoid attributes? - https://phabricator.wikimedia.org/T115236#1722554 (10Catrope) >>! In T115236#1720756, @mobrovac wrote: > As with the revision, there is no point in ha... [17:57:43] Is it a bogus failure ("Disconnected (1 times), because no message in 60000 ms")? [17:58:49] Yes [17:58:53] That's been happening a lot lately [18:30:05] 3Collaboration-Team-Current, 10Flow: Run subset of Flow browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109678#1722688 (10Mattflaschen) [18:30:19] 3Collaboration-Team-Current, 10Echo: Run subset of Echo browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109679#1722692 (10Mattflaschen) [18:32:34] (03CR) 10Paladox: [C: 031] "Test passes the reason it fails here because it is running the generic test for extension unittests." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [18:56:18] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Site-Requests: Convert LiquidThreads->Flow on fi.wikimedia.org - https://phabricator.wikimedia.org/T104089#1722734 (10Mattflaschen) a:5DannyH>3Catrope [18:56:34] RoanKattouw_away, https://phabricator.wikimedia.org/T104089 [19:01:17] (03CR) 10Catrope: [C: 032] Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) (owner: 10Sbisson) [19:01:27] (03CR) 10Catrope: [C: 032] Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) (owner: 10Sbisson) [19:09:01] 3Collaboration-Team-Current, 10Flow, 10VisualEditor, 10VisualEditor-CopyPaste: 'Uncaught TypeError: Cannot read property 'start' of null' when pasting Categories in VE - https://phabricator.wikimedia.org/T115273#1722766 (10Jdforrester-WMF) p:5Triage>3High [19:11:05] (03Merged) 10jenkins-bot: Fixing summarize after resolve topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245900 (https://phabricator.wikimedia.org/T115337) (owner: 10Sbisson) [19:11:08] (03Merged) 10jenkins-bot: Fix edit board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245918 (https://phabricator.wikimedia.org/T115339) (owner: 10Sbisson) [19:17:55] (03PS1) 10Sbisson: Browser tests: add @integration to some tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245973 [19:18:24] (03CR) 10Sbisson: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245973 (owner: 10Sbisson) [19:21:44] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: add @integration to some tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245973 (owner: 10Sbisson) [20:18:05] matt_flaschen: lol, only 2 pages [20:18:07] OK [20:20:51] Yep [20:25:22] (03PS1) 10Catrope: Fix edit board description [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246076 (https://phabricator.wikimedia.org/T115339) [20:29:59] (03CR) 10jenkins-bot: [V: 04-1] Fix edit board description [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246076 (https://phabricator.wikimedia.org/T115339) (owner: 10Catrope) [20:32:26] (03PS1) 10Catrope: Fix edit board description [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/246079 (https://phabricator.wikimedia.org/T115339) [20:35:33] (03CR) 10jenkins-bot: [V: 04-1] Fix edit board description [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/246079 (https://phabricator.wikimedia.org/T115339) (owner: 10Catrope) [20:38:16] (03PS1) 10Catrope: Fixing summarize after resolve topic [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246080 (https://phabricator.wikimedia.org/T115337) [20:39:17] (03CR) 10Catrope: [C: 032] Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 (owner: 10Sbisson) [20:42:51] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 (owner: 10Sbisson) [20:42:55] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1723227 (10SBisson) >>! In T60975#1705658, @Trizek-WMF wrote: > [[https://zh.wikipedia.org/w/index.ph... [20:59:09] (03PS1) 10Mooeypoo: Allow changing of editable state to revisions and their widgets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) [20:59:49] RoanKattouw, stephanebisson ^^ this is more longer-term fix for the description widget issue + an explanation inline why it works differently than other widgets... see if that is good with you? [20:59:58] RoanKattouw, https://gerrit.wikimedia.org/r/246095 [21:00:13] I'll take a look later [21:00:20] I'm gonna convert fiwikimedia first [21:01:54] (03CR) 10jenkins-bot: [V: 04-1] Allow changing of editable state to revisions and their widgets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [21:06:41] (03PS2) 10Mooeypoo: Allow changing of editable state to revisions and their widgets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) [21:08:45] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Site-Requests: Convert LiquidThreads->Flow on fi.wikimedia.org - https://phabricator.wikimedia.org/T104089#1723369 (10Catrope) Done: https://fi.wikimedia.org/wiki/Kahvihuone [21:08:55] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Site-Requests: Convert LiquidThreads->Flow on fi.wikimedia.org - https://phabricator.wikimedia.org/T104089#1723372 (10Catrope) 5Open>3Resolved [21:11:09] (03CR) 10jenkins-bot: [V: 04-1] Allow changing of editable state to revisions and their widgets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [21:11:22] RoanKattouw: Last week I was able to connect to stat1003 but now I can't ( Permission denied (publickey). ). Any idea? [21:15:14] Hmm [21:15:22] Are you able to ssh into bastion.wmflabs.org? [21:15:31] Sorry I mean bast1001.wikimedia.org [21:20:26] (03CR) 10Catrope: [C: 04-1] Allow changing of editable state to revisions and their widgets (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [21:22:10] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Flow posts being serialized from HTML -> WT without providing Parsoid data-parsoid attributes? - https://phabricator.wikimedia.org/T115236#1723419 (10mobrovac) >>! In T115236#1722554, @Catrope wrote: >>>! In T115236#1720756, @mobrovac wrote: >> As... [21:25:52] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Flow posts being serialized from HTML -> WT without providing Parsoid data-parsoid attributes? - https://phabricator.wikimedia.org/T115236#1723432 (10Catrope) >>! In T115236#1723419, @mobrovac wrote: >> Really? I thought just echoing back the `ETa... [21:32:34] 3Collaboration-Team-Current, 10Flow: Run subset of Flow browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109678#1723472 (10Catrope) p:5Normal>3High [21:32:43] 3Collaboration-Team-Current, 10Echo: Run subset of Echo browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109679#1723473 (10Catrope) p:5Normal>3High [21:33:56] (03CR) 10Sbisson: "Should there be a change to flow-initialize in this patch to move the creation of the description widget before the model initialization?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [21:34:21] RoanKattouw: no, same error [21:34:50] (03CR) 10Catrope: "Note that the qunit failure on this patch is real (unlike all the bogus failures we've seen recently)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [21:35:27] stephanebisson, Strange. Have you tried forcing the SSH key to use with ssh -i ~/.ssh/id_rsa_production sbisson@bast1001.wikimedia.org ? [21:35:46] (03PS3) 10Mooeypoo: Allow changing of editable state to revisions and their widgets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) [21:35:48] RoanKattouw: yes, but doesn't help [21:36:00] Hmph [21:36:07] Then I recommend asking for help in #wikimedia-operations [21:36:43] The entire ops team is in the same place this week, so you should find it either very easy or very difficult to get help [21:38:45] (03CR) 10jenkins-bot: [V: 04-1] Allow changing of editable state to revisions and their widgets [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [21:39:48] 3Collaboration-Team-Current, 10Flow: Safari and FF do not display Categories on Flow pages - https://phabricator.wikimedia.org/T115411#1723527 (10Etonkovidova) 3NEW [21:40:12] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Notification state in output HTML is cached excessively - https://phabricator.wikimedia.org/T109997#1723536 (10Legoktm) >>! In T109997#1577743, @Catrope wrote: > This happens because pages you viewed while you had notifications get cached by yo... [21:43:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 7WorkType-NewFunctionality: Remove tooltips from dropdown menu in post and topic header - https://phabricator.wikimedia.org/T101198#1723549 (10Etonkovidova) Checked in betalabs - Chrome 45, FF 41, Safari 9.0. [21:46:34] stephanebisson, I'm running into a weird issue with browser tests in Flow -- 90% of them fail for me, and when I looked, it seems they're going to the "wrong" wiki. They're checking localhost/wiki instead of the vagrant localhost:8080/wiki [21:46:51] but my environments.yml file defines mw-vagrant-host as the default [21:46:58] ... so what's going on :( [21:47:40] mooeypoo: echo $MEDIAWIKI_ENVIRONMENT ? [21:48:01] mw-vagrant-guest' [21:48:05] the wrong one! :( [21:48:20] I can change itwith MEDIAWIKI_ENVIRONMENT=mw-vagrant-host [21:48:24] but why would it override default [21:49:39] ok i'll run the tests again, but this is weird. [21:50:29] mooeypoo: MEDIAWIKI_ENVIRONMENT=local is the only config that I know to work [21:53:34] 3Collaboration-Team-Current, 10Flow: Board description: Switching to VE and clicking Save removes Categories - https://phabricator.wikimedia.org/T115362#1723591 (10Catrope) Is this reproducible in normal VE as well? [22:02:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 7WorkType-NewFunctionality: Categories box is misaligned on Flow pages? - https://phabricator.wikimedia.org/T111110#1723612 (10Etonkovidova) Questions: 1. Categories added to Board description will be displaye... [22:03:46] (03CR) 10Catrope: [C: 032] Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 (owner: 10Sbisson) [22:04:01] 3Collaboration-Team-Current, 10Flow, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1723625 (10Etonkovidova) Also look at the comment on https://phabricator.wikimedia.org/T111110 (some display issues). [22:06:53] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: Use button text instead of title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245880 (owner: 10Sbisson) [22:08:40] 3Collaboration-Team-Current, 10Flow: Board description: Switching to VE and clicking Save removes Categories - https://phabricator.wikimedia.org/T115362#1723649 (10Etonkovidova) [22:08:41] 6Collaboration-Team-Backlog, 10Flow: Adding/removing categories to Board description/topic's Summary requires additional page refresh - https://phabricator.wikimedia.org/T115357#1723650 (10Etonkovidova) [22:08:43] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 7WorkType-NewFunctionality: Categories box is misaligned on Flow pages? - https://phabricator.wikimedia.org/T111110#1723651 (10Etonkovidova) [22:08:47] 3Collaboration-Team-Current, 10Flow, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1723648 (10Etonkovidova) [22:22:21] 3Collaboration-Team-Current, 10Flow: Adding Categories makes Board description unavailable for editing - https://phabricator.wikimedia.org/T115415#1723692 (10Etonkovidova) 3NEW [22:28:07] (03PS1) 10Catrope: Update compiled Handlebars files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246113 [22:28:35] mooeypoo, ---^^ [22:29:35] (03CR) 10Mooeypoo: [C: 032] Update compiled Handlebars files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246113 (owner: 10Catrope) [22:30:10] 3Collaboration-Team-Current, 10Flow: Safari and FF do not display Categories on Flow pages - https://phabricator.wikimedia.org/T115411#1723732 (10Catrope) a:3Mooeypoo I can reproduce this in Chrome too. [22:30:22] 3Collaboration-Team-Current, 10Flow: Categories flash and disappear on Flow pages - https://phabricator.wikimedia.org/T115411#1723734 (10Catrope) [22:32:43] (03Merged) 10jenkins-bot: Update compiled Handlebars files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246113 (owner: 10Catrope) [22:36:00] (03PS1) 10Mooeypoo: Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) [22:36:07] RoanKattouw, ^^ [22:36:59] (03CR) 10Catrope: [C: 032] Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) (owner: 10Mooeypoo) [22:38:37] (03CR) 10Mooeypoo: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246095 (https://phabricator.wikimedia.org/T115339) (owner: 10Mooeypoo) [22:40:12] (03CR) 10jenkins-bot: [V: 04-1] Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) (owner: 10Mooeypoo) [22:47:36] (03CR) 10Catrope: [C: 032] Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) (owner: 10Mooeypoo) [22:50:37] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1723788 (10Catrope) 3NEW [22:51:01] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1723798 (10Catrope) [22:51:01] (03CR) 10jenkins-bot: [V: 04-1] Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) (owner: 10Mooeypoo) [22:51:02] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1723797 (10Catrope) [22:51:30] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: simplify notification items - https://phabricator.wikimedia.org/T114357#1723800 (10Catrope) [22:51:31] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1723788 (10Catrope) [22:54:12] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1723807 (10Catrope) [22:56:36] (03CR) 10Catrope: [C: 032] Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) (owner: 10Mooeypoo) [22:59:31] (03Merged) 10jenkins-bot: Remove existing categories from DOM after the widget ate them [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246114 (https://phabricator.wikimedia.org/T115411) (owner: 10Mooeypoo) [22:59:52] 3Collaboration-Team-Current, 10Echo: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1723840 (10Catrope) 3NEW [23:04:18] (03CR) 10Catrope: [C: 032 V: 032] Fixing summarize after resolve topic [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246080 (https://phabricator.wikimedia.org/T115337) (owner: 10Catrope) [23:04:24] (03CR) 10Catrope: [C: 032 V: 032] Fix edit board description [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/246079 (https://phabricator.wikimedia.org/T115339) (owner: 10Catrope) [23:04:32] (03CR) 10Catrope: [C: 032 V: 032] Fix edit board description [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246076 (https://phabricator.wikimedia.org/T115339) (owner: 10Catrope) [23:04:47] (03PS1) 10Catrope: Remove existing categories from DOM after the widget ate them [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246124 (https://phabricator.wikimedia.org/T115411) [23:04:55] (03CR) 10Catrope: [C: 032 V: 032] Remove existing categories from DOM after the widget ate them [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/246124 (https://phabricator.wikimedia.org/T115411) (owner: 10Catrope) [23:06:31] 6Collaboration-Team-Backlog, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1723894 (10Catrope) 3NEW [23:07:47] 6Collaboration-Team-Backlog, 10Echo: Implement compressed rendering of notifications - https://phabricator.wikimedia.org/T115422#1723904 (10Catrope) 3NEW [23:09:47] 6Collaboration-Team-Backlog, 10Echo: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1723912 (10Catrope) 3NEW [23:10:23] 3Collaboration-Team-Current, 10Echo: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1723912 (10Catrope) [23:10:45] 6Collaboration-Team-Backlog, 10Echo: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1723923 (10Catrope) [23:20:32] (03PS1) 10Mooeypoo: Display clean titles for categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246127 [23:20:33] RoanKattouw, ^^ [23:23:12] (03PS2) 10Mooeypoo: Display clean titles for categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246127 [23:26:15] (03PS3) 10Mooeypoo: Display clean titles for categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246127 [23:29:00] (03CR) 10jenkins-bot: [V: 04-1] Display clean titles for categories [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246127 (owner: 10Mooeypoo)