[00:03:14] (03PS1) 10Catrope: Close popup when badge is clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242414 (https://phabricator.wikimedia.org/T114106) [00:03:53] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: The notifications badge should close the notification panel when it is already open - https://phabricator.wikimedia.org/T114106#1687798 (10Catrope) [00:04:18] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1687802 (10Catrope) Ran successfully on mediawiki.org [00:04:32] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: The notifications badge should close the notification panel when it is already open - https://phabricator.wikimedia.org/T114106#1687803 (10Catrope) a:3Catrope [00:05:15] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: [beta] RTL Echo notifications incorrect display - https://phabricator.wikimedia.org/T114184#1687807 (10Catrope) a:3Mooeypoo [00:05:47] 3Collaboration-Team-Current, 10Flow, 7Regression: [Regression 1.27.0-wmf1] Posting Flow topics / replies incredibly slow on testwiki - https://phabricator.wikimedia.org/T114174#1687822 (10Catrope) 5Open>3Invalid a:3Catrope Seems to have gone away mysteriously on testwiki, and isn't happening on mediawi... [00:05:53] 6Collaboration-Team-Backlog, 10Flow, 7Regression: [Regression 1.27.0-wmf1] Posting Flow topics / replies incredibly slow on testwiki - https://phabricator.wikimedia.org/T114174#1687825 (10Catrope) [00:07:23] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1687830 (10Catrope) a:5Mattflaschen>3Catrope [00:25:51] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1687891 (10Catrope) I've successfully converted https://se.wikimedia.org/wiki/Diskussion:N%C3%A4sta_dagordning as a test. The main... [00:31:25] I'm running the sewikimedia conversion and it's going well, but I fell for the same bash bug that Matt found [00:31:34] Where inline replace doesn't work for things with non-ASCII chars in them [00:34:49] Guess what, there's a lot of LQT pages on a Swedish wiki that contain both / and ä, ö or å [00:36:44] RoanKattouw, for one-offs you did with convertLqtPageOnLocalWiki.php? [00:37:09] RoanKattouw, I was expecting we would use convertAllLqtPages.php for the real one. [00:37:53] (03PS1) 10Mooeypoo: Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [00:38:01] RoanKattouw: Never! ;-) [00:39:49] (03CR) 10jenkins-bot: [V: 04-1] Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [00:42:20] matt_flaschen: I chickened out and did them all with that script [00:42:33] :( [00:42:35] But yeah I'll use convertAll for round 2 then [00:42:43] "them all" = all the ones that didn't have accents [00:43:25] I was also planning to test on Beta first, but probably a bit late for that. [00:43:43] (03PS6) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [00:43:54] (03PS2) 10Mooeypoo: Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [00:44:07] OK that seems to be working just fine [00:44:09] RoanKattouw, how did you even get the list of all of them? Just allpages or something? [00:44:21] Same trick as you did [00:44:26] ? [00:44:48] For the prior round we only did it page-by-page because of the order restrictions (user talk last or whatever), and I got the lists from pageswithprop. But that won't give you the full list on opt-out wiki. [00:45:02] Yeah I used pageswithprop [00:45:10] Are you sure? [00:45:14] It gave me 200+ pages [00:45:57] They have about 8,000. I don't know how many of those are talk, though. Let me check. [00:46:28] OK [00:46:30] (03CR) 10jenkins-bot: [V: 04-1] Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [00:46:31] Well it's certainly doing all of them now [00:46:45] (03CR) 10jenkins-bot: [V: 04-1] Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [00:46:46] 1,070 [00:46:46] The ones I see are all accent + slash pages so far, but we'll see [00:46:51] Aha [00:47:01] The API only gave me 265 [00:47:03] Good catch then [00:47:28] (03PS7) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [00:47:37] RoanKattouw, yeah, useliquidthreads:1 allows you to opt in to LQT, and useliquidthreads:0 lets you opt-out. But if it's on by default, you don't need either. [00:47:44] Oooh [00:47:51] That's why some of the convresions at the end were no-ops [00:47:57] Those were uselqt:0 pages [00:47:57] 3Collaboration-Team-Current, 10MediaWiki-extensions-GuidedTour, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Guided tour: clicking Back button displays an error in Console - https://phabricator.wikimedia.org/T114144#1687937 (10Jdforrester-WMF) [00:48:08] 6Collaboration-Team-Backlog, 10Flow, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Flow usertalk beta feature - opt-out can result in Internal error "CAS update failed" - https://phabricator.wikimedia.org/T114023#1687942 (10Jdforrester-WMF) [00:48:23] RoanKattouw, that's the reason we needed https://phabricator.wikimedia.org/T109931 [00:48:38] Yup that's coming back to me now [00:48:41] Silly me [00:49:05] I should have asked to have a quick brain dump about this. [00:49:10] (03PS8) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [00:49:19] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1688012 (10Jdforrester-WMF) [00:49:19] I should have asked *you* to give me a brain dump :) [00:49:32] Instead I went and copypasted bash snippets from the mw.org task that had known Unicode bugs in them [00:49:39] And did something fundamentally silly [00:49:47] Oh well, I guess I accidentally gave us a 1000-page test set [00:49:54] *100-page [00:49:59] In addition to the 1 page I started with [00:50:03] (03PS6) 10Mattflaschen: Fix exception on board history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) [00:50:28] (03PS9) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [00:50:44] Finally. [00:51:23] (03PS3) 10Mooeypoo: Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [00:51:25] RoanKattouw, at least you weren't in Sweden when doing this. That's more than I can say with https://www.mediawiki.org/wiki/Talk:Groups/Proposals/Ciudad_de_M%C3%A9xico [00:51:33] LOL [00:51:37] That's right! [00:53:07] The best I can say is that I started right around the scheduled departure time of https://flightaware.com/live/flight/SAS936 [00:53:28] But since Oakland has direct flights to Sweden now that doesn't count any more [00:53:54] (03CR) 10jenkins-bot: [V: 04-1] Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [00:54:19] Konversation's color hashing algorithm is killing me. [00:54:33] Am I the same color as krrrit-wm or something? [00:54:34] (03PS4) 10Mooeypoo: Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [00:54:46] MatmaRex, mooeypoo, RoanKattouw, and krrrit-wm are all the exact same color. [00:55:09] United colors of collabeneton [00:55:54] Yeah now it's definitely processing default stuff [00:56:01] Like user talk pages of users with ~sewikimedia in their name [00:56:03] (Hello legoktm ) [00:56:24] (03CR) 10Mattflaschen: Fix exception on board history page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [00:56:51] 3Collaboration-Team-Current, 10MediaWiki-extensions-GuidedTour, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Guided tour: clicking Back button displays an error in Console - https://phabricator.wikimedia.org/T114144#1688070 (10Jdforrester-WMF) [01:01:50] (03CR) 10Mattflaschen: "The ordering thing is fixed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [01:04:02] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7Regression, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Add 'target-page' for edit-user-talk - https://phabricator.wikimedia.org/T112477#1688086 (10Jdforrester-WMF) [01:04:28] hehehe [01:05:06] there's a few million of those [01:14:20] I'm using composition of my own free will. Stephane will be happy. [01:38:21] RoanKattouw, the quarterly review conflicts with my doctor's appointment. I can probably reschedule the appointment. We'll see. [01:38:52] matt_flaschen: Sorry for just spamming everyone with that. No requirement to attend unless you actively want to. [01:41:41] Yeah the QR is optional if you're not me or Danny [01:42:03] And due to hangout limits we probably don't want too many people to actually be in the video call either [01:42:36] OK sewikimedia is done [01:42:46] Snuck up on me while I was talking to Moriel [01:43:05] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1688148 (10Catrope) The conversion is finished now. I'll post the logs later. [01:43:37] I'll check to see if there were errors in the logs later, and do pt tomorrow [01:43:46] But a rerun of the conversion was a no-op so I think we're probably fine [01:46:48] RoanKattouw_away, alright, I guess I won't reschedule it then, which means probably not making QR. [01:51:21] 6Collaboration-Team-Backlog, 10Echo: Significant performance degradation in new (split) notifications - https://phabricator.wikimedia.org/T114012#1688153 (10Ijon) Great, thanks! (was I really the first one to file a bug about it in the current iteration? o_O) [08:50:16] 6Collaboration-Team-Backlog, 10Flow: When I want to reply to a Flow Topic on Chromium, scrolling goes weird. - https://phabricator.wikimedia.org/T114139#1688488 (10Trizek-WMF) As far as I can understand the console, I don't see any error (no red blinking alert message). [09:43:42] 6Collaboration-Team-Backlog, 10Flow: When I want to reply to a Flow Topic on Chromium, scrolling goes weird. - https://phabricator.wikimedia.org/T114139#1688617 (10Josve05a) Same problem as some have with section-links not working properly on wikis? (Something about autocollapse, and scrolls to the top...) [10:59:05] 3Collaboration-Team-Current, 10Flow: Beta features: "Discussion" link should go to Talk:Flow - https://phabricator.wikimedia.org/T114197#1688776 (10SBisson) The info link goes to **Project:Flow** on the local wiki or falls back to https://www.mediawiki.org/wiki/Extension:Flow The discussion link goes to **Proj... [12:10:10] (03CR) 10Sbisson: [C: 032] Close popup when badge is clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242414 (https://phabricator.wikimedia.org/T114106) (owner: 10Catrope) [12:12:30] (03Merged) 10jenkins-bot: Close popup when badge is clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242414 (https://phabricator.wikimedia.org/T114106) (owner: 10Catrope) [12:52:46] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1689016 (10Pginer-WMF) > The concept of "this wiki" and "other wikis" requires more processing. I think it makes sense to make the origin of the notifications more explicit t... [13:16:10] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1689074 (10Ainali) When I try to use flow, the top of the editing field says: "Error: One or more dependencies failed to load". [13:17:11] 6Collaboration-Team-Backlog, 10Echo: Define how to expose cross-wiki notifications to users - https://phabricator.wikimedia.org/T114237#1689076 (10Pginer-WMF) 3NEW [13:47:04] (03PS1) 10Sbisson: [WIP] Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) [13:50:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) (owner: 10Sbisson) [14:05:47] 6Collaboration-Team-Backlog, 10Flow: DataModelException - https://phabricator.wikimedia.org/T114240#1689193 (10Sunpriat) 3NEW [14:07:42] (03PS2) 10Sbisson: [WIP] Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) [14:11:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) (owner: 10Sbisson) [14:12:57] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) (owner: 10Sbisson) [14:24:41] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 2 others: bodyOnly is now body_only - https://phabricator.wikimedia.org/T114185#1689292 (10cscott) [14:30:41] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 3 others: bodyOnly is now body_only - https://phabricator.wikimedia.org/T114185#1689335 (10cscott) [14:31:47] (03PS3) 10Sbisson: Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) [14:34:26] (03PS1) 10Cscott: Rename RESTBase1/Parsoid3 `bodyOnly` parameter to `body_only` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242565 (https://phabricator.wikimedia.org/T114185) [14:35:31] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1689360 (10Ainali) It seemed to be solved now through these changes: https://se.wikimedia.org/w/index.php?title=MediaWiki%3ACommon.... [14:39:04] (03PS1) 10Matthias Mullie: [WIP] Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [14:39:36] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 7Easy: send Flow browser test job notices to #wikimedia-corefeatures channel - https://phabricator.wikimedia.org/T66103#1689392 (10zeljkofilipin) [14:45:33] (03CR) 10Ppchelko: [C: 031] Rename RESTBase1/Parsoid3 `bodyOnly` parameter to `body_only` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242565 (https://phabricator.wikimedia.org/T114185) (owner: 10Cscott) [14:51:34] (03CR) 10Sbisson: [C: 032] Rename RESTBase1/Parsoid3 `bodyOnly` parameter to `body_only` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242565 (https://phabricator.wikimedia.org/T114185) (owner: 10Cscott) [14:54:44] (03Merged) 10jenkins-bot: Rename RESTBase1/Parsoid3 `bodyOnly` parameter to `body_only` [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242565 (https://phabricator.wikimedia.org/T114185) (owner: 10Cscott) [15:30:56] 6Collaboration-Team-Backlog, 10Flow: Firefox extension Adblock plus with filter EasyPrivacy blocks Flow when a banner is displayed - https://phabricator.wikimedia.org/T114257#1689590 (10Trizek-WMF) 3NEW [15:36:02] (03PS1) 10Sbisson: Browser tests: eliminate deprecation warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242586 [15:37:06] (03PS4) 10Sbisson: [WIP] Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) [15:41:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Hide actions when viewing a board through Special:Undelete [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242544 (https://phabricator.wikimedia.org/T114043) (owner: 10Sbisson) [15:53:53] etonkovidova: did you update that event w/ Oren for tomorrow? mine still says 1pm [15:55:08] marxarelli: nope - Oren confirmed that he is coming at 1:30 [15:55:22] etonkovidova: ok, can you update it? [15:55:50] marxarelli: yes :) [15:56:20] etonkovidova: rad. thanks! i have a packed day tomorrow so the accurate calendaring is helpful [15:57:27] marxarelli: so you cannot spare more than 30 min? Just in case... [15:58:16] etonkovidova: more than 30 minutes is fine. i just need to know when we're starting :) [15:58:33] marxarelli: ok then - thx! [16:09:19] 3Collaboration-Team-Current, 10MediaWiki-extensions-GuidedTour, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Guided tour: clicking Back button displays an error in Console - https://phabricator.wikimedia.org/T114144#1689761 (10Etonkovidova) Checked in... [16:11:34] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): The notifications badge should close the notification panel when it is already open - https://phabricator.wikimedia.org/T114106#1689778 (10Etonkovidova) Checked in betalabs. [16:29:07] (03PS1) 10Legoktm: FlowUpdateBetaFeaturePreference: Add missing parent constructor call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242598 [16:32:39] (03CR) 10Sbisson: [C: 032] FlowUpdateBetaFeaturePreference: Add missing parent constructor call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242598 (owner: 10Legoktm) [16:34:21] (03CR) 10jenkins-bot: [V: 04-1] FlowUpdateBetaFeaturePreference: Add missing parent constructor call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242598 (owner: 10Legoktm) [16:35:47] stephanebisson, I ran into a small problem with the browser tests for Echo that you might have an idea on how to fix? [16:36:03] shoot [16:36:12] Look at the last scenario here: https://gerrit.wikimedia.org/r/#/c/242422/4/tests/browser/features/notifications.feature [16:36:25] Well, both scenarios have that issue [16:37:03] So, I wanted to test more than 1 notifications. I have an api user that mentions the tested user and also adds a topic to a board they follow [16:37:29] (03Merged) 10jenkins-bot: FlowUpdateBetaFeaturePreference: Add missing parent constructor call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242598 (owner: 10Legoktm) [16:37:38] Problem is this: I have to refresh between both actions to "draw" some time, because otherwise, at least on my machine, if I do action A and action B and then refresh, the counter still shows 1 [16:38:00] If I refresh again, I get 2. So, it seems it takes a moment for the second notification to show up [16:38:11] I couldn't use "refresh until" because it's the popup [16:38:24] I thought of doing something like "click the popup until" but that's pretty convoluted [16:39:00] I guess I can do refresh_until the counter changes, since the counter is also on the php call, but at this point I'm not sure if that's the right thing to do. [16:39:01] Thoughts? [16:39:38] refresh_until the popup shows "2" seems ok [16:40:11] but it's an Echo test, and it will fail if I don't have Flow [16:40:23] Flow depends on Echo, not the other way around [16:40:29] ... good point [16:40:44] Meh, but there's no real way of testing 2 notifications then [16:40:50] Mention is an alert [16:41:04] And alerts don't have "unread" status, nor the "mark as read" button [16:41:10] if 2 people leave messages on my talk page [16:41:23] so I have to test messages. But a message is either a talk page message or a flow board message on something you follow [16:41:29] well.. I guess I can have 2 api users [16:41:45] We're already going to have a bit of a problem with API users, btw, according to marxarelli [16:41:58] shared wikis don't have user factory [16:42:30] I don't use user_factory, at least not in it's current form [16:42:40] it's actually really convenient [16:42:47] as_user(:b) api.create_page .... [16:42:48] not for me [16:42:53] opt_in feature is creating users like no tomorrow [16:43:05] Hm, good point. [16:43:16] it only works in you have a finite number of users that are specified in your env yaml [16:43:24] Yeah [16:43:40] Well, if I only need 2 api users and 1 tested user, I can still use the factory [16:43:47] sure [16:44:07] wait, no, the fallback only works if you specify users in the yaml file. The user factory:true thing is supposedly instead of that [16:44:18] but it doesn't work on shared wikis [16:44:32] well, if it's not gonna work on beta, forget it [16:44:52] Yeah, ha, I don't know if beta is considered shared, but yeah. [16:45:04] mooeypoo: as_user isn't part of the user factory [16:45:13] it simply switches between user contexts [16:45:20] Okay, I'll create another api user. I think it's probably enough, but if I see we need more, I'll do what opt_in feature does [16:45:28] marxarelli, but which definition does it use for the user? [16:45:32] which _can_ be handled automatically by the factory but can also be mapped from environments.yml [16:46:07] right, so if I have to have 5 users, I'll have to add mediawiki_user_b, _c, _d, _e, _f etc to the yaml file [16:46:20] as opposed to creating users on the fly in the code [16:46:40] I would like to see as_new_user { do_something } [16:46:49] that'll be great [16:47:26] stephanebisson, btw, so I'll edit and work on the top commit in that chain (the one I showed you) but the underlying one is probably ready for review/merge [16:47:53] oh, I need to take out the Flow test from it. [16:48:05] mooeypoo: I'm confused [16:48:26] which one can I review/merge? [16:48:39] stephanebisson, I have two commits on a chain: https://gerrit.wikimedia.org/r/#/c/242016 and https://gerrit.wikimedia.org/r/#/c/242422/ [16:49:21] I separated them because the underlying one was notifications and when it was done, I started working on the mark-all-read button, which seemed to be another piece, so I added it on top. [16:49:47] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: [beta] RTL Echo notifications incorrect display - https://phabricator.wikimedia.org/T114184#1689912 (10Etonkovidova) Checked in betalabs for hewiki and fawiki {F2646407} {F2646411} [16:49:56] I thought the bottom one (242016) was ready but you're making a good point about Flow, I'll have to take that test out [16:50:45] (03PS1) 10Legoktm: dirname( __FILE__ ) → __DIR__ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242600 [16:51:18] 3Collaboration-Team-Current, 10Flow: Opt-in is automatically enabling users who previously had the "Automatically enable all new beta features" checked - https://phabricator.wikimedia.org/T114266#1689918 (10Quiddity) 3NEW [16:51:30] eh [16:51:46] (03CR) 10Sbisson: [C: 032] dirname( __FILE__ ) → __DIR__ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242600 (owner: 10Legoktm) [16:52:29] stephanebisson, so, it might actually be a good idea to test that when someone adds a topic you watch ,you get a notification for it. Should we add that in Flow ? [16:52:45] mooeypoo: sure [16:53:14] That would mean duplicating some of the "click badge / open popup / count notifications / etc" steps into Flow [16:53:22] can we reuse them from Echo ? [16:53:52] not really [16:54:10] unless you want to publish EchoPage as a gem [16:54:16] mooeypoo: yes, if you had to simulate five users in a shared environment like beta, you'd have to specify each one in environments.yml [16:54:43] Hm, actually might not be a terrible idea at some point, seeing as other extensions *could* use it in their tests if we allow for them to add notifications [16:55:31] marxarelli, okay, I don't thik I need that many users, so I think this should still be okay for Echo [16:55:32] stephanebisson: the idea with the user factory is that all users are new (you control all user preconditions) [16:55:52] mooeypoo: yeah, that seems like a lot :) [16:56:28] (03Merged) 10jenkins-bot: dirname( __FILE__ ) → __DIR__ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242600 (owner: 10Legoktm) [16:56:30] stephanebisson: but it was only intended for isolated environments like CI where leaving garbage around isn't a problem [16:56:50] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1689958 (10DannyH) 5Open>3Resolved [16:56:54] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Flaky test "ext.flow: mediawiki.ui.enhance Forms with required fields" - https://phabricator.wikimedia.org/T111459#1689959 (10DannyH) 5Open>3Resolved [16:56:56] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 5Patch-For-Review: Flow thanked posts aren't remembered across sessions - https://phabricator.wikimedia.org/T88820#1689962 (10Quiddity) @Mattflaschen Is the UI aspect meant to be addressed in this task (in which case it should stay open) or in {T101342} (in wh... [16:57:03] marxarelli: what/where is CI env? I think our tests in CI are running against beta [16:57:11] marxarelli, yeah but doing as_user(:b) { ... } means that if user_b already did something it isn't new anymore. You will need to remember in the code which user is new or not. In Echo's case it doesn't really matter, because the api users are only needed to post stuff, but I can see how we should be able to do "give me another user to do X" and reuse that step each time with a new new user [16:57:41] 3Collaboration-Team-Current, 10MediaWiki-extensions-GuidedTour, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Guided tour: clicking Back button displays an error in Console - https://phabricator.wikimedia.org/T114144#1689968 (10DannyH) 5Open>3Resolved [16:57:49] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: [beta] RTL Echo notifications incorrect display - https://phabricator.wikimedia.org/T114184#1689970 (10DannyH) 5Open>3Resolved [16:57:53] stephanebisson: right, by CI i mean gerrit trigger CI, not periodic Jenkins jobs [16:57:56] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7Regression, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): Add 'target-page' for edit-user-talk - https://phabricator.wikimedia.org/T112477#1689972 (10DannyH) 5Open>3Resolved [16:57:58] *triggered* [16:58:04] I see [16:58:06] stephanebisson: zuul [16:58:12] stephanebisson: https://www.mediawiki.org/wiki/Continuous_integration/Browser_tests [16:59:20] For Flow, most features are just anon, some do log in, and only 1 cares about having new users everytime [16:59:28] stephanebisson: i could see a case for `as_new_user` in cases where you want to ignore the entry in environments.yml and create one from scratch, but there's an issue would using something like that in Cucumber where generalized steps have no knowledge of one another [17:00:03] e.g. "Given I'm logged in as a new user" might use `as_new_user` in its implementation [17:00:23] marxarelli, yeah exactly [17:00:32] but how does a general "And I'm on the x page" know to do the same [17:00:48] Why do you need a username for that step? [17:00:52] in a linear form like rspec, it's easier to implement and make sense of [17:01:01] mooeypoo: ok, bad example :) [17:01:33] What I mean is that I think in most of the cases where we explicitly need a new user, it's mostly restricted in what it does to test specific things for a new user [17:01:59] I can see how it can be an issue. But most of the steps I write are not meant to be generic, they only serve the current feature file [17:02:15] so, example, you can have something like @newuser = new_user if you really need to share it between steps, and be assured that the user you have no is actually completely new [17:02:24] reuse is happening on the page, with no knowledge of the context or user [17:02:48] stephanebisson: that's a better approach i think, but cucumber doesn't make it easy :) [17:03:01] they even consider it an antipattern [17:03:06] anyway, sorry, brb [17:03:24] enjoy your meeti. [17:03:30] :) [17:13:46] 6Collaboration-Team-Backlog, 10WikiLove, 10Possible-Tech-Projects, 10UI-Standardization: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1690061 (1001tonythomas) Is the work huge enough for an Outreachy/GSoC slot, or should it go along with couple more from https://pha... [17:17:13] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-06_(1.27.0-wmf.2): The notifications badge should close the notification panel when it is already open - https://phabricator.wikimedia.org/T114106#1690075 (10DannyH) 5Open>3Resolved [17:17:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Catchable fatal error: Argument 1 passed to Flow\UrlGenerator::boardLink() must be an instance of Title, null given - https://phabricator.wikimedia.org/T113312#1690077 (10DannyH) 5Open>3Resolved [17:17:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 7WorkType-Maintenance: Adjust to removal of Connection::getSingleton in Cirrus - https://phabricator.wikimedia.org/T111164#1690079 (10DannyH) 5Open>3Resolved [17:17:37] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1690083 (10DannyH) [17:17:43] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1), 7WorkType-NewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1690084 (10DannyH) 5Open>3Resolved [17:17:57] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1690086 (10DannyH) 5Open>3Resolved [17:24:44] (03PS10) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [17:33:42] * legoktm is trying new headphones today [17:40:34] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [17:42:27] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T108363#1690171 (10Quiddity) [17:42:29] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T85563#1690172 (10Quiddity) [17:43:44] 3Collaboration-Team-Current, 10Flow, 5MW-1.27-release-notes, 5Patch-For-Review, and 3 others: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1690182 (10Catrope) a:5matthiasmullie>3Catrope [17:43:45] 6Collaboration-Team-Backlog, 10Flow: Add Mediawiki:Histlegend to Board/Topic history pages - https://phabricator.wikimedia.org/T101420#1690184 (10Quiddity) [17:43:47] 6Collaboration-Team-Backlog, 10Flow: Add "View logs for this page" link to Flow board and topic history pages - https://phabricator.wikimedia.org/T96455#1690185 (10Quiddity) [17:43:49] 6Collaboration-Team-Backlog, 10Flow: Add log entries to history pages - https://phabricator.wikimedia.org/T90071#1690187 (10Quiddity) [17:43:51] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1690188 (10Mattflaschen) [17:44:08] 3Collaboration-Team-Current, 10Flow, 7Blocked-on-Parsoid: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1633004 (10Mattflaschen) [18:00:31] mlitn, do you remember if we took notes in the memcached/indexing meeting? [18:01:17] I didn’t, don’t think RoanKattouw_away did either [18:01:49] 6Collaboration-Team-Backlog, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1690234 (10Mattflaschen) I think where we ended up in the meeting was that we should gradually reduce the memcached time to live, preferably while keeping performance metr... [18:03:37] mlitn, remember anything else important/is that takeaway right? [18:03:48] Updates from scrum of scrums: [18:04:20] * Parsoid team is still working on our issues, at least the {{{foo}}} one. However, someone is on vacation, so it might be a little while for the remaining two parts (one part is fixed) [18:04:42] * Aaron brought up the memcached/master queries stuff again. [18:04:53] * External store was brought up in general terms, but we already know we need to resync with Jaime. [18:05:58] mooeypoo: so the modern styles are being applied, except there are :hover styles that are overriding our own?? [18:06:25] 3Collaboration-Team-Current, 10Flow, 6Parsing-Team, 10Parsoid, and 3 others: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1690263 (10ssastry) @mattflaschen I created a new topic and 3 replies right now .. http://test.wikimedia.beta.wmflabs.org/wiki/Topic:Spwqw5x... [18:07:33] matt_flaschen: other than what was in Roan’s mail, we also discussed lowering cache TTL to test how much/where it would hurt us to take it away entirely [18:07:52] 3Collaboration-Team-Current, 10Flow: Freeze LQT on se.wikimedia - https://phabricator.wikimedia.org/T114277#1690264 (10SBisson) 3NEW [18:08:22] 3Collaboration-Team-Current, 10Flow: Freeze LQT on pt.wikibooks - https://phabricator.wikimedia.org/T114278#1690271 (10SBisson) 3NEW [18:08:52] mooeypoo: also I'm seeing mark as read "X"s in the alerts flyout [18:08:56] popup* [18:08:58] mlitn, yeah, that's what I mentioned in Phabricator. What's the subject of his mail? I guess we should copy those notes to Phabricator. [18:09:09] 3Collaboration-Team-Current, 10Flow: Opt-in is automatically enabling users who previously had the "Automatically enable all new beta features" checked - https://phabricator.wikimedia.org/T114266#1690280 (10SBisson) a:3SBisson [18:09:48] matt_flaschen: “Concerns about WANCache strategy” [18:10:11] Oh yeah. [18:10:49] 6Collaboration-Team-Backlog, 10Flow: DataModelException - https://phabricator.wikimedia.org/T114240#1690288 (10Mattflaschen) Probably a duplicate of {T111494} [18:20:28] 6Collaboration-Team-Backlog, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1690380 (10Mattflaschen) The other possible approach is to replace merge with delete. WANObjectCache has special provisions to allow a delete() to win even if a stale set... [18:22:51] (03CR) 10Sbisson: [C: 04-1] Add browser test for notifications in Echo (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [18:25:13] (03PS1) 10Legoktm: Also override Modern's :hover styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242631 (https://phabricator.wikimedia.org/T114080) [18:26:05] (03PS2) 10Legoktm: Also override Modern's :hover styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242631 (https://phabricator.wikimedia.org/T114080) [18:32:07] legoktm, my local wiki doesn't seem to add "Thanks" to an alert. I'm thanking test user for a comment on a Flow board, and it doesn't appear in test user's alerts. Am I missing something? [18:32:38] does the user have thanks enabled in their preferences? [18:32:42] I forget what the default is [18:32:57] oh, hm let me check. Though I do have older alerts in their popup about thanks [18:33:27] yeah thanks is enabled for both web and email [18:34:23] hm... NOW it appears [18:34:24] wtf. [18:34:48] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 7Easy: send Echo and Flow (and any Collaboration team extensions with browser tests) browser test job notices to #wikimedia-collaboration channel - https://phabricator.wikimedia.org/T66103#1690428 (10Mattflaschen) [18:34:52] okay seriously, is my computer THAT slow [18:36:19] okay, I think I found the issue. I think it's with the popup loading new alerts [18:37:32] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1690431 (10SBisson) The IE job can be deleted since it's never going to pass unless we recreate the IE browser factory in mediawiki_selenium. The other jobs a... [18:37:53] (03PS1) 10Mooeypoo: Initialize 'mark as read' button hidden unless needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242636 (https://phabricator.wikimedia.org/T113629) [18:42:10] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 5Patch-For-Review: Flow thanked posts aren't remembered across sessions - https://phabricator.wikimedia.org/T88820#1690464 (10Mattflaschen) 5Open>3Resolved I guess {T101342}. It is technically being remembered now. [18:42:34] 6Collaboration-Team-Backlog, 10Echo: Define how to expose cross-wiki notifications to users - https://phabricator.wikimedia.org/T114237#1690468 (10Pginer-WMF) After an initial discussion, it seems reasonable to consider a progressive approach: starting with a beta feature first (that will help setting expectat... [18:44:45] (03PS1) 10Mooeypoo: Mark notifications as automatically read only after the popup loads [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242638 [18:44:53] legoktm, RoanKattouw_away :\ :\ ^^ [18:47:31] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Improve organization and control for Flow notifications (tracking + ideas) - https://phabricator.wikimedia.org/T100528#1690490 (10Pginer-WMF) [18:51:47] 3Collaboration-Team-Current, 10Flow, 6Parsing-Team, 10Parsoid, and 3 others: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1690501 (10Mattflaschen) Thanks. I tested a similar scenario to the one in the initial report, and it seems fixed now. [18:51:54] 3Collaboration-Team-Current, 10Flow, 6Parsing-Team, 10Parsoid, and 2 others: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1690502 (10Mattflaschen) [18:56:15] (03PS11) 10Mooeypoo: Add browser test for notifications in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242016 (https://phabricator.wikimedia.org/T113081) [18:56:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Freeze LQT on se.wikimedia - https://phabricator.wikimedia.org/T114277#1690530 (10Mattflaschen) a:3Mattflaschen [18:57:16] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Freeze LQT on se.wikimedia - https://phabricator.wikimedia.org/T114277#1690264 (10Mattflaschen) [18:57:18] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1690531 (10Mattflaschen) [18:58:23] 3Collaboration-Team-Current, 10Flow: Freeze LQT on pt.wikibooks - https://phabricator.wikimedia.org/T114278#1690537 (10Mattflaschen) [18:58:24] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1690536 (10Mattflaschen) [18:58:52] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1673081 (10Mattflaschen) [19:00:00] (03PS5) 10Mooeypoo: Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [19:00:40] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 10Continuous-Integration-Config, 7Easy: send Echo and Flow (and any Collaboration team extensions with browser tests) browser test job notices to #wikimedia-collaboration channel - https://phabricator.wikimedia.org/T66103#1690541 (10zeljkofilipin) [19:07:01] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1690559 (10zeljkofilipin) [19:21:52] RoanKattouw_away, updated at https://pt.wikibooks.org/wiki/T%C3%B3pico:Wikilivros_Discuss%C3%A3o:Portal_comunit%C3%A1rio/Proposta_para_converter_as_p%C3%A1ginas_de_LiquidThreads_para_Flow [19:21:55] * quiddity lunches [19:22:35] 6Collaboration-Team-Backlog, 10Echo, 6WMF-Design-Research, 7Epic, 7Needs-user-research: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1690629 (10Capt_Swing) [19:31:54] quiddity: Wow how did we end up with a thing written in Portuguese? Do we have a CL I've forgotten about who speaks pt, or do you have hitherto unsuspected talents? [19:33:40] RoanKattouw, I wrote https://www.mediawiki.org/wiki/Flow/Proposal_for_Ptwikibooks and waited for 24 hours, and then asked a kind Pt-editor how I should move the request along, and he volunteered to translate it immediately. [19:34:11] So, not a regularly requestable thing. [19:34:24] hah nice [19:37:47] 3Collaboration-Team-Current, 10Flow: Opt-in is automatically enabling users who previously had the "Automatically enable all new beta features" checked - https://phabricator.wikimedia.org/T114266#1690689 (10SBisson) I can reproduce it locally very easily. Here are the steps: # Make sure `$wgFlowEnableOptInBe... [19:40:11] RoanKattouw, legoktm, matt_flaschen: any idea how to solve to Flow opt-in auto-enroll? https://phabricator.wikimedia.org/T114266 [19:41:22] Looking [19:41:35] add an option to BF to exempt preferences from the auto-enroll option? [19:42:41] stephanebisson: how do you do #4 - Set $wgFlowEnableOptInBetaFeature = true; ? [19:42:49] stephanebisson, if it's doing it when you just visit Preferences, that also means it's doing a write on a GET request, which we try to avoid. [19:43:01] etonkovidova: in a config file [19:43:20] matt_flaschen: yes, it is [19:43:31] stephanebisson: yeah -sigh [19:43:39] legoktm: for sure, it's an option [19:45:08] stephanebisson, it looks like it's trying to allow preferences to opt out already, but I'm figuring out the details. [19:45:15] Opt out to auto opt in. :) [19:47:16] matt_flaschen: There's the concept of auto-enroll within a group. Like: Flow is a group that you have enabled, you'll be enrolled in all new Flow BF. [19:47:58] matt_flaschen: There's also dependencies. [19:48:46] stephanebisson, oh, never mind, it's an or, so if autoEnrollAll is true it will always do it. [19:50:03] matt_flaschen: I'm playing with exempt_auto_enroll. Now that legoktm mentioned it I know it's not off-limit ;) [19:50:53] stephanebisson, yeah, I can't see a way to do it without changing BetaFeatures. You could also just allow 'auto-enrollment' key to have a false value to disable all auto-enrollment. [19:51:01] For that particular feature. [20:04:20] 6Collaboration-Team-Backlog, 10Flow: Flow: Flow board history shouldn't usurp action=history (prio from Nick) - https://phabricator.wikimedia.org/T75538#1690818 (10Quiddity) Is this a duplicate of this other task? {T93491} I think so, but am not sure. [20:07:46] legoktm, if two users post almost at the same time in another user's talk page -- are those two notifications merging into one? [20:08:12] Yes [20:08:15] ... [20:08:29] They will bundle together [20:08:36] so I have absolutely no way of testing a user having 2 notifications in the popup/badge [20:08:44] I can't trust having Flow because Echo is not dependent on it [20:09:05] I can test with alerts, but alerts are marked read when seen, so testing the "mark all as read" is out of the question [20:09:22] and testing "mark all as read" on 1 notification is not really the point :\ [20:09:36] legoktm, is there any way to produce several messages to a user without using Flow? [20:10:29] (03CR) 10Catrope: [C: 032] Mark notifications as automatically read only after the popup loads [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242638 (owner: 10Mooeypoo) [20:10:45] Well once the message is seen or read (I forget) it will no longer bundle [20:10:52] hm [20:11:39] Read, probably [20:11:46] But that doesn't help with testing mark all as read [20:12:23] 6Collaboration-Team-Backlog, 10Flow: See which Flow posts contain the latest updates, via the 'cur' in history pages - https://phabricator.wikimedia.org/T114302#1690834 (10Quiddity) 3NEW [20:12:46] (03Merged) 10jenkins-bot: Mark notifications as automatically read only after the popup loads [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242638 (owner: 10Mooeypoo) [20:12:59] Damnit. [20:13:22] It should be at least not merged if the user seen the notification [20:15:44] lol [20:15:48] Flow is not installed on ptwikibooks [20:18:30] (03CR) 10Mooeypoo: [C: 032] Also override Modern's :hover styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242631 (https://phabricator.wikimedia.org/T114080) (owner: 10Legoktm) [20:23:59] RoanKattouw, yeah, that's because of https://phabricator.wikimedia.org/T107879 . [20:24:17] Oh OK [20:24:20] And https://phabricator.wikimedia.org/T107973 [20:24:22] I should check if that has been resolved then [20:26:51] It hasn't been :S [20:27:03] I suppose I could rename LQT's topic namespace there? [20:27:12] (03Merged) 10jenkins-bot: Also override Modern's :hover styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242631 (https://phabricator.wikimedia.org/T114080) (owner: 10Legoktm) [20:28:40] (03PS1) 10Sbisson: [WIP] Disable auto-enroll for opt-in beta feature [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242715 (https://phabricator.wikimedia.org/T114266) [20:29:15] (03CR) 10Catrope: [C: 032] Initialize 'mark as read' button hidden unless needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242636 (https://phabricator.wikimedia.org/T113629) (owner: 10Mooeypoo) [20:31:04] (03PS2) 10Sbisson: Disable auto-enroll for opt-in beta feature [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242715 (https://phabricator.wikimedia.org/T114266) [20:31:59] (03Merged) 10jenkins-bot: Initialize 'mark as read' button hidden unless needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242636 (https://phabricator.wikimedia.org/T113629) (owner: 10Mooeypoo) [20:44:05] RoanKattouw, err, wouldn't a rename break all old links? [20:44:17] Yes :( [20:44:19] (bookmarks, external incoming links, etc) [20:44:22] And it would be nontrivial as well [20:44:29] So we probably have to rename the Topic namespace in Flow instead [20:44:31] yeah, not an option then. [20:44:38] mhm :/ [20:44:52] s/probably/certainly/ [20:45:07] Because we can't have them be the same, and we can't rename the LQT ones without a lot of pain [20:49:17] (03CR) 10Mooeypoo: [C: 032] Browser tests: eliminate deprecation warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242586 (owner: 10Sbisson) [20:49:45] RoanKattouw, we also need to check if any pt lang Flow boards have been created elsewhere. [20:49:56] If you're going to rename the Flow one. [20:52:16] matt_flaschen, RoanKattouw, yes, pt.wikipedia already uses tópico https://pt.wikipedia.org/wiki/T%C3%B3pico:Sk7xi9rdw6oue60u [20:53:49] Does that mean that languages must remain consistent, across different projects? (it'd make sense, but I hadn't realized that before.) [20:54:41] i.e. either the pt.wikibooks LQT thread/tópico namespace needs to be renamed, OR, the pt.wikipedia Flow tópico namespace needs to be renamed. They could not have different strings. [20:55:09] I think there is a way to do per-project overrides. [20:56:03] I was trying to look at doing a per-project override [20:56:08] But I haven't yet figured out if it can be done [20:58:30] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: eliminate deprecation warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242586 (owner: 10Sbisson) [21:00:23] RoanKattouw, ah, there must be, because "User" namespace is different in Ptwp vs Ptwikibooks ( Utilizador vs Usuário(a) ) [21:00:30] err, vice versa [21:02:11] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Opt-in is automatically enabling users who previously had the "Automatically enable all new beta features" checked - https://phabricator.wikimedia.org/T114266#1691079 (10Etonkovidova) Scenario for testing after the fix(the issue was confirmed in betalab... [21:08:08] stephanebisson, I sent you the full log of running all of Flow's browser tests [21:11:03] (03PS6) 10Mooeypoo: [wip] Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [21:15:57] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242586 (owner: 10Sbisson) [21:16:55] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Echo notification icons should be white in MonoBook to match Vector - https://phabricator.wikimedia.org/T112290#1691108 (10violetto) cc @Volker_e [21:19:02] stephanebisson, any creative ideas on how to test 'mark all as read' in Echo considering there's no real way of having more than 1 unread message in the popup without having Flow enabled ? :\ [21:19:48] I am at a loss. Either we test with Flow, or we don't test that and the "mark as read" in each notification will be silly test too, because if there's only 1 unread message, the test can't check if that [x] button marked 1 as unread or marked all. [21:24:32] mooeypoo: so you're saying if I have echo but not flow, I have a 'message' notification button and flyout but it's only every gonna have 0 or 1 item... [21:25:12] stephanebisson, seems so, yes. [21:25:31] stephanebisson, well, the message popup has talk page messages and flow messages [21:25:40] I think it's possible to have more than one, but only one unread (without Flow) [21:25:42] Due to bundling. [21:25:42] but talk page messages get bundled until you see them [21:25:53] yeah I'm talking about unread, to test "mark all as read" [21:25:58] so if 10 people write on my wikitext talk page over the course of 10 days, I'll have 1 entry [21:26:09] Yes. "10 new topics on your talk page" or something [21:26:11] If you don't mark any read in the meantime. [21:26:12] 1 message, bundled. [21:26:35] Indeed. If you look and read in between, you'll get another 1 unread message bundled [21:26:45] the point is that there seems to be no way to get more than 1 unread message unless you have Flow [21:28:53] mooeypoo: would yousay that the behaviour you are trying to test here is mostly in the UI, the API, a specific class, all of them? [21:30:53] I am trying to test the UI I think [21:31:10] (03CR) 10Sbisson: [C: 032] "Per Moriel" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242586 (owner: 10Sbisson) [21:31:22] Although I could do this as a qunit test as well (i probably *should*) but that still leaves the same issue [21:31:37] the only way for me to test "mark all read" properly is to have more than 1 message as unread [21:31:54] I can have multiple alerts being unread at once, but they are all marked as read the second we open the poppup [21:31:56] popup [21:32:08] which is going to be its own test, so it's not testing the actual button [21:32:47] mooeypoo, I think you have to put it in Flow. [21:32:57] But it's an Echo test [21:33:04] Before we moved edit-user-talk, we wouldn't even be having this conversation. [21:33:13] It would be obviously impossible to test it with just Echo. [21:33:19] A test in Flow would be "am I getting x messages if I hve x topics I follow udpating" or something [21:33:20] mooeypoo: at the unit level, there is no reason you shouldn't be able to push a bunch of notifications and mark all as read [21:33:22] It turns out it still is, just slightly less obviously. [21:33:49] stephanebisson, yeah qunit tests I can do. There already are some in there, I need to expand them. [21:33:50] Browser-test I mean. I can be done with unit tests. [21:33:52] But it's not testing the UI [21:34:53] stephanebisson, but it's also preventing other sort of tests in the browser. Like having 3 messages, clicking on 1 of them and making sure that the next time you open the popup you still have 2 unread [21:35:13] a bunch of test cases that I wanted to cover are impossible [21:35:25] Impossibl without Flow, that is. [21:35:30] Impossible* [21:35:41] I guess matt_flaschen's point stands. It can just be in Flow. [21:35:58] I'll have to copy over a bunch of the definitions, though. [21:36:17] mooeypoo: you want to test Echo as a general notification manager that can receive and display notifications... and that's great. But you are testing it in it's current implementation based on user talk pages and Flow boards [21:37:16] I'm wondering if going closer to unit testing you would be more able to control the way it is used [21:37:23] stephanebisson, yeah, I wanted to make sure it works to spec, but there's no way of producing many of the test cases [21:37:32] well, the unit tests can test the view model [21:37:35] and should [21:37:45] the browser tests should probably test interaction, more, no? [21:38:06] (03Merged) 10jenkins-bot: Browser tests: eliminate deprecation warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242586 (owner: 10Sbisson) [21:38:21] "I clicked here, this is the desired outcome..." except, clicking "mark all as read" can only test 1 message, clicking the "[x]" is also one message at a time, etc. The tests are not that good like that. [21:39:26] unit tests can test anything you want, browser tests check that the whole thing work together generally, not with all the corner cases [21:39:42] "Mark all as read" is not supposed to be corner case [21:39:50] How can I test that button, is my problem [21:40:28] well, if you don't have Flow, like most people, it is a corner case [21:40:44] hm. Do we even need that button there if you don't have Flow, then? [21:41:08] It's a little funny to have "Mark all as read" when you always have 1 message tops [21:41:42] But my biggest concern is that this is *probably* temporary condition. At some point, we'll have cross-wiki notifications, in which case we may well have multiple messages... [21:42:03] I just don't like the fact we can't really test that button. I'll add the unit tests to the model specifically, though. [21:42:13] unit test what you can [21:42:44] (03PS7) 10Mooeypoo: [wip] Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) [21:42:54] ok, I'll add the unit tests and we can see if we need more from there [21:43:00] we can solve that problem when we really have cross-wiki [21:43:06] 3Collaboration-Team-Current, 10Flow, 6Parsing-Team, 10Parsoid, and 2 others: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1691195 (10Etonkovidova) Checked on http://test.wikimedia.beta.wmflabs.org/ (including the initial issue with Undo for Flow talk page manag... [21:43:27] stephanebisson, yeah, I guess. There's not a whole lot of coverage with the current echo tests though right now. [21:43:37] mooeypoo, you can test that markAllRead calls the API method (with SinonJS). And if you want, you can test in PHPUnit that markallread works. [21:43:52] yeah we need phpunit and qunit tests for that [21:44:03] I should also add Alert-specific browser tests [21:44:45] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add browser test to "mark all as read" in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242422 (https://phabricator.wikimedia.org/T113081) (owner: 10Mooeypoo) [22:02:56] (03PS1) 10Mooeypoo: Add QUnit test for marking 'read' and 'seen' notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242738 [22:09:44] (03CR) 10jenkins-bot: [V: 04-1] Add QUnit test for marking 'read' and 'seen' notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242738 (owner: 10Mooeypoo) [22:46:33] 6Collaboration-Team-Backlog, 10Flow: DataModelException - https://phabricator.wikimedia.org/T114240#1691385 (10Quiddity) [22:46:34] 3Collaboration-Team-Current, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1691386 (10Quiddity) [22:47:36] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Wikimedia-log-errors, 7WorkType-NewFunctionality: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1691392 (10Quiddity) [23:16:17] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Have 'flow-suppress' work on MediaWiki-Vagrant out of the box - https://phabricator.wikimedia.org/T113641#1691568 (10Mattflaschen) p:5Triage>3Normal [23:16:42] 6Collaboration-Team-Backlog, 10Flow: Old -style wikitext icon is displayed for older topics - https://phabricator.wikimedia.org/T114326#1691571 (10Etonkovidova) 3NEW [23:17:03] 6Collaboration-Team-Backlog, 10Flow: See which Flow posts contain the latest updates, via the 'cur' in history pages - https://phabricator.wikimedia.org/T114302#1691578 (10Catrope) p:5Triage>3Normal [23:18:24] 6Collaboration-Team-Backlog, 10Flow: Firefox extension Adblock plus with filter EasyPrivacy blocks Flow when a banner is displayed - https://phabricator.wikimedia.org/T114257#1691584 (10Catrope) p:5Triage>3Low [23:18:47] 6Collaboration-Team-Backlog, 10Echo: Define how to expose cross-wiki notifications to users - https://phabricator.wikimedia.org/T114237#1691590 (10Catrope) p:5Triage>3High [23:20:05] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 3 others: bodyOnly is now body_only - https://phabricator.wikimedia.org/T114185#1691593 (10Catrope) p:5Triage>3High [23:20:45] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 3 others: bodyOnly is now body_only - https://phabricator.wikimedia.org/T114185#1687357 (10Catrope) What remains to be done here? [23:21:15] 6Collaboration-Team-Backlog, 10Flow: VE suggestions for Link and Mention are cut off at the bottom of the Flow page - https://phabricator.wikimedia.org/T114177#1691603 (10Catrope) p:5Triage>3High [23:23:02] 6Collaboration-Team-Backlog, 10Flow: When I want to reply to a Flow Topic on Chromium, scrolling goes weird. - https://phabricator.wikimedia.org/T114139#1691614 (10Catrope) p:5Triage>3Normal [23:24:01] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression: 'View and restore deleted pages': posting a new topic, re-sorting, and Edit board actions on a page are present but don't work - https://phabricator.wikimedia.org/T114043#1691619 (10Catrope) Could {T114138} be related? [23:24:06] 6Collaboration-Team-Backlog, 10Flow: 'View and restore deleted pages' displays 'No topics returned from API' for deleted protected pages - https://phabricator.wikimedia.org/T114138#1691621 (10Catrope) p:5Triage>3Normal [23:24:48] 3Collaboration-Team-Current, 10Echo, 6WMF-Design-Research, 7Epic, 7Needs-user-research: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1691624 (10Catrope) a:3Pginer-WMF [23:24:58] 3Collaboration-Team-Current, 10Echo, 6WMF-Design-Research, 7Epic, 7Needs-user-research: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1684135 (10Catrope) p:5Triage>3High [23:25:16] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-skins-Modern, 5Patch-For-Review: css bugs in modern skin with the latest echo spilt notifications. - https://phabricator.wikimedia.org/T114080#1691628 (10Catrope) p:5Triage>3High [23:25:40] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-skins-Modern, 5Patch-For-Review: css bugs in modern skin with the latest echo spilt notifications. - https://phabricator.wikimedia.org/T114080#1691632 (10Catrope) a:3Legoktm [23:27:01] 6Collaboration-Team-Backlog, 10Flow: Special:Contributions/newbies doesn't show username/usertalk links for Flow items - https://phabricator.wikimedia.org/T114037#1691633 (10Catrope) p:5Triage>3Normal [23:28:24] 6Collaboration-Team-Backlog, 10Flow, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2015-09-29_(1.27.0-wmf.1): Flow usertalk beta feature - opt-out can result in Internal error "CAS update failed" - https://phabricator.wikimedia.org/T114023#1691637 (10Catrope) 5Open>3Resolved a:3Catrope [23:29:22] 3Collaboration-Team-Current, 10Echo: Significant performance degradation in new (split) notifications - https://phabricator.wikimedia.org/T114012#1691639 (10Catrope) [23:30:14] 3Collaboration-Team-Current, 10Echo: Significant performance degradation in new (split) notifications - https://phabricator.wikimedia.org/T114012#1682331 (10Catrope) @Mattflaschen suggests we separate our metrics for the two different flyouts. [23:30:22] 3Collaboration-Team-Current, 10Echo: Significant performance degradation in new (split) notifications - https://phabricator.wikimedia.org/T114012#1691643 (10Catrope) p:5Triage>3Normal [23:36:06] 6Collaboration-Team-Backlog, 10Flow: Add option to semi/fully-protect Flow board descriptions - https://phabricator.wikimedia.org/T113902#1691653 (10Catrope) p:5Triage>3Normal [23:37:52] 3Collaboration-Team-Current, 10Echo, 7Browser-Support-Apple-Safari: The messages panel cannot be closed anymore on iOS - https://phabricator.wikimedia.org/T113881#1691658 (10Catrope) p:5Triage>3Unbreak! [23:38:48] 3Collaboration-Team-Current, 10Flow: 'wgTitle' and 'wgPageName' are null on history of Flow pages - https://phabricator.wikimedia.org/T113833#1691662 (10Catrope) p:5Triage>3High [23:39:05] 6Collaboration-Team-Backlog, 10Flow: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#1691668 (10Catrope) p:5Triage>3Normal [23:42:54] 6Collaboration-Team-Backlog, 10Echo: Measure the notification types that are most abundantly received at 5 sample wikis - https://phabricator.wikimedia.org/T113664#1691672 (10Catrope) >>! In T113664#1682673, @Legoktm wrote: > Notifications are private, so I don't think we should be associating users with what... [23:44:28] 3Collaboration-Team-Current, 10Echo: Measure the notification types that are most abundantly received at 5 sample wikis - https://phabricator.wikimedia.org/T113664#1691686 (10Catrope) [23:44:33] 3Collaboration-Team-Current, 10Echo: Measure the number of different wikis from which users have unread notifications - https://phabricator.wikimedia.org/T113626#1691688 (10Catrope) [23:44:44] 3Collaboration-Team-Current, 10Echo, 10Flow: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1691690 (10Catrope) [23:44:50] 3Collaboration-Team-Current, 10Echo: Measure the notification types that are most abundantly received at 5 sample wikis - https://phabricator.wikimedia.org/T113664#1691691 (10Catrope) p:5Triage>3High [23:44:56] 3Collaboration-Team-Current, 10Echo: Measure the number of different wikis from which users have unread notifications - https://phabricator.wikimedia.org/T113626#1691692 (10Catrope) p:5Triage>3High [23:45:01] 3Collaboration-Team-Current, 10Echo, 10Flow: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1691694 (10Catrope) p:5Normal>3High [23:46:15] 6Collaboration-Team-Backlog, 10Flow: Resolving a topic that has an existing summary, forces to save the summary (there's no cancel button) - https://phabricator.wikimedia.org/T113585#1691706 (10Catrope) p:5Triage>3Normal The spurious history entry should be fixed in wmf1, see {T60975}. [23:47:54] 3Collaboration-Team-Current, 10Flow: Old editor system is used when replying to a topic that was loaded using infinite scroll - https://phabricator.wikimedia.org/T114326#1691713 (10Catrope) [23:47:59] 3Collaboration-Team-Current, 10Flow: Old editor system is used when replying to a topic that was loaded using infinite scroll - https://phabricator.wikimedia.org/T114326#1691571 (10Catrope) p:5Triage>3High