[00:12:10] 6Collaboration-Team-Backlog, 10Beta-Cluster, 10MediaWiki-Recent-changes: [enwiki-betacluster] Special: Recent changes page is not displayed correctly - https://phabricator.wikimedia.org/T113660#1673332 (10greg) [05:42:03] 6Collaboration-Team-Backlog, 10Beta-Cluster, 10MediaWiki-Recent-changes: [enwiki-betacluster] Special: Recent changes page is not displayed correctly - https://phabricator.wikimedia.org/T113660#1673600 (10Luke081515) a:3Luke081515 I can try if the reason for this is a wrong mediawiki systemmessage [07:30:57] 6Collaboration-Team-Backlog, 10Beta-Cluster, 10MediaWiki-Recent-changes: [enwiki-betacluster] Special: Recent changes page is not displayed correctly - https://phabricator.wikimedia.org/T113660#1673661 (10Luke081515) 5Open>3Resolved [[http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki%3ARec... [08:32:32] 6Collaboration-Team-Backlog, 10Flow: Rename an account make lose user's Flow board. - https://phabricator.wikimedia.org/T113701#1673759 (10Trizek-WMF) 3NEW [08:34:52] 6Collaboration-Team-Backlog, 10Echo: notification duplicated in divided notifications - https://phabricator.wikimedia.org/T112246#1673771 (10Sunpriat) {F2633738} "If you take a screenshot of the menu it will not be seen which of the two I opened they are quite similar, with the title "Notifications." It is nec... [08:48:19] 6Collaboration-Team-Backlog, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1673779 (10Trizek-WMF) 3NEW [08:56:41] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1673803 (10jcrespo) > I guess we need to use this as a baseline then check back in a little whil... [09:03:00] (03CR) 10Jcrespo: "Ok, let's wait for the other pending schema change on the tables to apply that, it should be less impacting with less secondary keys." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [09:08:03] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1673843 (10jcrespo) @Mattflaschen, I am ok with you explanation. Just remember that when there is no othe... [10:00:54] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality, 7user-notice: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1674017 (10Sunpriat) MediaWiki:Flow-notification-link-text-enabled-on-talkpage Here need $1 too for gender to user [10:03:38] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1674022 (10Pginer-WMF) > As we discussed in our meeting, I think that the notification bundling should be a bit more flexible. Thanks @Mooeypoo for the detailed example. I... [10:08:15] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) missing or shown inconsistently with custom CSS - https://phabricator.wikimedia.org/T113574#1674037 (10zhuyifei1999) AFAIK, Special:Preferences has user css disabled (T72672). I'm inclined to close this task as declined. [10:51:16] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) missing or shown inconsistently with custom CSS - https://phabricator.wikimedia.org/T113574#1674114 (10Josve05a) That does not explain why the notification-icon(s9 are ompleatly missing on other pages, since that css should only disable the... [11:53:41] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) missing or shown inconsistently with custom CSS - https://phabricator.wikimedia.org/T113574#1674239 (10zhuyifei1999) 5Open>3declined a:3zhuyifei1999 >>! In T113574#1674114, @Josve05a wrote: > That does not explain why the notification... [13:35:38] 6Collaboration-Team-Backlog, 10Echo, 10Browser-Tests: Fix or delete failing Echo browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94152#1674443 (10zeljkofilipin) 5duplicate>3Open [13:39:43] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1674477 (10zeljkofilipin) 5Resolved>3Open a:5SBisson>3None [13:47:07] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1674490 (10zeljkofilipin) [13:47:24] 6Collaboration-Team-Backlog, 10Echo, 10Browser-Tests: Fix or delete failing Echo browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94152#1674491 (10zeljkofilipin) [14:25:53] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1674604 (10zeljkofilipin) p:5High>3Normal [14:32:17] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1674628 (10Huji) Tested again: now the yellow badge for new messages DOES disappear when you click on the item in the notification drop-down, but the counter s... [16:40:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1675071 (10SBisson) > 3. Deleting and viewing/restoring another user's User talk page seems to produce a specific error I can'... [16:43:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1675110 (10SBisson) > /srv/mediawiki/php-master/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\Board... [16:55:44] 3Collaboration-Team-Current, 10Flow: Old style wikitext icon is displayed on undo-edit-post pages - https://phabricator.wikimedia.org/T113764#1675274 (10Etonkovidova) 3NEW [17:21:21] RoanKattouw_away etc -- I won [17:22:13] won't be at the standup today -- I need to go to CommTech sprint planning [17:22:34] but I'll be available after that [17:23:32] dannyh: what did you win? [17:23:50] that was supposed to be "I won't" [17:23:56] :) [17:23:56] oh :P [17:24:00] legoktm: he won the priviledge to not attend standup [17:24:05] haha [17:24:19] hi collaboration team [17:25:59] stephanebisson, 5/5 passes this morning. 6/7 passes last night. [17:26:18] mooeypoo: what was the error? [17:26:49] My computer acted up and I lost the error log, I am fairly sure it was the same issue, but I don't know so I kept running it, trying to get a failure again [17:26:51] none so far [17:27:05] mooeypoo: I think we should merge [17:27:12] stephanebisson, I concur [17:28:06] (03CR) 10Mooeypoo: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 (owner: 10Sbisson) [17:28:06] mooeypoo: also, if you could try a full run at some point, during lunch or something, and send me the log [17:28:15] stephanebisson, I was running a full run [17:28:18] I really want your setup to be stable, mine is [17:28:24] I mean full full [17:28:26] all tests [17:28:28] oh you mean full full [17:28:29] yeah [17:28:31] okay, I'll do that [17:28:40] stephanebisson, is there a way to send the logs to a file? [17:28:48] pipe to file [17:28:57] ... of course. ha. [17:29:05] cucumber features/ -t @chrome > log [17:29:11] ok I don't trust my terminal backlog limit [17:29:15] * mooeypoo nods [17:29:18] will do at lunch [17:29:20] or @firefox [17:29:57] you have to use a tag because not all test can work on all browser [17:31:20] (03Merged) 10jenkins-bot: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 (owner: 10Sbisson) [17:33:43] RoanKattouw_away, matt_flaschen ping :) [17:48:55] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-API: Unpatrolled edits on Flow pages do not appear in the API - https://phabricator.wikimedia.org/T104083#1675531 (10Quiddity) [17:48:57] 6Collaboration-Team-Backlog, 10Flow: 'Mark this page as patrolled' message should be more specific - https://phabricator.wikimedia.org/T102310#1675532 (10Quiddity) [17:49:00] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Patrolling: User talk edit by autopatrol user not autopatrolled - https://phabricator.wikimedia.org/T58989#1675533 (10Quiddity) [17:49:02] 6Collaboration-Team-Backlog, 10Flow: Edit patrol - Flow issues (tracking) - https://phabricator.wikimedia.org/T73456#1675530 (10Quiddity) [17:50:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1675545 (10Mattflaschen) Show changes is {T110679}. [17:52:12] 3Collaboration-Team-Current, 10Flow, 6Parsing-Team, 10Parsoid, and 2 others: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1675558 (10Mattflaschen) [17:57:34] 3Collaboration-Team-Current, 10Flow: Use new editor for undo pages - https://phabricator.wikimedia.org/T113764#1675583 (10Mattflaschen) [18:04:32] 6Collaboration-Team-Backlog, 10Beta-Cluster, 10MediaWiki-Recent-changes: [enwiki-betacluster] Special: Recent changes page is not displayed correctly - https://phabricator.wikimedia.org/T113660#1675604 (10Mattflaschen) Thanks. I don't know why it doesn't show that message at http://en.wikipedia.beta.wmflabs... [18:09:24] 6Collaboration-Team-Backlog, 10Echo: notification duplicated in divided notifications - https://phabricator.wikimedia.org/T112246#1675622 (10Mattflaschen) They do not currently have the same title. If you click the bell, it should show a popup with the heading " Alerts". For messages, it should be... [18:11:56] (03PS1) 10D3r1ck01: modified [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241106 [18:11:59] (03PS1) 10D3r1ck01: Call to deparecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 [18:12:02] (03CR) 10jenkins-bot: [V: 04-1] modified [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241106 (owner: 10D3r1ck01) [18:12:20] 6Collaboration-Team-Backlog, 10Echo: When marking an unread notification "read" it should be pushed downwards, under the read notifications - https://phabricator.wikimedia.org/T113630#1675626 (10SBisson) [18:13:25] 3Collaboration-Team-Current, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1675631 (10Mattflaschen) [18:13:33] (03Abandoned) 10D3r1ck01: modified [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241106 (owner: 10D3r1ck01) [18:14:37] woah [18:14:47] d3r1ck, what is this commit supposed to do? [18:14:55] (03PS2) 10D3r1ck01: Call to deparecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 [18:16:29] mooeypoo: it is suppost to update a call to a deprecated module in Thanks [18:16:49] d3r1ck, yeah, sorry, I saw the other one you abandoned and didn't notice you abandoned it [18:17:03] that caused a break when trying to deplay the Mobile Frontend extension [18:17:10] mooeypoo: ohhh, no problem [18:17:15] but you can review that one and merge [18:19:30] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Run patch-reference_wiki-phase5.sql in production - https://phabricator.wikimedia.org/T113778#1675663 (10Mattflaschen) 3NEW [18:19:44] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change, 7WorkType-NewFunctionality: Run patch-reference_wiki-phase5.sql in production - https://phabricator.wikimedia.org/T113778#1675663 (10Mattflaschen) [18:19:55] mooeypoo: check it out. [18:20:06] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1675672 (10Mattflaschen) [18:20:35] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change, 7WorkType-NewFunctionality: Run patch-reference_wiki-phase5.sql in production - https://phabricator.wikimedia.org/T113778#1675663 (10Mattflaschen) [18:21:46] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1593860 (10Mattflaschen) [18:22:13] (03CR) 10Mooeypoo: [C: 04-1] Call to deparecated toast module updated (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 (owner: 10D3r1ck01) [18:22:26] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1675693 (10Mattflaschen) >>! In T111084#1673803, @jcrespo wrote: > Please create... [18:23:12] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1675703 (10Mattflaschen) How long do you think we should wait before checking ba... [18:24:12] (03PS3) 10D3r1ck01: Call to deparecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 [18:24:30] mooeypoo: it is fine now. Check it out. [18:26:09] d3r1ck, I'll test a little later after I"m done with a few things ,but I think you need to rebase this onto master now... I've never seen a commit depends on something that was abandoned. I think you need to rebase. [18:26:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1675738 (10Mattflaschen) [18:26:23] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1675737 (10Mattflaschen) [18:26:45] (03PS4) 10D3r1ck01: Call to deparecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 [18:27:33] mooeypoo: yes it is cherry picked to master :) [18:27:38] awesome [18:28:20] mooeypoo: waaitin :) [18:28:31] hehe patience, d3r1ck [18:28:42] (03PS5) 10Jdlrobson: Hygiene: Call to deprecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 (owner: 10D3r1ck01) [18:28:50] (03CR) 10Jdlrobson: [C: 032] Hygiene: Call to deprecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 (owner: 10D3r1ck01) [18:28:57] 6Collaboration-Team-Backlog, 10Flow: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#1675740 (10Mattflaschen) 3NEW [18:29:12] aaand jdlrobson beat me to it (thanks !) [18:29:19] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1675749 (10jcrespo) Unless there is no activity, a day should be more than enoug... [18:29:21] 6Collaboration-Team-Backlog, 10Flow: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#1675750 (10Mattflaschen) [18:29:37] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality, 7user-notice: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1675753 (10Mattflaschen) >>! In T98270#1674017, @Sunpriat wrote: > MediaWiki:Flow-notification-link-text-enabled-on-talkp... [18:30:54] mooeypoo: ok [18:31:39] 6Collaboration-Team-Backlog, 10Echo, 10Browser-Tests: Fix or delete failing Echo browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94152#1675758 (10Mattflaschen) These will all be rewritten due to the rewrite of the Echo frontend. [18:33:16] (03Merged) 10jenkins-bot: Hygiene: Call to deprecated toast module updated [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/241107 (owner: 10D3r1ck01) [18:37:07] 3Collaboration-Team-Current, 10Echo, 7Regression: Add 'target-page' for edit-user-talk - https://phabricator.wikimedia.org/T112477#1675773 (10Mattflaschen) [18:38:30] 3Collaboration-Team-Current, 10Echo, 7Regression: Add 'target-page' for edit-user-talk - https://phabricator.wikimedia.org/T112477#1635568 (10Mattflaschen) This is the same mechanism we use to auto-mark-as-read Flow messages when you visit the Flow board. [18:39:33] * RoanKattouw walks in sheepishly [18:51:00] mlitn: What is "the problem" you were trying to solve in https://gerrit.wikimedia.org/r/#/c/240367/ ? [18:52:33] RoanKattouw: I assumed at that time $title->getArticleId() was returning the correct article ID there (which turned out wasn’t the case) [18:52:46] yet, wikipage->getContent wasn’t returning the expected content [18:53:22] wikipage does a lot of things [18:53:37] I mean, at a macro level [18:53:43] Was this trying to address a bug related to opt-in? [18:53:51] ah, yes [18:54:01] the one with the description [18:54:30] opt-in, opt-out, opt-in, board description not updated [18:56:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1675832 (10Etonkovidova) Re-checked both cases described in the ticket and one more from https://en.wikipedia.org/w/index.php?title=Topic:... [18:56:59] (03PS20) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [18:58:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1675835 (10Etonkovidova) Also checked > undo edit post > undo edit topic summary > undo edit board description [19:15:54] stephanebisson, do you know if there's already a mw step for creating a new user? [19:16:01] I think there is, I can't remember where or what it is [19:16:23] oh, found it. api.create_account [19:17:03] mooeypoo: the first step in opt_in_steps.rb shows one way to use it [19:17:13] yeah I just saw that [19:18:35] 6Collaboration-Team-Backlog, 10Flow: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#1675896 (10Aklapper) [19:19:52] quiddity: regarding T112338: when you said there "incorrect rendering" - it was about about rendering correctly links/templates/markup(like strikethrough) ? [19:20:53] quiddity: cause I see cases when carriage return is displayed as a symbol. Wondering if it deserves a separate bug ... [19:27:55] etonkovidova, yes, I was mainly referring to all the wikimarkup being rendered in plaintext, e.g "{{collapse top|test collapse}}" rather than showing the template itself (and if flipped into wikitext mode, it shows s have been added). [19:28:55] I /think/ the carriage return arrows are accurate, at least in https://phab.wmfusercontent.org/file/data/mxfcbrf2yoiy7pqowvpb/PHID-FILE-jiuwuxp4wp2yd42m2lqh/lxsal5p4jrrsi3dh/wrFT6U2.png [19:29:13] quiddity: yes, all seems to be cleaner and clearer now. [19:29:15] however there probably should /not/ ever be 2 in a row, as in https://phab.wmfusercontent.org/file/data/wm7nqpf5aeyq6pgzk5b3/PHID-FILE-bfllu56x2zcijukvupfy/dpmijdxkmwel4jsv/g8imExx.png [19:31:03] quiddity: and carriage returns - I'll push them to the end of my priority investigation list - for while :) I am knee deep in trying to figure out View history mysterious and non-reproducible error pages :( [19:31:12] quiddity: thanks for the links! [19:31:40] :) Good luck/condolences! (and those are just the images from T112338 itself) [19:32:59] quiddity: I was getting the same errors as in T113702 - Fatal Error type "Flow \ Exception \ DataModelException" [19:34:30] hmmm :/ [19:36:31] 3Collaboration-Team-Current, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1675944 (10Etonkovidova) Seems the same t error after clicking on 'View history' on Talk:ET3 page: ``` An error has occurred while processing the data in your request. Return to Main P... [19:54:31] these browser tests are getting better and better: 49 scenarios (49 passed) - 288 steps (288 passed) - 13m55.826s [19:55:17] they used to take 45+ minutes on my laptop, and mostly/randomly fail [20:01:48] (03PS1) 10Sbisson: Ignore null edits for topic title, post, description, and summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/241142 (https://phabricator.wikimedia.org/T60975) [20:02:40] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Wikimedia-log-errors, 7WorkType-NewFunctionality: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1676108 (10Etonkovidova) The same error as in https://phabricator.wikimedia.org/T113702. [20:08:25] 6Collaboration-Team-Backlog, 10Flow: MWException when viewing diffs on Special:Undelete - https://phabricator.wikimedia.org/T113798#1676137 (10Etonkovidova) 3NEW [20:10:10] 6Collaboration-Team-Backlog, 10Flow: MWException when viewing diffs on Special:Undelete - https://phabricator.wikimedia.org/T113798#1676158 (10Etonkovidova) [20:10:12] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: MediaWiki error for deleted Flow board, when clicking 'Show changes' - https://phabricator.wikimedia.org/T110679#1676160 (10Etonkovidova) [20:10:34] (03PS2) 10Sbisson: Ignore null edits for topic title, post, description, and summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/241142 (https://phabricator.wikimedia.org/T60975) [20:40:44] 3Collaboration-Team-Current, 10Flow: Summarize: switching to wikitext mode displays old style icon - https://phabricator.wikimedia.org/T111984#1676425 (10DannyH) 5Open>3Resolved a:3DannyH [20:41:04] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1676427 (10DannyH) 5Open>3Resolved [20:43:16] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Editing posts: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T110093#1676441 (10DannyH) 5Open>3Resolved a:3DannyH The behavior Elena noted (switching moves the cursor to the end) is accept... [20:43:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1676447 (10DannyH) 5Open>3Resolved Awesome, well done [20:43:42] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1676450 (10DannyH) 5Open>3Resolved [20:52:33] 3Collaboration-Team-Current, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1676482 (10DannyH) p:5Triage>3Unbreak! [20:54:27] 3Collaboration-Team-Current, 10Flow: History link is broken on French Wiktionary - https://phabricator.wikimedia.org/T113702#1673779 (10DannyH) This may be fixed with {T111494}. [20:56:37] 6Collaboration-Team-Backlog, 10Flow: Renaming an account doesn't move the Flow board on the user's talk page - https://phabricator.wikimedia.org/T113701#1676498 (10DannyH) [20:57:18] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Renaming an account doesn't move the Flow board on the user's talk page - https://phabricator.wikimedia.org/T113701#1673759 (10DannyH) [20:58:05] 3Collaboration-Team-Current, 10Flow: Exception when viewing https://es.wikiquote.org/wiki/Tema:Sobaaiky57zs7py7 - https://phabricator.wikimedia.org/T113311#1676504 (10DannyH) [20:59:00] stephanebisson, in the Flow browser tests, we're using browser_factory.override( ... ) to override user agent, to simulate a nojs page. I want to do the same for Echo, but it fails with "undefined local variable or method `browser_factory'" -- and yet, I don't find where Flow defines that either. Any idea? [21:00:30] mooeypoo: browser_factory is accessible in step definitions on the global scope [21:00:56] stephanebisson, hm I'm not requiring something, then [21:01:24] hm [21:01:33] mooeypoo: do you have a 'env.rb' file in support/ ? [21:01:35] Can I just use Flow's env.rb ? it's compeltely different [21:01:48] yeah it's completely different than Flow's [21:01:59] no require 'mediawiki_selenium' and /support etc [21:02:00] but [21:02:27] when upgrading to mw_selenium 1.4 this file was completely rewritten [21:02:41] if I copy the Flow one into the Echo one, I have failures "cannot load such file -- mediawiki_selenium/support (LoadError)" [21:03:08] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1676521 (10Etonkovidova) All issues in my comments seem to be addressed by already filed tickets >1 T110679 >3 T104591 Delete... [21:03:08] which version of mw_selenium do you have in your Gemfile? [21:03:17] oh! the Gemfile! [21:03:18] and did you `bundle install` ? [21:03:21] I knew I forgot something [21:03:29] yes, but I didn't up the version in the Gemfile [21:03:33] we're in rubyland here ;) [21:03:39] yeah :\ [21:03:53] gem 'mediawiki_selenium', '~> 0.4.2' [21:04:00] ancient [21:04:18] 3Collaboration-Team-Current, 10Flow: 'View and restore deleted pages' displays broken layout for deleted Flow pages - https://phabricator.wikimedia.org/T113668#1676533 (10Etonkovidova) [21:04:20] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1676532 (10Etonkovidova) [21:04:56] mooeypoo: use 1.4.0 and remove mediawiki_api if you have it [21:04:58] stephanebisson, the Flow Gemfile has no hard coded versions for csscss and rubocop [21:05:07] should I do the same? [21:05:13] yes [21:05:25] So it seems can just copy the gemfile from flow to echo [21:05:27] doesn't matter too much, they are dev dependencies [21:05:30] maybe minus the chunky_png [21:07:42] I didn't we had csscss [21:07:50] just ran it, the results aren't pretty [21:08:36] I just copied Flow's gemfile to Echo [21:08:43] it works, but I get weird other failures now [21:08:44] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Renaming an account doesn't move the Flow board on the user's talk page - https://phabricator.wikimedia.org/T113701#1676555 (10DannyH) [21:08:47] I'mstill missing things i think [21:08:49] uninitialized constant ArticlePage::URL (NameError) [21:09:05] 6Collaboration-Team-Backlog, 10Echo, 10Browser-Tests: Fix or delete failing Echo browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94152#1676556 (10zeljkofilipin) @Mattflaschen should we delete the jobs? We can easily restore them once they are green again. [21:09:15] oh wait! in the new version we don't do this anymore... ha [21:09:47] mooeypoo: there's a migration to do... I thought you were starting from scratch [21:10:13] stephanebisson, we are.... except for that page which dumbily enough I rewrote rather than cmpletely start from scratch. [21:10:29] "I need a page too! I'll just erase the body" ... yeah. Silly. I am rewriting it [21:10:54] just do `page_url 'url as string here'` [21:11:04] no more URL [21:11:10] yeah [21:11:21] This is a general page, so I don't need page_url at all, I don't think [21:11:32] even better [21:12:22] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Renaming an account doesn't move the Flow board on the user's talk page - https://phabricator.wikimedia.org/T113701#1676563 (10DannyH) [21:12:52] stephanebisson, I have this definition in the ArticlePage: a(:notifications_alert_badge, css: '#pt-notifications-alert a') [21:13:03] in my step, I have on(ArticlePage).notifications_alert_badge.click [21:13:21] and I get the error "undefined method `click' for nil:NilClass (NoMethodError)" :\ [21:13:41] Does that mean it wasn't in the DOM or that I'm using a wrong click() function? I thought links are .click [21:14:05] if notifications_alert_badge is defined as link(:notifications_alert_badge, ) [21:14:07] nil:NilClass sounds like it didn't find it, which, if true, is terrible. [21:14:21] doing page.notifications_alert_badge will invoke the default action, which is click [21:15:18] alternatively, you can write `page.notifications_alert_badge_element.click` [21:15:28] _element ... that's waht I was missing [21:15:31] but I'll try without the click first [21:15:51] \o/ my first test passes [21:16:42] btw, stephanebisson there's no "I am logged in as a new user" in MW steps? [21:16:54] mooeypoo, do you think we should delete the Echo browser test jobs until they're rewritten and pass on Jenkins, or would you rather just keep them running (may bother the QA team depending when they go green again)? https://phabricator.wikimedia.org/T94152#1676556 [21:16:55] I see you've added that to Flow (and I'm stealing it) but it sounds like it should be a general mw-wide rule [21:17:11] mooeypoo: it could be [21:17:20] matt_flaschen, yeah I'm working on a patch now that basically deletes all of them and I'm rewriting [21:17:31] but it might take a bit to rewrite everything as I get re-used to ruby and selenium [21:17:36] I guess I can also do it in steps [21:18:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Switching Flow's editor-mode from VE to wikitext whilst a link inspector is open, makes the edit area fully collapse - https://phabricator.wikimedia.org/T113382#1676568 (10Etonkovidova) Checked in betalabs - Chrome 45, FF 41, and Safari 8.0.8. [21:18:08] mooeypoo, yeah, whatever you think is better. See my link. [21:18:14] matt_flaschen, mooeypoo: I think we should keep the jobs. But very soon it's just going to run the new tests, which should be passing. [21:18:32] mooeypoo, yeah, the general rule is to put something in mediawiki-selenium if it's needed for more than one repo. [21:19:12] (03PS1) 10Mooeypoo: [wip] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 [21:19:14] 6Collaboration-Team-Backlog, 10Echo, 10Browser-Tests: Fix or delete failing Echo browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94152#1676570 (10Mattflaschen) Let's keep them for now, since @mooeypoo is actively working on the rewrite. [21:19:28] and yeah, I agree with stephanebisson about keeping the jobs [21:19:31] mooeypoo: you don't have to rewrite everything before merging. Having just 1 test, a good test, would already be a step up [21:19:46] stephanebisson, aye, I was going to say that... look at the above commit [21:20:19] that is a "setup" really -- deleting everything old, correcting the Gemfile, rewriting the page definition to fit the new 2-badge system and have a single no-js test. [21:20:26] We can start with that maybe? I can add tests on top of it [21:20:48] (03CR) 10jenkins-bot: [V: 04-1] [wip] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 (owner: 10Mooeypoo) [21:20:49] It's a small silly test, though. Not really enough, but I wanted to make sure my upgrade and setup works. [21:21:58] mooeypoo: don't worry too much about step reuse. Your page objects and components are where the real reuse is. Steps exist to serve the features file and readability of the feature files is critical even is if means re-implementing steps with a different wording. [21:22:16] * mooeypoo nods [21:22:31] yeah I copied it over, but I was just thinking that it could probably be useful for more repos [21:22:34] stephanebisson mooeypoo: sorry, lurking, but if you're interested in trying a simpler (albeit experimental) syntax for browser tests, let me know (see https://phabricator.wikimedia.org/T108273#1520544) [21:22:51] define "experimental" ? Is it working? [21:22:58] it works, yes [21:23:13] however, there's no jenkins job for rspec invocation [21:23:20] though setting one up wouldn't be difficult [21:23:24] hm [21:23:24] rspec instead of cucumber? [21:23:35] yep, plain ol' rspec [21:23:45] no "natural language" stuff :) [21:23:54] i find it much easier to follow and debug [21:24:14] but i haven't found a candidate to try it out yet [21:24:33] I don't know... There's something good about having tests that follow the same convention as the rest of the extensions [21:24:34] I love rspec in general and I know exactly which test I'll use it on [21:24:52] But I don't mind either way, since I am pretty much learning as I go here anyways [21:25:03] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Notification: the counter for Messages that come from updates on User talk page in wikitext is not updated correctly. - https://phabricator.wikimedia.org/T113645#1676573 (10Etonkovidova) Checked in betalabs. [21:25:07] but I like the abstraction of cucumber for some browser tests that I want to read like specs [21:25:08] mooeypoo: yeah, hence my difficulty in finding a candidate for experimentation :) [21:26:05] heh yeah. [21:26:06] stephanebisson: yeah, i've gone back and forth on it many times, but in my experience the cost of cucumber indirection outweighs the benefits [21:26:24] and the internals of cucumber scare me [21:26:38] Are they green and seedy? [21:26:40] anyway, no pressure to use it it [21:26:57] Can we mix? [21:26:58] it was a net benefit to implement since it forced me to generalize some more things in the framework [21:27:00] marxarelli: any plan to have it run in jenkins? [21:27:25] once we have something to run, i can help w/ the jjb [21:28:04] it shouldn't be difficult. i just haven't had a reason to do it yet [21:28:57] I'll play with it [21:29:07] mooeypoo: green but not seedy, and not green in a "fresh" way [21:29:09] OKay, for the moment, I"ll continue as-is [21:29:24] sweet! sorry to interrupt [21:29:27] marxarelli, I hate when cucumbers go all gooey [21:29:31] * marxarelli sidesteps away [21:29:32] It will force me to encapsulate higher level actions in the page objects, which is a good thing but I have been lazy about [21:29:45] no no that was great , update interruptions are good [21:30:04] marxarelli: what about login through API? [21:30:52] stephanebisson: yes! that's the main advantage to the new form i think; it promotes use of straightforward Ruby patterns instead of Cucumber steps [21:30:56] hm legoktm do we have an API way to add a notification to a user ? [21:31:21] say, the browser test sends a notification before we check there's a notification? I can't trust the "new users have 1 welcome notification" because not all wikis have it [21:31:35] and I would like to test if unseen notifications become seen, and unread->read, etc [21:32:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Use EditorWidget for topic summary - https://phabricator.wikimedia.org/T111102#1676606 (10Etonkovidova) Re-checked Summary editing finctionality in betalabs(re-checked the following issues too: T111984: Summarize: switching... [21:32:37] stephanebisson: i'd like to eventually remove watir and simplify our pages objects, too. we should chat about it some time [21:34:03] marxarelli: any update on log-in using the API instead of Special:UserLogin? [21:34:42] stephanebisson: ugh, yeah ... i was supposed to email -QA about that :) [21:34:46] it works! [21:34:52] and it's in the newest release [21:35:07] marxarelli: shutup and take my money [21:35:17] haha [21:36:18] so I can use it now? [21:37:21] stephanebisson: oh wait, i lied [21:37:28] we didn't release it apparently [21:37:31] but it does work [21:38:01] * marxarelli gives stephanebisson his money back w/ interest [21:44:16] marxarelli: well, let me know when it's out. It's going to shave off some precious seconds. [21:49:36] stephanebisson: will do [21:56:15] stephanebisson, or in the case of my computer, minutes. [21:57:25] mooeypoo: did you unpress the turbo button? You know you shouldn't do that [21:58:50] stephanebisson, THAT's what it is! [21:58:59] When it's pressed everything is moving too fast. [22:01:28] 3Collaboration-Team-Current, 10Flow: 'View and restore deleted pages' displays broken layout for deleted Flow pages - https://phabricator.wikimedia.org/T113668#1676713 (10SBisson) p:5Triage>3High [22:01:51] 3Collaboration-Team-Current, 10Flow: 'View and restore deleted pages' displays broken layout for deleted Flow pages - https://phabricator.wikimedia.org/T113668#1676716 (10SBisson) a:3SBisson [22:03:15] stephanebisson, do you know where I can find all available elements in cucumber? how do I represent a span ? Just span() ? [22:03:39] I keep getting confused with things. Like, there's no p() and no a() but link(), etc [22:03:45] mooeypoo: not in cucumber but the page-object gem: https://github.com/cheezy/page-object/wiki/page-object [22:03:59] oh great [22:04:06] I am ruby-newbie [22:04:34] mooeypoo: reading this doc will help you a lot. Make sure to check: https://github.com/cheezy/page-object/wiki/Page-Sections [22:04:58] you can encapsulate your widgets and compose your pages [22:05:06] * mooeypoo nodes [22:05:09] yeah I'm trying to figure that out now [22:06:36] also, make sure to run rubocop locally or your patches will all fail [22:07:07] rubocop tests/browser/features/**/*.rb [22:07:35] eh, "Inspecting 0 files" [22:07:59] well, it depends where you are now [22:08:17] bah [22:08:42] I have 2 terminals open, in one i"m in Echo/ and in one i'm in Echo/tests/browser, and I ran this in the latter. Pff. Hang on [22:10:53] (03PS2) 10Mooeypoo: [wip] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 [22:12:29] (03CR) 10jenkins-bot: [V: 04-1] [wip] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 (owner: 10Mooeypoo) [22:12:40] (03PS3) 10Mooeypoo: [wip] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 [22:14:21] (03CR) 10jenkins-bot: [V: 04-1] [wip] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 (owner: 10Mooeypoo) [22:44:08] (03PS4) 10Mooeypoo: Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 [22:45:41] (03CR) 10jenkins-bot: [V: 04-1] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 (owner: 10Mooeypoo) [22:48:29] (03PS5) 10Mooeypoo: Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 [22:50:10] (03CR) 10jenkins-bot: [V: 04-1] Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 (owner: 10Mooeypoo) [22:51:05] (03PS6) 10Mooeypoo: Rewrite browser tests for Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/241231 [22:51:09] * mooeypoo stares at jenkins [22:59:04] https://i.imgur.com/zuGQrYX.png [23:01:09] * quiddity collapses for an hour or two. (This autumn weather is doing something unpleasant to my head, in late afternoons. Bring on winter and the long darkness!) Have a good weekend, all. [23:05:01] Jerkins [23:09:15] feel better, quiddity ! [23:50:38] marxarelli, are you still around? [23:50:53] for a little bit yeah [23:51:02] I'm looking into some of the Flow step definitions to get stuff into Echo, and I ran into this lovely piece: api.log_in user, password unless api.logged_in? [23:51:14] marxarelli, ^^ does that mean we can log in from the api...? [23:51:49] mooeypoo: yes we can! [23:51:55] mooeypoo: but not with that [23:51:57] In the Echo testss, I have to have 2 users. One in the current session to test with, and another to add crap to the first user's notifications [23:51:59] that's just for api auth [23:52:09] Yeah I need to add pages through the API [23:52:17] but it sucks if I constantly need to re-log in [23:52:30] ah, you want `as_user` [23:52:37] yes? [23:52:38] I think? [23:52:42] e.g. `as_user(:b) { api.do_stuff }` [23:52:47] yes! [23:52:58] I wrote this: [23:52:58] def create_page_with_user(title, text, username) [23:52:59] visit(LoginPage).login_with username, password [23:52:59] api.create_page title, text [23:52:59] end [23:53:08] Which is partially taken from the previous Echo tests [23:53:11] ah right, that won't work [23:53:32] now i'm thinking api.log_in user, password unless api.logged_in? [23:53:35] you're authenticating the browser session but not the api in that first part [23:53:40] instead of the visit... [23:53:41] yeah [23:53:47] you don't need the `unless` part [23:53:59] just start using `api` and it will authenticate if it needs to [23:54:05] Wait, so I can have 1 user in the API and one in the browser? I don't need to log out or re-log-in from the browser user [23:54:17] yep, i would recommend that actually [23:54:24] that way you don't have to juggle browser sessions [23:54:34] awesomesauce [23:54:42] try to do everything in the precondition (Given) with the api [23:54:52] the previous Echo tests did juggle sessions, my head is spinning from trying to figure out what they did and how to do it [23:54:59] Aye [23:55:02] i remember looking at them [23:55:11] my head spun as well [23:55:12] :) [23:55:43] a lot of the refactoring to mw-selenium 1.x was based off the crazy patterns in echo and flow [23:55:58] i figured if we could get those right, everything else would be cake [23:56:37] mooeypoo: https://doc.wikimedia.org/rubygems/mediawiki-selenium/MediawikiSelenium/Environment.html#as_user-instance_method [23:56:49] oooooo [23:57:02] although if I can have a different api user and browser session user, I"m golden [23:57:14] I just need 1 browser user to test that whatever the API user is doing (sending notifications) works [23:57:27] no need to log in repeatedly = win [23:57:32] right, that sounds like a good approach [23:58:25] though there are a couple of times I'll need the API for the browser user [23:58:36] mooeypoo: that's possible too! [23:58:39] but I can just re-login to the api with its credentials in that case [23:58:49] (to log in the browser session via the api) [23:58:55] as of 1.6.0 which i just released today [23:59:00] we [23:59:03] we're using 1.4 [23:59:10] but wait, why do we need anything new? [23:59:11] def clear_notifications(username) [23:59:11] api.log_in username, password [23:59:11] api.action('echomarkread', token_type: 'edit', all: '1') [23:59:11] end [23:59:22] ^^ that would clear notifications for any username I specify... no? [23:59:29] (as long as the password matches of course) [23:59:32] you don't strictly need it [23:59:52] I don't?