[00:04:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1664783 (10Catrope) Now that `$wgFlowMigrateReferenceWiki` is off everywhere, I tried to run the script, but... [00:05:17] (03PS1) 10Mooeypoo: Prevent the badge icon from flashing red when updating notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240294 (https://phabricator.wikimedia.org/T112823) [00:08:16] 3Collaboration-Team-Current, 10Echo, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification - https://phabricator.wikimedia.org/T55564#1664798 (10Etonkovidova) Checked in betalabs - reverts made by I... [00:15:53] (03CR) 10Catrope: [C: 04-1] Prevent the badge icon from flashing red when updating notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240294 (https://phabricator.wikimedia.org/T112823) (owner: 10Mooeypoo) [00:16:07] mooeypoo: are your lighting talk slides uploaded anywhere? [00:16:15] (03PS1) 10Mooeypoo: Remove 'initiallyUnseen' class when the popup closes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240295 [00:16:45] legoktm, yep there's a link from the lightning talk page [00:16:51] i uploaded to commons [00:17:25] ty :D [00:19:00] https://fr.wikipedia.org/wiki/Aide:Notifications they've already updated their docs, wow [00:19:48] https://commons.wikimedia.org/wiki/File:Clocheuhuhu.PNG what language is that filename in? o.O [00:24:33] legoktm: Did you see the table of namespaces and whether mentions work there? [00:24:46] They like reverse-engineered all this informaton [00:25:07] (03PS2) 10Mooeypoo: Prevent the badge icon from flashing red when updating notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240294 (https://phabricator.wikimedia.org/T112823) [00:25:17] (03CR) 10Mooeypoo: Prevent the badge icon from flashing red when updating notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240294 (https://phabricator.wikimedia.org/T112823) (owner: 10Mooeypoo) [00:26:08] legoktm: Also, Monphyla, Kze, Eaadki [00:28:38] RoanKattouw: well that's out of date, mentions work in all namespaces [00:39:13] mooey|away: I think you might enjoy https://en.wikipedia.org/wiki/User:Kaldari/nerdalert.js, it looks like https://commons.wikimedia.org/wiki/File:Notifications-Message-Indicator-OptionG2-Nerd-Alert-Screenshot-05-07-2013.png [00:46:53] (03PS1) 10Legoktm: Remove duplicate 'MediaWiki' prefix from echo.unseen stats [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240298 [00:47:16] (03PS18) 10Sbisson: EditTopicSummary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) [00:48:05] (03CR) 10Krinkle: [C: 032] Remove duplicate 'MediaWiki' prefix from echo.unseen stats [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240298 (owner: 10Legoktm) [00:50:35] (03CR) 10Sbisson: EditTopicSummary widget (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:51:08] (03PS1) 10Legoktm: Remove duplicate 'MediaWiki' prefix from echo.unseen stats [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240300 [00:51:18] (03Merged) 10jenkins-bot: Remove duplicate 'MediaWiki' prefix from echo.unseen stats [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240298 (owner: 10Legoktm) [00:51:23] (03CR) 10Legoktm: [C: 032 V: 032] Remove duplicate 'MediaWiki' prefix from echo.unseen stats [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240300 (owner: 10Legoktm) [00:51:40] (03PS2) 10Sbisson: Show the wikitext editor first on the undo pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240019 (https://phabricator.wikimedia.org/T112338) [01:00:26] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: MediaWiki.echo.overlay stats are wrong after lazy-load - https://phabricator.wikimedia.org/T113387#1664871 (10Legoktm) 5Open>3Resolved [01:08:20] quiddity: thanks :D [01:30:13] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1664888 (10Etonkovidova) Checked in betalabs - one case seems still to be producing an error - deleted page Talk:ET25 was crea... [03:35:05] 10Pywikibot-Flow, 5Patch-For-Review: Update bot to support Flow and demo it - https://phabricator.wikimedia.org/T108969#1664923 (10NiharikaKohli) @quiddity, This might help: {T109287} [06:15:39] 6Collaboration-Team-Backlog, 10MoodBar, 7I18n, 5Patch-For-Review: Add GENDER support to MediaWiki:Moodbar-log-hide and friends - https://phabricator.wikimedia.org/T45481#1665205 (10Nemo_bis) >>! In T45481#1664202, @gerritbot wrote: > Change 240175 had a related patch set uploaded (by Haritha28): > Add GEND... [07:28:06] (03CR) 10Aklapper: "Haritha28: Did you test whether your change works in your local installation?" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240175 (https://phabricator.wikimedia.org/T45481) (owner: 10Haritha28) [09:13:45] 6Collaboration-Team-Backlog, 10WikiLove, 10Possible-Tech-Projects, 10UI-Standardization: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#1665637 (10Qgil) This is a message posted to all tasks under "Backlog" at #Possible-Tech-Projects. #Outreachy-Round-11 is around the... [10:24:43] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1665780 (10Petrb) OK, I guess I will need to read some documentation. The implementation is probably not go... [10:53:52] 3Collaboration-Team-Current, 10Flow, 7I18n, 7RTL, 7WorkType-NewFunctionality: Bidi-isolate username fields in Flow boards - https://phabricator.wikimedia.org/T106741#1665801 (10SBisson) a:3Mooeypoo [10:54:39] 6Collaboration-Team-Backlog, 10Flow: [Regression-betalabs] Error on View history of User talk page after second opt-in - https://phabricator.wikimedia.org/T113103#1665812 (10SBisson) [11:35:34] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1665955 (10SBisson) p:5Unbreak!>3High [11:38:39] hey mlitn [11:42:10] hey stephanebisson [11:43:16] mlitn: on Flow history pages, what are the meaning of "cur" and "prev" links? Is it the same thing as regular wikitext pages? [11:43:27] "Legend: (cur) = difference with latest revision, (prev) = difference with preceding revision" [11:43:38] yeah [11:43:48] I think they’re the same for Flow (I can be wrong) [11:44:48] so there should be a "cur" link for all rev except the latest [11:45:02] and there should be a "prev" link for all rev expect the first [11:45:15] if so, it's broken [11:46:08] mlitn: do you know how/where are those links generated? [11:54:44] ehm [11:54:51] looks like we have no HistoryFormatter :p [11:54:56] let’s see [11:56:26] right [11:57:07] flow_block_board_history.handlebars & flow_block_topic_history.handlebars, which both include flow_history_line.partial.handlebars [12:00:29] the data comes from BoardHistoryQuery.php, PostHistoryQuery.php & TopicHistoryQuery.php - basically from AbstractQuery::buildResult, and it’s formatted by RevisionFormatter::formatApi [12:00:37] so those links come from RevisionFormatter::buildLinks [12:09:55] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1666052 (10Elitre) @Cpiral [[ https://www.mediawiki.org/wiki/Topic:Spf62apypqeiusic | seems to be reporting ]] that the same issue for him went away when resetting prefs to default. [12:23:35] (03PS5) 10DCausse: Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [12:27:01] (03CR) 10DCausse: [C: 032] Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [12:29:43] (03Merged) 10jenkins-bot: Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [13:40:41] mlitn: I found this comment in the code: // the root post (topic title) has the same id as the workflow [13:41:07] at the db level, does this mean: flow_revision.rev_id === flow_workflow.workflow_id ? [13:41:15] for a new topic [13:41:42] flow_revision.rev_type_id === flow_workflow.workflow_id (not rev_id) [13:46:08] mlitn: I'm really confused by the collections [13:48:17] mlitn: essentially, AbstractQuery->getCurrentRevision does not work for summaries [13:48:49] when asked for the current revision of a summary, it returns the current revision of the topic it is attached to [13:52:56] mmh yeah [13:52:59] so [13:53:20] every revision has an id [13:53:38] every revisionable object also has another id, the “collection id” (rev_type_id) [13:53:54] rev_type_id stays the same for all revisions of that thing [13:54:20] workflow id === topic title collection id === summary collection id [13:54:46] AbstractQuery::getCurrentRevision keeps a collection id => last revision id array [13:54:56] but topic title & topic summary both have the same collection id [13:55:09] so one will override the other [13:55:16] so for summary it has 2 purposes: group the revision of that summary AND identify which topic it is attached to [13:55:23] $currentRevisionId = $this->currentRevisionsCache[$collectionId->getAlphadecimal()]; [13:55:24] return $this->revisionCache[$currentRevisionId->getAlphaDecimal()]; [13:55:55] there is no way currentRevisionsCache can hold both topic title & summary, since both have the same $collectionId [13:56:07] that’s probably why you get a topic title instead of a summary [13:56:14] makes sense [13:56:40] so it's probably been broken for a while [13:56:55] since forever, I assume :p [13:57:10] a quick fix would be to prepend $revision->getRevisionType() to the id [13:57:41] so we’d get ‘post-’ and ‘post-summary-’ as keys [14:41:05] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one button on personal bar - https://phabricator.wikimedia.org/T111871#1666429 (10Paladox) 5declined>3Open [14:41:18] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one button on personal bar - https://phabricator.wikimedia.org/T111871#1618535 (10Paladox) Re opening this since it is a valid task. [14:55:49] (03PS1) 10Sbisson: Fix 'cur' and 'prev' links for topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) [14:57:35] (03CR) 10jenkins-bot: [V: 04-1] Fix 'cur' and 'prev' links for topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [15:01:29] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [15:10:44] I'm gonna be late into the office today, Caltrain hit someone [15:10:57] (03PS1) 10Matthias Mullie: Try loading moved Flow board content differently [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240367 [15:12:01] (03CR) 10Matthias Mullie: [C: 032] Fix 'cur' and 'prev' links for topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [15:15:20] (03CR) 10jenkins-bot: [V: 04-1] Fix 'cur' and 'prev' links for topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [15:18:23] (03CR) 10Sbisson: [C: 032] Try loading moved Flow board content differently [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240367 (owner: 10Matthias Mullie) [15:19:27] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [15:21:31] (03Merged) 10jenkins-bot: Try loading moved Flow board content differently [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240367 (owner: 10Matthias Mullie) [15:29:48] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one button on personal bar - https://phabricator.wikimedia.org/T111871#1666577 (10Aklapper) 5Open>3declined This task is about reverting (see task summary). That specific request has been declined for the time being, so declined correctly reflect the... [15:51:07] (03CR) 10Matthias Mullie: [C: 04-1] "Code seems to look fine. I've spotted some weird things when testing, though." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [15:54:31] (03CR) 10Matthias Mullie: Fix exception on board history page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [15:59:28] wow, there is a series of bug i want to fix [15:59:43] but the problem is dealin with .gitignore file and vendor files [16:00:00] https://phabricator.wikimedia.org/T110418 is one of them [16:10:46] I made it to Palo alto :/ [16:19:47] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [16:26:49] 3Collaboration-Team-Current, 10Flow: Catchable fatal error: Argument 1 passed to Flow\UrlGenerator::boardLink() must be an instance of Title, null given - https://phabricator.wikimedia.org/T113312#1666707 (10SBisson) a:3SBisson [16:29:42] (03PS1) 10Sbisson: Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) [16:42:09] (03PS2) 10Matthias Mullie: Fix 'cur' and 'prev' links for topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [16:55:48] (03CR) 10Sbisson: [C: 032] "Per Matthias" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [16:59:12] stephanebisson: T110696 - what do you think about my comment? Should be a separate bug? Or ...? [16:59:28] (03Merged) 10jenkins-bot: Fix 'cur' and 'prev' links for topic summary [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240366 (https://phabricator.wikimedia.org/T113261) (owner: 10Sbisson) [17:00:53] etonkovidova: if it needs to be done now, then that's the same bug. If we want to postponed, then a separate one [17:01:12] etonkovidova: I would prefer to fix it right away [17:01:30] stephanebisson: hmm... I was inclined to make it a separate issue :) [17:01:53] stephanebisson: but if you see it as an easy fix - ok then [17:02:04] I don't know if it's easy [17:02:16] but it's broken, and I don't like broken [17:03:33] a separate issue is fine, we can ask dannyh about priorities [17:08:45] stephanebisson: let me try couple of some tests - I suspect that that one in the comment is not an isolated case. [17:09:26] stephanebisson: cause if it's an isolated issue - then it can be a separate issue; if not - then we'll see ... [17:38:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1666966 (10Mooeypoo) p:5High>3Normal [17:38:35] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1647172 (10Mooeypoo) p:5High>3Normal [17:45:40] (03PS1) 10Matthias Mullie: Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 [17:57:04] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Add text to move log item during opt-in process to explain better - https://phabricator.wikimedia.org/T113500#1667048 (10DannyH) 3NEW [18:01:36] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Add text to move log item during opt-in process to explain better - https://phabricator.wikimedia.org/T113500#1667088 (10SBisson) This is the solution to the problem outlined in {T111220} [18:06:41] 3Collaboration-Team-Current, 10Flow: Opt-in: Copy templates above the first heading when enabling Flow on an existing wikitext page - https://phabricator.wikimedia.org/T113426#1667121 (10Quiddity) [18:06:43] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Opt-in Flow -- Blacklist of templates to not copy into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1667120 (10Quiddity) [18:17:34] Could someone review that ancient 11 lines Moodbar patch in https://gerrit.wikimedia.org/r/#/c/49478 ? [18:18:05] It's Gerrit Cleanup time, you know, and I wade through the backlog a bit [18:25:47] (03CR) 10Sbisson: [C: 032] Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [18:25:51] (03PS1) 10Matthias Mullie: Add better debug info for FlowFixLinks.php failure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240439 [18:28:03] (03CR) 10Catrope: [C: 032] Add better debug info for FlowFixLinks.php failure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240439 (owner: 10Matthias Mullie) [18:28:47] (03CR) 10Catrope: [C: 032] Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [18:29:58] (03CR) 10jenkins-bot: [V: 04-1] Add better debug info for FlowFixLinks.php failure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240439 (owner: 10Matthias Mullie) [18:30:15] (03CR) 10Matthias Mullie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240439 (owner: 10Matthias Mullie) [18:35:49] (03CR) 10Legoktm: [C: 032] Use :hover instead of jQuery based styling [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (https://bugzilla.wikimedia.org/38345) (owner: 10Nischayn22) [18:35:56] andre__: reviewed [18:42:42] (03CR) 10jenkins-bot: [V: 04-1] Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [18:42:45] (03Merged) 10jenkins-bot: Add better debug info for FlowFixLinks.php failure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240439 (owner: 10Matthias Mullie) [18:42:48] (03CR) 10jenkins-bot: [V: 04-1] Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [18:42:50] (03Merged) 10jenkins-bot: Use :hover instead of jQuery based styling [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/49478 (https://bugzilla.wikimedia.org/38345) (owner: 10Nischayn22) [18:50:26] legoktm, thanks [18:51:07] 6Collaboration-Team-Backlog, 10MoodBar, 5Patch-For-Review: Moodbar smileys styled by JS-added class instead of plain CSS - https://phabricator.wikimedia.org/T40345#1667322 (10Legoktm) 5Open>3Resolved [19:06:09] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [19:07:01] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [19:08:08] (03PS2) 10Matthias Mullie: Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 [19:11:45] (03CR) 10jenkins-bot: [V: 04-1] Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [19:30:30] (03CR) 10Sbisson: [C: 032] "Per Roan" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [19:30:42] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [19:34:37] 6Collaboration-Team-Backlog, 10Echo, 7Design: Line height is too low, text appears cramped in Special:Notifications - https://phabricator.wikimedia.org/T73358#1667563 (10PeterBowman) This seems to have been fixed with 1.26wmf24. [19:43:46] (03CR) 10Sbisson: Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [19:43:54] (03CR) 10Sbisson: [C: 032] Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [19:51:40] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1667623 (10DannyH) Some questions from team meeting, for further consideration: What order do we show the cross-wiki notifications? Alphabetical by project could use the Ro... [19:57:21] (03CR) 10jenkins-bot: [V: 04-1] Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [20:27:06] (03Merged) 10jenkins-bot: Read new page id from master [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240428 (owner: 10Matthias Mullie) [20:37:05] (03CR) 10Hashar: "Seems to be a transient issue with the qunit job. You will want to remove your +2 vote and vote +2 again." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [20:37:25] (03CR) 10Sbisson: Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [20:37:39] (03CR) 10Sbisson: [C: 032] Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [20:43:47] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1667845 (10Mooeypoo) As we discussed in our meeting, I think that the notification bundling should be a bit more flexible. My idea is to maybe try to bundle per-wiki, showing... [20:45:21] 3Collaboration-Team-Current: [betalabs] enwiki - ref_src_wiki column is missing from v2 index - https://phabricator.wikimedia.org/T113525#1667853 (10Etonkovidova) 3NEW a:3Catrope [20:52:20] (03Merged) 10jenkins-bot: Log a warning when no title is given for parameter 'new-topics-permalink' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240382 (https://phabricator.wikimedia.org/T113312) (owner: 10Sbisson) [20:52:46] i dunno if its new, but i was just poking the logs on deployment-fluorine and lots of notices from PostRevision.php:12[27] about Undefined index: tree_rev_id [21:02:29] stephanebisson: sorry to bother you... when you have a sec, can take a look at: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:ET24&action=history [21:03:00] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1667945 (10matthiasmullie) Seems to be fixed with https://gerrit.wikimedia.org/r/#/c/240428/ [21:03:30] etonkovidova: I can see it [21:06:11] etonkovidova: never seen it before, is there anything special you did to this board? [21:11:12] stephanebisson: nothing specific - at least I cannot recall anything special Sigh... [21:11:57] stephanebisson: only that board gives that error [21:41:18] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-UniversalLanguageSelector, 7Design, and 2 others: Use consistent preferences icon - https://phabricator.wikimedia.org/T52843#1668151 (10Mooeypoo) Since we're moving the system to OOJS-UI (in the MediaWiki theme that is supported by the UI standard... [21:43:03] (03CR) 10Mooeypoo: [C: 04-1] "I am not sure this is the right thing to do anymore. We are migrating the system to oojs-ui which has its own icons (that are supported an" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/177269 (https://phabricator.wikimedia.org/T52843) (owner: 10Mlawnik) [21:47:31] (03CR) 10Mooeypoo: "What can be done in this fix to make it relevant is to transform the settings icon in Special:Notifications to an oo-ui-icon-advanced. Reg" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/177269 (https://phabricator.wikimedia.org/T52843) (owner: 10Mlawnik) [21:56:32] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1668212 (10Etonkovidova) 1) > The notifications that were received 1 minute (or 1 hour) ago are buried inside a "vague" bundle of cross-wiki notifications. The user has to op... [22:00:50] 3Collaboration-Team-Current: [betalabs] enwiki - ref_src_wiki column is missing from v2 index - https://phabricator.wikimedia.org/T113525#1668222 (10Catrope) 5Open>3Resolved ``` mysql> show index from flow_wiki_ref; +---------------+------------+---------------------------+--------------+-------------------... [22:38:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Marking a Flow topic as unresolved creates "cur" links that give Fatal exceptions - https://phabricator.wikimedia.org/T113261#1668401 (10Etonkovidova) Checked in betalabs for those two cases (links (http://en.wikipedia.beta... [23:03:01] RoanKattouw, ping for meeting :) [23:03:46] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1668512 (10DannyH) p:5Triage>3High [23:05:40] 6Collaboration-Team-Backlog, 10Flow: Issue with Matanya's talk page - https://phabricator.wikimedia.org/T113241#1668521 (10DannyH) It's rendering correctly for me in Firefox. Is this still happeneing? [23:07:43] 6Collaboration-Team-Backlog, 10Flow: Deleting the first comment of a topic (with no more comments) leaves the topic with zero comments - https://phabricator.wikimedia.org/T113143#1668537 (10DannyH) p:5Triage>3Normal [23:10:31] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1668567 (10Catrope) [23:10:32] 6Collaboration-Team-Backlog, 10Flow: Issue with Matanya's talk page - https://phabricator.wikimedia.org/T113241#1668566 (10Catrope) [23:11:23] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1612147 (10Catrope) Has anyone been able to reproduce this while logged-out? I strongly suspect this is due to a broken gadget or broken site scripts. [23:11:38] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1668572 (10Catrope) Also, has anyone seen any JS errors in their browser console while this happens? [23:12:36] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1668577 (10Catrope) p:5Triage>3High [23:14:45] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1668586 (10Catrope) [23:14:46] 6Collaboration-Team-Backlog, 10Flow: Editing a topic title and saving it without making any changes, records it as a change - https://phabricator.wikimedia.org/T113138#1668587 (10Catrope) [23:16:08] 6Collaboration-Team-Backlog, 10Echo: Rewrite Echo browser tests for the new split notification change - https://phabricator.wikimedia.org/T113081#1668614 (10Catrope) p:5Triage>3High [23:16:26] 3Collaboration-Team-Current, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1668619 (10Legoktm) ``` exception.log-20150918.gz:2015-09-17 18:48:33 mw1084 mediawikiwiki exception... [23:17:08] 3Collaboration-Team-Current, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1668622 (10Legoktm) p:5Unbreak!>3Low [ Lowering priority because I don't see any other instances... [23:18:55] 6Collaboration-Team-Backlog, 10Echo: Display a 'no notifications' empty option if there are no notifications in the Echo popup - https://phabricator.wikimedia.org/T113070#1668643 (10Catrope) > If we need an empty state for messages we can make something along the same lines: Right now the messages badge isn't... [23:19:34] 6Collaboration-Team-Backlog, 10Echo: Display a 'no notifications' empty option if there are no notifications in the Echo popup - https://phabricator.wikimedia.org/T113070#1668644 (10Catrope) p:5Triage>3Low [23:21:45] 6Collaboration-Team-Backlog, 10Flow: 'Add a template' box looks different on Flow pages - https://phabricator.wikimedia.org/T110966#1668650 (10Catrope) [23:21:46] 6Collaboration-Team-Backlog, 10Flow: there is an overflow on narrow screens when adding a template - https://phabricator.wikimedia.org/T113041#1668651 (10Catrope) [23:22:02] 6Collaboration-Team-Backlog, 10Flow: 'Add a template' box looks different on Flow pages - https://phabricator.wikimedia.org/T110966#1668653 (10Catrope) 5duplicate>3Open Duped it the wrong way [23:22:18] mooeypoo: Looks like you fixed the issues with the notifications that we talked about a while back! [23:22:19] 6Collaboration-Team-Backlog, 10Flow: there is an overflow on narrow screens when adding a template - https://phabricator.wikimedia.org/T113041#1653117 (10Catrope) [23:22:20] 6Collaboration-Team-Backlog, 10Flow: 'Add a template' box looks different on Flow pages - https://phabricator.wikimedia.org/T110966#1668656 (10Catrope) [23:22:45] (I'm looking at mediawiki.org) [23:23:18] Deskana, Yes. I call it: The Case of the Dreaded 1 Pixel. [23:23:38] I should blog about it. [23:23:44] 6Collaboration-Team-Backlog, 10Flow: Exception when moving Flow board - https://phabricator.wikimedia.org/T112954#1668659 (10Catrope) [23:23:50] mooeypoo: hi [23:23:55] d3r1ck, heya [23:24:00] mooeypoo: :) [23:24:20] mooeypoo: familiar with Mofile FE extension? [23:24:30] d3r1ck, somewhat [23:24:32] what do you need? [23:24:41] mooeypoo: review of my patches [23:24:55] 6Collaboration-Team-Backlog, 10Flow: Exception when moving Flow board - https://phabricator.wikimedia.org/T112954#1650888 (10Catrope) "Could not locate workflow" sounds scary, that shouldn't happen. [23:24:56] mooeypoo: will you do that for me? I will submit like 30 patches this today [23:25:08] and i need them reviewed, so will you help? :) [23:25:41] 6Collaboration-Team-Backlog, 10Flow: Exception when moving Flow board - https://phabricator.wikimedia.org/T112954#1668674 (10DannyH) p:5Triage>3Normal [23:25:45] d3r1ck, You should have someone from Mobile frontend review patches for the extension... I can try to help, but I'm not sure I'll be comfortable +2'ing things in there, I am not *that* familiar with the codebase. [23:25:56] 6Collaboration-Team-Backlog, 10Flow, 10BetaFeatures: Opt-out: mw-ui-feature-user-count in Preferences-Beta features is not updated after Save - https://phabricator.wikimedia.org/T112944#1668679 (10Catrope) [23:26:04] 6Collaboration-Team-Backlog, 10Flow, 10BetaFeatures: Opt-out: mw-ui-feature-user-count in Preferences-Beta features is not updated after Save - https://phabricator.wikimedia.org/T112944#1650687 (10Catrope) This sounds like it might be a bug in BetaFeatures? [23:26:10] 6Collaboration-Team-Backlog, 10Flow, 10BetaFeatures: Opt-out: mw-ui-feature-user-count in Preferences-Beta features is not updated after Save - https://phabricator.wikimedia.org/T112944#1668685 (10Catrope) p:5Triage>3Low [23:26:12] d3r1ck, are you submitting patches that are connected to tasks in phabricator? [23:27:14] mooeypoo: ys [23:27:25] mooeypoo: i am removing calls to deprecated modules [23:27:52] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1668688 (10Catrope) p:5Triage>3Normal [23:27:53] mooeypoo: it is simple to understand. jdlrobson has reviewd and merge the first one. It is fine but it seems he is busy [23:27:59] mooeypoo: that is why i need your help [23:28:00] d3r1ck, the mobile frontend team is likely following those tasks... especially if these are removing modules, they should be able to test properly and review. [23:28:34] We're all busy ;) I just don't know if I feel comfortable reviewing for that codebase. You should send them to review in any case [23:28:35] mooeypoo: yes, jdlrobson is alone on it. [23:28:59] so should i add you as reviewer? [23:29:05] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1668696 (10Catrope) How do you reproduce this exactly? Do you have to paste a link into a VisualEditor instance on that Flow board? [23:29:24] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1668699 (10Catrope) p:5Triage>3High [23:29:44] d3r1ck, I will likely not have time to review this today anyways. Send to review, ask the mobile frontend team to review it, and it will be added to their stack of things to review [23:30:02] ok [23:30:13] mooeypoo: thanks :) [23:30:56] 6Collaboration-Team-Backlog, 10Flow: Edit description link should be grey by default, not blue - https://phabricator.wikimedia.org/T112872#1668707 (10Catrope) p:5Triage>3Normal [23:31:50] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: A link to a Commons file is red colored on edit mode on Flow - https://phabricator.wikimedia.org/T112862#1668716 (10Catrope) [23:32:00] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: A link to a Commons file is red colored on edit mode on Flow - https://phabricator.wikimedia.org/T112862#1648455 (10Catrope) This is almost certainly a bug in VisualEditor. [23:32:16] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: A link to a Commons file is red colored on edit mode on Flow - https://phabricator.wikimedia.org/T112862#1668721 (10Catrope) p:5Triage>3Normal [23:32:43] 6Collaboration-Team-Backlog, 10Flow: Create a Flow sandbox board on French Wikipedia - https://phabricator.wikimedia.org/T112860#1668722 (10Catrope) p:5Triage>3High [23:33:09] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1668725 (10Catrope) 5duplicate>3Open Duped this in the wrong direction. [23:33:16] 6Collaboration-Team-Backlog, 10Flow: Editing a topic title and saving it without making any changes, records it as a change - https://phabricator.wikimedia.org/T113138#1668729 (10Catrope) [23:33:18] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1668730 (10Catrope) [23:33:37] 6Collaboration-Team-Backlog, 10Flow: Create a Flow sandbox board on French Wikipedia - https://phabricator.wikimedia.org/T112860#1668732 (10DannyH) 5Open>3Resolved Okay, done! [23:33:46] 6Collaboration-Team-Backlog, 10Flow, 10Security-Reviews, 6Security-Team: Security review for Flow new structured workflow feature - https://phabricator.wikimedia.org/T112793#1668734 (10Catrope) p:5Triage>3Normal [23:33:47] d3r1ck: Some patience would be advised. We're all very busy working on our tasks and can't always drop everything to review a lot of patches. [23:34:22] 6Collaboration-Team-Backlog, 10Echo, 10Security-Reviews, 6Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#1668737 (10Catrope) p:5Triage>3Normal [23:34:28] d3r1ck: Your enthusiasm is great! But you'll need patience too. :-) [23:34:55] Deskana: thanks for the advice. I really appriciate :) [23:35:07] 6Collaboration-Team-Backlog, 10Flow: "There are no older topics" should not be on new Flow pages - https://phabricator.wikimedia.org/T112714#1668741 (10Catrope) p:5Triage>3Low Yeah we probably shouldn't show this message when there are 0 topics. [23:35:33] 6Collaboration-Team-Backlog, 10Flow: Flow shouldn't assume Parsoid is source of all VRS errors - https://phabricator.wikimedia.org/T112566#1668745 (10Catrope) Which error messages are you talking about exactly? [23:35:38] 6Collaboration-Team-Backlog, 10Flow: Flow shouldn't assume Parsoid is source of all VRS errors - https://phabricator.wikimedia.org/T112566#1668746 (10Catrope) p:5Triage>3Normal [23:36:58] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1668755 (10Catrope) >>! In T112477#1635889, @Huji wrote: > It does take me to the page, but that does not result in the item getting marked as read or the coun... [23:37:23] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1668758 (10Catrope) p:5Triage>3High [23:38:21] 6Collaboration-Team-Backlog, 10Flow: Missing 'View changes' for entries on User talk pages with Flow enabled (page-level diff) - https://phabricator.wikimedia.org/T112353#1668764 (10Catrope) p:5Triage>3Low [23:38:32] 6Collaboration-Team-Backlog, 10Flow: Collapsed templates in a Flow topic are not collapsed immediately after the initial save - https://phabricator.wikimedia.org/T112332#1668766 (10Catrope) [23:39:53] 6Collaboration-Team-Backlog, 10Flow: Collapsed templates in a Flow topic are not collapsed immediately after the initial save - https://phabricator.wikimedia.org/T112332#1632553 (10Catrope) I think this is because the wikipage.content hook or whatever it's named is not called. There are/were similar issues wit... [23:40:02] 6Collaboration-Team-Backlog, 10Flow: Collapsed templates in a Flow topic are not collapsed immediately after the initial save - https://phabricator.wikimedia.org/T112332#1668780 (10Catrope) p:5Triage>3Normal [23:42:22] 6Collaboration-Team-Backlog, 10MediaWiki-Page-editing, 7IPv6: Have one aggregated talk page for ipv6 /64 - https://phabricator.wikimedia.org/T112325#1668786 (10Catrope) p:5Triage>3Low [23:43:38] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Echo notification icons should be white in MonoBook to match Vector - https://phabricator.wikimedia.org/T112290#1668800 (10Catrope) p:5Triage>3High [23:44:09] 6Collaboration-Team-Backlog, 10MediaWiki-Page-editing, 7IPv6: Have one aggregated talk page for ipv6 /64 - https://phabricator.wikimedia.org/T112325#1668806 (10Legoktm) I imagine that everywhere we interact with an IPv6 address, we'd normalize it to the /64 version, and we'd never link to individual IPs or s... [23:47:35] 6Collaboration-Team-Backlog, 10Echo: Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1668833 (10Quiddity) 3NEW [23:47:52] 6Collaboration-Team-Backlog, 10Echo: Expected links in thank notification do not show in popup - https://phabricator.wikimedia.org/T112283#1668849 (10Catrope) This works the same in the old and the new systems: the entire notification is a link to the diff (and right-click works now), and the user name is a li... [23:48:23] 6Collaboration-Team-Backlog, 10Echo: Thanks notification should have link to page in popup, like it does in Special:Notifications - https://phabricator.wikimedia.org/T112283#1668852 (10Catrope) [23:48:29] 6Collaboration-Team-Backlog, 10Echo: Thanks notification should have link to page in popup, like it does in Special:Notifications - https://phabricator.wikimedia.org/T112283#1630909 (10Catrope) p:5Triage>3Normal [23:48:38] 6Collaboration-Team-Backlog, 10Echo: Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1668854 (10Quiddity) [23:49:56] 6Collaboration-Team-Backlog, 10Flow: Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1668860 (10Catrope) [23:50:16] 6Collaboration-Team-Backlog, 10Flow: Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1630878 (10Catrope) p:5Triage>3Normal [23:50:57] 6Collaboration-Team-Backlog, 10Flow: Warn people who left ~~~~ on a Flow message - https://phabricator.wikimedia.org/T112239#1668875 (10Catrope) p:5Triage>3Normal [23:51:05] 6Collaboration-Team-Backlog, 10Flow: Warn people who left ~~~~ on a Flow message - https://phabricator.wikimedia.org/T112239#1629672 (10Catrope) p:5Normal>3Low [23:52:00] 6Collaboration-Team-Backlog, 10Flow: Summary needs clear:both - https://phabricator.wikimedia.org/T112281#1668882 (10Quiddity) Here's an example of a summary where a {{clr}} has been manually added, to fix the problem. https://fr.wikipedia.org/wiki/Sujet:Sp323u8nxgzbit27 [23:52:38] 6Collaboration-Team-Backlog, 10Echo: Mark as read 'x' button is very small - https://phabricator.wikimedia.org/T112217#1668884 (10Catrope) p:5Triage>3Normal [23:53:03] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1668890 (10Catrope) [23:53:05] 6Collaboration-Team-Backlog, 10Echo: Icons fuzzy due to font size - https://phabricator.wikimedia.org/T112196#1668891 (10Catrope) [23:53:28] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1668896 (10Catrope) 5duplicate>3Open Meant to close the other one [23:53:36] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1668900 (10Catrope) [23:53:37] 6Collaboration-Team-Backlog, 10Echo: Icons fuzzy due to font size - https://phabricator.wikimedia.org/T112196#1628555 (10Catrope) [23:55:49] 6Collaboration-Team-Backlog, 10Flow: Empty alert box shows a blank item which throws an exception when clicked - https://phabricator.wikimedia.org/T112194#1668912 (10Catrope) [23:55:51] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1668913 (10Catrope) [23:58:24] 6Collaboration-Team-Backlog, 10Echo: Notifications from functionaries to users for when email isn't available - https://phabricator.wikimedia.org/T112142#1668931 (10Catrope) p:5Triage>3Low [23:58:55] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1668936 (10Catrope) p:5Triage>3Normal [23:59:03] (03PS2) 10Mooeypoo: Remove 'initiallyUnseen' class when the popup closes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240295 [23:59:21] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1668940 (10Catrope)