[00:00:27] (03CR) 10Catrope: [C: 032] Add an emailuser web notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239582 (https://phabricator.wikimedia.org/T56130) (owner: 10Umherirrender) [00:03:47] (03Merged) 10jenkins-bot: Add an emailuser web notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239582 (https://phabricator.wikimedia.org/T56130) (owner: 10Umherirrender) [00:06:23] RoanKattouw quiddity I'm cool with the woooo [00:07:29] (03PS17) 10Sbisson: EditTopicSummary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) [00:07:32] (03PS1) 10Sbisson: Show the wikitext editor first on the undo pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240019 (https://phabricator.wikimedia.org/T112338) [00:11:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1632698 (10SBisson) The same problem exists with # undo edit post # undo edit topic summary # undo edit board description [00:22:21] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#1661768 (10Mattflaschen) [00:23:21] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#1466223 (10Mattflaschen) T105843#1654271 indicates the new hardware p... [04:52:30] 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1661976 (10ssastry) 3NEW [04:54:05] 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 2 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1661987 (10ssastry) [07:22:02] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, 7Design: Encourage users to publish old inactive unpublished translations - https://phabricator.wikimedia.org/T89707#1662158 (10Pginer-WMF) [07:30:05] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 5Patch-For-Review, and 2 others: Provide web notifications when user is sent an email via Special:Emailuser - https://phabricator.wikimedia.org/T56130#1662186 (10Luke081515) @Umherirrender resolved, or is there still something which needs to be done? [07:30:33] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 5WMF-deploy-2015-09-22_(1.26wmf24), 7user-notice: Provide web notifications when user is sent an email via Special:Emailuser - https://phabricator.wikimedia.org/T56130#1662199 (10Luke081515) [08:42:52] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Turn on Flow for every talk page on Mediawiki.org (pending consensus) - https://phabricator.wikimedia.org/T113295#1662339 (10Aklapper) > Nick has started a discussion: Where? [09:35:05] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1662404 (10Pginer-WMF) >I was always a little confused about those "x" buttons, because they seem to not be very consistent. The "x" is usually for "close" actions (like in o... [10:21:17] hi [11:10:07] (03PS1) 10D3r1ck01: Permission file problem. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/240071 (https://phabricator.wikimedia.org/T111738) [11:23:17] (03CR) 10Hoo man: [C: 032] Permission file problem. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/240071 (https://phabricator.wikimedia.org/T111738) (owner: 10D3r1ck01) [11:25:46] (03Merged) 10jenkins-bot: Permission file problem. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/240071 (https://phabricator.wikimedia.org/T111738) (owner: 10D3r1ck01) [11:59:52] 6Collaboration-Team-Backlog, 10Thanks, 7Easy, 5Patch-For-Review: extensions/Thanks - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111738#1662615 (10JanZerebecki) 5Open>3Resolved [12:52:27] (03PS1) 10Sbisson: Browser tests: Wait for preloaded text to be populated in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240080 [12:57:01] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1662665 (10SBisson) [13:18:45] (03PS1) 10Matthias Mullie: Don't use getContent in optIn [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240084 [13:36:25] 6Collaboration-Team-Backlog, 10Thanks, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): extensions/Thanks - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111738#1662699 (10wpmirrordev) I confirm that the above mentioned debian lintian warning is cured.... [13:49:56] 6Collaboration-Team-Backlog, 10Thanks, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): extensions/Thanks - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111738#1662740 (10D3r1ck01) I am happy to hear that. I am glad i fixed the bug and willing to fix... [13:58:33] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Marking a Flow topic as unresolved creates "cur" links that give Fatal exceptions - https://phabricator.wikimedia.org/T113261#1662782 (10SBisson) a:3SBisson [14:14:23] (03PS1) 10Matthias Mullie: Add debug info to OptInController [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240093 (https://phabricator.wikimedia.org/T112784) [14:15:00] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1662810 (10Rical) A new case about the Gadget-oldeditor.js https://www.mediawiki.org/w/index.php?title=Topic:Spdy7ipje59svni8&action=history You could also look at my vector.js and https://www.mediawiki... [14:17:36] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1662818 (10Rical) A new case from another user about the Gadget-oldeditor.js https://www.mediawiki.org/w/ind... [14:28:17] 6Collaboration-Team-Backlog, 10Echo, 7Technical-Debt: Remove use of UserRights hook when UserGroupsChanged hook is available - https://phabricator.wikimedia.org/T113357#1662820 (10Anomie) 3NEW [14:28:35] 6Collaboration-Team-Backlog, 10Echo, 7Technical-Debt: Remove use of UserRights hook when UserGroupsChanged hook is available - https://phabricator.wikimedia.org/T113357#1662836 (10Anomie) [14:45:02] mlitn: you there? [14:45:19] yup [14:45:46] hey, quick question, with mysql command line, do you know how to format our IDs so they are readable? [14:45:58] HEX(rev_id) [14:46:00] they all start with ^E?... [14:46:10] then they’ll be hex format [14:46:18] wonderful [14:46:18] which UUID::create will understand [14:46:19] thanks [14:47:23] I have topicsummary_newRevision=spej1b3k6h1rlix1 (that doesn't look like anything I see in the db) [14:49:38] yeah, the printed UUIDs are in base 34 (0-9a-z), but HEX will only show them in base 16 (0-9a-f) [14:50:23] UUID::create( )->getAlphadecimal() will let you see what it is in base36 [14:50:30] is there any way to find 'spej1b3k6h1rlix1' in the db? [14:50:58] $hex = UUID::create( ‘spej1b3k6h1rlix1’ )->getHex(); [14:51:16] has any ID scheme ever been harder to use? [14:51:17] SELECT * FROM table WHERE id = UNHEX( … ); — … will be $uuid’s value [14:51:24] I think not :p [14:52:01] (we used to display them in hex, but people complained they were too long :p) [14:52:42] people still complain that they are nonsense [14:53:09] when used with the topic NS [14:54:14] so, UNHEX( 'spej38m71hc7qu4l' ) should work? [14:57:14] when I do "$hex = UUID::create( ‘spej1b3k6h1rlix1’ )->getHex();" in `php -a` it says "Class 'UUID' not found" [14:57:58] UNHEX( 'spej38m71hc7qu4l' ) won’t work [14:58:08] UNHEX will take hexadecimal and convert into binary [14:58:18] but you first need to convert alphanumeric to hexadecimal [14:58:26] not sure how to do that in SQL, but UUID can do it [14:58:43] that’ll be Flow\Model\UUID::create [14:58:53] but it probably won’t know about Flow [14:59:08] about Flow\Model\UUID [14:59:39] run maintenance/eval.php (in core) - that’ll be a PHP prompt with all of MW loaded [14:59:52] there you can do Flow\Model\UUID::create( … )->getHex() [15:18:39] those were never supposed to be displayed to the user beyond temporarily waiting for content handler to be enabled on prod wiki's....but then hiding those id's never made it back onto the roadmap :P [15:19:52] lol :) [15:20:42] nothing as permanent as a temporary solution [15:42:29] (03CR) 10Catrope: [C: 032] Browser tests: Wait for preloaded text to be populated in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240080 (owner: 10Sbisson) [15:43:47] (03PS2) 10Dduvall: Updated RuboCop to the latest released version [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/234533 (owner: 10Zfilipin) [15:45:37] (03Merged) 10jenkins-bot: Browser tests: Wait for preloaded text to be populated in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240080 (owner: 10Sbisson) [16:17:00] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 5WMF-deploy-2015-09-22_(1.26wmf24), 7user-notice: Provide web notifications when user is sent an email via Special:Emailuser - https://phabricator.wikimedia.org/T56130#1663142 (10Umherirrender) 5Open>3Resolved >>! In T56130#1662186, @Luke081515... [16:37:42] (03CR) 10Catrope: [C: 032] Don't use getContent in optIn [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240084 (owner: 10Matthias Mullie) [16:37:46] (03CR) 10Catrope: [C: 032] Add debug info to OptInController [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240093 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [16:41:10] (03Merged) 10jenkins-bot: Don't use getContent in optIn [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240084 (owner: 10Matthias Mullie) [16:42:52] (03CR) 10Umherirrender: "Thanks for the i18n fix, Catrope." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239582 (https://phabricator.wikimedia.org/T56130) (owner: 10Umherirrender) [16:42:59] (03Merged) 10jenkins-bot: Add debug info to OptInController [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240093 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [17:11:03] (03CR) 10Dduvall: [C: 032] Updated RuboCop to the latest released version [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/234533 (owner: 10Zfilipin) [17:11:13] (03PS2) 10Dduvall: Fixed Style/StringLiterals RuboCop offense [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/234534 (https://phabricator.wikimedia.org/T110672) (owner: 10Zfilipin) [17:11:18] (03Merged) 10jenkins-bot: Updated RuboCop to the latest released version [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/234533 (owner: 10Zfilipin) [17:12:03] (03CR) 10Dduvall: [C: 032] Fixed Style/StringLiterals RuboCop offense [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/234534 (https://phabricator.wikimedia.org/T110672) (owner: 10Zfilipin) [17:17:52] (03Merged) 10jenkins-bot: Fixed Style/StringLiterals RuboCop offense [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/234534 (https://phabricator.wikimedia.org/T110672) (owner: 10Zfilipin) [17:32:03] 6Collaboration-Team-Backlog, 10Thanks, 5Patch-For-Review: Notifications: Getting multiple "Thank"s from one user for the same edit is possible (double/duplicate) - https://phabricator.wikimedia.org/T53303#1663524 (10Legoktm) 5Resolved>3Open This happened again :( https://en.wikipedia.org/w/index.php?tit... [17:35:25] 6Collaboration-Team-Backlog, 10Flow: Switching Flow's editor-mode from VE to wikitext whilst a link inspector is open, makes the edit area fully collapse - https://phabricator.wikimedia.org/T113382#1663544 (10Quiddity) 3NEW [17:36:20] (03PS1) 10Matthias Mullie: Revert "Add debug info to OptInController" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240133 [17:36:40] (03CR) 10Matthias Mullie: [C: 032] "Done testing here, don't need this anymore." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240133 (owner: 10Matthias Mullie) [17:40:08] did RoanKattouw_away get a haircut? [17:45:11] (03Merged) 10jenkins-bot: Revert "Add debug info to OptInController" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240133 (owner: 10Matthias Mullie) [17:50:55] 3Collaboration-Team-Current, 10Flow: Catchable fatal error: Argument 1 passed to Flow\UrlGenerator::boardLink() must be an instance of Title, null given - https://phabricator.wikimedia.org/T113312#1663645 (10Catrope) p:5Triage>3High [17:51:43] legoktm: Yes [17:56:09] :D [18:00:06] RoanKattouw: Boo. [18:01:27] James_F: By the time you see me it'll be slightly longer [18:02:14] RoanKattouw: By the time you next see yourself in a mirror it'll be slightly longer. ;-P [18:03:54] RoanKattouw: do we have a hangout for Lightning talk? [18:05:52] etonkovidova: No, only a youtube link: https://www.youtube.com/watch?v=d9nTt8li3BE [18:06:12] (she's halfway through her talk but youtube lets you watch the video on delay) [18:10:30] RoanKattouw: thx! I can see everything now [18:17:08] (03PS1) 10Legoktm: Use UserGroupsChanged hook instead of deprecated UserRights hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240144 (https://phabricator.wikimedia.org/T113357) [18:20:10] (03CR) 10Catrope: [C: 032] Use UserGroupsChanged hook instead of deprecated UserRights hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240144 (https://phabricator.wikimedia.org/T113357) (owner: 10Legoktm) [18:24:43] (03Merged) 10jenkins-bot: Use UserGroupsChanged hook instead of deprecated UserRights hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240144 (https://phabricator.wikimedia.org/T113357) (owner: 10Legoktm) [18:28:37] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 7Technical-Debt: Remove use of UserRights hook when UserGroupsChanged hook is available - https://phabricator.wikimedia.org/T113357#1663756 (10Legoktm) 5Open>3Resolved a:3Legoktm [18:29:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1663766 (10DannyH) 5Open>3Resolved [18:29:54] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Pre-fill broken - https://phabricator.wikimedia.org/T112037#1663767 (10DannyH) 5Open>3Resolved [18:31:04] 3Collaboration-Team-Current, 10Flow, 10CirrusSearch, 6Discovery, and 4 others: Call to a member function getUser() on a non-object (NULL) - https://phabricator.wikimedia.org/T113106#1663773 (10DannyH) 5Open>3Resolved [18:31:19] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Search for localized {{#useliquidthreads}} as well in find/replace in LQT→Flow conversion - https://phabricator.wikimedia.org/T110723#1663777 (10DannyH) 5Open>3Resolved [18:31:31] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1663779 (10DannyH) 5Open>3Resolved [18:31:32] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Echo icon FOUC (tracking) - https://phabricator.wikimedia.org/T112104#1663781 (10DannyH) [18:31:40] 3Collaboration-Team-Current, 10Flow: Opt-out: the opt-in guided tour displayed again when a user reverts 'Flow on user talk' option - https://phabricator.wikimedia.org/T112938#1663782 (10DannyH) 5Open>3Resolved [18:31:42] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1663783 (10DannyH) [18:32:03] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1663784 (10DannyH) 5Open>3Resolved [18:32:34] 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review, and 2 others: "You have new messages" stuck (until page reload) after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1663786 (10DannyH) 5Open>3Resolved [18:32:53] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: When accessing talk page through echo, the yellow "new message" notification doesn't go away until the next page view - https://phabricator.wikimedia.org/T107655#1663789 (10DannyH) 5Op... [18:46:29] mooeypoo: I think the timing.MediaWiki.echo.overlay stats aren't working properly for lazy-load [18:50:23] 3Collaboration-Team-Current, 10Echo: MediaWiki.echo.overlay stats are wrong after lazy-load - https://phabricator.wikimedia.org/T113387#1663837 (10Legoktm) 3NEW a:3Legoktm [18:52:03] legoktm, hm. [18:52:19] legoktm, I'll take a look, but that's possible. [18:52:23] I have a patch incoming [18:53:27] oh! okay then [18:55:08] (03PS1) 10Legoktm: Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) [18:56:45] (03CR) 10Legoktm: "To test this, run https://phabricator.wikimedia.org/P2077 in your console first, then click on the badge." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [18:56:52] mooeypoo: ^ [18:57:54] (03CR) 10jenkins-bot: [V: 04-1] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [18:58:30] (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [19:01:33] (03CR) 10Mooeypoo: Move timing.MediaWiki.echo.overlay stats into ext.echo.init (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [19:01:55] legoktm, what are we testing, ooui load, or the popup full render *with* notifications in it? [19:02:11] the latter [19:02:12] 'cause if it's the latter, we should move it into the .then() of populateNotifications 2 lines above where you have it [19:02:18] * legoktm does [19:02:46] Yeah, it's async, we should count after the notifications are all fetched from the API and rendered fully [19:04:40] (03PS2) 10Legoktm: Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) [19:04:49] mooeypoo: updated and made the comment better [19:06:38] (03CR) 10jenkins-bot: [V: 04-1] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [19:06:38] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
, not a
which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1663924 (10Jdforrester-WMF) p:5Triage>3Low [19:06:56] ugh [19:06:58] that test is flaky [19:08:28] (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [19:22:44] er [19:22:46] legoktm, did you see my question? my internet is borked [19:22:48] legoktm, do you want to also test how long it takes to load ooui in that ? [19:22:50] so we have a test of click -> ooui load -> api finished + rendering [19:22:52] ? [19:22:54] legoktm, if not, this looks good, I'll +2 [19:23:43] Let's do that in a follow up [19:23:48] * mooeypoo nods [19:24:05] (03CR) 10Mooeypoo: [C: 032] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [19:26:15] (03CR) 10jenkins-bot: [V: 04-1] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [19:30:26] 6Collaboration-Team-Backlog, 10MoodBar, 7I18n: Add GENDER support to MediaWiki:Moodbar-log-hide and friends - https://phabricator.wikimedia.org/T45481#1664047 (10Haritha28) [19:31:11] 6Collaboration-Team-Backlog, 10MoodBar, 7I18n: Add GENDER support to MediaWiki:Moodbar-log-hide and friends - https://phabricator.wikimedia.org/T45481#1664050 (10Haritha28) a:3Haritha28 [20:19:14] (03PS1) 10Haritha28: Add GENDER support for Moodbar [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240175 (https://phabricator.wikimedia.org/T45481) [20:35:05] (03CR) 10Catrope: [C: 032] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [20:37:29] (03CR) 10jenkins-bot: [V: 04-1] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [20:37:36] sigh [20:38:50] (03CR) 10Mooeypoo: [C: 04-1] Add GENDER support for Moodbar (032 comments) [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240175 (https://phabricator.wikimedia.org/T45481) (owner: 10Haritha28) [20:45:28] mooeypoo: Try adding multistr: true to .jshintrc [21:00:07] (03PS1) 10Mooeypoo: Make jshint happy by ignoring problems [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240269 [21:03:25] (03CR) 10jenkins-bot: [V: 04-1] Make jshint happy by ignoring problems [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240269 (owner: 10Mooeypoo) [21:06:21] (03PS2) 10Mooeypoo: Make jshint happy by ignoring problems [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240269 [21:08:00] (03CR) 10Catrope: [C: 032] Make jshint happy by ignoring problems [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240269 (owner: 10Mooeypoo) [21:17:23] (03Merged) 10jenkins-bot: Make jshint happy by ignoring problems [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240269 (owner: 10Mooeypoo) [21:27:43] (03CR) 10Legoktm: [C: 032] "Third time's the charm..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [21:31:49] quiddity: the Pywikibot-Flow code is in the main pywikibot repository, unless you wanted wikibugs? [21:32:07] ack! wikibugs. thanks [21:32:09] will fix [21:32:20] * quiddity grumbles at krrrit-wm [21:41:06] (03Merged) 10jenkins-bot: Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240149 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [21:41:25] FINALLY [21:42:16] RoanKattouw: I don't see any MediaWiki.echo.unseen metrics in graphite... [21:45:51] (03PS1) 10Mooeypoo: Wrap author name with tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240274 (https://phabricator.wikimedia.org/T106741) [21:46:00] 3Collaboration-Team-Current, 10Flow, 7I18n, 7RTL, 7WorkType-NewFunctionality: Bidi-isolate username fields in Flow boards - https://phabricator.wikimedia.org/T106741#1664506 (10DannyH) [21:46:53] legoktm: ? [21:47:11] (03CR) 10Catrope: [C: 032] Wrap author name with tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240274 (https://phabricator.wikimedia.org/T106741) (owner: 10Mooeypoo) [21:47:22] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/238632/ [21:47:36] I'm not seeing those in graphite yet [21:47:44] but we should have data from group0 wikis right? [21:47:55] I don't know, ask ori or Krinkle [21:48:00] * legoktm does [21:48:03] I know nothing about graphite or anything else to do with graphs :S [21:48:58] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Opt-in Flow -- Blacklist of templates to not copy into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1664508 (10DannyH) [21:49:14] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Opt-in Flow -- Blacklist of templates to not copy into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1573675 (10DannyH) p:5High>3Normal [21:56:05] 6Collaboration-Team-Backlog, 10Flow: Convert pt.wikibooks LQT pages to Flow (pending consensus) - https://phabricator.wikimedia.org/T113294#1664546 (10Quiddity) [21:59:00] RoanKattouw: for T111084: it seems that flow_wiki_ref table in enwiki does not have `ref_src_wiki` in both: KEY `flow_wiki_ref_idx_v2` and KEY `flow_wiki_ref_revision_v2` [22:00:02] RoanKattouw: testwiki and cawiki have it in in their v2 indexes - can you take you a look when you have a chance? Why such a difference for enwiki? [22:07:00] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1664591 (10Etonkovidova) > Verify the v2 indexes exist on the tables The v2 indexes exist for f... [22:07:19] stephanebisson, can you point me in the direction of the code in OptinController that copies the templates to the header? [22:07:55] stephanebisson, are we checking if they're templates or "just" copying up to the first heading? [22:09:14] (03Merged) 10jenkins-bot: Wrap author name with tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240274 (https://phabricator.wikimedia.org/T106741) (owner: 10Mooeypoo) [22:12:37] 3Collaboration-Team-Current, 10MediaWiki-extensions-GettingStarted, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): GettingStarted issue with less.php - https://phabricator.wikimedia.org/T113313#1664600 (10Etonkovidova) Checked in betalabs. [22:13:16] etonkovidova: Whoa [22:13:21] etonkovidova: Thanks for warning me literally just in time [22:13:28] I was about to deploy a change that would have made it use that index [22:13:38] RoanKattouw: hmm... other dbs are fine [22:13:45] etonkovidova: Is this in prod or beta? [22:13:53] RoanKattouw: beta, of course [22:14:10] Right, because getting you prod access is still on my todo list :( [22:14:58] It looks fine in prod fortunately [22:15:09] RoanKattouw: great! [22:15:15] mooeypoo: could you be more specific? [22:15:17] I'll try to fix the labs one [22:16:03] mooeypoo: we're not copying any templates in optin, but we are in Special:EnableFlow [22:16:40] etonkovidova: OK I see it, WTF [22:17:30] RoanKattouw: I am pretty sure it's nothing sensational - other dbs testwiki, cawiki are fine [22:17:56] OK beta should be fixed [22:18:02] Yeah, nothing disastrous [22:20:12] stephanebisson, aahh. Okay, that makes sense. I thought we're doing the same thing [22:20:39] mooeypoo: it could make sense, but it was never brought up [22:21:04] stephanebisson, yeah, I am looking into creating a template blacklist that wikis can add templates they don't want Flow to copy to the description [22:21:17] so I thought it happened in both Special:EnableFlow and opt in [22:24:49] mooeypoo: https://gerrit.wikimedia.org/r/#/c/239277/4/modules/ext.echo.init.js,unified why does it remove #pt-talk? [22:25:01] instead of removing the alert class or something [22:25:51] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1664611 (10Etonkovidova) Checked in betalabs. [22:26:40] duh, because that's the situation where you opened your message popup and all popups are read -- including your personal messages on your talk page. [22:26:43] (03PS1) 10Legoktm: Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240281 (https://phabricator.wikimedia.org/T113387) [22:27:02] mooeypoo: yeah...but why is it removing the link entirely? [22:27:17] It's better than hiding it? [22:27:28] Why not? If it's out, it's out...? [22:27:38] that link is normally there though [22:27:46] is it!? i checked... [22:27:54] yeah... [22:28:01] Echo just adds a class to it [22:28:09] wait [22:28:25] hang on [22:28:39] * duh grips tightly [22:28:42] (03CR) 10jenkins-bot: [V: 04-1] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240281 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [22:29:11] duh, .... oy vey. [22:29:27] For some odd reason, I thought the orange bar is its own thing and removed it [22:29:37] instead of removing the class and returning the original message [22:29:37] crap [22:30:05] duh, fixing asap [22:30:15] thanks :) [22:33:26] duh, while I"m fixing it, I think we should also consider re-adding this in case new notifications arrive that are from the talk page [22:33:45] will be easier to do with/if the API gives us actually useful data outside of the rendered dom [22:33:49] but anyways, fixing this now [22:33:58] legoktm, ^^ [22:35:48] yes [22:36:00] too many IRC clients open [22:37:11] (03PS1) 10Mooeypoo: Replace the orange bar with talk-page link, don't remove it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240282 [22:37:13] legoktm, RoanKattouw ^^ [22:38:44] (03CR) 10Legoktm: [C: 032] Replace the orange bar with talk-page link, don't remove it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240282 (owner: 10Mooeypoo) [22:40:09] dannyh, etonkovidova: Opt-in is live on test.wikipedia.org now, enjoy :) [22:40:35] RoanKattouw: thank you very much! :) [22:41:34] (03Merged) 10jenkins-bot: Replace the orange bar with talk-page link, don't remove it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240282 (owner: 10Mooeypoo) [22:42:19] (03PS1) 10Legoktm: Replace the orange bar with talk-page link, don't remove it [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240283 [22:42:35] mooeypoo: I'll put it in swat [22:42:39] Thanks [22:42:42] legoktm, you beat me to it. Thanks! [22:42:51] I told her to wait before it merged before cherry-picking [22:52:38] (03CR) 10jenkins-bot: [V: 04-1] Replace the orange bar with talk-page link, don't remove it [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240283 (owner: 10Legoktm) [23:06:06] RoanKattouw hooray! [23:20:32] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1664719 (10Catrope) The global groups that have this right are Staff and Sysadmin. A number of CLs are members of the Staff group, but not Nick or Ben... [23:20:59] (03CR) 10Alex Monk: [C: 032 V: 032] Move timing.MediaWiki.echo.overlay stats into ext.echo.init [extensions/Echo] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240281 (https://phabricator.wikimedia.org/T113387) (owner: 10Legoktm) [23:21:04] 3Collaboration-Team-Current, 10Flow, 6Community-Advocacy, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1664724 (10Catrope) [23:22:24] 3Collaboration-Team-Current, 10Flow, 6Community-Advocacy, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1651506 (10Catrope) @JAlexander: We need Nick and Benoît to have the `flow-create-board` globally. Staff and Sysadmin have this... [23:39:35] 3Collaboration-Team-Current, 10Flow: Opt-in: Copy templates above the first heading when enabling Flow on an existing wikitext page - https://phabricator.wikimedia.org/T113426#1664749 (10DannyH) 3NEW [23:39:56] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Opt-in Flow -- Blacklist of templates to not copy into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1664759 (10DannyH) [23:41:44] 3Collaboration-Team-Current, 10Flow, 6Community-Advocacy, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1664770 (10Quiddity) >>! In T112979#1664719, @Catrope wrote: > A number of CLs are members of the Staff group, but not Nick or... [23:42:28] 3Collaboration-Team-Current, 10Flow, 6Community-Advocacy, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1664771 (10Catrope) Oh that's right, Patrick and Jan are CA, not CL. [23:43:44] (03CR) 10Catrope: [C: 04-1] "Looks good, minor comments inline" (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson)