[06:00:07] <krrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Won't pass. Just letting Jenkins PHPUnit run because user is not whitelisted." (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[06:02:01] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[06:06:11] <krrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Sorry, my bad. It's actually User::newFromName." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[08:02:46] <d3r1ck>	 matt_flaschen: hi
[08:02:52] <d3r1ck>	 i have a question
[08:03:25] <d3r1ck>	 matt_flaschen: Line 245:                       ->will( $this->returnValue( $extra ) );
[08:03:28] <d3r1ck>	 Add step 2 here before the if.
[08:03:37] <d3r1ck>	 what is the step two?
[08:13:21] <krrrit-wm>	 (03PS21) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) 
[08:13:50] <d3r1ck>	 matt_flaschen: i have made the changes. You an test it and see. i have ran local test and it is fine
[08:56:48] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 5Patch-For-Review, 7user-notice: Provide web notifications when user is sent an email via Special:Emailuser - https://phabricator.wikimedia.org/T56130#1656645 (10matej_suchanek)
[10:30:02] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow summary content should be cleared - https://phabricator.wikimedia.org/T112281#1656717 (10Ciencia_Al_Poder) This also happens on mediawiki.org: [[ https://www.mediawiki.org/wiki/Topic:Sg2gfvr9c0p9bgvb | Topic:Sg2gfvr9c0p9bgvb ]]
[18:29:18] <d3r1ck>	 matt_flaschen, ebernhardson, hi
[18:54:41] <krrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "You missed one of the notes from patch set 20, so it still will not pass." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[18:54:52] <krrrit-wm>	 (03CR) 10Mattflaschen: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[18:57:20] <krrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[18:57:31] <d3r1ck>	 matt_flaschen: is that the only thing left to do?
[18:57:53] <matt_flaschen>	 d3r1ck, yes.  If you ran the local PHPUnit test, you must have run the wrong command.
[18:57:59] <matt_flaschen>	 It should be something like:
[18:58:49] <matt_flaschen>	 php tests/phpunit/phpunit.php extensions/Echo/tests/phpunit/formatters/NotificationFormatterTest.php
[18:59:02] <d3r1ck>	 matt_flaschen: ahhh, ok
[18:59:37] <d3r1ck>	 yes i ran the test and it failed
[18:59:41] <d3r1ck>	 let me fix it now.
[19:01:42] <d3r1ck>	 matt_flaschen: ohhh, i see. It should be $loggedUser = new User::newFromName right?
[19:02:17] <matt_flaschen>	 d3r1ck, yes, sorry, I gave you the wrong method before then corrected it in my review of 20.
[19:03:48] <d3r1ck>	 no problem
[19:08:33] <krrrit-wm>	 (03PS22) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) 
[19:08:36] <d3r1ck>	 matt_flaschen: i have submitted the review
[19:08:44] <d3r1ck>	 you can check it now lets see how it is
[19:08:59] <d3r1ck>	 one this patch is merged, i will be very motivated
[19:09:14] <d3r1ck>	 one -> *once
[19:10:30] <matt_flaschen>	 d3r1ck, you still didn't specify a user name like I mentioned at https://gerrit.wikimedia.org/r/#/c/239301/20/tests/phpunit/formatters/NotificationFormatterTest.php .
[19:12:07] <matt_flaschen>	 I think something else is wrong too.  Looking now.
[19:15:36] <d3r1ck>	 which username should i use
[19:16:19] <matt_flaschen>	 Notification-formatter-test 
[19:16:20] <matt_flaschen>	 I think.
[19:18:05] <d3r1ck>	 matt_flaschen: which can of name should use
[19:18:19] <matt_flaschen>	 What do you mean?
[19:20:21] <d3r1ck>	 19:10 <+matt_flaschen> d3r1ck, you still didn't specify a user name like I mentioned at 
[19:20:36] <matt_flaschen>	 I answered your question.
[19:20:39] <matt_flaschen>	 You should use Notification-formatter-test .
[19:21:20] <matt_flaschen>	 If you're asking something else besides which name to use, please clarify.
[19:21:44] <d3r1ck>	 matt_flaschen: i don't understand
[19:21:53] <d3r1ck>	 so i can use $Notification-formatter-test
[19:22:02] <d3r1ck>	 don't you see the variable name is too long?
[19:22:21] <matt_flaschen>	 No, just the string.
[19:22:22] <matt_flaschen>	 'Notification-formatter-test'
[19:22:31] <d3r1ck>	 $name = $user->getName();
[19:22:36] <matt_flaschen>	 ?
[19:22:42] <d3r1ck>	 that is the link of code you are talking about rigght?
[19:23:06] <d3r1ck>	 or this
[19:23:07] <d3r1ck>	 $loggedUser = User::newFromText();
[19:23:19] <d3r1ck>	 $loggedUser = User::newFromName();
[19:23:35] <matt_flaschen>	 Yes, you need to pass in the username 'Notification-formatter-test'.
[19:23:53] <d3r1ck>	 ok
[19:23:55] <d3r1ck>	 like this
[19:24:08] <d3r1ck>	 $loggedUser = User::newFromName('Notification-formatter-test');
[19:24:17] <d3r1ck>	 is that it?
[19:25:57] <matt_flaschen>	 d3r1ck, that's right, except add single spaces inside the parentheses.  There's one more thing, though.
[19:26:15] <matt_flaschen>	 d3r1ck, you also need to only do the getAgent mock if an agent is passed in.  So in mockEvent, only if $agent is non-null.
[19:26:19] <matt_flaschen>	 I'll put it in Gerrit too.
[19:26:23] <d3r1ck>	 matt_flaschen: wow, i see why you asked me to put in the string.
[19:26:32] <matt_flaschen>	 Yes, it's setup above.
[19:26:36] <d3r1ck>	 yes
[19:28:08] <krrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "This and newFromName with the name from setup is the last thing required to make it pass." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[19:28:26] <matt_flaschen>	 d3r1ck, I tested it locally.  It will pass if those changes are made.
[19:28:48] <d3r1ck>	 matt_flaschen: i don't understand the part what you said about $gent in mockEvent
[19:28:57] <d3r1ck>	 that i should use a condition?
[19:29:00] <d3r1ck>	 like using iff?
[19:29:02] <d3r1ck>	 *if
[19:29:11] <matt_flaschen>	 d3r1ck, yes, do you see how $rev uses the if?
[19:29:53] <d3r1ck>	 yes
[19:29:56] <d3r1ck>	 i see it
[19:30:14] <d3r1ck>	 it is not i am noticing since they both have similar parameter declarationss
[19:30:20] <d3r1ck>	 in the function definition
[19:30:26] <d3r1ck>	 *now
[19:31:42] <matt_flaschen>	 d3r1ck, yeah, it's basically the same thing, just separate.
[19:32:26] <krrrit-wm>	 (03PS23) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) 
[19:32:27] <d3r1ck>	 matt_flaschen: you can check now
[19:32:33] <d3r1ck>	 lets see how it works
[19:33:03] <matt_flaschen>	 It looks like if a method is mocked twice, only the first will take effect, so this avoids breaking testAgentSuppression.
[19:33:34] <d3r1ck>	 matt_flaschen: what do you mean?
[19:33:57] <matt_flaschen>	 d3r1ck, how testAgentSuppression has its own getAgent handling, which we don't want to interfere with.
[19:34:21] <d3r1ck>	 matt_flaschen: so can we change the function name?
[19:34:39] <matt_flaschen>	 No, the if check we added will handle it.
[19:34:50] <d3r1ck>	 ok
[19:34:55] <d3r1ck>	 i understand
[19:35:07] <d3r1ck>	 matt_flaschen: check the patch
[19:35:15] <d3r1ck>	 I really want it to be merged
[19:35:18] <matt_flaschen>	 d3r1ck, you added the space in a different place (it actually should be there too!), but not to your new code.
[19:35:23] <matt_flaschen>	 d3r1ck, promise it will be today.
[19:35:38] <matt_flaschen>	 Next to the parentheses, I mean.
[19:35:57] <d3r1ck>	 :D
[19:36:09] <d3r1ck>	 wow, is that a syntax error or what?
[19:36:19] <d3r1ck>	 so MediaWiki don't joke with spaces?
[19:36:26] <d3r1ck>	 matt_flaschen: this is really cool
[19:36:32] <matt_flaschen>	 d3r1ck, no, coding convention: https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Spaces
[19:36:46] <matt_flaschen>	 Coding conventions are not super-cool, but it makes the code consistent and hopefully easier to read.
[19:36:55] <krrrit-wm>	 (03PS24) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) 
[19:37:08] <d3r1ck>	 matt_flaschen: i see and truely thats nice
[19:37:17] <d3r1ck>	 matt_flaschen: i have fixed it now. Check it out.
[19:37:47] <matt_flaschen>	 d3r1ck, oh, that's not the one I meant, but that's actually right too.
[19:37:51] <matt_flaschen>	 One sec
[19:38:39] <d3r1ck>	 matt_flaschen: i ran test
[19:38:41] <d3r1ck>	 all is fine
[19:38:44] <d3r1ck>	 PHPUnit already present
[19:38:45] <d3r1ck>	 PHPUnit 3.7.37 by Sebastian Bergmann.
[19:38:45] <d3r1ck>	 Configuration read from /var/www/html/OpenSource/MediaWiki/tests/phpunit/suite.xml
[19:38:48] <d3r1ck>	 ................................................................. 65 / 65 (100%)
[19:38:51] <d3r1ck>	 Time: 3.08 seconds, Memory: 22.50Mb
[19:38:53] <d3r1ck>	 OK (65 tests, 162 assertions)
[19:38:53] <krrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] IP addresses should link to Special:Contributions instead of userpage e.g. revert change (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[19:39:15] <matt_flaschen>	 Yep
[19:39:59] <d3r1ck>	 matt_flaschen: the comment you made
[19:40:12] <d3r1ck>	  $tests = array();
[19:40:21] <matt_flaschen>	 d3r1ck, no, it's about newFromName.
[19:40:31] <d3r1ck>	 ok
[19:40:46] <matt_flaschen>	 d3r1ck, if you check https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Spaces it says, "except where the parentheses are empty"
[19:41:25] <matt_flaschen>	 Sometimes Gerrit is ambiguous about which line was reviewed.
[19:42:05] <d3r1ck>	 ok
[19:42:06] <d3r1ck>	 done
[19:42:12] <d3r1ck>	 damn i really forgot that one
[19:42:18] <d3r1ck>	 i thought i fixed it.
[19:42:30] <matt_flaschen>	 d3r1ck, you fixed the one that was already broken before your change. :)
[19:44:49] <krrrit-wm>	 (03PS25) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) 
[19:45:01] <d3r1ck>	 matt_flaschen: check it out now lets see
[19:45:11] <d3r1ck>	 hope there is not mistake left again?
[19:46:44] <matanya>	 matt_flaschen: hi, my flow user page never finishes to load
[19:46:52] <matanya>	 https://he.wikipedia.org/w/index.php?title=%D7%A9%D7%99%D7%97%D7%AA_%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Matanya&topiclist_sortby=newest&fromnotif=1#flow-post-soe8gmp6l804t7w9
[19:46:59] <matanya>	 example link ^
[19:56:58] <krrrit-wm>	 (03PS26) 10Mattflaschen: IP addresses should link to Special:Contributions instead of user page for revert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[19:57:52] <matt_flaschen>	 26 is just a couple unrelated space changes I noticed, and the commit message again.
[19:59:14] <krrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] "Congratulations again! This time it will actually merge." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[20:00:27] <d3r1ck>	 matt_flaschen: we did it 
[20:00:50] <d3r1ck>	 :)
[20:01:39] <krrrit-wm>	 (03Merged) 10jenkins-bot: IP addresses should link to Special:Contributions instead of user page for revert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01)
[20:02:08] <matt_flaschen>	 :)
[20:02:53] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 7Easy, 5Patch-For-Review: IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification - https://phabricator.wikimedia.org/T55564#1657106 (10Mattflaschen)
[20:07:25] <d3r1ck>	 matt_flaschen: this is really fun
[20:07:35] <d3r1ck>	 matt_flaschen: i need to move to the next bug to fix
[21:03:01] <d3r1ck>	 matt_flaschen: what does this mean?
[21:03:03] <d3r1ck>	 ReleaseTaggerBot added a project
[21:07:50] <d3r1ck>	 matt_flaschen: i read it. Don't worry to tell me any more