[00:05:05] (03CR) 10Mooeypoo: Remove talk page notification bar if all messages are read (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239277 (https://phabricator.wikimedia.org/T106033) (owner: 10Mooeypoo) [00:05:31] seriously? https://gerrit.wikimedia.org/r/#/c/239303/ [00:10:41] (03PS2) 10Mooeypoo: Add a missing dot in the new api error message in English. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239303 [00:10:51] I can't believe I just rebased a dot. [00:11:06] Can someone re+2 ? [00:11:50] (03CR) 10Jforrester: [C: 032] Add a missing dot in the new api error message in English. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239303 (owner: 10Mooeypoo) [00:12:09] mooeypoo: Trade for https://gerrit.wikimedia.org/r/#/c/232423/ :-) [00:13:49] (03CR) 10Mooeypoo: [C: 032] build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232423 (owner: 10Jforrester) [00:15:38] (03Merged) 10jenkins-bot: Add a missing dot in the new api error message in English. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239303 (owner: 10Mooeypoo) [00:16:33] (03Merged) 10jenkins-bot: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232423 (owner: 10Jforrester) [00:19:11] matt_flaschen: how can i check if a user is a real user? [00:19:16] or anonymous [00:19:43] d3r1ck, if $user is a User object: [00:20:09] $user->isLoggedIn() [00:21:31] (03PS4) 10Mooeypoo: Correct unseen animation in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) [00:27:17] matt_flaschen: where can i do the check? [00:27:26] i am seeing if's every where [00:27:46] and also how to i assign a string to a variable in the code [00:27:58] i am seeing the use of getMessage() [00:29:09] (03PS3) 10Jforrester: Get rid of $wgFlowMigrateReferenceWiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232465 (https://phabricator.wikimedia.org/T108104) (owner: 10Matthias Mullie) [00:29:22] (03PS2) 10Jforrester: Update for I51f7966add: load oojs-ui.styles.icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238318 (owner: 10Catrope) [00:29:41] (03PS5) 10Jforrester: Show real output instead of placeholder HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) (owner: 10Matthias Mullie) [00:29:50] (03PS3) 10Jforrester: Preload new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238312 (https://phabricator.wikimedia.org/T112037) (owner: 10Sbisson) [00:30:28] d3r1ck, sorry, don't have more time to work on that, at least not now. [00:33:39] (03CR) 10jenkins-bot: [V: 04-1] Update for I51f7966add: load oojs-ui.styles.icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238318 (owner: 10Catrope) [00:33:40] ok [00:41:03] (03PS2) 10Sbisson: Instantiate the Optin controller only when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238740 [00:41:33] 6Collaboration-Team-Backlog, 10Flow: Flow: Make Preview and Wikitext Edit available simultaneously - https://phabricator.wikimedia.org/T69258#727848 (10He7d3r) See also mw:Topic:Sn3mt38amyu5b5xj. [00:43:43] (03CR) 10Jforrester: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238318 (owner: 10Catrope) [00:44:11] (03PS3) 10Jforrester: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [00:44:46] (03CR) 10Mattflaschen: [C: 032] Instantiate the Optin controller only when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238740 (owner: 10Sbisson) [00:47:58] (03Merged) 10jenkins-bot: Instantiate the Optin controller only when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238740 (owner: 10Sbisson) [00:55:16] (03PS5) 10Sbisson: Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) [00:57:08] (03CR) 10Sbisson: Use localized version of LQT magic word (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [00:59:31] (03PS16) 10Jforrester: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [01:01:43] (03PS17) 10Jforrester: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [01:01:46] (03CR) 10Jforrester: "PS16: Manual rebase." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [01:02:07] (03PS4) 10Jforrester: Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [01:05:15] matt_flaschen, RoanKattouw_away: You've hopefully already noticed, but VE now has explicit entry/exit of links ('cartouches') and it seems to work in Flow too. [01:05:54] James_F, I have not (been working on backend stuff), but thank you for testing Flow for regressions. [01:06:11] matt_flaschen: Always. Thank you for making cool stuff that it's a pleasure to test. :-) [01:23:33] I thought I had tested the obvious fix, but I hadn't because I renamed the file and modified the wrong one... [01:23:40] Obvious fix works, though. :) [01:36:46] Anyone from collaboration want to comment on https://phabricator.wikimedia.org/T106264 ? [01:37:52] (If not, that's okay, I'll probably just do it. Please speak up if you're planning to make this obsolete though) [01:47:31] Krenair, I don't know of any plans to change Wikilove's status. [01:47:38] It should be okay to enable it on outreach I think. [01:48:02] matt_flaschen: what is the meaning of $1?|$1 [01:48:31] in json. Is it referencing and array? i am sure but now are the $ handled? [01:50:32] matt_flaschen: i guess that is JSON [02:03:22] (03CR) 10EBernhardson: "i'll copy it here in case you don't have the info on hand. lightly edited from irc to be a little more clear." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [02:04:22] d3r1ck: they are argument numbers [02:04:36] d3r1ck: $1 - argument 1. $2 - argument 2 [02:05:00] its a bit cryptic, most everything else uses named arguments. but this is what we have :) [02:06:21] ebernhardson: i really need help to fix this bug [02:06:27] i know you have given me help [02:06:30] and i have understood [02:06:37] d3r1ck: which step are you at? [02:06:40] my problem now is to implement it. [02:07:01] the messages from me above were the exact steps i would personally take to address the bug, in order [02:07:20] ok ebernhardson, walk me one at a time [02:07:35] first, what should i do with the en.json [02:07:36] ? [02:07:52] you said i should add another variable? [02:07:58] so we have the i18n message, it looks like "Your {{PLURAL:$4|edit on [[:$2]] has|edits on [[:$2]] have}} been {{GENDER:$1|reverted}} by [[User:$1|$1]]. $3 [02:08:12] yes [02:08:23] We need to make the User:$1 value more dynamic, so we change that to [[$5|$1]] and add a new argument [02:08:31] so first, change to $5 and save file [02:08:40] open up Echo.php [02:08:53] done [02:09:20] a few hundred lines down there is an array called $wgEchoNotifications defined [02:09:27] this is the configuration for all of the default notifications [02:09:38] i see it [02:09:39] we want to find the configuration of the 'reverted' notification [02:09:39] i am there [02:09:43] yes [02:09:44] i am there [02:10:06] we see it has 'title-message' => 'notification-reverted2' [02:10:13] that was the message we changed, so this is the thing that has to change [02:10:24] just below it is title-params => array( 'agent', 'title', 'difflink' 'number' ) [02:10:34] these are the params, the $1, $2, $3, $4 in the message [02:10:57] we invent a new name to mean 'return User:Name or Special:Contributions/name' [02:11:03] i dunno, any ideas? [02:11:55] ebernhardson: i am with you [02:11:59] continue [02:12:06] d3r1ck: any ideas what we should name our new argument? [02:12:22] page-locator [02:12:34] its not a page though, its specifically either the User page, or the contributions [02:12:38] not just a page i mean [02:12:42] needs to be more specific [02:12:53] i'm not sure a good way to capture that concept in a word. hmm [02:13:27] ebernhardson: what about locator [02:13:31] "locator" [02:13:40] ? [02:14:13] even locator isn't specific. if i just see [[$5|$1]] and i see in this document that $1 is agent and $5 is locator, i don't think thats clear enough [02:14:53] what do you suggest? [02:15:22] what about: 'track-revert' [02:15:33] ? [02:15:46] "There are only two hard things in Computer Science: cache invalidation and naming things." [02:16:24] maybe user-page? although thats dubious because it doesn't capture the Special:Contributions half [02:16:27] :) [02:16:57] ebernhardson: what about "contributions" [02:16:59] ? [02:17:34] or "userpage-contributions" [02:17:56] userpage-or-contributions-or-a-rabbit [02:18:05] i dunno [02:18:16] call it userpage-contributions for now, can't hurt [02:18:22] ok [02:18:33] so add that as the last string in the title-params array [02:18:58] done [02:19:26] just above that in the 'reverted' configuration it has 'formatter-class' => 'EchoEditFormatter'. It means that is the class that takes those strings and turns them into the actual values to pass into the message [02:19:37] so we open up that class to the processParam() method [02:19:51] done [02:20:14] this is mostly just an if/elseif/elseif/ thing. add another condition with $param === 'userpage-contributions' [02:21:05] this class doesn't have much in it, doesn't give many hints about how to do what we need to do. so in another window i open up the parent class to this. just to see how things are supposed to work. [02:21:33] ok [02:21:35] done [02:21:46] what should be in the condition [02:21:47] ? [02:22:02] are we supposed to use the $user object to know if the user is logged in? [02:22:02] actually i lied :P no need to look through the parant. just some complicated messes. everything we need is in the arguments passed to processParam() [02:22:25] d3r1ck: we need to double check who $user is, the documentation on this function doesn't say [02:22:38] ok [02:22:39] $user could be the person we are rendering for, or the person that triggered the event [02:22:51] ok [02:22:57] so how do we do that now? [02:23:17] well, we have to look through the parent class actually :) EchoBasicFormatter [02:24:02] d3r1ck: flooding this channel is no problem, and then when i'm wrong someone else can chime in :) [02:24:23] ok [02:24:36] ebernhardson: so they are all open [02:24:40] what next? [02:24:51] so in EchoBasicFormatter processParam() by searching arround we see processParam() is only called in one place [02:24:59] since it was a protected method, we know that's the only caller [02:25:10] unfortunatly, this method (processParams) also has useless documentation :) [02:25:21] but we can look around for something that calls this method [02:25:39] ok [02:25:56] it looks like processParams() is called by formatFragment() and this one finally docuemnts $user: * @param $user User to format the notification for. [02:26:11] yes [02:26:13] it does [02:26:15] part of being good citizens, add that documentation to the two functions we had to jump to to get here [02:26:29] just copy the line and replace the line that just says $param $user USer with no docs [02:27:21] so now we know that is the user we are formatting for, thats the wrong user. We want the user that the event was created because of [02:27:47] sure [02:27:47] the first argument here is EchoEvent, close EchoBasicFormatter and open that one up [02:27:57] (in EchoEditFormatter::processParam) [02:28:24] wait before that, you said i should do something with two methods [02:28:31] put documentation to them? [02:29:06] yea just copy the documentation that we had to dig to find to the two methods we jumped through. its just a nice thing to do and is how code eventually gets documented [02:29:33] basically the line we are copying is: * @param $user User to format the notification for. [02:29:51] find the processParams function in EchoBasicFormatter, [02:30:03] that one only has: * @param $user User [02:30:11] so replace that with the one that also says what user is [02:31:18] find it? [02:31:59] done for processParam() [02:32:04] which other one? [02:32:49] done too for processParam() in EchoEditFormatter. [02:32:54] We can move ahead [02:32:54] processParam that it calls [02:33:00] yes [02:33:01] it is done [02:34:07] ok so, look at the functions available from EchoEvent.php. getAgent() looks promising [02:35:34] ebernhardson: where is EchoEvent.php? [02:35:57] d3r1ck: what os are you on? do you have grep available? or some sort of mass-search? [02:36:16] i have grep [02:36:24] i am using Ubuntu [02:36:28] grep -r EchoEvent | less [02:36:36] err, grpe -r EchoEvent . | less [02:36:43] baically, this is the programmers most powerful tool :) [02:36:59] ok [02:37:42] `grep -r EchoEvent . | less` this will find you all things that contain this word. when you want to know where something is you grep for it.uy [02:37:55] ebernhardson: output is much [02:38:06] but i can see includes/model/Event.php [02:38:10] is that the file? [02:38:13] yup thats the one [02:38:34] you can also come up with more unique strings for grep, the string 'class EchoEvent' is more unique, if we grep for that we probably get only 1 result the thing we are looking for [02:38:48] kinda like googling, you will learn over time by useing it alot what to grep for [02:39:09] ok [02:39:12] it is open [02:39:13] so, we are just looking in here to see what is available to use from EchoEditFormatter::processParam() [02:39:28] basically just looking at the function names, and reading the docs above them [02:39:54] annoyingly getAgent() doesn't say what it is, but i happen to know that is the user to triggered the event to be created. [02:40:37] so, now we have a User object, all that is left is to write the couple lines of code [02:40:45] (in EchoEditFormatter::processParam) [02:41:07] sure [02:41:11] * @return User|null [02:41:11] */ [02:41:11] public function getAgent() { [02:41:11] return $this->agent; [02:41:19] } [02:41:21] will work [02:41:48] well i am in the Formatter now. [02:42:04] yes, and you have an EchoEvent passed in as the first argument of the method. $event [02:42:26] yes [02:43:06] That will return a User object. the two relevant methods are isAnon() which returns a boolean true/false. and getName() which returns the name (ip in the case of anons) [02:43:32] its just a little logic to string those methods into returning either 'User:$name' or 'Special:Contributions/$name' [02:44:30] so in the condition we created, are we to define two functions? [02:44:40] inside? i doubt [02:44:44] nah, just an if/else [02:45:08] so is isAnon() a function? [02:45:16] also getName? [02:45:22] getName()? [02:45:31] yes, on the User object that is returned by getAgent() [02:45:32] standard in Wiki [02:45:39] ok [02:45:41] so $event->getAgent(), that returns a User object [02:45:49] understood [02:45:57] let me write something and send to you [02:48:35] so where is $name comming from? [02:49:04] is it our $1 param, ebernhardson [02:49:25] no, its from getName() [02:49:36] ok [02:50:01] so which one do i know i am returnin? [02:50:17] isAnon [02:50:19] based on what? the bolean values from isAnon? [02:50:22] ohhh i see [02:51:45] ebernhardson: check this out [02:51:49] it is not complete [02:51:54] elseif ( $param === 'userpage-contributions' ) { [02:51:54] $user = $event->getAgent(); [02:51:54] if( $user->isAnon() ){ [02:51:54] $name = $user->getName() [02:51:54] } [02:51:56] else { [02:51:59] [02:52:01] } [02:52:04] } [02:52:21] will you need the name in both conditions? [02:52:42] i need the IP in one and Name in the other [02:52:49] but i have only one function to do that [02:53:16] so how should we tackle that? [02:54:03] d3r1ck: the ip is the name of anon's [02:54:20] d3r1ck: everywhere in wikipedia where a name should be, anons have an ip address. that's because that *is* their name [02:54:24] so we shall need the name in both conditions [02:54:49] i have added the name in the else [02:55:04] $name = $user->getName(); [02:55:12] so what next? is it ok like that? [02:56:04] basically we just need to return the right strings [02:56:12] in the anon case, return the contributions link [02:56:29] in the logged-in case, return the user link [02:56:37] (and by link, i just mean the text that goes in the wikilink) [02:56:47] ok [02:57:02] like return 'User:$name" [02:57:23] and 'Special:Contribution/$name' [02:57:24] ? [02:57:26] like that? [02:57:55] sorta. in php single quotes return the literal string. double quotes perform variable substitution [02:58:06] ok [02:58:46] ebernhardson: done [02:59:56] test it out [03:00:04] $5 is showing [03:00:47] ebernhardson: i get this as the link [03:00:49] http://localhost/OpenSource/MediaWiki/index.php?title=$5&action=edit&redlink=1 [03:01:18] can you use `git commit --amend` and push the updated patch to gerrit? [03:01:29] yes [03:10:34] d3r1ck, you probably still need to add 'userpage-contributions' in Echo.php. [03:10:50] As the fifth in the list. [03:22:19] (03Abandoned) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:22:42] matt_flaschen: i added it [03:22:57] ebernhardson: let me do the patch and submit [03:23:26] (03Restored) 10Mattflaschen: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:23:41] d3r1ck, don't abandon your patch. Just amend it. [03:24:10] matt_flaschen: i was not on the review branch [03:24:24] like review/d3r1ck01/d3r1ck01 [03:24:33] Do: [03:24:35] git stash [03:24:39] on whatever branch you're on. [03:24:44] Then check out the review branch and do: [03:24:45] git stash pop [03:27:42] ok [03:33:43] (03PS7) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [03:34:31] matt_flaschen, ebernhardson, i sent the patch [03:34:36] you can review it [03:35:11] but it is not working for me yet [03:35:36] it is still showing $5 after putting the fifth key in the array [03:37:05] (03CR) 10Mattflaschen: [C: 04-1] "Almost there." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:38:01] (03CR) 10EBernhardson: [C: 04-1] IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:38:36] hmm, my comment didnt post... [03:39:17] (03CR) 10EBernhardson: IP addresses should link to Special:Contributions instead of userpage e.g. revert change (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:39:54] (03CR) 10D3r1ck01: "But it is above the if/else in the elseif condition right. Check it out" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:40:15] matt_flaschen: it is above the if/else in the elseif condition [03:40:20] is it not correct? [03:42:03] ebernhardson: let me send the updated copy [03:42:44] (03PS8) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [03:44:53] (03CR) 10D3r1ck01: "It is not still working for me yet. What could be missing?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [03:48:46] ebernhardson: so what is the problem now? [03:56:02] ebernhardson: can we just wrap up with this one now? [03:56:06] so i can sleep :) [03:56:11] i am damn tired [03:58:34] Well, i want to rest. If you come anytime, just hint me on what to do and i will do it. [03:58:43] ebernhardson: i will be waiting... [04:23:41] (03CR) 10Mattflaschen: [C: 04-1] IP addresses should link to Special:Contributions instead of userpage e.g. revert change (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [04:24:26] (03CR) 10Mattflaschen: "You also need to update the qqq.json (look for the same key you changed in en.json, notification-reverted2 in this case) to note the new p" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [05:06:39] (03PS2) 10Mattflaschen: Fix exception on history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) [05:08:00] (03CR) 10Mattflaschen: "This is ready for review. It should fully fix T111494. It doesn't fix T112230 (though there are some feelers in that direction), but it " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [06:00:40] 6Collaboration-Team-Backlog, 10MediaWiki-Page-editing, 7IPv6: Have one aggregated talk page for ipv6 /64 - https://phabricator.wikimedia.org/T112325#1652437 (10Legoktm) Would we also want to do this for pages like Special:Contributions too? just show everything in the /64? [06:06:48] 6Collaboration-Team-Backlog, 10MediaWiki-Page-editing, 7IPv6: Have one aggregated talk page for ipv6 /64 - https://phabricator.wikimedia.org/T112325#1652439 (10Mbch331) >>! In T112325#1652437, @Legoktm wrote: > Would we also want to do this for pages like Special:Contributions too? just show everything in th... [06:52:56] 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 4 others: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views - https://phabricator.wikimedia.org/T112401#1652507 (10ori) a:5ori>3Legoktm Nice work. Thanks for tackl... [06:53:04] 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 4 others: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views - https://phabricator.wikimedia.org/T112401#1652509 (10ori) 5Open>3Resolved [07:11:13] (03CR) 10Matthias Mullie: [C: 032] Show real output instead of placeholder HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) (owner: 10Matthias Mullie) [07:15:14] (03Merged) 10jenkins-bot: Show real output instead of placeholder HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) (owner: 10Matthias Mullie) [08:00:37] (03CR) 10Matthias Mullie: [C: 032] Preload new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238312 (https://phabricator.wikimedia.org/T112037) (owner: 10Sbisson) [08:03:49] (03Merged) 10jenkins-bot: Preload new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238312 (https://phabricator.wikimedia.org/T112037) (owner: 10Sbisson) [08:37:46] (03CR) 10Matthias Mullie: [C: 032] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [08:47:02] (03Merged) 10jenkins-bot: Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [08:47:13] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1652629 (10Pginer-WMF) A placeholder message encouraging participation would be a good option: {F2615261} Idea... [09:57:01] (03CR) 10Matthias Mullie: "I want to do some more testing, but this looks like a big improvement!" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [10:05:07] (03PS9) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [10:05:27] holy crap the bug has been fixed [10:07:18] (03CR) 10D3r1ck01: "The patch set 9 fixes the bug. It works very well for my local MediaWiki version." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [10:16:30] matt_flaschen, ebernhardson you guys can review now. [10:16:38] the bug has been fixed [11:02:39] (03PS5) 10Catrope: Correct unseen animation in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) (owner: 10Mooeypoo) [11:02:54] (03CR) 10Catrope: [C: 032] "Love the branch name" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) (owner: 10Mooeypoo) [11:05:32] (03CR) 10Catrope: Remove talk page notification bar if all messages are read (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239277 (https://phabricator.wikimedia.org/T106033) (owner: 10Mooeypoo) [11:10:12] (03Merged) 10jenkins-bot: Correct unseen animation in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) (owner: 10Mooeypoo) [13:01:23] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 5Patch-For-Review: IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification - https://phabricator.wikimedia.org/T55564#1652999 (10D3r1ck01) From the last patch set i have submitted, it fixes the Bug. Thanks to Mattflasche... [13:02:40] (03CR) 10D3r1ck01: [C: 031] IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [13:16:55] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 5Patch-For-Review: IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification - https://phabricator.wikimedia.org/T55564#577809 (10matej_suchanek) [13:28:54] 6Collaboration-Team-Backlog, 10Flow: there is an overflow on narrow screens when adding a template - https://phabricator.wikimedia.org/T113041#1653117 (10Trizek-WMF) 3NEW [13:32:13] (03PS1) 10Sbisson: Browser tests: remove redundant assertion [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239370 [13:42:27] (03PS3) 10Sbisson: Fix exception on history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237872 (https://phabricator.wikimedia.org/T111494) (owner: 10Mattflaschen) [13:53:23] RoanKattouw: do you have a moment? [13:53:42] Sure [13:53:56] I only have 24 minutes of battery though [13:54:13] still troubleshooting the parsoid error [13:54:41] we're receiving a 500 when trying to convert '{{{asdf}}}' html->wikitext [13:54:57] '500' is the only info in our log [13:54:58] But only from RESTbase, not from Parsoid? Or something like that [13:55:04] yes [13:55:21] I can do that conversion successfully from the restbase testing page [13:55:25] on beta [13:55:51] I now have access to deployment-bastion but cannot find any restbase or parsoid log [13:57:04] not sure where to look next [13:57:16] I heard something yesterday about RB logging having magically stopped on Monday [13:57:20] That could be related [13:57:41] maybe our code DOS it ;) [13:59:40] Hmm wait but it only happens when running {{{foo}}} through html2wt? [13:59:49] Wouldn't you just expect that to return {{{foo}}} ? [14:01:59] if we do wt2html first and then back [14:02:04] we end up sending:

{{{asdf}}}

[14:04:10] wat [14:04:22] Wait that's HTML [14:04:30] So did you mean if we do html2wt and then wt2html? [14:05:00] ah AH [14:05:13] I can reproduce it with https://restbase-beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/v1/?doc#!/Transforms/transform_html_to_wikitext__title___revision__post [14:06:30] Nice [14:06:39] so I type {{{asdf}}} in wt editor, switch to VE, it stays visually the same, then switch back to wt and it breaks [14:07:22] is it a bug that can be filed or am I doing something wrong here? [14:08:07] That sounds like a bug [14:08:54] It works using only Parsoid on the command line [14:09:00] And it works on your laptop, rihgt? [14:09:29] in mw-vagrant going straight to parsoid it works [14:14:12] OK [14:14:17] Yeah that's worth reporting as a RESTbase bug [14:14:58] doing it now [14:15:14] I have 2% battery left so I'll probably drop off soon [14:16:48] alright [14:16:52] thanks! [14:29:28] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1653267 (10SBisson) This problem can be reproduce on the restbase API doc page: https://restbase-beta.w... [14:36:55] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1653284 (10SBisson) a:3SBisson [15:43:59] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1653492 (10SBisson) I think this is the last place where the old editor system is being used. I still haven't figured out exactly how/when it got broken. @qui... [16:11:33] (03PS7) 10Catrope: [WIP] Replace entire

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [16:11:58] mooey|away: That ---^^ fixes the worst of it, but it's still not aligned quite right. I'll try making it subclass PopupButtonWidget again [16:25:43] (03PS8) 10Catrope: [WIP] Replace entire

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [17:02:12] RoanKattouw_away, what what? it fixes it perfectly for me [17:02:32] RoanKattouw_away, and making it a subclass of PopupButtonWidget will again wrap it in a

:\ [17:03:40] RoanKattouw_away, besides, popup button widget is just a widget with a button and a popup -- which is what I"m basically doing in the new widget, except the "top" widget is now an

instead of a

... so if you go with Popup Button Widget and get the button outside, it will be mostly the same....? [17:30:10] mooeypoo: Yeah, never mind, I realized those things since I said that [17:34:45] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/f... - https://phabricator.wikimedia.org/T111771#1653906 [17:36:25] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1653929 (10Quiddity) #1 sounds sensible to me - reverting a diff needs to be checked and sometimes verified or partially replaced, in which case wikitext might... [17:48:33] 3Collaboration-Team-Current, 10Flow: Opt-out: the opt-in guided tour displayed again when a user reverts 'Flow on user talk' option - https://phabricator.wikimedia.org/T112938#1654022 (10Catrope) a:3Mooeypoo [17:48:37] 3Collaboration-Team-Current, 10Flow: Opt-out: the opt-in guided tour displayed again when a user reverts 'Flow on user talk' option - https://phabricator.wikimedia.org/T112938#1650560 (10Catrope) https://gerrit.wikimedia.org/r/#/c/239180/ [17:58:40] 6Collaboration-Team-Backlog, 10Echo: Display a 'no notifications' empty option if there are no notifications in the Echo popup - https://phabricator.wikimedia.org/T113070#1654048 (10Mooeypoo) 3NEW [17:59:29] (03PS1) 10Ori.livneh: Use a different CSS hack to exclude IE6 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 [18:00:04] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1630049 (10Mooeypoo) Those are awesome! I split this into a new task specifically for picking and designing th... [18:00:50] (03CR) 10Krinkle: [C: 032] Use a different CSS hack to exclude IE6 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 (owner: 10Ori.livneh) [18:00:56] (03CR) 10Catrope: [C: 032] Use a different CSS hack to exclude IE6 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 (owner: 10Ori.livneh) [18:01:07] (03CR) 10Catrope: "Hmm, I think this CSS might be unused now..." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 (owner: 10Ori.livneh) [18:02:57] (03CR) 10jenkins-bot: [V: 04-1] Use a different CSS hack to exclude IE6 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 (owner: 10Ori.livneh) [18:21:20] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1654147 (10Catrope) #1 sounds good to me [18:27:26] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1654184 (10DannyH) Yes, I agree. Loading the wikitext editor makes sense; the people who will be looking at this page will be fine with wikitext. [18:33:49] RoanKattouw, I just checked the popup alignment, it's great. I can take off the WIP in that case, yes? [18:33:56] or do you think something else is missing? [18:35:21] (03PS9) 10Mooeypoo: Replace entire

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [18:35:37] (03PS2) 10Ori.livneh: Fix LESS syntax error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 [18:36:07] (03CR) 10Ori.livneh: [C: 032] Fix LESS syntax error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 (owner: 10Ori.livneh) [18:36:55] mooeypoo: I'm reviewing and -1ing [18:37:39] (03CR) 10jenkins-bot: [V: 04-1] Replace entire

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [18:37:58] RoanKattouw, ok, updated the commit message to remove the issue and WIP tag [18:38:43] ... oi [18:38:59] RoanKattouw, Less_Exception_Chunk: ParseError: Unexpected input in tooltips.less on line 183, column 2 <-- is this what ori just fixed? [18:39:03] I think so [18:39:18] how did it not fail before... [18:39:35] I think we're using a different LESS parser now or something? [18:40:43] (Ori says yes) [18:41:18] mooeypoo: So all this CSS starting with .mixin-notifications-badge() and setting the width and height and the icon adjustments etc, why was that all removed? I don't see where it went [18:41:39] RoanKattouw, because now the base styles are actually affecting the current button [18:41:47] ha! [18:41:48] Right [18:41:52] So then we don't need the mixin any more either? [18:41:56] Probably not :D [18:42:07] it just has a base style that applies to it [18:42:26] (03CR) 10Catrope: Replace entire

element to produce button and popup separately (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [18:42:31] the button is the same. Except for the background color in unread -- because that's defined by a different class [18:42:38] (03CR) 10Catrope: [C: 04-1] "See PS8" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [18:42:53] RoanKattouw, also, we need to completely rewrite the Echo browser tests [18:43:43] 6Collaboration-Team-Backlog, 10Echo: Rewrite Echo browser tests for the new split notification change - https://phabricator.wikimedia.org/T113081#1654243 (10Mooeypoo) 3NEW [18:44:00] RoanKattouw, ^^ added it to the backlog, but it's probably a good idea to do them soon(ish) [18:44:12] 6Collaboration-Team-Backlog, 10Flow: EnableFlow -- don't copy "welcome" templates into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1654251 (10DannyH) [18:46:35] RoanKattouw, you knwo what I forgot to double-check with the new

fix? [18:46:55] What? [18:46:58] Monobook? [18:47:00] RoanKattouw, .... legoktm. I mean MonoBook. Monobook. I forgot to double check Monobook. [18:47:25] Shouldn't be a big issue there, not many changes, but I'll check now. [18:47:40] :P [18:47:53] legoktm, good thing you're not using Modern [18:47:58] oh god [18:48:02] :v [18:48:06] :D [18:48:19] I've been mainly testing Modern for one user that I know uses it [18:48:33] because he's awesome and likes weird skins for some reason [18:51:15] (03Merged) 10jenkins-bot: Fix LESS syntax error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239428 (owner: 10Ori.livneh) [18:52:45] matt_flaschen: what about my patch [18:52:47] did you review it? [18:52:49] ebernhardson: hi [18:53:43] legoktm, we should create an ingress skin [18:53:53] I'm down [18:54:00] it'll be blue of course [18:54:03] LOL, we can hire marktraceur as consultant. [18:54:11] It'll be the color of your faction, duh [18:54:25] did you see this morning's BAF? [18:54:33] And for unregistered users, it'll be grey [18:54:42] d3r1ck, yes, I'll re-review it now. [18:54:48] What's BAF? [18:55:01] matt_flaschen: you are asking me that? [18:55:04] legoktm, "History" can be "Hack" and "Edit" can be "Deploy resonators". It'll be awesome. [18:55:06] the BAF thing? [18:55:12] what do does it mean? [18:55:23] I wasn't asking you. [18:55:27] matt_flaschen: ok [18:55:46] legoktm, I did not, I actually haven't played in a while [18:57:00] (03CR) 10Mattflaschen: [C: 04-1] "See inline comments, plus you still need to update qqq. See above." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [18:59:28] mooeypoo: https://i.imgur.com/SDP2PgJ.png [19:02:02] matt_flaschen: BAF, Big Ass Field [19:02:21] mooeypoo: You didn't drive three hours to kill a field? WHAT KIND OF AGENT ARE YOU [19:03:03] I guess the anchors weren't even that close to you [19:04:39] matt_flaschen: i did the changes [19:04:45]

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [21:49:49] (03CR) 10jenkins-bot: [V: 04-1] Replace entire

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [21:54:41] once i do that matt_flaschen will my patch be merged? [21:54:45] or verified? [21:57:26] 3Collaboration-Team-Current, 10Flow: [Regression-betalabs] Error on View history of User talk page after second opt-in - https://phabricator.wikimedia.org/T113103#1654974 (10Etonkovidova) 3NEW [21:58:32] (03CR) 10Mattflaschen: "See inline" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [21:59:27] d3r1ck, fix the coding convention thing I just mentioned (might as well since you have to update the patch anyway for qqq), then after that I'll look at the qqq and if it looks good, test, and if it works fix your commit message then merge. [21:59:51] ok [22:00:24] 3Collaboration-Team-Current, 10Flow: [Regression-betalabs] Error on View history of User talk page after second opt-in - https://phabricator.wikimedia.org/T113103#1655002 (10Mattflaschen) [22:00:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1655003 (10Mattflaschen) [22:00:50] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1655007 (10Etonkovidova) Still do not see the link after 2nd opt-in. Also, there is T113103. [22:01:04] (03PS2) 10Mooeypoo: Remove talk page notification bar if all messages are read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239277 (https://phabricator.wikimedia.org/T106033) [22:01:58] d3r1ck, it should be like: [22:02:02] } else { [22:05:45] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1655030 (10Etonkovidova) Checked in betalabs. [22:06:41] (03PS11) 10Mooeypoo: Replace entire

element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [22:07:42] matt_flaschen: i understand [22:07:45] i have done it already [22:07:51] let me send a review [22:08:50] (03PS12) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [22:08:53] matt_flaschen: i have submitted the review. You can check now [22:09:02] matt_flaschen: and tell me what do make changes in. [22:10:19] (03CR) 10D3r1ck01: [C: 031] IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [22:10:36] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1655053 (10Etonkovidova) In betalabs - testwiki: {F2617742} [22:11:13] matt_flaschen: you can check now [22:11:27] ebernhardson: where are you? you have not said anything today in the channel [22:11:37] but you helped me the whole day yesterday. [22:12:00] d3r1ck, you don't need to ping me twice. And I'm already helping you so you don't need to ping Erik. He's not officially working on Echo anymore, and probably has other stuff to work on. [22:13:47] (03CR) 10Mattflaschen: [C: 04-1] "userpage-contributions is not a message key. You need to update the documentation for the message you changed in en.json (as I mentioned " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [22:14:40] d3r1ck, also don't +1 your own changes unless there are special circumstances. [22:20:04] matt_flaschen: ok. I am learning alot [22:20:05] :) [22:21:42] (03PS13) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [22:27:08] (03CR) 10Mattflaschen: [C: 04-1] "I said to update it. It's already documented." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [22:38:44] (03PS14) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [22:42:48] 6Collaboration-Team-Backlog, 10Flow, 10CirrusSearch, 6Discovery, 7Wikimedia-log-errors: Call to a member function getUser() on a non-object (NULL) - https://phabricator.wikimedia.org/T113106#1655120 (10greg) 3NEW [22:43:34] 6Collaboration-Team-Backlog, 10Flow, 10CirrusSearch, 6Discovery, 7Wikimedia-log-errors: Call to a member function getUser() on a non-object (NULL) - https://phabricator.wikimedia.org/T113106#1655129 (10greg) [22:44:17] (03CR) 10Mattflaschen: [C: 04-1] IP addresses should link to Special:Contributions instead of userpage e.g. revert change (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [22:47:15] (03PS15) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [22:47:17] matt_flaschen: done [22:47:27] matt_flaschen: check it out now [22:47:33] so who wants to help me play guess why the flow content model started throwing exceptions in beta labs on getParserOutput()? :) [22:47:41] men this patch need to be ok [22:47:42] https://logstash-beta.wmflabs.org/#/dashboard/temp/AU_ioEtFa1EjumVd_UK5 [22:47:53] looks to have started about 2 hours ago, but i don't see any interesting merges :( [22:48:09] ebernhardson: hey [22:48:12] d3r1ck: hi [22:48:15] fixed the bug [22:48:19] excellent [22:48:29] thanks to you and matt_flaschen [22:48:38] he is reviewing it. [22:48:45] ebernhardson, I can't right now. I did change Flow to return bogus HTML like we discussed, but we ended up having to revert that, and the revert is merged (https://gerrit.wikimedia.org/r/#/c/236016/). Anyway, bogus HTML is not null HTML. [22:49:23] ebernhardson: we are working on qqq.json to document the $5 argument [22:49:28]