[00:00:34] matt_flaschen: so it is thesame user but login and logout on two diff browesers right? [00:00:59] d3r1ck, one of the browsers is logged in as Derick, the other browser is not logged in at all. [00:01:51] then how do i revert edit? i can't even access preferences [00:02:21] d3r1ck, you don't need to access preferences to revert edits. Go to history and click undo on the edit to revert, then save. [00:03:47] matt_flaschen: Yup, we did it [00:03:50] :) [00:03:55] it worked perfectly [00:04:10] Great, so you can reproduce the current revert notification behavior (and see where it links to the user page)? [00:04:15] so the bug now is to link to the page that did the edit? [00:04:37] or revert? [00:05:42] d3r1ck, the link should point to the Special:Contributions/1.2.3.4 page (except the real IP address rather than 1.2.3.4) [00:05:51] d3r1ck, if the user who does the revert is logged in, there should be no change. [00:06:12] See https://phabricator.wikimedia.org/T55564 [00:06:36] matt_flaschen: i am getting the point now [00:07:00] (03PS4) 10Mooeypoo: [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [00:08:48] my vagrant is almost up [00:09:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [00:09:10] but i don't need it for now [00:12:14] matt_flaschen: will continue on the bug tomorrow [00:12:22] i have not slept for days now [00:12:28] i need to rest :) [00:14:31] d3r1ck, have a good night. [02:47:40] Sorry, internet still acting up. [02:48:58] is that another victim of comcast I hear? [02:50:07] Negative24, yeah, is there a known problem in Philadelphia? [02:50:45] I have no idea. I don't live in Philadelphia. I just know from first hand experience :P [03:32:17] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization, 7Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#1647883 (10Volker_E) [03:32:46] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Inactive badge colors not compliant with accessibility guidelines - https://phabricator.wikimedia.org/T112510#1647890 (10Volker_E) [03:32:50] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization, 7Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#1270507 (10Volker_E) [05:05:35] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization: OOUI PopupWidgets don't have drop shadows in the MediaWiki theme - https://phabricator.wikimedia.org/T111889#1647966 (10Volker_E) [[ https://gerrit.wikimedia.org/r/239027 | Change 239027 ]] unifies OOjs UI's box-shadows of PopupWidget (i... [06:42:30] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Internationalization, 7I18n, and 3 others: Fix unsanitized message in PageTriage - https://phabricator.wikimedia.org/T112469#1648109 (10Nemo_bis) 5Open>3Resolved [06:42:53] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 7I18n, 5Patch-For-Review, and 2 others: Fix unsanitized message in PageTriage - https://phabricator.wikimedia.org/T112469#1635391 (10Nemo_bis) [06:43:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (owner: 10Mooeypoo) [07:18:36] (03PS4) 10Siebrand: Remove unused key "notification-link-text-respond-to-user" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [07:18:47] (03PS5) 10Siebrand: Remove unused key "notification-link-text-respond-to-user" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [07:19:09] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [07:19:24] 6Collaboration-Team-Backlog, 10Thanks, 7I18n, 5Patch-For-Review: Add GENDER support to notification-link-text-respond-to-user - https://phabricator.wikimedia.org/T56979#1648177 (10siebrand) 5Open>3Resolved a:3siebrand Message was removed, as it was no longer used. [07:21:06] (03CR) 10jenkins-bot: [V: 04-1] Remove unused key "notification-link-text-respond-to-user" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [07:45:21] (03CR) 10Mattflaschen: [C: 04-1] "Please also remove it from qqq. That will fix the Jenkins failure." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [07:45:58] 6Collaboration-Team-Backlog, 10Thanks, 7I18n, 5Patch-For-Review: Add GENDER support to notification-link-text-respond-to-user - https://phabricator.wikimedia.org/T56979#1648207 (10Mattflaschen) 5Resolved>3Open Did not merge. [07:46:02] 6Collaboration-Team-Backlog, 10Thanks, 7I18n, 5Patch-For-Review: Add GENDER support to notification-link-text-respond-to-user - https://phabricator.wikimedia.org/T56979#1648210 (10Mattflaschen) a:5siebrand>3Haritha28 [08:03:31] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization, 7Accessibility: Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines - https://phabricator.wikimedia.org/T98526#1648229 (10Pginer-WMF) >>! In T98526#1428684, @Legoktm wrote: > Any suggestions on what we should cha... [08:06:28] (03PS6) 10Siebrand: Remove unused key "notification-link-text-respond-to-user" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [08:07:05] (03CR) 10Siebrand: "Then the npm job sucks. Superfluous qqq entries should not be a reason for failing a merge." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [08:07:16] (03CR) 10Siebrand: [C: 032] Remove unused key "notification-link-text-respond-to-user" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [08:09:43] (03Merged) 10jenkins-bot: Remove unused key "notification-link-text-respond-to-user" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [08:10:17] 6Collaboration-Team-Backlog, 10Thanks, 7I18n, 5Patch-For-Review: Add GENDER support to notification-link-text-respond-to-user - https://phabricator.wikimedia.org/T56979#1648257 (10siebrand) 5Open>3Resolved [08:39:53] 3Collaboration-Team-Current, 10Flow: Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1648326 (10matthiasmullie) a:3matthiasmullie [08:50:35] 6Collaboration-Team-Backlog, 10Flow: When you post a message and then go back to the previous page, the message seems to be lost - https://phabricator.wikimedia.org/T112858#1648346 (10Trizek-WMF) 3NEW [09:03:02] 6Collaboration-Team-Backlog, 10Flow: Create a Flow sandbox board on French Wikipedia - https://phabricator.wikimedia.org/T112860#1648394 (10Trizek-WMF) 3NEW a:3DannyH [09:03:13] 6Collaboration-Team-Backlog, 10Flow: Create a Flow sandbox board on French Wikipedia - https://phabricator.wikimedia.org/T112860#1648403 (10Trizek-WMF) [09:23:55] 6Collaboration-Team-Backlog, 10Flow: A link to a file is red colored on edit mode on Flow - https://phabricator.wikimedia.org/T112862#1648455 (10Trizek-WMF) 3NEW [09:43:10] (03PS1) 10Matthias Mullie: Make sure $title object has the correct article id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239057 (https://phabricator.wikimedia.org/T112784) [10:13:43] 6Collaboration-Team-Backlog, 10Flow: Create a newsletter about Flow - https://phabricator.wikimedia.org/T112864#1648523 (10Trizek-WMF) 3NEW a:3Trizek-WMF [10:52:43] (03CR) 10Sbisson: [C: 032] Make sure $title object has the correct article id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239057 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [10:55:45] (03Merged) 10jenkins-bot: Make sure $title object has the correct article id [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239057 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [11:19:51] damn, didn’t fix it :p [11:21:26] it's not deployed to beta yet [11:23:55] aha ok :p [11:55:14] 6Collaboration-Team-Backlog, 10Flow: Edit description link should be grey by default, not blue - https://phabricator.wikimedia.org/T112872#1648704 (10Pginer-WMF) 3NEW [12:49:36] mlitn: not fixed :( [12:49:43] yeah indeed :p [12:51:02] mlitn: hey, I have this line: "wfDebugLog( 'Flow', __METHOD__ . ": $msg" );" [12:51:16] how/where can I see it from enbeta? [12:51:39] I know the method and part of the msg if it can help [12:53:39] I don’t know on beta [12:53:45] let’s see if I can easily find in config [12:54:37] actually, that must be documented somewhere, I’ll try google first :p [12:57:27] https://wikitech.wikimedia.org/wiki/Logs [12:59:06] Various server logs are written to the remote syslog server deployment-fluorine.eqiad.wmflabs in /srv/mw-log. [12:59:30] oh, I don't have access to that [12:59:55] oh, that sucks [13:00:06] do you need me to find & sopy something for now? [13:00:17] I tried logstash-beta.wmflabs.org but I can't find what I'm looking for in there [13:01:22] something like: 'Flow' "parsoid: Failed contacting Parsoid for title" [13:19:56] 6Collaboration-Team-Backlog, 10Flow: When you post a message and then go back to the previous page, the message seems to be lost - https://phabricator.wikimedia.org/T112858#1648892 (10Trizek-WMF) [13:27:46] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1648915 (10He7d3r) 3NEW [13:35:00] sbisson-brb: sorry, got sidetracked & forgot to look :p [13:35:02] 2015-09-17 11:20:18 deployment-mediawiki01 enwiki Flow INFO: Flow\Parsoid\Utils::parsoid: Failed contacting Parsoid for title "Topic:Sozdb7w0b4iljl7c": 500 [13:35:02] 2015-09-17 11:20:18 deployment-mediawiki01 enwiki Flow INFO: Flow\Templating::getContent: Failed to get content for rev_id = sp1swjnguir4b78r [13:35:42] 6Collaboration-Team-Backlog, 10Beta-Cluster, 10Staging, 7Database: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#1648943 (10Reedy) >>! In T95871#1431750, @hashar wrote: > @Mattflaschen External Store is a bit tricky. Gotta need to setup a few instances to hold the SQL datab... [14:01:15] (03PS1) 10Matthias Mullie: Update Title & LinkCache article ids right after move [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239104 (https://phabricator.wikimedia.org/T112784) [14:30:27] (03CR) 10Zfilipin: [C: 04-1] "Except for the `sleep`, looks good to me in general. Voting -1 because of `sleep` and because of merge conflict." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/182400 (owner: 10Spage) [14:39:00] 6Collaboration-Team-Backlog, 10Echo, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-09-08_(1.26wmf22), 7user-notice: Broken Common.css on Commons breaks search suggestions, Echo, others for Safari, old Firefox - https://phabricator.wikimedia.org/T112552#1649170 (10matej_suchanek) [14:44:18] (03CR) 10Sbisson: [C: 04-1] "There's something really weird here. With this change, old talk pages are archived at "Username/Archive_1" instead of "User_talk:Username/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239104 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [14:51:34] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1649213 (10SBisson) It's not that the config is missing. We are receiving a 500 from parsoid when conve... [15:25:38] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1649398 (10Josve05a) 3NEW [15:27:13] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1649416 (10Josve05a) Something related, but a userscript for sv.wp https://sv.wikipedia.org/wiki/Anv%C3%A4nd... [15:56:01] (03PS2) 10Matthias Mullie: Update Title & LinkCache article ids right after move [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239104 (https://phabricator.wikimedia.org/T112784) [16:17:49] (03CR) 10Sbisson: [C: 032] Update Title & LinkCache article ids right after move [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239104 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [16:21:24] (03Merged) 10jenkins-bot: Update Title & LinkCache article ids right after move [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239104 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [16:33:30] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1649761 (10Quiddity) [16:46:02] mlitn: still no :( [16:46:11] indeed, also just tested :p [16:46:59] 6Collaboration-Team-Backlog, 10Echo: Echo popups look odd when empty - https://phabricator.wikimedia.org/T112251#1649830 (10Etonkovidova) From my observations: - no reliable steps to reproduce - it happens more frequently than it could be attributed to >Their account may have existed before Echo was deploy... [16:48:15] 3Collaboration-Team-Current, 10Flow: Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1647282 (10Etonkovidova) [16:48:17] 6Collaboration-Team-Backlog, 10Echo: Echo popups look odd when empty - https://phabricator.wikimedia.org/T112251#1649837 (10Etonkovidova) [16:49:44] 3Collaboration-Team-Current, 10Flow, 10WMF-Server-Backports, 5MW-1.26-release, and 3 others: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1649848 (10DannyH) 5Open>3Resolved [16:49:46] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1649849 (10DannyH) [16:49:52] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1649850 (10DannyH) 5Open>3Resolved [16:49:54] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1575034 (10DannyH) [16:50:29] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: Echo waits to show you messages on second load - https://phabricator.wikimedia.org/T112186#1649857 (10DannyH) 5Open>3Resolved [16:52:28] 6Collaboration-Team-Backlog, 10Echo: Echo popups look odd when empty - https://phabricator.wikimedia.org/T112251#1649872 (10Mooeypoo) Echo popups, in theory should never be empty. There is always at least 1 alert in the alerts popup ("Welcome...") and when the messages popup is empty, it should be invisible.... [16:55:10] (03PS2) 10Mooeypoo: [wip] Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) [16:57:16] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1649884 (10DannyH) p:5Triage>3Normal [16:57:29] 3Collaboration-Team-Current, 10Flow: Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1649888 (10Mooeypoo) [16:57:31] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1649887 (10Mooeypoo) [16:57:52] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1649889 (10DannyH) [17:05:03] 6Collaboration-Team-Backlog, 10Flow: Flow: Make Preview and Wikitext Edit available simultaneously - https://phabricator.wikimedia.org/T69258#1649899 (10DannyH) 5Open>3declined a:3DannyH Since this ticket was filed, we enabled VE in the Flow message fields. The VE field now serves as a preview for wikite... [17:30:13] (03PS3) 10Mooeypoo: Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) [17:33:04] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 7I18n, 5Patch-For-Review, and 2 others: Fix unsanitized message in PageTriage - https://phabricator.wikimedia.org/T112469#1650003 (10Etonkovidova) Checked Special:NewPagesFeed in betalabs. [17:33:21] 3Collaboration-Team-Current, 10Echo, 10Flow: "You have new messages" stuck (until page reload) after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1650005 (10Mooeypoo) a:3Mooeypoo [17:38:23] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1650029 (10Catrope) a:3Mooeypoo [17:42:22] 6Collaboration-Team-Backlog, 10Flow: When you post a message and then go back to the previous page, the message seems to be lost - https://phabricator.wikimedia.org/T112858#1650040 (10Quiddity) [17:42:23] 6Collaboration-Team-Backlog, 10Flow: Flow shows new messages only after I reload the page - https://phabricator.wikimedia.org/T63086#1650041 (10Quiddity) [17:42:56] 6Collaboration-Team-Backlog, 10Flow: Flow shows new messages only after I reload the page - https://phabricator.wikimedia.org/T63086#1650050 (10Quiddity) [17:47:33] 3Collaboration-Team-Current, 10Flow: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1650068 (10DannyH) p:5Normal>3High [17:48:10] 3Collaboration-Team-Current, 10Echo, 10Flow: "You have new messages" stuck (until page reload) after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1650070 (10DannyH) p:5Normal>3High [17:48:20] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1650072 (10DannyH) p:5Normal>3High [17:52:04] 6Collaboration-Team-Backlog, 10Flow: Review SQL flow_*_ref_revision_v2 indexes - https://phabricator.wikimedia.org/T112511#1650106 (10Catrope) p:5Triage>3Normal [18:01:29] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1650129 (10Mattflaschen) [18:03:42] (03PS1) 10Matthias Mullie: Read board content from master db [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) [18:07:31] (03CR) 10jenkins-bot: [V: 04-1] Read board content from master db [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [18:14:55] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1650204 (10Mattflaschen) [18:17:56] (03PS1) 10Mattflaschen: Remove obsolete comment. This is no longer the last one. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239157 [18:18:17] (03CR) 10Mattflaschen: [C: 032] "Trivial docfix." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239157 (owner: 10Mattflaschen) [18:21:06] (03Merged) 10jenkins-bot: Remove obsolete comment. This is no longer the last one. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239157 (owner: 10Mattflaschen) [18:23:44] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1650241 (10Mattflaschen) [18:24:34] (03PS5) 10Mooeypoo: [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [18:25:08] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1593860 (10Mattflaschen) [18:26:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [18:27:41] (03PS6) 10Mooeypoo: [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [18:28:13] RoanKattouw, when you have time, please help with that one ^^ The popup is not anchored correctly, even though I added $container config... can't figure it out :\ [18:28:29] (03CR) 10Mattflaschen: "It's deliberate. It avoids the problem of a non-existent message lingering in qqq for whatever reason (maybe a developer intended to add " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/238426 (https://phabricator.wikimedia.org/T56979) (owner: 10Haritha28) [18:30:42] 6Collaboration-Team-Backlog, 10Flow: A link to a Commons file is red colored on edit mode on Flow - https://phabricator.wikimedia.org/T112862#1650268 (10Mattflaschen) [18:31:01] mooeypoo: OK but I might not have time today [18:31:26] mooeypoo: Regardless of how much I speak to you over the course of today, can you send me an email when you stop working with a list of stuff you want my help with [18:31:40] Basically, give me things to do tomorrow morning/afternoon my time while you sleep [18:34:44] 6Collaboration-Team-Backlog, 10Flow, 10Huggle, 7WorkType-NewFunctionality: Investigate if and how Huggle works when warning user who has Flow on user talk - https://phabricator.wikimedia.org/T112900#1650294 (10Mattflaschen) You can also read/grep the [Pywikibot code](https://git.wikimedia.org/tree/pywikibo... [18:36:25] 6Collaboration-Team-Backlog, 10Flow: Review SQL flow_*_ref_revision_v2 (missing and extra indexes) - https://phabricator.wikimedia.org/T112511#1650302 (10Mattflaschen) [18:37:50] stephanebisson, have you been able to access deployment-bastion and deployment-fluorine yet? [18:39:01] Oh we have a deployment-fluorine? [18:40:10] Yeah [18:40:16] It's basically the same as fluorine. [18:40:28] But for Beta obviously. [18:42:04] matt_flaschen: no :( [18:42:28] RoanKattouw, yep, will do [18:42:30] stephanebisson, I can work on it now with you if you want. [18:42:55] matt_flaschen: give me a few minutes if you can [18:42:55] Probably a good start would be to look at a sanitized version of your ssh config. [18:42:58] Sure [18:47:33] (03CR) 10Matthias Mullie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [19:01:09] (03PS1) 10Mooeypoo: Correct unseen animation in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) [19:01:10] RoanKattouw, :(((((( animations.... ^^ [19:01:50] norifications [19:02:05] ... out of the entire convoluted explanation in my commit message, THAT is what you notice [19:02:06] :D [19:02:27] RoanKattouw, also, to be honest, I'm somewhat worried about that animation now. :\ [19:03:00] seeon-to-read [19:03:03] unseen-to-read? [19:03:17] yes, unseen to both [19:03:38] Not the first issue I've had with it... and it's weird that I could only reproduce *one* aspect of this bug locally, yet in Beta it happens fairly consistently (but only with a new session for the user, not later) [19:03:47] so.. I think it's this fix + caching issues on beta? [19:04:03] I'm not sure, though. I can't verify until we merge and check on beta again. [19:05:11] (03PS2) 10Mooeypoo: Correct unseen animation in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) [19:06:39] *logically* speaking, it makes sense in explaining what we see on Beta (wrong background color applied despite the inspected rules of the CSS showing another color *should* be applied) but it's frustrating that I can't actually reproduce this fully locally [19:10:53] matt_flaschen: I sent you my ssh config [19:11:12] stephanebisson, okay, looking now. [19:12:14] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1650545 (10Mooeypoo) Seems fixed after the lazy load fix. [19:13:15] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1650552 (10Quiddity) >>! In T112251#1649872, @Mooeypoo wrote: > Echo popups, in theory should never be empty. There is always at least 1 alert in th... [19:17:19] 3Collaboration-Team-Current, 10Flow: Opt-out: the opt-in guided tour displayed again when a user reverts 'Flow on user talk' option - https://phabricator.wikimedia.org/T112938#1650560 (10Etonkovidova) 3NEW [19:17:21] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1650567 (10Mooeypoo) We need to come up with a product solution for this, then. If there are no messages, the message icon is not showing. What do w... [19:18:38] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1650569 (10Etonkovidova) Related ticket T112938 Opt-out: the opt-in guided tour displayed again when a u... [19:19:00] stephanebisson, I think it's just the username. I was able to get yours working with my shell username. [19:19:28] what should it be? [19:19:36] Probably sbisson or stephanebisson [19:20:17] indeed! thanks [19:20:22] stephanebisson, matt_flaschen Elena just found another bug in opt-in where if you opt in, opt out, and opt in again, the guided tour is again triggered. But the guided tour cookie checks if there was ever a flow board -- is that check not correct? Or do we need to check something else? Is that an indicator for something related to the current bug with not refilling the archive link? [19:20:35] 3Collaboration-Team-Current, 10Flow: Opt-out: the opt-in guided tour displayed again when a user reverts 'Flow on user talk' option - https://phabricator.wikimedia.org/T112938#1650560 (10Etonkovidova) [19:20:36] If it's not recognizing whether it is the second time at all, etc? [19:20:37] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1650578 (10Etonkovidova) [19:20:50] mooeypoo: I found that code suspicious too [19:21:27] matt_flaschen: hi [19:21:33] you around? [19:21:34] mooeypoo: the right place to trigger it is in optincontroller.php:97 [19:21:39] d3r1ck, ehy [19:21:46] wait, didn't we fix this... [19:21:49] same as the echo notification, the first time only [19:21:58] matt_flaschen, how are you today? [19:22:11] stephanebisson, right place to trigger what? [19:22:18] the guided tour [19:22:28] matt_flaschen: setting the cookie for the guided tour [19:22:33] matt_flaschen, am I senile? Didn't we fix this? didn't we move it to setting the cookie in hooks ? [19:22:43] The reason the hook needs to add the custom cookie rather than OptinController itself is that OptInController runs in a deferred. By that point it's too late to send any content (including a header) to the user's browser. [19:22:56] yes... and we moved it [19:22:58] ... what the hell [19:23:04] I would shell in and check if hasFlowBoardArchive() is wrong in this scenario. [19:23:07] of course [19:23:28] d3r1ck, fine, how are you? [19:23:38] matt_flaschen, >.< it's moved to the hooks, but wasn't removed from optin controller [19:23:47] Great. [19:24:10] mooeypoo: line 128 [19:24:22] $this->user is TPM [19:24:28] matt_flaschen, i am fine too [19:24:34] not the user requesting the beta feature [19:24:36] mooeypoo, yeah it was: https://git.wikimedia.org/blobdiff/mediawiki%2Fextensions%2FFlow.git/184f0cf2ee05e5b32b826d02326ab093ede2308a/includes%2FImport%2FOptInController.php [19:24:54] ... how do I still see it in the code [19:25:07] mooeypoo: you need to pass in the user from the hook [19:25:10] let me pull everything again [19:25:15] stephanebisson, aren't we doing that? [19:25:43] mooeypoo: no, you're using $this->user inside the controller [19:25:50] mooeypoo, I have no idea. It's not there: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/HEAD/includes%2FImport%2FOptInController.php [19:26:28] matt_flaschen, okay, I am updating master again [19:26:44] stephanebisson, i see it. bah [19:27:13] d3r1ck, do you have a question? [19:27:24] stephanebisson, wait, wait, why is that not good? We have $this->user set in that class [19:27:34] mooeypoo: it's not the same user [19:27:41] oh it's the talk page manager [19:27:44] ...bah [19:27:52] that's confusing. [19:28:04] mooeypoo: you can rename $this->user at the same time [19:28:33] or do you want me to fix this, you are busy, right? [19:28:46] I just fixed it [19:28:52] i think [19:29:04] I need to send the user from the hooks [19:29:12] so I changed the function to accept a user [19:29:42] mooeypoo: are you able to run the optin browser tests? [19:30:11] if so, do it. if not, we need to find a time to fix your setup [19:30:18] stephanebisson, I didn't try for a while [19:30:29] but yeha, we do. [19:30:46] 6Collaboration-Team-Backlog, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1650630 (10Quiddity) 3NEW [19:30:58] these tests have saved me sooo much time for this feature [19:31:37] 6Collaboration-Team-Backlog, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1650641 (10Mattflaschen) p:5Triage>3Unbreak! [19:31:48] (03PS1) 10Mooeypoo: Use the currect user when checking whether there was a board before [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239180 [19:31:56] 3Collaboration-Team-Current, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1650630 (10Mattflaschen) [19:32:03] stephanebisson, yeah, I need to figure out what's up with them. I had them working for other features before [19:32:19] ok I have to run to lunch, I'll be back in a bit [19:33:47] (03CR) 10Bartosz Dziewoński: Use the currect user when checking whether there was a board before (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239180 (owner: 10Mooeypoo) [19:34:28] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: API problem in Echo may be showing empty notifications panel - https://phabricator.wikimedia.org/T112251#1650665 (10Quiddity) For now, a placeholder message would probably be best. (Otherwise editors will get in the habit of ignoring the "red 1" at less... [19:37:50] 6Collaboration-Team-Backlog, 10Flow: Opt-out: mw-ui-feature-user-count in Preferences-Beta features is not updated after Save - https://phabricator.wikimedia.org/T112944#1650687 (10Etonkovidova) 3NEW [19:42:02] (03CR) 10Sbisson: [C: 04-1] "It doesn't restore my wikitext talk page properly when I opt out." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [19:42:27] matt_flaschen: yes [19:42:36] matt_flaschen: where is the HTML for Echo? [19:45:40] d3r1ck, there is not just raw HTML. You will have to understand the structure and update the messages. [19:47:35] (03CR) 10Sbisson: [C: 032] Use the currect user when checking whether there was a board before [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239180 (owner: 10Mooeypoo) [19:48:48] d3r1ck, you should probably start with an easier bug. [19:49:54] I'm going to get lunch too. [19:51:06] matt_flaschen: i will understand it. I will make me learn [19:51:20] matt_flaschen: just tell me where the file i will edit is, then i will look for it [19:51:26] matt_flaschen: is it in Echo.php? [19:55:14] (03CR) 10Matthias Mullie: "Wow. I thought $loader wasn't used apart from there, but it is a couple of lines down so I shouldn't have removed it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [19:55:20] (03PS2) 10Matthias Mullie: Read board content from master db [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) [19:56:18] (03Merged) 10jenkins-bot: Use the currect user when checking whether there was a board before [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239180 (owner: 10Mooeypoo) [19:59:53] d3r1ck, possibly Echo.php among other places. You will either need to split notification-reverted2 into two messages (which I'm not sure how to do in this situation) or add a new parameter for the target page (User:Foo or Special:Contributions/1.2.3.4) which I'm also not sure the best way to do here. [20:00:25] 3Collaboration-Team-Current, 10Flow: Opt-out: the opt-in guided tour displayed again when a user reverts 'Flow on user talk' option - https://phabricator.wikimedia.org/T112938#1650816 (10DannyH) p:5Triage>3Normal I agree that this could be tightened up, but it's not a blocker for opt-in release. [20:00:28] d3r1ck, sorry, I don't have any more time to work on this bug with you. [20:03:44] matt_flaschen: can it be fixed? Like is it doable to a new comer like me? [20:04:05] I will really like to fix the bug. I want to help MediaWiki. I am really interested [20:06:30] Is anyone here called EBernhardson [20:06:39] ebernhardson: hi [20:06:49] d3r1ck: heh, yes thats me :) [20:06:51] i will like us to work on something [20:06:52] nice [20:06:58] you are working on this bug right [20:07:03] probably not [20:07:06] https://phabricator.wikimedia.org/T55174 [20:07:10] that one [20:07:14] it is assigned to you. [20:07:26] ebernhardson: the link i sent. [20:07:34] d3r1ck: looks like i declined that task [20:07:43] but it is still assigned to you [20:07:49] that is what i see [20:08:00] d3r1ck: yes when a ticket is closed its still assigned [20:08:07] ohhh [20:08:11] but i need help on something [20:08:32] d3r1ck: basically, if you want to move that ticket forward you will have to work with dannyh (product manager). At the time the request in that ticket as against the desired of the existing PM [20:08:34] ebernhardson: if i understand it, i will just fix the other bug [20:09:11] ebernhardson: did you understand what the bug i am talk about or working on need? [20:09:28] Changing the links from User page to Special Contributions page [20:09:41] ebernhardson: https://phabricator.wikimedia.org/T55564 [20:09:41] d3r1ck: is there a different ticket for that bug? [20:09:47] yes [20:09:50] there is [20:10:01] ebernhardson: it bas been assigned to me. [20:10:13] I want to fix it, but the code is not quite clear to me. [20:10:43] I know it is PHP but i need to know where the links for the Echo are generated so i can tweak it to make the fix. Do you understand what i mean? [20:11:11] d3r1ck: yea..the echo notifications configuration is insane. The configuration for echo will have the i18n message a list of strings that resolve into variables [20:11:27] d3r1ck: the configuration in flow for the echo notifiations [20:11:43] d3r1ck: you have to figure out which one of the echo formatters your particular thing is in and change it [20:12:04] ebernhardson: which file has all that? Is it Echo.php? [20:12:10] and what is i18n? [20:12:19] 6Collaboration-Team-Backlog, 10Flow: Can not move flow boards - https://phabricator.wikimedia.org/T112954#1650888 (10Luke081515) 3NEW [20:12:27] d3r1ck: the flow configuration for echo notifications is in includes/Notifications/Notifications.php [20:12:38] matthiasmullie: also doing the night shift? [20:12:52] d3r1ck: all the code related to notifications in flow should be in that directory. The formatter that outputs the wrong links could be in either echo or flow, although i would guess flow [20:13:12] d3r1ck: i18n is internationalization (See, way too long to type. thats why its i18n) [20:13:37] ebernhardson: :) i see [20:13:37] the i18n messages are the actual text that is in the user interface [20:15:01] ebernhardson: hey, something is not straight here [20:15:48] which of the includes folder because there is no Notifications folder in the root of MediaWiki and also in Echo extension [20:16:21] d3r1ck: Flow [20:16:44] (03CR) 10Sbisson: [C: 032] Read board content from master db [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [20:16:46] 6Collaboration-Team-Backlog, 10Flow: Opt-out: mw-ui-feature-user-count in Preferences-Beta features is not updated after Save - https://phabricator.wikimedia.org/T112944#1650906 (10Etonkovidova) [20:16:49] echo was supposed to me more of a library, but some extra things got bolted in there and we never had time to properly separate back out [20:17:15] but assume that echo just handles the backend work, and that anything to do with the content or links or whaetever of a Flow notification happen in flow. Echo just delivers them [20:18:00] ebernhardson: please where is the Flow? [20:18:04] Is it another extension? [20:18:09] because i don't see it. [20:18:26] Can you give me the full path from the MediaWiki root? [20:18:39] d3r1ck: doh, i read your ticket wrong:P flow is the main project that the collaboration team have been working on for the past 2 years [20:19:20] (03Merged) 10jenkins-bot: Read board content from master db [extensions/Flow] - 10https://gerrit.wikimedia.org/r/239151 (https://phabricator.wikimedia.org/T112784) (owner: 10Matthias Mullie) [20:19:35] d3r1ck: in that case, all that config is going to be in Echo.php [20:20:27] i see [20:20:29] ok [20:20:54] ebernhardson: the thing is this is my first bug. I will like to fix it and one i do this, i will know how to do the others myself [20:24:03] d3r1ck: i guess i can just walk you through it. Your message is 'Your edit on [[Mike Patton]] has been reverted by [[User:124.181.111.127|124.181.111.127]' [20:24:33] so we open up i18n/en.json and look for a message like that. We find ""notification-reverted2": "Your {{PLURAL:$4|edit on [[:$2]] has|edits on [[:$2]] have}} been {{GENDER:$1|reverted}} by [[User:$1|$1]]. $3", [20:25:08] so basically, that the message. This hard harcoded [[User:$1|$1]] so we probably need to add a new argument and change that to [[$3:$1]] [20:25:46] then we need to find the keys in Echo.php that reference this message. We see this mentioned once in $wgEchoNotifications['reverted']['title-message'] [20:26:06] this looks to currently receive 4 arguments, 'agent'm, 'title', 'difflink' and 'number', based on the match title-params argument right next to it [20:26:16] so actually we need to make our message [[User:$5|$1]] [20:26:29] then we need to append a string value to that list that will reference our new argument [20:26:31] 3Collaboration-Team-Current, 10Flow: Opt-out: How to show link to /Flow Archive? (needs team discussion) - https://phabricator.wikimedia.org/T112957#1650955 (10DannyH) 3NEW [20:26:38] err, not [[User:$5|$1]] but [[$5|$1]] [20:26:58] the configuration for 'reverted' says it uses the formatter-class 'EchoEditFormatter' [20:27:45] so we open up EchoEditFormatter and there is a function 'processParam' [20:27:51] ebernhardson: wait let me understand the messages you have sent first before you continue [20:28:09] we need to make that function return User:Name when the user is a real user, and Special:Contributions/Name when its anon [20:28:22] that should be about it, i probably skipped a step or two [20:37:08] 3Collaboration-Team-Current, 10Flow: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1651048 (10Mooeypoo) a:3Mooeypoo [20:42:54] stephanebisson: lol [20:43:09] no nightshift - just saw your review roll in and seemed easy enought to fix right away [20:43:18] anyway, seems like it’s working now :) [20:46:33] ebernhardson: where is the EchoEditFormatter class? [20:46:37] I can't fine it [20:46:38] *find [20:47:05] matthiasmullie: not too fast there... [20:47:44] I need to run some more tests, I saw a failure [20:48:23] (03PS1) 10Mooeypoo: Remove talk page notification bar if all messages are read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239277 (https://phabricator.wikimedia.org/T106033) [20:52:11] matthiasmullie: looks good. I saw a problem where the board was restored but it didn't have the topic I posted to it earlier... But it ran successfully 10 times after that. [21:03:36] ebernhardson: i am working on it. It is moving but where can i see the EchoEditFormatter Class? [21:03:57] ebernhardson: still there? [21:05:52] d3r1ck: sorry was in a meeting, EchoEditFormatter is in the Echo extension, includes/formatter/EchoEditFormatter.php [21:07:47] ebernhardson: i have fixed it [21:08:14] but the problem now is the notification(red small button) is not working [21:08:35] 3Collaboration-Team-Current, 10Flow: Opt-out: How to show link to /Flow Archive? (needs team discussion) - https://phabricator.wikimedia.org/T112957#1651294 (10Etonkovidova) Another (although related) topic to discuss - 'View history': User talk page will have different History pages due to opt-in/opt-out -... [21:08:45] If any changes are reverted, it should show red and 1 or ... [21:08:49] but it is not showing [21:11:29] ebernhardson: the notification is not changing to red to show that there a revert. But revert is enabled [21:13:17] (03PS4) 10Mooeypoo: Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) [21:15:17] (03PS1) 10Mooeypoo: Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) [21:15:59] RoanKattouw, omg, I just did that not only with git add -p, but I used 'e' to edit a piece [21:16:09] I am way more proud than I should be about this [21:16:15] Nice :) [21:16:32] It took me 3 times to edit it right, because it kept telling me it's invalid, but I got it at the end [21:16:33] The power of -p is awesome, both in the Californian sense and the biblical sense [21:16:45] That's a biblical sense to -p ? [21:16:51] ebernhardson: the alert box is not showing red anymore. Which the number of notifications [21:17:07] 3Collaboration-Team-Current, 10Flow: Opt-out: How to show link to /Flow Archive? (needs team discussion) - https://phabricator.wikimedia.org/T112957#1651341 (10DannyH) About the two histories: that's actually not much different from page moves, or wikitext cut-and-paste archives. I think this is actually more... [21:17:11] ebernhardson: were is the alert code so i can check? [21:17:14] oh the biblical/californian was about "Awesome", not about "-p" [21:17:14] ha [21:17:34] Yes [21:18:33] A biblical sense to -p, I suppose that would be people following some but not all of Leviticus [21:19:06] d3r1ck: notifications are returned to the flyout in ApiEchoNotifications [21:19:46] ok [21:26:53] whooo [21:26:58] i just fixed my first bug [21:27:08] :) [21:28:55] sweet! [21:29:06] ebernhardson: do you review bugs? [21:29:16] i want to submit a review then you can check and merge :) [21:33:02] mooeypoo: could you review https://gerrit.wikimedia.org/r/#/c/238835/ and https://gerrit.wikimedia.org/r/#/c/238846/ ? [21:35:32] d3r1ck: i'm burried in other work currently, but there are multiple people that can review echo patches [21:38:28] (03CR) 10Mooeypoo: [C: 032] Don't depend upon ext.echo.logger in ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238835 (owner: 10Legoktm) [21:40:16] (03CR) 10Legoktm: [C: 04-1] "If I open the flyout and sucessfully fetch notifications, close it, and open again and get an API error (logged out in a different tab or " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [21:40:57] (03Merged) 10jenkins-bot: Don't depend upon ext.echo.logger in ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238835 (owner: 10Legoktm) [21:41:08] ebernhardson: ok [21:41:09] thanks [21:42:16] d3r1ck, good job. I can review it for you. I'm mattflaschen on Gerrit. [21:43:27] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Give Nick and Benoit access to Special:EnableFlow - https://phabricator.wikimedia.org/T112979#1651506 (10DannyH) 3NEW a:3Catrope [21:44:19] ok [21:44:51] hey, please can you git me the gerrit repo link for Echo extension? [21:44:59] It seems i cloned from git [21:45:40] matt_flaschen: can you help me with the link so that i can do git remote add? [21:45:56] so i will push to my gerrit account for review please [21:46:09] legoktm, the only fear I have with the echo.nojs->echo.notification/badge split is that other extensions require the nojs module. I checked with MobileFrontend and they're only using the logger and I grepped through extensions/ folder and I found no other instance. It's also a new thing, so... It's safe to assume no one else uses it right? [21:46:35] I don't think anyone else had to adjust [21:46:54] d3r1ck, what's your Gerrit username? [21:47:03] mooeypoo: Yeah, I grepped and didn't see any other uses [21:47:17] matt_flaschen: d3r1ck01 [21:47:18] awesome, just wanted to make 100% sure we're not breaking anything preventable [21:47:29] (03CR) 10Mooeypoo: [C: 032] Split up ext.echo.nojs into badge and notifications styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238846 (owner: 10Legoktm) [21:47:57] matt_flaschen: could this be the link to it? [21:48:00] ssh://d3r1ck01@gerrit.wikimedia.org:29418/mediawiki/extensions/echo.git [21:48:14] d3r1ck, almost: [21:48:16] git remote set-url origin ssh://d3r1ck01@gerrit.wikimedia.org:29418/mediawiki/extensions/Echo.git [21:49:32] matt_flaschen: ok [21:49:37] thanks [21:49:42] will submit the review soon [21:51:05] (03CR) 10Mooeypoo: "Yes, that's by design for this fix. The only API error you will see is if you failed to fetch the initial messages. If you have notificati" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [21:51:20] (03Merged) 10jenkins-bot: Split up ext.echo.nojs into badge and notifications styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238846 (owner: 10Legoktm) [21:51:29] matt_flaschen: it complains about .git/hooks/commit-msg [21:51:32] how can i get it? [21:51:57] d3r1ck, what does: [21:51:58] git remote -v [21:52:00] say? [21:52:13] matt_flaschen: it seems git review -s will do [21:52:47] it didn't work [21:52:53] What is got remote -v? [21:53:01] origin ssh://d3r1ck01@gerrit.wikimedia.org:29418/mediawiki/extensions/Echo.git (fetch) [21:53:04] origin ssh://d3r1ck01@gerrit.wikimedia.org:29418/mediawiki/extensions/Echo.git (push) [21:53:09] that is it [21:53:47] d3r1ck, try: [21:53:49] git commit --amend [21:54:07] Then re-save the commit message. It may just need to add the Change-Id. [21:54:39] But it should download the hook automatically I believe if you have the right URL. [21:55:35] is the change id different? [21:55:45] because i had thesame error [21:55:55] d3r1ck, please make a pastebin of the exact error you get when you do git review. [21:58:40] (03CR) 10Catrope: [C: 04-1] Use localized version of LQT magic word (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [21:58:51] (03PS4) 10Jforrester: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232423 [22:01:04] matt_flaschen: the error is not much [22:01:23] matt_flaschen: i can paste it here [22:01:33] d3r1ck, alright. [22:03:33] (03PS5) 10Mooeypoo: Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) [22:03:46] (03CR) 10Legoktm: "Minor wording suggestion. Is there a way to make the error message not clickable? https://i.imgur.com/eGQ3UkH.png is how it looks after yo" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [22:06:48] d3r1ck, what do you get from: [22:07:03] ssh mattflaschen@gerrit.wikimedia.org -p 29418 [22:08:42] (03CR) 10Legoktm: [C: 032] Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [22:09:06] ssh d3r1ck01@gerrit.wikimedia.org -p 29418 [22:09:17] Yeah, whoops. :) [22:09:20] d3r1ck, from what you PMed me it looks like your ssh config is broken. [22:11:18] (03Merged) 10jenkins-bot: Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [22:12:00] (03CR) 10Catrope: [C: 04-1] "You should not need to add the -footer class to the individual buttons. The CSS selector wrote should work without that too. If it doesn't" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 (owner: 10Legoktm) [22:13:45] (03PS3) 10Catrope: Correct unseen animation in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) (owner: 10Mooeypoo) [22:16:08] (03PS2) 10Legoktm: Make the footer links readable in Modern [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 [22:16:11] (03CR) 10Catrope: [C: 04-1] Correct unseen animation in notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239170 (https://phabricator.wikimedia.org/T112826) (owner: 10Mooeypoo) [22:16:34] (03CR) 10Legoktm: "@Catrope: Yup! Works fine without" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 (owner: 10Legoktm) [22:16:44] (03CR) 10Catrope: [C: 032] Make the footer links readable in Modern [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 (owner: 10Legoktm) [22:19:54] (03Merged) 10jenkins-bot: Make the footer links readable in Modern [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 (owner: 10Legoktm) [22:20:40] (03CR) 10Catrope: [C: 032] Instantiate the Optin controller only when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238740 (owner: 10Sbisson) [22:20:43] (03CR) 10jenkins-bot: [V: 04-1] Instantiate the Optin controller only when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238740 (owner: 10Sbisson) [22:22:03] (03CR) 10Catrope: "I think you can make OptionWidgets "unselectable", that should fix that." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [22:22:17] (03CR) 10Catrope: "This commit needs to be rebased manually, it has conflicts." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [22:24:20] RoanKattouw, yeah I was about to rebase it, was dealing with demonstration of bugs from Elena [22:24:36] this is super confusing, some of the bugs we're seeing are being fixed in multiple commits [22:27:58] d3r1ck, can you PM me your .ssh/config? [22:28:31] (03PS2) 10Mooeypoo: Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) [22:28:42] matt_flaschen: i have configurations for connecting to a server [22:28:46] online [22:29:18] (03CR) 10Catrope: [C: 04-1] Remove talk page notification bar if all messages are read (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239277 (https://phabricator.wikimedia.org/T106033) (owner: 10Mooeypoo) [22:29:23] in the config file [22:30:02] d3r1ck, I don't understand. Can you PM me your .ssh/config file? [22:30:06] d3r1ck, also, try: [22:30:15] (03CR) 10jenkins-bot: [V: 04-1] Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [22:30:15] ping gerrit.wikimedia.org [22:30:19] I don't know why that wouldn't work, but... [22:30:55] matt_flaschen: i am sure it is my internet connection [22:31:01] ping is not working [22:31:14] ping returns [22:31:15] ping: unknown host gerrit.wikimedia.org [22:31:24] so let me reboot my Wireless router [22:31:28] matt_flaschen: :) [22:38:51] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: When accessing talk page through echo, the yellow "new message" notification doesn't go away until the next page view - https://phabricator.wikimedia.org/T107655#1651790 (10Etonkovidova... [22:50:25] matt_flaschen: regarding https://phabricator.wikimedia.org/T111771 : I still see ajax-loader.gif?57f34 in /static/master/resources/src/mediawiki.legacy/images [22:50:49] matt_flaschen: I meant - I see it when I am looking at the page loaded sources... [22:51:00] etonkovidova, good catch. I forgot to remove the image. [22:51:13] One sec [22:51:30] matt_flaschen: hurray! I felt very useful now :) [22:52:45] Wait, that's outside the Flow extension. [22:52:49] It was already removed from Flow. [22:55:31] etonkovidova, actually, the one you mentioned (in core) is still referenced from resources/src/mediawiki.legacy/shared.css (also a file in core) by the mw-ajax-loader CSS class. [22:56:45] matt_flaschen: well, it's ok then, right? [22:57:00] etonkovidova, and mw-ajax-loader still has some uses: https://github.com/search?q=user%3Awikimedia+mw-ajax-loader&type=Code&utf8=%E2%9C%93 . So I think we're good. [22:57:03] Sorry for the confusion. [22:57:46] matt_flaschen: yes, I was surprised to see ajax-loader.gif . OK - thanks! [22:58:07] etonkovidova, there are actually several copies of that file. :( [22:58:17] Not sure if they're the same... [22:58:37] Not in Flow (none left there), other places. [22:58:57] Some are totally unrelated, though. [23:00:58] matt_flaschen: as long as ajax-loader.gif is not on ResourcesTest::testFileExistence radar as "referenced by 'ext.flow.ui' must exist." [23:01:17] Yep, that one's fixed. [23:03:22] (03PS1) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [23:03:43] matt_flaschen: i have done the push [23:03:47] you can revi now [23:03:51] *review [23:06:46] matt_flaschen: i have added you as a reviewer. [23:06:55] check it and see if it works for you. [23:06:58] d3r1ck, I'll review it shortly. [23:07:15] (03PS3) 10Mooeypoo: Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) [23:07:27] matt_flaschen: ok [23:08:15] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1651871 (10Mattflaschen) [23:09:00] (03CR) 10jenkins-bot: [V: 04-1] Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [23:10:04] etonkovidova, I've set $wgFlowMigrateReferenceWiki to false on the Beta cluster. Basically this means that the behavior and performance for link table issues should be similar now in Beta to when we do this in production (production later). [23:10:36] etonkovidova, this means there should no longer be any inconsistencies where things in Beta from different wikis are wrongly linked together. [23:10:49] matt_flaschen: that's actually great - thx [23:11:13] etonkovidova, it would be particularly helpful to check for performance regressions on Beta (e.g. pagination being slow or anything else you can think of). [23:11:24] This is related to https://phabricator.wikimedia.org/T111084 and https://phabricator.wikimedia.org/T108104 . [23:12:31] We're hoping to do it in production early next week (hopefully Monday). [23:13:08] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/f... - https://phabricator.wikimedia.org/T111771#1651890 [23:14:30] matt_flaschen: how can i submit a patch for review on the bug ticket it self [23:14:39] I'm out for ~2 hours, whilst certain stores are open. [23:14:46] so it can be marked as Patch-For-Review [23:15:35] d3r1ck, edit the commit message (you can do that in Gerrit or with: [23:15:37] git commit --amend [23:15:38] ) [23:15:40] Add: [23:16:31] 6Collaboration-Team-Backlog, 10Echo, 7Easy: IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification - https://phabricator.wikimedia.org/T55564#1651901 (10Mattflaschen) [23:16:40] Bug: T55564 [23:16:43] as the last line before Change-Id [23:16:45] ^ d3r1ck [23:16:49] matt_flaschen: i did that [23:16:54] but it did not work [23:18:03] (03PS2) 10Mattflaschen: IP addresses should link to Special:Contributions instead of userpage [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [23:18:20] (03PS3) 10Mattflaschen: IP addresses should link to Special:Contributions instead of userpage [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [23:18:55] (03PS4) 10Mattflaschen: IP addresses should link to Special:Contributions instead of userpage [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [23:19:01] (03PS5) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [23:19:43] d3r1ck, it has to be on the very last line before Change-Id. You had an empty line between Bug and Change-Id. It shouldn't be that finnicky, but it is. [23:20:53] (03CR) 10Mattflaschen: [C: 04-1] "This will link to the Contributions page for logged in users as well. You probably need to use the approach Erik (Ebernhardson) gave." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) (owner: 10D3r1ck01) [23:20:58] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1651928 (10Etonkovidova) Turned out it's not an issue - just an optical illusion:) - when Messages are open, 'Your alerts' are overlapping Messages' overlay. {F2613... [23:22:08] matt_flaschen: i understand [23:22:10] thanks [23:22:18] matt_flaschen: so did you review the patch? [23:22:24] d3r1ck, I fixed your commit message to handle Bug, but you overwrote it. I'll let you do it locally. There are also some typo fixes I made in the commit message, and we don't use Signed-off-by. [23:22:41] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Echo icon FOUC (tracking) - https://phabricator.wikimedia.org/T112104#1651942 (10DannyH) [23:22:42] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1651940 (10DannyH) 5Open>3Resolved Excellent, we could use more bugs that turn out to be optical illusions. [23:23:14] matt_flaschen: ok, let me fix all those and commit again [23:24:03] d3r1ck, yes. It won't work since you *always* use Special:Contributions. You need to do what ebernhardson suggested (pass in the page name as the fifth parameter) or some other approach. [23:24:04] legoktm, https://gerrit.wikimedia.org/r/#/c/239285/ <-- it's unclickable now [23:24:17] .. it's also failing jenkins. wtf? [23:25:30] OMG [23:26:00] (03CR) 10Catrope: [C: 04-1] Show a default message if no notifications are available (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [23:26:02] ... [23:26:03] (03PS4) 10Mooeypoo: Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) [23:26:10] Yeah guess what that -1 is for [23:26:11] RoanKattouw, I know... I know.... [23:26:17] I was testing my api [23:26:20] Actually my comment was also "..." [23:26:24] :D :D [23:26:24] haha [23:26:37] It was also "FALSE" and not "ERROR" ... not sure where that came from [23:26:40] bt yeah [23:26:41] oops [23:26:59] ERROR is actually truthy [23:27:02] (03PS6) 10D3r1ck01: IP addresses should link to Special:Contributions instead of userpage e.g. revert change [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239301 (https://phabricator.wikimedia.org/T55564) [23:27:19] RoanKattouw, which is why it worked! I probably didn't notice I'm typing it, I was thinking about errors [23:27:28] Unlike what you'd expect (or what would be sane), using an undefined constant like ERROR just implicitly defines it as 'ERROR' [23:27:30] but yeah, ha, good thing tests failed and we are vigilant in reviews [23:27:30] matt_flaschen: but that is what the patch says [23:27:39] sorry bug description [23:27:44] It would have behaved as || true, not || false [23:27:49] Oh but you were using || so you wanted taht [23:27:56] yep [23:28:03] wanted to trigger an error [23:28:21] d3r1ck, the bug says it needs to link to the user page if the user is logged in. [23:28:21] RoanKattouw, just to verify, you see how I made the model have an error state ? [23:28:35] d3r1ck, you always link to Special:Contributions. [23:28:45] i am not sure if that's a perfect thing to do. The ideal would've been to have the promise do it, but it seems to fall into the 'it's not nullifying itself properly' pit [23:28:59] So I improvised. [23:29:03] mooeypoo: Where did you do that? [23:29:06] d3r1ck, Erik explained the basics of how to solve this properly. [23:29:24] in the underlying commig, let me find it [23:29:35] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/238903/ [23:29:47] RoanKattouw, specifically: https://gerrit.wikimedia.org/r/#/c/238903/5/modules/viewmodel/mw.echo.dm.NotificationsModel.js [23:30:15] RoanKattouw, this is what we discussed a while back about setting the promise while returning it [23:30:23] how the nullification can be problematic? [23:30:26] "echo-api-failure": "Could not retrieve notifications Please try again. (Error $1)", [23:30:35] Ahm, maybe there should be a period in that message? [23:30:45] After the () ? [23:30:54] periods in english are inside the () [23:30:57] which is confusing in this case [23:31:08] No, between "notifications" and "Please" [23:31:14] oh [23:31:18] ... wtf, there was one [23:31:18] matt_flaschen: yes i can see it now. [23:31:21] :) [23:31:27] Not in the merged version apparently [23:31:47] crap [23:32:17] The first comment at https://gerrit.wikimedia.org/r/#/c/238903/5/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js I don't understand at all [23:32:42] In particular, "retrieves the fetching notifications" and "reset the notification population method" don't parse for me [23:33:07] eh "promise". Retrieve the fetching notification promise [23:33:38] as in, we don't care if it was requested before or after, the model has a fetching promise that it will give you (or take from what you give it) [23:33:46] Right [23:33:48] Clearly I need to re-explain [23:34:07] I think I understand the comment after reading it again [23:34:17] But only by ignoring some of the words in it [23:34:45] (03PS1) 10Mooeypoo: Add a missing dot in the new api error message in English. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239303 [23:35:13] RoanKattouw, Sorry, something really wrong happened to my English there [23:35:39] This, however, is priceless: "I could understand what you meant, but only after ignoring some of the words." [23:36:03] haha [23:36:05] I was being serious! [23:36:11] I know! [23:36:13] it's great [23:36:17] You're not wrong, either [23:36:17] After I deliberately ignored a few words that I thought were wrongly chosen, I understood it better [23:36:34] It's okay, I do that all the time [23:37:27] also, holy crap, what are you doing up? [23:39:51] Oh hmm yeah [23:39:53] I should go to sleep [23:40:03] I fixed up the comment [23:40:10] but read it after you sleep [23:40:17] Maybe you'll be able to ignore less of my words [23:40:18] :D [23:40:50] wait, wtf... oh [23:41:00] it would be nice if i didn't try to git review a patch that's already merged. [23:44:10] (03PS1) 10Mooeypoo: Fix a code comment to make it much clearer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239305 [23:46:08] mooeypoo, comment makes sense. Want me to merge? [23:46:43] matt_flaschen, I think so. Makes it much better than the other comment. Not sure what I was on... [23:47:42] (03CR) 10Mattflaschen: [C: 032] Fix a code comment to make it much clearer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239305 (owner: 10Mooeypoo) [23:48:28] (03CR) 10Catrope: [C: 032] Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [23:49:13] (03CR) 10Catrope: [C: 032] Add a missing dot in the new api error message in English. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239303 (owner: 10Mooeypoo) [23:50:12] (03Merged) 10jenkins-bot: Fix a code comment to make it much clearer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239305 (owner: 10Mooeypoo) [23:52:51] (03Merged) 10jenkins-bot: Show a default message if no notifications are available [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239285 (https://phabricator.wikimedia.org/T112251) (owner: 10Mooeypoo) [23:52:54] (03CR) 10jenkins-bot: [V: 04-1] Add a missing dot in the new api error message in English. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239303 (owner: 10Mooeypoo)