[00:12:45] (03PS9) 10Mooeypoo: Only load ext.echo.ui if the user clicks the echo badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238389 (https://phabricator.wikimedia.org/T112401) [00:27:58] 6Collaboration-Team-Backlog, 10Flow: Flow's editor won't finish loading at Enwiki or at mw.o - https://phabricator.wikimedia.org/T112716#1643636 (10Quiddity) 3NEW [00:28:40] 6Collaboration-Team-Backlog, 10Flow: Flow's editor won't finish loading at Enwiki or at mw.o - https://phabricator.wikimedia.org/T112716#1643647 (10Quiddity) [00:29:00] 6Collaboration-Team-Backlog, 10Flow: Flow's editor won't finish loading at Enwiki or at mw.o - https://phabricator.wikimedia.org/T112716#1643653 (10Quiddity) [00:29:08] 6Collaboration-Team-Backlog, 10Flow: Flow's editor won't finish loading at Enwiki or at mw.o - https://phabricator.wikimedia.org/T112716#1643654 (10Legoktm) I think @Krinkle is fixing this right now. [00:42:53] quiddity: ^ should be fixed now [00:44:03] ty [00:45:22] legoktm, fixed at enwiki, not at mw.o ? [00:57:48] quiddity: urm, ask Krinkle? [00:58:23] legoktm, which channel???? [00:58:31] (so many to chose from....) [01:02:17] -dev? [01:02:26] i chose -editing [01:35:00] quiddity: -operations or -tech [01:35:17] way too late! but thanks anyway :) [02:00:26] 6Collaboration-Team-Backlog, 10Flow: Flow's editor won't finish loading at Enwiki or at mw.o - https://phabricator.wikimedia.org/T112716#1643756 (10Quiddity) 5Open>3Resolved a:3Quiddity Fixed by Krinkle magic. [04:21:22] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads, 6translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#1643819 (10Mattflaschen) 5Invalid>3Open "Flow will be maintained and supported, and communities that are e... [04:21:35] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads, 6translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#1643822 (10Mattflaschen) a:5Nemo_bis>3None [04:28:27] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1643826 (10Mattflaschen) [04:28:29] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1643825 (10Mattflaschen) [04:46:44] (03CR) 10Mattflaschen: "It's all Ruby code ("I have no new notifications" is defined in Ruby)." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163216 (owner: 10Spage) [04:46:54] (03CR) 10Mattflaschen: [C: 04-1] QA: comment on duplicated logic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/163216 (owner: 10Spage) [04:47:49] (03PS4) 10Mattflaschen: WIP: Add code to randomly remove idling records from email batch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/63097 (owner: 10Bsitu) [04:47:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add code to randomly remove idling records from email batch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/63097 (owner: 10Bsitu) [04:51:27] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1643888 (10Mattflaschen) [05:48:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1617300 (10matthiasmullie) It took a couple of patches, but it seems to works now :) [07:20:51] 6Collaboration-Team-Backlog, 10Echo, 6Performance-Team, 7Performance: Don't use wfDiff() - https://phabricator.wikimedia.org/T93625#1644026 (10Legoktm) 5Resolved>3Open >>! In T93625#1311400, @ori wrote: > Done in [[ https://gerrit.wikimedia.org/r/#/c/190513/ | Ia5239c1e7 ]]. I think that's supposed to... [07:45:59] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads, 6translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#1644095 (10Nemo_bis) 5Open>3Invalid a:3Nemo_bis Doesn't change substance, see also https://lists.wikimed... [09:28:31] (03CR) 10Catrope: [C: 04-1] "PS9 contains some CSS changes that I suspect belong in a different commit" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238389 (https://phabricator.wikimedia.org/T112401) (owner: 10Mooeypoo) [09:28:39] (03CR) 10Catrope: Only load ext.echo.ui if the user clicks the echo badge (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238389 (https://phabricator.wikimedia.org/T112401) (owner: 10Mooeypoo) [10:48:23] RoanKattouw: I believe https://gerrit.wikimedia.org/r/#/c/238713/ should fix the patch you just had to revert [10:49:26] Ooooh [10:49:41] Yeah that looks like it should do the trick [11:01:37] (03CR) 10Catrope: [C: 031] Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [11:17:53] (03CR) 10Jcrespo: [C: 04-1] "Why a UUID, specially given that it is not used anywhere else (as per your comments)? Why not a simple int (4 bytes) or big int (8 bytes)?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [11:20:13] (03CR) 10Jcrespo: "BTW, the usage of an extra column is +1 for me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [11:53:55] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1644629 (10SBisson) One scenario doesn't seem to work: Re-opt-in ( features/opt-in.feature:37 ) # You... [11:54:59] (03CR) 10Sbisson: [C: 032] Browser tests: fix buttons locators for anonymous edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238129 (owner: 10Sbisson) [11:59:11] (03Merged) 10jenkins-bot: Browser tests: fix buttons locators for anonymous edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238129 (owner: 10Sbisson) [13:29:23] (03PS1) 10Sbisson: Instantiate the Optin controller only when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238740 [14:24:17] 6Collaboration-Team-Backlog, 10Flow, 10Cite, 6Language-Engineering, and 6 others: Use CSS to style Parsoid's Cite extension output - https://phabricator.wikimedia.org/T86782#1644848 (10Amire80) [15:21:19] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an overview about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1645079 (10Trizek-WMF) [15:22:38] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1645088 (10Trizek-WMF) 3NEW a:3Trizek-WMF [15:23:55] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an overview about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1645104 (10Trizek-WMF) [15:23:58] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1645088 (10Trizek-WMF) [15:24:13] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an overview about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1606490 (10Trizek-WMF) [15:24:16] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1645088 (10Trizek-WMF) [15:28:55] (03Abandoned) 10Sbisson: [WIP] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238493 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [15:29:08] (03PS1) 10Sbisson: [WIP] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) [15:32:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [15:34:55] (03PS2) 10Sbisson: [WIP] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) [15:37:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) (owner: 10Sbisson) [15:41:34] (03PS3) 10Sbisson: [WIP] Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) [16:43:12] (03PS4) 10Sbisson: Use localized version of LQT magic word [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238772 (https://phabricator.wikimedia.org/T110723) [16:54:12] (03CR) 10Mooeypoo: "I can split the commit of the css changes if you want, but they are put here because with the new on-demand-load, the button jump has a di" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238389 (https://phabricator.wikimedia.org/T112401) (owner: 10Mooeypoo) [16:54:15] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1645574 (10Etonkovidova) 3NEW [16:54:26] RoanKattouw, ^^ spherical CSS in a vacuum, for you, Mr. Math. [16:55:16] RoanKattouw, "Assume the browser is consistent...." vs "Simplify the CSS to a perfect sphere and adjust by eye". We should frame this and hang in in front of our monitors. [16:56:25] haha [16:57:36] Alright the code looks fine to me [16:57:41] I'll test it then merge [16:59:04] RoanKattouw, I am fairly sure (eh, hopefully sure) that if we switch the widget to
  • ... structure, the styling will be consistent. Also, in this fix it's also not 100%, but it's a lot closer.... :\ [17:00:23] mooeypoo: Is it supposed to stay greyed out until both the code and the API response are ready? [17:00:41] No, but I don't need to un-grey it, because it's being replaced when it's ready [17:00:47] (I anticipated that code question) [17:00:50] Well, sure [17:00:53] But what I mean it [17:00:54] *is [17:01:11] We don't want to grey it out when the popup is already up [17:01:25] Even if I enable caching for load.php, so the code loads instantly and the API request takes time, I still observe the button staying greyed out until it is replaced with a fully formed popup [17:01:33] I do not observe it being replaced with a pending popup [17:01:35] Is this intentional? [17:01:59] so this "loading" state is in 2-stages (that's what I was talking about in yesterday's meeting) -- the first stage the button is greyed out until ooui is loaded, then it isn't greyed out anymore but the popup appears with a pending state. [17:02:07] RoanKattouw, yes, the button is greyeed out while ooui is loading. [17:02:08] Oh, it's just because my API is "too fast" [17:02:22] Mine is slow :\ [17:02:24] (03PS2) 10Legoktm: Split out .mw-echo-alert styles back into a separate module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238204 [17:02:25] vagrant.... [17:02:34] Even with the OOUI code cached, apparently my API still responds fast enough that it doesn't get a chance tobe pending [17:02:37] RoanKattouw, I can screencast it for you if you want. The popup appears pending for me [17:02:43] (03CR) 10Legoktm: [C: 032] "Per Roan" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238204 (owner: 10Legoktm) [17:02:47] Yeah I reproduced that by adding sleep(3); to api.php [17:03:49] (03PS2) 10Catrope: Adjust margins for the notification badge in MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238628 (owner: 10Mooeypoo) [17:04:18] There's still a bit more of a change in Monobook [17:04:29] It's unnoticeably close in Vector, but it's noticeable in Monobook, even with the follow-up patch [17:04:52] In Vector it's perfect [17:05:02] I [17:05:09] I'll merge the patches but please see if you can fix that [17:05:10] hm, I adjusted in monobook above ? [17:05:20] https://gerrit.wikimedia.org/r/#/c/238628/ [17:05:24] ^^ RoanKattouw monobook. [17:05:31] Yeah that patch makes it better but still noticeable [17:05:36] oh [17:05:48] okay, I'll look into that [17:05:57] (03Merged) 10jenkins-bot: Split out .mw-echo-alert styles back into a separate module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238204 (owner: 10Legoktm) [17:05:59] Just checking in Firefox now [17:06:25] ~1px change in Vector in Firefox but whatreyagonnado [17:06:43] RoanKattouw, this 1px is the bane of my existence [17:06:57] RoanKattouw, should I just work on the
  • widget? [17:06:59] Monobook is actually better in FF [17:07:01] Yeah, I guess so [17:07:24] It's less urgent because of the 2-part lazy load, but it's still probably necessary [17:07:45] (03CR) 10Catrope: [C: 032] Only load ext.echo.ui if the user clicks the echo badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238389 (https://phabricator.wikimedia.org/T112401) (owner: 10Mooeypoo) [17:08:09] (03CR) 10Catrope: [C: 032] Adjust margins for the notification badge in MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238628 (owner: 10Mooeypoo) [17:14:55] (03Merged) 10jenkins-bot: Only load ext.echo.ui if the user clicks the echo badge [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238389 (https://phabricator.wikimedia.org/T112401) (owner: 10Mooeypoo) [17:15:17] (03Merged) 10jenkins-bot: Adjust margins for the notification badge in MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238628 (owner: 10Mooeypoo) [17:18:46] (03PS2) 10Legoktm: Measure how likely users open flyout if they have unseen notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238632 [17:41:07] 6Collaboration-Team-Backlog, 10Echo, 6Performance-Team, 7Performance: Don't use wfDiff() - https://phabricator.wikimedia.org/T93625#1645958 (10MaxSem) A volunteer wants to wfDeprecate() it, thus Echo's unit tests migh break if diffing is tested at all. [17:41:58] 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 3 others: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views - https://phabricator.wikimedia.org/T112401#1645964 (10Catrope) a:5Catrope>3Mooeypoo [17:42:13] 3Collaboration-Team-Current, 10Flow: Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1645968 (10matthiasmullie) 3NEW [17:42:15] matt_flaschen, when you get a chance, can you link me to docs on adding Flow to the dumps? [17:42:33] I'm curious how you'll do it. I'd like to support it with my tools. [17:42:50] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1645978 (10matthiasmullie) I've created another ticket for that: {T112784} [17:43:37] halfak, https://phabricator.wikimedia.org/T89398 and https://phabricator.wikimedia.org/T93925 . You can join our meeting on Monday about it if you want (11 AM Pacific). [17:44:45] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Echo icon FOUC (tracking) - https://phabricator.wikimedia.org/T112104#1625508 (10Catrope) [17:48:52] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1645999 (10DannyH) p:5Triage>3Normal [17:48:54] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1646001 (10Catrope) [17:49:03] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1646017 (10Catrope) a:3Mooeypoo [17:51:06] 3Collaboration-Team-Current, 10Flow: Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1646026 (10DannyH) p:5Triage>3High [17:51:12] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Echo icon FOUC (tracking) - https://phabricator.wikimedia.org/T112104#1646028 (10Etonkovidova) [17:51:13] 3Collaboration-Team-Current, 10Flow: Echo notifications: "Your alerts" tooltip placed under Messages - https://phabricator.wikimedia.org/T112773#1646029 (10Etonkovidova) [17:53:23] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1646034 (10DannyH) p:5Triage>3Normal [17:53:27] (03PS3) 10Mooeypoo: Dim the nojs buttons for js-version of Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237540 (https://phabricator.wikimedia.org/T112218) [17:53:48] (03Abandoned) 10Mooeypoo: Dim the nojs buttons for js-version of Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237540 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [17:55:42] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1646040 (10matthiasmullie) >>! In T109676#1585731, @Mattflaschen wrote: > We'll probably go with an artif... [17:58:07] matt_flaschen, it's hard to work from the meeting notes, but from what I gather, you guys are looking to put flow boards along-side tags in the page/revision dumps, right? [17:59:03] halfak, I was thinking more a separate XML file, but I don't know if we explicitly decided that. [17:59:16] I see. I think that might be nice. [17:59:36] Do you have an XML schema document that I can review? [18:00:26] (03CR) 10Matthias Mullie: "Our UUID is 88bits, so the column size should be fine." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [18:01:32] matt_flaschen, ^ [18:02:26] halfak, no. Is there one for the core dumps? [18:02:37] https://www.mediawiki.org/xml/export-0.10.xsd [18:03:23] I use that to build my parser so that I don't get caught off guard by a weird field. Or at least when I do, it's not my fault. [18:04:06] 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend: Check Special:Notifications logging for MobileFrontend - https://phabricator.wikimedia.org/T112789#1646088 (10Mattflaschen) 3NEW [18:07:45] 6Collaboration-Team-Backlog, 10Echo, 7Easy: IP addresses should link to Special:Contributions instead of userpage - https://phabricator.wikimedia.org/T55564#1646117 (10D3r1ck01) Wow, i have been researching a little about this bug. Is it still there or has it been fixed. I think i can challenge myself to fi... [18:19:02] 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend: Check Special:Notifications logging for MobileFrontend - https://phabricator.wikimedia.org/T112789#1646158 (10Jdlrobson) p:5Triage>3Normal Note it's possible you might not be loading JavaScript because of targets. Let me know if I can help in any way. [18:25:10] 6Collaboration-Team-Backlog, 10Echo: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#1646180 (10Mattflaschen) 3NEW [18:25:36] legoktm: https://meta.wikimedia.org/w/index.php?title=Tech/News/2015/39&diff=0&oldid=13648820 <-- want to undo? [18:26:03] 6Collaboration-Team-Backlog, 10Echo: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#1646199 (10Mattflaschen) [18:26:15] 6Collaboration-Team-Backlog, 10Echo, 10Security-Reviews, 6Security-Team: Security review for cross-wiki aspects of Echo notifications - https://phabricator.wikimedia.org/T112792#1646180 (10Mattflaschen) [18:27:28] 6Collaboration-Team-Backlog, 10Flow, 10Security-Reviews, 6Security-Team: Security review for Flow new structured workflow feature - https://phabricator.wikimedia.org/T112793#1646213 (10Mattflaschen) 3NEW [18:30:19] James_F: I'll clean it up [18:30:31] legoktm: Kk. [18:30:54] legoktm: But it doesn't really need discussing. A 20% slow down for first-run first-paint for logged-in users? Meh. [18:33:35] James_F: https://meta.wikimedia.org/w/index.php?title=Tech%2FNews%2F2015%2F39&type=revision&diff=13662511&oldid=13650589 [18:34:42] legoktm: LGTM. [18:37:21] halfak, alright, I'll make a subtask for that. (I also know from hard experience on the other end that XSDs can make things a lot easier in certain environments) [18:37:39] Thanks matt_flaschen :) [18:38:24] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Typing ':' at the start of a paragraph in VisualEditor creates a
    , not a
    which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1646347 (10Esanders) [18:38:55] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
    , not a
    which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1646351 (10Jdforrester-WMF) [18:39:32] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 7WorkType-Maintenance: Create XML Schema for Flow dump format(s) - https://phabricator.wikimedia.org/T112799#1646353 (10Mattflaschen) 3NEW [18:44:25] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
    , not a
    which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1646386 (10Alsee) I submitted the report on DannyH's page. However colon... [18:44:41] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
    , not a
    which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1646391 (10Esanders) Relevant bug on
    support: T39938 [18:47:17] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Reconsider that typing ':' at the start of a paragraph in VisualEditor creates a
    , not a
    which is the wikitext equivalent - https://phabricator.wikimedia.org/T112690#1646400 (10Jdforrester-WMF) I'm entirely OK with making `:` insert a ` 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads, 6translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#1646411 (10Mattflaschen) I'm not going to edit war with you about the status. I'm sure if Niklas and Siebrand... [18:52:10] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1646421 (10SBisson) a:5matthiasmullie>3SBisson [18:53:49] (03CR) 10Mattflaschen: [C: 031] "I would also prefer to use a UUID for consistency with other artificial primary keys in Flow, such as workflow_id." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [18:58:12] RoanKattouw_away: could you look at https://gerrit.wikimedia.org/r/238632 whenever you have some time? [18:59:38] mooeypoo: does the mw.track timing for the overlay opening still work with the new preload system? [18:59:57] 6Collaboration-Team-Backlog, 10Echo, 7Easy: IP addresses should link to Special:Contributions instead of userpage - https://phabricator.wikimedia.org/T55564#1646459 (10Mattflaschen) a:3D3r1ck01 It's still open. If you have questions, you can ask in #wikimedia-collaboration. [19:00:35] (03CR) 10Catrope: [C: 032] Measure how likely users open flyout if they have unseen notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238632 (owner: 10Legoktm) [19:01:31] RoanKattouw_away: do you think it's worth writing a wmf21 version of that so we can start getting data now? [19:03:15] 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 4 others: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views - https://phabricator.wikimedia.org/T112401#1646475 (10Legoktm) Recap of fixes: * {3940f523baf7b339e258ef5... [19:03:37] (03Merged) 10jenkins-bot: Measure how likely users open flyout if they have unseen notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238632 (owner: 10Legoktm) [19:07:34] i was asked to ask my question about thiss bug https://phabricator.wikimedia.org/T55564 by Mattflaschen [19:07:47] is he around? Id please [19:11:21] matt_flaschen ^^ [19:12:11] d3r1ck, yes, what's your question? [19:12:33] can someone throw more lights on what i am suppose to do about it? [19:12:36] i mean the bug [19:13:01] i am interested in fixing it. [19:13:44] d3r1ck, do you know what Echo is? [19:16:00] matt_flaschen: echo is thesame as notification [19:16:10] from what i saw in Wiki. Are my right? [19:17:26] (03CR) 10Jcrespo: [C: 031] Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [19:17:41] d3r1ck, yes. Please make an edit at https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/Sandbox and I will demonstrate for you. [19:18:01] d3r1ck, make the edit while logged in. [19:18:43] d3r1ck, wait one sec. [19:19:06] RoanKattouw_away, is .always() not running after .fail() ?! [19:19:07] ok [19:19:11] yeesh [19:19:48] matt_flaschen: i am waiting and ready when you are [19:19:57] d3r1ck, before making the edit, enable the 'Edit revert' notification at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-echo . [19:20:48] Then go ahead and make the edit and let me know. [19:21:52] ok [19:22:40] matt_flaschen: shouel i put any text? [19:22:43] *should [19:22:50] for the edit? [19:23:43] matt_flaschen: edit done [19:25:41] d3r1ck, okay, now go to https://en.wikipedia.org/wiki/Special:Notifications . Do you see the revert notification? [19:26:19] manyes i see it. [19:26:33] matt_flaschen: yes i see it. [19:27:25] 6Collaboration-Team-Backlog, 10Echo, 7Easy: IP addresses should link to Special:Contributions instead of userpage - https://phabricator.wikimedia.org/T55564#1646554 (10Mattflaschen) [19:28:33] d3r1ck, okay, if you mouse over, you'll see it goes to the User: page (user page). It should go to Special:Contributions/73.165.39.119 , just like the 73.165.39.119 link at https://en.wikipedia.org/w/index.php?title=User:Mattflaschen-WMF/Sandbox&action=history . [19:28:37] d3r1ck, make sense? [19:29:09] (03PS1) 10Legoktm: Don't depend upon ext.echo.logger in ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238835 [19:29:14] mooeypoo: ^ [19:31:10] matt_flaschen: mouse hover on what? Show changes or what? [19:31:38] d3r1ck, mouse hover on 73.165.39.119 . [19:31:46] Or just check the href. [19:33:30] matt_flaschen: this is what i get when i click on the IP https://en.wikipedia.org/w/index.php?title=User:73.165.39.119&action=edit&redlink=1 [19:33:38] mooeypoo: what do you think about s/nojs/styles/? so "ext.echo.styles.special" "ext.echo.styles.badge"? [19:34:15] d3r1ck, yes, it should go to https://en.wikipedia.org/w/index.php?title=Special:Contributions/73.165.39.119 . [19:34:44] Or https://en.wikipedia.org/wiki/Special:Contributions/73.165.39.119 (you won't have to worry about that since the linker generates the link). [19:34:57] legoktm, yeah, either that or something like "base" or something. It's the base styles for both nojs and js versions. [19:35:02] 'styles' work [19:35:11] d3r1ck, you just need to specify the right target page when the reverter is anonymous. [19:36:04] matt_flaschen: So i have to make sure it generates https://en.wikipedia.org/wiki/Special:Contributions/73.165.39.119 [19:36:26] or i click to it and it takes me to the https://en.wikipedia.org/wiki/Special:Contributions/73.165.39.119 page? [19:37:18] matt_flaschen: is it in the VectorTemplate.php file? because that is the skin i am using and HTML code is there [19:37:49] also, how can we do the test offline so i can make the change and be able to see it. [19:37:54] d3r1ck, that URL should be right. No, it's in Echo. [19:38:11] d3r1ck, you should install https://www.mediawiki.org/wiki/MediaWiki-Vagrant unless you already have MW installed locally. [19:38:49] matt_flaschen: i have installed it but it is complaining about base box [19:39:18] d3r1ck, you'll have to make a new message (similar to notification-reverted2 but only used for anons, e.g. notification-reverted2-anonymous). [19:39:30] [21:33] mooeypoo [2015-09-16 19:13:43] RoanKattouw_away, is .always() not running after .fail() ?! [19:39:38] That message is in https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FEcho.git . [19:39:44] d3r1ck, what does the error say? [19:40:17] mooeypoo: You mean you wanted an order guarantee? If so, use .then() [19:40:55] matt_flaschen: vm: [19:40:57] * The box 'base' could not be found. [19:41:50] d3r1ck, or I guess you could pass a page name (e.g. User:Foo or Special:Contributions/73.165.39.119) then change notification-reverted2 to take the page name as a parameter and use that instead of User:$1 [19:41:56] d3r1ck, when you do what? [19:42:15] when i run vagrant up [19:44:14] d3r1ck, what happens when you run: [19:44:16] vagrant box list [19:46:00] matt_flaschen: There are no installed boxes! Use `vagrant box add` to add some. [19:47:12] d3r1ck, what directory are you in when you do vagrant up? [19:47:39] in my MediaWiki directory root [19:47:58] or do i have to clone vagrant for wiki specific? [19:49:40] d3r1ck, did you clone https://gerrit.wikimedia.org/r/mediawiki/vagrant as https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Quick_start says, or just clone MediaWiki core directly? [19:50:08] i cloned MediaWiki core [19:50:15] then cloned the WikiBase [19:50:19] in the extensions folder [19:50:31] are my suppose to clone vagrant? [19:51:12] d3r1ck, if you have a working MediaWiki installation, you can just install Echo and keep using your separate MW install. [19:51:38] d3r1ck, if you don't have a working MW installation, you should delete your unfinished MW installation and follow https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Quick_start [19:51:38] is echo an extension? [19:51:53] d3r1ck, yes. See https://www.mediawiki.org/wiki/Extension:Echo . [19:52:07] I don't have any more time to work on this right now, but see above about how to get started. [19:52:21] i will do that. [19:52:25] (03PS2) 10Legoktm: Don't depend upon ext.echo.logger in ext.echo.init [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238835 [19:52:29] (03PS1) 10Legoktm: Split up ext.echo.nojs into badge and notifications styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238846 [19:52:46] If there is any questions, i will put ask in the chaneset [19:52:49] *changeset [20:33:45] matt_flaschen: for 'End the occupation' I see that-- select max(rev_timestamp) from revision where rev_comment like "%Taken over by Flow%"; 20150827095122 [20:34:17] matt_flaschen: did we get rid of the comment sucessfully? [20:34:55] (03PS4) 10Sbisson: Show real output instead of placeholder HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) (owner: 10Matthias Mullie) [20:35:36] etonkovidova, looks like it judging by that date. :) Yes, it was changed to use the flow-talk-taken-over-comment translation message, which in English defaults to "This page has been converted into a Flow discussion board" [20:36:02] matt_flaschen: good :) [20:39:51] RoanKattouw, you remember we talked about how when you return a promise that nullifies itself, we could run into race conditions? [20:40:48] matt_flaschen: i will work on the patch tomorrow [20:40:58] but will need your help when need be [20:41:11] Yes... [20:41:14] RoanKattouw, Hello, race conditions..... I'm trying to deal with error handling, and while I did find a workaround for this (marking 'error' state in the model) it's FAR from perfect. The ideal would really be if the promise can nullify itself anyways, but I can't manage to do that.... [20:41:24] RoanKattouw, I'm going to push my wip, can you take a look? [20:42:43] (03PS1) 10Mooeypoo: [wip] Handle API fetching errors [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238903 [20:42:45] RoanKattouw, ^^ [20:43:00] Hmm, maybe tomorrow? [20:43:02] I'm going to bed soon [20:43:05] and I need to wrap up a few things [20:43:10] RoanKattouw, I thought at first that "fail()" doesn't trigger "always()" but that's not the case [20:43:11] oh yeah [20:43:14] it's not urgent for today [20:43:17] just pointing it out [20:44:07] RoanKattouw, I wanted to make sure I don't forget we need this. I am going to work on the
  • widget next [20:44:49] this can wait for tomorrow. Also, I have a workaround WORKING. It's just... crappy. And it may lead to potential problems synchronizing existing API calls if/when the model calls for one without the UI (like whatever future push notifications we want to do) [20:45:00] so it's far from urgent, but I don't want to implement a crappy solution if a better one is available [20:48:15] (03PS1) 10Zfilipin: Updated watir-webdriver Ruby gem to the latest version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238942 (https://phabricator.wikimedia.org/T112748) [21:02:48] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1646990 (10Etonkovidova) Checked in betalabs(including general regression testing on Moving pages between namespaces, and then converting to Flow). Also the c... [21:14:33] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1647021 (10SBisson) This is also happening on mw.org. I didn't test on other production sites. It can b... [21:15:12] 3Collaboration-Team-Current, 10Flow: [Regression] In betalabs "Due to a technical error, this post could not be retrieved." for entries with triple curly brackets - https://phabricator.wikimedia.org/T112350#1647024 (10SBisson) p:5Normal>3Unbreak! a:3SBisson [21:25:28] (03PS1) 10Zfilipin: Updated watir-webdriver Ruby gem to the latest version [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/238975 (https://phabricator.wikimedia.org/T112748) [21:31:16] how would one proceed to get the value of configuration variables on enbeta? [21:31:52] stephanebisson: ssh deployment-bastion.eqiad.wmflabs ; mwscript eval.php enwiki; var_dump($wgWhatever); [21:32:17] (Assuming you have your ~/.ssh/config set up to do ProxyCommand for *.eqiad.wmflabs like in the documentation) [21:33:25] I'm afraid I don't, which documentation is it? [21:33:53] * RoanKattouw searches [21:34:37] https://wikitech.wikimedia.org/wiki/SSH_access#Labs [21:35:00] your_labs_ssh_key is the same SSH key you use for Gerrit [21:35:05] username ditto [21:42:15] stephanebisson, I think https://phabricator.wikimedia.org/P2053 should be sufficient, unless you use a non-default key for Labs. [21:44:41] ok, I'm in [21:45:18] but I can't run mwscript from here, where should I go? [21:46:33] You're on deployment-bastion.eqiad.wmflabs ? [21:46:55] i'm on bastion1.eqiad.wmflabs [21:47:13] deployment-bastion says "Connection closed by UNKNOWN" [21:47:14] Oh, right [21:47:23] Oh hm maybe the ProxyCommand thing isn't working right [21:48:54] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 3 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1647121 (10DannyH) This looks good ! Waiting on these: {T111830} {T112784} [21:51:22] Let me look at my ssh config [21:51:55] 6Collaboration-Team-Backlog, 10Flow: FlowHooks::getOccupationController() should not be called on every page view - https://phabricator.wikimedia.org/T102158#1647133 (10DannyH) [21:51:56] 6Collaboration-Team-Backlog, 10Flow: Flow on user talk: Pages don't exist - https://phabricator.wikimedia.org/T109189#1647132 (10DannyH) [21:51:58] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1647130 (10DannyH) 5Open>3Resolved [21:52:22] stephanebisson: Redacted version of my ~/.ssh/config: https://gist.github.com/catrope/0659917ba3afba8f741f [21:52:56] \o/ [21:55:21] other than the last block, that's what I have [21:55:33] and still "Connection closed by UNKNOWN" [21:57:19] ok, making progress [21:57:31] it turns out typos in usernames are NOT supported [21:57:46] now I get: "Permission denied (publickey)." [21:58:28] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1647157 (10DannyH) 5Open>3Resolved This looks great; I think the issue Elena found in... [22:00:01] Hmm strange [22:00:03] Oh, hm, wait [22:00:09] You might have to upload that key separately [22:00:20] Right, yes, I think so, because LDAP supports everything except SSH keys [22:00:44] upload where? [22:01:00] https://wikitech.wikimedia.org/wiki/Special:Preferences#mw-prefsection-openstack [22:01:05] Sorry, I forgot about that [22:02:17] You know how you play tetris for a while and you end up seeing falling bricks everywhere you go? [22:02:32] my key is there [22:02:43] I see unread people. ALL THE TIME. [22:03:04] Oh right, cause you were able to log into bastion. [22:03:16] Ahm, maybe they haven't banned agent forwarding yet? You could try that [22:03:24] ssh -A bastion.wmflabs.org ; ssh deployment-bastion [22:04:02] what's up? [22:04:20] please don't use agent forwarding [22:04:40] no good [22:04:46] Oh, crap, I know [22:04:53] You're not a member of the deployment project [22:04:54] doh [22:04:58] This is how you can tell I need sleep :| [22:05:00] I'll add you [22:05:32] 3Collaboration-Team-Current, 10Flow: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1647172 (10Etonkovidova) 3NEW [22:06:59] stephanebisson: OK try ssh deployment-bastion.eqiad.wmflabs now? [22:07:30] RoanKattouw: Permission denied (publickey). [22:07:55] :( [22:10:06] RoanKattouw: where did you set it? Does it take effect right away? [22:10:26] I don't know how fast it is [22:11:04] If you just need the value of one var I can look it up for you if you like [22:11:14] I need a few [22:11:28] is there no specialpage that ouputs all $wg* ? [22:11:34] Nope [22:11:34] *outputs [22:11:41] eh, if only :\ [22:11:51] We'd have to very carefully hide the secret ones [22:12:04] You could try to determine the value from InitialiseSettings-labs.php and friends [22:12:18] But sometimes that stuff gets complex enough that you just want to var_dump it [22:12:33] yeah, I've tried to mentally parse the config repo but I dont trust myself doing it [22:12:37] a bunch of config is output by the API [22:12:55] meta=siteinfo [22:13:10] legoktm: would it include $wgVirtualRestConfig, $wgFlowParsoidURL, $wgFlowParsoidPrefix, $wgFlowParsoidTimeout, $wgFlowParsoidForwardCookies, $wgFlowParsoidHTTPProxy ? [22:13:16] it would not :P [22:14:18] I'll try the ssh again later [22:17:09] stephanebisson: https://gist.github.com/catrope/f658ee320da2080967ec [22:18:48] Still no luck with ssh? [22:20:03] RoanKattouw: thanks [22:20:08] Krenair: no [22:21:08] your key is AAAAB3NzaC1yc2EAAAADAQABAAABAQDSKFOSSTn2Q4VHxr+pGdehizSqrEIEfLuajbAx7BO66yhp3HhqcQ74n6z55qqHlRfczPI6GPexAt5A4s+xW3doXPit2JVPMocKYtGkdmLV9O/3DriwLfjm6+/XIbqrr21QnZ6XrPFSztdSCGvpGQ/yVqUG8ceoBZcd1LY+JurQNMo6HVLj1yXN3t7UXr54yviOu66Q53bnoe4g5ZfVr6PtZV4+kfJVe2rhUzqNfzMoFo6akEVP7AOl4L0QeysN3n7dZ/VRrKZTgj4s1zfhRlb7Ha+Gd9k46231Me7B6uHwfiCrUV+V8zzGza/07nCWfummA1Txbp2HNfIHkd9gwlGx ? [22:21:45] Krenair: yep [22:22:56] I don't see you in the ldap group [22:23:54] oh, it's not sorted you in the right place. okay [22:24:04] ...what? [22:24:31] I was looking at ldaplist and most of the list was alphabetical [22:24:40] except the last few people at the end, including stephanebisson [22:25:37] 3Collaboration-Team-Current, 10Flow: Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1647282 (10Etonkovidova) 3NEW [22:26:01] stephanebisson, what was the combination of config and commands you ended up trying to use? [22:29:28] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1647310 (10Etonkovidova) General checking for notifications(betalabs) - after "Update 'FlowFixLinks:v2' already logged as comp... [22:32:25] Krenair: pretty much this: https://phabricator.wikimedia.org/P2053 [22:33:16] and it works with "ssh bastion1.eqiad.wmflabs" or "ssh bastion.wmflabs.org" but not "ssh deployment-bastion.deployment-prep.eqiad.wmflabs"? [22:35:01] right [22:54:58] 3Collaboration-Team-Current, 10Flow, 10WMF-Server-Backports, 5MW-1.26-release, and 3 others: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1647416 (10Etonkovidova) Checked /a/mw-log - no related errors to FeatureCompactor.php. [22:56:05] 3Collaboration-Team-Current, 10Flow: Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1647420 (10DannyH) p:5Triage>3Unbreak! Making this unbreak now, this should be checked out before we redeploy the Echo changes. I was able to reproduce th... [23:05:06] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1647435 (10DannyH) p:5Triage>3Normal [23:05:48] 6Collaboration-Team-Backlog, 10Flow: "There are no older topics" should not be on new Flow pages - https://phabricator.wikimedia.org/T112714#1647438 (10Etonkovidova) [23:09:15] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Inactive badge colors not compliant with accessibility guidelines - https://phabricator.wikimedia.org/T112510#1647446 (10Quiddity) Partially a duplicate of {T98526} - Could you update that task, and then merge this one into it? [23:11:10] 3Collaboration-Team-Current, 10Flow: Echo notifications: Unread Messages not always display close icon (x) - https://phabricator.wikimedia.org/T112826#1647448 (10Mooeypoo) a:3Mooeypoo [23:12:49] 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 4 others: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views - https://phabricator.wikimedia.org/T112401#1647449 (10Legoktm) a:5Mooeypoo>3ori >>! In T112401#1646475... [23:14:16] 6Collaboration-Team-Backlog, 10Echo, 7Browser-Support-Apple-Safari, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Broken Common.css on Commons breaks search suggestions, Echo, others for Safari, old Firefox - https://phabricator.wikimedia.org/T112552#1647458 (10Legoktm) 5Open>3Resolved Marki... [23:14:21] 3Collaboration-Team-Current, 10Flow: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1647460 (10DannyH) p:5Triage>3Normal [23:17:59] 6Collaboration-Team-Backlog, 10Flow: Missing 'View changes' for entries on User talk pages with Flow enabled (page-level diff) - https://phabricator.wikimedia.org/T112353#1647471 (10Mattflaschen) [23:18:39] 6Collaboration-Team-Backlog, 10Flow: Missing 'View changes' for entries on User talk pages with Flow enabled (page-level diff) - https://phabricator.wikimedia.org/T112353#1633126 (10Mattflaschen) I linked a couple relevant feature requests in the description. I'm confident Flow never supported 'View changes'... [23:19:38] 3Collaboration-Team-Current, 10Flow, 7Performance: Flow JS loading / deferred loading is very slow - https://phabricator.wikimedia.org/T108313#1647477 (10Mattflaschen) [23:26:33] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Notification state in output HTML is cached excessively - https://phabricator.wikimedia.org/T109997#1647484 (10Mattflaschen) [23:32:27] 6Collaboration-Team-Backlog, 10Echo, 10Flow: "You have new messages" stuck after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1647502 (10Mattflaschen) [23:33:05] 6Collaboration-Team-Backlog, 10Echo, 10Flow: "You have new messages" stuck until page reload after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1647514 (10Mattflaschen) [23:33:15] 3Collaboration-Team-Current, 10Echo, 10Flow: "You have new messages" stuck after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1647515 (10DannyH) [23:33:28] 3Collaboration-Team-Current, 10Echo, 10Flow: "You have new messages" stuck (until page reload) after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1647517 (10Mattflaschen) [23:35:08] matt_flaschen: i have installed the wiki extension [23:35:08] 3Collaboration-Team-Current, 10Echo, 10Flow: "You have new messages" stuck (until page reload) after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1647519 (10Mattflaschen) It should now work after page reload (worth QA-ing), and @mooeypoo is going to work on having it do so imme... [23:35:18] how can i test it to see if it is working? [23:37:04] http://i.imgur.com/kKDgh41.png [23:37:57] matt_flaschen: i tested it and it is working. Thanks [23:38:05] now i just have to fix the bug [23:38:29] my problem now is to create a test like you did so i can see that i am fixing the bug [23:41:07] d3r1ck, login as Admin (password vagrant), make an edit, then log out and revert the edit. [23:42:02] Oh, before you make the edit, make sure revert notifications are enabled for the Admin user. [23:42:43] wait, i am running a local version. So you are saying i have to use vagrant? [23:42:43] After the revert, log back in to Admin and the notification should be there. [23:43:02] d3r1ck, no, just create a user then. [23:43:18] You can also use two different browsers (one logged in, one logged out) instead of logging out if you want. [23:43:21] i already have a user called d3r1ck1 [23:43:26] so i should create another one [23:43:30] ok [23:45:59] matt_flaschen: i now have two different users [23:46:09] one is Derick and another is Derick01 [23:46:29] so how do i do the test? [23:46:36] so as to get a notification? [23:46:52] d3r1ck: [23:47:01] 1. Log in as Derick [23:47:09] 2. Enable revert notifications. [23:47:26] 3. Make an edit. [23:47:55] ok [23:48:07] 4. In another browser where you're not logged in, revert the edit. [23:48:34] 5. You should receive the revert notification while logged in as Derick. [23:50:56] matt_flaschen: are my using thesame user? [23:51:00] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one button on personal bar - https://phabricator.wikimedia.org/T111871#1647595 (10DannyH) 5Open>3declined a:3DannyH This is an interesting suggestion, thank you. We want to try out the new design for a while more, to get more feedback. [23:51:08] for the two browsers? [23:52:01] matt_flaschen: i am kind of confused a little bit [23:53:44] (03PS1) 10Legoktm: Make the footer links readable in Modern [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 [23:54:31] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Echo notification icons should be white in MonoBook to match Vector - https://phabricator.wikimedia.org/T112290#1647616 (10Legoktm) [23:56:34] (03CR) 10Legoktm: "I'm not sure if this is right, but it works." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/239007 (owner: 10Legoktm) [23:57:52] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Echo notification icons should be white in MonoBook to match Vector - https://phabricator.wikimedia.org/T112290#1647635 (10Legoktm) Open questions for #UI-standardization: * Should apex support inverted icons? * Should OOUI PHP output black icons for... [23:58:49] d3r1ck, in the other browser you should be logged out. [23:59:23] I accidentally closed Hangouts, and now it won't let me back in.