[00:07:35] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] Update extension registration system for MoodBar (032 comments) [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/223539 (https://phabricator.wikimedia.org/T87942) (owner: 10Niharika29)
[01:18:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1636062 (10bmansurov) a:3bmansurov
[02:36:00] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Move "left a message on your talk page" Echo notification from Alerts to Messages - https://phabricator.wikimedia.org/T108760#1636108 (10Tgr) People expect messages to be in the "Messag...
[04:24:56] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: The ooui-UI echo-icons looks like they are dfferent size - https://phabricator.wikimedia.org/T112494#1636152 (10Josve05a) 3NEW
[04:27:27] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: The ooui-UI echo-icons looks like they are dfferent size - https://phabricator.wikimedia.org/T112494#1636162 (10Josve05a)
[04:50:48] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: The ooui-UI echo-icons looks like they are dfferent size - https://phabricator.wikimedia.org/T112494#1636182 (10Kethrus) I don't think it's just you. Looks how you described.
[04:58:30] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI: The ooui-UI echo-icons looks like they are dfferent size - https://phabricator.wikimedia.org/T112494#1636183 (10Josve05a)
[05:00:56] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 7WorkType-Maintenance: The ooui-UI echo-icons looks like they are dfferent size - https://phabricator.wikimedia.org/T112494#1636184 (10Josve05a)
[07:42:48] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team: Fivefold increase in render-blocking CSS size for logged-in users - https://phabricator.wikimedia.org/T112401#1636353 (10ori) a:3Catrope @Catrope, could you please discuss this during your daily stand-up and work out a plan? My...
[07:46:17] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Performance: Flow JS loading / defered loading is very slow - https://phabricator.wikimedia.org/T108313#1636367 (10Addshore) One improvement here for the history pages could be rather than grey out / disable the whole page only disable / grey out the few links that the J...
[08:35:51] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team: Fivefold increase in render-blocking CSS size for logged-in users - https://phabricator.wikimedia.org/T112401#1636424 (10Catrope) >>! In T112401#1636353, @ori wrote: > @Catrope, could you please discuss this during your daily stan...
[09:00:42] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1636476 (10phuedx)
[09:01:53] <RoanKattouw>	 mlitn: Could you join me and Jaime over in #wikimedia-databases ?
[09:04:41] <mlitn>	 ok
[09:31:09] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636532 (10Catrope) Three rows were not backfilled. They appear to point to a workflow_i...
[09:39:13] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636555 (10matthiasmullie) These indeed appear not to exist in flow_workflow:    SELECT...
[09:39:26] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636556 (10jcrespo) Backuped those on db1029:/home/jynus/flow_strange_records and about...
[09:46:59] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1636579 (10Catrope)
[10:07:19] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636591 (10jcrespo) Current state of tables:  ``` mysql> SHOW CREATE TABLE flow_ext_ref\...
[10:07:35] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636592 (10jcrespo) a:5jcrespo>3None
[10:07:55] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1636593 (10phuedx) I've reviewed [238083](https://gerrit.wikimedia.org/r/238083) and it LGTM but where did...
[10:16:25] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636598 (10Catrope) We haven't yet turned off `$wgFlowMigrateReferenceWiki`. What we did...
[10:22:07] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 4 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1636613 (10jcrespo) Current officewiki status:   ``` mysql> SHOW CREATE TABLE flow_ext_r...
[10:23:04] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n, 5WMF-deploy-2015-09-15_(1.26wmf23): Translation of new namespaces into Oriya - https://phabricator.wikimedia.org/T110879#1636615 (10Sipun)
[10:41:22] <grrrit-wm>	 (03PS1) 10Catrope: Don't load oojs-ui.styles on every page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238115 (https://phabricator.wikimedia.org/T112401) 
[10:50:44] <grrrit-wm>	 (03PS2) 10Matthias Mullie: Get rid of $wgFlowMigrateReferenceWiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232465 (https://phabricator.wikimedia.org/T108104) 
[11:03:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Inactive badge colors not compliant with accessibility guidelines - https://phabricator.wikimedia.org/T112510#1636731 (10Pginer-WMF) 3NEW
[11:30:54] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Review SQL flow_*_ref_revision_v2 indexes - https://phabricator.wikimedia.org/T112511#1636795 (10matthiasmullie) 3NEW
[11:31:12] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Review SQL flow_*_ref_revision_v2 indexes - https://phabricator.wikimedia.org/T112511#1636805 (10matthiasmullie)
[11:36:04] <mlitn>	 RoanKattouw: you’re working on updating patches for new deployment plan?
[11:36:28] <mlitn>	 then I can start working on adding some PK
[11:36:45] <mlitn>	 (unless you already are/plan to work on that)
[11:37:36] <RoanKattouw>	 I'm working on eating lunch :D
[11:37:49] <RoanKattouw>	 But yeah I can update those patches
[11:38:21] <RoanKattouw>	 I updated the mediawiki-config patches already; I guess I still need to do the SQL side of things
[11:40:33] <RoanKattouw>	 Oh, hrm, right, my grandparents are coming by
[11:40:46] <RoanKattouw>	 I'll be back in a few hours, but if you get a chance to do the SQL stuff, please do
[11:47:12] <mlitn>	 sure, I can do the SQL side of things
[11:54:07] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Update references migration to reflect production status [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238124 (https://phabricator.wikimedia.org/T111084) 
[11:57:53] <mlitn>	 ^^
[12:29:24] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1637005 (10matthiasmullie) a:3matthiasmullie
[12:39:12] <grrrit-wm>	 (03PS1) 10Sbisson: Browser tests: fix buttons locators for anonymous edit [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238129 
[12:44:50] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Inactive badge colors not compliant with accessibility guidelines - https://phabricator.wikimedia.org/T112510#1637102 (10Pginer-WMF)
[13:01:47] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1637142 (10jcrespo)
[13:19:21] <grrrit-wm>	 (03PS3) 10Sbisson: Show real output instead of placeholder HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) (owner: 10Matthias Mullie)
[13:25:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Mark as read 'x' button is very small - https://phabricator.wikimedia.org/T112217#1637196 (10Pginer-WMF) For me the "X" renders as shown by @Esanders, which seems definitely too small.  > it does raise another issue, which is that it definitely looks like a close button. I...
[13:47:46] <grrrit-wm>	 (03CR) 10Sbisson: [C: 04-1] "This patch seems to be breaking opt-out." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) (owner: 10Matthias Mullie)
[14:00:12] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1637277 (10Trizek-WMF) a:5DannyH>3Trizek-WMF I'm currently (when TW is not down) proofreading all messages, based on Matt's list: https://git.wikimedi...
[14:24:47] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkType-NewFunctionality: Clicking 'edit' should always refetch from the server - https://phabricator.wikimedia.org/T109660#1637362 (10SBisson) Editing board description, topic titles and posts always refresh from the server.  However, clicking cancel sho...
[14:50:20] <stephanebisson>	 hey RoanKattouw
[14:51:05] <RoanKattouw>	 Hey
[14:51:27] <stephanebisson>	 working from europe now?
[14:52:01] <RoanKattouw>	 Yeah, for this week
[14:52:05] <stephanebisson>	 cool
[14:52:54] <stephanebisson>	 so, I have a followup apt. at 1pm and probably another one later this week but otherwise I'm back
[14:53:10] <RoanKattouw>	 Awesome
[14:53:16] <RoanKattouw>	 And you were out all of last week, right?
[14:53:31] <RoanKattouw>	 (I was flying on Thursday and sleeping on Friday so I didn't pay attention very well)
[14:53:56] <stephanebisson>	 RoanKattouw: I ended up working about 0.5 days
[14:54:09] <RoanKattouw>	 legoktm: Could you review https://gerrit.wikimedia.org/r/238115 please?
[14:54:19] <RoanKattouw>	 if you're awake already
[14:54:51] <stephanebisson>	 RoanKattouw: I've reviewed what I could. Any suggestions about what I should work on next?
[14:55:03] <RoanKattouw>	 Let me see
[14:55:26] <RoanKattouw>	 I don't even know what's on the board yet, I spent the day putting out fires and seeing my grandparents
[14:56:00] <RoanKattouw>	 stephanebisson: You could take https://phabricator.wikimedia.org/T112037 back from me
[14:56:08] <RoanKattouw>	 I never had a chance to work on it anyway
[14:56:38] <stephanebisson>	 sure, I'm so not surprised that this is broken
[14:56:54] <RoanKattouw>	 I didn't realize we had that feature
[14:57:00] <RoanKattouw>	 But I'm also completely unsurprised that it broke
[14:57:18] <RoanKattouw>	 BTW, do you know why https://gerrit.wikimedia.org/r/#/c/236870/8 is marked [WIP]?
[14:57:25] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Regression: Pre-fill broken - https://phabricator.wikimedia.org/T112037#1637445 (10SBisson) a:5Catrope>3SBisson
[14:57:28] <grrrit-wm>	 (03PS11) 10Paladox: Update extension registration system for MoodBar [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/223539 (https://phabricator.wikimedia.org/T87942) (owner: 10Niharika29)
[14:57:33] <RoanKattouw>	 You could review Moriel's work that, although she's off today anyway
[14:57:56] <grrrit-wm>	 (03CR) 10Paladox: [C: 031] Update extension registration system for MoodBar [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/223539 (https://phabricator.wikimedia.org/T87942) (owner: 10Niharika29)
[14:59:06] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1637453 (10Trizek-WMF) 5Open>3Resolved
[14:59:15] <grrrit-wm>	 (03PS1) 10Paladox: Remove i18n shim [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/238155 
[14:59:18] <stephanebisson>	 I thought this was merged already
[14:59:39] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update references migration to reflect production status [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238124 (https://phabricator.wikimedia.org/T111084) (owner: 10Matthias Mullie)
[15:00:58] <stephanebisson>	 RoanKattouw: I'll need to sync with Moriel about it
[15:01:10] <RoanKattouw>	 OK so that would have to wait until tomorrow then
[15:01:42] <stephanebisson>	 she's off only today? I don't see it in the calendar
[15:02:05] <RoanKattouw>	 She only requested it on Saturday, it was a bit last-minute
[15:02:07] <RoanKattouw>	 I'll add it
[15:02:19] <grrrit-wm>	 (03PS2) 10Paladox: Remove i18n shim [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/238155 
[15:02:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update references migration to reflect production status [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238124 (https://phabricator.wikimedia.org/T111084) (owner: 10Matthias Mullie)
[15:19:26] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This doesn't really address the source of the problem. The rounding errors etc don't come from the divs, they appear to come from the diff" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo)
[15:19:44] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] Don't load oojs-ui.styles on every page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238115 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[15:26:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load oojs-ui.styles on every page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238115 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[15:29:08] <grrrit-wm>	 (03PS1) 10Catrope: Don't load oojs-ui.styles on every page [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238160 (https://phabricator.wikimedia.org/T112401) 
[15:30:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Don't load oojs-ui.styles on every page [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238160 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[15:31:54] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web-Sprint-55-π: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1637602 (10phuedx) p:5Triage>3High
[15:33:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load oojs-ui.styles on every page [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238160 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[15:39:41] <RoanKattouw>	 Whoa WTF the notification badge gets bigger on hover in monobook
[15:40:47] <RoanKattouw>	 Because... Monobook. Sigh
[16:24:51] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, 10RESTBase: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#1637856 (10cscott) Note that CX and VisualEditor share very similar code...
[16:41:45] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, 10RESTBase: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#1637944 (10cscott) Also: I suspect the error message seen by the user is...
[16:44:39] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 3Reading-Web-Sprint-56-4, 5Patch-For-Review: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1637971 (10KLans_WMF)
[16:44:47] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1637975 (10DannyH) p:5Triage>3Normal
[16:46:27] <legoktm>	 RoanKattouw: good morning
[16:48:11] <grrrit-wm>	 (03PS1) 10Catrope: Use math to compute badge padding in nojs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238182 
[16:48:11] <RoanKattouw>	 Morning
[16:48:21] <legoktm>	 did you already deploy it?
[16:48:24] <RoanKattouw>	 Yeah
[16:48:26] <RoanKattouw>	 Bartosz merged it
[16:50:10] <legoktm>	 so we're still loading the CSS on every page, just not in the top queue?
[16:51:10] <RoanKattouw>	 Yeah, and only in JS mode
[16:51:28] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Use math to compute badge padding in nojs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238182 (owner: 10Catrope)
[16:51:48] <RoanKattouw_away>	 I discovered why the badge flash is so much worse in monobook BTW
[16:52:09] <RoanKattouw_away>	 Apex has asymmetrical margins around its labels (0.25em left, 0 right) whereas it's symmetrical in the mediawiki theme
[16:52:15] <legoktm>	 I don't see any flashing in monobook :/
[16:52:18] <RoanKattouw_away>	 I'll address that later today
[16:52:21] <legoktm>	 ok
[16:52:24] <RoanKattouw_away>	 I mean the width/height changes during load
[16:52:31] * RoanKattouw_away goes away to eat
[16:53:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use math to compute badge padding in nojs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238182 (owner: 10Catrope)
[17:02:57] <quiddity>	 dannyh, i'll be a few mins late. other meeting going long
[17:03:14] <dannyh>	 that's okay, Roan's late too :) -- I'm the only one here
[17:03:51] <RoanKattouw_away>	 Oh right Elena also has today off
[17:04:00] * RoanKattouw_away is back earlier than expected, just preparing now
[17:05:16] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1638064 (10DannyH)
[17:05:18] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1638062 (10DannyH) 5Open>3Resolved
[17:07:56] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: Move "Mark as resolved" up in the Flow dropdown menu - https://phabricator.wikimedia.org/T110083#1638082 (10DannyH) 5Open>3Resolved
[17:17:36] <wikibugs>	 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1638144 (10DannyH) 5Open>3Resolved
[17:18:26] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Logged out warning is un-dismissable - https://phabricator.wikimedia.org/T108836#1638155 (10DannyH)
[17:18:28] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 5WMF-deploy-2015-09-15_(1.26wmf23): Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1638154 (10DannyH) 5Open>3Resolved
[17:19:23] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: After clicking on 'Edit description',  Board  description is displayed empty while  its content loads - https://phabricator.wikimedia.org/T109493#1638164 (10DannyH) 5Open>3Resolved
[17:19:33] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Board description: VE icons are misplaced - https://phabricator.wikimedia.org/T112019#1638166 (10DannyH) 5Open>3Resolved
[17:19:55] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1638172 (10DannyH) 5Open>3Resolved
[17:20:09] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5WMF-deploy-2015-09-08_(1.26wmf22): Echo makes the border of h1#firstHeading too short - https://phabricator.wikimedia.org/T111628#1638177 (10DannyH) 5Open>3Resolved
[17:20:21] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Easy, 7I18n, and 2 others: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1638179 (10DannyH) 5Open>3Resolved
[17:21:17] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add Korean translation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237624 (owner: 10Revi)
[17:23:29] <RoanKattouw>	 dannyh: Oh BTW we need to figure out what's on the agenda for the team meeting tomorrow
[17:24:25] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 3Reading-Web-Sprint-56-Four Lions, 5Patch-For-Review: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1638192 (10Jdlrobson) See "[Web] Closing out sprint π" this was a small task to keep team members...
[17:25:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add Korean translation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237624 (owner: 10Revi)
[17:26:45] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Move "left a message on your talk page" Echo notification from Alerts to Messages - https://phabricator.wikimedia.org/T108760#1638202 (10DannyH) 5Open>3Resolved Closing the ticket,...
[17:28:02] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: When accessing talk page through echo, the yellow "new message" notification doesn't go away - https://phabricator.wikimedia.org/T107655#1638204 (10Legoktm) a:3Legoktm
[17:28:39] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 3 others: Fivefold increase in render-blocking CSS size for logged-in users - https://phabricator.wikimedia.org/T112401#1638209 (10Catrope) Patch was deployed at 16:12 UTC
[17:29:11] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: When accessing talk page through echo, the yellow "new message" notification doesn't go away - https://phabricator.wikimedia.org/T107655#1500627 (10Legoktm) I think this is a regression from {64bf3a12b514bb0f88d90e268f388495e2554278}. Previously the user_newtalk flag would...
[17:31:42] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 5WMF-deploy-2015-09-15_(1.26wmf23): [Regression] Editing upper post in nested thread opens all nested Replies - https://phabricator.wikimedia.org/T111987#1638218 (10DannyH) 5Open>3Resolved I double-checked in...
[17:31:47] <grrrit-wm>	 (03PS5) 10Catrope: Add a calculated min-height for the editor widget placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237005 (owner: 10Mooeypoo)
[17:31:58] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Add a calculated min-height for the editor widget placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237005 (owner: 10Mooeypoo)
[17:34:52] <grrrit-wm>	 (03PS1) 10Legoktm: Don't show orange alert if you are viewing your user talk page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238194 (https://phabricator.wikimedia.org/T107655) 
[17:35:23] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: When accessing talk page through echo, the yellow "new message" notification doesn't go away - https://phabricator.wikimedia.org/T107655#1638223 (10Legoktm)
[17:36:42] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: When accessing talk page through echo, the yellow "new message" notification doesn't go away until the next page view - https://phabricator.wikimedia.org/T107655#1638226 (10Legoktm)
[17:39:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add a calculated min-height for the editor widget placeholder [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237005 (owner: 10Mooeypoo)
[17:40:01] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, 10RESTBase: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#1638244 (10GWicke) > The VRS object perhaps should grow a method to retu...
[17:49:56] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638267 (10Bawolff) 3NEW
[17:52:34] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638287 (10Bawolff) Note, I just noticed it doesn't appear on enwiki or enwikinews. It might be a local script or even a gadget...
[17:53:16] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team, and 3 others: Fivefold increase in render-blocking CSS size for logged-in users - https://phabricator.wikimedia.org/T112401#1638289 (10ori) >>! In T112401#1638209, @Catrope wrote: > Patch was deployed at 16:12 UTC  Much better, bu...
[17:58:59] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638323 (10Legoktm) > Based on timing (It wasn't like this, this morning), I'd guess it might be related to https://gerrit.wikimedia.org/r/#/c/238160/ which was...
[18:00:55] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638340 (10Legoktm) Also, any tips/pointers on how to install FF 3.5?
[18:04:23] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638351 (10Bawolff) even with all my gadgets disabled (including default enabled gadgets), and user:Bawolff/common.js commented out, issue is still present.
[18:12:19] <grrrit-wm>	 (03PS1) 10Legoktm: Split out .mw-echo-alert styles back into a separate module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238204 
[18:12:41] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638401 (10Bawolff) Oh, I do have a bunch of errors (not sure why that isn't the first thing I looked at). Also, the top bar looks fine initially. Seems to get m...
[18:19:05] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638421 (10Legoktm) >>! In T112552#1638401, @Bawolff wrote: > Exception in module-execute in module ext.centralNotice.display: > TypeError: Object.defineProperty...
[18:22:32] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638436 (10Legoktm) >>! In T112552#1638421, @Legoktm wrote: >>>! In T112552#1638401, @Bawolff wrote: >> Exception in module-execute in module ext.centralNotice.d...
[18:29:21] <mlitn>	 meeting is done?
[18:29:54] <RoanKattouw>	 Yeah
[18:30:04] <RoanKattouw>	 Sorry :| you kept freezing/dropping
[18:30:08] <mlitn>	 thought so :)
[18:30:12] <mlitn>	 no that’s ok - I’m sorry
[18:30:32] <mlitn>	 internet’s been very unreliable last week
[18:30:39] <RoanKattouw>	 The last thing we talked about is the data dumps task, about how it hasn't been picked up yet
[18:30:47] <RoanKattouw>	 So it sounds like that'll be on the agenda for tomorrow's discussion meeting
[18:30:59] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1638479 (10Bawolff) I think the central notice thing is not related to causing this issue, as that error is on all sites, but things are only blowing up for me o...
[18:31:02] <RoanKattouw>	 But I did say (while you were freezing up again) that it was a task that has Matt/Matthias written all over it
[18:31:37] <mlitn>	 I can probably look at it, but so far other stuff (opt-in, reference tables, …) seemed more urgent :p
[18:31:47] <RoanKattouw>	 Yeah
[18:31:55] <RoanKattouw>	 That keeps happening
[18:31:58] <mlitn>	 but once those are done, I can probably pick it up
[18:32:05] <mlitn>	 I assume Matt’s in the same place, with 2 unbreak nows :p
[18:32:12] <RoanKattouw>	 Matt took on the links in topic titles bug, and he also keeps getting distracted with UBNs
[18:32:14] <RoanKattouw>	 Yeah exactly
[18:36:42] <grrrit-wm>	 (03CR) 10Umherirrender: [C: 032] Remove i18n shim [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/238155 (owner: 10Paladox)
[18:38:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove i18n shim [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/238155 (owner: 10Paladox)
[18:40:26] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, 10RESTBase: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#1632433 (10cscott)
[18:41:35] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow shouldn't assume Parsoid is source of all VRS errors - https://phabricator.wikimedia.org/T112566#1638539 (10cscott) 3NEW
[18:41:46] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow shouldn't assume Parsoid is source of all VRS errors - https://phabricator.wikimedia.org/T112566#1638549 (10cscott)
[18:41:50] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, 10RESTBase: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#1632433 (10cscott)
[18:43:09] <legoktm>	 https://twitter.com/WeAreWikipedia/status/643248770990387200
[18:48:19] <RoanKattouw>	 legoktm: Twitter is still down :(
[18:48:31] <RoanKattouw>	 Maybe just in Europe?
[18:48:43] <legoktm>	 works fine for me here
[18:48:53] <legoktm>	 anyways the tweet is
[18:49:09] <legoktm>	 I just added
[18:49:09] <legoktm>	 .oo-ui-icon-bell {display: none !important;}
[18:49:09] <legoktm>	 .oo-ui-icon-speechBubble {display: none !important;}
[18:49:09] <legoktm>	 to my global.css. @Wikimedia
[18:49:29] <RoanKattouw>	 Oh yeah did you see the person that added that to their CSS and then complained the buttons weren't the same size?
[18:49:42] <legoktm>	 haha yes
[18:50:18] <RoanKattouw>	 Yes it's ugly that the icons aren't exactly the same size, but if you apply display: none !important; to random elements, that's not a supported use case
[18:51:40] <legoktm>	 RoanKattouw: btw https://gerrit.wikimedia.org/r/238204 kills some more unneeded styles from all page views
[18:51:55] <legoktm>	 ori says there's still a significant increase: https://phabricator.wikimedia.org/T112401#1638289
[18:52:12] <RoanKattouw>	 Oh nice
[18:52:14] <RoanKattouw>	 Yeah I saw that
[18:52:22] <quiddity>	 dannyh, FYI: Enwiki has a new "anon personal toolbar".  Screenshot: http://i.imgur.com/oP3YjlF.png 
[18:52:22] <quiddity>	  Discussion: https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Add_toolbar_for_IPs   
[18:52:22] <quiddity>	  Code:  https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=680879030&oldid=669892964
[18:52:26] <RoanKattouw>	 I was writing a "I'll look later" response but now I think I'll just look
[18:52:48] <dannyh>	 oh! that's interesting. 
[18:53:34] <legoktm>	 the 'oojs-ui.styles.icons-alerts' module is 31.5KB
[18:53:48] <dannyh>	 will that work with Flow if the whole user talk namespace is Flow?
[18:55:05] <quiddity>	 yes. It's just a link to [[special:MyTalk]]
[18:57:32] <grrrit-wm>	 (03PS1) 10Legoktm: Only load nojs Special:Notifications styles on the special page [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238212 (https://phabricator.wikimedia.org/T112407) 
[19:10:10] <grrrit-wm>	 (03CR) 10JanZerebecki: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237005 (owner: 10Mooeypoo)
[19:20:52] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Only load nojs Special:Notifications styles on the special page [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238212 (https://phabricator.wikimedia.org/T112407) (owner: 10Legoktm)
[19:24:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only load nojs Special:Notifications styles on the special page [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238212 (https://phabricator.wikimedia.org/T112407) (owner: 10Legoktm)
[19:27:15] <jdlrobson>	 https://phabricator.wikimedia.org/T112571 < could this be Echo legoktm  mooey|away ?
[19:27:42] <legoktm>	 those specific modules? I don't think so
[19:28:02] <jdlrobson>	 seems like enableOOUI triggers that
[19:28:10] <jdlrobson>	 so I guess the question is what triggers that
[19:28:23] <legoktm>	 we're only loading 'oojs-ui.styles.icons-alerts'
[19:28:50] <legoktm>	 as of this morning's SWAT, we're no longer calling enableOOUI on every page
[19:28:58] <wikibugs>	 3Collaboration-Team-Current, 6WMF-Design-Research: Curation tools user interviews - https://phabricator.wikimedia.org/T112027#1638734 (10Capt_Swing)
[19:29:11] <jdlrobson>	 legoktm: so if i flush the cache they should go away legoktm  ?
[19:29:11] <wikibugs>	 3Collaboration-Team-Current, 6WMF-Design-Research: Curation tools user interviews {raven} - https://phabricator.wikimedia.org/T112027#1638738 (10Capt_Swing)
[19:30:01] <jdlrobson>	 mm seems like something else is calling enableOOUI then :/
[19:30:10] <legoktm>	 I think so
[19:30:21] <legoktm>	 are you using Echo master? is this in prod?
[19:30:39] <jdlrobson>	 in prod yeh
[19:30:44] <jdlrobson>	 https://en.m.wikipedia.org/wiki/Red-winged_fairywren
[19:30:48] <jdlrobson>	 do mw.loader.inspect()
[19:31:04] <legoktm>	 oh yes
[19:31:05] <jdlrobson>	 ext.echo.ui is loaded so I wondered if that was related
[19:31:08] <legoktm>	 we load oojs-ui on every page
[19:31:11] <legoktm>	 which pulls in those modules
[19:31:21] <legoktm>	 sorry, my head is in multiple places right now
[19:31:23] <jdlrobson>	 :-S should probably not do that on mobile
[19:31:46] <jdlrobson>	 especially given Echo is only activated when you open it
[19:32:22] <legoktm>	 we just finished discussing this in -perf ;)
[19:33:35] <jdlrobson>	 heh should i go over there
[19:34:56] * legoktm bbl for lunch
[19:52:53] <grrrit-wm>	 (03PS1) 10Catrope: Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238239 (https://phabricator.wikimedia.org/T112401) 
[19:57:08] <wikibugs>	 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1638870 (10Quiddity) @pginer-wmf Before I forget, here's a note, just in case this gets re-opened.  Here's a clearer additional rationale...
[20:19:24] <grrrit-wm>	 (03CR) 10Legoktm: "I don't see any icons in MonoBook..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238239 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[20:21:54] <grrrit-wm>	 (03PS2) 10Catrope: Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238239 (https://phabricator.wikimedia.org/T112401) 
[20:21:55] <RoanKattouw>	 legoktm: Whoops, fixed
[20:27:43] <legoktm>	 MatmaRex: could you take a look at https://gerrit.wikimedia.org/r/#/c/238239/ and make sure it's not a totally terrible idea?
[20:27:54] <legoktm>	 functionally it works fine
[20:30:03] <MatmaRex>	 legoktm: uhhh, probably sane. if you maintain it yourself
[20:30:16] <MatmaRex>	 legoktm: you might want to use ResourceLoaderImageModule rather than ResourceLoaderOOUIImageModule, which is itself a hack on top of a hack
[20:30:44] <RoanKattouw>	 Well yeah except I need JSON stuff to work
[20:30:51] <MatmaRex>	 and you don't need to shoehorn .json files coming from external source into ResourceLoader stuffs, you can write it sanely from the start
[20:30:56] <RoanKattouw>	 I considered that
[20:31:03] <RoanKattouw>	 Hmm maybe
[20:31:17] <RoanKattouw>	 I guess I don't *need* the JSON stuff, do I, cause it's my own JSON file
[20:31:22] <MatmaRex>	 although, hmm, you have the mediawiki/apex split
[20:31:54] <MatmaRex>	 okay, if you support that, then this might be the better way
[20:32:24] <legoktm>	 yeah, because MonoBook has black icons
[20:32:27] <RoanKattouw>	 I don't really need to support it
[20:32:37] <RoanKattouw>	 I could deliver identical CSS to both and it would still work
[20:32:44] <MatmaRex>	 indeed
[20:34:28] <MatmaRex>	 (you guys totally could dedicate a humanweek or two towards making this a bit better, when you're done unbreaknowing things)
[20:37:11] <MatmaRex>	 RoanKattouw: legoktm: do you want me to sign off on it or something, or are you okay with a verbal 'yeah this isn't entirely insane'?
[20:37:32] <legoktm>	 just informal/verbal
[20:38:36] <RoanKattouw>	 MatmaRex: One more thing
[20:38:43] <RoanKattouw>	 How sane is https://gerrit.wikimedia.org/r/238308 ?
[20:40:12] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238239 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[20:40:49] <MatmaRex>	 RoanKattouw: well, i guess it means you won't get any icons on your buttons and things by default? not sure if we want to do that
[20:40:58] <RoanKattouw>	 Yeah that part of it sucks
[20:41:07] <RoanKattouw>	 I had to go into a few extensions and make them load icons again
[20:41:19] <RoanKattouw>	 Longer term I guess we should trim the fat from that module
[20:41:54] <MatmaRex>	 RoanKattouw: i think what we really should do is trim down the icon set. we have too many of them, almost all unused, and a few duplicates (although mostly in the optional sets)
[20:42:09] <MatmaRex>	 but, you know, it's that humanweek or two i mentioned. :)
[20:42:09] <RoanKattouw>	 Yeah
[20:42:13] <RoanKattouw>	 Yes
[20:42:27] <MatmaRex>	 you also need to convince James_F to let you do that
[20:42:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238239 (https://phabricator.wikimedia.org/T112401) (owner: 10Catrope)
[20:43:07] <grrrit-wm>	 (03PS1) 10Legoktm: Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238310 (https://phabricator.wikimedia.org/T112401) 
[20:43:18] <James_F>	 RoanKattouw: Killing the core icon set is on the roadmap.
[20:43:29] <James_F>	 RoanKattouw: But it's lots of whining and moaning.
[20:43:46] <legoktm>	 RoanKattouw: and objections to me pushing that out now?
[20:44:48] <RoanKattouw>	 James_F: I audited all extensions that use any of those icons, and submitted (/am submitting) patches for all of them to load the core set explicitly
[20:45:12] <RoanKattouw>	 So that then the oojs-ui module can stop depending it, which reduces the (transitive) size of that module by a third
[20:45:21] <RoanKattouw>	 Does that sound somewhat sensible?
[20:45:40] <James_F>	 RoanKattouw: Eh. Maybe? Almost everything that depends on OOUI actually wants the icons too.
[20:45:49] <RoanKattouw>	 A surprising amount doesn't
[20:45:53] <James_F>	 RoanKattouw: Also, gadgets.
[20:45:59] <RoanKattouw>	 :S true
[20:45:59] <James_F>	 RoanKattouw: That's a pretty major breaking change.
[20:46:09] <James_F>	 (Not that that should stop us entirely.)
[20:46:23] <RoanKattouw>	 Alternatively, maybe we can trim that set a lot
[20:46:51] <legoktm>	 mwgrep for "OO.ui" has 16 results, 4 of which are testwiki
[20:47:22] <grrrit-wm>	 (03PS1) 10Sbisson: Preload new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238312 (https://phabricator.wikimedia.org/T112037) 
[20:47:47] <legoktm>	 41 in user space
[20:48:00] <RoanKattouw>	 41 out of 16?!
[20:48:01] <James_F>	 Yeah.
[20:48:08] <RoanKattouw>	 Oh or is it 16 in MW space
[20:48:11] <legoktm>	 er, 16 in MW, and 41 in user
[20:51:28] <legoktm>	 RoanKattouw: so...not objection to me deploying the icon one now?
[20:51:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Preload new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238312 (https://phabricator.wikimedia.org/T112037) (owner: 10Sbisson)
[20:53:11] <RoanKattouw>	 legoktm: The "Hack around..." one? Yeah that one's good
[20:53:17] <RoanKattouw>	 Although its impact isn't that large
[20:53:35] <RoanKattouw>	 I guess it does impact in early-loading CSS though
[20:55:26] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238310 (https://phabricator.wikimedia.org/T112401) (owner: 10Legoktm)
[20:55:41] * RoanKattouw audits the core icon set
[20:55:44] <RoanKattouw>	 "redo", cool story
[20:56:56] <grrrit-wm>	 (03PS2) 10Sbisson: Preload new topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238312 (https://phabricator.wikimedia.org/T112037) 
[20:58:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hack around OOUI's icon pack being too large by creating our own [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238310 (https://phabricator.wikimedia.org/T112401) (owner: 10Legoktm)
[21:00:45] <RoanKattouw>	 OK so with trivial trimming I can get it from 125K to 41K
[21:02:09] <James_F>	 RoanKattouw: Trivial?
[21:02:28] <RoanKattouw>	 I grepped for "is this icon used in OOUI itself"
[21:02:32] <RoanKattouw>	 (documentation doesn't count)
[21:03:38] <James_F>	 RoanKattouw: Err.
[21:03:57] <James_F>	 It's a library. I'd be surprised if half of the features of OOUI are used in OOUI.
[21:04:25] <grrrit-wm>	 (03PS1) 10Catrope: Update for I51f7966add: load oojs-ui.styles.icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238318 
[21:04:31] <RoanKattouw>	 Well sure but does that mean they have to be in the core set
[21:04:46] <James_F>	 RoanKattouw: … yes?
[21:05:00] <James_F>	 The 'core set' was the only set.
[21:05:09] <James_F>	 Moving an icon is a breaking change, regardless of where it's used.
[21:05:22] <James_F>	 Because users of the library will now have to depend on the new set as well.
[21:05:24] <RoanKattouw>	 Yeah that's true :(
[21:05:30] <James_F>	 Hence the breaking change-ness.
[21:13:52] <grrrit-wm>	 (03PS1) 10Catrope: Don't load unused Echo JS/CSS on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238322 (https://phabricator.wikimedia.org/T112571) 
[21:35:09] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1639309 (10Quiddity) Semi-related issue (to the Echo icons in general) at {T112494}.  (This seems like a semi-reasonable task to note it in. :-)
[21:36:12] <thedj>	 https://phab.wmfusercontent.org/file/data/ez7ivxaoa3ilcj6ofsyo/PHID-FILE-lk6frwpfrcmadxwiwp7g/ea2ijl7nd47fssus/Screen_Shot_2015-09-14_at_23.31.55.png
[21:36:29] <thedj>	 that's on commons, which i hadn't visited for a while I suspect.
[21:37:37] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 7WorkType-Maintenance: The ooui-UI echo-icons looks like they are dfferent size - https://phabricator.wikimedia.org/T112494#1639314 (10Legoktm) 5Open>3Invalid a:3Legoktm That's not surprising at all, if you have custom CSS to hide certain elements of th...
[21:38:04] <legoktm>	 thedj: "You do not have permission to view this object."
[21:40:58] <thedj>	 https://phabricator.wikimedia.org/F2604326
[21:42:00] <thedj>	 oh, it's also reported on it's village pump
[21:42:26] <thedj>	 https://commons.wikimedia.org/wiki/Commons:Village_pump#HTML_rendering_issues_with_notifications_in_toolbar
[21:44:14] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Performance: Flow JS loading / defered loading is very slow - https://phabricator.wikimedia.org/T108313#1639343 (10Quiddity) >>! In T108313#1636367, @Addshore wrote: > One improvement here for the history pages could be rather than grey out / disable the whole page only...
[21:48:39] <legoktm>	 thedj: ok, bawolff reported something similar, but he thought it was FF 3.5 related
[21:49:51] <legoktm>	 I see syntax errors from https://commons.wikimedia.org/w/index.php?title=MediaWiki:LAPI.js&action=raw&ctype=text/javascript
[21:50:27] <legoktm>	 thedj: are you able to reproduce?
[21:50:28] <legoktm>	 I'm not...
[21:52:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons on some older browsers (firefox 3.5) - https://phabricator.wikimedia.org/T112552#1639367 (10Legoktm) p:5Triage>3Unbreak! @thedj and some other users are also seeing this: https://commons.wikimedia.org/wiki/Commons:Village_pump#HTML_render...
[21:52:18] <legoktm>	 RoanKattouw: ^^
[21:52:29] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons - https://phabricator.wikimedia.org/T112552#1639370 (10Legoktm)
[21:52:53] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons - https://phabricator.wikimedia.org/T112552#1638267 (10Legoktm)
[21:52:54] <thedj>	 legoktm: i have it like that on Safari. Have not tried bypassing caching yet.
[21:53:05] <thedj>	 i suspect if i do that, the problem will be gone
[21:53:09] <legoktm>	 hrm.
[21:53:11] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Rename page in ruwiki - https://phabricator.wikimedia.org/T111918#1639378 (10DannyH) Okay, I moved it. Sorry for my mistake.
[21:53:12] <RoanKattouw>	 whoa wtf
[21:53:18] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Rename page in ruwiki - https://phabricator.wikimedia.org/T111918#1639380 (10DannyH) 5Open>3Resolved
[21:53:21] * legoktm opens up safari
[21:53:52] <thedj>	 or i'm missing modules or something of course
[21:54:00] <RoanKattouw>	 thedj: Can you repro in incognito?
[21:54:14] <legoktm>	 I can repro
[21:54:16] <legoktm>	 in Safari
[21:54:24] <RoanKattouw>	 I guess you can't exactly be logged out
[21:54:27] <thedj>	 hmm bypassing cache does not solve it 
[21:55:15] <legoktm>	 looks fine with &debug=true
[21:57:14] <thedj>	 note that it's the indicator of the old Echo dropdown
[21:57:28] <RoanKattouw>	 Hmm it looks like it happens during load?
[21:58:15] <thedj>	 yes.
[21:58:21] <legoktm>	 yeah, disabling JS makes it look fine
[21:59:07] <thedj>	 i'm missing oo-ui styles i think...
[22:00:10] <RoanKattouw>	 It's not loading the CSS that styles oo-ui-element-hidden, for one thing
[22:00:12] <RoanKattouw>	 That's weird
[22:00:26] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] Don't load unused Echo JS/CSS on mobile (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238322 (https://phabricator.wikimedia.org/T112571) (owner: 10Catrope)
[22:03:28] <legoktm>	 If I type `mw.loader.inspect()` into the console, everything works as expected.
[22:04:08] <legoktm>	 like, the elements go back to their proper position
[22:04:09] <thedj>	 Error: SyntaxError: DOM Exception 12
[22:04:10] <thedj>	 Error: SyntaxError: DOM Exception 12
[22:04:13] <thedj>	 on the console.
[22:04:18] <thedj>	 if i do the inspect()
[22:04:26] <legoktm>	 I only see those if I call inspect() a second time
[22:04:42] <RoanKattouw>	 Hmm I wonder if the CSS loads but loads too late
[22:04:44] <thedj>	 for me it was on the first
[22:05:02] <legoktm>	 wtf
[22:05:42] <RoanKattouw>	 Yeah I get the error on the first
[22:06:45] <thedj>	 inside markModulesReady
[22:06:52] <thedj>	 -s
[22:07:30] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo looks messed up on commons - https://phabricator.wikimedia.org/T112552#1639424 (10RP88) Note that I and others are seeing rendering issues with the the notification icons on Commons in Safari which does support Object.defineProperty.
[22:09:42] <thedj>	 it's not a gadget at least. I disabled everything, and the problem is still there
[22:10:59] <legoktm>	 it is something specific to Commons though
[22:11:09] <legoktm>	 en.wp works fine with Safari
[22:13:07] <RoanKattouw>	 I think maybe it might be related to the code that loads CSS into <style> tags
[22:17:28] <grrrit-wm>	 (03CR) 10Jdlrobson: "(also please make sure this goes about on the next train :))" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238322 (https://phabricator.wikimedia.org/T112571) (owner: 10Catrope)
[22:18:01] <thedj>	 RoanKattouw: invalid css in Common.css or something ?
[22:18:03] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Echo looks messed up on commons - https://phabricator.wikimedia.org/T112552#1639450 (10AndyRussG) This [[ https://gerrit.wikimedia.org/r/238326 | patch  ]] specifically fixes the Object.defineProperty issue in CentralNotice.
[22:18:17] <RoanKattouw>	 Hmm perhaps
[22:18:17] <thedj>	 ah WLM notice ?
[22:18:21] <RoanKattouw>	 The error comes from auditSelectors
[22:19:07] <RoanKattouw>	 Which tries to call querySelector() on what appears to be an invalid selector
[22:21:43] <thedj>	 body.page-Commons:Wiki_Loves_Monuments_upload.action-view
[22:21:52] <RoanKattouw>	 Ooh maybe
[22:22:01] <thedj>	 that's in Vector.css
[22:22:11] <RoanKattouw>	 I found what inspect() crashes on
[22:22:49] <legoktm>	 the : should be an underscore right?
[22:23:16] <thedj>	 page-Commons_Wiki_Loves_Monuments_upload
[22:23:17] <thedj>	 yup
[22:23:39] <RoanKattouw>	 .oo-ui-textInputWidget input[type="search"]::-webkit-search-decoration, .oo-ui-textInputWidget input[type="search"]::-webkit-search-cancel-button, .oo-ui-textInputWidget input[type="search"]::-webkit-search-results-button, .oo-ui-textInputWidget input[type="search"]::-webkit-search-results-decoration
[22:25:42] <thedj>	 oh come... stupid apple
[22:26:56] <RoanKattouw>	 But yes, yours is invalid as well
[22:27:05] <RoanKattouw>	 document.querySelector('body.page-Commons:Wiki_Loves_Monuments_upload.action-view') throws DOM Exception 12
[22:27:36] <RoanKattouw>	 And for .oo-ui-textInputWidget input[type="search"]::-webkit-search-decoration too
[22:28:31] <legoktm>	 so because of the last one the styles aren't finishing loading?
[22:28:40] <RoanKattouw>	 Oooh probably
[22:28:58] <RoanKattouw>	 Well it works on non-Commons wikis
[22:29:08] <RoanKattouw>	 So it's probably the WLM thing that triggers it
[22:29:15] <RoanKattouw>	 But the ::-webkit-blah thing can't be good either
[22:29:24] <thedj>	 lemme throw that in #webkit
[22:32:10] <RoanKattouw>	 https://commons.wikimedia.org/w/index.php?title=MediaWiki%3AVector.css&type=revision&diff=171972596&oldid=117053483
[22:32:27] <thedj>	 hmm, maybe you cant queryselect shadow dom ?
[22:33:15] <RoanKattouw>	 That fixes it for me
[22:33:26] <RoanKattouw>	 My Safari instance on CBT now loads Commons with a functional notifications flyout
[22:33:47] <thedj>	 Throws a SYNTAX_ERR exception if the specified group of selectors is invalid.
[22:33:54] <thedj>	 CSS Pseudo-elements will never return any elements, as specified in the Selectors API
[22:33:59] <legoktm>	 nope, still broken for me
[22:34:02] <RoanKattouw>	 Argh and now it doesn't
[22:36:33] <RoanKattouw>	 Yeah it's still broken for both of my accounts :S
[22:37:17] <RoanKattouw>	 But mw.loader.inspect() does fix it as you guys noticed before
[22:42:06] <thedj>	 i really have to go to bed now. nite ppl
[22:42:45] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 5WMF-deploy-2015-09-15_(1.26wmf23): Special:Notifications has rendering issues on mobile - https://phabricator.wikimedia.org/T112191#1639551 (10Jdlrobson)
[22:43:11] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Missing 'View changes' for entires on User talk pages with Flow enabled - https://phabricator.wikimedia.org/T112353#1639553 (10DannyH) Yeah, this is working as designed. We've talked about page-level diffs, but haven't built it yet -- it's something that we could do wheneve...
[22:43:20] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Missing 'View changes' for entires on User talk pages with Flow enabled - https://phabricator.wikimedia.org/T112353#1639555 (10DannyH)
[22:43:22] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 5WMF-deploy-2015-09-15_(1.26wmf23): Special:Notifications has rendering issues on mobile - https://phabricator.wikimedia.org/T112191#1628451 (10Jdlrobson) Misleading patch hasn't fixed this problem. Echo team please let me know if you need help resolving this.
[22:43:43] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 3Reading-Web-Sprint-56-Four Lions, 5Patch-For-Review: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1639558 (10Jdlrobson) 5Open>3Resolved Looks good. Still issues in Echo on mobile but that's co...
[22:44:47] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Missing 'View changes' for entire User talk pages with Flow enabled (page-level diff) - https://phabricator.wikimedia.org/T112353#1639566 (10DannyH)
[22:45:54] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Easy, 7I18n, and 3 others: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1639567 (10DannyH)
[22:46:25] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Everytime I click on Echo toolbar icon, a network request is generated, even while closing - https://phabricator.wikimedia.org/T111667#1639568 (10DannyH)
[22:46:36] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: Board description: VE icons are misplaced - https://phabricator.wikimedia.org/T112019#1639569 (10DannyH)
[22:46:53] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: [Regression] Editing upper post in nested thread opens all nested Replies - https://phabricator.wikimedia.org/T111987#1639572 (10DannyH)
[22:47:03] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5Patch-For-Review, and 2 others: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1639573 (10DannyH)
[22:47:06] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Echo makes the border of h1#firstHeading too short - https://phabricator.wikimedia.org/T111628#1639574 (10DannyH)
[22:48:04] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, and 2 others: Flaky test "ext.flow: mediawiki.ui.enhance Forms with required fields" - https://phabricator.wikimedia.org/T111459#1639577 (10DannyH)
[22:48:08] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: Echo waits to show you messages on second load - https://phabricator.wikimedia.org/T112186#1639578 (10DannyH)
[22:48:20] <wikibugs>	 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Internationalization, 7I18n, and 3 others: Fix unsanitized message in PageTriage - https://phabricator.wikimedia.org/T112469#1639579 (10DannyH)
[22:48:32] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/f... - https://phabricator.wikimedia.org/T111771#1639584
[22:49:07] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Pre-fill broken - https://phabricator.wikimedia.org/T112037#1639585 (10DannyH)
[22:49:14] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: When accessing talk page through echo, the yellow "new message" notification doesn't go away until the next page view - https://phabricator.wikimedia.org/T107655#1639586 (10DannyH)
[22:49:20] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1639587 (10DannyH)
[22:49:25] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Categories box is misaligned on Flow pages? - https://phabricator.wikimedia.org/T111110#1639588 (10DannyH)
[22:50:03] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1639593 (10DannyH)
[22:50:07] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10WMF-Server-Backports, 5Patch-For-Review, 7WorkType-NewFunctionality: History pagination does not work properly - https://phabricator.wikimedia.org/T112230#1639594 (10DannyH)
[22:50:15] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 3 others: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1639595 (10DannyH)
[22:51:11] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1639598 (10DannyH)
[22:51:20] <wikibugs>	 3Collaboration-Team-Current, 7WorkType-Maintenance: Allow cross-wiki target for MediaWiki's feedback tool - https://phabricator.wikimedia.org/T111590#1639599 (10DannyH)
[22:51:28] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Undo in Flow, mis-converts into VE-mode - https://phabricator.wikimedia.org/T112338#1639600 (10DannyH)
[22:51:37] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, and 2 others: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one (main) - https://phabricator.wikimedia.org/T107108#1639601 (10D...
[22:51:39] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1639602 (10DannyH)
[22:54:34] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1639616 (10DannyH) Has this been merged? I just tried it on Beta -- opt-in works, but op...
[23:05:16] <legoktm>	 RoanKattouw: http://i.imgur.com/B8CGqKc.png via OOUI PHP :D
[23:05:59] <RoanKattouw>	 Sweet!
[23:06:12] <RoanKattouw>	 Did you take a sledgehammer to onPersonalUrls?
[23:06:41] <legoktm>	 no, that would have been a B/C mess :/
[23:06:53] <legoktm>	 I added an optional 'widget' parameter that overrides everything else
[23:07:33] <legoktm>	 I need to play with it a bit more though, it currently FOUCs worse than what we have right now
[23:07:48] <legoktm>	 I think I'm just missing some classes
[23:11:41] <jdlrobson>	 RoanKattouw: any objections to +2ing https://gerrit.wikimedia.org/r/#/c/238322/ or are you exploring other solutions?
[23:12:40] <RoanKattouw>	 Go for it
[23:12:50] <RoanKattouw>	 Your suggestions are good
[23:13:01] <RoanKattouw>	 But it's past 1am so I should go to bed
[23:13:22] <RoanKattouw>	 You could also amend my patch to implement your suggestions and then I can +2 in the morning (European time)
[23:13:55] <jdlrobson>	 RoanKattouw: sounds good. Right now I just want to make sure a fix rides the train
[23:14:13] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Suggestions can be fixed/discussed further in a follow up." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238322 (https://phabricator.wikimedia.org/T112571) (owner: 10Catrope)
[23:16:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load unused Echo JS/CSS on mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238322 (https://phabricator.wikimedia.org/T112571) (owner: 10Catrope)