[02:33:57] 6Collaboration-Team-Backlog, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1634640 (10aaron) Is this on anyone's plate to work on. The use of merge() is not just slow (like master queries) but totally broken for multi DC MW. I wonder if it would... [03:59:00] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1634662 (10Legoktm) Nearly everything in master has already been backported to 1.26wmf22. [04:05:00] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634664 (10Legoktm) From #wikimedia-dev yesterday: ``` [17:15:58] MatmaRex: do you see any way around https://phabricator.wikimedia.org/T112218#1630159 be... [04:10:17] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634666 (10Mooeypoo) I was actually thinking on similar lines. We can recreate only the button part of the widget and make its main element and then leave the re... [04:14:59] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634667 (10Quiddity) > > There is a secondary problem, however. The button will still behave differently between the no-js and js versions. In the JS versions clicki... [04:16:05] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634668 (10Legoktm) >>! In T112218#1634666, @Mooeypoo wrote: > Do we want to make this difference clear? If so, do we not still want to leave the semi-transparency o... [04:17:05] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634669 (10Mooeypoo) >>! In T112218#1634667, @Quiddity wrote: >> >> There is a secondary problem, however. The button will still behave > differently between the no-... [04:20:33] (03PS1) 10Legoktm: Only load nojs Special:Notifications styles on the special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237968 (https://phabricator.wikimedia.org/T112407) [04:21:11] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 5Patch-For-Review, 7Performance: nojs/mw.echo.special.less styles should only be loaded on Special:Notifications - https://phabricator.wikimedia.org/T112407#1634673 (10Legoktm) a:3Legoktm [04:22:23] (03CR) 10jenkins-bot: [V: 04-1] Only load nojs Special:Notifications styles on the special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237968 (https://phabricator.wikimedia.org/T112407) (owner: 10Legoktm) [04:22:33] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634674 (10Mooeypoo) >>! In T112218#1634668, @Legoktm wrote: >>>! In T112218#1634666, @Mooeypoo wrote: >> Do we want to make this difference clear? If so, do we not... [04:23:12] (03PS2) 10Legoktm: Only load nojs Special:Notifications styles on the special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237968 (https://phabricator.wikimedia.org/T112407) [05:04:07] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons change size slightly during load - https://phabricator.wikimedia.org/T112218#1634679 (10Quiddity) I'd err on the side of non-distraction. [08:29:17] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1634936 (10eranroz) Ideally the elements should be created in backend side and not in client side, and then OOUI should bind to those elements on page load (e.g give... [10:53:31] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10MassAction, 10MediaWiki-Internationalization, and 9 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#1635077 (10Nemo_bis) [15:08:41] 6Collaboration-Team-Backlog, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1635328 (10EBernhardson) Stripping out the caching layer is probably the easiest way to go about this, and tbh i don't think the caching layer in Flow ended up being incre... [15:36:06] 6Collaboration-Team-Backlog, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1635355 (10Mattflaschen) >>! In T94029#1634640, @aaron wrote: > Is this on anyone's plate to work on. The use of merge() is not just slow (like master queries) but totally... [15:46:18] (03CR) 10Mattflaschen: [C: 032] Only load nojs Special:Notifications styles on the special page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237968 (https://phabricator.wikimedia.org/T112407) (owner: 10Legoktm) [15:47:11] 3Collaboration-Team-Current, 10Echo, 7Easy, 5Patch-For-Review, 7Performance: nojs/mw.echo.special.less styles should only be loaded on Special:Notifications - https://phabricator.wikimedia.org/T112407#1635363 (10Mattflaschen) [15:48:39] (03Merged) 10jenkins-bot: Only load nojs Special:Notifications styles on the special page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237968 (https://phabricator.wikimedia.org/T112407) (owner: 10Legoktm) [16:18:21] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Internationalization, 7I18n: Fix unescaped message in PageTriage - https://phabricator.wikimedia.org/T112469#1635391 (10Mattflaschen) 3NEW [16:48:30] (03PS1) 10Mattflaschen: Fix unsanitized message [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/238000 (https://phabricator.wikimedia.org/T112469) [16:49:42] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Internationalization, 7I18n, 5Patch-For-Review: Fix unescaped message in PageTriage - https://phabricator.wikimedia.org/T112469#1635450 (10Mattflaschen) a:3Mattflaschen [16:50:32] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Internationalization, 7I18n, 5Patch-For-Review: Fix unsanitized message in PageTriage - https://phabricator.wikimedia.org/T112469#1635453 (10Mattflaschen) [17:41:03] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1635568 (10Huji) 3NEW [17:41:25] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1635576 (10Huji) [18:48:44] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one button on personal bar - https://phabricator.wikimedia.org/T111871#1635678 (10Paladox) [19:15:54] (03CR) 10Mooeypoo: [C: 04-2] "Stalled on product decision and on a potential alternative." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237540 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [19:17:42] (03CR) 10Mooeypoo: [C: 032] Fix vertical alignment of 'Mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237527 (owner: 10Esanders) [19:19:37] (03Merged) 10jenkins-bot: Fix vertical alignment of 'Mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237527 (owner: 10Esanders) [19:39:53] (03CR) 10Alex Monk: [C: 032] Fix unsanitized message [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/238000 (https://phabricator.wikimedia.org/T112469) (owner: 10Mattflaschen) [19:40:17] (03Merged) 10jenkins-bot: Fix unsanitized message [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/238000 (https://phabricator.wikimedia.org/T112469) (owner: 10Mattflaschen) [19:53:10] MatmaRex, you happen to be around despite the fact it's a weekend? [19:53:18] mostly [19:53:31] (03PS1) 10Mooeypoo: [wip] Get the button out of the
widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [19:53:34] I started working on that ^^ [19:54:04] but I'm running into annoying issues. First, the stupid icon won't show up, and I don't nderstant why. When I inspect, it says it should be there (background-image has the embedded correct image! wtf) [19:54:23] second, meh, since I move the button outside of the
of the widget, the popup now isn't anchored to it [19:54:49] I checked and popup widget has anchor config, but that seems to just be a boolean for whether to show it or not. Any easy way to change the *element* that the popup is anchored to? [19:55:06] say, instead of it going by its div, go by the parent
  • maybe ? [19:55:50] MatmaRex, if you're busy don't worry about it, I'm posting these questions as a general thing and you can answer after the weekend, I think that can definitely wait. I just got annoyed with the icon mostly. [19:57:13] I'm going to have to bring back the unseen/unread classes to the a element itself, too. meh. [19:58:30] mooeypoo: the CSS class oo-ui-iconElement has to be set on some parent of the actual icon (oo-ui-iconElement-icon) for it to appear, probably. it's usually set on $element [19:58:40] meh. [19:58:51] I'll have to set it on the parent, then? [19:59:06] This is such a hack... but there doesn't seem to be a better way to do it [19:59:21] hmm [19:59:42] I'm going to have to bring up the oo-ui-flaggedElement classes too [20:00:09] mooeypoo: yeah, this looks like a huge pain. hmm [20:00:19] MatmaRex, not sure if I have much other choice, though. [20:00:34] Other than rewriting the personal tools to allow OOUI widgets [20:00:39] which... is a painer pain probably [20:01:24] mooeypoo: since, as far as i can tell, you're basically trying to replicate an IconWidget on top of a PopupButtonWidget… why not make NotificationBadgeWidget inherit from IconWidget, and mix in PopupElement for the popup bits? PopupButtonWidget is just a few lines of code bridging ButtonWidget and PopupElement, you could put that in your widget [20:01:44] yeah maybe so [20:01:53] But the button still has stuff that's on top [20:02:02] like, flaggedElement is on the
  • [20:04:00] MatmaRex, no the part is only the button. The popup needs to be a sibling to it, it can't be under it [20:04:10] i wonder what would happen if you mixed in ButtonElement, and set { $button: this.$element } [20:04:28] MatmaRex, but again then I'm stuck with being a parent to the popup [20:04:36] oh. hmm [20:04:44] it has to be a sibling to it, otherwise the entire popup would be clickable in a nasty way [20:04:57] yeah. true [20:05:02] I think that as convoluted as it is, making a widget for the entire
  • might be my best bet [20:05:09] the just replacing the current
  • with the new one [20:05:31] i can then attach all my necessary oo-ui-buttonElement and flaggedElement and all those into the
  • directly [20:05:39] It's cringe-worthy a bit, but.... [20:05:47] that actually sounds fairly reasonable, heh [20:05:56] hm [20:06:19] mooeypoo: or you could try putting that popup somewhere entirely else in the DOM. there's an old Echo bug asking for that, even [20:06:39] Why? [20:07:02] We're gaining automatical adjustment of the placement without too much calculation if it's there [20:07:12] If they share the same parent, that is [20:08:40] various things don't expect huge popups inside #p-personal, there were some Modern skin issues related to that in the past [20:09:19] oh, i found the bug: https://phabricator.wikimedia.org/T49993 apparently at least one screen-reader user would prefer it to be that way, too [20:09:40] anyway, just something to consider. your
  • solution sounds fairly reasonable [20:09:56] hm [20:10:19] Since this is something everyone's complainign about, I'll start with the
  • and we can adjust the placement of the popup later. [20:10:43] 6Collaboration-Team-Backlog, 10Echo, 7Accessibility: Echo: placement of notifications flyout in DOM (HTML) makes it hard for screen-reader users to access - https://phabricator.wikimedia.org/T49993#1635772 (10matmarex) [20:13:51] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1635777 (10Aklapper) With which browser, which skin, which website does this happen? [20:45:16] 6Collaboration-Team-Backlog, 10Echo: Enable the option to thank users for log entrys - https://phabricator.wikimedia.org/T112483#1635798 (10Luke081515) 3NEW [20:46:18] 6Collaboration-Team-Backlog, 10Thanks: Enable the option to thank users for log entrys - https://phabricator.wikimedia.org/T112483#1635807 (10Luke081515) [20:48:37] 6Collaboration-Team-Backlog, 10Thanks: Enable the option to thank users for log entrys - https://phabricator.wikimedia.org/T112483#1635817 (10Luke081515) [20:48:39] 6Collaboration-Team-Backlog, 10Thanks: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#1635818 (10Luke081515) [20:50:51] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1635824 (10Mooeypoo) Clicking the notification should take you to the actual message. Once that page with the message is loaded, the notification is marked as... [20:54:31] (03PS2) 10Mooeypoo: [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [20:54:48] MatmaRex, ^^ an extreme WIP [20:55:02] but it's a start. I htink i have a few of the classes I need to put up in the li parent? The icons aren't showing [20:55:48] Actually... crap. I don't need the icon elements if I want to preserve the same styling. The php piece attaches the icon to the background of the
  • itself. [20:55:52] err itself i mean [20:56:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [21:13:52] (03PS3) 10Mooeypoo: [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) [21:15:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Replace entire
  • element to produce button and popup separately [extensions/Echo] - 10https://gerrit.wikimedia.org/r/238017 (https://phabricator.wikimedia.org/T112218) (owner: 10Mooeypoo) [21:21:06] 3Collaboration-Team-Current, 10Echo, 6Editing-Department, 6Performance-Team: Fivefold increase in render-blocking CSS size for logged-in users - https://phabricator.wikimedia.org/T112401#1635867 (10ori) Are there any objections to a temporary revert? [21:34:23] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 3 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1635874 (10Tgr) This can be controlled by the `section` [[https://www.mediawiki.org/wiki/Echo_(Notifications)/De... [22:24:59] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1635889 (10Huji) >>! In T112477#1635777, @Aklapper wrote: > With which browser, which skin, which website does this happen? With Firefox on Vector, as tested... [23:53:04] (03CR) 10Legoktm: Only load nojs Special:Notifications styles on the special page (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237968 (https://phabricator.wikimedia.org/T112407) (owner: 10Legoktm) [23:53:10] 3Collaboration-Team-Current, 10Echo, 7Easy, 5Patch-For-Review, and 2 others: nojs/mw.echo.special.less styles should only be loaded on Special:Notifications - https://phabricator.wikimedia.org/T112407#1635947 (10Legoktm) 5Open>3Resolved