[00:02:01] 3Collaboration-Team-Current, 10Flow, 7Easy, 7I18n, and 2 others: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1623244 (10Etonkovidova) Checked in betalabs - on protected Flow pages the generic message 'Blocked' is displayed. Some things to consider: - The mes... [00:56:21] (03PS5) 10Mooeypoo: [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:56:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:57:32] (03PS6) 10Mooeypoo: [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:57:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:59:12] (03PS7) 10Mooeypoo: [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:59:42] (03PS2) 10Jforrester: build: Enable mediawiki-codesniffer and make pass [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 [01:05:03] (03PS3) 10Jforrester: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232423 [01:38:02] 3Collaboration-Team-Current, 10Flow, 7Regression: Pre-fill broken - https://phabricator.wikimedia.org/T112037#1623393 (10Mattflaschen) 3NEW [01:44:11] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1599565 (10Mattflaschen) [01:44:13] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 3 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1623420 (10Mattflaschen) [01:45:04] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1623429 (10Mattflaschen) p:5Triage>3High [04:26:55] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Wikimedia-log-errors: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1623504 (10Mattflaschen) [04:30:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Wikimedia-log-errors: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1623506 (10Mattflaschen) Added proper debugging information. [07:29:12] 6Collaboration-Team-Backlog, 10Flow, 10Thanks: there's no way to thank for writing a Flow topic summary - https://phabricator.wikimedia.org/T93520#1623717 (10QuimGil) Writing a topic... and also editing it? For what is worth, this feature has been mentioned at https://ca.wikipedia.org/wiki/Tema:Sokzwewotxo... [07:54:51] 6Collaboration-Team-Backlog, 10Flow: Rename page in ruwiki - https://phabricator.wikimedia.org/T111918#1623754 (10Sunpriat) 5Resolved>3Open [07:57:14] 6Collaboration-Team-Backlog, 10Flow: Rename page in ruwiki - https://phabricator.wikimedia.org/T111918#1623755 (10Sunpriat) @DannyH, https://ru.wikipedia.org/wiki/Википедия:Обсуждение_Википедии:Поток vs https://ru.wikipedia.org/wiki/Обсуждение_Википедии:Поток ( must be namespase:/Обсуждение_Википедии name:Поток) [09:43:49] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1624235 (10Trizek-WMF) On [[https://fr.wikipedia.org/w/index.php?title=Sujet:Snqg3qewtptldpwm&action=history|this conversation]], I was not able to see th... [10:20:03] (03PS1) 10Matthias Mullie: Fix toggling Flow to false in BetaFeatures (opt-out) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237350 (https://phabricator.wikimedia.org/T111830) [10:20:59] 3Collaboration-Team-Current, 10Flow, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1624355 (10matthiasmullie) a:3matthiasmullie [12:11:44] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization: OOUI PopupWidgets don't have drop shadows in the MediaWiki theme - https://phabricator.wikimedia.org/T111889#1624866 (10Pginer-WMF) Thanks for the clarifications, @violetto! [12:30:05] legoktm: when did the alert split go to prod? [14:10:13] 6Collaboration-Team-Backlog, 10Flow: Mark resolved topics on the Table of Contents - https://phabricator.wikimedia.org/T106410#1625297 (10Trizek-WMF) Is that enough, especially concerning accessibility? I don't see shades of grey, and it is only when I've changed my computer (with better contrast that I've not... [14:27:33] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1625374 (10Mattflaschen) >>! In T111778#1624235, @Trizek-WMF wrote: > Translation is already accurate on the interface. I haven't been attentive, sorry.... [14:42:44] Morning, everyone. [14:48:41] hey matt_flaschen when did the notification split happen ? [14:50:03] matanya, first production branch with it is wmf/1.26wmf22. Made it to MediaWiki.org on Tuesday, will make it to Wikipedia today. [14:50:24] matt_flaschen: it is on commons [14:50:36] is that part of mediawiki group ? [14:50:48] matanya, no. Made it to all non-Wikipedia yesterday: https://www.mediawiki.org/wiki/MediaWiki_1.26/Roadmap [14:50:57] oh, ok [14:51:02] i really like it [14:51:18] 6Collaboration-Team-Backlog, 10Echo: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1625508 (10Nemo_bis) 3NEW [14:51:19] Glad to hear it. :) ^ mooey|away [14:51:20] thanks for this neat feature. would love to see it with my flow userpage on wikipedia [14:53:28] 6Collaboration-Team-Backlog, 10Echo: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1625528 (10Nemo_bis) [14:53:29] 6Collaboration-Team-Backlog, 10Echo: Echo flyout icon flashes color change from white to black in MonoBook skin - https://phabricator.wikimedia.org/T111821#1625529 (10Nemo_bis) [14:54:01] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1625531 (10Trizek-WMF) Updated on TranslateWiki. Thanks a lot for your patience, @Mattflaschen! [15:04:02] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1625595 (10jcrespo) I applied the change on officewiki, but I had to revert the change o... [15:04:29] 6Collaboration-Team-Backlog, 10Echo: Re-merge the split Echo icons if I disable Flow mentions - https://phabricator.wikimedia.org/T112107#1625598 (10Nemo_bis) 3NEW [15:04:42] 6Collaboration-Team-Backlog, 10Echo: Re-merge the split Echo icons if I disable Flow mentions - https://phabricator.wikimedia.org/T112107#1625608 (10Nemo_bis) [15:06:13] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1625617 (10Mattflaschen) >>! In T111778#1625531, @Trizek-WMF wrote: > Updated on TranslateWiki. Thanks a lot for your patience, @Mattflaschen! Maybe we c... [15:07:27] 6Collaboration-Team-Backlog, 10Echo: Don't show a bell if there is only one Echo icon in personal toolbar - https://phabricator.wikimedia.org/T112108#1625618 (10Nemo_bis) 3NEW [15:08:43] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1625641 (10jcrespo) To make this clear, options I see: * execute this independently on... [15:13:17] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1625658 (10Trizek-WMF) I'm online. [15:22:42] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Add an external link on Flow is broken - https://phabricator.wikimedia.org/T111926#1625721 (10Trizek-WMF) I've tried to reproduce what I've done as far as I remember : # type a text on VE # select the word on which I want to create a link on # click on the lin... [15:24:15] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Add an external link on Flow is broken - https://phabricator.wikimedia.org/T111926#1625727 (10Mattflaschen) That doesn't seem like a valid URL (because of the space). Even Phabricator is not interpreting it as a single full URL. How did you get that URL exactly? [15:29:35] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Add an external link on Flow is broken - https://phabricator.wikimedia.org/T111926#1625773 (10Trizek-WMF) IIRC, copy/paste from a diff in the Guilbert Express article history. I haven't changed anything on the link. I've done it again: I copy the link on my bro... [15:31:32] 6Collaboration-Team-Backlog, 10Echo: Don't show a bell if there is only one Echo icon in personal toolbar - https://phabricator.wikimedia.org/T112108#1625812 (10Mattflaschen) edit-user-talk (i.e. talk page messages on a non-Flow user talk page, as indicated by that orange bar) has also been moved to Messages.... [15:54:55] 6Collaboration-Team-Backlog, 10Echo: Don't show a bell if there is only one Echo icon in personal toolbar - https://phabricator.wikimedia.org/T112108#1625983 (10Nikerabbit) Currently: ``` twn:/srv/mediawiki/workdir/extensions/Echo (master)$ git show HEAD commit 9a2262d6949474351d5de2a6a81e9cfff6de0a3c Merge:... [16:22:38] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1626175 (10matej_suchanek) 3NEW [16:33:47] 6Collaboration-Team-Backlog, 10Echo: Re-merge the split Echo icons if I disable Flow mentions - https://phabricator.wikimedia.org/T112107#1626243 (10Catrope) Flow mentions aren't the only thing under the messages icon. User talk notifications are there too, see {T108760} [16:37:22] Good morning everybody [16:37:52] matanya: The Echo split should be on hewiki (and other Wikipedias) in about 2 hours [16:38:13] Morning [16:42:29] RoanKattouw: How's the flight? [16:43:01] Delayed departure due to weather in Philadelphia [16:43:06] Fun. [16:43:09] * James_F blames matt_flaschen. [16:43:11] I've had that happen before on West Coast flights, but not cross-country [16:43:44] Seriously. [16:43:54] When I went out for lunch, I thought the rain was over for the day... [16:43:56] It wasn't. [16:51:11] 3Collaboration-Team-Current, 10Flow, 7Regression: Pre-fill broken - https://phabricator.wikimedia.org/T112037#1626310 (10Catrope) a:3Catrope [16:55:20] 6Collaboration-Team-Backlog, 10Flow: No indication to user of Protected Flow pages - https://phabricator.wikimedia.org/T112125#1626335 (10Etonkovidova) 3NEW [16:56:48] 6Collaboration-Team-Backlog, 10Flow: No indication to user of Protected Flow pages - https://phabricator.wikimedia.org/T112125#1626351 (10Mattflaschen) [16:56:50] 6Collaboration-Team-Backlog, 10Flow: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1626352 (10Mattflaschen) [16:57:26] 6Collaboration-Team-Backlog, 10Flow: No indication to user on Protected Flow pages - https://phabricator.wikimedia.org/T112125#1626360 (10Etonkovidova) [16:58:18] 6Collaboration-Team-Backlog, 10Flow: Flow: protected pages should warn you before you try to submit a comment - https://phabricator.wikimedia.org/T62909#1626369 (10Mattflaschen) [16:58:20] 6Collaboration-Team-Backlog, 10Flow: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1529848 (10Mattflaschen) [16:58:33] 6Collaboration-Team-Backlog, 10Flow: Says "user is blocked" when page is protected - https://phabricator.wikimedia.org/T91722#1626374 (10Mattflaschen) [16:58:35] 6Collaboration-Team-Backlog, 10Flow: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1529848 (10Mattflaschen) [16:59:14] 6Collaboration-Team-Backlog, 10Flow: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1626387 (10Mattflaschen) [17:07:58] 6Collaboration-Team-Backlog, 10Echo: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1626443 (10Legoktm) The messages icon should never disappear on you...it's only shown once you have a message (user talk edit or flow notification currently), but shouldn't go away. What... [17:10:22] When you do a git blame in Flow and it goes all the way back to the prototype, you know debugging is going to be interesting... [17:12:02] sorry :( [17:12:52] What are you debugging? [17:13:39] ebernhardson, not your fault. I was just hoping to find some insight about why "tree revision doesn't match provided revision" was originally added. But whatever is causing it now is probably not the same thing as it was back then. [17:13:47] RoanKattouw, https://phabricator.wikimedia.org/T111494 . [17:14:05] Oh that one [17:14:40] BTW did you see Jaime's response on the references backfill task? [17:15:01] No, thanks for letting me know. Will check now. [17:15:32] matt_flaschen: that was added as a basic sanity check. tree_rev_id is a foreign key, so that failing means the data being loaded doesn't match the foreign key [17:15:40] (03PS1) 10Legoktm: Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237424 (https://phabricator.wikimedia.org/T111821) [17:17:00] matt_flaschen: I have some ideas about why he's seeing what he's seeing, I'll check a few quick things and then respond [17:18:22] 6Collaboration-Team-Backlog, 10Echo: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1626486 (10matmarex) Separately from the icon switching from white to black, the dimensions of the badges also change very slightly, and it seems like the text gains bold styling. This ap... [17:18:29] RoanKattouw, okay, thanks. The one he mentions is not even the more complicated of the two. Open to any ideas. [17:18:38] RoanKattouw, I wonder if just re-ordering the ref_src_wiki line to the beginning of the where would help (at least on re-runs). Not sure if MySQL is that stupid. [17:18:46] ( flow_wiki_ref.ref_src_wiki = '' OR flow_wiki_ref.ref_src_wiki IS NULL ) [17:18:54] I wonder if the OR is the problem [17:20:06] RoanKattouw, hmm, problem there is one of the tables was incorrectly done NOT NULL earlier so there are '' entries. But that only applies to one, so we could not do it for the other if that is actually an issue. [17:20:11] (03CR) 10Bartosz Dziewoński: Only use inverted icons for skins using the MediaWiki OOUI theme (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237424 (https://phabricator.wikimedia.org/T111821) (owner: 10Legoktm) [17:20:25] EXPLAIN appears to indicate that = '' is better than IS NULL [17:20:35] In any case, there are two indices starting with ref_src_wiki [17:20:44] Finding rows with a given ref_src_wiki value should not be a problem [17:20:52] Right. [17:20:53] Although perhaps NULL is different [17:21:20] But in that case, we could ALTER the field to NOT NULL everywhere and that'll replace all the NULLs with '' , right? :) [17:22:44] (03PS2) 10Legoktm: Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237424 (https://phabricator.wikimedia.org/T111821) [17:22:49] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Everytime I click on Echo toolbar icon, a network request is generated, even while closing - https://phabricator.wikimedia.org/T111667#1626509 (10Etonkovidova) > The popup will now only send an API request when it i... [17:23:01] RoanKattouw, I don't know what it will do if there are existing NULL values and we try to ALTER to NOT NULL. What caused the originally was adding a NOT NULL column without providing a default value. [17:23:37] RoanKattouw, are you free after standup? Maybe we can talk with jynus then before it gets too late his time. [17:24:14] Aah I see [17:24:18] Yeah let's do that [17:24:56] RoanKattouw, oh, maybe we just need an index that starts with ref_src_object_type. It might be the header, post-summary IN that's killing it. [17:25:09] We would still need to add the INDEX, but might be worth it. [17:25:26] Hmm maybe [17:25:32] Why is that condition there anyway? [17:25:42] Don't we want to eliminate all NULL rows? [17:27:08] RoanKattouw, I have all the info for the splitting of the commit, but I think working on it bottom-up will be the easiest. So that means I'll pull it from gerrit, reset the commit, and then build the commits bottom-up. Do I use 'git reset HEAD^' as a first step? How do I "uncommit" everything? [17:27:27] RoanKattouw, yeah, but there's two ways depending on the type. [17:27:39] mooeypoo: Yes git reset HEAD^ [17:27:47] RoanKattouw, also, I don't know why werdna didn't use ref_src_workflow_id. I noticed that after it was merged. So we could check on a slave if there any where that's different, and if not use that instead. [17:27:51] Oh jeez [17:27:58] OK yes let's look into that [17:28:47] Okay, I'll do that after standup. [17:30:14] I'll be around. I'm on in-flight wifi so I can't attend the standup (even text hangouts won't load for me), but I'll be here on IRC until about 1:30pm Pacific [17:31:09] Okay, see you in a bit. [17:32:44] matt_flaschen legoktm standup ping [17:32:59] RoanKattouw, our room seems to think it's taken until 11:30 [17:33:01] O.o [17:33:18] joining [17:33:40] Oh, oops [17:33:40] Maybe today is a random day where the room is in use [17:33:41] Let me see if I can fix that [17:35:26] RoanKattouw, we're already sitting in a random space [17:35:37] mooeypoo: You have R51 [17:35:41] where is that? [17:35:43] if you want it [17:35:48] The huge conf room on 5 [17:36:08] yay [17:36:11] ok we're there. [17:36:13] Thanks! [17:36:36] The only other available room was R64 which is a glorified broom closet [17:36:43] Yeah we saw that one [17:36:58] ... it *is* a broom closet, with sound proofing [17:38:38] To be fair it's a bit bigger, maybe 1.5x the size of R69 say [17:38:46] (03PS2) 10Umherirrender: Replace deprecated 'jquery.mwExtension' by 'mediawiki.RegExp' [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/221077 (owner: 10Gerrit Patch Uploader) [17:38:53] (03CR) 10Umherirrender: [C: 032] Replace deprecated 'jquery.mwExtension' by 'mediawiki.RegExp' [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/221077 (owner: 10Gerrit Patch Uploader) [17:39:06] You can fit three people and there's a BYOL hangout rig [17:39:48] R69 fits two people, prior history of intimacy not required but suggested [17:41:17] Oh we're talking about a different room. What's the name of the *actual* broom closet on the fifth floor near the door [17:41:45] (03Merged) 10jenkins-bot: Replace deprecated 'jquery.mwExtension' by 'mediawiki.RegExp' [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/221077 (owner: 10Gerrit Patch Uploader) [17:42:23] mooeypoo: That's unnamed. [17:43:19] Yeah that's the actual broom closet [17:43:28] I didn't realize it had sound-proofing [17:43:29] RoanKattouw: No, that's next to it. [17:43:39] RoanKattouw: There's an actual-actual broom closet. [17:43:46] oh right [17:44:00] And then there's the broom closet disguised as a phone booth room next to it [17:44:14] James_F, the teeny tiny room with a folding desk and a glass door that pretends to fit a person and now has sound proofing -- that's a broom closet that pretends to not be a broom closet [17:44:24] Yes. [17:45:00] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1626622 (10Catrope) I wonder if `ref_src_wiki = '' OR ref_src_wiki IS NULL` is the culpr... [17:45:37] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1626624 (10Mattflaschen) @Catrope did you find out about restarting it? [17:46:42] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1626634 (10Catrope) >>! In T111249#1626624, @Mattflaschen wrote: > @Catrope did you find out about restarting it? Subbu said it was restarted (as part of... [17:46:53] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1626636 (10Catrope) a:5Catrope>3None [18:00:39] dannyh: https://phabricator.wikimedia.org/T108762 [18:02:11] ebernhardson, if you have a moment I was wondering about tree_ancestor_id and "Segregate Reference objects by source wiki." (yeah, that's still not done, though I am trying to change that). [18:02:11] (03CR) 10Catrope: [C: 032] Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237424 (https://phabricator.wikimedia.org/T111821) (owner: 10Legoktm) [18:02:42] matt_flaschen: sure [18:02:50] RoanKattouw, it doesn't look like we can use ref_src_workflow_id for posts, and there's no real reason it's better for summary, header. [18:02:52] matt_flaschen: tree_ancestor_id is otherwise known as 'the post replied to' [18:03:09] OK [18:03:21] RoanKattouw, I could be wrong though, hence asking Erik. [18:03:47] ebernhardson, does it only track direct parent (post replied to), all ancestors, or just the root (I think not the last if I understand you)? [18:04:03] I was thinking maybe we can merge the queries and deal with the special-casing for posts differently [18:04:09] matt_flaschen: the table contains all possible sub-tree's, if thats what you are asking [18:04:17] (03PS1) 10Legoktm: Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237440 (https://phabricator.wikimedia.org/T111821) [18:04:29] (03Merged) 10jenkins-bot: Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237424 (https://phabricator.wikimedia.org/T111821) (owner: 10Legoktm) [18:04:30] Such that you have one query that operates on all rows, and does the logic inside [18:04:42] ebernhardson, yeah, so if it's D replies to C replies to B replies to A, "D is a descendant of B" is explicitly represented as a row? [18:04:55] So you'd have to do a LEFT JOIN against flow_tree_node I think, and then some IF(....) stuff in the select fields [18:05:44] matt_flaschen: within the flow_tree_node table D is a descendant of B is expicitly represented (with appropriate depth = value) [18:06:28] ebernhardson, tree_ancestor_id B, tree_descendant_id D, tree_depth 2? [18:07:04] matt_flaschen: yes [18:07:10] RoanKattouw, so, if I pull the gerrit fix, 'git reset HEAD^' and then build 3 commits one on top of the other, I need to send the top one to review so that the other ones below it also are sent, yes? [18:07:10] Not one by one or anything [18:07:18] matt_flaschen: there is even tree_ancestor_id B, tree_descenant_id B, tree_depth 0. All possible subtree's [18:07:28] mooeypoo: Yes [18:07:37] ebernhardson, okay, so I was wrong to assume it was just root. Thanks for explaining it. [18:07:45] (thats what makes the insertion algorithm work, which selects all descedants and changes the ancestor and adds +1 to depth [18:07:55] mooeypoo: Also if you want Gerrit to think that one of your new commits is patchset N+1 of the old commit, you can tell it by setting the Change-Id to be the same in the commit msg [18:08:13] RoanKattouw, oh that's right [18:08:19] hm, might make tht with the bottom one [18:08:42] ebernhardson, do you know of any problem with using ref_src_workflow_id for all flow_wiki_ref and flow_ext_ref to correlate to workflow_wiki. I followed werdna's lead of using ref_src_object_id and tree_ancestor_id (correlated to workflow_id which should only match for roots), but I have no idea why he didn't use ref_src_workflow_id. [18:08:50] ebernhardson, I only found out about ref_src_workflow_id later. [18:09:38] matt_flaschen: Does that mean that the second query in -phase2.sql mispopulates post rows? [18:09:57] Hmm, I guess not, it might identify the wrong workflow but that workflow would still be on the same wiki [18:10:08] ebernhardson, currently, it's done like https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/321409f0370f4f99e19a136f6a1fbc8f93c198b3/db_patches%2Fpatch-reference_wiki-phase2.sql but it's apparently too slow. [18:10:18] matt_flaschen: the workdlow id should be unique across wikis, it eems like a great way to correlate [18:10:42] One of the causes of slowness might be the ref_src_object_type (Which there is no index on), so always using ref_src_workflow_id would allow us to drop that and simplify massively. [18:10:49] (03CR) 1020after4: [C: 032] Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237440 (https://phabricator.wikimedia.org/T111821) (owner: 10Legoktm) [18:11:25] RoanKattouw, it shouldn't be wrong, because only the root post will be able to JOIN with workflow_id, so it should drop all other possible joins. [18:11:59] oic [18:12:06] ebernhardson, okay, so as far as you know, ref_src_workflow_id does what it says on the tin? [18:12:08] Yeah speaking of [18:12:18] matt_flaschen: afaik [18:12:24] ebernhardson, great, thanks. [18:12:28] If the workflow_id field turns out to not be populated correctly, I have an idea for merging the queries [18:12:37] But if Erik thinks that it is, let's check [18:13:18] (03Merged) 10jenkins-bot: Only use inverted icons for skins using the MediaWiki OOUI theme [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237440 (https://phabricator.wikimedia.org/T111821) (owner: 10Legoktm) [18:14:54] I can double-check it against the current method as well, even with the ancestor thing (by keeping the flow_workflow join the account for that). [18:14:55] legoktm: ...? [18:15:01] legoktm: Are you deploying that immediately? [18:15:15] RoanKattouw: twentyafterfour is including it in his train deploy, see -operations [18:15:19] Oh, I see that now [18:15:21] Yup, sorry [18:15:28] :) [18:23:00] 6Collaboration-Team-Backlog, 10Echo: Notifications from functionaries to users for when email isn't available - https://phabricator.wikimedia.org/T112142#1626811 (10Quiddity) 3NEW [18:23:52] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1626820 (10Mattflaschen) I'm going to rewrite it to use ref_src_workflow_id. This will... [18:25:58] 6Collaboration-Team-Backlog, 10Echo: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1626833 (10Legoktm) [18:26:00] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Echo flyout icon flashes color change from white to black in MonoBook skin - https://phabricator.wikimedia.org/T111821#1626831 (10Legoktm) 5Open>3Resolved a:3Legoktm [18:27:45] (03CR) 10Catrope: [C: 032] Set the guided tour cookie in onUserSaveOptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236993 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [18:28:16] (03CR) 10Catrope: [C: 032] Set line-height: 0; to empty AnonWarningWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236998 (https://phabricator.wikimedia.org/T110086) (owner: 10Mooeypoo) [18:29:04] (03PS1) 10Mattflaschen: WIP: use ref_src_workflow_id to find workflow ID directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237453 (https://phabricator.wikimedia.org/T111084) [18:30:55] (03Merged) 10jenkins-bot: Set the guided tour cookie in onUserSaveOptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236993 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [18:31:02] (03PS1) 10Alex Monk: Make sure editLink gets set in OOUI/BoardDescriptionWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237454 [18:32:04] (03Merged) 10jenkins-bot: Set line-height: 0; to empty AnonWarningWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236998 (https://phabricator.wikimedia.org/T110086) (owner: 10Mooeypoo) [18:33:27] RoanKattouw, okay, I have a stack ready, but I screwed up, I have 1 piece that should be lower in the stack. Much lower. Should I first send to review and then fix (I have that piece uncommitted and unstaged) [18:33:43] matt_flaschen: Hmm so now I think your SELECT is probably fine, but the WHERE in the outer UPDATE query is still on a field that isn't directly indexed, I wonder if that'll end up being a problem [18:33:52] mooeypoo: No need [18:34:04] mooeypoo: Do you have your piece uncommitted, and everything else done? [18:34:09] yes [18:34:14] OK [18:34:27] So first, commit your piece [18:34:44] oh you're going to make me go through git rebase -i, aren't you [18:34:47] and flip the order [18:34:49] yup [18:34:50] * mooeypoo sees where this is going [18:35:06] squash/fixup the temp commit into the commit that piece belongs in [18:35:11] so I need to make another branch for it so I can squash it into the branch it needs ? [18:35:17] No no [18:35:33] All you need to do is look at git log and identify the hash of the commit that your piece belongs in [18:35:37] Right now I'm at the top commit. It doesn't belong there, though. Do I not make another commit on top of that one? [18:35:47] 6Collaboration-Team-Backlog, 10Flow: Summarize: switching to wikitext mode displays old style icon - https://phabricator.wikimedia.org/T111984#1626894 (10Etonkovidova) [18:35:51] Yes, first put your piece in a separate commit by itself [18:35:58] on top is fine, you're going to move it anyway [18:36:11] Then find the hash of the commit it belongs in (using git log) [18:36:22] Run git rebase -i thathash^ [18:36:44] Move your temporary commit to right below the commit that your change belongs in, and change its (the temp commit's) action from pick to fixup [18:36:54] wait, not HEAD^(number-backwards) ? [18:37:00] HEAD~n works too [18:37:04] But then you have to count [18:37:10] oh I didn't know you can do either [18:37:13] the hash is easier [18:37:15] This way you can copy-paste [18:37:16] Yeah [18:37:19] They're equivalent actually [18:37:24] ^ is short for ~1 [18:37:26] RoanKattouw, true, but I don't know if adding the index is worth it if we're just doing it this one time. [18:37:42] So thathash^ will end up being the same as HEAD~5 or something [18:37:54] RoanKattouw, jynus and I are discussing in #wikimedia-operations. [18:37:55] matt_flaschen: Yeah it might not be. I just realized it's not indexed at all [18:38:11] I thought there was an index on (wiki, workflow_id) but there isn't [18:39:13] RoanKattouw, sorry, it's just really confusing. I'm in the list of commits in the terminal editor, but they're "backwards" ... like, 1->2->3->4->(mypiece) [18:39:21] my piece needs to go into 2 [18:39:26] so do I put it before or after [18:39:39] This part is always confusing as hell to me [18:40:38] Sorry [18:40:42] ok I think I got it [18:40:43] It's in chronological order [18:40:51] Whereas git log is in reverse chronological order :S [18:40:52] 1, 2, squash mypiece, 3, 4... [18:40:56] Yes [18:41:01] Assuming mypiece needs to be part of 2 [18:41:05] yeah [18:41:10] Also, use "fixup" instead of "squash" to bypass the commit message merging step [18:41:23] (it'll just use the commit message of 2 verbatim and drop the commit message of mypiece altogether) [18:41:41] great [18:41:46] I almost always do this because merging commit messages is a pain and I rarely need it [18:42:07] And if I do need to change the commit summary, I can always go back to git rebase -i and use reword [18:42:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Board description: VE icons are misplaced - https://phabricator.wikimedia.org/T112019#1626930 (10Etonkovidova) [18:42:24] :\ it still wants me to combine the commit messages [18:42:50] (03CR) 10Catrope: [C: 032] Make sure editLink gets set in OOUI/BoardDescriptionWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237454 (owner: 10Alex Monk) [18:42:55] ok I'm done with that [18:43:05] RoanKattouw, now i need to get back "up" to the top commit to send to review ? [18:43:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: [Regression] Editing upper post in nested thread opens all nested Replies - https://phabricator.wikimedia.org/T111987#1626934 (10Etonkovidova) [18:43:31] mooeypoo: Once the rebase finishes you should be there already [18:43:33] (use git log to verify) [18:44:39] awesome. Except it seemed to have changed my branch name to the top one, which was the temporary one [18:44:50] not a big deal, just annoying [18:45:04] git checkout -B new-branch-name [18:45:06] ;) [18:45:13] that makes *another* branch on top [18:45:32] (-B is like -b , but means "if the branch already exists, stfu, delete it first then recreate it") [18:45:41] ok I just tested to make sure I didn't miss anythng (hopefully) and i'm ready according to git log, so now just... git review ? [18:45:45] Well yeah but then you can do git branch -d oldname [18:45:48] oh oh capital B [18:45:49] (or -D if neede) [18:46:13] -B and -b only differ if the branch you're trying to /create/ already exists [18:46:21] I'll often do something like [18:46:34] git checkout -b who-needs-a-font-size-anyway [18:46:39] [fix missing font size] [18:46:40] git review [18:46:44] [someone else amends my commit] [18:46:47] no but if you're already in a branch and you do that, it will create a branch on *top* of your branch [18:46:47] git review -d 12345 [18:46:55] git checkout -B who-needs-a-missing-font-size-anyway [18:47:01] There is no stacking of branches [18:47:04] Branches are pointers to commits [18:47:21] but ... isn't that how you make a stacked commit? [18:47:25] Your system may have gitk installed. gitk --all will show you a visualization that might be informative [18:47:37] Well yes, by first starting a new branch and then committing [18:47:46] When you commit, only the currently active branch's pointer is advanced [18:47:50] working on commit A, then go 'git checkout -b blah' work on files, then commit, then git checkout -b blah2' etc [18:49:14] (03PS1) 10Mooeypoo: Use topicId instead of page name for posts in the APIHandler [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237459 [18:49:17] (03PS1) 10Mooeypoo: Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 [18:49:18] * mooeypoo holds her breath [18:49:20] (03PS1) 10Mooeypoo: [wip] Add a Topic Summary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237461 [18:49:23] (03PS1) 10Mooeypoo: [wip] Add browser tests to EditTopicSummaryWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237462 [18:49:43] (03Merged) 10jenkins-bot: Make sure editLink gets set in OOUI/BoardDescriptionWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237454 (owner: 10Alex Monk) [18:50:08] yay [18:50:21] and foo, the only thing I forgot is to "eat up" the original commit [18:50:33] I guess I can abandon it instead [18:50:35] eh [18:50:56] hm. Can I still replace them? [18:51:22] RoanKattouw, this: https://gerrit.wikimedia.org/r/#/c/237461/ should really be the next ps of https://gerrit.wikimedia.org/r/#/c/236870 [18:51:39] if I replace the change id's, would the hierarchy of the commits remain? [18:51:51] mooeypoo: Yes, just use reword to do that [18:52:09] git rebase -i hashofcommityouneedtochange^ then choose reword for the top one, and update the Change-Id [18:52:58] (03PS8) 10Mooeypoo: [wip] Add a Topic Summary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (owner: 10Sbisson) [18:53:01] (03PS2) 10Mooeypoo: [wip] Add browser tests to EditTopicSummaryWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237462 [18:53:04] (03CR) 10jenkins-bot: [V: 04-1] Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 (owner: 10Mooeypoo) [18:53:58] \o/ [19:01:49] (03CR) 10Catrope: [C: 032] Fix toggling Flow to false in BetaFeatures (opt-out) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237350 (https://phabricator.wikimedia.org/T111830) (owner: 10Matthias Mullie) [19:03:29] (03PS2) 10Catrope: Use topicId instead of page name for posts in the APIHandler [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237459 (owner: 10Mooeypoo) [19:04:20] mooeypoo: Hmm I guess I forgot to teach you how to attribute authorship to others; I'll do that now [19:04:52] (Basically it's git commit --amend --author="Stephane Bission " [19:05:01] s/Basically// [19:05:39] (03PS3) 10Catrope: Use topicId instead of page name for posts in the APIHandler [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237459 (owner: 10Mooeypoo) [19:06:35] (03CR) 10Catrope: [C: 032] Use topicId instead of page name for posts in the APIHandler [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237459 (owner: 10Mooeypoo) [19:07:07] (03PS2) 10Catrope: Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 (owner: 10Mooeypoo) [19:07:12] (03PS3) 10Catrope: Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 (owner: 10Mooeypoo) [19:07:58] (03PS4) 10Catrope: Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 (owner: 10Mooeypoo) [19:08:20] (03CR) 10Catrope: [C: 032] Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 (owner: 10Mooeypoo) [19:08:43] (03Abandoned) 10Catrope: [wip] Add a Topic Summary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237461 (owner: 10Mooeypoo) [19:09:01] (03PS9) 10Catrope: [wip] Add a Topic Summary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (owner: 10Sbisson) [19:09:45] (03Merged) 10jenkins-bot: Fix toggling Flow to false in BetaFeatures (opt-out) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237350 (https://phabricator.wikimedia.org/T111830) (owner: 10Matthias Mullie) [19:13:47] RoanKattouw, meh I thought the patchset you abandoned was taken over by the new one [19:13:51] apparently not..? [19:14:27] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Way for VE to run on Flow without changing wgVisualEditorNamespaces - https://phabricator.wikimedia.org/T94282#1627370 (10Jdforrester-WMF) [19:14:35] oh, it duplicated [19:14:43] RoanKattouw, is that a gerrit thing or a git thing ? [19:15:13] It's a Gerrit thing [19:15:17] okay [19:15:22] It was duplicatd because you initially didn't reuse the Change-Id [19:15:31] also, why are things not merging.... [19:16:13] oh okay, they're on their way [19:16:39] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1627383 (10Jdforrester-WMF) [19:16:59] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Initial render of mention output in an empty (placeholder'ed) VE Flow reply is blank until it is changed - https://phabricator.wikimedia.org/T107342#1492766 (10Jdforrester-WMF) [19:19:48] (03Merged) 10jenkins-bot: Use topicId instead of page name for posts in the APIHandler [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237459 (owner: 10Mooeypoo) [19:19:54] (03Merged) 10jenkins-bot: Centralize the application of flow-api-inprogress class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237460 (owner: 10Mooeypoo) [19:23:24] 6Collaboration-Team-Backlog, 10Flow: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1627443 (10DannyH) How about this: The message appears in the box when you click into an entry field, as we do with the anon edit warning. The background color is the standard... [19:23:35] 6Collaboration-Team-Backlog, 10Flow: Notify users who are editing protected flow content - https://phabricator.wikimedia.org/T108762#1627445 (10DannyH) p:5High>3Normal [19:26:05] My laptop is gonna die soon here [19:26:15] I'm off tomorrow, see you guys Monday [19:28:51] (03CR) 10Catrope: [C: 04-1] "Good to merge if you remove the commented-out code" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237280 (https://phabricator.wikimedia.org/T112004) (owner: 10Mooeypoo) [19:29:04] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1627473 (10jcrespo) I think matt already fixed, but I wanted to put the findings here:... [19:30:40] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1627483 (10Catrope) Scheduled for Monday at 09:00 UTC. @jcrespo will perform the change... [19:31:30] is it intentional that on monobook the notification badges use black icons ? [19:33:09] thedj: Yes. [19:33:23] thedj: (Monobook => Apex theme => Only one colour of icon.) [19:34:28] https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Notifications_indicators_have_changed [19:34:52] James_F: i think you get black on red then in monobook.. /me hasn't had a notif yet. [19:35:35] thedj: Normally black on grey, and black on red for the few seconds when you have a talk page notification to read, yes. [19:39:14] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1627566 (10Rical) Now, I experiment another case of vail: https://fr.wikipedia.org/wiki/Discussion_Projet:Aide_et_accueil in discussion, but the Project page is OK: https://fr.wikipedia.org/wiki/Projet:... [19:54:53] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1627632 (10Merl) The new notification design looks horrible in modern skin with its grey rounded icon boxes. Als... [19:56:12] thanks RoanKattouw_away it looks great [20:04:20] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1627701 (10Legoktm) >>! In T108190#1627632, @Merl wrote: > The new notification design looks horrible in modern... [20:10:10] James_F|Away: hmm, i also see styling flashes on them though. For me it's white -> black -> white if i load the page and there is a message waiting for me. [20:10:32] thedj: ugh, monobook or vector? [20:10:49] vector [20:11:44] ok. we just fixed a flash in monobook, but it might have regressed in vector? I'm testing now [20:11:54] ah. it does that only on Flow boards ! [20:12:08] o.O [20:12:12] * legoktm points to mooeypoo [20:16:07] thedj: could you file a bug for this please? [20:16:16] yeah i will do that [20:18:31] * legoktm goes back to the modern bug [20:27:39] legoktm, your fix should fix it, though, no? [20:27:51] as for designing specifically for Modern, we'll have to see what to do [20:28:21] it should have yeah [20:28:47] I'm fiddling with CSS right now for https://phabricator.wikimedia.org/T111825 [20:30:18] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Notification icon flashes from white to black to white on Flow boards - https://phabricator.wikimedia.org/T112168#1627862 (10TheDJ) 3NEW [20:37:31] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Notification icon flashes from white to black to white on Flow boards - https://phabricator.wikimedia.org/T112168#1627944 (10TheDJ) on second try, it seems that i have it on all pages, it's just infinitely faster on non Flow pages, so that I hardly notice the flash [20:41:25] (03PS1) 10Legoktm: Override padding for links in personal tools in Modern skin [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237495 (https://phabricator.wikimedia.org/T111825) [20:42:45] mooeypoo: I don't think your buttons fix got backported [20:43:11] (03PS1) 10Legoktm: Align popup footer buttons to take 50% width each [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237496 [20:51:07] (03CR) 10Legoktm: [C: 032] Align popup footer buttons to take 50% width each [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237496 (owner: 10Legoktm) [20:53:08] (03Merged) 10jenkins-bot: Align popup footer buttons to take 50% width each [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237496 (owner: 10Legoktm) [20:56:23] (03PS2) 10Mattflaschen: Use ref_src_workflow_id to find workflow ID, add index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237453 (https://phabricator.wikimedia.org/T111084) [20:56:49] matt_flaschen: while checking links (https://phabricator.wikimedia.org/T109814) - I saw that templatelinks does not list templates that are in posts [20:56:54] 6Collaboration-Team-Backlog, 10Echo: TypeError: jQuery(...).filter(...).makeCollapsible is not a function - https://phabricator.wikimedia.org/T112175#1628046 (10Josve05a) 3NEW [20:56:58] matt_flaschen: is it intentional? [20:57:26] matt_flaschen: normal pages display all template links in the table... [20:57:53] etonkovidova, it's not intentional. What are the steps to reproduce? [20:59:04] matt_flaschen: betalabs Talk:ET24 - there is a template {{convert|6.3|cm|abbr = on}} which is not listed in select * from templatelinks where tl_from=126245; [21:00:37] 6Collaboration-Team-Backlog, 10Echo: TypeError: jQuery(...).filter(...).makeCollapsible is not a function - https://phabricator.wikimedia.org/T112175#1628062 (10Legoktm) Any reason you think this is an Echo bug...? [21:01:14] re: the monobook FOUC (well, partially styled), is there a bug for the Flash of resizing seen in Vector's echo icons? [21:01:37] 6Collaboration-Team-Backlog, 10Echo: TypeError: jQuery(...).filter(...).makeCollapsible is not a function - https://phabricator.wikimedia.org/T112175#1628082 (10Josve05a) Actually, no. But i pressed the notification-thingy and it just kept loading, and would not show my "thanks". I checked my colsole and this... [21:02:08] etonkovidova, ah, since it's part of the topic you need the article ID of the topic page (128674). You can get that the same was as any article ID (e.g. wgArticleId on the topic page). [21:02:21] etonkovidova, you'll also see the transclusion at http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3AWhatLinksHere&target=Template%3AConvert&namespace=2600 in the topic namespace. [21:03:21] etonkovidova, however, if it's part of the board description, it should be under the board page ID. [21:04:11] quiddity: https://phabricator.wikimedia.org/T112104 ? [21:05:31] that's it, thanks [21:07:44] (03PS3) 10Mattflaschen: Use ref_src_workflow_id to find workflow ID, add index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237453 (https://phabricator.wikimedia.org/T111084) [21:10:22] (03CR) 10jenkins-bot: [V: 04-1] Use ref_src_workflow_id to find workflow ID, add index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237453 (https://phabricator.wikimedia.org/T111084) (owner: 10Mattflaschen) [21:10:47] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1628142 (10Mattflaschen) [21:10:56] 6Collaboration-Team-Backlog, 10Echo: TypeError: jQuery(...).filter(...).makeCollapsible is not a function - https://phabricator.wikimedia.org/T112175#1628144 (10Legoktm) Please include that in your initial bug report in the future :-) [21:12:02] 6Collaboration-Team-Backlog, 10Echo: TypeError: jQuery(...).filter(...).makeCollapsible is not a function - https://phabricator.wikimedia.org/T112175#1628146 (10Josve05a) Sorry :p But I was pre-occupied. Was going to add it later, but since I was pinged... [21:35:35] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization: OOUI PopupWidgets don't have drop shadows in the MediaWiki theme - https://phabricator.wikimedia.org/T111889#1628336 (10Esanders) This is how the DropdownWidget looks at normal size: {F2566484, size=full} It's very subtle and only visi... [21:38:41] matt_flaschen: so about templates in templatelinks - false alarm? :) [21:40:01] 6Collaboration-Team-Backlog, 10Echo: Echo waits to show you messages on second load - https://phabricator.wikimedia.org/T112186#1628352 (10Esanders) 3NEW [21:41:35] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-Maintenance: TypeError: jQuery(...).filter(...).makeCollapsible is not a function - https://phabricator.wikimedia.org/T112175#1628372 (10Josve05a) [21:43:54] (03PS1) 10Mooeypoo: [wip] Adjust and clean up styles and behavior for mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237510 [21:46:30] 6Collaboration-Team-Backlog, 10Echo: 'All notifications' and 'Preferences' buttons shoud fill their containers properly - https://phabricator.wikimedia.org/T112188#1628373 (10Esanders) 3NEW [21:49:35] 6Collaboration-Team-Backlog, 10Echo: Echo waits to show you messages on second load - https://phabricator.wikimedia.org/T112186#1628407 (10Mooeypoo) The notification widget is, by request/design, updating itself on every open. The ideal would be that echo API gives us only the *NEW* notifications instead of al... [21:50:59] matt_flaschen: and a different question: pagelinks in beta should still have references to Special pages? [21:51:54] matt_flaschen: I do not see Special namespace in pagelinks ... [21:53:55] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1628425 (10Etonkovidova) Checked in betalabs enwiki: Special pages do not list links from Flow. [21:54:23] etonkovidova, templates used in Flow should always show up in templatelinks and Special:WhatLinksHere. The question is just where they should show up. For board description, links from the board page. For everything else, links from the topic page. [21:55:52] matt_flaschen: I will check in WhatLInksHree. So if they are not listed in templatelinks and in Special:WhatLInksHere - it's a bug? [21:56:17] etonkovidova, no, there should no longer be any links to special pages in Beta since https://phabricator.wikimedia.org/T109814 is fixed and FlowFixLinks has run in Beta. [21:56:38] matt_flaschen: I am talking about templates links [21:57:04] matt_flaschen: so FlowFixLinks was run - good. [21:57:11] etonkovidova, yes, templatelinks should always show up, but make sure you're checking the right page (board or topic) depending where the link is. [21:57:17] etonkovidova, yes, see https://phabricator.wikimedia.org/T111267 . [21:57:28] We still need to run it in prod. [21:58:13] matt_flaschen: understood - thx. What is the namespace for Special pages in beta? Is it different than in prod? [21:58:37] etonkovidova, special namespace ID is always -1. [21:59:02] matt_flaschen: ok [22:00:12] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/237453 (https://phabricator.wikimedia.org/T111084) (owner: 10Mattflaschen) [22:01:30] 6Collaboration-Team-Backlog, 10Echo: Special:Notifications not rendering on mobile - https://phabricator.wikimedia.org/T112191#1628451 (10Jdlrobson) 3NEW [22:03:21] 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 3Reading-Web-Sprint-55-π: Remove SpecialMobileNotifications from MobileFrontend - https://phabricator.wikimedia.org/T112189#1628493 (10Mattflaschen) [22:03:37] 6Collaboration-Team-Backlog, 10Echo: Special:Notifications has rendering issues on mobile - https://phabricator.wikimedia.org/T112191#1628499 (10Mattflaschen) [22:07:35] 6Collaboration-Team-Backlog, 10Flow: Empty alert box shows a blank item which throws an exception when clicked - https://phabricator.wikimedia.org/T112194#1628528 (10Esanders) 3NEW [22:09:11] 6Collaboration-Team-Backlog, 10Echo: Re-merge the split Echo icons if I disable Flow mentions - https://phabricator.wikimedia.org/T112107#1628550 (10Quiddity) There's a request for feedback on which other Notification types, both existing and planned, should be moved into the "messages" section. https://www.me... [22:11:52] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Ctrl+click (or middle click) should open notifications in a new window - https://phabricator.wikimedia.org/T112004#1628553 (10Quiddity) Also reported onwiki at https://www.mediawiki.org/wiki/Topic:Sooghkix1i8xa4f6 [22:13:25] 6Collaboration-Team-Backlog, 10Echo: Icons fuzzy due to font size - https://phabricator.wikimedia.org/T112196#1628555 (10Esanders) 3NEW [22:13:34] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1628564 (10Etonkovidova) [enwiki]> select count(*) from pagelinks where pl_namespace= -1; +----------+ | count(*) | +----------+ | 0 | +----------+ 1 row in se... [22:13:42] (03PS1) 10Esanders: Remove unnecessary calc() from css [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237516 [22:13:45] (03PS1) 10Esanders: Restyle buttons to be fully clickable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237517 (https://phabricator.wikimedia.org/T112188) [22:15:20] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1628570 (10Etonkovidova) >>! In T110326#1628564, @Etonkovidova wrote: ``` [enwiki]> select count(*) from pagelinks where pl_namespace= -1; +----------+ | count(*)... [22:16:01] (03CR) 10Mattflaschen: [C: 032] Remove unnecessary calc() from css [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237516 (owner: 10Esanders) [22:17:35] (03PS1) 10Esanders: Add constructed class names in comment for greppability [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 [22:18:40] (03CR) 10Legoktm: [C: 032] Add constructed class names in comment for greppability [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 (owner: 10Esanders) [22:20:07] 6Collaboration-Team-Backlog, 10Flow: Empty alert box shows a blank item which throws an exception when clicked - https://phabricator.wikimedia.org/T112194#1628590 (10Josve05a) Same as T112175? [22:20:31] (03PS2) 10Esanders: Add constructed class and messages names in comment for greppability [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 [22:25:14] (03PS1) 10Mooeypoo: Don't clear notifications when refetching [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237522 (https://phabricator.wikimedia.org/T112186) [22:31:11] (03Merged) 10jenkins-bot: Remove unnecessary calc() from css [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237516 (owner: 10Esanders) [22:32:30] (03CR) 10Esanders: "modified just after your +2 :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 (owner: 10Esanders) [22:33:50] (03CR) 10Esanders: [C: 031] "Looks good, appears to work." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237522 (https://phabricator.wikimedia.org/T112186) (owner: 10Mooeypoo) [22:34:12] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1628648 (10Mattflaschen) [22:38:09] (03PS1) 10Mooeypoo: Footer buttons should fill their footer containers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237525 (https://phabricator.wikimedia.org/T112188) [22:38:12] (03CR) 10jenkins-bot: [V: 04-1] Footer buttons should fill their footer containers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237525 (https://phabricator.wikimedia.org/T112188) (owner: 10Mooeypoo) [22:38:33] (03PS3) 10Esanders: Add constructed class and messages names in comment for greppability [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 [22:38:53] (03CR) 10Legoktm: [C: 032] Add constructed class and messages names in comment for greppability [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 (owner: 10Esanders) [22:39:33] (03CR) 10Esanders: "See https://gerrit.wikimedia.org/r/#/c/237517/ :/" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237525 (https://phabricator.wikimedia.org/T112188) (owner: 10Mooeypoo) [22:39:39] (03PS2) 10Mooeypoo: Footer buttons should fill their footer containers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237525 (https://phabricator.wikimedia.org/T112188) [22:41:19] (03CR) 10Mooeypoo: [C: 032] "Works great, thanks!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237517 (https://phabricator.wikimedia.org/T112188) (owner: 10Esanders) [22:41:51] (03Abandoned) 10Mooeypoo: Footer buttons should fill their footer containers [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237525 (https://phabricator.wikimedia.org/T112188) (owner: 10Mooeypoo) [22:42:38] (03Merged) 10jenkins-bot: Add constructed class and messages names in comment for greppability [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237519 (owner: 10Esanders) [22:42:44] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo waits to show you messages on second load - https://phabricator.wikimedia.org/T112186#1628691 (10Mooeypoo) a:3Mooeypoo [22:43:17] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: 'All notifications' and 'Preferences' buttons shoud fill their containers properly - https://phabricator.wikimedia.org/T112188#1628698 (10Mooeypoo) a:3Esanders [22:43:34] (03Merged) 10jenkins-bot: Restyle buttons to be fully clickable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237517 (https://phabricator.wikimedia.org/T112188) (owner: 10Esanders) [22:44:36] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 5WMF-deploy-2015-09-15_(1.26wmf23): [Regression] Editing upper post in nested thread opens all nested Replies - https://phabricator.wikimedia.org/T111987#1628722 (10Mooeypoo) a:3Catrope [22:44:36] (03PS1) 10Esanders: Fix vertical alignment of 'Mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237527 [22:45:40] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Board description: VE icons are misplaced - https://phabricator.wikimedia.org/T112019#1628732 (10Mooeypoo) a:3Catrope [22:46:32] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: 'All notifications' and 'Preferences' buttons shoud fill their containers properly - https://phabricator.wikimedia.org/T112188#1628735 (10Esanders) Any reason why these buttons aren't centered like MessageDialog? [22:48:17] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: 'All notifications' and 'Preferences' buttons shoud fill their containers properly - https://phabricator.wikimedia.org/T112188#1628753 (10Mooeypoo) The initial design showed them as being a little to the side (because of the icons.) See {T108190} https... [22:54:46] (03CR) 10Mooeypoo: [C: 032] Override padding for links in personal tools in Modern skin [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237495 (https://phabricator.wikimedia.org/T111825) (owner: 10Legoktm) [22:56:15] (03PS1) 10Aaron Schulz: Defer the "seen time" updates on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237530 (https://phabricator.wikimedia.org/T94448) [22:56:43] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: 'All notifications' and 'Preferences' buttons shoud fill their containers properly - https://phabricator.wikimedia.org/T112188#1628793 (10Esanders) After I converted to framed buttons I had to override the alignment, as framed buttons use text-align:cen... [22:56:46] (03Merged) 10jenkins-bot: Override padding for links in personal tools in Modern skin [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237495 (https://phabricator.wikimedia.org/T111825) (owner: 10Legoktm) [22:57:06] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: 'All notifications' and 'Preferences' buttons shoud fill their containers properly - https://phabricator.wikimedia.org/T112188#1628797 (10Esanders) Pinging @Pginer-WMF [22:57:09] (03CR) 10Legoktm: [C: 032] Defer the "seen time" updates on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237530 (https://phabricator.wikimedia.org/T94448) (owner: 10Aaron Schulz) [22:59:03] (03Merged) 10jenkins-bot: Defer the "seen time" updates on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237530 (https://phabricator.wikimedia.org/T94448) (owner: 10Aaron Schulz) [23:03:16] (03PS1) 10Aaron Schulz: Also defer the markRead() master updates [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237531 (https://phabricator.wikimedia.org/T92357) [23:49:44] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Weird spacing around links in Echo flyout in Modern skin - https://phabricator.wikimedia.org/T111825#1629041 (10Legoktm) 5Open>3Resolved a:3Legoktm [23:58:20] (03PS1) 10Mooeypoo: Dim the nojs buttons for js-version of Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237540 [23:58:29] 6Collaboration-Team-Backlog, 10Echo: Icons in the notifications bar flash black while page is loading - https://phabricator.wikimedia.org/T112215#1629077 (10Deskana) 3NEW [23:59:18] 6Collaboration-Team-Backlog, 10Echo: Icons in the notifications bar flash black while page is loading - https://phabricator.wikimedia.org/T112215#1629085 (10Legoktm) [23:59:19] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Notification icon flashes from white to black to white on Flow boards - https://phabricator.wikimedia.org/T112168#1629086 (10Legoktm) [23:59:25] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Notification icon flashes from white to black to white - https://phabricator.wikimedia.org/T112168#1629088 (10Legoktm) [23:59:48] 6Collaboration-Team-Backlog, 10Echo: Echo icons in personal tools keep blinking - https://phabricator.wikimedia.org/T112104#1629092 (10Legoktm) [23:59:49] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Notification icon flashes from white to black to white - https://phabricator.wikimedia.org/T112168#1627862 (10Legoktm)