[00:00:59] 6Collaboration-Team-Backlog, 10Flow: Alert messages have mixed icons? - https://phabricator.wikimedia.org/T111737#1615199 (10Mooeypoo) 5Open>3Resolved a:3Mooeypoo This was fixed with this: https://gerrit.wikimedia.org/r/#/c/235885 [00:02:47] 6Collaboration-Team-Backlog, 10Echo: Everytime I click on Echo toolbar icon, a network request is generated, even while closing - https://phabricator.wikimedia.org/T111667#1615203 (10Mooeypoo) Clicking the badge doesn't close it, it triggers a reopen. That said, this should be fixed now, as I've added a safeg... [00:12:50] (03PS1) 10Mooeypoo: Only send api request if the popup is opening [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236693 (https://phabricator.wikimedia.org/T111667) [00:13:42] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Everytime I click on Echo toolbar icon, a network request is generated, even while closing - https://phabricator.wikimedia.org/T111667#1615213 (10Mooeypoo) My investigation was fruitful, there's a fix now. The popup will now only send an API request whe... [00:14:16] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Everytime I click on Echo toolbar icon, a network request is generated, even while closing - https://phabricator.wikimedia.org/T111667#1615215 (10Mooeypoo) a:3Mooeypoo [00:18:55] (03CR) 10Catrope: [C: 032] Only send api request if the popup is opening [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236693 (https://phabricator.wikimedia.org/T111667) (owner: 10Mooeypoo) [00:20:02] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#1615227 (10Quiddity) Adding @wittylama per https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications/Archive_6#Requesting_.22File_has_been_used... [00:21:54] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: After clicking on 'Edit description', Board description is displayed empty while its content loads - https://phabricator.wikimedia.org/T109493#1615230 (10Mooeypoo) The editor is designed to appear empty (pending state) while it loads the new... [00:22:37] (03Merged) 10jenkins-bot: Only send api request if the popup is opening [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236693 (https://phabricator.wikimedia.org/T111667) (owner: 10Mooeypoo) [00:22:39] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: After clicking on 'Edit description', Board description is displayed empty while its content loads - https://phabricator.wikimedia.org/T109493#1615232 (10Mooeypoo) a:3Mooeypoo [00:26:42] 6Collaboration-Team-Backlog, 10Echo: Echo icon lacks a tooltip (and functionality?) - https://phabricator.wikimedia.org/T101637#1615241 (10Mooeypoo) Is this even still relevant with the new ooui version of the popup? Can anyone verify so we can close this or reopen if needed? The entire popup was refactored. [00:27:26] 6Collaboration-Team-Backlog, 10Echo: Echo icon lacks a tooltip (and functionality?) - https://phabricator.wikimedia.org/T101637#1615250 (10Jdforrester-WMF) 5stalled>3Resolved a:3Jdforrester-WMF [00:32:37] 6Collaboration-Team-Backlog, 10Echo: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615272 (10Mooeypoo) I can't reproduce this. Can you point me to the exact page this happened in? What wiki? [00:33:00] 3Collaboration-Team-Current, 10Echo: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615274 (10Mooeypoo) p:5Triage>3High a:3Mooeypoo [00:38:07] 6Collaboration-Team-Backlog, 10Echo: Echo: Implement 'Mark all as read' - https://phabricator.wikimedia.org/T49092#1615286 (10Mooeypoo) 5Open>3Resolved a:3Mooeypoo [00:53:02] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7Easy: Add hard drop shadow to echo badge label text to increase readability - https://phabricator.wikimedia.org/T57523#1615308 (10Mooeypoo) 5Open>3declined Superceded by {T108190} [01:05:39] 6Collaboration-Team-Backlog, 10Echo: Echo "Mark all as read" control no longer appears - https://phabricator.wikimedia.org/T88003#1615344 (10Mooeypoo) This should be fixed with the recent overhaul of the popup to OOUI. [01:12:07] 6Collaboration-Team-Backlog, 10Echo: Echo: Visiting Special:Notifications should not change any notification's "read" status - https://phabricator.wikimedia.org/T111750#1615355 (10Mooeypoo) 3NEW [01:13:13] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1615362 (10Mooeypoo) a:3Mooeypoo [03:25:09] (03PS3) 10Catrope: Use wikitext icon from OOUI for the VE->WT switch tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) [03:25:12] (03PS1) 10Catrope: VisualEditorWidget: Ensure toolbar is initialized after editor is attached [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236721 [03:25:15] (03PS1) 10Catrope: EditorSwitcherWidget: Move wikitext-specific styles to WikitextEditorWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236722 [03:25:18] (03PS1) 10Catrope: mw.flow.ve.Target.less: Apply font-size override to toolbar rather than target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236723 [03:25:21] (03PS1) 10Catrope: mw.flow.ve.Target.less: Avoid magical margin-top on actions div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236724 [03:25:24] (03PS1) 10Catrope: Make VE and wikitext editors the same height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236725 [03:25:27] (03PS1) 10Catrope: Replace the WT->VE switch button with an OOUI toolbar tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236726 (https://phabricator.wikimedia.org/T101316) [03:27:14] (03PS2) 10Catrope: Make VE and wikitext editors (almost) the same height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236725 [03:27:17] (03PS2) 10Catrope: Replace the WT->VE switch button with an OOUI toolbar tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236726 (https://phabricator.wikimedia.org/T101316) [03:27:21] mwahahahah [03:32:06] 3Collaboration-Team-Current, 10Echo: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615399 (10santhosh) You can reproduce this by going to http://en.wikipedia.beta.wmflabs.org/wiki/Special:ContentTranslation and clicking on the alert icon. Note tha... [03:35:22] 6Collaboration-Team-Backlog, 5Patch-For-Review: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1615400 (10Catrope) >>! In T101316#1591376, @Catrope wrote: > Yes, that's exactly what I meant. Sorry for not being very clear. I'll whip up a patch soon to demonstrate this.... [03:36:02] 3Collaboration-Team-Current, 5Patch-For-Review: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1615405 (10Catrope) [03:36:13] 3Collaboration-Team-Current, 5Patch-For-Review: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1615413 (10Catrope) a:5Pginer-WMF>3Catrope [03:38:44] (03CR) 10Catrope: [C: 032] Align notification badge higher on the personal navigation bar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236689 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [03:40:10] (03CR) 10Catrope: [C: 04-1] Add a tooltip to the notification badges (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [03:40:53] (03Merged) 10jenkins-bot: Align notification badge higher on the personal navigation bar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236689 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [03:46:11] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Everytime I click on Echo toolbar icon, a network request is generated, even while closing - https://phabricator.wikimedia.org/T111667#1615426 (10santhosh) 5Open>3Resolved Thanks, tested and confimed it is fixed [04:28:44] 3Collaboration-Team-Current, 10Echo: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615440 (10Mooeypoo) Okay, I managed to reproduce this, but this is extremely baffling to me. this.seenTime (which is what the script is complaining about being nul... [04:51:52] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615466 (10Legoktm) This is because Echo ads the 'wgEchoSeenTime' variable in the `PersonalUrls` hook. ContentTranslatio... [04:52:10] mooey|away: ^ [05:05:20] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615468 (10Mooeypoo) Roan and I just spent a while diagnosing the same thing too. I'm going to move the variable creati... [05:08:19] (03PS1) 10Mooeypoo: Create JsConfigVars in onBeforePageDisplay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236730 (https://phabricator.wikimedia.org/T111668) [05:10:24] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5Patch-For-Review: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615480 (10Catrope) Set of variables present on `[[Flow]]` but absent on `[[Special:CX]]`: ``` > OO... [05:14:23] (03CR) 10Legoktm: "We don't independently cache the seen time unless you call the backend storage a cache :P" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236730 (https://phabricator.wikimedia.org/T111668) (owner: 10Mooeypoo) [05:15:08] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5Patch-For-Review: Javascript error while clicking on Echo alert icon in Special:CX - https://phabricator.wikimedia.org/T111668#1615492 (10Catrope) ...or legoktm can put a workaround for this particular issue in CX, that works too [05:15:29] (03CR) 10Catrope: [C: 04-1] "This incurs an additional memc request, and https://gerrit.wikimedia.org/r/#/c/236731/ already works around this in CX." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236730 (https://phabricator.wikimedia.org/T111668) (owner: 10Mooeypoo) [05:15:46] I'm really hoping RoanKattouw_away and mooey|away aren't still at the office. [05:16:27] (03Abandoned) 10Catrope: Create JsConfigVars in onBeforePageDisplay [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236730 (https://phabricator.wikimedia.org/T111668) (owner: 10Mooeypoo) [05:21:48] legoktm: No we're at our respective homes [05:21:50] If I had been at the office, I'd have been on IRC [05:21:51] Which, sorry for not being on IRC [05:21:53] And conflicting with you all the time because of that [05:22:02] :p no worries [05:22:15] Also WTF is up with CX only registering their special page when the beta feature is enabled, it's very confusing :S [05:22:27] actually it's always registered [05:22:34] $out->showErrorPage( 'nosuchspecialpage', 'nospecialpagetext' ); [05:22:41] it just does that if you don't have the BF enabled [05:22:55] WTF [05:23:01] That's just *actively* unhelpful [05:23:21] Also also, Moriel found https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/master/ContentTranslation.hooks.php#L306 [05:23:44] I don't know much about Echo's hook API or anything like that, but if someone's writing code like that, then either they're doing it wrong or our API is bad [05:23:55] They're hooking in and adding users to their own notif types [05:24:15] tl;dr "our API is bad" [06:11:29] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1615535 (10Legoktm) 5Open>3stalled [06:30:25] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Create a special page like Special:NewMessages in Flow - https://phabricator.wikimedia.org/T94691#1615551 (10Ricordisamoa) [06:30:26] 6Collaboration-Team-Backlog, 10Flow: Flow: Personal feed v1 (design) - https://phabricator.wikimedia.org/T100858#1615552 (10Ricordisamoa) [06:58:50] 6Collaboration-Team-Backlog, 10Flow: Flow: Personal feed v1 (design) - https://phabricator.wikimedia.org/T100858#1615574 (10Ricordisamoa) As a user watching 40,000+ pages on Wikidata, Ricordisamoa can't use Flow & Echo together. >>! In T100858#1384312, @DannyH wrote: > His activity pattern: He visits his feed... [07:37:05] 6Collaboration-Team-Backlog, 10Echo: Echo: Visiting Special:Notifications should not change any notification's "read" status - https://phabricator.wikimedia.org/T111750#1615655 (10Legoktm) This is for messages specifically right? We still need a no-JS way to mark notifications as read.... [07:41:08] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1615666 (10Legoktm) https://lists.wikimedia.org/pipermail/wikitech-ambassadors/2015-September/001253.html is the... [08:01:55] 6Collaboration-Team-Backlog, 10Echo: Echo: Visiting Special:Notifications should not change any notification's "read" status - https://phabricator.wikimedia.org/T111750#1615689 (10Mooeypoo) Yeah, alerts are marked as read when they're seen, so that will remain consistent between the popup and the Special:Notif... [08:58:08] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7I18n: PageTriage's "pagetriage-special-contributions" is missing documentation - https://phabricator.wikimedia.org/T103215#1615807 (10Prtksxna) 5Open>3Resolved a:3Prtksxna Added in rEPTRdb86b0cb989b133889212a335c4ad48d22462778 ``` Runn... [08:58:18] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7I18n: PageTriage's "pagetriage-special-contributions" is missing documentation - https://phabricator.wikimedia.org/T103215#1615814 (10Prtksxna) a:5Prtksxna>3None [10:34:29] 6Collaboration-Team-Backlog, 10Flow: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist. - https://phabricator.wikimedia.org/T111771#1616066 (10matmarex) 3NEW [10:50:57] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1616088 (10Amire80) 3NEW [11:26:36] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1616109 (10Josve05a) @Quiddity Is this a dupe of (or problem caused by) {T111772} [11:40:31] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per Roan's comments." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [11:50:25] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236584 (https://phabricator.wikimedia.org/T110932) (owner: 10Mooeypoo) [11:52:41] (03Merged) 10jenkins-bot: Remove unused message flow-error-edit-restricted [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236584 (https://phabricator.wikimedia.org/T110932) (owner: 10Mooeypoo) [12:47:10] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a quick tour about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1616188 (10Trizek-WMF) [12:47:13] 6Collaboration-Team-Backlog, 10Flow, 7Design: Visual design for new Flow indentation model - https://phabricator.wikimedia.org/T88865#1616189 (10Trizek-WMF) [13:55:25] 6Collaboration-Team-Backlog, 10Flow: Hidden a Flow post is against certain French Wikipedia policies - https://phabricator.wikimedia.org/T111778#1616288 (10Trizek-WMF) 3NEW [14:27:07] 6Collaboration-Team-Backlog, 10Echo: Clicking on Echo's "All notifications" does not work - https://phabricator.wikimedia.org/T111783#1616367 (10He7d3r) 3NEW [14:31:49] 6Collaboration-Team-Backlog, 10Echo: Clicking on Echo's "All notifications" does not work - https://phabricator.wikimedia.org/T111783#1616383 (10He7d3r) Apparently the link has no `href` attribute: ```lang=html
6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable: VE displays multiple placeholders when editor only contains a single template - https://phabricator.wikimedia.org/T111107#1616427 (10Esanders) [14:41:53] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1616434 (10IKhitron) [14:46:24] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1616458 (10IKhitron) Seems me that it's indeed a problem, because @Amire80 you have also a flow page in frwiki in this category, and it's exi... [14:49:38] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1616471 (10IKhitron) I recommend to merge this task with T108467 [15:00:07] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: VE displays multiple placeholders when editor only contains a single template - https://phabricator.wikimedia.org/T111107#1616496 (10Esanders) I think fixing the first issue makes the assumption which... [15:08:39] 6Collaboration-Team-Backlog, 10Echo: [Regression] Clicking on Echo's "All notifications" does not work - https://phabricator.wikimedia.org/T111783#1616554 (10Legoktm) p:5Triage>3High a:3Legoktm [15:10:35] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-UploadWizard, 6Multimedia: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#1616584 (10Wittylama) Thank you @quiddity for adding me here! Since my suggestion on the wiki was auto-archived after several weeks with no resp... [15:17:39] (03PS2) 10Matthias Mullie: Show real output instead of placeholder HTML [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236016 (https://phabricator.wikimedia.org/T110696) [15:29:28] (03PS1) 10Legoktm: Use #pt-notifications_alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) [15:30:11] (03PS2) 10Legoktm: Use #pt-notifications_alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) [15:30:58] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: [Regression] Clicking on Echo's "All notifications" does not work - https://phabricator.wikimedia.org/T111783#1616674 (10Legoktm) [15:49:28] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-09-08_(1.26wmf22): VE displays multiple placeholders when editor only contains a single template - https://phabricator.wikimedia.org/T111107#1616796 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [15:52:33] 6Collaboration-Team-Backlog, 10Echo, 7Easy: extensions/Echo - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111740#1616867 (10Legoktm) (Please don't assign bugs to random people who are listed as authors, it discourages other people from working on these easy bugs.) [15:52:39] 6Collaboration-Team-Backlog, 10Echo, 7Easy: extensions/Echo - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111740#1616868 (10Legoktm) a:5kaldari>3None [15:57:12] 6Collaboration-Team-Backlog, 10Echo, 7Documentation: Add documentation file for Echo hooks - https://phabricator.wikimedia.org/T110356#1616899 (10Legoktm) ``` km@km-tp ~/p/v/m/e/Echo> ack "Hooks::run" --php Hooks.php 20: Hooks::run( 'BeforeCreateEchoEvent', array( &$wgEchoNotifications, &$wgEchoNotification... [16:09:11] (03PS1) 10Southparkfan: chmod 644 for php files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236818 (https://phabricator.wikimedia.org/T111742) [16:11:40] (03CR) 10Legoktm: [C: 032] chmod 644 for php files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236818 (https://phabricator.wikimedia.org/T111742) (owner: 10Southparkfan) [16:11:43] (03PS1) 10Southparkfan: chmod 644 for php files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236820 (https://phabricator.wikimedia.org/T111740) [16:12:08] (03CR) 10Legoktm: [C: 032] chmod 644 for php files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236820 (https://phabricator.wikimedia.org/T111740) (owner: 10Southparkfan) [16:16:46] (03Merged) 10jenkins-bot: chmod 644 for php files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236818 (https://phabricator.wikimedia.org/T111742) (owner: 10Southparkfan) [16:16:48] (03Merged) 10jenkins-bot: chmod 644 for php files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236820 (https://phabricator.wikimedia.org/T111740) (owner: 10Southparkfan) [16:21:53] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 5Patch-For-Review: extensions/Echo - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111740#1617060 (10Southparkfan) 5Open>3Resolved a:3Southparkfan Fixed in https://gerrit.wikimedia.org/r/236820. [16:22:07] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 5Patch-For-Review: extensions/Flow - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111742#1617066 (10Southparkfan) 5Open>3Resolved Fixed in https://gerrit.wikimedia.org/r/236818. [16:25:15] 6Collaboration-Team-Backlog, 10Echo: Echo flyout icon flashes color change from white to black in MonoBook skin - https://phabricator.wikimedia.org/T111821#1617089 (10Legoktm) 3NEW [16:40:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-Maintenance: Switch Flow to use Parsoid v3 API with VirtualRESTService - https://phabricator.wikimedia.org/T110721#1617157 (10Etonkovidova) Checked on local machine and betalabs for $wgFlowParsoidHTTPPro... [16:41:39] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Fix Flow Parsoid integration on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T111119#1617161 (10Etonkovidova) Checked along with T110721. [16:55:59] 6Collaboration-Team-Backlog, 10Echo: Weird spacing around links in Echo flyout in Modern skin - https://phabricator.wikimedia.org/T111825#1617212 (10Legoktm) 3NEW [16:57:16] 6Collaboration-Team-Backlog, 10Echo: Echo flyout icon flashes color change from white to black in MonoBook skin - https://phabricator.wikimedia.org/T111821#1617221 (10Mooeypoo) MonoBook uses Apex, which doesn't support inverted icons... I'm not sure why it flashes at all, it should always be black there. [16:59:28] 6Collaboration-Team-Backlog, 10Flow: Flow: Test whether Flow works with dynamic-user-language templates - https://phabricator.wikimedia.org/T60762#1617232 (10Trizek-WMF) [17:11:44] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 7WorkType-Maintenance, 7notice: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1617297 (10Mattflaschen) [17:11:46] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 3 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1617296 (10Mattflaschen) [17:12:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 3 others: Fix toggling Flow to false in BetaFeatures - https://phabricator.wikimedia.org/T111830#1617300 (10Mattflaschen) 3NEW [17:13:09] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 3 others: Fix toggling Flow to false in BetaFeatures - https://phabricator.wikimedia.org/T111830#1617300 (10Mattflaschen) [17:18:18] 6Collaboration-Team-Backlog, 10Echo: Weird spacing around links in Echo flyout in Modern skin - https://phabricator.wikimedia.org/T111825#1617337 (10Legoktm) This has to do with a padding rule applying to `#p-personal li a`: https://phabricator.wikimedia.org/diffusion/SMOD/browse/master/resources/main.css;9a10... [17:25:17] 3Collaboration-Team-Current, 10Flow, 7Wikimedia-log-errors: BadMethodCallException on history of a Flow page - https://phabricator.wikimedia.org/T111494#1617385 (10Mattflaschen) a:3Mattflaschen [17:26:12] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix toggling Flow to false in BetaFeatures - https://phabricator.wikimedia.org/T111830#1617396 (10Mattflaschen) [17:27:42] 6Collaboration-Team-Backlog, 10Echo: Echo flyout icon flashes color change from white to black in MonoBook skin - https://phabricator.wikimedia.org/T111821#1617397 (10Legoktm) If you disable JS, you'll see only the white icon loaded. [17:28:04] 6Collaboration-Team-Backlog, 10Echo: Echo flyout icon flashes color change from white to black in MonoBook skin - https://phabricator.wikimedia.org/T111821#1617398 (10Legoktm) [17:32:24] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Fix Flow Parsoid integration on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T111119#1617415 (10DannyH) 5Open>3Resolved [17:32:30] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase, 5Patch-For-Review: Switch Flow from ExternalStore to RESTBase - https://phabricator.wikimedia.org/T94574#1617419 (10DannyH) [17:32:32] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-Maintenance: Switch Flow to use Parsoid v3 API with VirtualRESTService - https://phabricator.wikimedia.org/T110721#1617417 (10DannyH) 5Open>3Resolved [17:32:36] 3Collaboration-Team-Current, 10Beta-Cluster, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-Maintenance: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1617420 (10DannyH) 5Open>3Resolved [17:32:50] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): extensions/Echo - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111740#1617422 (10wpmirrordev) I confirm that the above mentioned debian lintian warning is cured. Tha... [17:33:34] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): extensions/Flow - file permissions trigger debian lintian warnings - https://phabricator.wikimedia.org/T111742#1617429 (10wpmirrordev) I confirm that the above mentioned debian lintian warnings are cured. T... [17:36:22] (03CR) 10Legoktm: Add a tooltip to the notification badges (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:34:32] (03CR) 10Legoktm: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235886 (owner: 10Jforrester) [18:34:42] legoktm: Whee. Finally. :-) [18:36:39] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235886 (owner: 10Jforrester) [18:43:57] (03CR) 10Catrope: Add a tooltip to the notification badges (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:44:42] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Flow VE toolbar expands on first window resize - https://phabricator.wikimedia.org/T106918#1617705 (10Catrope) This doesn't seem to be happening anymore, but if it still does, https://gerrit.wikimedia.org/r/236721 should fix it. [19:41:45] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 3 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1617984 (10SBisson) `cucumber features/opt_in.feature:30` works locally but exposes the issue mentioned above on beta. [19:41:59] (03PS1) 10Sbisson: [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) [19:44:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [20:03:24] 6Collaboration-Team-Backlog, 10Flow: Link to Special:Notifications from Alert box does not work for a new user - https://phabricator.wikimedia.org/T111537#1618049 (10Etonkovidova) It seems that the link 'All notifications' to Special:Notifications page does not work only when a user has not previously receive... [20:08:00] (03PS2) 10Sbisson: [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) [20:09:56] 6Collaboration-Team-Backlog, 10Flow: Link to Special:Notifications from Alert box does not work when only Alerts are present - https://phabricator.wikimedia.org/T111537#1618080 (10Etonkovidova) [20:11:45] 6Collaboration-Team-Backlog, 10Flow: Split notifications: the same oo-ui-icon-bell used for oo-ui-popupWidget-head Alerts and Messages - https://phabricator.wikimedia.org/T111411#1618092 (10Etonkovidova) Fixed - checked in betalabs. {F2558587} [20:12:02] 6Collaboration-Team-Backlog, 10Flow: Split notifications: the same oo-ui-icon-bell used for oo-ui-popupWidget-head Alerts and Messages - https://phabricator.wikimedia.org/T111411#1618093 (10Etonkovidova) 5Open>3Resolved p:5Triage>3Normal [20:12:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Topic Summary Widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [20:18:22] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 7WorkType-Maintenance, 7notice: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1618112 (10DannyH) @Nemo_bis: I agree that it's important to get this done very soon. We just need to figure who's available to take th... [20:23:13] legoktm, I don't understand why my api response in Echo notifications list doesn't work as expected. I have 'notmessageunreadfirst: 1' and yet I am not getting unread messages first [20:23:28] legoktm, the "old" system did the same and the notifications *were* unread-first. [20:23:58] the only difference I spot in the requests is that mine asks for notsections: this.type and the old one asked for notsections: 'alert|message' [20:24:04] can that have affected the order? [20:24:35] I'm looking [20:24:40] also, I found this beauty: [20:24:41] 'alertunreadfirst' => 'Whether to show unread message notifications first', [20:24:42] 'messageunreadfirst' => 'Whether to show unread alert notifications first' [20:26:32] .... [20:26:37] * mooeypoo mutters [20:26:45] does it matter if you separate the sections ? [20:26:53] legoktm: :-D [20:26:57] we're no longer passing groupbysection right? [20:27:12] legoktm, each request is separate, so no? [20:27:33] well, turns out that foounreadfirst doesn't do anything unless you pass 'groupbysection' [20:27:42] legoktm, i'm passingit in [20:27:51] I just checked [20:28:02] i thought i shouldn't but i've just duplicated the entire api request [20:28:17] umm, I don't see it in my network console [20:28:27] no no I mean I just started as part of my test [20:28:28] BUT [20:28:31] I think I see the problem [20:28:41] now my api response is dying because it's in the wrong expected structure [20:28:45] let me adjust to the new structure [20:29:03] this makes no sense btw... it now "groups" by section (so i have another nested key i need to adjust to) but there's only ONE second [20:29:05] section [20:29:15] it should work without it too :\ [20:30:22] yes it should [20:30:53] let me see if that gives me the right order, at least [20:32:08] legoktm, yes, it works now [20:32:26] but it requires me to use another useless nested key. It's okay for now, but yeah... we should adjust that. [20:33:34] it's doing some interesting db stuff [20:38:12] mooeypoo: also http://i.imgur.com/b6CovZF.png :P [20:39:18] legoktm, what am I looking at? [20:39:40] wait [20:39:47] someone changed the popup styling o.o [20:40:11] Me? [20:40:23] oh no the popuppopup [20:40:27] not the ooui popup of echo popup [20:40:36] I am so confupup [20:40:50] https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-navpop.css&curid=14623307&action=history [20:40:51] hmm [20:41:03] *but* the fact the popup works means my hook was placed properly [20:41:06] which I am glad for [20:41:17] hee hee [20:41:32] legoktm, excellent, we were talking about redesigning it, weren't we? [20:41:34] yes :D [20:41:39] :D [20:41:40] (to both!) [20:47:43] (03PS1) 10Mooeypoo: The return of the 'mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236939 [20:48:16] ^^ this commit message needs a sound effect [20:48:21] we should add that option to gerrit [20:51:26] (03CR) 10Catrope: [C: 032] The return of the 'mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236939 (owner: 10Mooeypoo) [20:52:20] phabricator supports sound ;) [20:52:52] (03PS1) 10Mooeypoo: Show unread notifications first in the popup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236941 [20:52:58] legoktm, don't tempt me... [20:53:28] * legoktm reviews [20:53:29] (03CR) 10Catrope: [C: 032] Show unread notifications first in the popup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236941 (owner: 10Mooeypoo) [20:54:29] (03CR) 10Legoktm: "We should leave a comment indicating why we're using this parameter when it seems useless as we're only fetching one section." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236941 (owner: 10Mooeypoo) [20:54:58] (03Merged) 10jenkins-bot: The return of the 'mark all as read' button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236939 (owner: 10Mooeypoo) [20:57:06] (03PS2) 10Mooeypoo: Show unread notifications first in the popup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236941 [20:57:18] * quiddity barks like a seal at legoktm [20:57:36] quiddity: hehehe that's exactly what I was thinking of [20:57:47] i think that's the only one that uses it [20:58:03] (03CR) 10Legoktm: [C: 032] "Thanks :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236941 (owner: 10Mooeypoo) [20:58:03] (thankgawd) [20:58:21] quiddity, my sound effect would have been reading the commit message in a HOLLYWOOD MOVIE ANNOUNCER VOICE! [20:59:04] ... I should have started it with "In a world where 'mark as read' was accidentally deleted... comes a commit that fixes it all!" [20:59:21] * mooeypoo plans for future commits [20:59:28] mooeypoo: Re Hollywood announcer voice, https://www.youtube.com/watch?v=Yn3Xp2jkTZQ [20:59:39] mooeypoo, https://www.youtube.com/watch?v=JQRtuxdfQHw (4 min distraction. 5 voiceover artists doing a skit) [21:01:58] (03PS2) 10Mooeypoo: Add a tooltip to the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) [21:02:03] (03CR) 10jenkins-bot: [V: 04-1] Add a tooltip to the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [21:03:48] (03PS3) 10Mooeypoo: Add a tooltip to the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) [21:04:28] mooeypoo/RoanKattouw: https://gerrit.wikimedia.org/r/236799 [21:04:38] The full version of the skit I linked (slightly NSFW): https://www.youtube.com/watch?v=Qvv8SMTyAgk [21:04:55] legoktm, I'm actually changing their names now from _ to - [21:05:07] oh, why? [21:05:20] legoktm, because core automatically creates messages based on the class \o/ [21:05:35] ahh [21:05:36] It caused the message key to be foo-bar_baz [21:05:43] and having a message "tooltip-pt-notifications_message" is crappy [21:06:14] legoktm, I can fix your commit [21:06:25] please :) [21:07:45] (03PS3) 10Mooeypoo: Use #pt-notifications_alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) (owner: 10Legoktm) [21:08:00] (03PS4) 10Mooeypoo: Use #pt-notifications_alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) (owner: 10Legoktm) [21:08:16] 6Collaboration-Team-Backlog, 10Flow: Local categories set on Flow boards affect Flow boards on other projects? - https://phabricator.wikimedia.org/T108467#1618318 (10DannyH) I'm sorry that these categories are appearing; I know that they're confusing and annoying for the people who see it happen. This ticke... [21:08:28] (03PS5) 10Mooeypoo: Use #pt-notifications-alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) (owner: 10Legoktm) [21:08:31] (03Merged) 10jenkins-bot: Show unread notifications first in the popup [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236941 (owner: 10Mooeypoo) [21:08:34] 6Collaboration-Team-Backlog, 10Flow: Mention suggestions drop down - the width size is not calculated correctly - https://phabricator.wikimedia.org/T111864#1618326 (10Etonkovidova) 3NEW [21:08:39] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1616088 (10DannyH) I'm sorry that these categories are appearing; I know that they're confusing and annoying for the people who see it happen... [21:08:46] (03CR) 10Catrope: [C: 032] Use #pt-notifications-alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) (owner: 10Legoktm) [21:09:20] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1618342 (10DannyH) [21:09:21] 6Collaboration-Team-Backlog, 10Flow: Local categories set on Flow boards affect Flow boards on other projects? - https://phabricator.wikimedia.org/T108467#1618343 (10DannyH) [21:09:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, and 2 others: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1489595 (10DannyH) [21:09:30] (03CR) 10Catrope: [C: 032] Add a tooltip to the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [21:10:36] mooeypoo: ack-grep pt-notifcations_ --nojson [21:11:46] (03Merged) 10jenkins-bot: Add a tooltip to the notification badges [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236691 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [21:12:38] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Split seen timestamp for alerts and messages - https://phabricator.wikimedia.org/T111285#1618351 (10DannyH) 5Open>3Resolved [21:12:51] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Overlapping messages in the notifications flyout in non-English languages - https://phabricator.wikimedia.org/T108270#1618355 (10DannyH) [21:12:53] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1618353 (10DannyH) 5Open>3Resolved Works great on beta... [21:13:45] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Warn the user if they cancel an editor with data in it - https://phabricator.wikimedia.org/T111115#1618356 (10DannyH) 5Open>3Resolved [21:13:55] (03Merged) 10jenkins-bot: Use #pt-notifications-alert to get Special:Notifications link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/236799 (https://phabricator.wikimedia.org/T111783) (owner: 10Legoktm) [21:15:24] please add to {{gender}} for "user" to MediaWiki:Flow-talk-page-beta-feature-description, MediaWiki:Flow-talk-page-beta-feature-message, MediaWiki:Flow-notification-enabled-on-talkpage-email-batch-body. or how to use GENDER in messages, when it is not in the English version [21:16:08] (03PS1) 10Mooeypoo: Show unread notifications first in the popup [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236954 [21:16:32] (translatewiki.net Flow) [21:17:08] (03PS1) 10Mooeypoo: Add a tooltip to the notification badges [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236956 (https://phabricator.wikimedia.org/T108190) [21:17:40] (03PS1) 10Mooeypoo: Use #pt-notifications-alert to get Special:Notifications link [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236957 (https://phabricator.wikimedia.org/T111783) [21:26:33] 6Collaboration-Team-Backlog, 10Flow: "TypeError: Cannot read property 'addButton' of undefined TypeError" for User/User talk pages when "Flow on user talk" is not enabled - https://phabricator.wikimedia.org/T111866#1618376 (10Etonkovidova) 3NEW [21:29:34] sunpriat: Are you trying to use the gender of the current user? [21:29:55] sunpriat: Cause you can always do that with {{gender:|male|female}} [21:30:11] (Apparently even many MW core developers don't know this) [21:30:30] >.> [21:30:39] this will work without an $1? [21:30:51] Yeah :) [21:30:53] Little known feature [21:31:06] legoktm: ? [21:31:16] I didn't know that until today :P [21:31:29] Yeah I was trying to be diplomatic :P [21:31:41] when I said "many MW core devs" [21:31:55] * RoanKattouw gets the use of >.> now; first thought it meant disapproval [21:32:30] OK, I will try to do so. I hope it works for email. thank [21:32:55] Oh, right, emails [21:32:57] crap [21:33:13] sunpriat: You're right, for Flow-notification-enabled-on-talkpage-email-batch-body we probably do need a $1 cause it's an email [21:33:26] I... guess it's probably still the current user in this case [21:33:29] maybe, hopefully [21:42:52] RoanKattouw, I think it runs from a batch (processEchoEmailBatch.php), so we shouldn't count on it. [21:42:54] (03PS1) 10Catrope: Add GENDER support for flow-notification-enabled-on-talkpage-email-batch-body [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236968 [21:43:05] Oh right [21:49:37] (03PS1) 10Catrope: Add hint to use {{GENDER:|...}} to flow-talk-page-beta-feature-description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236969 [22:00:50] matt_flaschen, okay, I'm done (I hope!) with the urgent echo stuff. I've checked the guided tour, and it actually doesn't work onmy local machine either. The cookie doesn't seem to get set at all... :\ [22:02:21] mooeypoo, I assume you or at the latest Flow and GuidedTour commits. Make sure you are enabling opt-in on a fresh account (it only does it the first time). [22:02:54] matt_flaschen, yeah, I added it to where $this->createFlowBoard() is done in the OptInController.php [22:03:02] so the cookie is only set if we're creating a new board [22:03:17] and I tested on a brand new user with wikitext talk page which I then opted in [22:03:56] mooeypoo, okay, I didn't test that patch yet, so I'll test master now. [22:04:08] matt_flaschen: https://phabricator.wikimedia.org/T108760 -- it's weird but I cannot leave a message on user talk pages anymore [22:04:43] etonkovidova, on Beta? [22:04:45] Testing now. [22:05:01] matt_flaschen: yeah, leaving messages on converted Flow boards - it's called :responded to ... [22:05:07] matt_flaschen, I'm trying to var_dump stuff but I think the operation is running in the background [22:05:24] matt_flaschen, but I'm looking at the cookies tab in Chrome's "resources" in the console, and I don't see that cookie set [22:05:51] mooeypoo, it's HTTP-only, so it may not show in JavaScript/consoles. That should be fine since it only needs to be read by the server. [22:06:01] It should show in Chrome's full list of cookies, though. [22:06:41] It isn't :\ [22:06:48] wait, which list? [22:07:05] maybe I'm looking at the wrong place... [22:07:46] mooeypoo, chrome://settings/cookies [22:08:23] meh, can't see it there either [22:08:23] etonkovidova, to save me a little time, what is a Flow user talk page on Beta? [22:08:43] Okay, it should be. I will continue this after debugging etonkovidova's thing since that sounds a little more urgent. [22:09:03] * mooeypoo nods [22:09:52] matt_flaschen: I name users ET1 and ET2 etc [22:11:35] etonkovidova, okay, I added a new topic and (separately) replied at http://en.wikipedia.beta.wmflabs.org/wiki/User_talk:ET1 . When you say "cannot leave a message", what are the symptoms exactly? [22:12:38] matt_flaschen: if User talk page is converted to Flow - leaving messages there are not classified as 'left a message' but as 'responded to' [22:12:53] matt_flaschen: hmm... sounds like expected? [22:12:57] (03CR) 10Mooeypoo: [C: 032] Add hint to use {{GENDER:|...}} to flow-talk-page-beta-feature-description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236969 (owner: 10Catrope) [22:13:54] matt_flaschen: then, for a user without Flow user talk enabled - I left a message 34 min ago and it was displayed in Messages not in Alerts [22:13:55] etonkovidova, yeah, it doesn't have the same notifications when it's a Flow board, since the structure is different. [22:14:21] They should both now be in Messages now, and for Flow, it should have the appropriate message depending whether it was a new topic or reply to an existing one. [22:14:35] matt_flaschen: ok. [22:14:51] (03CR) 10Mooeypoo: [C: 032] Add GENDER support for flow-notification-enabled-on-talkpage-email-batch-body [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236968 (owner: 10Catrope) [22:15:19] (03Merged) 10jenkins-bot: Add hint to use {{GENDER:|...}} to flow-talk-page-beta-feature-description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236969 (owner: 10Catrope) [22:15:29] matt_flaschen: but I keep seeing 'left a message on your talk' page in Messages for user without enabled Flow [22:15:58] matt_flaschen: and what happened to View changes - completely disappeared [22:16:15] etonkovidova, yes, the notification hasn't changed. I just moved it from Alerts to Messages and allowed you to clear the orange bar by clicking the X or otherwise marking as read. [22:16:30] etonkovidova, 'View changes' shouldn't be gone. That sounds like a bug. [22:16:55] It should still be there for wikitext, not for Flow. [22:17:07] matt_flaschen: sigh... nope [22:17:18] (03Merged) 10jenkins-bot: Add GENDER support for flow-notification-enabled-on-talkpage-email-batch-body [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236968 (owner: 10Catrope) [22:17:33] etonkovidova, not for wikitext either? Yeah, please file a bug or move back to In Dev. [22:17:46] matt_flaschen: ok - thx [22:19:18] I confirmed it's treating it like a normal Flow board ("created a new topic on User talk:Mattflaschen" or "responded on User talk:Mattflaschen"). [22:22:40] (03CR) 10Mooeypoo: [C: 032] "Works great!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236726 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [22:24:21] (03CR) 10Mooeypoo: [C: 032] Use wikitext icon from OOUI for the VE->WT switch tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [22:26:21] (03Merged) 10jenkins-bot: Use wikitext icon from OOUI for the VE->WT switch tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [22:28:12] (03CR) 10Mooeypoo: [C: 032] VisualEditorWidget: Ensure toolbar is initialized after editor is attached [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236721 (owner: 10Catrope) [22:29:47] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-CologneBlue: Bug using Cologne Blue skin - https://phabricator.wikimedia.org/T111868#1618511 (10Krenair) [22:29:53] 6Collaboration-Team-Backlog, 10Flow: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist. - https://phabricator.wikimedia.org/T111771#1618515 (10Mattflaschen) Goo... [22:29:57] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-CologneBlue: Bug using Cologne Blue skin - https://phabricator.wikimedia.org/T111868#1618516 (10Krenair) Sounds like this might be #Echo related [22:30:03] 3Collaboration-Team-Current, 10Flow: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist. - https://phabricator.wikimedia.org/T111771#1618517 (10Mattflaschen) [22:30:39] (03PS1) 10Mattflaschen: Remove dead code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236978 (https://phabricator.wikimedia.org/T111771) [22:31:07] (03Merged) 10jenkins-bot: VisualEditorWidget: Ensure toolbar is initialized after editor is attached [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236721 (owner: 10Catrope) [22:31:28] (03CR) 10Mooeypoo: [C: 032] EditorSwitcherWidget: Move wikitext-specific styles to WikitextEditorWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236722 (owner: 10Catrope) [22:31:32] (03CR) 10Catrope: [C: 032] Remove dead code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236978 (https://phabricator.wikimedia.org/T111771) (owner: 10Mattflaschen) [22:32:01] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: ResourcesTest::testFileExistence: File '/mnt/jenkins-workspace/workspace/mediawiki-extensions-hhvm/src/extensions/Flow/modules/styles/flow/icons/ajax-loader.gif' referenced by 'ext.flow.ui' must exist. - https://phabricator.wikimedia.org/T111771#1618533 (... [22:32:46] Just wanted to finish that since it was really quick. Testing the GuidedTour thing now. [22:32:55] (03CR) 10Mooeypoo: [C: 032] "less Math ftw." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236723 (owner: 10Catrope) [22:33:48] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one grey button on personal bar - https://phabricator.wikimedia.org/T111871#1618535 (10Paladox) 3NEW [22:34:07] (03Merged) 10jenkins-bot: EditorSwitcherWidget: Move wikitext-specific styles to WikitextEditorWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236722 (owner: 10Catrope) [22:35:09] (03CR) 10Mooeypoo: [C: 032] mw.flow.ve.Target.less: Avoid magical margin-top on actions div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236724 (owner: 10Catrope) [22:35:51] (03Merged) 10jenkins-bot: Remove dead code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236978 (https://phabricator.wikimedia.org/T111771) (owner: 10Mattflaschen) [22:35:54] (03Merged) 10jenkins-bot: mw.flow.ve.Target.less: Apply font-size override to toolbar rather than target [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236723 (owner: 10Catrope) [22:37:01] Forgot to actually remove the file... [22:37:12] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Move "left a message on your talk page" Echo notification from Alerts to Messages - https://phabricator.wikimedia.org/T108760#1618556 (10Etonkovidova) "Username left a message on your t... [22:37:15] (03CR) 10Mooeypoo: [C: 032] Make VE and wikitext editors (almost) the same height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236725 (owner: 10Catrope) [22:37:52] (03Merged) 10jenkins-bot: mw.flow.ve.Target.less: Avoid magical margin-top on actions div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236724 (owner: 10Catrope) [22:39:49] (03Merged) 10jenkins-bot: Make VE and wikitext editors (almost) the same height [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236725 (owner: 10Catrope) [22:40:28] (03Merged) 10jenkins-bot: Replace the WT->VE switch button with an OOUI toolbar tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236726 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [22:41:19] (03PS1) 10Mattflaschen: Remove containing file as intended. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236981 (https://phabricator.wikimedia.org/T111771) [22:41:50] (03CR) 10Catrope: [C: 032] Remove containing file as intended. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236981 (https://phabricator.wikimedia.org/T111771) (owner: 10Mattflaschen) [22:44:15] (03Merged) 10jenkins-bot: Remove containing file as intended. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236981 (https://phabricator.wikimedia.org/T111771) (owner: 10Mattflaschen) [22:47:47] 6Collaboration-Team-Backlog, 10Echo: Revert echo back to one grey button on personal bar - https://phabricator.wikimedia.org/T111871#1618578 (10Paladox) [22:48:41] mooeypoo, I confirmed it doesn't work, and I know why. [22:49:00] Similar to what you said, it's running in a DeferredUpdate, which also occurs after the response is already sent. [22:49:26] This allows DeferredUpdates to take longer (though this is not the main reason we're using it in this case) without blocking the user's rendering, but also means the user will not get the cookie. [22:50:58] mooeypoo, you'll have to check in onUserSaveOptions whether they have an existing Flow board (OptInController->findLatestFlowArchive). If so, you can set the cookie. [22:51:26] mooeypoo, good news is you don't need to worry about race conditions due to the deferred update taking a while. There is already a check to make sure the first cookie is not deleted/tour is not shown until it's Flow. [22:52:00] Worst case scenario, the enable fails and the cookie sits around (mostly) harmlessly for 30 days. [22:52:02] Ooooh, is it trying to set the cookie from the DeferredUpdate? [22:52:23] ahha [22:52:30] Yes, because OptInController is called from OptInUpdate. [22:53:56] 3Collaboration-Team-Current, 10Echo, 5WMF-deploy-2015-09-08_(1.26wmf22): Echo makes the border of h1#firstHeading too short - https://phabricator.wikimedia.org/T111628#1618589 (10Etonkovidova) Checked in betalabs and on https://translatewiki.net/wiki/User:Amire80 Duplicate of https://phabricator.wikimedia.... [22:54:06] hm [22:55:27] matt_flaschen, "findLatestFlowArchive" is a private method. [22:55:37] I can make it public, but is that what you mean? [22:55:37] mooeypoo: given you guys are working on Echo right now - would it be a good time to pair with you and rewrite the mobile echo overlay in oojs ui and port it to the Echo extension? [22:55:49] (not as in right this minute but as in within the next week) [22:56:08] given you are in the office i suspect it would be a good knowledge transfer exercise [22:57:21] 6Collaboration-Team-Backlog, 10Flow: My user talk page in the Catalan and Hebrew Wikipedias has a category with a French name - https://phabricator.wikimedia.org/T111772#1618598 (10Mattflaschen) We're actually just waiting on Ops for {T111084}. Everything else we can do ourselves. [22:58:36] jdlrobson, ooui *should* theoretically (and hopefully practically) already be mobile-ready [22:58:57] so I think that pairing could be good -- but we *might* find out we need to adjust a few ooui things [22:59:07] since we've never actually done pure mobile ooui before, I don't think [22:59:35] We can definitely give it a try and see, though! [23:00:33] jdlrobson, so, ideally, we won't need to rewrite -- we will just need to "connect" the existing ooui popup to work on mobile, and adjust the styles [23:00:35] mooeypoo: my concern is fitting it into the mobile ecosystem :) [23:00:38] i'm sure it's mobile ready [23:00:47] (I'm not :P ) [23:01:01] my concern is making it work with things like our OverlayManager - but either way I think it would be a useful activity [23:01:03] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour, 7Documentation: Create a quick tour about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1618621 (10Mattflaschen) This could potentially use GuidedTour. [23:01:07] but yeah adjusting it into mobile ecosystem can be done wtih styles and specific adjustments, though [23:01:14] Yeah I think we can work it out [23:01:17] sweet [23:01:26] it will at least give us lots to think about [23:01:50] would thursday work for you or is that too soon? [23:02:15] Attaching it in X instead of Y is a relatively small issue... the bigger concern I have is how much code we'll hve to duplicate into the mobile feature... I think not much, but I am not sure how OO.ui.PopupButtonWidget() is working on mobile [23:02:25] Thursday works for me [23:02:29] But I'm off on Friday [23:02:56] mooeypoo: great. I'll set something up and we'll find out :) [23:03:11] jdlrobson, if nothing else, we can start with an exploratory experiment of what needs to be done... :D [23:03:28] awesome [23:04:54] mooeypoo: done [23:05:01] (03CR) 10Catrope: [C: 032] The return of the 'mark all as read' button [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236953 (owner: 10Mooeypoo) [23:05:07] (03CR) 10Catrope: [C: 032] Show unread notifications first in the popup [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236954 (owner: 10Mooeypoo) [23:05:14] (03CR) 10Catrope: [C: 032] Add a tooltip to the notification badges [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236956 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:05:18] (03CR) 10Catrope: [C: 032] Use #pt-notifications-alert to get Special:Notifications link [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236957 (https://phabricator.wikimedia.org/T111783) (owner: 10Mooeypoo) [23:07:25] (03Merged) 10jenkins-bot: The return of the 'mark all as read' button [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236953 (owner: 10Mooeypoo) [23:09:32] (03Merged) 10jenkins-bot: Show unread notifications first in the popup [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236954 (owner: 10Mooeypoo) [23:09:35] (03Merged) 10jenkins-bot: Add a tooltip to the notification badges [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236956 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:09:38] (03Merged) 10jenkins-bot: Use #pt-notifications-alert to get Special:Notifications link [extensions/Echo] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/236957 (https://phabricator.wikimedia.org/T111783) (owner: 10Mooeypoo) [23:12:53] 6Collaboration-Team-Backlog, 10Flow: Hidden a Flow post is against certain French Wikipedia policies - https://phabricator.wikimedia.org/T111778#1618653 (10Mattflaschen) It is true that Flow by default allows anyone to hide (flow-hide right) a comment. The corresponding history text in French is: ``` "flow-r... [23:13:24] 6Collaboration-Team-Backlog, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1618654 (10Mattflaschen) [23:13:37] 3Collaboration-Team-Current, 10Flow, 7I18n: French needs a different translation for hide vs. suppress in Flow - https://phabricator.wikimedia.org/T111778#1616288 (10Mattflaschen) [23:14:24] ^ If only we had someone who spoke French on our team... [23:15:01] i can ask someone if it helps :) [23:15:35] * ebernhardson just realized :) [23:17:37] matt_flaschen, ok I have a patch for the guided tour that works now [23:19:07] BUT I am running into another issue. The guided tour doesn't attach itself to the right elements. The second stage is completely gone even though I have an archive link. When I looked, the archive link doesn't have the class ".flow-link-to-archive" [23:25:12] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1618683 (10Etonkovidova) Try to create a new topic: 3afe20d7] Exception Caught: Conversion from 'html' to 'wikitext' was requested, but core's Parser onl... [23:26:55] mooeypoo, yeah, that's what I meant re findLatestFlowArchive. Sorry, not sure why I didn't see your question earlier. [23:29:21] (03PS1) 10Mooeypoo: [wip] Set the guided tour cookie in onUserSaveOptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236993 [23:29:36] matt_flaschen, are you sure we're using 'flow-link-to-archive' ? [23:29:45] I don't have it, and that makes the second tour step not show up [23:29:46] mooeypoo, yes, will give you the command in a second. [23:30:34] mooeypoo, delete Template:LQT_page_converted_to_Flow and Template:Wikitext_talk_page_converted_to_Flow, then run: [23:30:35] mwscript extensions/Flow/maintenance/FlowCreateTemplates.php --force [23:31:01] We'll have to do this in production too (and reinstate local modifications, if any, afterwards). [23:31:03] Will add a blocker. [23:31:05] gotcha [23:34:51] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1618707 (10Etonkovidova) Checked in betalabs in Chrome and FF. [23:36:22] (03PS2) 10Mooeypoo: Set the guided tour cookie in onUserSaveOptions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236993 [23:36:25] mooeypoo, is https://he.wikipedia.org/wiki/%D7%AA%D7%91%D7%A0%D7%99%D7%AA:%D7%93%D7%A3_%D7%A7%D7%95%D7%93_%D7%95%D7%99%D7%A7%D7%99_%D7%9E%D7%95%D7%9E%D7%A8_%D7%9C%D7%96%D7%A8%D7%99%D7%9E%D7%94 the right title for flow-importer-wt-converted-template? [23:36:26] matt_flaschen, ^^ [23:36:34] I'm a little confused since I don't see a 'page does not exist' message. [23:36:50] matt_flaschen, yes it looks like it [23:37:12] it literally says 'wiki page imported to flow' [23:37:14] or converted [23:37:20] Thanks [23:38:24] mooeypoo, oh, it does exist, but it's in includeonly. Man, that diff is confusing. Hopefully it's not as bad when you use Hebrew UI language. [23:38:39] ... it's a little as bad [23:38:41] :D [23:39:16] matt_flaschen, okay, that commit makes things work for me now. I'm just hoping i did things right, I added a public function to OptInController and took advantage of it in the hook [23:39:28] mooeypoo, that's what I meant. [23:42:09] mooeypoo, I guess in prod we should just manually add the class. That seems easier than my previous suggestion. Can you do Hebrew? Just that one, we don't need to worry about flow-importer-lqt-converted-template on any of these wikis. [23:43:38] dannyh, remind me to check this when we enable opt-in on new wikis (beyond cawiki, frwiki, hewiki, wikidatawiki). It should only be an issue on wikis that have been using Flow for a while, but I can check it easily. [23:46:21] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, 3Reading-Web: On mobile, the Flow notification's link takes you to the desktop version of the Flow page, even though the main (background) link takes you to the mobile one (main) - https://phabricator.wikimedia.org/T107108#1618772 (1... [23:50:38] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 3 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1618779 (10Mattflaschen) For the opt-in wikis, we need to add `` around t...