[00:00:13] (03PS1) 10Mooeypoo: Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 [00:00:18] RoanKattouw, ^^^^ !!!! [00:00:20] oops [00:00:41] whoops [00:00:58] (03CR) 10Catrope: [C: 032] Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [00:01:04] Yeah elena casually mentioned there are console errors when you click stuff [00:01:10] .... I verified. [00:01:11] mooeypoo: Did you see https://phabricator.wikimedia.org/T111285#1600236 ? [00:01:42] I did now [00:04:14] (03PS1) 10Mooeypoo: [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 [00:04:25] RoanKattouw, my initial work on the saveable toggle thing ^^ [00:04:39] RoanKattouw, I just need to see how I'm setting "initial content" (model?) in VE [00:04:43] breakpoint, no? [00:05:00] I did this before, I just don't remember quite the details [00:05:31] (03CR) 10jenkins-bot: [V: 04-1] Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [00:06:44] (03PS2) 10Mooeypoo: [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 [00:06:51] what tha [00:07:09] * mooeypoo grunts [00:09:16] (03CR) 10jenkins-bot: [V: 04-1] [wip] Toggle the save button when there are changes to the content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235646 (owner: 10Mooeypoo) [00:16:09] mooeypoo: Hrmph... that's not very well supported. Talk to Ed :S [00:17:24] RoanKattouw, I saw no other option than to explicitly tell the editor(s) "THIS is where you store your initial content" [00:17:28] but we can/should go over this [00:17:36] Yeah, will do later [00:17:39] Sorry, working on an urgent thing [00:18:05] RoanKattouw, so, the timestamp thing is an Unbreak Now! but I am not sure I can do it without legoktm [00:18:24] legoktm, are you still around? [00:18:25] He said "just make it a pipe-separated field" [00:18:35] You can look at his patch to see how the timestamp is stored [00:18:35] I was joking! [00:18:38] ... [00:18:40] LOL [00:18:41] rofl [00:18:47] omg heart attack for me, thank you. [00:18:56] lol [00:19:03] I was offended by it but I actually did think he was serious [00:19:16] Anyway, look at his recent commit (which I merged an hour ago), and split the entry [00:19:20] which patch... [00:19:20] Shouldn't be too difficult [00:19:24] we just need to make the API module take another parameter [00:19:26] oh [00:19:28] https://gerrit.wikimedia.org/r/#/c/233639/ [00:19:31] legoktm, "just" ? [00:20:06] do you want me to do it? :P [00:20:17] hehe nah, I think I see [00:20:25] if I drown, I"ll let you know. [00:20:31] Hopefully before I drown. [00:20:52] I can just invent my own JsConfigVars though? [00:21:07] like.. if I'm splitting, we'll have 2 instead of the current one, and they will both be different than what we had [00:21:33] Which would also mean we're going to screw up previous seen time unless I keep it for backwards compatibility [00:22:26] mooeypoo: Yes, you can invent your own config vars, but in this case I recommend changing the type of wgEchoWhatever from a string to an array of strings [00:22:35] config vars can be rich types, as long as they're JSON-able [00:23:02] hmm [00:25:16] hm [00:25:45] legoktm, is it just me, or is EchoSeenTime::getTime $data = .... picking the wrong key now? [00:26:04] it's getting echo-seen-time instead of your new wgEchoSeenTime [00:26:10] is that on purpose for backwards capabilities? [00:26:53] it first checks the db-replicated cache, then falls back to user options for back-compat [00:27:03] but you changed the name of the user option, no? [00:27:41] it's now mw.config.get( 'wgEchoSeenTime' ); [00:27:45] not echo-seen-time [00:27:51] Different key in a different system [00:27:57] umm, on client-side yes [00:28:16] so do I create echo-seen-alert-time and echo-seen-msg-time ? [00:28:35] Let me come downstairs [00:32:15] I thought we were going to have a meeting about that. [00:32:53] huh [00:32:53] Oh never mind, this is the initial fix to split alert/message seen time. [00:32:56] Yeah [00:32:58] Right [00:33:03] This is the UBN part of it [01:11:37] (03PS1) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [01:13:06] (03CR) 10jenkins-bot: [V: 04-1] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:15:54] (03PS2) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [01:17:21] (03CR) 10jenkins-bot: [V: 04-1] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:18:08] (03PS3) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [01:19:06] (03CR) 10Mooeypoo: [C: 032] "..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [01:19:16] (03CR) 10jenkins-bot: [V: 04-1] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:20:09] mooeypoo: 01:18:33 /srv/deployment/integration/slave-scripts/bin/mw-install-mysql.sh: line 22: 14885 Segmentation fault (core dumped) php maintenance/install.php --confpath "$MW_INSTALL_PATH" --dbtype=mysql --dbserver="$MW_DB_HOST:$MW_DB_PORT" --dbuser="$MW_DB_USER" --dbpass="$MW_DB_PASS" --dbname="$MW_DB" --pass testpass TestWiki WikiAdmin [01:20:34] (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [01:20:56] (03CR) 10jenkins-bot: [V: 04-1] Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [03:15:16] (03PS9) 10Krinkle: Update extension registration system for MoodBar [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/223539 (https://phabricator.wikimedia.org/T87942) (owner: 10Niharika29) [03:15:21] (03PS10) 10Krinkle: Update extension registration system for MoodBar [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/223539 (https://phabricator.wikimedia.org/T87942) (owner: 10Niharika29) [05:20:40] 6Collaboration-Team-Backlog, 10MoodBar, 7I18n: Untranslatable timestamps in moodbar-feedback-response-helpful-summary, moodbar-feedback-response-summary - https://phabricator.wikimedia.org/T69965#1601017 (10Liuxinyu970226) [05:35:09] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Undefined indices in TopicFormatter - https://phabricator.wikimedia.org/T95957#1601041 (10demon) p:5High>3Low From looking at the code, it doesn't look like the one on line 67 (at the time, now 68), is possible anymore....as of rEFLW720d146e. Un... [06:02:48] (03CR) 10Legoktm: "minor" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [06:14:26] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [06:29:22] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Gender support for "flow-edited-by" - https://phabricator.wikimedia.org/T99301#1601116 (10Liuxinyu970226) [09:20:42] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1601349 (10jcrespo) p:5Unbreak!>3Triage [09:20:46] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1601351 (10jcrespo) a:3jcrespo [09:35:26] (03CR) 10Paladox: [C: 031] Update extension registration system for MoodBar [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/223539 (https://phabricator.wikimedia.org/T87942) (owner: 10Niharika29) [09:54:29] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1601424 (10jcrespo) I've executed the scripts: * https://git.wikimedia.org/blob/me... [10:24:37] (03PS1) 10Matthias Mullie: Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) [10:27:08] (03CR) 10jenkins-bot: [V: 04-1] Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [10:29:25] 3Collaboration-Team-Current, 10Flow, 7Regression: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1601623 (10matthiasmullie) a:3matthiasmullie [12:55:46] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1601980 (10Tbayer) Confirming that I was just able to save a comment with links (h... [14:22:37] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage: Tech News should not use wikitext in topic titles in topics intended for Flow pages - https://phabricator.wikimedia.org/T104914#1602300 (10Johan) Is there a simpler way of finding out which pages on the Tech News distribution list are Flow pages? [14:40:09] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage: Tech News should not use wikitext in topic titles in topics intended for Flow pages - https://phabricator.wikimedia.org/T104914#1602404 (10Trizek-WMF) Is it not preferable to remove wikitext from titles? On French Wikipedia it is a discouraged practice (but... [14:43:23] 6Collaboration-Team-Backlog, 10Flow: Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1602419 (10Trizek-WMF) 3NEW a:3Trizek-WMF [14:43:51] 6Collaboration-Team-Backlog, 10Flow, 7Design: Visual design for new Flow indentation model - https://phabricator.wikimedia.org/T88865#1602429 (10Trizek-WMF) [14:43:53] 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q1. New model for indentation (French, Catalan) - https://phabricator.wikimedia.org/T88501#1602430 (10Trizek-WMF) [15:52:14] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email: Launch ECHO notification when sending user e-mail - https://phabricator.wikimedia.org/T111347#1602691 (10Aklapper) [15:57:56] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email: Launch Echo notification when sending user e-mail - https://phabricator.wikimedia.org/T111347#1602709 (10Legoktm) [16:05:37] legoktm: hello there:) I am checking https://phabricator.wikimedia.org/T110945 "Dates missing on Special:Notifications in many languages" [16:06:09] legoktm: and if I do not see dates on http://127.0.0.1:8080/w/index.php?title=Special:Notifications&uselang=fy - that means that the fix does not apply retractively? [16:06:32] legoktm: or I did not update my local machine? [16:06:43] are you using the latest version of MediaWiki core? [16:13:27] etonkovidova: http://i.imgur.com/b82rieq.png [16:14:25] legoktm: ok, hmm... means that I did not update properly. Thx! [16:14:27] ךקעםת בשמ טםו עם םהקר איק בםצצןא? [16:14:29] ... [16:14:34] once again, with feeling [16:14:48] legoktm, can you go over the commit? [16:14:55] which one? [16:15:10] the one I worked on yesterday, let me paste [16:15:16] https://gerrit.wikimedia.org/r/#/c/235659/ [16:15:24] legoktm, I fixed up the.. uh.. "problem" I had :P [16:15:57] I think all I"m missing is the documentation of the API stuff? I'm not sure I did that right. But the entire way things work, I could use a second pair of eyes of someone who actually knows how this thing works. [16:16:11] oh you went over it [16:16:24] legoktm, i missed the fact you wrote comments... ha ignore me. [16:16:59] :) [16:18:09] (03CR) 10Mooeypoo: Separate 'seen time' for alerts and messages (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [16:21:14] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1602765 (10Mattflaschen) >>! In T111254#1601424, @jcrespo wrote: > I've executed t... [16:21:26] legoktm, right now the API validates the type ("Allowed type" is set up as 'message', 'alert' or 'all') but the SeenTime.php doesn't... we're assuming whatever uses it knows. But technically speaking, if someone goes "setTime( time, 'foobar' ) it will store foobar key in the cache.... and yet, this is an internal thing; the external is managed by the API anyways. Should I set up allowed types in SeenTime too or is that unnecessary? [16:23:45] mooeypoo: if you want. We should be able to trust PHP code, but it's a good line of defense if someone makes a typo in the future or something [16:24:14] ok [16:24:27] legoktm: I can see Dates now :) [16:24:39] yay :D [16:27:10] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1602783 (10Mattflaschen) [16:31:22] meh, anyone knows what's up with this failure? IT's the second time we're trying to +2 it, and it's actually pretty urgent :( https://gerrit.wikimedia.org/r/#/c/235643/ [16:32:27] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Take out "This description has been modified" line in side rail legal text - https://phabricator.wikimedia.org/T110082#1602837 (10DannyH) 5Open>3Resolved [16:33:59] 3Collaboration-Team-Current, 10Echo, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Dates missing on Special:Notifications in many languages - https://phabricator.wikimedia.org/T110945#1602867 (10Etonkovidova) Checked locally - e.g. http://127.0.0.1:8080/w/index.php?title=Specia... [16:34:24] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Cancel keeps temporary text in editors - https://phabricator.wikimedia.org/T109365#1602872 (10DannyH) 5Open>3Resolved [16:34:49] 3Collaboration-Team-Current, 10Echo, 5MW-1.26-release, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Dates missing on Special:Notifications in many languages - https://phabricator.wikimedia.org/T110945#1602877 (10DannyH) 5Open>3Resolved [16:35:03] 3Collaboration-Team-Current, 10Echo, 5MW-1.26-release, 5Patch-For-Review, and 2 others: Dates missing on Special:Notifications in many languages - https://phabricator.wikimedia.org/T110945#1590690 (10DannyH) [16:36:38] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change, 7WorkType-NewFunctionality: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1602897 (10DannyH) [16:36:39] etonkovidova, did you submit a task about the split notifications bug you told me yesterday? [16:36:50] etonkovidova, the one where clicking a notifications caused console errors? [16:37:19] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-Maintenance: Switch Flow to use Parsoid v3 API with VirtualRESTService - https://phabricator.wikimedia.org/T110721#1602912 (10DannyH) [16:37:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Warn the user if they cancel an editor with data in it - https://phabricator.wikimedia.org/T111115#1602913 (10DannyH) [16:37:35] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Fix Flow Parsoid integration on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T111119#1602915 (10DannyH) [16:38:39] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Adjust to removal of Connection::getSingleton in Cirrus - https://phabricator.wikimedia.org/T111164#1602920 (10DannyH) [16:38:43] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkType-NewFunctionality: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1602921 (10DannyH) [16:38:49] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Use EditorWidget for topic summary - https://phabricator.wikimedia.org/T111102#1602922 (10DannyH) [16:39:26] mooeypoo, looking at Jenkins. [16:39:42] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Split seen timestamp for alerts and messages - https://phabricator.wikimedia.org/T111285#1602926 (10DannyH) [16:39:49] 3Collaboration-Team-Current, 7WorkType-NewFunctionality: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1602928 (10DannyH) [16:39:57] 3Collaboration-Team-Current, 7WorkType-Maintenance: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1599880 (10DannyH) [16:40:12] mooeypoo, this is the same thing RoanKattouw_away brought up yesterday. Do you know if he filed it? [16:40:16] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1602939 (10DannyH) [16:40:18] mooeypoo: no, I did not file anything regarding split notifications [16:40:23] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowCreateTemplates.php on all Flow-enabled wikis in production - https://phabricator.wikimedia.org/T111098#1602940 (10DannyH) [16:41:49] matt_flaschen, I'm getting a bad bad bad bug in all my flow boards. Anything I post from any user, comes back with "Due to a technical error, this post could not be retrieved" :(( [16:42:07] etonkovidova, okay, 'cause there's a fix on the way [16:42:19] mooeypoo, update your MediaWiki-Vagrant and reprovision. Sounds like it might be the Parsoid thing I fixed. [16:42:25] * mooeypoo nods [16:42:48] (03CR) 10Mattflaschen: [C: 032] "Per Catrope. Sounds like it was https://phabricator.wikimedia.org/T111369 ." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [16:43:26] mooeypoo, update meaning git pull in MWV, vagrant git-update shouldn't be needed. [16:43:36] mooeypoo: if you wish - you may file a bug or, if it's small enough, just to add it as a comment to the big task https://phabricator.wikimedia.org/T108190 [16:43:39] oh, ok, doing that now [16:44:04] etonkovidova, okay, it's merging [16:44:35] mooeypoo: yay [16:44:43] (03Merged) 10jenkins-bot: Correct 'primaryLink' to 'primaryUrl' everywhere [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235643 (owner: 10Mooeypoo) [16:44:58] yay, thanks matt_flaschen [16:45:26] No problem, all I did was search Maniphest. :) [16:46:31] (03PS4) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [16:50:41] 3Collaboration-Team-Current, 10Flow: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1603041 (10DannyH) a:5Pginer-WMF>3None [16:51:26] 3Collaboration-Team-Current, 10Flow: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1568505 (10DannyH) The first mockup works great. I agree that dismissing it isn't necessary; you can dismiss it by logging in. :) Thanks, Pau! [16:54:37] 6Collaboration-Team-Backlog, 10Flow: Logged out warning is un-dismissable - https://phabricator.wikimedia.org/T108836#1603089 (10DannyH) 5Open>3declined a:3DannyH Yes, I think this is solved by T110086 -- the problem here was obscuring content in the side rail. With the message on top, that's not a probl... [17:29:10] 6Collaboration-Team-Backlog, 10Flow: Split notifications: the same oo-ui-icon-bell used for oo-ui-popupWidget-head Alerts and Messages - https://phabricator.wikimedia.org/T111411#1603265 (10Etonkovidova) 3NEW [17:32:57] * legoktm stabs hangouts [17:33:16] "Please wait..." [17:34:31] there we go [17:46:30] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1603408 (10Mattflaschen) [17:46:33] 3Collaboration-Team-Current, 10Flow, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1603407 (10Mattflaschen) [17:53:57] (03PS3) 10Legoktm: Move edit-user-talk to messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231736 (https://phabricator.wikimedia.org/T108760) (owner: 10Mattflaschen) [17:54:10] (03CR) 10Legoktm: "PS3: Rebased" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231736 (https://phabricator.wikimedia.org/T108760) (owner: 10Mattflaschen) [17:56:20] (03CR) 10Legoktm: Move edit-user-talk to messages (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231736 (https://phabricator.wikimedia.org/T108760) (owner: 10Mattflaschen) [17:57:49] quiddity: I think the echo flyout split + moving user-talk to messages is big enough to warrant a separate email to wikitech-ambassadors [17:58:28] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1603446 (10Mooeypoo) This should be fixed with the new popup, even just for the fact it shows progress as it loads... we should... [17:58:46] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Echo flyout takes too long to open - https://phabricator.wikimedia.org/T56486#1603447 (10Legoktm) 5Open>3Resolved a:3Legoktm With {1ac72cc01ab511605cbf55b1177991dbcf974228} there is now immediate feedback to the user when they click on the badge. [17:59:00] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Echo flyout takes too long to open - https://phabricator.wikimedia.org/T56486#1603451 (10Legoktm) a:5Legoktm>3Mooeypoo [17:59:21] legoktm, agreed. When is that likely to be merged? For next week's deployment train? [17:59:34] quiddity: yes [17:59:50] Woo: http://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Jdforrester_(WMF) [17:59:57] Yay BetaFeatureFlow. [18:03:23] James_F: someone posted on your talk page too! [18:03:38] legoktm: Gosh, fancy that. :-) [18:04:03] legoktm: Though Apex isn't installed on BC yet. [18:04:12] ?useskin=monobook! [18:06:03] quiddity, legoktm: It isn't just likely to be merged, it has already been merged :) [18:06:17] RoanKattouw_away: only half of it :P [18:06:18] It was merged yesterday but we forgot to enable it on beta until half an hour ago [18:06:31] Oh, right, moving user talk [18:06:49] legoktm: ?useskin=apex. :-P [18:23:32] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1603520 (10Catrope) [18:23:59] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1599306 (10Catrope) Turns out this was only broken on the test wiki in beta, not in English beta. I've submitted a patch that I think might fix this. [18:29:21] pginer: What is the hex color value of the blue background in the anon warning mockup? [18:36:59] 3Collaboration-Team-Current, 10Flow: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1603581 (10Catrope) {F2538069} Icon compressed with `svgo` and with the bounding box corrected to 24x24 (was 24x23). [18:37:36] 3Collaboration-Team-Current, 10Flow: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1603583 (10Catrope) >>! In T110086#1591975, @Pginer-WMF wrote: > A mockup below illustrates the idea: > > {F2524072} > This looks great, thanks Pau! What is the hex value of the color blue you're... [18:47:58] Hey Flow team have you seen any unit tests failures recently to do with "ext.flow: mediawiki.ui.enhance Forms with required fields have certain buttons disabled by default FAILED Buttons with data-role=action are disabled when required fields are empty." [18:48:39] (03CR) 10Catrope: [C: 031] Adjust to removal of Connection::getSingleton in Cirrus [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [18:49:18] (03CR) 10Catrope: [C: 04-1] Adjust to removal of Connection::getSingleton in Cirrus (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235699 (https://phabricator.wikimedia.org/T111164) (owner: 10Matthias Mullie) [18:50:28] 6Collaboration-Team-Backlog, 10Flow: [Regression] betalabs - a horizontal line after firstHeading is not fully displayed - https://phabricator.wikimedia.org/T111427#1603617 (10Etonkovidova) 3NEW [18:53:41] (03CR) 10Catrope: [C: 032] Require a Language object in DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235520 (owner: 10Legoktm) [18:56:29] (03Merged) 10jenkins-bot: Require a Language object in DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235520 (owner: 10Legoktm) [18:57:41] (03CR) 10Catrope: [C: 04-1] Separate 'seen time' for alerts and messages (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [19:00:50] 3Collaboration-Team-Current, 10Flow: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1603638 (10Pginer-WMF) >>! In T110086#1603583, @Catrope wrote: >>>! In T110086#1591975, @Pginer-WMF wrote: >> A mockup below illustrates the idea: >> >> {F2524072} >> > This looks great, thanks Pa... [19:01:54] jdlrobson, unit tests, or browser tests? [19:03:49] https://gerrit.wikimedia.org/r/#/c/235643/ was merged just a couple hours ago, so unit tests should be fine. [19:04:03] Getting lunch [19:12:41] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Error after enabling flow on a page - https://phabricator.wikimedia.org/T111429#1603684 (10MarkAHershberger) 3NEW [19:29:06] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Error after enabling flow on a page - https://phabricator.wikimedia.org/T111429#1603734 (10MarkAHershberger) Ran into this again without a backtrace. Might be my MW checkout. [19:29:56] 6Collaboration-Team-Backlog, 10Flow: Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1603735 (10Etonkovidova) 3NEW [19:41:01] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1603778 (10Etonkovidova) Checked in betalabs - all events(edits, thanks, adding topics on watched pages, mentio... [20:06:39] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Error after enabling flow on a page - https://phabricator.wikimedia.org/T111429#1603882 (10Mattflaschen) What version of MW and Flow do you have (if git, commit(s))? [20:11:20] (03CR) 10Mooeypoo: [C: 032] "Okay, we need to rethink the firing of events for either format and content, but I don't see this as a blocker." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231483 (owner: 10Catrope) [20:13:50] (03Merged) 10jenkins-bot: Eliminate two API requests for board description fixed-html on load [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231483 (owner: 10Catrope) [20:15:55] (03PS5) 10Mooeypoo: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) [20:18:06] matt_flaschen, remember my earlier failure with "Due to a technocal error..." ? I've updated mw core + composer update + maintainance/update.php.... now I get this error: "[c3b0460c] Exception Caught: Conversion from 'html' to 'wikitext' was requested, but core's Parser only supports 'wikitext' to 'html' conversion" [20:18:08] :\ [20:20:02] mooeypoo, did you update MediaWiki-Vagrant and re-provision? [20:20:15] Meaning git pull in MWV repo. [20:24:06] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Error after enabling flow on a page - https://phabricator.wikimedia.org/T111429#1604026 (10MarkAHershberger) Flow: 576f705 (REL1_25) MediaWiki: 76e04b0 (1.25.1) [20:33:05] matt_flaschen, no, I'll do that now [20:33:12] i thought it was only mw core repo [20:33:46] 6Collaboration-Team-Backlog, 10Flow: Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1604118 (10Catrope) Is #3 specific to Chrome? [20:35:53] 6Collaboration-Team-Backlog, 10Flow: Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1604134 (10Mooeypoo) >>! In T111432#1604118, @Catrope wrote: > Is #3 specific to Chrome? It's happening because we're redrawing after the silly scrollbars appear :( I don't know how to fi... [20:37:23] 6Collaboration-Team-Backlog, 10Flow: Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1604139 (10Catrope) >>! In T111432#1604134, @Mooeypoo wrote: >>>! In T111432#1604118, @Catrope wrote: >> Is #3 specific to Chrome? > > It's happening because we're redrawing after the sil... [20:49:54] (03PS1) 10Catrope: Unbreak update.php for wikis using MW_INSTALL_PATH [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235860 [21:02:51] 6Collaboration-Team-Backlog, 10Flow: Split notifications: minor display issues - https://phabricator.wikimedia.org/T111432#1604212 (10Etonkovidova) Yes, #3 seems to be specific to Chrome. There is another teeny-tiny annoyance which presents only in FF - watch for a space above number in small notification... [21:10:17] (03CR) 10Catrope: [C: 032] Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [21:12:35] 3Collaboration-Team-Current, 10Beta-Cluster, 7WorkType-Maintenance: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1604260 (10bd808) ``` Traceback (most recent call last): File "/usr/local/bin/wmf-beta-update-databases.py", line 98, in sys.exit(main()) File "/usr/local... [21:14:40] (03CR) 10Alex Monk: [C: 032] Unbreak update.php for wikis using MW_INSTALL_PATH [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235860 (owner: 10Catrope) [21:15:28] 3Collaboration-Team-Current, 10Beta-Cluster, 7WorkType-Maintenance: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1604281 (10bd808) Results from manual run on deployment-bastion: ``` $ sudo -u jenkins-deploy /usr/local/bin/mwscript update.php --wiki=enwiki --quick Catchable fatal er... [21:17:09] (03Merged) 10jenkins-bot: Separate 'seen time' for alerts and messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235659 (https://phabricator.wikimedia.org/T111285) (owner: 10Mooeypoo) [21:18:02] 6Collaboration-Team-Backlog, 10Flow, 7Regression: [Regression] betalabs - a horizontal line after firstHeading is not fully displayed - https://phabricator.wikimedia.org/T111427#1604297 (10Aklapper) [21:19:49] (03Merged) 10jenkins-bot: Unbreak update.php for wikis using MW_INSTALL_PATH [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235860 (owner: 10Catrope) [21:20:50] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235879 [21:25:12] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235884 [21:25:20] (03PS1) 10Mooeypoo: Fix the badge icon update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235885 (https://phabricator.wikimedia.org/T111432) [21:25:54] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235886 [21:27:44] (03CR) 10jenkins-bot: [V: 04-1] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235886 (owner: 10Jforrester) [21:29:35] (03PS1) 10Mooeypoo: Add a border between the popup head and notification list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235891 (https://phabricator.wikimedia.org/T111432) [21:33:02] (03CR) 10Catrope: [C: 032] Add a border between the popup head and notification list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235891 (https://phabricator.wikimedia.org/T111432) (owner: 10Mooeypoo) [21:34:54] (03Merged) 10jenkins-bot: Add a border between the popup head and notification list [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235891 (https://phabricator.wikimedia.org/T111432) (owner: 10Mooeypoo) [21:36:05] (03PS2) 10Mooeypoo: Fix the badge icon update [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235885 (https://phabricator.wikimedia.org/T111432) [21:38:34] 6Collaboration-Team-Backlog, 10Flow, 10MassMessage: Tech News should not use wikitext in topic titles in topics intended for Flow pages - https://phabricator.wikimedia.org/T104914#1604432 (10Mattflaschen) >>! In T104914#1439679, @DannyH wrote: > Yeah, I think we should address how to include certain wikitext... [21:40:30] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1604435 (10Mattflaschen) See https://www.mediawiki.org/wiki/Extension:Flow#Moderation for part of this. [21:42:45] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email: Launch Echo notification when sending user e-mail - https://phabricator.wikimedia.org/T111347#1604447 (10Mattflaschen) [21:42:47] 6Collaboration-Team-Backlog, 10Echo: Provide web notifications when user is sent an email via Special:Emailuser - https://phabricator.wikimedia.org/T56130#1604448 (10Mattflaschen) [21:43:06] matt_flaschen: Now that wmf21 is everywhere, what's the next step for "Segregate reference objects"? [21:43:26] Sorry I keep asking, I never completely internalized the sequence of steps there [21:44:35] * RoanKattouw reads the list of steps at https://gerrit.wikimedia.org/r/#/c/136280/ [21:44:37] RoanKattouw, ask ops to do the SQL backfill (https://gerrit.wikimedia.org/r/#/c/136280/). I will update the task [21:44:47] Right that's what I thought [21:44:58] I wasn't sure if $wgFlowMigrateReferenceWiki had been set already [21:46:21] Oh yes it has [21:46:34] 3Collaboration-Team-Current, 10Flow, 7Schema-change, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1604464 (10Mattflaschen) [21:48:09] matt_flaschen: Just to be completely clear, "soon" in https://phabricator.wikimedia.org/T111084 is now, right? [21:48:27] RoanKattouw, yes, that's the task I'm updating. [21:48:37] OK thanks [21:48:44] Sorry, I didn't realize you were still updating it [21:50:39] (03PS1) 10Mooeypoo: Don't wait for the API to update seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235899 [21:51:58] 3Collaboration-Team-Current, 10Flow, 7Schema-change, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1604476 (10Mattflaschen) [21:52:23] 3Collaboration-Team-Current, 10Flow, 7Schema-change, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1604477 (10Mattflaschen) p:5Lowest>3Triage [21:52:40] 3Collaboration-Team-Current, 10Flow, 7Schema-change, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1593860 (10Mattflaschen) [21:52:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1604481 (10Mattflaschen) [21:53:08] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1489595 (10Mattflaschen) [21:53:28] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, and 2 others: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1489595 (10Mattflaschen) [21:53:52] Updated [21:54:10] (03CR) 10Jforrester: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235886 (owner: 10Jforrester) [22:02:21] (03PS2) 10Mooeypoo: Don't wait for the API to update seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235899 [22:05:35] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in test beta labs - https://phabricator.wikimedia.org/T111249#1604528 (10Mattflaschen) p:5Unbreak!>3High [22:05:36] (03CR) 10Catrope: [C: 04-1] Don't wait for the API to update seen time (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235899 (owner: 10Mooeypoo) [22:07:02] (03PS3) 10Mooeypoo: Don't wait for the API to update seen status of notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235899 [22:07:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, and 2 others: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1604533 (10Catrope) Details for steps 4 and 5 (which is why this task is blocked on ops right now) are in {T111084} [22:07:57] (03CR) 10Catrope: [C: 032] Don't wait for the API to update seen status of notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235899 (owner: 10Mooeypoo) [22:08:57] 3Collaboration-Team-Current, 10Beta-Cluster, 7WorkType-Maintenance: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1604540 (10Mattflaschen) See also https://gerrit.wikimedia.org/r/#/c/235860/1 but that didn't fix it. [22:13:02] (03Merged) 10jenkins-bot: Don't wait for the API to update seen status of notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235899 (owner: 10Mooeypoo) [22:17:08] (03CR) 10Krinkle: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235884 (owner: 10Jforrester) [22:17:14] (03CR) 10Krinkle: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235879 (owner: 10Jforrester) [22:20:51] 6Collaboration-Team-Backlog, 10Flow: Flaky test "ext.flow: mediawiki.ui.enhance Forms with required fields" - https://phabricator.wikimedia.org/T111459#1604612 (10Krinkle) 3NEW [22:21:23] 6Collaboration-Team-Backlog, 10Flow: Flaky test "ext.flow: mediawiki.ui.enhance Forms with required fields" - https://phabricator.wikimedia.org/T111459#1604628 (10Krinkle) p:5Triage>3High [22:23:37] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235884 (owner: 10Jforrester) [22:23:40] (03CR) 10jenkins-bot: [V: 04-1] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235879 (owner: 10Jforrester) [22:24:18] Fun. [22:34:48] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Flaky test "ext.flow: mediawiki.ui.enhance Forms with required fields" - https://phabricator.wikimedia.org/T111459#1604677 (10Mattflaschen) [22:35:20] (03CR) 10Mattflaschen: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235879 (owner: 10Jforrester) [22:35:34] (03CR) 10Mattflaschen: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235879 (owner: 10Jforrester) [22:35:54] James_F, not sure why that QUnit failure started up. We'll look at it. [22:36:15] mooeypoo, why does BoardDescriptionWidget default to plaintext (noticed this when grepping for plaintext for the topic title change)? [22:37:21] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235879 (owner: 10Jforrester) [22:37:57] (03PS1) 10Mooeypoo: Create an 'initiallyUnseen' class for initially unseen notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235909 [22:37:59] Seems it would be better not to default it and to require a format being passed in, since there is no way the description should be plaintext. [22:38:31] (03CR) 10Catrope: [C: 032] Create an 'initiallyUnseen' class for initially unseen notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235909 (owner: 10Mooeypoo) [22:38:46] hm [22:39:05] matt_flaschen, uh.. where? [22:39:36] it's defaulting to wikitext [22:39:38] contentFormat = this.editor.getInitialFormat() || 'wikitext'; [22:39:56] matt_flaschen: Thanks. [22:40:00] but the 'getInitialFormat()' defaults to that too, I think, actually, which makes this default redundant [22:40:02] mooeypoo, https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow.git/321409f0370f4f99e19a136f6a1fbc8f93c198b3/includes%2FOOUI%2FBoardDescriptionWidget.php#L10 [22:40:09] Sorry, I should have clarified. [22:40:16] (03Merged) 10jenkins-bot: Create an 'initiallyUnseen' class for initially unseen notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235909 (owner: 10Mooeypoo) [22:40:18] oh the php side! [22:40:21] eek [22:40:41] mooeypoo, it's probably never hit (always gets set to non-default). If you agree, I can have it throw when it's not passed in. [22:40:46] And drop the deafult. [22:40:56] matt_flaschen, good catch, oops. It shouldn't ever default, but yeah, if anything, default should be wikitext [22:41:03] yeah that sounds good [22:41:13] actually [22:41:26] matt_flaschen, instead of throw, we should default on fixed-html... this is the "view" piece anyways [22:41:50] I can't imagine a scenario where you'd need it in any other format, honestly. It's the html widget [22:42:09] The default should definitely be fixed-html which would allow all other instances that use it to just not specify anything [22:42:50] mooeypoo, yeah, but it's also already passed in everywhere, right? [22:43:00] I feel like we over-use defaults a little bit. It can make it harder to refactor in some cases. [22:43:07] I don't feel strongly about it in this case. [22:43:35] matt_flaschen, yes from handlebars [22:44:03] but logically speaking, it probably should be defaulting to fixed html. In an imaginary world where we one day get rid of handlebars in Flow, then it will matter. [22:44:28] But since that's a bit of a stretch for now, i think throwing isa good option. [22:44:41] At the very least, it would remind our grandchildren to replace it to something else. [22:44:45] Okay. [22:46:30] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Extension-setup: Installation of Flow on fr.wikt - https://phabricator.wikimedia.org/T73330#1604711 (10Krenair) [22:49:00] 6Collaboration-Team-Backlog, 10Flow: Installation of Flow on fr.wikt - https://phabricator.wikimedia.org/T73330#1604719 (10Krenair) [22:52:26] 6Collaboration-Team-Backlog, 10Flow: Installation of Flow on fr.wikt - https://phabricator.wikimedia.org/T73330#1604724 (10MarcoAurelio) @jackpotte I was told to say you that you please migrate the request to https://www.mediawiki.org/wiki/Flow/Request_Flow_on_a_page - Looks that they're handling this over the... [22:52:59] 6Collaboration-Team-Backlog, 10Flow: Installation of Flow on fr.wikt - https://phabricator.wikimedia.org/T73330#1604726 (10Mattflaschen) It's enabled there now. You can coordinate with @DannyH and @quiddity on initial pages. [22:53:06] 6Collaboration-Team-Backlog, 10Flow: Installation of Flow on fr.wikt - https://phabricator.wikimedia.org/T73330#1604728 (10Mattflaschen) p:5Low>3Triage [22:54:37] 6Collaboration-Team-Backlog, 10Flow: give willing people an easy way to volunteer their user talk pages as a testing ground for Flow - https://phabricator.wikimedia.org/T90383#1604732 (10Mattflaschen) [22:54:38] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 2 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1604733 (10Mattflaschen) [22:54:52] 6Collaboration-Team-Backlog, 10Echo: Provide web notifications when user is sent an email via Special:Emailuser - https://phabricator.wikimedia.org/T56130#1604735 (10matmarex) This should be easy enough to implement. * In core, the `EmailUserComplete` hook needs to be extended to give the User objects, and not... [23:05:31] matt_flaschen: happened again here - https://gerrit.wikimedia.org/r/#/c/235883/ https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/9983/console [23:05:38] test seems kinda flakey [23:05:40] not sure why [23:06:29] I'll try to look at it today, but there's also a problem on Beta. [23:17:15] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235932 [23:21:25] (03CR) 10jenkins-bot: [V: 04-1] build: Updating development dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235932 (owner: 10Legoktm) [23:21:56] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235932 (owner: 10Legoktm) [23:38:26] (03PS1) 10Mooeypoo: Design the anon warning widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235936 (https://phabricator.wikimedia.org/T110086) [23:40:10] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1604830 (10Mooeypoo) @PGiner-WMF designed per spec, including adding a different message for the submit button for anonymous users. It looks a little different when you add new... [23:40:22] RoanKattouw: when do we go to the airport? [23:42:12] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1604841 (10Mooeypoo) a:3Mooeypoo [23:43:54] bd808: 5:41pm BART train work for you? [23:43:57] Arrives at 6:13pm [23:45:34] RoanKattouw: I trust your travel timing :) I just have to clear security and reach the gate [23:51:36] (03Abandoned) 10Jforrester: build: Updating development dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235932 (owner: 10Legoktm) [23:55:58] bd808: Your flight's at 8, right? [23:56:45] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/235886 (owner: 10Jforrester) [23:57:05] RoanKattouw: yes. 7:55. boards at 7:30 [23:58:38] (03CR) 10Catrope: [C: 04-1] Design the anon warning widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235936 (https://phabricator.wikimedia.org/T110086) (owner: 10Mooeypoo)