[00:01:05] (03CR) 10Catrope: "Specifically James was arguing that:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [00:02:28] matt_flaschen: Is https://gerrit.wikimedia.org/r/#/c/230924/ ready to be merged? [00:03:08] RoanKattouw, I was in the process of testing it, then I got sucked into Parsoid. [00:03:28] Oh, right [00:03:38] It's not just you, BTW, I'm pretty sure it doesn't work for me either [00:03:40] (The Parsoid thing) [00:06:49] Yeah. Trying to get it fixed tonight, git-update still running and the Parsoid one gave some sketchy error, so I need to fix that to actually update Parsoid then continue. Doing other stuff in parallel. [00:07:54] Sketchy error: https://phabricator.wikimedia.org/P1964 [00:16:37] (03PS5) 10Catrope: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [00:18:07] (03PS6) 10Catrope: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [00:18:10] (03PS37) 10Catrope: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [00:18:29] (03Abandoned) 10Catrope: Use mw.Api#postWithToken for echomarkseen requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233640 (owner: 10Legoktm) [00:19:51] (03CR) 10jenkins-bot: [V: 04-1] Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [00:21:07] ehh [00:21:08] (03PS1) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [00:21:11] (03CR) 10jenkins-bot: [V: 04-1] Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [00:21:46] (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [00:23:41] (03PS2) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [00:23:44] (03CR) 10jenkins-bot: [V: 04-1] Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [00:27:33] (03PS3) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [00:27:55] https://i.imgur.com/zuGQrYX.png [00:29:56] (03CR) 10jenkins-bot: [V: 04-1] Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [00:31:25] (03PS4) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [01:26:35] (03CR) 10Catrope: Split alerts and messages in Echo (0317 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [01:26:48] (03CR) 10Catrope: Split alerts and messages in Echo (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [01:27:01] (03CR) 10Catrope: [C: 04-1] "Comments on PS35 and PS36" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [01:34:14] (03CR) 10Catrope: [C: 04-1] Add a confirmation dialog for canceling edits (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [01:34:45] (03CR) 10Catrope: [C: 032] Document Event methods that can return null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232566 (owner: 10Mattflaschen) [01:37:04] (03Merged) 10jenkins-bot: Document Event methods that can return null [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232566 (owner: 10Mattflaschen) [01:51:02] (03CR) 10Jforrester: "> * James, did I forget anything?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [03:04:35] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fatals in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1595662 (10Mattflaschen) 3NEW [03:10:22] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1595675 (10Mattflaschen) [03:54:22] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Fix Flow Parsoid integration on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T111119#1595725 (10Mattflaschen) p:5Triage>3High [04:15:27] (03PS21) 10Mattflaschen: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:15:30] (03CR) 10jenkins-bot: [V: 04-1] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:18:44] (03PS22) 10Mattflaschen: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:20:04] (03CR) 10Mattflaschen: [C: 031] "Amended to use the new selector for the description attachTo (it was using the one from the old system), and rebased." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:20:54] (03CR) 10jenkins-bot: [V: 04-1] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:25:01] (03CR) 10Mattflaschen: "I tested in isolation. There will need to be a followup to set the low_optIn_guidedTour cookie." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:27:18] (03PS23) 10Mattflaschen: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:29:07] (03CR) 10Mattflaschen: [C: 031] "Fixed the rebase issue." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:46:22] (03CR) 10Mattflaschen: "> 1. Having to parse the error code to find out about the captacha. The API could return something clear that means: you need a captcha, a" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen) [05:09:23] 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkType-NewFunctionality: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1595817 (10Mattflaschen) >>! In T109816#1590919, @Etonkovidova wrote: > Note: http://quarry.wmflabs.org/: use fawikibooks_p give... [08:31:46] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 6WMF-Design, 5ContentTranslation-Release7: Notify that your article has been translated by another user - https://phabricator.wikimedia.org/T88581#1596118 (10Arrbee) [10:47:38] 6Collaboration-Team-Backlog, 10Flow: Adjust to removal of Connection::getSingleton in Cirrus - https://phabricator.wikimedia.org/T111164#1596388 (10matthiasmullie) 3NEW [11:01:45] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Make it easier to type '{{' when you don't want to insert a template - https://phabricator.wikimedia.org/T110800#1596406 (10Pginer-WMF) One option to explore could be to bring the autocompletion template selection in-place. That can help to keep... [12:20:30] (03CR) 10Krinkle: Use db-replicated objectcache for storing last seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [12:25:58] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads, 6translatewiki.net: Consider possibility of enabling Flow on translatewiki.net - https://phabricator.wikimedia.org/T88102#1596625 (10Nemo_bis) 5stalled>3Invalid a:3Nemo_bis https://lists.wikimedia.org/pipermail/wikitech-l/2015... [12:39:08] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1596662 (10matthiasmullie) I'm going to guess/hope it may be related to testing the reference stuff & having some invalid data in cache somewhere. However, I ca... [12:47:35] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1596694 (10matthiasmullie) a:3matthiasmullie [12:51:32] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1596697 (10matthiasmullie) Turns out `MemcachedBagOStuff`s are unreliable. It'll rawurlencode keys when fetching data from cache, but won't decode them when resp... [13:04:51] (03PS1) 10Matthias Mullie: Fix/clarify some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235459 [13:05:05] (03CR) 10Matthias Mullie: [C: 032] Fix/clarify some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235459 (owner: 10Matthias Mullie) [13:09:21] (03Merged) 10jenkins-bot: Fix/clarify some comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235459 (owner: 10Matthias Mullie) [13:47:55] (03CR) 10Sbisson: "Fair enough but you have to explain it. Why not let the code do the talking?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen) [14:26:03] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Fatals and notices in FlowFixLinks.php - https://phabricator.wikimedia.org/T111138#1596888 (10EBernhardson) I'm not finding an open task, but i've seen ori mention a couple times in the last week that memcache is having iss... [14:30:45] (03CR) 10Sbisson: [C: 032] Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) (owner: 10Mooeypoo) [14:30:48] (03CR) 10jenkins-bot: [V: 04-1] Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) (owner: 10Mooeypoo) [14:33:34] (03CR) 10Sbisson: "Boo. Mooeypoo, can you rebase manually?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) (owner: 10Mooeypoo) [15:26:06] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Make it easier to type '{{' when you don't want to insert a template - https://phabricator.wikimedia.org/T110800#1597271 (10Jdforrester-WMF) '`{{`' is not a major feature. It's a very minor accessibility hack for old-hand Wikimedians who forget... [16:26:00] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 2 others: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1597841 (10Etonkovidova) Checked in betalabs. [16:27:10] hey RoanKattouw [16:27:56] Hey [16:28:13] I'm working on the TopicSummary widget. We have again 2 options here: it's just an editor and kicks in when you want to edit or it does the view part as well, more like BoardDescription widget.. [16:28:32] ugh right [16:28:38] * RoanKattouw looks at what summaries look like in his browser [16:28:53] at least the view part is simple [16:29:11] I was going down the option #2 path and looking at the ramifications... [16:29:38] Yeah, that sounds sensible [16:29:46] I just looked at the DOM structure and it looks really simple and self-contained [16:29:50] the widget itself is pretty simple but it's integration within the old-and-new-system is ugly [16:30:02] Yeah :S [16:30:11] Welcome to Moriel's life for the past couple months :| [16:30:35] In this case I think you should be able to do something very very similar to BoardDescriptionWidget [16:30:42] Which I don't think needed any old system magic [16:30:57] Description is 1 and only 1 [16:31:10] Oh right, there are potentially lots of summaries [16:31:23] Summary is everywhere, we would have to replace what's there with the new widget in many code paths [16:31:46] I think we would get most of the benefits (nice editor behavior, mostly) by doing edit-only [16:31:56] Yeah [16:32:03] That makes sense [16:32:09] and simplify the whole thing when it's container is also a widget [16:32:27] Ugh, I thought BoardDescriptionWidget used {{oouifiy}} :( [16:32:39] Or... I guess maybe it does, but it doesn't use the standard infusion thing, or something [16:34:12] I wonder if an outside-in approach for topics would help (i.e.. it's a widget but it's implementation relies on rendering handlebar) [16:34:39] To a certain extent that's how BoardDescription works [16:34:56] It uses a replace but that replace reuses chunks of the original DOM [16:36:19] do you know of morphdom? [16:36:51] * RoanKattouw googles [16:37:29] this one: https://github.com/patrick-steele-idem/morphdom/ [16:38:28] Oh so it's one of those DOM diff/patch library things [16:38:38] yes [16:38:40] except without a virtual DOM [16:39:14] it gives you one the nice things about React [16:39:34] I think it would work pretty well in the context of oojs-ui [16:40:13] you widget just always produce a new $element and the container updates the UI accordingly [16:40:14] Yeah it looks like it would [16:40:30] your rendering code doesn't have to be stateful (care about what's there already) [16:40:31] Well... hold on [16:40:36] That doesn't take event handlers into account [16:43:16] yeah, this one is limited [16:43:22] but the idea is nice [16:44:26] I liked your suggestion for dealing with captchas BTW [16:44:30] ( https://gerrit.wikimedia.org/r/#/c/234423/ ) [16:45:17] thanks [16:45:19] We have a broader discussion about that tomorrow, but I think you're convincing me that composition is good here [16:45:59] I've changed my mind [16:46:03] (As in, I went from "huh?" to "hmm, interesting idea" and now I'm at "this is probably better") [16:46:06] lol [16:46:25] it's only abstraction [16:46:28] Right [16:47:09] Yeah, for CAPTCHAs, I think the composition approach to abstracting it is promising [16:47:28] For other things (like automatic AnonWarningWidget), I'm thinking maybe a mixin is what we want [16:48:10] But thanks for challenging whether a base class (inheritance) was the right tool to use; I sort of took that for granted [16:59:21] (03PS2) 10Catrope: Use wikitext icon from OOUI for the VE->WT switch tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) [17:09:29] (03CR) 10Mooeypoo: Add a confirmation dialog for canceling edits (037 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [17:10:05] (03PS5) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [17:13:20] I'll be at scrum of scrums, so my update is: [17:15:08] Did some code review, fixed the Parsoid regression from the VirtualRESTService change, started working on T59153 (Allow links in Flow topic titles). I'll continue the latter today.. [17:15:55] (03CR) 10Mooeypoo: [C: 032] "Per matt's comment." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [17:16:03] matt_flaschen, ^^ and thanks! [17:16:50] matt_flaschen, also, the followup 'activate the cookie' commit is on top of stephanebisson's opt in commit https://gerrit.wikimedia.org/r/#/c/233868/ [17:16:57] I need to rebase it [17:17:00] mooeypoo, no problem, I'm glad to see GuidedTour being used more. :) It's been a while since I worked on it. [17:17:28] \o/ [17:17:38] (03PS2) 10Mooeypoo: [wip] Activate guided tour from opt in process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233868 (https://phabricator.wikimedia.org/T98270) [17:18:54] (03PS3) 10Mooeypoo: Activate guided tour from opt in process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233868 (https://phabricator.wikimedia.org/T98270) [17:19:23] mooeypoo: you could also merge "Activate guided tour from opt in process" with "guide tour" since they are best tested together [17:19:28] not required, just an idea [17:19:45] what? which? [17:19:54] matt_flaschen: How/where did you fix the VRS regression? [17:20:21] mooeypoo: opt-in guided tour and guided tour trigger [17:20:37] stephanebisson, the trigger depends on your opt in commit, though [17:20:40] stephanebisson, everything else is merged except the trigger, so that can just be rebased and tested. [17:20:41] ... which is merged. ha! [17:20:46] i didn't notice [17:20:53] You guys mean https://gerrit.wikimedia.org/r/#/c/233868/3 ? [17:20:57] oh, I didn't know the guided tour was merged... [17:21:04] That looks fine-ish to me but I'm wondering if that's the way you're supposed to do things... [17:21:13] stephanebisson, I just self +2'ed per matt's comment in the review [17:21:15] stephanebisson, just a momoment ago. Still Jenkin-ing. [17:21:30] mooeypoo: Don't you remember, that's the commit I merged right before you complained that I'd forgotten that you'd reported a bug against it [17:21:37] alright, nevermind me [17:21:37] RoanKattouw, yes, I just remembered [17:21:47] (the deferred change --> error thnig) [17:21:53] RoanKattouw, re Parsoid: https://phabricator.wikimedia.org/T111119 [17:22:09] matt_flaschen: ooooooh [17:22:14] That's why my local install is broken [17:22:16] RoanKattouw, do you want to report an actual task/bug against it now that it's merged? [17:22:18] Thanks, now I know how to fix mine [17:22:23] mooeypoo: Could you? [17:22:28] I could. But will I... [17:22:39] (I am :p ) [17:24:23] RoanKattouw, yeah, I think that ('Flow_optIn_guidedTour') is the best way to do it right now. We discussed this a fair amount (and I've tested parts of the flow). We also have approval from ops for the cookie name. [17:24:32] (03Merged) 10jenkins-bot: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [17:24:37] OK [17:24:43] Oh and thanks for thinking of asking ops [17:24:49] I had totally forgotten we had to do that [17:24:50] mooeypoo: https://gerrit.wikimedia.org/r/#/c/235353/ needs some love... [17:25:10] (I mean I remember the incident that made them put that rule in place, I'd just forgotten about the rule) [17:25:15] 6Collaboration-Team-Backlog, 10Flow: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1598290 (10Mooeypoo) 3NEW [17:25:20] RoanKattouw, ^^ [17:25:24] (03CR) 10Catrope: [C: 032] Activate guided tour from opt in process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233868 (https://phabricator.wikimedia.org/T98270) (owner: 10Mooeypoo) [17:25:49] stephanebisson, wow, seriously? a manual rebase for *THAT* ? boo [17:26:01] I'll do it. It's probably the i18n files again [17:26:04] we should REALLY alphabetize them [17:26:08] I was shocked [17:27:32] I think we should enabled opt-in on beta [17:27:57] +1 to putting it on Beta. [17:28:19] Oh, yes [17:28:22] We absolutely should [17:28:25] * RoanKattouw writes config patch [17:28:29] Actually [17:28:29] (03Merged) 10jenkins-bot: Activate guided tour from opt in process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233868 (https://phabricator.wikimedia.org/T98270) (owner: 10Mooeypoo) [17:28:35] I wanted to do it but I ws too dumb to figure out the config file [17:28:36] stephanebisson: Have you written config patches before? [17:28:45] That answers my question [17:28:47] Wanna learn? :) [17:28:47] I tried :( [17:28:54] sure [17:29:07] OK, so do you have a clone of the operations/mediawiki-config.git repo? [17:29:08] I've got to go to scrum of scrums, see you in a bit. [17:29:30] RoanKattouw: I got this far [17:29:45] (03PS2) 10Mooeypoo: Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) [17:29:51] stephanebisson, ^^ [17:30:13] ...wait wait [17:30:16] OK, so edit CommonSettings.php and find the section about Flow [17:30:17] something went wrong with the rebase [17:30:18] (earch for wmgUseFlow) [17:30:19] wtf [17:31:18] Then in that section, add something like if ( $wmgFlowBetaFeature ) { config stuff } [17:31:52] (03PS3) 10Mooeypoo: Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) [17:32:25] Or, rather, $wgFlowEnableOptInBetaFeature = $wmgFlowEnableOptInBetaFeature; [17:32:57] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1598335 (10Mattflaschen) [17:33:27] Then in InitialiseSettings.php, add a 'wmgFlowEnableOptInBetaFeature' key and set it to array( 'default' => false ) [17:33:53] Then in InitialiseSettings-labs.php, set it to 'enwiki' => true [17:35:45] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 2 others: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1598349 (10DannyH) 5Open>3Resolved [17:36:15] 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Exception Caught: Row has null primary key - https://phabricator.wikimedia.org/T110390#1598362 (10DannyH) 5Open>3Resolved [17:40:01] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1598376 (10Mooeypoo) [17:44:58] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1598410 (10DannyH) p:5Triage>3High [17:50:07] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in production - https://phabricator.wikimedia.org/T111098#1598423 (10DannyH) p:5Triage>3Lowest [17:56:44] (03CR) 10Catrope: [C: 032] Expose the revid of the event revision in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 (owner: 10Legoktm) [17:57:34] (03CR) 10jenkins-bot: [V: 04-1] Expose the revid of the event revision in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 (owner: 10Legoktm) [18:00:43] RoanKattouw: https://gerrit.wikimedia.org/r/235516 [18:00:55] thanks for the info [18:02:26] Thanks, that looks good [18:03:15] (03PS2) 10Legoktm: Expose the revid of the event revision in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 [18:04:46] (03CR) 10Sbisson: [C: 032] Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) (owner: 10Mooeypoo) [18:06:03] dannyh: in your spare time, please explain what would happen to the open bugs in flow with the focus shift. [18:06:56] (03Merged) 10jenkins-bot: Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) (owner: 10Mooeypoo) [18:10:59] (03PS5) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [18:11:02] (03PS1) 10Legoktm: Require a Language object in DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/235520 [18:11:34] i don't think this flow announcement is being explained well. [18:11:46] people are reading it as "flow is done and finished" which is how i read it at first. [18:12:11] but it's not; my understanding is that it's "we're shifting focus to the harder parts of the flow specification", which is (IMO) what should be done. [18:12:31] those parts of the design were what i don't think _anyone_ from teh community grasped. [18:12:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [18:55:12] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads: Create a script to extract all data from LiquidThreads and import into Flow - https://phabricator.wikimedia.org/T47088#1598642 (10Spage) >>! In T47088#1292244, @Wesalius wrote: > Is the script available anywhere for download? Sure, i... [19:01:47] (03CR) 10Mooeypoo: Split alerts and messages in Echo (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [19:02:05] (03PS38) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [19:05:16] matanya the plan is that we'll have some room (up to an equivalent of .5 of a team member's time) to support Flow by fixing bugs. I'm trying to get a bunch of bugs + fixes done now that have been really bothering people in the communities that we're working most closely with, including Hebrew [19:05:47] thanks [19:06:36] matanya so we're working through some, if you/people you know want to nominate some bugs, this is a good time for that, because we have a little more time where that's the main focus [19:07:34] will figure that out, with members of the community [19:07:47] matanya but that will continue after September -- we can't do feature requests, but we can definitely do some bugs, and the communities that are using opt-in will be the closest to our hearts [19:07:52] okay, good [19:08:03] i am really afarid my talk page will be flow, something will break in the future and i won't have anyone to support it [19:09:50] yeah, that kind of thing was #1 on my list when I've talked with people here about repriorities -- making sure that we don't make life hard for the people that we have good relationships with [19:11:36] dannyh: i think the word "maintenance" is what's tripping people up because they are conflating it with "sunsetting" [19:12:26] i've had people on the team personally say that the flow isn't canceled or sunsetted but is moving in different focus. that's not the takeaway the community has. or some members of it, at any rate. [19:13:10] ah. matt just sent a clarifying email. [19:14:12] jorm yeah, it's a confusing thing to explain because it's a confusing situation. [19:15:36] jorm these decisions are based a lot on the needs that are being expressed by the communities. [19:16:14] jorm the community response has really changed lately on some wikis, not on others. we need to see how that plays out [19:16:49] from the outside, i'm not seeing anything that wasn't anticipated or isn't part of the greater design. [19:17:16] it's confusing to me sometimes, though, when communities ask for features (or demand?) that were always on the roadmap, and complain that no one listened. [19:19:05] If anyone figures out a good solution, for getting detailed feedback (and from a well-informed-basis), from hundreds of thousands of people... they'd make a lot of governments very happy. [19:20:32] my favorite - seriously, my fucking FAVORITE - is when people complain about Flow, all the while demanding a solution for talk pages that works cross-wiki, or a "central location" for discussion. [19:23:39] jorm: Please don't be aggressive and swear in a workplace. [19:32:15] James_F: you're no fun [19:32:22] MatmaRex: True. [19:32:25] :> [19:33:16] i hear gubment work does that to people [19:34:04] wait. are you serious? [19:43:30] FYI, I'll be going to the RFC meeting today, "RFC: Master/slave datacenter strategy for MediaWiki". There is some stuff that is directly relevant to Flow, and it's relevant to data storage in general. It's at 2 Pacific in #wikimedia-office . [19:43:43] I <3 Flow !!!!!!!!!! [20:21:21] (03CR) 10Catrope: [C: 032] Expose the revid of the event revision in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 (owner: 10Legoktm) [20:21:50] mooeypoo: Please review https://gerrit.wikimedia.org/r/#/c/234447/ and the stack around it (above and below). Also https://gerrit.wikimedia.org/r/#/c/231483/ . And look at https://gerrit.wikimedia.org/r/234423 and provide any input you might have [20:23:33] (03Merged) 10jenkins-bot: Expose the revid of the event revision in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/90688 (owner: 10Legoktm) [20:26:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1599191 (10Etonkovidova) Checked in betalabs. Created a new board Talk:ET46 and added one topic: ```https://e... [20:33:24] RoanKattouw, ok, will do [20:38:36] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads: Create a script to extract all data from LiquidThreads and import into Flow - https://phabricator.wikimedia.org/T47088#1599232 (10Wesalius) Thanks, I will pass it to our sysadmin. [20:40:03] (03CR) 10Mooeypoo: [C: 031] "Looks good to me, I'd have merged if it wasn't for the dependencies." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [20:40:48] (03CR) 10Mooeypoo: "That comment was on the wrong patchset. Apologies (and taking back my +1)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [20:40:50] * mooeypoo grunts [20:41:07] (03CR) 10Catrope: "I think you commented on the wrong change?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [20:41:09] Oh, sorry [20:41:10] (03CR) 10Mooeypoo: [C: 031] "Looks good to me, I'd have merged if it wasn't for the dependencies." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234447 (owner: 10Catrope) [20:41:23] mooeypoo: You know, you can +2 things that have dependencies and nothing bad will happen [20:41:24] RoanKattouw, yes. Sorry :P I took back the comment and the +1 on it. Good thing I didn't +2! [20:41:31] ... good thing I didnt [20:41:31] :D [20:41:37] but yeah, I guess so. Does it matter? [20:41:39] Because until the dependency is approved, it'll simply do nothing [20:41:48] But then when the dependency is merged, it'll automatically merge with it [20:41:51] and then someone approves the dependency and the patch is magically merged [20:41:56] gotcha. I'll +2 it then [20:42:05] (03CR) 10Mooeypoo: [C: 032] Fix positioning of resolved check icon in RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234447 (owner: 10Catrope) [20:42:12] mooeypoo: Also, please look at the dependency, and at the dependent patch [20:42:18] yeah that is coming next [20:42:22] OK cool [20:42:33] I called that one out because if you were only gonna look at one patch, I wanted it to be that one [20:42:52] RoanKattouw, "// Prevent floated icon from pushing this away " <-- which way? [20:43:23] mooeypoo: In LTR, the icon is float: left; , and at some font sizes but not others that prevented the meta text from being all the way on the left [20:43:24] wow. I am going to shut up now... second time misreading something in 2 minutes. [20:43:27] So it pushed it to the right [20:43:49] Yeah, I missed the fact it said "pushing this AAAAway" [20:44:01] I read "pushing this way"... which way? [20:44:01] Oh lol [20:47:22] (03CR) 10Mooeypoo: [C: 032] "wfm, looks good" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234171 (https://phabricator.wikimedia.org/T108263) (owner: 10Catrope) [20:47:41] RoanKattouw, I don't need to do anything to get the above commit to merge now, do I ? [20:48:12] No, you should be fine [20:48:21] You should, however, review https://gerrit.wikimedia.org/r/#/c/234448/ which is part of the same stack :) [20:48:40] yep that's what I'm doing [20:48:47] Cool [20:49:16] uhm [20:49:34] RoanKattouw, you have two comments in titlebar.less "// HACK: move check icon a bit to the left ..." [20:49:40] (03Merged) 10jenkins-bot: Reduce font size and vertical padding of topic header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234171 (https://phabricator.wikimedia.org/T108263) (owner: 10Catrope) [20:49:52] but one is above a margin-left: -0.25em; and the other is above a margin-right: -0.25em [20:49:57] but it *looks* okay [20:50:08] So I'm confused. Is this wrong comment or... am I missing something [20:50:26] (03CR) 10Catrope: [C: 04-1] Add a confirmation dialog for canceling edits (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [20:50:58] mooeypoo: Sorry, LTR bias [20:51:03] To the left in LTR, but to the right in RTL [20:51:07] (03Merged) 10jenkins-bot: Fix positioning of resolved check icon in RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234447 (owner: 10Catrope) [20:51:39] the other way around... [20:51:50] margin-left: -0.25em pushes to the right [20:52:00] margin-right: -0.25em pushes the the left [20:52:02] ... [20:52:05] I am so confused. [20:52:36] No it doesn't [20:52:38] *negative* margin [20:53:00] yes [20:53:11] negative left => positive right [20:53:13] ... [20:53:17] No no [20:53:25] Positive left margin pushes to the right [20:53:34] Because it reserves additional space to the left of the thing [20:53:51] oh right.. right! right [20:54:12] okay, I left a comment about this in the patchset, it's silly, but it's so confusing, that the comments should really just say left/right properly [20:54:34] (03CR) 10Mooeypoo: [C: 04-1] "Tiny (but confusing) change to the comments" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234448 (https://phabricator.wikimedia.org/T108263) (owner: 10Catrope) [20:56:12] stephanebisson: What is the value that needs to go in $wgBetaFeaturesWhitelist again? [20:56:44] RoanKattouw: 'beta-feature-flow-user-talk-page' [20:57:31] Thanks [20:59:11] stephanebisson: I added that to your config patch and I've scheduled it for deployment at 4pm Pacific (in 2 hours): https://wikitech.wikimedia.org/w/index.php?title=Deployments&action=historysubmit&type=revision&diff=175984&oldid=175929 [20:59:36] yeah, I forgot about the whitelisting again [20:59:51] RoanKattouw: Want to Decline https://phabricator.wikimedia.org/T71584 maybe? :-) [21:00:33] 6Collaboration-Team-Backlog, 10Echo: Use core templating in Echo - https://phabricator.wikimedia.org/T71584#1599287 (10Catrope) 5Open>3declined a:3Catrope Superseded by {T107823} [21:01:48] Thanks. [21:02:07] (03PS2) 10Catrope: Hackily move the check icon a bit so it appears to align better [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234448 (https://phabricator.wikimedia.org/T108263) [21:02:33] mooeypoo: --^^ [21:02:47] am I the only one getting this with mw-vagrant: "Notice: Undefined index: restbaseCompat in /vagrant/mediawiki/includes/libs/virtualrest/ParsoidVirtualRESTService.php on line 94" [21:03:16] RoanKattouw: Also, is https://phabricator.wikimedia.org/T54337 on the vague plan? [21:03:22] RoanKattouw: 'Cos they are pretty dire. [21:04:22] 6Collaboration-Team-Backlog, 10Flow: History: 'Undo' for 'Flow talk page manager edited the description' produces Error page - https://phabricator.wikimedia.org/T111249#1599306 (10Etonkovidova) 3NEW [21:04:58] (03CR) 10Mooeypoo: [C: 032] "wfm" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234448 (https://phabricator.wikimedia.org/T108263) (owner: 10Catrope) [21:05:14] RoanKattouw, I almost wrote mfw just for the emphasis [21:05:54] (03CR) 10Catrope: [C: 04-1] "Most comments on PS35 were not addressed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [21:05:59] lol [21:06:01] mooeypoo: So, next ---^^ [21:06:07] wait, what? [21:06:15] mooeypoo: I really want to merge that one, but your PS38 does not address most of the PS35 comments [21:06:17] There was ONE comment in 35 [21:06:20] No [21:06:23] There were >10 [21:06:26] Two on 36 [21:06:28] Sorry for that split [21:06:35] stephanebisson: Regarding https://phabricator.wikimedia.org/T109931 "Tweak importer to allow converting opt-out wikis (LQT->Flow)" -- [21:06:38] crap, I missed the ones on notificationItem and notificationModel [21:06:39] sorry [21:07:03] stephanebisson, I fixed that in core: https://gerrit.wikimedia.org/r/#/c/235396/ Want to merge? [21:07:34] stephanebisson: do we have such wikis in betalabs - with LQT enabled by default ? [21:08:11] RoanKattouw, also, I just noticed, the fallback for not having a timestamp can't be Date.now() / 1000 if we're using mw format (which we are) [21:08:18] etonkovidova: I don't know. I configured my local setup to have LQT on NS_USER_TALK whe nI was working on it. [21:08:25] I need to literally output the mw timestamp format :\ [21:08:42] RoanKattouw, any useful mw method for that, or am I going to have to do this manually? [21:08:49] Ugh [21:08:56] stephanebisson: I see - ok. [21:09:03] I don't know offhand, maybe ask Krinkle or see if you can find docs [21:09:41] stephanebisson: how to check for beta if it's enabled somewhere? If it's not too much trouble.... [21:10:24] etonkovidova: I'll check if I can figure it out based on the configuration... just a moment [21:10:34] etonkovidova, you can compare all-labs.dblist in mediawiki-config repo to whatever you're looking for. In this case, wikis where wmgLiquidThreadsOptIn is false. [21:10:37] stephanebisson: thx! [21:13:16] dannyh: Did you have a rough date in mind for the production release of the personal Flow board Beta Feature? [21:13:18] mooeypoo: Also, don't we already depend on momentjs anyway? [21:13:28] I just thought about that [21:13:32] I think we are in Flow [21:13:40] Oh right you're in Echo [21:13:41] Not 100% sure about echo, checking [21:13:46] Probably not [21:13:58] Doesn't core depend on moment? [21:14:08] hm, echo doesn't. [21:14:15] It wouldn't be too hard to build an MW timestamp using new Date().getUTC*() methods, just a bit laborious [21:14:20] James_F I'm unofficially hoping for two weeks from now, because I want to see it working live for a minute before the October cutoff [21:14:25] I could add it in, but it sounds funny to do that *just* for the fallback [21:14:38] * James_F nods. [21:14:47] RoanKattouw, also, at some point, when the echo API works right and we're actually building the UI properly, we probably will want to depend on moment [21:15:09] What for? [21:15:32] RoanKattouw, Notification accepted X days ago [21:15:37] 2 hours ago [21:15:38] bla bla [21:15:47] dannyh: BTW in case nobody told you yet, we're enabling the beta feature on English beta labs in ~2 hours [21:15:50] It's all done in the server right now [21:15:54] Oh, right [21:15:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Use EditorWidget for edit post - https://phabricator.wikimedia.org/T109000#1599368 (10Etonkovidova) Checked in beta - edit/new reply posts are ok: {F2533987} [21:15:58] Live-updating timeago messages like in Flow [21:16:05] yeah [21:16:11] RoanKattouw um nobody did :) but that is very good to know [21:16:35] Also we'll probably have the Echo split there later today [21:16:57] etonkovidova: I can't find confirmation by looking at the config. [21:17:21] matt_flaschen: do you know if any lab site has a whole NS on LQT? [21:17:41] stephanebisson: ok - it can wait. I have higher priority task to verify now ... [21:17:55] stephanebisson, doesn't the script only add namespaces if $wgLqtTalkPages is true? [21:18:42] matt_flaschen: yes [21:20:53] stephanebisson, etonkovidova, there's no overlap between wmgLiquidThreadsOptIn false (i.e. wgLqtTalkPages true) and https://git.wikimedia.org/blob/operations%2Fmediawiki-config/969878973b08011e6fa24ec406c0bc011e650f22/all-labs.dblist . [21:21:29] And wgLqtNamespaces is not used in production. [21:21:35] Or Labs [21:25:14] I thought it was for sewikimeida? [21:25:20] matt_flaschen: https://phabricator.wikimedia.org/T109931 lists strategywiki, sewikimedia, ptwikibooks. So only those wikis can be checked? [21:25:20] Or am I thinking of something else? [21:26:07] RoanKattouw, sewikimedia uses $wgLqtTalkPages = true. $wgLqtNamespaces is a per-namespace setting, wgLqtTalkPages is global. [21:26:14] Oooh OK [21:27:07] etonkovidova, the problem is there is no suitable wiki in Beta yet. We could try to spin one up, or test locally. [21:28:42] matt_flaschen: right. I am checking now 'Opt-in for Flow on your own user talk page' which has a higher priority [21:32:44] stephanebisson: an easier question :) Should I run maintenance/FlowUpdateBetaFeaturePreference.php to start checking or ...? [21:34:54] etonkovidova: the maintenance script is independent from the main feature [21:35:25] RoanKattouw: mooeypoo can't say enough thank you for ironing those mind-blowing RTL/LTR issues [21:35:33] if your talkpage is already flow board and you run the maintenance script, when you open the beta preference page it should be checked by default [21:36:00] stephanebisson: but I do not see the opt-in in betalabs [21:36:34] etonkovidova: there is a config change for it that will be deployed at the end of the day [21:36:47] stephanebisson: ah :) [21:36:59] the code is there but it is turned off [21:37:33] stephanebisson: I see. Cannot wait for it to be turned on :) [21:37:50] etonkovidova: you can create a user with a flow talk page before it is deployed to simulate the real scenario... [21:38:14] the maintenance script will be executed by update.php [21:39:52] (03CR) 10Mooeypoo: Split alerts and messages in Echo (0317 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [21:40:15] matanya, my absolute erusaelp [21:40:16] ;) [21:40:28] :) [21:40:34] Also, it's somewhat selfish... I read that in Hebrew too! :P [21:40:43] heh [21:41:09] now lets hope the flyout will be fixed, and i'll go to heaven [21:41:30] (03PS39) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [21:41:38] matanya, you mean notifications? [21:42:16] when i have a red number in the notifications thing and i click it, it only changes to 0 but doesn't open the flyout [21:42:24] matanya, ... guess what I'm working on now........ :D' [21:42:31] there is a ticket for that in phab somewhere [21:42:39] that? :DD ? [21:42:41] matanya, it's almost ready to be merged, by the grace of RoanKattouw [21:42:55] haleluja [21:43:06] matanya, well, ooui'fying it + splitting notifications to alerts/messages and along the way fixing the way the numbers update. [21:43:14] 3Collaboration-Team-Current, 10Flow: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1599565 (10Mattflaschen) 3NEW [21:43:23] yay! [21:43:27] matanya, I'm testing rtl again now against it [21:43:38] if you need any help, poke [21:43:49] mooeypoo: Never! No-one here cares about RTL. Especially not matanya. ;-) [21:44:00] should be working, except my notifications are not quite rtl'ed because my test wiki was english until now. We'll have to have some of the RTL verification after merge [21:44:05] stephanebisson, we need a task to do it in production, though. Filed https://phabricator.wikimedia.org/T111253?workflow=create . [21:44:07] James_F, yes, RT-what? [21:44:16] matanya, is there a bug for that? I haven't heard about that. [21:44:25] "it only changes to 0 but doesn't open the flyout" [21:44:33] matt_flaschen: there is, i can look for it [21:44:49] * James_F grins. [21:45:18] yeah I can't say I heard about a specific opening-the-flyout bug... but either way, we've rewritten the flyout to be an ooui popup, so whatever bug there *was* should either go away, or be fixed a different way anyways [21:45:58] matt_flaschen: is update.php running during deployment in beta? [21:46:03] stephanebisson: Yes. [21:46:48] stephanebisson: Hmm, but it's failing. [21:47:02] stephanebisson, yep, update.php runs automatically in Beta. [21:47:08] https://integration.wikimedia.org/ci/view/Beta/job/beta-update-databases-eqiad/2642/consoleFull [21:47:46] matt_flaschen: i think it is related to https://phabricator.wikimedia.org/T73080 [21:47:55] 3Collaboration-Team-Current, 10Flow: Flow post with links on officewiki - database query error - https://phabricator.wikimedia.org/T111254#1599587 (10Quiddity) 3NEW [21:48:30] matanya, that's an old bug and likely fixed. Different from what you said earlier. [21:48:49] matt_flaschen: more accurate description: https://phabricator.wikimedia.org/T71966 [21:49:12] but it happens also when i do have unred items [21:49:23] James_F: can you spot the actual error? I can't. [21:49:37] if you'll mention me on he.wiki can screencast it if you wish [21:49:45] stephanebisson, it's not shown. I also filed a bug about that. [21:49:54] matanya: We should have the new code in beta soon (probably later today; maybe in 20 minutes if Moriel's latest patch is good to merge) so please do verify it in hewiki beta then [21:49:57] However, update.php can be run manually in Beta Labs. [21:50:16] (Though it sucks if it gets interrupted with an error midway, because it might already be tracked as 'has run' and then needs to be forced). [21:52:58] RoanKattouw: sure, thanks [21:53:01] I actually found a tiiiiinsy tiny little bug in my code [21:53:21] stephanebisson: What matt_flaschen said. [21:53:47] actually wait [21:53:56] not a bug [21:54:01] ha! OOUI FTW [21:54:07] What's up [21:54:30] mooeypoo: Bug or no bug? [21:54:45] (03PS7) 10Catrope: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [21:56:04] RoanKattouw, I'm testing again. [21:56:17] the problem is that the badge icon is not flipped in RTL [21:56:24] it is in JS rtl of course because that's ooui [21:56:54] but I was working in debug mode until now [21:57:40] it should just work :\ [21:57:48] css janus should flip things [21:58:28] Hmm [21:58:39] RoanKattouw, I got it... it's flipping SOME but not all [21:58:49] background-position: 0.12em center is not flipped [21:59:05] so the icon is still to the left, despite the fact it should be on the right [21:59:21] Oh, right [21:59:25] RoanKattouw, except, how DO we position it properly on the right ? :\ [21:59:28] Ahm [21:59:38] Let me read some CSS documentation about background-position [21:59:40] ideally letting cssjanus do it, but that seems to be not working atm [21:59:47] * mooeypoo nods [21:59:52] anyways, this is the only bug [22:00:37] matt_flaschen: i have a screencast for you [22:00:42] RoanKattouw, in any case, if you think it's nto a blocker (it's "jumping" in RTL js from nojs) then we can make it a followup fix [22:01:14] matanya, okay, can you file a bug and attach the screencast? [22:01:20] yes [22:01:44] Thanks, matanya [22:02:58] 3Collaboration-Team-Current, 10Flow: Flow post with links on officewiki - database query error - https://phabricator.wikimedia.org/T111254#1599684 (10Mattflaschen) a:3Mattflaschen [22:03:06] 3Collaboration-Team-Current, 10Flow: Flow post with links on officewiki - database query error - https://phabricator.wikimedia.org/T111254#1599587 (10Mattflaschen) p:5Triage>3Unbreak! [22:03:28] 6Collaboration-Team-Backlog, 10Echo: clicking on messages in echo flyout clears count in personal bar, doesn't open flyout (intermediate) - https://phabricator.wikimedia.org/T111261#1599687 (10Matanya) 3NEW [22:03:40] matt_flaschen: ^ [22:05:13] grumble grumble meeting rooms grumble [22:05:18] Sorry for moving that meeting twice in five minutes [22:05:32] I booked a room, and then the room declined because someone beat me to it, and it was the last room available [22:05:49] We have like 15 meeting rooms in this office, and it turns out that at 10am on Tuesday every single one is booked [22:06:02] 6Collaboration-Team-Backlog, 10Echo: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1599707 (10Mattflaschen) [22:06:08] do virtual meetings :) [22:06:19] It is a hangout meeting :) [22:06:30] But there are multiple local participants so I wanted a room [22:07:07] matanya, next time there's a major issue like that, please do bug us. [22:07:28] I wonder if that's happening for everyone, or just with certain settings/user scripts. [22:07:47] matt_flaschen: it is very hard to reproduce, i only see it a lot bec. i get pinged a lot [22:08:21] 6Collaboration-Team-Backlog, 10Echo: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1599717 (10DannyH) p:5Triage>3Normal [22:08:22] I see. Maybe the formatter is failing or something. [22:08:36] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1599687 (10DannyH) [22:08:54] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1599724 (10Legoktm) Is there anything in your browser's JavaScript console? Can you look at the network console and see if an A... [22:10:11] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1599748 (10Matanya) i need many pings in order to reproduce it. Please ping me as much as possible so i can try and reproduce i... [22:10:16] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: clicking on Echo badge clears count in personal bar, doesn't open flyout - https://phabricator.wikimedia.org/T111261#1599750 (10Legoktm) (My hunch is that this is {T56486}). [22:11:02] matanya: [22:11:03] matanya: [22:11:05] matanya: [22:11:06] matanya: [22:11:10] legoktm: on-wiki ... [22:11:12] is that enough pings? ;) [22:11:15] :) [22:14:25] legoktm: can you please mention me on he.wiki ? [22:15:07] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Echo flyout takes too long to open - https://phabricator.wikimedia.org/T56486#1599771 (10Legoktm) https://grafana.wikimedia.org/#/dashboard/db/echoflyout is the graphite data btw. [22:15:18] yeah, doing [22:16:26] matanya: pinged [22:16:46] yes, got it, 273 ms [22:17:50] so it opened fine this time? [22:18:21] yes [22:18:28] try again please [22:19:12] you can also use the template {{א|Matanya}} [22:19:27] might be related, who knows ... [22:19:47] mooeypoo: OK, so short version, CSS sucks and you need to specify the background-position as a %age instead [22:20:21] Hmm no [22:20:44] OK CSS sucks except in Firefox where "offsets from any edge" is supportd [22:20:54] Outside of Firefox, you need a %age which cssjanus knows how to flip [22:28:54] matt_flaschen: now i have another one when the flyout opens, but the counter doesn't zero. report that too on phab ? [22:29:28] matanya, it's not supposed to zero if there are messages. Only alerts should make it go to 0. [22:29:52] Also, might be the same as https://phabricator.wikimedia.org/T73585 if it is a problem. [22:29:54] so i have to read the message to make it zero ? [22:30:00] matanya, yes. [22:30:10] But only for messages, alerts auto-read. [22:30:32] ok, forcing me to read a message that says "thanks" seems somewhat pushy, but ok [22:30:33] mooeypoo: ... ugh, but we can't use a percentage because it's variable width [22:30:36] mooeypoo: Wait wait [22:30:44] mooeypoo: Is the OOUI version variable width? [22:31:10] hmm yes it is [22:31:12] OK [22:31:13] So [22:31:22] I think I know what to do [22:31:24] RoanKattouw, if we change to 1.25em, it looks good [22:31:28] but that's manual :\ [22:32:01] matanya, thanks is an alert, not a message. [22:32:12] Oh, unless you mean a Flow message that just happens to say thank you. [22:32:21] yes, taht [22:32:24] *that [22:32:56] so the entire text is in the message but i must click it to see it in the board although i know what it says [22:33:03] or click "mark all as read" [22:33:17] matanya, there is also an X. [22:33:19] matanya, you can also mark as read only that one [22:33:21] which is not so fun if i have other stuff i didn't read yet [22:33:43] mooeypoo, remember you can do arithmetic in LESS, not sure if that helps. [22:33:48] mooeypoo: I'm doing body.rtl & { background-position: calc( 100% - @blah ) center; } [22:33:58] ha, matt_flaschen good timing [22:34:21] RoanKattouw, will cssjanus replace it , or no need? [22:34:45] No Janus won't touch it [22:35:07] ok, matt_flaschen that X does the trick, thanks [22:35:17] oh, right, you're sepaarting by .rtl [22:37:09] (03PS40) 10Catrope: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [22:37:13] mooeypoo: --^ [22:37:41] mooeypoo: If you're OK with the 39..40 diff (I tested it locally) then I'll merge [22:38:12] testing now [22:38:18] 3Collaboration-Team-Current: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1599880 (10Mattflaschen) 3NEW [22:38:26] 3Collaboration-Team-Current: update.php broken in Beta - https://phabricator.wikimedia.org/T111267#1599887 (10Mattflaschen) p:5Triage>3High [22:39:10] RoanKattouw, thumbs up! [22:39:46] RoanKattouw, we could probably flip the bubble icon in RTL but that can totally be a separate (optional) commit [22:40:26] RoanKattouw, but, not related to Echo at all, just a comment -- flow sidebar is meh in mixed content/interface directionalities [22:40:58] Oh, right [22:41:16] But that's both with and without OOUI, right? [22:41:24] We'd need to like actually put in an RTL version of the icon [22:41:35] No wait, the bubble icon is flipped in JS [22:41:59] Actually bubble icon flipping WFM even in nojs [22:42:10] in Echo that is [22:42:25] (03CR) 10Catrope: [C: 032] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [22:42:32] (03CR) 10Catrope: [C: 032] Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [22:42:38] (03PS8) 10Catrope: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [22:42:42] woohoo [22:42:44] (03CR) 10Catrope: [C: 032] Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [22:42:50] ITS HAPPENING [22:43:08] 6Collaboration-Team-Backlog, 10Flow: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" - https://phabricator.wikimedia.org/T109750#1599900 (10DannyH) [22:43:09] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Editing posts: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T110093#1599899 (10DannyH) [22:43:11] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Use EditorWidget for edit post - https://phabricator.wikimedia.org/T109000#1599897 (10DannyH) 5Open>3Resolved [22:43:14] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1599901 (10DannyH) 5Open>3Resolved [22:43:17] 3Collaboration-Team-Current, 10Flow, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1599903 (10DannyH) [22:43:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1599907 (10DannyH) 5Open>3Resolved [22:43:51] mooeypoo: still around for short time if you are looking for testing [22:43:55] mooeypoo: Also I'm merging the MF change but the concern you voiced should still be looked into [22:44:08] matanya: Awesome. Give it 10-15 minutes, I'll let you know when it's live [22:44:25] * matanya is falling a sleep :) [22:44:29] matanya, well, it'll probably take it a bit to get to beta, and then yes [22:44:50] RoanKattouw, MF ? [22:44:57] matanya: That last little delay was because I was wrestling with making the icons appear on the right side in RTL in non-JS mode; CSS doesn't want to let you do that except in Firefox [22:45:00] MobileFrontend [22:45:10] oh oh [22:45:11] yes [22:45:20] firefox FTW [22:45:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Allow user to create new board at Special:EnableFlow without description - https://phabricator.wikimedia.org/T108348#1599910 (10DannyH) 5Open>3Resolved Beautiful, thank you! [22:45:30] RoanKattouw, ... which ONE of my concerns about MobileFrontend ? [22:45:36] * RoanKattouw resorted to background-position: calc(100% - 0.12em) center; , but in Firefox you can (allegedly) do background-position-x: right 0.12em; [22:45:41] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Don't switch preference for VE/wikitext if your device doesn't support your preferred editor - https://phabricator.wikimedia.org/T110706#1599912 (10DannyH) [22:45:42] mooeypoo: Be nice [22:45:45] you see James_F firefox is better than chrome in some things [22:45:52] you mean the logger? That's probably not a blocker [22:45:56] mooeypoo: https://gerrit.wikimedia.org/r/233081 PS7 [22:46:00] matanya: :-P [22:46:07] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1599913 (10DannyH) [22:46:08] no, haha I mean the logger or the reimplementation of the flyout not being OOUI [22:46:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1599915 (10DannyH) [22:46:48] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Don't switch preference for VE/wikitext if your device doesn't support your preferred editor - https://phabricator.wikimedia.org/T110706#1599916 (10DannyH) 5Open>3Resolved [22:47:05] RoanKattouw, I don't think we have that logged in desktop version either; we should at some point (soonish) decide what we want to log, where, and how much [22:47:10] and then implement that throughout [22:47:15] OK I didn't really understand your comment at all [22:47:15] I just tried to keep things as is for now [22:47:18] But it sounded vaguely worrying [22:47:55] well, we aren't really doing a lot of echo logging at the moment. We're only logging clicks and impressions [22:48:10] but i think we aren't logging all clicks from Special:Notifications [22:48:18] that said, we're also not logging a lot of other things we might want to [22:48:28] so thi sis a general non-blocking concern we should deal with soon, but not panic over. [22:49:30] I doubt anyone is looking at that data anyways, we should just turn it off [22:50:13] 6Collaboration-Team-Backlog, 10Flow: Edit on wikitext button on the right column of a Flow board is hidden by text. - https://phabricator.wikimedia.org/T110872#1599920 (10Etonkovidova) [22:50:14] 6Collaboration-Team-Backlog, 10Flow: wikitext preview message overlapping with Switch to VisualEditor button - https://phabricator.wikimedia.org/T108261#1599921 (10Etonkovidova) [22:50:28] legoktm, I counter with "I think we should make it better so we can look at it from now on" [22:50:38] :) [22:50:43] (03Merged) 10jenkins-bot: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [22:50:43] also an option :P [22:50:46] (03Merged) 10jenkins-bot: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [22:53:06] (03PS6) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [22:53:09] (03CR) 10jenkins-bot: [V: 04-1] Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [22:56:00] (03PS7) 10Mooeypoo: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) [22:59:16] 3Collaboration-Team-Current, 10Flow: Run phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1599996 (10Mattflaschen) [22:59:35] 3Collaboration-Team-Current, 10Flow: Run phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1599587 (10Mattflaschen) [23:00:29] 3Collaboration-Team-Current, 10Flow: Run phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1599587 (10Mattflaschen) [23:02:52] ^ RoanKattouw_away will be slightly late to meeting due to that. [23:05:10] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Take out "This description has been modified" line in side rail legal text - https://phabricator.wikimedia.org/T110082#1600117 (10Etonkovidova) Checked in betalabs: {F2534246} [23:07:55] (03CR) 10Catrope: [C: 032] Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [23:09:52] (03Merged) 10jenkins-bot: Add a confirmation dialog for canceling edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235383 (https://phabricator.wikimedia.org/T111115) (owner: 10Mooeypoo) [23:10:02] 3Collaboration-Team-Current, 10Flow, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1600134 (10DannyH) [23:10:55] 3Collaboration-Team-Current, 10Flow: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1600139 (10Mattflaschen) [23:11:09] 3Collaboration-Team-Current, 10Flow: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1599587 (10Mattflaschen) [23:12:55] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1600145 (10DannyH) p:5Triage>3Normal [23:13:47] 6Collaboration-Team-Backlog, 10Flow: Editing description on a brand new board doesn't show the new description - https://phabricator.wikimedia.org/T106459#1600150 (10Catrope) p:5Triage>3Low [23:13:54] 3Collaboration-Team-Current, 10Flow: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1600152 (10Mattflaschen) [23:14:47] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Add Arabic (ar) translation of the new namespaces for Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T110999#1600171 (10Catrope) 5Open>3Resolved a:3Catrope [23:15:41] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1599587 (10Mattflaschen) [23:15:45] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1600176 (10Mattflaschen) a:5Mattflaschen>3None [23:16:11] 3Collaboration-Team-Current, 10Flow, 7Database, 7Schema-change: Run "patch-remove_unique_ref_indices.sql" and phase 1 of "Segregate Reference objects by source wiki." on officewiki - https://phabricator.wikimedia.org/T111254#1600183 (10Mattflaschen) [23:17:33] 6Collaboration-Team-Backlog, 10Flow: 'Add a template' box looks different on Flow pages - https://phabricator.wikimedia.org/T110966#1600186 (10Catrope) p:5Triage>3Normal [23:19:18] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow's elapsed Timestamp message at Lvwp, changes to an incorrect translation after loading is complete - https://phabricator.wikimedia.org/T110934#1600195 (10Catrope) I am told Moment doesn't support qqx, so it's not super easy to figure out which message key is b... [23:20:44] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow's elapsed Timestamp message at Lvwp, changes to an incorrect translation after loading is complete - https://phabricator.wikimedia.org/T110934#1600196 (10Catrope) p:5Triage>3Normal [23:22:01] 6Collaboration-Team-Backlog, 10Flow, 7I18n: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1600200 (10Catrope) It's talking about the current user, so just using {{GENDER:|...}} should work. But we should indicate this in the English message. [23:22:24] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 7I18n: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1600202 (10Catrope) [23:22:38] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 7I18n: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1600204 (10Catrope) p:5Triage>3Normal [23:23:25] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: {{FlowMention|Someone}} displays a link that connects with the following characters after it, in case there's no space between them (but only if the text is not capitalized) - https://phabricator.wikimedia.org/T110757#1600210 (10Catrope) p:5Triage>3N... [23:25:04] 6Collaboration-Team-Backlog, 10Echo: Investigate maximum echo notification count - https://phabricator.wikimedia.org/T110745#1600220 (10Catrope) p:5Triage>3Normal [23:27:37] 6Collaboration-Team-Backlog, 10Echo: Echo's 'seen time' should be replaced with marking specific notifications as seen - https://phabricator.wikimedia.org/T110731#1600232 (10Catrope) p:5Triage>3Normal [23:30:02] 3Collaboration-Team-Current, 10Flow: Split seen timestamp for alerts and messages - https://phabricator.wikimedia.org/T111285#1600236 (10Catrope) 3NEW a:3Mooeypoo [23:31:17] 3Collaboration-Team-Current, 10Flow: Split seen timestamp for alerts and messages - https://phabricator.wikimedia.org/T111285#1600250 (10Mooeypoo) There's also this: https://phabricator.wikimedia.org/T110731 [23:31:58] 6Collaboration-Team-Backlog, 10Flow: Search for localized {{#useliquidthreads}} as well in find/replace in LQT→Flow conversion - https://phabricator.wikimedia.org/T110723#1600251 (10Catrope) p:5Triage>3High [23:32:01] mooeypoo: ---^^ [23:32:39] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Search for localized {{#useliquidthreads}} as well in find/replace in LQT→Flow conversion - https://phabricator.wikimedia.org/T110723#1600255 (10DannyH) [23:36:03] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Mobile browser tests for Flow - https://phabricator.wikimedia.org/T110562#1600261 (10Catrope) p:5Triage>3Normal [23:36:46] 6Collaboration-Team-Backlog, 10Flow: Have a global diff when some people add answers to a Topic - https://phabricator.wikimedia.org/T110525#1600264 (10Catrope) p:5Triage>3Normal [23:37:48] RoanKattouw_away, is there a way to set a breakpoint for comparison in VE ? As in, tell it "this is your original model to compare hasBeenChanged" ? [23:38:18] 6Collaboration-Team-Backlog, 10Flow: Type of flow_ext_ref.ref_target incorrect on some tables on Beta Cluster - https://phabricator.wikimedia.org/T110446#1600269 (10Catrope) [23:38:38] 6Collaboration-Team-Backlog, 10Flow: Type of flow_ext_ref.ref_target incorrect on some tables on Beta Cluster - https://phabricator.wikimedia.org/T110446#1578196 (10Catrope) p:5Triage>3Normal [23:40:04] Is the Flow opt-in beta feature going to be deployed on all wikis? [23:40:20] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Parsoid broken in beta labs - https://phabricator.wikimedia.org/T111249#1600277 (10Catrope) p:5Triage>3Unbreak! a:3Catrope [23:40:30] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Flow's Parsoid usage broken in beta labs - https://phabricator.wikimedia.org/T111249#1599306 (10Catrope) [23:40:44] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Flow's Parsoid usage broken in beta labs - https://phabricator.wikimedia.org/T111249#1599306 (10Catrope) This is probably because beta labs's Parsoid config hasn't been updated for the v3 changes. [23:41:13] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Flow's Parsoid usage broken in beta labs - https://phabricator.wikimedia.org/T111249#1600284 (10DannyH) [23:41:35] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Adjust to removal of Connection::getSingleton in Cirrus - https://phabricator.wikimedia.org/T111164#1600286 (10Catrope) p:5Triage>3High a:3matthiasmullie [23:41:46] 3Collaboration-Team-Current, 10Flow: Adjust to removal of Connection::getSingleton in Cirrus - https://phabricator.wikimedia.org/T111164#1596388 (10Catrope) [23:43:34] 6Collaboration-Team-Backlog, 10Flow: Categories box is misaligned on Flow pages? - https://phabricator.wikimedia.org/T111110#1600293 (10Catrope) We can probably remove the categories bar at the bottom after {T92874} ? [23:44:53] 6Collaboration-Team-Backlog, 10Flow: Categories box is misaligned on Flow pages? - https://phabricator.wikimedia.org/T111110#1600296 (10Catrope) p:5Triage>3Normal [23:46:04] 3Collaboration-Team-Current, 10Flow: Use EditorWidget for topic summary - https://phabricator.wikimedia.org/T111102#1600298 (10Catrope) [23:46:06] 6Collaboration-Team-Backlog, 10Flow: Topic summary edited in VE: Template displays multiple 'Describe briefly the outcome of this discussion' - https://phabricator.wikimedia.org/T111107#1600297 (10Catrope) [23:46:22] 6Collaboration-Team-Backlog, 10Flow: Topic summary edited in VE: Template displays multiple 'Describe briefly the outcome of this discussion' - https://phabricator.wikimedia.org/T111107#1600300 (10Catrope) p:5Triage>3High [23:46:37] 6Collaboration-Team-Backlog, 10Echo: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1600304 (10Legoktm) a:3Legoktm [23:46:47] 3Collaboration-Team-Current, 10Echo: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#585144 (10Legoktm) [23:54:45] 3Collaboration-Team-Current, 10Echo: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1600324 (10Legoktm) We're going to do something like "Foo mentioned you on "Wikipedia:FooBar" in "section". [23:55:02] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Split notification-mention and notification-mention-flyout messages - https://phabricator.wikimedia.org/T110699#1600330 (10Legoktm) 5Open>3declined a:3Legoktm Declining in favor of {T56433}. [23:55:38] 3Collaboration-Team-Current, 10Echo: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1600340 (10Mattflaschen) >>! In T56433#1600324, @Legoktm wrote: > We're going to do something like "Foo mentioned you on "Wikipedia:FooBar" in "section".... [23:56:17] 3Collaboration-Team-Current, 10Echo: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1600345 (10Legoktm) Yeah, I wasn't clear in my post. We're going to us that generic message for all pages, talk and non-talk. [23:57:20] 3Collaboration-Team-Current, 10Flow: Split seen timestamp for alerts and messages - https://phabricator.wikimedia.org/T111285#1600348 (10Legoktm) T110731 would probably require a schema change to add a `notification_seen_timestamp` column or something. We can fix bug this by using two keys or something.