[00:11:30] 2015-08-31 10:42:04 silver labswiki exception ERROR: [7b529d91] /wiki/Special:WhatLinksHere/Help:Tool_Labs Flow\Exception\CatchableFatalErrorException from line 23 of /srv/mediawiki/php-1.26wmf20/extensions/Flow/includes/Model/WikiReference.php: Argument 6 passed to Flow\Model\WikiReference::__construct() must be an instance of Title, null given [00:12:20] seems weird to me that this occurs on Special:Whatlinkshere [00:13:58] AFAIK we have no flow pages on that wiki anyway [00:19:43] Oh, yes [00:19:50] Let me tell you why that happens [00:19:53] Flow has its own fake link table [00:20:08] Which lives in a global DB and is shared by all wikis [00:20:59] Until recently that table didn't *have* a column specifying the wiki [00:21:09] Now it has one, but it's full of NULLs because we have no code tracking it [00:21:28] There's code in tomorrow's train that finally tracks which wiki the link/category/template reference is on [00:21:52] Until that rolls out *and* we run a maintenance script to backfill the wiki field, we have cross-wiki contamination of whatlinkshere and other things [00:22:16] For example, on User talk pages on hewiki we've seen French categories because that same user also uses Flow on their User talk page on frwiki [00:22:26] And we're going to backfill it (the backfill for this particular problem is a SQL script, but there is a related issue that will require a maintenance script). [00:23:11] (Which has been written, and will also be run soon) [00:37:05] 6Collaboration-Team-Backlog, 10Echo: Echo - missing dates in Serbian, Croatian and Slovenian language - https://phabricator.wikimedia.org/T110805#1591327 (10Liuxinyu970226) [00:38:12] 6Collaboration-Team-Backlog, 10Echo: Echo - missing dates in Serbian, Croatian and Slovenian language - https://phabricator.wikimedia.org/T110805#1591329 (10Legoktm) [00:38:13] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1591328 (10Legoktm) [00:38:26] 6Collaboration-Team-Backlog, 10Echo: Echo - missing dates in Serbian, Croatian and Slovenian language - https://phabricator.wikimedia.org/T110805#1586962 (10Legoktm) (I know this one was filed first, but I'm duping the other way because it has more information on it) [00:38:35] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1591332 (10Legoktm) 5duplicate>3Open [00:38:52] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590690 (10Legoktm) [00:38:54] 6Collaboration-Team-Backlog, 10Echo: Echo - missing dates in Serbian, Croatian and Slovenian language - https://phabricator.wikimedia.org/T110805#1591334 (10Legoktm) [00:50:31] (03PS1) 10Catrope: Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 [00:59:51] 3Collaboration-Team-Current, 10Flow: Don't switch preference for VE/wikitext if your device doesn't support your preferred editor - https://phabricator.wikimedia.org/T110706#1591359 (10Catrope) a:3Catrope [01:07:54] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), and 2 others: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1591369 (10Quiddity) [01:09:39] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian, Croatian and Slovenian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1591375 (10Quiddity) [01:11:47] 6Collaboration-Team-Backlog, 5Patch-For-Review: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1591376 (10Catrope) >>! In T101316#1588495, @Pginer-WMF wrote: >>>! In T101316#1585664, @Catrope wrote: >> I've been meaning to change the WT->VE button too (not just the icon... [01:19:55] (03CR) 10Mooeypoo: [C: 032] BoardDescriptionWidget: Don't fetch wikitext when initializing VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231481 (owner: 10Catrope) [01:20:19] (03CR) 10Catrope: [C: 031] "Thanks for doing this for us, Scott! This patch looks good to me, but I'd like to hold off on merging it until after tomorrow's branch cut" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234667 (https://phabricator.wikimedia.org/T110721) (owner: 10Cscott) [01:23:45] (03Merged) 10jenkins-bot: BoardDescriptionWidget: Don't fetch wikitext when initializing VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231481 (owner: 10Catrope) [01:50:24] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1591432 (10TTO) Note for QA people: this is difficult to test... [02:28:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1591460 (10Mattflaschen) Also, already-existing cases will no... [02:57:07] 6Collaboration-Team-Backlog, 10Flow, 7Parsoid-Nowiki, 7WorkType-NewFunctionality: Flow puts nowiki around a mailto: link with spaces in query string - https://phabricator.wikimedia.org/T109806#1591472 (10Tgr) Affects non-mailto links as well. See e.g. the state before [[ https://www.mediawiki.org/w/index.p... [03:17:47] 6Collaboration-Team-Backlog, 10Flow: Flow eats paragraph breaks in lists - https://phabricator.wikimedia.org/T110986#1591491 (10Tgr) 3NEW [03:22:04] nom nom nom [04:00:39] (03PS1) 10Mattflaschen: Fix removing references by using right PK, only right indexes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235179 (https://phabricator.wikimedia.org/T107204) [04:03:39] (03CR) 10Mattflaschen: "The other way I could think of to fix this was to change URLReference->fromStorageRow and WikiReference->fromStorageRow to calculate the w" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235179 (https://phabricator.wikimedia.org/T107204) (owner: 10Mattflaschen) [04:17:14] (03PS4) 10Mattflaschen: Allow converting entire LQT namespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) (owner: 10Sbisson) [04:23:16] (03CR) 10Mattflaschen: [C: 032] "Looks good. I focused on testing the behavior for on-by-default namespaces." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) (owner: 10Sbisson) [04:24:42] (03CR) 10Mattflaschen: "(Using wgLqtTalkPages, not the per-namespace config)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) (owner: 10Sbisson) [04:25:36] (03Merged) 10jenkins-bot: Allow converting entire LQT namespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) (owner: 10Sbisson) [06:05:05] (03CR) 10Matthias Mullie: "Should be updated to reflect https://gerrit.wikimedia.org/r/#/c/235179/1/container.php" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232465 (https://phabricator.wikimedia.org/T108104) (owner: 10Matthias Mullie) [06:05:37] (03CR) 10Matthias Mullie: [C: 032] Fix removing references by using right PK, only right indexes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235179 (https://phabricator.wikimedia.org/T107204) (owner: 10Mattflaschen) [06:07:33] (03Merged) 10jenkins-bot: Fix removing references by using right PK, only right indexes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235179 (https://phabricator.wikimedia.org/T107204) (owner: 10Mattflaschen) [06:09:28] (03CR) 10Matthias Mullie: Beta feature Flow on user talk page (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [06:10:00] (03CR) 10Matthias Mullie: [C: 031] "LGTM! Merge whenever we want to deploy this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [06:23:47] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow's elapsed Timestamp message at Lvwp, changes to an incorrect translation after loading is complete - https://phabricator.wikimedia.org/T110934#1591726 (10Edgars2007) During load: {F2522199} After load: {F2522198} Also note that 15 hours changes to 16 hours.... [07:38:36] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets: Add Arabic (ar) translation of the new namespaces for Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T110999#1591816 (10Meno25) 3NEW [08:51:43] 6Collaboration-Team-Backlog, 10Flow: Style of new anon edit warning - https://phabricator.wikimedia.org/T110086#1591975 (10Pginer-WMF) As I understand this scenario we need to support two different needs: - For users that didn't realised they were logged out, we want to clearly communicate they are logged out.... [09:39:48] 6Collaboration-Team-Backlog, 10Flow: Logged out warning is un-dismissable - https://phabricator.wikimedia.org/T108836#1592085 (10Pginer-WMF) I understand the problem of overlapping information on the sidebar, which may also increase the chances of users to start writing content before noticing. It is not comp... [11:38:40] 6Collaboration-Team-Backlog, 10Echo, 10Wikidata, 7Need-volunteer: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#1592373 (10Lydia_Pintscher) p:5Triage>3Normal [12:53:39] (03CR) 10Sbisson: [C: 032] Don't change editor preference if preferred editor is unsupported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235167 (https://phabricator.wikimedia.org/T110706) (owner: 10Catrope) [12:57:19] (03Merged) 10jenkins-bot: Don't change editor preference if preferred editor is unsupported [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235167 (https://phabricator.wikimedia.org/T110706) (owner: 10Catrope) [12:58:33] (03CR) 10Sbisson: "There's something strange with this patch: the reply widget starts fully expanded." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [13:22:26] (03CR) 10Sbisson: Edit post widget (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [13:26:20] (03PS7) 10Sbisson: Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) [13:31:25] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Merge duplicate icons 'source' (in VE) and 'WikiText' (and 'NoWikiText'?) - https://phabricator.wikimedia.org/T111038#1592726 (10Esanders) 3NEW [13:31:40] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Merge duplicate icons 'source' (in VE) and 'WikiText' (and 'NoWikiText'?) - https://phabricator.wikimedia.org/T111038#1592734 (10Esanders) Separately is NoWikiText used anywhere? [13:32:05] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Merge duplicate icons 'source' (in VE) and 'WikiText' (and 'NoWikiText'?) - https://phabricator.wikimedia.org/T111038#1592736 (10Esanders) [13:45:38] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Duplicate icons: 'source' (in VE) and 'WikiText' - https://phabricator.wikimedia.org/T111038#1592837 (10Esanders) [13:51:25] (03CR) 10Sbisson: [C: 031] "Looks good and works fine but I'd like to understand the reason for this change." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [13:59:47] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Port remaining editor uses to EditorWidget - https://phabricator.wikimedia.org/T109000#1592878 (10SBisson) [15:02:02] (03CR) 10Catrope: "addJsConfigVars() is the standard way to export data in MediaWiki. Previously we were doing it the DIY way, which made Chris (our security" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [15:03:49] RoanKattouw: ^ Thanks for the explanation. Do you want me to +2 or wait? [15:04:11] We can hold that one until after the cut for paranoia [15:04:17] The cut is in like 3 hours anyway [15:04:27] alright [15:05:45] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Duplicate icons: 'source' (in VE) and 'WikiText' - https://phabricator.wikimedia.org/T111038#1593153 (10Catrope) @DannyH @PGiner-WMF you guys might have opinions about this alternative wikitext icon [15:17:09] (03PS1) 10Catrope: Add namespace for Arabic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235240 (https://phabricator.wikimedia.org/T110999) [15:18:56] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 5Patch-For-Review: Add Arabic (ar) translation of the new namespaces for Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T110999#1593230 (10Catrope) I've uploaded patches to the Gadgets and Flow extensions in your name. Plea... [15:27:06] (03PS2) 10Legoktm: Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [15:27:13] (03CR) 10Legoktm: [C: 031] Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [15:29:22] (03PS3) 10Catrope: Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 [15:40:30] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 5Patch-For-Review: Add Arabic (ar) translation of the new namespaces for Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T110999#1593353 (10Meno25) >>! In T110999#1593230, @Catrope wrote: > I've uploaded patches to the Gadge... [15:52:21] (03CR) 10CSteipp: [C: 031] "Much prefer this to the other way. Thanks!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [17:07:18] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian, Croatian and Slovenian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1593619 (10Legoktm) a:3Legoktm In `Language::getDateFormatString()`, we're not falling back to the `date` type if `pretty` is not available when using `d... [17:07:34] 3Collaboration-Team-Current, 10Echo: Date missing in Serbian, Croatian and Slovenian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1593621 (10Legoktm) [17:17:20] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1593646 (10DannyH) [17:17:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-Maintenance: VE error editing board description - https://phabricator.wikimedia.org/T110393#1593647 (10DannyH) 5Open>3Resolved [17:17:35] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Update MediaWiki-Vagrant for removal of wgFlowOccupyPages and wgFlowOccupyNamespaces - https://phabricator.wikimedia.org/T109553#1593649 (10DannyH) 5Open>3Resolved [17:17:36] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 2 others: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1593650 (10DannyH) [17:17:40] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1593651 (10DannyH) 5Open>3Resolved [17:17:46] 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkType-NewFunctionality: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1593653 (10DannyH) 5Open>3Resolved [17:17:52] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: We should update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1593655 (10DannyH) 5Open>3Resolved [17:17:54] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1593657 (10DannyH) [17:25:26] mediawiki.jqueryMsg: flow-summary-edited: Unknown operation "kön" [17:25:26] (^when I closed a topic on sv.wp) [17:25:31] "Kön" means "Gender" in Swedish [17:29:12] Josve05a: sounds like somebody mistakenly translated {{GENDER:}} to {{kön:}} in the 'flow-summary-edited' message in Swedish? i'm not sure if that magic word is translateable at all [17:29:51] I bet that it was me... [17:31:30] oH, then I might have solved a bg I filed a few weeks ago about i8n-code visable when edited the summary.. [17:31:31] https://phabricator.wikimedia.org/T108353 ? [17:31:41] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1593692 (10Esanders) Yes, I understood the request. Part of the point made was that it is difficult to dismiss if you wanted to type {{, and there are w... [17:31:46] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Make it easier to type '{{' when you don't want to insert a template - https://phabricator.wikimedia.org/T110800#1593693 (10Esanders) 5declined>3Open [17:32:16] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Editing topicsummary made by another user shows raw i18n code - https://phabricator.wikimedia.org/T108353#1593696 (10Josve05a) Is the magicword "GENDER" supposed to be (allowed) translated? [17:32:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Allow user to create new board at Special:EnableFlow without description - https://phabricator.wikimedia.org/T108348#1593699 (10Etonkovidova) Checked in betalabs - the warning is not di... [17:43:00] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 7WorkType-NewFunctionality, 7notice: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1593757 (10DannyH) [17:45:00] (03CR) 10Mooeypoo: "I think we can abandon this in light of the new editor." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/227448 (owner: 10Matthias Mullie) [17:55:41] (03CR) 10Mooeypoo: Edit post widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [17:55:56] 3Collaboration-Team-Current, 10Flow, 7Regression: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1593815 (10Catrope) p:5Normal>3High [17:57:26] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1593821 (10Mattflaschen) a:3Mattflaschen [18:01:10] stephanebisson, actually, regarding my pessimistic comment about jQuery .live() and .on() -- there seems to be a way to do it with event bubbling by attaching the event to the parent instead of the actual element itself, but we will need to readjust the selectors we use. (And if this works, we should probably do it for the replyWidgets in flow-initialize too) see http://stackoverflow.com/questions/8752321/jquery-live-vs-on-method-fo [18:01:10] r-adding-a-click-event-after-loading-dynamic-ht [18:01:21] er http://stackoverflow.com/questions/8752321/jquery-live-vs-on-method-for-adding-a-click-event-after-loading-dynamic-ht [18:03:10] mooeypoo: Yeah isn't that how the other editor hookups in flow-initialize are already doing it? [18:04:02] $board.on( 'click', '.reply-link', function () { ... } ); or whatever [18:04:02] nope, we each created a method we then call on refreshTopic event. [18:04:02] We thought we're cheating the system. [18:04:07] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1593860 (10Mattflaschen) 3NEW a:3Mattflaschen [18:06:11] (03CR) 10Catrope: Edit post widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [18:08:54] pginer: Are you coming to our discussion meeting? [18:09:06] I’m in the hangout alone [18:09:16] which make me think it may be the wrong one [18:09:18] join the one for the standup [18:09:24] we didn't leave it, ended up reusing it [18:10:23] ok. Thanks [18:10:43] Oh, crap, sorry [18:10:47] I'll change the calendar invite [18:13:56] (03PS8) 10Sbisson: Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) [18:37:29] (03CR) 10Mooeypoo: [C: 032] "WFM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [18:40:26] (03Merged) 10jenkins-bot: Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [19:05:18] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor: Duplicate icons: 'source' (in VE) and 'WikiText' - https://phabricator.wikimedia.org/T111038#1594141 (10Jdforrester-WMF) p:5Triage>3Low [19:33:45] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1594358 (10Mattflaschen) a:5Mattflaschen>3None [19:36:15] (03PS1) 10Sbisson: Browser tests: fix typo in step usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235296 [19:41:18] (03CR) 10Mattflaschen: [C: 032] Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [19:42:46] (03PS4) 10Mattflaschen: Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [19:44:43] matt_flaschen: Would you mind me moving our 1:1 half an hour later, to 1:30 Pacific instead of 1pm Pacific? [19:45:22] RoanKattouw_away, that's fine. [19:45:28] Thanks [19:46:55] (03CR) 10Mattflaschen: [C: 032] Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [19:47:05] And thanks for that too [19:47:19] (03CR) 10Catrope: [C: 032] Browser tests: fix typo in step usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235296 (owner: 10Sbisson) [19:48:48] (03PS33) 10Catrope: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [19:50:40] (03CR) 10Catrope: [C: 04-1] Beta feature Flow on user talk page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [19:53:52] (03Merged) 10jenkins-bot: Use addJsConfigVars() instead of makeInlineScript() for JSON blob [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235162 (owner: 10Catrope) [19:55:05] (03Merged) 10jenkins-bot: Browser tests: fix typo in step usage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235296 (owner: 10Sbisson) [19:57:04] (03PS34) 10Catrope: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [19:57:24] (03CR) 10Catrope: "PS34: Crushed SVG file with:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [19:57:53] (03PS35) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [19:58:43] (03CR) 10Sbisson: Beta feature Flow on user talk page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [19:59:30] stephanebisson: Whoops, sorry about amending after -1ing there [19:59:42] Your PS35 overwrote my PS34 and I have only myself to blame [19:59:54] oups, no worries [20:02:39] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in Beta and production - https://phabricator.wikimedia.org/T111098#1594416 (10Mattflaschen) 3NEW [20:03:11] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in Beta and production - https://phabricator.wikimedia.org/T111098#1594432 (10Mattflaschen) [20:03:13] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: We should update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1594433 (10Mattflaschen) [20:03:20] (03CR) 10Mooeypoo: [C: 032] Add namespace for Arabic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235240 (https://phabricator.wikimedia.org/T110999) (owner: 10Catrope) [20:05:31] (03Merged) 10jenkins-bot: Add namespace for Arabic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235240 (https://phabricator.wikimedia.org/T110999) (owner: 10Catrope) [20:05:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): Don't switch preference for VE/wikitext if your device doesn't support your preferred editor - https://phabricator.wikimedia.org/T110706#1594445 (10Etonkovidova) Checked in mobile(Android/iOS) betalabs - the user e... [20:06:30] stephanebisson, https://phabricator.wikimedia.org/T109000 is "in development" when it was reviewed and (recently) merged. Can I move it to QA review or is there anything you're actively re-working on? [20:06:44] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in Beta and production - https://phabricator.wikimedia.org/T111098#1594453 (10Mattflaschen) Doing Beta now. [20:07:10] mooeypoo: it's in 2 parts: edit post and summary [20:07:22] oh, wait, no, --- right, I was going to say, I forgot there's also summary and post [20:07:30] mooeypoo: I'll split it so we can move one part into QA [20:08:03] ah, awesome [20:09:40] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1594478 (10Mooeypoo) We should really change the way we calculate seen time in general, which would solve both the... [20:10:10] 3Collaboration-Team-Current, 10Flow: Use EditorWidget for topic summary - https://phabricator.wikimedia.org/T111102#1594479 (10SBisson) 3NEW a:3SBisson [20:10:41] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22), 7WorkType-NewFunctionality: Use EditorWidget for edit post - https://phabricator.wikimedia.org/T109000#1594489 (10SBisson) [20:11:26] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in production - https://phabricator.wikimedia.org/T111098#1594498 (10Mattflaschen) [20:13:07] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in production - https://phabricator.wikimedia.org/T111098#1594416 (10Mattflaschen) It turned out this ran automatically on Beta (I believe as part of update.php). [20:14:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Script to update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1594502 (10Mattflaschen) [20:14:48] 3Collaboration-Team-Current, 10Flow: Run FlowCreateTemplates.php on all Flow-enabled wikis in production - https://phabricator.wikimedia.org/T111098#1594504 (10Mattflaschen) [20:14:50] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1594503 (10Mattflaschen) [20:14:51] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Script to update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1443487 (10Mattflaschen) [20:23:44] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Editing topicsummary made by another user shows raw i18n code - https://phabricator.wikimedia.org/T108353#1594548 (10Mattflaschen) Per @josve05a on IRC, this also results in: ``` mediawiki.jqueryMsg: flow-summary-edited: Unknown operation "kön" ``` That indicates... [20:23:55] (03PS1) 10Mooeypoo: Remove 'last modified' message from the description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235353 (https://phabricator.wikimedia.org/T110082) [20:24:19] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Take out "This description has been modified" line in side rail legal text - https://phabricator.wikimedia.org/T110082#1594555 (10Mooeypoo) a:3Mooeypoo [20:34:42] stephanebisson, meh, I"m testing your opt in patch and I am again running into issues. What am I missing? I have $wgFlowEnableOptInBetaFeature = true; in LocalSettings. I removed $wgNamespaceContentModels[ NS_USER_TALK ] = CONTENT_MODEL_FLOW_BOARD; so my namespace is unoccupied... I made a new user, opted-in, and I have no board. [20:35:28] oh! NOW I have a board... on second loading. [20:36:00] mooeypoo: anything in the exception log? [20:36:00] it's a bit long so it's running in a deferred update... [20:36:36] now I did the same thing, and I see Unknown topic [20:36:36] The requested topic does not exist. [20:36:47] stephanebisson, and then I refreshed and all is good [20:37:06] stephanebisson, I think that it's probably going to be common for users to enable and then go to their user talk page immediately (like I did) [20:37:09] Can we have a placeholder ? [20:37:18] like.. "Your new talk page is being prepared" or something ? [20:39:18] putting the placeholder would also take time, if you have a talk page we have to archive we're already halfway in the process [20:39:35] Hm. [20:40:11] I think we should be aware this is potentially problematic. I didn't really hurry after enabling, but I did go to see how my new talk page looks like -- before it was ready. [20:40:12] if you go from the notification it's gonna be ready [20:40:21] I agree [20:40:25] yeah I checked that now -- the notification works great [20:40:30] but users will probably not wait [20:41:02] I wonder if there's any temporary state we can put the talk page in [20:41:13] having proper transactions would be sweet so you don't see the in-between state [20:41:51] stephanebisson, I think we should, at the very least, tell the user "The conversion will be ready in a few seconds" or something after enabling. Something to set up the expectation [20:41:57] I thought it failed when I first tried. [20:42:32] is there a way to send user messages on the preference page? [20:42:44] Hmmm. There is in javascript [20:42:47] not sure about the php side [20:43:02] There are the system popup message thingies [20:43:28] stephanebisson, BetaFeatures already does that with "Your preferences have been saved." [20:43:34] but on the js end [20:43:39] (Which might be enough) [20:45:38] I wonder if a message about their talk page would cause people to wait or to immediately go there... [20:45:57] we could also ditch the deferred update [20:46:03] hmmm [20:46:05] I am not sure. [20:46:17] also, stephanebisson, I broke your system.... I found a somewhat convoluted bug. An edge case, I think, but worth noting. [20:46:47] 6Collaboration-Team-Backlog, 10Flow: Topic summary edited in VE: Template displays multiple 'Describe briefly the outcome of this discussion' - https://phabricator.wikimedia.org/T111107#1594668 (10Etonkovidova) 3NEW [20:47:09] New user without wikitext page, enable flow -> perfect. I added a test topic, then disabled flow -> got back a wikitext page: perfect. Then I wrote stuff in the wikitext page, and enabled flow again. [20:47:30] The same old flow board came back (perfect) *but* I have no statement about the archiving of my now existing wikitext page [20:47:50] so when you "recreate" the flow board, maybe it's worth rechecking if there should be an archiving message? [20:48:26] yes [20:48:43] but I don't know if you should have had a wikitext page after you disabled [20:49:01] I got an empty wikitext page, that's good, no? [20:49:08] No longer a flow board -- back to the talk pages [20:49:22] since you didn't have a wikitext talk page to begin with [20:49:53] yes, but consider the scenario of a user testing this out, regretting and moving back to talk page. Now they have a talk page for a month, and they re-enable Flow [20:50:17] their talk page is archived correctly (I checked, the page is in the right place, and comes back when you disabled again) -- but it essentially vanished from the user, because there's nothing saying it was archived [20:50:21] the archiving process happens, though [20:51:10] agree but initially if you don't have a talk page, you enable and then disable, you should see "deleted without redirect" [20:51:20] I saw that [20:51:35] but then I edited it to make myself a talk page [20:51:40] I see [20:51:45] The problem only happened on the second time that I enabled Flow [20:51:57] then yes, we're missing the archive template the second time [20:51:58] it brought back the old Flow board, which is good, but it didn't re-check for the archive notice [20:52:49] Other than those two issues things look great. I'm considering rebasing the opt in guided tour on top of your commit so I can test that together [20:52:57] seems they're not going to be merged separately anyways [20:53:50] yeah, they should be together [20:58:18] mooeypoo: I tried it and I got the template in the header [20:58:33] mooeypoo: maybe the edit header didn't work for you [20:58:41] anything weird in the board history? [20:58:49] or in the exception log? [21:01:38] quiddity: that bug is significantly more than just serbian...I'm running a script right now to find the other languages :\ [21:01:52] :< [21:02:31] 6Collaboration-Team-Backlog, 10Flow: Categories box is misaligned on Flow pages? - https://phabricator.wikimedia.org/T111110#1594707 (10Etonkovidova) 3NEW [21:12:25] quiddity: http://fpaste.org/262224/41936144/raw/ [21:12:35] >..< [21:15:06] stephanebisson, I didn't see anything but I'm checking again [21:15:34] mooeypoo: is it possible that it wasn't finished when you got the page? [21:15:44] stephanebisson, yeah, maybe. [21:15:46] let me try again [21:16:11] stephanebisson, yes, that's it. Now it appears (after I waited for it a bit) [21:16:20] ok [21:16:22] Ok, so both issues are actually the same issue [21:19:51] (03CR) 10Catrope: [C: 032] Use the VirtualRESTService to configure Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234667 (https://phabricator.wikimedia.org/T110721) (owner: 10Cscott) [21:22:10] (03Merged) 10jenkins-bot: Use the VirtualRESTService to configure Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234667 (https://phabricator.wikimedia.org/T110721) (owner: 10Cscott) [21:22:28] stephanebisson, mooeypoo, it might be fast enough to get away with running it before the user gets the response (though we need to be careful about that), but I'm also not sure how to solve the transaction problem. Using a deferred update also solved that. [21:22:48] Maybe we could improve the situation by updating the i18n message on BetaFeatures ("You will be notified..."). However, it's not realistic to expect everyone to read that message. [21:23:00] mooeypoo, do you want me to wait until your GuidedTour commit is chained, or review now? [21:23:24] matt_flaschen, are we going to merge the two commits separately or is it going to wait for stephanebisson's commit anyways? [21:23:28] if it's the latter, I might as well rebase [21:23:41] but if we plan to merge now, then no need [21:23:43] I don't see anything wrong with merging separately, but I can do it either way. [21:23:53] matt_flaschen: do you think deferred updates in prod would be faster or slower than on our setup? [21:24:32] If it's ready for merge, then I think we can just go for it. It won't actually activate until the opt in change anyways, but will allow us to test them together and not have the other one go stale and have to be rebased too many times when it's ctually ready [21:24:35] +A [21:24:38] err +a [21:24:52] stephanebisson, not sure. [21:25:32] But I don't think it's scheduled. I think it runs immediately after we tell the user's browser 'response is done'. [21:27:17] stephanebisson, ori might be able to tell you more about it. He's in #wikimedia-dev. [21:27:50] Hey guys -- I just sent email to WMF-all and Wikitech-l about the Collab team priority change [21:28:05] For deferred updates AaronSchulz might also be able to help [21:28:40] Nothing surprising for Collab team members, just letting people know the direction [21:29:10] (03PS20) 10Mattflaschen: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [21:29:28] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1594819 (10Etonkovidova) Checked in betalabs with the sample templ... [21:29:29] Hey folks. I just saw dannyh's email re flow deprioritization. [21:29:40] Should I halt my progress towards an RFC on meta to enable flow? [21:30:10] halfak it depends on whether you think the current state is good enough for the RfC [21:30:29] It seems that there's still open requests for admin/curation feature for Flow. I've been betting on those getting done soon. [21:30:58] that may be the Workflows project? depending on what you mean [21:31:00] I don't have specifics handy but I can dig into specific bugs. [21:32:05] Regretfully, I only have notes from a meeting with dannyh about the status of flow last March. [21:32:24] There was a set of bugs that were blockers for deployment on enwiki [21:32:28] * dannyh yeah, let me know -- the major thing that's shelved is search on a Flow board, and some notifications/watchlist upgrades [21:32:56] They were to be fixed by April 17th, 2015 [21:32:58] stephanebisson, do you need help with the porting of the editor widget? [21:33:07] ring a bell dannyh ? [21:33:10] halfak, by 'admin' do you mean admin actions like deletion, or 'administration' is the normal meaning of the word? [21:33:19] wiki sysop [21:33:28] Deletion/undeletion of threads [21:33:28] halfak, the key admin support is already there IMHO (board/topic/post hide/deletion/suppress), with some small issues we're going to finish up despite the deprioritization. There are some other admin items that are not as urgent that we might do as a result of the deprioritization. [21:33:33] That's implemented. [21:33:53] Cool. That's really what I needed to know. [21:33:57] Thanks matt_flaschen and dannyh [21:34:02] halfak okay, cool [21:34:04] FWIW, I'll be moving forward. [21:34:06] :) [21:34:13] With the RFC that is. [21:34:17] yup :) [21:34:25] Probably just for the research namespace, but we'll see. [21:34:50] mooeypoo: I will need help understanding the desire architecture and relationship between model, api, widgets. It's pretty cloudy with the old system in place... [21:35:12] *desired [21:35:30] stephanebisson, yeah the old system is confusing. I can help whenever with the architecture stuff, though. If you want on IRC or on hangouts, or wherever/whenever. [21:35:37] mooeypoo: I have to go now. Can we talk tomorrow? [21:35:46] stephanebisson, yep no problems [21:35:51] have a good evening! [21:35:52] thanks! [21:35:57] Yep, have a good night. [21:37:38] halfak: I was thinking of Just Doing It for MW.org, FWIW… [21:37:47] halfak: (Speaking in my 'personal' +crat capacity there.) [21:38:17] halfak: Not sure whether proposing it on meta and MW.org at the same time would spook people. [21:38:23] Seems like that would be a fine idea. [21:38:26] Oh good point. [21:38:29] I'm not in a rush. [21:38:34] * James_F isn't either. :-) [21:38:39] :) [21:38:39] halfak: Do you want to go first? [21:38:48] BTW, would love your feedback on my draft post. [21:38:55] Sure. [21:39:08] https://meta.wikimedia.org/wiki/User:EpochFail/Flow_RFC [21:41:05] mooeypoo: https://phabricator.wikimedia.org/T109365 [21:43:01] 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Exception Caught: Row has null primary key - https://phabricator.wikimedia.org/T110390#1594895 (10Etonkovidova) Checked in betalabs - all is fixed. - removing templates - removing categories/lin... [21:43:19] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Date missing in Serbian, Croatian and Slovenian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1594898 (10Legoktm) This affects significantly more than Serbian, Croatian and Slovenian...confirmed using the same script that all in... [21:43:36] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Dates missing on Special:Notifications in many languages - https://phabricator.wikimedia.org/T110945#1594900 (10Legoktm) p:5Triage>3High [21:44:32] (03PS36) 10Catrope: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [21:44:48] (03PS37) 10Catrope: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [21:44:57] (03CR) 10Catrope: [C: 032] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [21:47:18] (03Merged) 10jenkins-bot: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [21:51:46] dannyh: around ? [21:52:04] (03PS1) 10Mooeypoo: Always refetch data editing description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235364 (https://phabricator.wikimedia.org/T109365) [21:52:11] RoanKattouw, uh... ^^ [21:52:12] matanya hi, Matanya -- around for a minute, but about to go into a meeting [21:52:34] matanya I'll be around after that? if you are, I don't know what time it is for you :) [21:52:59] dannyh: just a clarificarion on flow dev work. will it stop? [21:53:06] it is 1 am [21:54:57] legoktm, about to test and merge your patch. Going to do a minor amend for a docfix. Clarification, do you know what 'both' means in date, time or both? Do you literally pass in 'both', or 'datetime', or what? [21:55:09] halfak: https://meta.wikimedia.org/wiki/User:EpochFail/Flow_RFC LGTM. (Except for not doing ''e.g.'' but I'm just fussy. ;-)) [21:55:12] That docblock is quite confusing. [21:55:41] matt_flaschen: you pass in the literal string 'both' [21:55:48] matanya we're moving to Workflows earlier than we thought. there are some more features coming this month, including splitting the notifications panel to two icons, and opt-in Beta feature for user talk pages. [21:55:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Cancel keeps temporary text in editors - https://phabricator.wikimedia.org/T109365#1594947 (10Mooeypoo) a:3Mooeypoo [21:55:58] (03CR) 10Catrope: [C: 032] Always refetch data editing description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235364 (https://phabricator.wikimedia.org/T109365) (owner: 10Mooeypoo) [21:56:02] matanya and then Workflows starting in October [21:56:03] Thanks, legoktm. [21:56:29] i fear flow wil end like lqt [21:56:43] *will [21:57:00] matt_flaschen: T109814 Links from Flow topics to special pages are incorrectly included in link tables --- what exactly are "link tables"? [21:57:13] 3Collaboration-Team-Current, 10Flow: Warn the user if they cancel an editor with data in it - https://phabricator.wikimedia.org/T111115#1594957 (10Mooeypoo) 3NEW a:3Mooeypoo [21:57:38] etonkovidova: Tables that track which page links to which other page, which page is in which category, which page uses which template, etc [21:57:46] etonkovidova, yeah, full list: [21:57:53] * pagelinks (ordinary links e.g. List of planets linking to Mercury) [21:58:13] * templatelinks (template transclusions, e.g. which pages use Template:Cite web to cite a web site) [21:58:25] * imagelinks (uses of media such as images) [21:58:36] (03Merged) 10jenkins-bot: Always refetch data editing description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235364 (https://phabricator.wikimedia.org/T109365) (owner: 10Mooeypoo) [21:58:36] matt_flaschen: hmm... and they are not db tables? [21:58:37] * categorylinks (uses of categories) [21:58:46] (03CR) 10Jforrester: "Woo. Needs some minor follow-up to fully comply with https://www.mediawiki.org/wiki/Beta_Features/Package which I've mentioned to Roan. Aw" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [21:58:54] * externallinks (URL links to external sites) [21:59:13] * langlinks (links to foreign-language versions of the same page, but this is implemented differently now that we have Wikidata) [21:59:43] * iwlinks - Links to separate sites through wiki links (e.g. Wiktionary) [22:00:11] matt_flaschen: I see [22:00:15] etonkovidova, they are DB tables. [22:00:37] etonkovidova, also Flow has flow_wiki_ref and flow_ext_ref to track internally what specific part of the page has the link. [22:00:39] matt_flaschen: yes, I see them there thx! [22:01:14] E.g. if a topic links to [[Earth]], Flow tracks internally whether it's the topic summary or the post. This is because at the core level, we only have board and topic pages, which isn't enough granularity to show meaningful output to the user. [22:01:31] I believe flow_wiki_ref is used for all of them except URLs, which use flow_ext_ref. [22:02:10] I believe all of them also track red links, so having a link in the table doesn't mean the destination page exists. [22:02:36] mooeypoo: In VE, look at CancelConfirmDialog and at onBeforeUnload [22:02:56] matt_flaschen: thx again. Will dive in and track down link stuff [22:04:21] etonkovidova, these are also documented on-wiki if you haven't seen: E.g. https://www.mediawiki.org/wiki/Manual:Pagelinks_table . Main page: https://www.mediawiki.org/wiki/Manual:Database_layout [22:11:12] James_F, no use of "e.g."? [22:11:36] halfak: No, I mean s/e.g./''e.g.''/ – put it in italics. :-) [22:11:37] * halfak letting his formal technical writing infect his wiki vernacular -- or something else? [22:11:41] oh! [22:11:45] * James_F grins. [22:11:48] As I said, very fussy. [22:11:50] Not infected enough! [22:12:11] Thanks for taking look :) [22:14:35] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Dates missing on Special:Notifications in many languages - https://phabricator.wikimedia.org/T110945#1595017 (10Legoktm) (The script I used to generated the list was P1963). [22:15:38] matt_flaschen: woot, thanks [22:16:01] legoktm, no problem, wanted to give you a chance to evening SWAT it if you want. [22:17:16] matt_flaschen: probably not. AFAICT, this bug has existed since ever and no one noticed until now, and it touches an area of core that took me 2 hours to properly understand [22:17:31] also my internet is being really really terrible right now [22:18:02] legoktm, they probably just never knew there was supposed to be a heading there... But it's not super-urgent. [22:18:15] indeed :P [22:18:15] (And anywhere else, the date would just be missing too, right?) [22:18:27] yeah... [22:18:46] since null casts to empty string [22:23:14] mooeypoo, RoanKattouw_away, legoktm, etonkovidova, have any of you used Parsoid successfully with VRS on MediaWiki-Vagrant? Trying to figure out if just my MWV is broken, or everyone's. [22:23:34] never tried [22:23:49] Okay, I'll test, looks broken though. [22:23:54] James_F might have? [22:24:13] We're now using VRS on latest Flow master, so I need to see if it's still broken after I rebase my MWV, and if so fix. [22:24:19] matt_flaschen: I find it works. [22:24:33] James_F, do you have latest Flow? [22:24:44] matt_flaschen: Oh, sorry, no. [22:27:42] Ooh, Elasticsearch has a language detector plugin. That is something people have requested (so it can detect which RTL the