[05:46:08] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1588405 (10Mattflaschen) [05:46:49] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1588088 (10Mattflaschen) [05:47:03] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1588088 (10Mattflaschen) [07:50:26] 6Collaboration-Team-Backlog, 5Patch-For-Review: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1588495 (10Pginer-WMF) >>! In T101316#1585664, @Catrope wrote: > I've been meaning to change the WT->VE button too (not just the icon, more aspects of it). Would you say that... [09:18:48] 6Collaboration-Team-Backlog, 10Flow: Edit on wikitext button on the right column of a Flow board is hidden by text. - https://phabricator.wikimedia.org/T110872#1588673 (10Trizek-WMF) 3NEW [09:19:00] 6Collaboration-Team-Backlog, 10Flow: Edit on wikitext button on the right column of a Flow board is hidden by text. - https://phabricator.wikimedia.org/T110872#1588681 (10Trizek-WMF) [09:26:08] 6Collaboration-Team-Backlog, 10Flow, 7Design: Usernames are too emphasized - https://phabricator.wikimedia.org/T94294#1588688 (10Elitre) Came here to post a similar remark. [10:21:14] (03PS1) 10Matthias Mullie: Don't include Special pages as wiki links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234972 (https://phabricator.wikimedia.org/T109814) [10:48:06] (03CR) 10TTO: [C: 04-1] "I think this needs to exclude the Media: (-2) namespace as well." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234972 (https://phabricator.wikimedia.org/T109814) (owner: 10Matthias Mullie) [11:13:53] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n: Translation of new namespace at or.wikipedia.org - https://phabricator.wikimedia.org/T110879#1588910 (10TTO) [11:15:53] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n: Translation of new namespace at or.wikipedia.org - https://phabricator.wikimedia.org/T110879#1588918 (10TTO) [11:17:18] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n: Translation of new namespace at or.wikipedia.org - https://phabricator.wikimedia.org/T110879#1588920 (10TTO) This is not a site request; the changes need to occur in the extensions themselves. [11:17:21] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n: Translation of new namespace at or.wikipedia.org - https://phabricator.wikimedia.org/T110879#1588921 (10Revi) [11:17:25] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n: Translation of new namespace at or.wikipedia.org - https://phabricator.wikimedia.org/T110879#1588925 (10Revi) Edit conflict, huh. [11:25:03] (03CR) 10Sbisson: "> OOjs uses composition too" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen) [11:28:38] hey mlitn [12:01:39] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-Gadgets, 7I18n: Translation of new namespace at or.wikipedia.org - https://phabricator.wikimedia.org/T110879#1588974 (10Jnanaranjan_sahu) [12:43:34] hey stephanebisson [12:43:43] hey [12:43:50] do you think the beta feature can be merged now? [12:45:29] erm [12:45:33] probably :p [12:45:36] let me just try disabling again [12:45:59] other than that, it seemed ready last week [12:48:41] bad bad wifi connection [13:08:10] (03PS4) 10Sbisson: Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) [13:21:57] stephanebisson: still around? [13:22:03] mlitn: yes [13:22:37] I just read you’re about to leave soon, so haven’t had time to properly figure it out [13:22:47] disabling still isn’t working for me [13:23:02] and it looks like the onUserSaveOptions is why it’s not working [13:23:13] there’s a $before & $after check [13:23:18] and $before is unreliable for me [13:23:37] when disabling (where it was previously enabled), it says $before is false [13:23:41] (03PS5) 10Sbisson: Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) [13:23:53] I think it is because user preferences are also cacheable [13:24:03] and I assume at that point, cache has already updated [13:24:20] so trying to fetch it from a new user object doesn’t work (already returns the new value) [13:24:26] I’m not 100% sure yet [13:24:53] mlitn: i'm not leaving yet [13:25:30] if that is indeed the case, do you see a problem with replacing the $before check to $before = , instead of $before = ? [13:25:31] ah, ok :p [13:25:53] onUserSaveOptions should not try to do anything when the beta feature is false.... I forgot to do that properly [13:26:16] (03CR) 10jenkins-bot: [V: 04-1] Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [13:26:21] well, it should disable when the beta feature is (now) false (and was true previously) [13:26:38] it just seems like the “what was the previous value” check is unreliable for me [13:27:04] no i mean, when $wgFlowEnableOptInBetaFeature is false it should be like the hook doesn't exist [13:27:35] ha, true [13:27:39] then, checking your previous preference should work [13:27:53] but $wg… is true for me, and $before still isn’t what I’d expect it to be [13:27:59] but haven’t really figured out why, yet [13:28:00] (03PS6) 10Sbisson: Edit post widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) [13:28:06] I’ll keep looking into that [13:28:50] ok, let me know what you find, this really has to work before we release it, I expect a lot of people will try it [13:29:35] I hope so :) [13:35:36] mmh [13:37:39] (03PS31) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [13:38:12] I updated the hooks when $wgFlowEnableOptInBetaFeature is off [13:40:30] (03CR) 10Matthias Mullie: Beta feature Flow on user talk page (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [13:40:41] problem was pretty simple [13:40:44] ah, let’s see [13:41:36] the problem was with $wgBetaFeaturesWhitelist not knowing about Flow [13:41:57] so the $before check always returned false, because beta features doesn’t think it’s an allowed feature [13:42:28] as soon as I added it to $wgBetaFeaturesWhitelist, disabling also worked fine [13:43:19] but we should probably make it more obvious that this feature has to be part of $wgBetaFeaturesWhitelist (either replacing $wgFlowEnableOptInBetaFeature, or automatically adding it if $wgFlowEnableOptInBetaFeature === true) [13:45:12] (also: weird how GetBetaFeaturePreferences hook lets you add features that it doesn’t consider allowed :p) [14:09:31] (03PS2) 10Matthias Mullie: Don't include virtual pages as wiki links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234972 (https://phabricator.wikimedia.org/T109814) [14:15:11] (03PS1) 10Matthias Mullie: Disable Echo notifications for FlowFixLinks.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235002 (https://phabricator.wikimedia.org/T110851) [14:15:29] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1589211 (10matthiasmullie) a:3matthiasmullie [15:03:07] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1589365 (10Pginer-WMF) >>! In T108266#1585539, @Mooeypoo wrote: > Here are... [15:34:59] (03CR) 10Matthias Mullie: [C: 04-1] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [15:41:35] quiddity: fyi https://meta.wikimedia.org/wiki/Steward_requests/Bot_status#Flow-diskussionssideshanterare.40svwiki [15:43:01] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1589488 (10Esanders) I think it can be improved, for example pressing escape/cancel should leave the {{ on the page, but given that it's such a rare thi... [15:46:59] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1589492 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester-WMF I think the ask here is to be able to type `{{foo}}` and just have it insert the te... [16:27:34] matt_flaschen: Good morning! I am having a strange problem with my vagrant - on http://127.0.0.1:8080/wiki/Talk:Flow_QA I see: {"flow-workflow":"sl7tycx0fusebpyj"} [16:28:01] matt_flaschen: could it mean that I need to re-enable roles? I checked roles - Flow is enabled... [16:33:57] (03CR) 10Esanders: [C: 031] Use wikitext icon from VE for the VE->WT switch tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [16:36:42] legoktm, thanks for the link. I'm confused though.. What would you suggest I need to do? [ The original account name is still a bot/flow-bot (https://sv.wikipedia.org/wiki/Anv%C3%A4ndare:Flow_talk_page_manager ) and has all the edits. It doesn't look as if https://sv.wikipedia.org/wiki/Anv%C3%A4ndare:Flow-diskussionssideshanterare was ever used... ] [16:38:50] quiddity: nothing, it was just a fyi :P I thought they might be having a discussion about Flow somewhere, but I couldn't find any threads (nor did I look too hard) [16:39:32] okay :) (I wasn't sure if it might be a technical problem) [16:48:50] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1589665 (10Etonkovidova) Checked in betalabs - after inserting &saving [[File:Example.jpg|thumb]] - the display is fine. ``` 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1589670 (1... [16:55:30] (03PS19) 10Mooeypoo: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [16:56:32] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-Maintenance: VE error editing board description - https://phabricator.wikimedia.org/T110393#1589671 (10Etonkovidova) Re-checked in betalabs - the specific error is not present anymore. [17:19:36] 3Collaboration-Team-Current, 10Flow, 7Regression: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1589753 (10DannyH) p:5Unbreak!>3Normal [17:21:25] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: MediaWiki error for deleted Flow board, when clicking 'Show changes' - https://phabricator.wikimedia.org/T110679#1589757 (10DannyH) p:5Triage>3Normal [17:22:46] (03CR) 10Catrope: [C: 032] Disable Echo notifications for FlowFixLinks.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235002 (https://phabricator.wikimedia.org/T110851) (owner: 10Matthias Mullie) [17:22:52] 6Collaboration-Team-Backlog, 10Flow: Can not undelete deleted Flow boards using revision undeletion - https://phabricator.wikimedia.org/T110680#1589759 (10DannyH) p:5Triage>3Normal [17:23:44] (03CR) 10Catrope: [C: 032] Don't include virtual pages as wiki links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234972 (https://phabricator.wikimedia.org/T109814) (owner: 10Matthias Mullie) [17:24:28] (03CR) 10Sbisson: Beta feature Flow on user talk page (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [17:24:31] (03CR) 10Catrope: [C: 032] Allow zero-length descriptions in both S:EF and standard edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234575 (https://phabricator.wikimedia.org/T108348) (owner: 10Mattflaschen) [17:26:25] (03Merged) 10jenkins-bot: Don't include virtual pages as wiki links [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234972 (https://phabricator.wikimedia.org/T109814) (owner: 10Matthias Mullie) [17:27:34] (03Merged) 10jenkins-bot: Disable Echo notifications for FlowFixLinks.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235002 (https://phabricator.wikimedia.org/T110851) (owner: 10Matthias Mullie) [17:27:52] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Suppress Echo notifications during FlowFixLinks run - https://phabricator.wikimedia.org/T110851#1589783 (10Mattflaschen) @Catrope and I discussed this briefly, and we're thinking it's probably better not to suppress the oth... [17:28:14] (03Merged) 10jenkins-bot: Allow zero-length descriptions in both S:EF and standard edits [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234575 (https://phabricator.wikimedia.org/T108348) (owner: 10Mattflaschen) [17:28:39] (03Abandoned) 10Catrope: Use viewmodel in Echo's front end [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234451 (owner: 10Mooeypoo) [17:35:46] (03PS4) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [17:49:31] (03CR) 10Matthias Mullie: Beta feature Flow on user talk page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [17:56:08] etonkovidova, will help you fix that after retro, unless you already got it. [17:56:29] legoktm: whether I have no whitelist at all or something like: $wgBetaFeaturesWhitelist = array( 'asdf' ); my beta feature shows up in the list, what am I missing? [17:57:31] matt_flaschen: ok - yes, still need your help. [18:02:58] (03PS11) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [18:27:15] (03CR) 10Mooeypoo: [C: 04-1] BoardDescriptionWidget: Don't fetch wikitext when initializing VE (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231481 (owner: 10Catrope) [19:02:12] (03CR) 10Mattflaschen: "See inline re Media." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234972 (https://phabricator.wikimedia.org/T109814) (owner: 10Matthias Mullie) [19:06:15] mooeypoo, is etonkovidova around, or at lunch? [19:11:58] 6Collaboration-Team-Backlog, 10Flow, 7I18n: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1590319 (10Nemo_bis) 3NEW [19:19:49] (03CR) 10Sbisson: Beta feature Flow on user talk page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [19:24:52] 6Collaboration-Team-Backlog, 10Flow, 10Web-APIs-Hub: Enable Flow on Web APIs talk pages on mediawiki.org - https://phabricator.wikimedia.org/T103049#1590372 (10Spage) 5Open>3Resolved Thanks @DannyH all done, until the next pages :) Danny and Quiddity are writing a Flowify mw.org proposal, I would rather... [19:25:21] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow's elapsed Timestamp message at Lvwp, changes to an incorrect translation after loading is complete - https://phabricator.wikimedia.org/T110934#1590378 (10Quiddity) 3NEW [19:27:55] 6Collaboration-Team-Backlog, 10Flow, 7I18n: GENDER support in flow-error-edit-restricted - https://phabricator.wikimedia.org/T110932#1590389 (10Aklapper) [19:34:25] matt_flaschen: They're at lunch [19:37:59] matt_flaschen: I am back - if you have a time to help me, it'd be great. I can login to http://127.0.0.1:8080/wiki/Talk:Flow_QA [19:38:07] matt_flaschen: and I see on the page: {"flow-workflow":"sl7tycx0fusebpyj"} [19:38:27] (03PS32) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [20:00:45] etonkovidova, try: [20:01:35] in vagrant ssh: [20:02:05] mwscript extensions/Flow/maintenance/FlowUpdateRevContentModelFromOccupyPages.php [20:02:14] Sorry, thought I already had that on the clipboard. [20:02:53] matt_flaschen: hmm... ok I re-run it [20:03:02] You ran that before? [20:03:37] matt_flaschen: yes, that script was the starting point of my troubles :( [20:04:14] vagrant@mediawiki-vagrant:~$ mwscript extensions/Flow/maintenance/FlowUpdateRevContentModelFromOccupyPages.php [20:04:14] Set content model for 0 pages; skipped 0 pages. [20:05:21] etonkovidova, okay, I'm in a meeting so I'm multi-tasking. One sec [20:06:04] etonkovidova, okay, that means you don't have any occupied pages. I'm not sure the script caused the issues. [20:06:17] matt_flaschen: do not worry - it's not urgent. [20:06:37] etonkovidova, okay, I didn't want to block you. We can continue after the meeting. [20:06:54] matt_flaschen: sure :) Thx! [20:41:24] (03PS1) 10Sbisson: Remove duplicated 'loadmore' event handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235127 [20:46:42] (03PS12) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [20:50:47] legoktm, we were talking in the meeting about potentially marking the echo_event with a flag (here be dragons) for hide/delete/suppression. This would be done at hide/delete/suppress time, and if the flag is 1 it would have to do special handling at display-time. [20:50:50] In theory, we wouldn't have to clear the flag on undelete/unsuppress, as long as the formatter handled the current state correctly. This would save time on the 99.9.. of events with the flag 0. [20:51:31] etonkovidova, are you there? [20:51:44] matt_flaschen: yup [20:53:13] matt_flaschen: sounds like a good idea. except we have problems with doing this already (https://phabricator.wikimedia.org/T106219) where _deleted columns aren't updated properly... [20:53:40] matt_flaschen: I think we need to have better batching instead of lots of individual look ups, and I have a few ideas for that [20:54:12] etonkovidova, what do you get for: [20:54:13] SELECT page_id, page_namespace, page_title, page_content_model, rev_id, rev_content_model FROM page JOIN revision ON page_latest = rev_id WHERE page_namespace = 1 AND page_title IN ('Sandbox', 'Flow_QA'); [20:54:15] $formatter->preload( EchoEvent[] ); [20:54:22] $formatter->format( EchoEvent )... [20:55:11] legoktm, yeah, makes sense, that's what we do for Flow integration in various places (e.g. onChangesListInitRows) [20:55:28] +---------+----------------+------------+--------------------+--------+-------------------+ [20:55:28] | page_id | page_namespace | page_title | page_content_model | rev_id | rev_content_model | [20:55:29] +---------+----------------+------------+--------------------+--------+-------------------+ [20:55:30] | 13955 | 1 | Flow_QA | flow-board | 127252 | flow-board | [20:55:32] | 37919 | 1 | Sandbox | wikitext | 171325 | NULL | [20:55:34] +---------+----------------+------------+--------------------+--------+-------------------+ [20:55:38] I don't have access to that bug, but yeah, it would definitely require being very good about setting the flag to 1 when required. [20:57:04] etonkovidova, hmm, Talk:Flow_QA is broken, but it looks right there. [20:57:10] etonkovidova, is Talk:Sandbox also broken? [20:57:41] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkType-NewFunctionality: We should update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1590625 (10Etonkovidova) Checked in betalabs... [20:58:40] matt_flaschen: argh... are you looking on your local machine? [20:59:15] etonkovidova, oh, that's in Beta? That explains the high IDs. [20:59:57] Yeah, can you do that query locally? [21:00:26] matt_flaschen: can you see https://phabricator.wikimedia.org/T106219 now? [21:00:31] matt_flaschen: locally? You mean in beta? [21:01:39] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow's elapsed Timestamp message at Lvwp, changes to an incorrect translation after loading is complete - https://phabricator.wikimedia.org/T110934#1590637 (10Catrope) Can you try using ?uselang=qqx and seeing if the message key changes after load? [21:01:41] legoktm, yeah. [21:01:49] etonkovidova, no, by locally I mean your MediaWiki-Vagrant. [21:02:04] I'm trying to help you fix your: [21:02:05] matt_flaschen: Good morning! I am having a strange problem with my vagrant - on http://127.0.0.1:8080/wiki/Talk:Flow_QA I see: {"flow-workflow":"sl7tycx0fusebpyj"} [21:02:42] matt_flaschen: hmm... do not know where to run queries locally... [21:02:54] vagrant ssh [21:02:55] mysql [21:04:09] matt_flaschen: ok [21:05:10] +---------+----------------+------------+--------------------+--------+-------------------+ [21:05:11] | page_id | page_namespace | page_title | page_content_model | rev_id | rev_content_model | [21:05:11] +---------+----------------+------------+--------------------+--------+-------------------+ [21:05:12] | 7 | 1 | Flow_QA | flow-board | 9 | NULL | [21:05:14] +---------+----------------+------------+--------------------+--------+-------------------+ [21:06:17] etonkovidova, also, if it's Beta that explains why Talk:Sandbox is wikitext (different config, happens to be a wikitext talk page): http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Sandbox [21:06:30] etonkovidova, I notice you don't have Talk:Sandbox, but that could be normal if you just never needed to use it. [21:07:22] matt_flaschen: but I used to see Talk:Flow QA page as a Flow page... [21:07:36] etonkovidova, yeah, we're going to fix that. [21:07:44] etonkovidova, anyway, there is a script way to do it (but that requires going backwards in git a little bit), or the quick fix. [21:07:46] Quick fix is: [21:08:09] UPDATE revision SET rev_content_model = 'flow-board' WHERE rev_id = 9; [21:11:29] matt_flaschen: do not like updating dbs manually -- sigh. I will do it - thx! [21:12:01] etonkovidova, you don't have to if you want to do it the maintenance script way, it will take a little longer though. [21:12:03] matt_flaschen: What is the script way and why do you have to go backwards in git for it? [21:13:29] RoanKattouw, second line at https://www.mediawiki.org/wiki/Extension:Flow#Upgrading . Because wgFlowOccupyPages was removed from MediaWiki-Vagrant in https://gerrit.wikimedia.org/r/#/c/234271/1/puppet/modules/role/templates/flow/conf.php.erb , and I can tell etonkovidova has that because she ran the script above and it said 0 pages. [21:13:59] RoanKattouw, we did this in production and Beta in https://phabricator.wikimedia.org/T109671 [21:14:24] Oh, I see [21:14:38] I also did it manually in the DB because I knew how that worked [21:15:56] RoanKattouw: matt_flaschen no problem, I'll run UPDATE [21:21:40] No JS testing looks good. [21:23:46] (03CR) 10Catrope: [C: 032] Remove duplicated 'loadmore' event handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235127 (owner: 10Sbisson) [21:24:06] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590690 (10Quiddity) 3NEW [21:24:22] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590698 (10Quiddity) [21:25:01] quiddity: wtf.... [21:26:34] 6Collaboration-Team-Backlog, 10Flow, 7Easy: New topic link broken in no-JS view for non-existent Flow boards - https://phabricator.wikimedia.org/T107929#1590718 (10Mattflaschen) This shouldn't be in the freezer. It makes it impossible to create a board normally with no-JS on Catalan. [21:28:03] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590721 (10Legoktm) What language does "sr" end up being? Echo has files for sr-ec.json and sr-el.json, no sr.json. [21:28:03] (03Merged) 10jenkins-bot: Remove duplicated 'loadmore' event handling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/235127 (owner: 10Sbisson) [21:29:28] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590727 (10Legoktm) sr -> sr-ec according to https://upload.wikimedia.org/wikipedia/commons/2/26/MediaWiki_fallback_chains.svg ?uselang=sr-ec also fails. [21:33:37] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590738 (10Legoktm) I think this has to do with `wfGetLangObj( 'sr-ec' )->getDateFormatString( 'pretty', 'default' )` returning `null`. [21:42:57] (03PS13) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [21:43:45] mooeypoo: https://gerrit.wikimedia.org/r/235127 [21:43:50] (already merged) [21:45:35] mooeypoo: https://gerrit.wikimedia.org/r/234447 [21:46:06] (03CR) 10Catrope: [C: 04-1] "Should change the icon in the other direction too" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [21:46:18] (03CR) 10Mooeypoo: [C: 031] "It works, but are we sure we want the switching icon to look so different between VE and wikitext?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) (owner: 10Catrope) [21:47:41] mooeypoo: https://gerrit.wikimedia.org/r/232883 https://gerrit.wikimedia.org/r/#/c/231483/ [21:50:03] 6Collaboration-Team-Backlog, 10Flow: Editing description on a brand new board doesn't show the new description - https://phabricator.wikimedia.org/T106459#1590794 (10Quiddity) 5Invalid>3Open Re-opening, as it was reported to have occurred at https://en.wikipedia.org/wiki/Wikipedia_talk:Flow/Developer_test_... [22:13:24] 6Collaboration-Team-Backlog, 10Echo: Date missing in Serbian Echo special:notifications - https://phabricator.wikimedia.org/T110945#1590852 (10Milicevic01) [22:13:25] 6Collaboration-Team-Backlog, 10Echo: Echo - missing dates in Serbian, Croatian and Slovenian language - https://phabricator.wikimedia.org/T110805#1590853 (10Milicevic01) [22:24:52] (03CR) 10Mooeypoo: [C: 04-1] "Overall looks great. We should at some point make a base class for all similar uses, but that's not a blocker." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234603 (https://phabricator.wikimedia.org/T109000) (owner: 10Sbisson) [22:27:47] (03CR) 10Mooeypoo: [C: 032] "wfm" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232883 (owner: 10Catrope) [22:30:10] (03Merged) 10jenkins-bot: Use moveCursorToEnd from OOjs UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232883 (owner: 10Catrope) [22:33:49] 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkType-NewFunctionality: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1590919 (10Etonkovidova) Checked Special pages - Flow is listed there. https://fa.wikibooks.org/wiki/%D9%88%DB%8C%DA%98%D9%87:%... [22:52:19] 3rd party user question, about piped links not working as expected on their instance, when using `$wgFlowEditorList = none` -- https://www.mediawiki.org/w/index.php?title=Topic:Snwu8cxuevid917x&fromnotif=1 [22:53:37] 6Collaboration-Team-Backlog, 10Flow: Flow: exception in getPostLinkAnchor in notifications for event 19743397 on enwiki - https://phabricator.wikimedia.org/T74087#1591005 (10Mattflaschen) p:5Normal>3High We should move this up. It is still happening, roughly 20 times a day on average: https://dpaste.de/N... [22:56:26] People think we should go through and add all the old bugs (in Echo, Flow, etc.) that are in neither Backlog nor Current to Backlog? [22:56:30] Pro: Consistency [22:57:14] 6Collaboration-Team-Backlog, 10Flow: 'Add a template' box looks different on Flow pages - https://phabricator.wikimedia.org/T110966#1591039 (10Etonkovidova) 3NEW [22:58:40] matt_flaschen, yes. I searched for those a few weeks ago. there are ~188 of them. [23:00:30] quiddity, 221 I think (with all our projects): https://phabricator.wikimedia.org/maniphest/query/NTLhzv0ofYMk/#R [23:02:12] sigh, moodbar.