[00:00:51] (03CR) 10Aaron Schulz: Use db-replicated objectcache for storing last seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [00:03:11] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkTypeNewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1586101 (10Mattflaschen) >>! In T98270#1575210, @QuimGil wrote: > Just curious, does this affect non... [00:05:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkTypeNewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1586102 (10Mattflaschen) Oh, I see your question is specifically in regards to the "Have Flow depend... [00:09:45] 6Collaboration-Team-Backlog, 10Flow: {{FlowMention|Someone}} displays a link that connects with the following characters after it, in case there's no space between them (but only if the text is not capitalized) - https://phabricator.wikimedia.org/T110757#1586105 (10Mattflaschen) a:3Mattflaschen [00:09:48] 6Collaboration-Team-Backlog, 10Flow: Dirty diff for [[File:...|thumb]] - https://phabricator.wikimedia.org/T110758#1586106 (10Tbayer) 3NEW [00:15:33] 6Collaboration-Team-Backlog, 10Flow: {{FlowMention|Someone}} displays a link that connects with the following characters after it, in case there's no space between them (but only if the text is not capitalized) - https://phabricator.wikimedia.org/T110757#1586129 (10Mattflaschen) This is standard link trail beh... [00:17:03] quiddity, can you take a look at https://www.mediawiki.org/wiki/Topic:Snnpfhq9n0z3k288 when you get a chance? [00:17:09] ya [00:17:35] oh, I already thanked him, and it was already updated. [00:18:52] done [00:19:22] Thanks. :) [00:26:10] 6Collaboration-Team-Backlog, 10Flow: Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1586178 (10Mattflaschen) p:5Triage>3Unbreak! a:3Mattflaschen [00:26:30] 6Collaboration-Team-Backlog, 10Flow: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1586106 (10Mattflaschen) [00:26:38] 3Collaboration-Team-Current, 10Flow: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1586106 (10Mattflaschen) [00:31:28] (03PS1) 10Mattflaschen: Work around link trail with nowiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234706 (https://phabricator.wikimedia.org/T110757) [00:35:48] (03CR) 10Mattflaschen: [C: 04-1] "I tested this wrong. It's not working yet." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234706 (https://phabricator.wikimedia.org/T110757) (owner: 10Mattflaschen) [00:43:39] ^ mooeypoo, turns out to be a Parsoid bug also. [00:44:41] matt_flaschen, yeah RoanKattouw just showed me. Weird how it only happens on capital letters, though. [00:45:03] mooeypoo, only on lower case (that's why I uploaded it, because I tested on the wrong one) [00:45:15] mooeypoo, the use case is so you can write: [00:46:15] There are 50 [[U.S. state]]s [00:46:19] and it will link correctly. [00:46:31] But it also applies for other lower-case link trails. [00:51:36] Yeah, but: [00:51:45] $ echo "{{echo|[[foo]]}}bar" | node tests/parse.js --normalize [00:51:47]

foobar

[00:51:50] * RoanKattouw files a Parsoid bug [00:52:07] RoanKattouw, I already did. [00:52:20] RoanKattouw: https://phabricator.wikimedia.org/T110772 [00:52:50] But that one is good because it's self-contained. [00:54:17] You're right that is handled wrong as well [00:54:33] (03CR) 10Mattflaschen: "This is correct for the PHP parser, but blocked on T110772 ." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234706 (https://phabricator.wikimedia.org/T110757) (owner: 10Mattflaschen) [00:55:10] matt_flaschen: It shouldn't be necessary in any case [00:55:38] I guess maybe if they make it work with but not without... but they shouldn't do that [00:55:56] RoanKattouw, meaning "Just don't write {{FlowMention|Admin}}foo", or there's a better way to do the template? [00:56:23] I don't know, I haven't found a workaround yet [00:56:32] Only more ways to expose the Parsoid bug [00:56:48] I guess we could add a zero-width non-breaking space at the end of the template? :D [00:57:01] Kind of like but hopefully that will work [00:57:04] &#feff; [00:57:26] $ echo "{{echo|[[foo]]}}bar" | node tests/parse.js --normalize [00:57:28]

foo bar

[00:57:31] 3Collaboration-Team-Current, 10Flow: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1586333 (10Tbayer) [00:57:45] Meh, Parsoid converts that to a regular space [00:58:28] RoanKattouw, let's see what the Parsoid team does with it. is the documented way to do it (https://www.mediawiki.org/wiki/Help:Links#Internal_links). [00:58:50] Yeah [01:14:41] 3Collaboration-Team-Current, 10Flow: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1586370 (10Jdforrester-WMF) Parsoid DOM for images isn't valid HTML or something. Need to use VE-MW's image code which copes with this. [01:19:26] (03PS1) 10Catrope: Load mwimage support in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234709 (https://phabricator.wikimedia.org/T110758) [01:20:35] matt_flaschen: Crap, sorry, I hadn't noticed that you had claimed https://phabricator.wikimedia.org/T110758#1586370 [01:21:59] RoanKattouw, that's okay. I was probably going to ask you for help soon anyway. Just wanted to explore that code (DOM->data model) a little and see if I could make any headway. [01:22:20] I ended up taking the shortcut of walking to James's desk [01:22:44] I got as far as getDataFromDomSubtree and model inlineImage and still didn't see anything weird. [01:22:45] And he explained that the MW image DOM is weird in a way that's apparently nonstandard which the VE-core implementation of image handling barfs on [01:23:06] Basically the DOM that ended up being sent back to Parsoid had in it :S [01:23:28] This is probably a regression, I'm pretty sure it would have come up before. [01:23:43] Well, this is a typical case of fingerpointing [01:23:50] I accused VE core of dirtying input [01:24:00] James accuses Parsoid of outputting invalid HTML [01:24:18] And I accuse VE not-core (as if it's a different team) of changing their dependencies. [01:24:26] VE-MW? [01:24:28] Based on mere suspicion! [01:24:51] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: VE/Preview broken for simple image markup - https://phabricator.wikimedia.org/T110758#1586421 (10Mattflaschen) a:5Mattflaschen>3Catrope [01:25:31] Anyway -- I didn't realize you hadn't been exposed to the DOM->data code path in VE much before (although that makes sense). I wrote most of it and I've debugged round-trip failures in it for 3 years, so I take all sorts of shortcuts [01:26:14] I haven't been exposed to most of VE, but I did learn some of it reviving the VE integration (the first revival) and implementing the mention inspector. [01:26:39] I also should have thought of checking mwimage since I had to deal with those modules back then. [01:27:01] Oh right I remember the MentionInspector stuff [01:27:02] (03PS36) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [01:27:08] That code is quite good actually [01:27:34] (03CR) 10Catrope: Split alerts and messages in Echo (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [01:27:45] Thanks. Partly by reading/borrowing a lot of VE and partly by talking to y'all [01:29:14] Yeah I remember you working with Moriel on that [01:29:18] (03CR) 10Mattflaschen: [C: 032] "Works" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234709 (https://phabricator.wikimedia.org/T110758) (owner: 10Catrope) [01:29:21] When we were still on different teams [01:35:36] (03CR) 10Catrope: Split alerts and messages in Echo (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [01:37:05] (03Merged) 10jenkins-bot: Load mwimage support in VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234709 (https://phabricator.wikimedia.org/T110758) (owner: 10Catrope) [01:44:51] 6Collaboration-Team-Backlog, 10Echo: Investigate maximum echo notification count - https://phabricator.wikimedia.org/T110745#1586442 (10Mattflaschen) >>! In T110745#1586052, @Mooeypoo wrote: > - Separate the limit between messages and alerts, especially since the popups are now separated. Agree. Also, if w... [01:59:51] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow: Flow should support making actions as a bot and set rc_bot accordingly - https://phabricator.wikimedia.org/T73197#1586452 (10jayvdb) [02:06:24] (03CR) 10Mattflaschen: Beta feature Flow on user talk page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [02:20:08] (03PS2) 10Mattflaschen: Initial refactoring to create ContentWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) [02:27:25] (03CR) 10Mattflaschen: "> I know I'm going against the grain here but have you considered an approach based on composition instead of inheritance?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen) [02:28:43] (03CR) 10Mattflaschen: Initial refactoring to create ContentWidget (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) (owner: 10Mattflaschen) [02:40:07] Have a good weekend, everyone. [02:47:01] 3Collaboration-Team-Current, 10MediaWiki-Recent-changes, 5MW-1.26-release, 5Patch-For-Review, and 2 others: "Redis::publish requires at least 2 parameters 2 given" - https://phabricator.wikimedia.org/T109544#1586517 (10Mattflaschen) Note: https://github.com/facebook/hhvm/issues/6062 has also been addressed... [06:07:15] 6Collaboration-Team-Backlog, 10Echo: Support cross-wiki rights change notification in Echo - https://phabricator.wikimedia.org/T53540#1586543 (10matej_suchanek) [15:00:36] 6Collaboration-Team-Backlog, 10Flow: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1586837 (10Yammesicka) 3NEW [16:03:18] 6Collaboration-Team-Backlog, 10Flow: Flow: Prettify thread permalink URLs/Titles (they are not human readable!) - https://phabricator.wikimedia.org/T59154#1586855 (10He7d3r) [16:10:30] 6Collaboration-Team-Backlog, 10Flow: Flow: Prettify thread permalink URLs/Titles (they are not human readable!) - https://phabricator.wikimedia.org/T59154#1586858 (10He7d3r) I had to delete ALL Topic pages from my watchlist by using Special:Watchlist/raw, because there were too many to select manually using Sp... [16:13:59] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist: Existing Flow topic appears as red link and with no link to history on Special:EditWatchlist - https://phabricator.wikimedia.org/T110801#1586861 (10He7d3r) 3NEW [16:18:28] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist: Existing Flow topic appears as red link and with no link to history on Special:EditWatchlist - https://phabricator.wikimedia.org/T110801#1586875 (10Ciencia_Al_Poder) [16:44:02] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Design: Cancel the modal on templates with no parameters - https://phabricator.wikimedia.org/T110800#1586913 (10Amire80) [18:00:18] hey... [18:01:54] I am facing a issue regarding a bug :https://phabricator.wikimedia.org/T72472 [18:40:38] 6Collaboration-Team-Backlog, 10Echo: Echo - missing dates in Serbian, Croatian and Slovenian language - https://phabricator.wikimedia.org/T110805#1586962 (10Milicevic01) 3NEW