[00:05:30] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1577907 (10matmarex) They are SVGs, but they still have to be translated to "raster" pixel-based displays when they're displayed, and they're optimized for 24x24px.  Here's the 'remove' icon at 21px...
[00:05:56] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Run subset of Echo browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109679#1577909 (10Catrope) p:5Triage>3Normal
[00:06:06] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Run subset of Flow browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109678#1577911 (10Catrope) p:5Triage>3Normal
[00:06:46] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: 'Change title' does not update 'Reply to[title]' - https://phabricator.wikimedia.org/T109898#1577913 (10Catrope) p:5Triage>3Low
[00:11:50] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Database: Add primary key or unique constraint to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1577943 (10Catrope) p:5Triage>3High
[00:13:01] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Blockers before allowing Flow opt-in on sv.wp (tracking) - https://phabricator.wikimedia.org/T109685#1577953 (10DannyH)
[00:13:03] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Make Flow respect VE's opt-out preference and not show any trace of it to the user - https://phabricator.wikimedia.org/T109684#1577950 (10DannyH) 5Open>3declined a:3DannyH We've got a sticky preference so that when you use the wikitext editor in Flow...
[00:21:33] <matt_flaschen>	 My laptop is doing its occasional thing where it refuses to switch resolutions when I plug in the external monitor, but more persistently than usual.
[00:21:37] <matt_flaschen>	 Let's see if restarting helps.
[00:32:04] <matt_flaschen>	 No luck
[00:35:50] <grrrit-wm>	 (03CR) 10Krinkle: Use db-replicated objectcache for storing last seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm)
[00:38:49] <grrrit-wm>	 (03CR) 10Krinkle: Use db-replicated objectcache for storing last seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm)
[00:42:14] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Make Flow respect VE's opt-out preference and not show any trace of it to the user - https://phabricator.wikimedia.org/T109684#1578003 (10Josve05a) No, the first act for them was to change their css-code and remove their VE-blocking code since it hide (pas...
[00:52:52] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1578055 (10Catrope) Yeah, this might be related. T97631 is about OOUI expecting the font size to be 12.8px (because it sizes the icons at 1.875em and expects that to be 24px), and that does actually...
[00:53:56] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] Defer clearTalkNotification() updates as they often happen on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234183 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz)
[01:01:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Defer clearTalkNotification() updates as they often happen on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234183 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz)
[01:05:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1578095 (10matmarex) If this is not critical, and it probably isn't, then I think the solution is to fix T97631 and continue switching Flow from mw-ui to OOUI icons.
[01:41:38] <matt_flaschen>	 Ended up having to mess with the command line and modify the X11 conf file (I was told that was no longer a thing).
[01:42:03] <matt_flaschen>	 Oh, but it uses the stylish new conf.d mechanism (/etc/X11/xorg.conf.d) so it's fine then.
[01:42:06] <matt_flaschen>	 ;)
[01:42:10] <RoanKattouw>	 I haven't had to repair my X11 config for years
[01:42:46] <matt_flaschen>	 RoanKattouw, this used to happen rarely, then I would plug the VGA cable in and out like 10 or so times, and it would work.
[01:42:52] <matt_flaschen>	 Which is itself bizarre.
[01:43:05] <matt_flaschen>	 But now that didn't even work, so I had to mess with the command-line.
[01:43:22] <RoanKattouw>	 I experienced a bug in Ubuntu for a while where it sometimes wouldn't recognize the external display I plugged in
[01:43:32] <RoanKattouw>	 for a while that was more frequent than usual
[01:43:53] <RoanKattouw>	 and I found that opening the settings screen (not even display settings, just general settings) fixed it
[01:44:05] <matt_flaschen>	 Interesting
[01:44:18] <matt_flaschen>	 For me it recognized, it just wouldn't switch the resolution.  The internal supports less than full HD, but the external supports full HD.
[01:44:22] <RoanKattouw>	 I knew I could fix it from the display settings screen, but it never gave me a chance to get there, because it would fix itself if I just threatened to go there
[01:44:29] <matt_flaschen>	 :)
[01:45:07] <matt_flaschen>	 RoanKattouw, what if the display settings screen just says, 'TODO: Update this i18n message', and that's it?
[01:46:05] <RoanKattouw>	 hahaha
[02:02:53] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: ref_target of flow_ext_ref incorrect on some tables on Beta Cluster - https://phabricator.wikimedia.org/T110446#1578196 (10Mattflaschen) 3NEW
[02:36:09] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: ref_target of flow_ext_ref incorrect on some tables on Beta Cluster - https://phabricator.wikimedia.org/T110446#1578386 (10Mattflaschen) Side note, there are also inconsistencies in CHARSET, but this might be DB-wide.
[03:06:44] <matt_flaschen>	 The Beta DB is sufficiently wrangled for tonight.  Still need to follow up tomorrow with Matthias's patch and Elena's Beta issues , which I hope are related.
[03:06:47] <matt_flaschen>	 Have a good night, all.
[05:48:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend, 7Tracking: Writing any posts through the mobile interface is completely impossible - https://phabricator.wikimedia.org/T110485#1578677 (10Amire80) 3NEW
[05:56:51] <grrrit-wm>	 (03PS1) 10Amire80: Remove double spaces in en.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234211 
[06:01:59] <grrrit-wm>	 (03PS1) 10Amire80: Remove extra space from {{#time:}} calls [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234212 
[06:02:22] <grrrit-wm>	 (03CR) 10Amire80: "Please just abandon if I misunderstood something and the space is actually needed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234212 (owner: 10Amire80)
[06:23:33] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MobileFrontend, 7Tracking: Writing any posts through the mobile interface is completely impossible - https://phabricator.wikimedia.org/T110485#1578724 (10Mattflaschen)
[06:26:41] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MobileFrontend, 7Tracking: Writing any posts through the mobile interface is completely impossible - https://phabricator.wikimedia.org/T110485#1578727 (10Catrope) Seems to be a regression in the new editor system. The `<textarea>` for submitting a post remains pending...
[06:51:49] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MobileFrontend, 7Tracking: Writing any posts through the mobile Flow interface is completely impossible - https://phabricator.wikimedia.org/T110485#1578775 (10Amire80)
[06:53:44] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Design, 7I18n, 7RTL: The icon for expanding and collapsing a Flow topic must be flipped for RTL - https://phabricator.wikimedia.org/T110488#1578780 (10Amire80) 3NEW
[07:22:19] <grrrit-wm>	 (03PS1) 10Catrope: Make SidebarExpandWidget work in RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234218 (https://phabricator.wikimedia.org/T110488) 
[07:37:32] <wikibugs>	 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Availability: SpecialNewPagesFeed abuses preferences for 'pagetriage-lastuse' key - https://phabricator.wikimedia.org/T110444#1578899 (10Nemo_bis)
[07:51:31] <grrrit-wm>	 (03PS1) 10Catrope: Fall back to the first available editor when the preferred editor is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234219 (https://phabricator.wikimedia.org/T110485) 
[07:52:28] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MobileFrontend, 5Patch-For-Review, 7Tracking: Writing any posts through the mobile Flow interface is completely impossible - https://phabricator.wikimedia.org/T110485#1578959 (10Catrope) a:3Catrope
[07:53:34] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Bump mention limit to 50 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234179 (https://phabricator.wikimedia.org/T110306) (owner: 10Mattflaschen)
[07:55:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump mention limit to 50 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234179 (https://phabricator.wikimedia.org/T110306) (owner: 10Mattflaschen)
[08:23:32] <grrrit-wm>	 (03CR) 10Mooeypoo: "This would also mean that the first edit a user does in this new available editor, this editor becomes his preferred one. I'm not entirely" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234219 (https://phabricator.wikimedia.org/T110485) (owner: 10Catrope)
[08:27:47] <grrrit-wm>	 (03CR) 10Addshore: [C: 032] Remove double spaces in en.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234211 (owner: 10Amire80)
[08:31:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove double spaces in en.json [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234211 (owner: 10Amire80)
[09:12:01] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Defer clearTalkNotification() updates as they often happen on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234183 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz)
[09:13:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Defer clearTalkNotification() updates as they often happen on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234183 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz)
[11:07:17] <wikibugs>	 6Collaboration-Team-Backlog, 10LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error:  Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1579442 (10Nemo_bis) Another example:  ``` Exception encountered, of type "BadM...
[11:14:00] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 032] Fall back to the first available editor when the preferred editor is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234219 (https://phabricator.wikimedia.org/T110485) (owner: 10Catrope)
[11:17:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fall back to the first available editor when the preferred editor is not available [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234219 (https://phabricator.wikimedia.org/T110485) (owner: 10Catrope)
[11:20:12] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1579478 (10SBisson) a:3Catrope
[11:23:21] <grrrit-wm>	 (03PS8) 10Matthias Mullie: Remove TalkpageManager::isTalkpageOccupied [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228269 (https://phabricator.wikimedia.org/T105574) 
[11:24:08] <grrrit-wm>	 (03CR) 10Matthias Mullie: Remove TalkpageManager::isTalkpageOccupied (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228269 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie)
[11:25:43] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 2 others: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1579494 (10matthiasmullie)
[11:34:23] <stephanebisson>	 hey mlitn
[11:34:45] <stephanebisson>	 do you think "Remove TalkpageManager::isTalkpageOccupied" should be merged now?
[11:35:57] <mlitn>	 yeah, it should be safe to merge now
[11:37:22] <stephanebisson>	 I'll run all the tests on it and then merge
[11:38:14] <mlitn>	 sweet
[11:41:25] <grrrit-wm>	 (03CR) 10Matthias Mullie: "Can you rebase this patch? (ideally on top of https://gerrit.wikimedia.org/r/#/c/233432/)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo)
[11:43:15] <mlitn>	 stephanebisson: do you need review on opt-in?
[11:43:29] <stephanebisson>	 mlitn: yes
[11:43:57] <stephanebisson>	 make sure NS_USER_TALK is not flow already in your setup
[11:44:16] <stephanebisson>	 for the optin to make sense user talk has to be wikitext
[11:51:26] <mlitn>	 ok
[11:52:19] <mlitn>	 damn, 1.4k additions, this will take awhile :p
[12:38:32] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Remove TalkpageManager::isTalkpageOccupied [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228269 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie)
[12:41:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove TalkpageManager::isTalkpageOccupied [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228269 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie)
[12:41:44] <grrrit-wm>	 (03PS6) 10Sbisson: Rename OccupationListener to TopicPageCreationListener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228284 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie)
[13:04:10] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Rename OccupationListener to TopicPageCreationListener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228284 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie)
[13:06:10] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename OccupationListener to TopicPageCreationListener [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228284 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie)
[13:09:15] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1579751 (10SBisson) Before: {F2458828}  After: {F2458842}  @pginer-wmf, what do you think?
[13:14:20] <stephanebisson>	 mlitn: I think all the patches for "end the occupation" have been merged
[13:14:39] <stephanebisson>	 mlitn: do you know if anything else has to be done here or does it go to QA review?
[13:15:53] <mlitn>	 great
[13:15:55] <mlitn>	 yeah, that should be it
[13:16:03] <mlitn>	 you can move it to QA :)
[13:16:05] <mlitn>	 thanks
[13:41:15] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Have a global diff when some people add answers to a Topic - https://phabricator.wikimedia.org/T110525#1579887 (10Trizek-WMF) 3NEW
[13:42:16] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-1] Beta feature Flow on user talk page (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson)
[13:42:35] <mlitn>	 stephanebisson: Biggest blocker is the incorrect revision content after converting the page. The problem may not even be related to this patch, but should be fixed (or looked in to, at least) before we deploy this.
[13:42:39] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Update MediaWiki-Vagrant for removal of wgFlowOccupyPages and wgFlowOccupyNamespaces - https://phabricator.wikimedia.org/T109553#1579900 (10SBisson) a:3SBisson
[13:42:45] <mlitn>	 I’m looking at it atm
[13:45:33] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Update MediaWiki-Vagrant for removal of wgFlowOccupyPages and wgFlowOccupyNamespaces - https://phabricator.wikimedia.org/T109553#1579906 (10SBisson) I don't know if it is worth doing anything for Talk:Flow_QA for the browser...
[13:59:42] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234272 
[14:04:36] <grrrit-wm>	 (03CR) 10Sbisson: Beta feature Flow on user talk page (0310 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson)
[14:04:42] <grrrit-wm>	 (03PS27) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) 
[14:04:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson)
[14:05:17] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234272 (owner: 10Matthias Mullie)
[14:07:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix typo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234272 (owner: 10Matthias Mullie)
[14:08:53] <grrrit-wm>	 (03PS28) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) 
[14:14:02] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo should warn users who tries to mention more than 20 other users that they won't be notified - https://phabricator.wikimedia.org/T108293#1579998 (10He7d3r) BTW: is this limit documented? Is it hardcoded or configurable?
[14:39:33] <grrrit-wm>	 (03PS29) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) 
[14:51:25] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Make Flow browser tests stable - https://phabricator.wikimedia.org/T109785#1580067 (10SBisson)
[14:57:12] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Design, and 3 others: The icon for expanding and collapsing a Flow topic must be flipped for RTL - https://phabricator.wikimedia.org/T110488#1580095 (10SBisson)
[14:58:35] <grrrit-wm>	 (03CR) 10Matthias Mullie: Beta feature Flow on user talk page (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson)
[15:01:23] <grrrit-wm>	 (03PS1) 10Matthias Mullie: Fix some PHPDoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234285 
[15:09:40] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Fix some PHPDoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234285 (owner: 10Matthias Mullie)
[15:12:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix some PHPDoc [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234285 (owner: 10Matthias Mullie)
[15:14:15] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1580177 (10Pginer-WMF) As the outcome of the last discussion about this design change: - There was agreement that there is a subjective part in the percepti...
[15:18:16] <grrrit-wm>	 (03CR) 10Sbisson: Beta feature Flow on user talk page (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson)
[15:18:33] <grrrit-wm>	 (03PS30) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) 
[15:29:00] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MobileFrontend, 5Patch-For-Review, and 2 others: Writing any posts through the mobile Flow interface is completely impossible - https://phabricator.wikimedia.org/T110485#1580240 (10Jdlrobson) I would highly recommend writing some lightweight browser tests for Flow mob...
[15:29:06] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Tracking, 5WMF-deploy-2015-09-01_(1.26wmf21): Writing any posts through the mobile Flow interface is completely impossible - https://phabricator.wikimedia.org/T110485#1580241 (10Jdlrobson)
[15:43:21] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Make SidebarExpandWidget work in RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234218 (https://phabricator.wikimedia.org/T110488) (owner: 10Catrope)
[15:45:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make SidebarExpandWidget work in RTL [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234218 (https://phabricator.wikimedia.org/T110488) (owner: 10Catrope)
[15:59:46] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkTypeNewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1580358 (10matthiasmullie) > On each wiki, the "information" link should point to that wiki's versio...
[16:55:43] <stephanebisson>	 hey dannyh!
[16:55:49] <dannyh>	 hi!
[16:56:14] <stephanebisson>	 I'm ready to start on something
[16:56:23] <stephanebisson>	 https://phabricator.wikimedia.org/T109814 is a the top of the queue
[16:56:55] <stephanebisson>	 but it's priority is normal vs everything else is high
[16:57:19] <stephanebisson>	 please let me know what you would be most valuable now
[16:57:47] <dannyh>	 ah -- yeah, we moved those into Current in the bug triage yesterday afternoon, and I forgot to move them down the list
[16:57:56] <dannyh>	 thanks for catching & asking
[16:58:57] <dannyh>	 also a couple needs triage tickets that should be in the backlog
[16:59:51] <dannyh>	 you should start with the high tickets -- 110326 is a blocker for other tickets, so that's at the top if you can do it
[17:00:33] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: VE error editing board description - https://phabricator.wikimedia.org/T110393#1580637 (10DannyH)
[17:03:30] <stephanebisson>	 it's part of what matthias is doing with the categories, he really should do it
[17:03:58] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1580660 (10DannyH) p:5Triage>3Unbrea...
[17:05:00] <wikibugs>	 3Collaboration-Team-Current, 10Flow: VE error editing board description - https://phabricator.wikimedia.org/T110393#1580666 (10DannyH)
[17:07:25] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkTypeNewFunctionality, 7user-notice: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1580674 (10Johan)
[17:09:35] <grrrit-wm>	 (03CR) 10Catrope: "Hmph, right. I suppose we could disable the preference update in this case (the user's preferred editor being unsupported)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234219 (https://phabricator.wikimedia.org/T110485) (owner: 10Catrope)
[17:16:18] <RoanKattouw>	 I don't think stephanebisson can do T110326 because it requires shell access
[17:18:34] <stephanebisson>	 RoanKattouw: suppose I wanted to port 1 remaining editor, say topic summary, where would I start?
[17:20:35] <RoanKattouw>	 The one I was going to start with was "edit reply"; since I've already done some thinking and had a false start about that one, do you mind if I talk about that one instead?
[17:20:46] <RoanKattouw>	 *thinking about and had a false start with
[17:22:55] <stephanebisson>	 sure
[17:23:24] <RoanKattouw>	 OK, so at first I thought I was going to be able to do this with the existing ReplyWidget
[17:23:32] <RoanKattouw>	 Unfortunately that one is too specific to creating a new reply
[17:24:04] <RoanKattouw>	 Matt and I have talked abou factoring out some shared code between ReplyWidget/NewTopicWidget/BoardDescriptionWidget into a base class, but regardless of that:
[17:24:29] <RoanKattouw>	 You'd probably want to create a new widget much like ReplyWidget, except it wouldn't have triggerInput
[17:24:47] <RoanKattouw>	 You'd have to change the API request code because different API methods are used for editing vs creating replies
[17:25:56] <stephanebisson>	 how do they attach in the existing system based on handlebar?
[17:26:04] <RoanKattouw>	 In flow-initialize.js
[17:26:37] <RoanKattouw>	 As for fetching the existing content and sticking it into the editor, you can look at how BoardDescriptionWidget does that (if you can look past the other complexities there)
[17:26:52] <RoanKattouw>	 Some of this stuff needs to be better organized
[17:27:19] <RoanKattouw>	 We probably need a base class for things that interact with the editor for example
[17:27:26] <etonkovidova>	 mooeypoo: when you have time - pls check  Hide(topic/post) icon on he.wikipedia.beta.wmflabs.org/wiki/. It's ok to have it flipped? 
[17:27:47] <RoanKattouw>	 It would be nice if you could write an "I just want to edit a thing" subclass by just overriding some API stuff and not much else
[17:27:52] <stephanebisson>	 so what I'll do is an hybrid between board description and reply widget, we'll figure out how to rationalize after...
[17:27:57] <RoanKattouw>	 Yeah sounds good
[17:28:01] <RoanKattouw>	 1) Make it work
[17:28:02] <mooeypoo>	 etonkovidova, which icon and where?
[17:28:06] <RoanKattouw>	 2) Make it nice
[17:28:16] <RoanKattouw>	 (within reason)
[17:28:20] <etonkovidova>	 moo
[17:28:57] <etonkovidova>	 mooeypoo:Hide(topic/post) icon on he.wikipedia.beta.wmflabs.org/wiki/
[17:29:08] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Port remaining editor uses to EditorWidget - https://phabricator.wikimedia.org/T109000#1580785 (10SBisson) a:3SBisson
[17:29:13] <mooeypoo>	 etonkovidova, where is there a flow board on test hewiki?
[17:29:28] <mooeypoo>	 ok found it
[17:29:33] <etonkovidova>	 mooeypoo: yes :)
[17:33:56] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Design, and 4 others: The icon for expanding and collapsing a Flow topic must be flipped for RTL - https://phabricator.wikimedia.org/T110488#1580793 (10Etonkovidova) Checked in betalabs - e.g. http://he.wikipedia.beta.wmflabs.org/wiki/%D7%A...
[17:35:13] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Design, and 4 others: The icon for expanding and collapsing a Flow topic must be flipped for RTL - https://phabricator.wikimedia.org/T110488#1580804 (10Catrope) a:3Catrope
[17:44:00] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1580850 (10Mattflaschen) @MatthiasMullie said he was going to look at this.
[17:44:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1580851 (10Mattflaschen) a:3matthiasmullie
[17:44:24] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1558619 (10Mattflaschen)
[17:50:57] <wikibugs>	 3Collaboration-Team-Current, 10Flow: VE error editing board description - https://phabricator.wikimedia.org/T110393#1580884 (10Catrope) p:5Triage>3Unbreak!
[18:01:54] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Mobile browser tests for Flow - https://phabricator.wikimedia.org/T110562#1580907 (10Mattflaschen) 3NEW
[18:02:24] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Tracking, 5WMF-deploy-2015-09-01_(1.26wmf21): Writing any posts through the mobile Flow interface is completely impossible - https://phabricator.wikimedia.org/T110485#1580917 (10Mattflaschen) Filed as {T110562}.
[18:08:47] <wikibugs>	 6Collaboration-Team-Backlog, 10LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error:  Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1580944 (10Mattflaschen) p:5Low>3Normal
[18:12:25] <matt_flaschen>	 quiddity, I think https://phabricator.wikimedia.org/T110525#1579887 is a dup but I can't find it.
[18:13:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Protection log entries for Flow pages link to broken action=history&offset=... URLs - https://phabricator.wikimedia.org/T109936#1580976 (10Umherirrender) Maybe it is just an problem by a parameter name conflict (Flow is using offset with other values like core?), in that ca...
[18:14:25] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo should warn users who tries to mention more than 50 other users that they won't be notified - https://phabricator.wikimedia.org/T108293#1580982 (10Mattflaschen)
[18:16:39] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Echo should warn users who tries to mention more than 50 other users that they won't be notified - https://phabricator.wikimedia.org/T108293#1580991 (10Mattflaschen) It's documented at https://www.mediawiki.org/wiki/Manual:Echo#Technical_details .  It's hard-coded (now to 5...
[18:18:43] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1581006 (10Mattflaschen)
[18:19:18] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1575034 (10Mattflaschen) When we discussed {T109814} at triage, we thought it would be good to fix that first, since it should be straightforward and then we can just run this once.
[18:19:55] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1559881 (10Mattflaschen)
[18:23:18] <RoanKattouw>	 matt_flaschen: lol your term "domino error" confused me for a second because Parsoid uses a DOM parsing library called domino
[18:25:18] <matt_flaschen>	 RoanKattouw, heh.
[18:25:51] <quiddity>	 matt_flaschen, i think https://phabricator.wikimedia.org/T72513 ?
[18:26:43] <matt_flaschen>	 quiddity, eh, kind of.  I thought there was one about just showing a diff of a topic (pretending it was one revisionable piece of content).
[18:26:46] <quiddity>	 and https://phabricator.wikimedia.org/T62645
[18:26:59] <quiddity>	 ah, yeah...
[18:27:13] <matt_flaschen>	 mooeypoo, so you have you seen you can use description alternatively to descriptionmsg?
[18:29:32] <RoanKattouw>	 matt_flaschen: https://phabricator.wikimedia.org/T110393 was "reported by etonkovidova at [...]" where?
[18:29:36] <mooeypoo>	 matt_flaschen, yeah, I just did.
[18:30:54] <matt_flaschen>	 Okay, ping me if you want to discuss.
[18:32:50] <etonkovidova>	 RoanKattouw: regarding:  https://phabricator.wikimedia.org/T110393 was "reported by etonkovidova -- https://phabricator.wikimedia.org/T110358
[18:32:56] <quiddity>	 matt_flaschen, https://phabricator.wikimedia.org/T96895
[18:33:55] <matt_flaschen>	 quiddity, that might be what I was thinking of.
[18:34:39] <mooeypoo>	 matt_flaschen, according to the documentaion, though, from the examples, "description" takes a wikipage and parses it?
[18:34:54] <mooeypoo>	 Can I put in a jQuery object? 
[18:35:49] <matt_flaschen>	 mooeypoo, no, unless you do special things it's just HTML.  You should check out the docs: https://doc.wikimedia.org/GuidedTour/master/#!/api/mw.guidedTour.TourBuilder-method-step
[18:36:04] <matt_flaschen>	 We documented it as HTML, let me check if it can actually be jQuery.
[18:36:07] <mooeypoo>	 oh, ok, so HTML
[18:36:14] <mooeypoo>	 I can transform my jQuery to html 
[18:36:22] <mooeypoo>	 but it doesn't have to be a wiki page?
[18:37:35] <RoanKattouw>	 etonkovidova: Hmm, I tried those steps but I can't reproduce
[18:38:06] <RoanKattouw>	 I took a board with an existing description, edited description, blanked it, switched to wikitext, typed [[Category:Flow|*]], saved
[18:38:16] <RoanKattouw>	 nothing happened, and when I edited again and switched to VE, nothing bad happened either
[18:38:32] <etonkovidova>	 RoanKattouw: could some recent fixes - yes. I'll check 
[18:38:39] <RoanKattouw>	 OK thanks
[18:38:52] <matt_flaschen>	 mooeypoo, no, it doesn't.  It's just a straight-up HTML description by default.  It goes into .html().
[18:39:13] <matt_flaschen>	 (So it could be jQuery if you really want).
[18:40:04] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Have a global diff when some people add answers to a Topic - https://phabricator.wikimedia.org/T110525#1581106 (10Mattflaschen)
[18:40:24] <mooeypoo>	 matt_flaschen, gotcha
[18:40:31] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow permalinks point to specific topic or post, not snapshot in time of board or topic - https://phabricator.wikimedia.org/T96895#1228646 (10Mattflaschen)
[18:41:40] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1581127 (10Legoktm) >>! In T110306#1577618, @Catrope wrote: > It's suggested we up the limit to something more practic...
[18:41:50] <etonkovidova>	 RoanKattouw: well, at least, https://phabricator.wikimedia.org/T110358 is totally reproducible - just follow two simple steps: 1.Delete a content from a board descirption. 
[18:42:06] <etonkovidova>	 RoanKattouw:2. In wikitext ode - add [[Category:Flow|*]] - click on 'Save description'
[18:45:15] <RoanKattouw>	 Ooh now I have [7fcc3f21] Exception Caught: Row has null primary key:
[18:46:43] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21): Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1581148 (10Mattflaschen) >>! In T110358...
[18:47:08] <matt_flaschen>	 RoanKattouw, that is {T110390}, which I'm hoping will be fixed by Matthias's patch, but I'm not 100% sure.
[18:47:44] <RoanKattouw>	 Right
[18:47:52] <RoanKattouw>	 But I didn't get a VE error though
[18:48:10] <RoanKattouw>	 etonkovidova: So, maybe I'm missing something, so I'll walk through what I'm doing
[18:48:15] <RoanKattouw>	 I go to http://en.wikipedia.beta.wmflabs.org/wiki/Flow_test_talk:Roan2 which is an empty board
[18:48:21] <RoanKattouw>	 I add "Hello world" as the description
[18:48:34] <etonkovidova>	 RoanKattouw: add a template
[18:48:37] <RoanKattouw>	 Ooooh
[18:48:58] <RoanKattouw>	 OK I've changed the description to {{echo|Hi I'm a template}}
[18:49:17] <RoanKattouw>	 Then when in #1 I blank the description, do I do that in VE or in WT?
[18:50:02] <etonkovidova>	 RoanKattouw: let me try that page ...
[18:50:04] <wikibugs>	 3Collaboration-Team-Current, 10Flow: VE error editing board description - https://phabricator.wikimedia.org/T110393#1581155 (10Mattflaschen)
[18:51:06] <mooeypoo>	 matt_flaschen, is there a way to test whether the current page is a flow board in php ?
[18:51:17] <mooeypoo>	 $out->isFlowBoard() or something 
[18:51:22] <etonkovidova>	 RoanKattouw: in wikitext  -delete the template and Save - I just got an error on the page
[18:51:57] <matt_flaschen>	 mooeypoo, $title->getContentModel() === CONTENT_MODEL_FLOW_BOARD
[18:52:07] <matt_flaschen>	 mooeypoo, only tricky thing is that will also be true for Flow topics.
[18:52:11] <RoanKattouw>	 OK yes that also throws [4fa49f5a] Exception Caught: Row has null primary key:
[18:52:24] <RoanKattouw>	 Which Matt and I think might be fixed once Matthias's fix for category stuff is merged
[18:52:29] <mooeypoo>	 matt_flaschen, it's a redundany "just to be safe" condition for the guided tour
[18:52:34] <mooeypoo>	 so that should probably not be a problem
[18:52:36] <RoanKattouw>	 But I still didn't see the VE error
[18:52:39] <RoanKattouw>	 How do I get that one?
[18:52:49] <RoanKattouw>	 nm, got it :D
[18:53:15] <RoanKattouw>	 I Ctrl+Zed to get the wikitext I'd deleted back, then switched back to VE, and it exploded
[18:53:22] <RoanKattouw>	 Seems to be a bug in moveCursorToEnd
[18:54:10] <mooeypoo>	 matt_flaschen, it's not working :\
[18:54:16] <RoanKattouw>	 ooooh
[18:54:23] <RoanKattouw>	 getNearestContentOffset() returns -1 when there is no content offset
[18:54:30] <RoanKattouw>	 and we don't check for that
[18:54:38] <mooeypoo>	 matt_flaschen, I have 'if $title->getContentModel() === CONTENT_MODEL_FLOW_BOARD { load the tour }'
[18:54:42] <mooeypoo>	 and the tour loads in all pages
[18:54:57] <mooeypoo>	 (obviously that if statement will have other conditions too, but just to test, this specific condition seems to not work
[18:55:25] <matt_flaschen>	 mooeypoo, one sec.
[18:55:35] <RoanKattouw>	 I'm helping her debug a little bit
[18:56:32] <matt_flaschen>	 mooeypoo, you have to make sure to X out of the tour, otherwise the internal GuidedTour cookie will keep it alive confusing your testing.
[18:56:47] <mooeypoo>	 oh
[18:56:48] <mooeypoo>	 ha
[18:59:34] <mooeypoo>	 matt_flaschen, that's a really weird behavior
[18:59:57] <mooeypoo>	 So, if I am on the guided tour and I don't quit it, and then I go to main page, I have the tour pop up
[19:00:10] <matt_flaschen>	 mooeypoo, it's by design, so on multi-page tours (e.g. a tour of the old-style edit/preview/save workflow), they will retain their state.
[19:00:13] <mooeypoo>	 I could set up "check we're on a flow board" test in the guided tour definition JS 
[19:00:21] <mooeypoo>	 but then it'll follow us in all flow boards
[19:00:32] <matt_flaschen>	 mooeypoo, I forgot, there's a field for this i think.
[19:00:37] <mooeypoo>	 eh. Too bad it's not an optional thing
[19:01:02] <matt_flaschen>	 mooeypoo, it is.  Add:
[19:01:06] <matt_flaschen>	 isSinglePage: true
[19:01:22] <mooeypoo>	 ooh
[19:01:29] <matt_flaschen>	 to the TourBuilder config object.
[19:02:03] <wikibugs>	 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-T-2015-04-08, 10Echo, 7Schema-change, 7WorkTypeMaintenance: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1581214 (10DannyH)
[19:02:25] <wikibugs>	 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-T-2015-04-08, 10Echo, 7Schema-change, 7WorkTypeNewFunctionality: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1163090 (10Danny...
[19:02:25] <mooeypoo>	 matt_flaschen, hm. It works, but now I'm getting console errors
[19:02:33] <mooeypoo>	 Exception in load-callback in module ext.guidedTour.tour.flowOptIn:
[19:02:44] <mooeypoo>	 IllegalArgumentError: Step "newTopic" not found in the "flowOptIn" tour. 
[19:02:45] <mooeypoo>	 O.o
[19:03:00] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkTypeNewFunctionality: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1581217 (10...
[19:03:09] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 3 others: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#1581218 (10DannyH)
[19:03:21] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkTypeNewFunctionality: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1581219 (10DannyH)
[19:03:29] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Design, and 5 others: The icon for expanding and collapsing a Flow topic must be flipped for RTL - https://phabricator.wikimedia.org/T110488#1581220 (10DannyH)
[19:03:32] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1581221 (10DannyH)
[19:03:37] <wikibugs>	 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkTypeNewFunctionality: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1581222 (10DannyH)
[19:03:50] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeMaintenance: VE error editing board description - https://phabricator.wikimedia.org/T110393#1581223 (10DannyH)
[19:03:55] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1581224 (10DannyH)
[19:04:00] <mooeypoo>	 matt_flaschen, okay, I think that was unrelated. I just hard-refreshed again, and no more errors, but it's not working. It still follows me around :\
[19:04:04] <wikibugs>	 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Exception Caught: Row has null primary key - https://phabricator.wikimedia.org/T110390#1581226 (10DannyH)
[19:04:09] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1581229 (10DannyH)
[19:04:18] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkTypeNewFunctionality: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1581230 (10DannyH)
[19:04:25] <matt_flaschen>	 mooeypoo, X out one more time, you probably already have the cookie.
[19:05:04] <mooeypoo>	 matt_flaschen, I did, and then cleared cache to be safe
[19:05:07] <mooeypoo>	 still not working
[19:05:19] <mooeypoo>	 Let me try this now through another browser
[19:06:05] <mooeypoo>	 matt_flaschen, yeah I just tried it with firefox which I haven't used on this before, and it's still not working :\
[19:06:11] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Move "Mark as resolved" up in the Flow dropdown menu - https://phabricator.wikimedia.org/T110083#1581234 (10DannyH)
[19:06:19] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks, 7WorkTypeNewFunctionality: Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks - https://phabricator.wikimedia.org/T109984#1581236 (10DannyH)
[19:06:28] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7WorkTypeNewFunctionality: Warnings on data loss are not applied in Flow when VE or wikitext is used - https://phabricator.wikimedia.org/T97292#1581237 (10DannyH)
[19:06:33] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Null edits should not be saved in posts, topic titles, summaries - https://phabricator.wikimedia.org/T60975#1581238 (10DannyH)
[19:06:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Take out "This description has been modified" line in side rail legal text - https://phabricator.wikimedia.org/T110082#1581239 (10DannyH)
[19:06:47] <wikibugs>	 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#1581241 (10DannyH)
[19:07:05] <wikibugs>	 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 5Patch-For-Review, 7WorkTypeMaintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#1466223 (10DannyH)
[19:07:07] <mooeypoo>	 matt_flaschen, maybe I'm adding it in the wrong place? 
[19:07:08] <mooeypoo>	 		tour = new gt.TourBuilder( {
[19:07:08] <mooeypoo>	 			name: 'flowOptIn',
[19:07:08] <mooeypoo>	 			isSinglePage: true
[19:07:08] <mooeypoo>	 		} ),
[19:07:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Protection log entries for Flow pages link to broken action=history&offset=... URLs - https://phabricator.wikimedia.org/T109936#1581243 (10DannyH)
[19:07:21] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Email notification: The  new renamed topic title is displayed in place for the previos title - https://phabricator.wikimedia.org/T109784#1581244 (10DannyH)
[19:07:26] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7WorkTypeNewFunctionality: "You have new messages" is highlighted in orange whenever you view your talk page - https://phabricator.wikimedia.org/T109997#1581248 (10DannyH)
[19:07:36] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Editing posts: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T110093#1581250 (10DannyH)
[19:07:42] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: flow-menu-js-drop menu options are cut off for topics at the bottom of the page - https://phabricator.wikimedia.org/T107235#1581251 (10DannyH)
[19:07:49] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Tweak LQT->Flow import code to support a mode where LQT is enabled by default - https://phabricator.wikimedia.org/T107634#1581252 (10DannyH)
[19:07:55] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: In watchlists, Flow entries should bold the Topic Title, not the Board name - https://phabricator.wikimedia.org/T109347#1581253 (10DannyH)
[19:07:59] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Deleted topics should not appear in RecentChanges - https://phabricator.wikimedia.org/T108136#1581255 (10DannyH)
[19:08:04] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: EnableFlow automatically moves to /Archive Number -- should it also take into account /Archive/Number? - https://phabricator.wikimedia.org/T107615#1581256 (10DannyH)
[19:08:08] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Cancel keeps temporary text in editors - https://phabricator.wikimedia.org/T109365#1581262 (10DannyH)
[19:08:13] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Remove "Move" from Flow board dropdown menu if there's no possible destination the user could move to - https://phabricator.wikimedia.org/T107109#1581263 (10DannyH)
[19:08:19] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Check that deleting boards turns topic links red - https://phabricator.wikimedia.org/T108135#1581264 (10DannyH)
[19:08:20] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: After clicking on 'Edit description',  Board  description is displayed empty while  its content loads - https://phabricator.wikimedia.org/T109493#1581266 (10DannyH)
[19:08:29] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Entire Flow page is reloaded when using browser back/forward navigation - https://phabricator.wikimedia.org/T109218#1581268 (10DannyH)
[19:08:39] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Mobile, 7WorkTypeNewFunctionality: Flow topics in mobile watchlist should be human readable - https://phabricator.wikimedia.org/T98724#1581273 (10DannyH)
[19:08:44] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Only give the "You have entered text" warning if I've actually changed the text - https://phabricator.wikimedia.org/T102979#1581275 (10DannyH)
[19:08:48] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Enhance Flow's resolved-topic entry in RC/watchlist, with Enhanced Recent Changes - https://phabricator.wikimedia.org/T109661#1581276 (10DannyH)
[19:09:00] <wikibugs>	 6Collaboration-Team-Backlog, 10MediaWiki-Recent-changes, 10MediaWiki-Vagrant, 7WorkTypeMaintenance: Make RC feeds testable in MWV - https://phabricator.wikimedia.org/T109548#1581278 (10DannyH)
[19:09:08] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Parsoid-Nowiki, 7WorkTypeNewFunctionality: Flow puts nowiki around a mailto: link with spaces in query string - https://phabricator.wikimedia.org/T109806#1581280 (10DannyH)
[19:09:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Change the selection of buttons when using tab key, in order to unify the workflow - https://phabricator.wikimedia.org/T105758#1581282 (10DannyH)
[19:09:16] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Flow should make sure all non-logged, non-caught exceptions are logged - https://phabricator.wikimedia.org/T103394#1581283 (10DannyH)
[19:09:22] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Tech News Delivery to Flow page fails without error - https://phabricator.wikimedia.org/T101177#1581284 (10DannyH)
[19:09:25] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Editing pencil for Flow descriptions is always blue - https://phabricator.wikimedia.org/T110309#1581285 (10DannyH)
[19:09:28] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Reconsider Flow's use of .mw-ui-hovericon (dropdown menu items that gain progressive/constructive/destructive styling on hover) - https://phabricator.wikimedia.org/T110051#1581287 (10DannyH)
[19:09:33] <matt_flaschen>	 mooeypoo, no, that looks right.  Looking.
[19:09:33] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Remove tooltips from dropdown menu in post and topic header - https://phabricator.wikimedia.org/T101198#1581289 (10DannyH)
[19:09:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1581291 (10DannyH)
[19:09:41] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Flow API error messages should be i18n'ed - https://phabricator.wikimedia.org/T108117#1581293 (10DannyH)
[19:09:46] <grrrit-wm>	 (03PS17) 10Mooeypoo: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) 
[19:09:54] <mooeypoo>	 matt_flaschen, can you take a look if I'm doing it wrong? ^^
[19:10:00] <mooeypoo>	 I just pushed the new version.
[19:10:17] <matt_flaschen>	 Yep
[19:10:29] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo)
[19:10:34] <grrrit-wm>	 (03PS1) 10Catrope: VisualEditorWidget: Guard against setting selection to -1 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234343 (https://phabricator.wikimedia.org/T110393) 
[19:10:50] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Make Flow browser tests stable - https://phabricator.wikimedia.org/T109785#1581298 (10DannyH) p:5High>3Normal
[19:10:50] <mooeypoo>	 matt_flaschen, wait, i'm stupid... wow... I was about to describe how I tested it so you can test, and then realized the issue
[19:10:57] <mooeypoo>	 actually, no
[19:11:02] <mooeypoo>	 that shouldn't happen anyways
[19:11:14] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1581300 (10DannyH) p:5High>3Normal
[19:11:28] <matt_flaschen>	 mooeypoo, oh, I know what the problem is. :(
[19:11:47] <mooeypoo>	 oh?
[19:11:52] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkTypeNewFunctionality: Clicking 'edit' should always refetch from the server - https://phabricator.wikimedia.org/T109660#1581304 (10DannyH) p:5High>3Normal
[19:11:58] <matt_flaschen>	 isSinglePage assumes that you'll be launching it from JavaScript.  It doesn't do anything to delete the cookie, it just doesn't set the cookie.  But you're already setting it from the server.
[19:12:15] <mooeypoo>	 ha
[19:12:16] <mooeypoo>	 hm
[19:12:31] <mooeypoo>	 Okay. Hm. How can we work around this?
[19:12:56] <mooeypoo>	 I could reproduce the entire php condition in the js and delete the cookie if the condition is falsey
[19:13:04] <mooeypoo>	 but that's... hacky and probably unreliable.
[19:13:06] <RoanKattouw>	 Maybe export a setting to JS from PHP that tells JS to enable the tour?
[19:13:20] <RoanKattouw>	 Using makeGlobalVariablesScript or whatever that hook is called now
[19:13:25] <matt_flaschen>	 mooeypoo, I think I can just delete the cookie (if it's single page) the same place it normally updates it (or doesn't for isSinglePage).  Can't think how that would break existing tours.  They shouldn't be relying on cookies if they're single page.
[19:14:39] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Null edits should not be saved in posts, topic titles, summaries - https://phabricator.wikimedia.org/T60975#1581314 (10DannyH)
[19:15:05] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Take out "This description has been modified" line in side rail legal text - https://phabricator.wikimedia.org/T110082#1581316 (10DannyH)
[19:15:37] <mooeypoo>	 matt_flaschen, RoanKattouw either sound good to me. I suggested the idea of having a "config" option that goes on and off instead of the Flow cookie, but it is the same if guided tour can handle it
[19:17:16] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Email notification: The  new renamed topic title is displayed in place for the previos title - https://phabricator.wikimedia.org/T109784#1581322 (10DannyH) p:5High>3Normal
[19:17:33] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7WorkTypeNewFunctionality: "You have new messages" is highlighted in orange whenever you view your talk page - https://phabricator.wikimedia.org/T109997#1581327 (10DannyH) p:5High>3Normal
[19:18:41] <grrrit-wm>	 (03PS1) 10Catrope: VisualEditorWidget: Use selectLastContentOffset() from VE directly [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234347 
[19:18:59] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeMaintenance: VE error editing board description - https://phabricator.wikimedia.org/T110393#1581334 (10Catrope) a:3Catrope
[19:19:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkTypeNewFunctionality: Only give the "You have entered text" warning if I've actually changed the text - https://phabricator.wikimedia.org/T102979#1581336 (10DannyH) p:5High>3Normal
[19:20:39] <wikibugs>	 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Design, and 5 others: The icon for expanding and collapsing a Flow topic must be flipped for RTL - https://phabricator.wikimedia.org/T110488#1581340 (10DannyH) 5Open>3Resolved
[19:20:56] <matt_flaschen>	 mooeypoo, did the GT fix, testing now.
[19:22:01] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1581342 (10DannyH) 5Open>3Resolved Sadly, this is expected behavior. I was hoping to do more work on notifications, watchlists and emails, but it looks l...
[19:33:51] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10WMF-Server-Backports, 5Patch-For-Review, and 3 others: addurl CAPTCHA broken (HTML is rendered as text and CAPTCHA always fails you even if you fill in the form right) - https://phabricator.wikimedia.org/T109554#1581380 (10Etonkovidova) Checked in betalabs.
[19:41:58] <matt_flaschen>	 mooeypoo, tested and uploaded: https://gerrit.wikimedia.org/r/#/c/234402/
[19:42:21] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] Create a guided tour for first-time users (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo)
[19:58:10] <adisha>	 Hey I want to work on the Bug: https://phabricator.wikimedia.org/T72472 
[19:58:30] <adisha>	 https://phabricator.wikimedia.org/T72472 I have install Mediawiki and Flow extension
[19:58:46] <adisha>	 How should I start?
[19:58:53] <adisha>	 Can anyone help
[20:01:12] <RoanKattouw>	 adisha: You can use ?uselang=qqx to find the name of the i18n message that's being used
[20:01:18] <RoanKattouw>	 And then you can find that message in en.json and change it
[20:01:45] <adisha>	 I only have to change the message
[20:01:47] <adisha>	 ???
[20:02:13] <matt_flaschen>	 No, you will also have to plug in the topic title.  Also, please check with dannyh first.
[20:02:22] <RoanKattouw>	 Well, if you want to add the topic title as well (the second suggestion), then you need to change the code that uses the message
[20:02:28] <RoanKattouw>	 But otherwise you'd only have to change the message
[20:02:43] <matt_flaschen>	 RoanKattouw, you're right, I misread it.  I thought the first one was the old one.
[20:03:19] <adisha>	 So Before working on it Can I assign it to myself?
[20:03:27] <matt_flaschen>	 Yes
[20:04:02] <adisha>	 Ok
[20:04:49] <adisha>	 On ?uselang=qqx the message is "Revision history of" so I have to use same message ?
[20:05:03] <RoanKattouw>	 Ahm, that doesn't sound right
[20:05:05] <RoanKattouw>	 Hold on, let me check
[20:05:14] <matt_flaschen>	 dannyh, does "History of Topic on Talk:Flow" sound better than the current "Topic on Talk:Flow" at https://www.mediawiki.org/w/index.php?title=Topic:Snpnyr7612bg46wp&action=history ?  adisha wants to work on it.
[20:05:16] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1581520 (10Adishaporwal) a:3Adishaporwal
[20:05:45] <RoanKattouw>	 adisha: So we're talking about pages like https://www.mediawiki.org/w/index.php?title=Topic:Snpnyr7612bg46wp&action=history , specifically the header that says "Topic on Talk:Flow", right
[20:06:01] <adisha>	 Yes
[20:06:10] <RoanKattouw>	 adisha: If I add &uselang=qqx to that URL, I get https://www.mediawiki.org/w/index.php?title=Topic:Snpnyr7612bg46wp&action=history&uselang=qqx which shows (flow-topic-first-heading: Talk:Flow) in the header
[20:06:16] <RoanKattouw>	 So the name of the message is flow-topic-first-heading
[20:06:34] <RoanKattouw>	 and the first parameter ($1) is Talk:Flow, the name of the page
[20:06:40] <RoanKattouw>	 You should be able to find the message name in en.json
[20:06:41] <matt_flaschen>	 Which means you need to split it, because it's the same at https://www.mediawiki.org/wiki/Topic:Snpnyr7612bg46wp?uselang=qqx .
[20:06:49] <RoanKattouw>	 Oh, ugh
[20:06:52] <RoanKattouw>	 Right :S
[20:08:27] <adisha>	 In every page a line comes '< Talk:Flow' for eg: https://www.mediawiki.org/wiki/Topic:Snpnyr7612bg46wp?uselang=qqx
[20:09:05] <adisha>	 I have to remove that too??
[20:09:34] <RoanKattouw>	 No that one is fine
[20:10:32] <adisha>	 But if I don't use '?uselang=qqx' It displays 'Topic on Talk:Flow'. Link 'https://www.mediawiki.org/wiki/Topic:Snpnyr7612bg46wp'
[20:10:51] <matt_flaschen>	 adisha, yes, it needs to stay the same on that page.
[20:11:05] <matt_flaschen>	 Which is why the task requires adding a message.
[20:11:23] <grrrit-wm>	 (03PS18) 10Mooeypoo: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) 
[20:11:55] <adisha>	 Now I am bit confused with what shat should I do? :)
[20:12:30] <RoanKattouw>	 So, right now the same i18n message is used for the heading when viewing a topic, and the heading when viewing a topic's history
[20:12:47] <RoanKattouw>	 You want to change the heading for the topic history, but you don't want to change the heading for the regular topic view
[20:12:53] <RoanKattouw>	 So you need to split the message
[20:12:59] <RoanKattouw>	 i.e. introduce a new message for the topic history header
[20:13:15] <RoanKattouw>	 so that you can make it different from the other one
[20:15:16] <adisha>	 Ok thanks..:)
[20:15:47] <stephanebisson>	 RoanKattouw: do you think I should create a widget to edit a post or a widget to display a post, that is also editable?
[20:16:11] <matt_flaschen>	 Anyone else got npm permission errors from the commit hooks?
[20:16:13] <matt_flaschen>	 E.g.:
[20:16:24] <matt_flaschen>	 "npm ERR! Please try running this command again as root/Administrator." (and some other stuff)
[20:16:26] <matt_flaschen>	 ?
[20:16:57] <matt_flaschen>	 Seems to work if I run npm install from inside the VM.
[20:19:08] <RoanKattouw>	 stephanebisson: I personally was trying to avoid going down the PostWidget rabbit hole, if that's what you mean
[20:19:24] <RoanKattouw>	 I suppose you could model it after BoardDescriptionWidget and make rendering part of it
[20:19:34] <RoanKattouw>	 That... might be better actually
[20:19:38] <RoanKattouw>	 Since we have to rerender on save
[20:20:09] <RoanKattouw>	 So yeah I think a widget that renders a post that is also editable (and rerenders on edit) would be preferable
[20:20:09] <stephanebisson>	 it helps with this part but what about initial rendering?
[20:20:21] <RoanKattouw>	 If you can pull that off without things getting crazy complicated
[20:20:35] <stephanebisson>	 I'm still not clear on our js/no-js strategy
[20:20:39] <RoanKattouw>	 stephanebisson: Did you look at how BoardDescriptionWidget does it?
[20:20:52] <stephanebisson>	 yes, I understand how it works
[20:23:51] <RoanKattouw>	 stephanebisson: What is your question about initial rendering then?
[20:24:14] <stephanebisson>	 would we really want to replace all the post html coming from the server with the widgets?
[20:25:05] <stephanebisson>	 this was an open question a while back, I don't know what's the current architectural vision
[20:25:17] <RoanKattouw>	 Hmm
[20:25:20] <RoanKattouw>	 I'm not completely sure
[20:25:29] <RoanKattouw>	 Even if we did do that, we would want to reuse the HTML of the actual post rendering
[20:25:58] <RoanKattouw>	 I think that completely replacing each post with a widget on init is a bit overkill for now
[20:26:17] <stephanebisson>	 I agree
[20:26:24] <RoanKattouw>	 It is what we do with BoardDescriptionWidget, but there's only one of those
[20:26:30] <RoanKattouw>	 There could easily be 100 posts on a page
[20:26:40] <RoanKattouw>	 And you'd have to hook into infinite scroll
[20:27:19] <stephanebisson>	 we can attach to the current dom instead of re-creating it, but we need the initial markup and the one we generate to be very similar
[20:27:33] <stephanebisson>	 so we'd have to maintain 2 implementations
[20:27:36] <RoanKattouw>	 So I think a more sustainable solution for now would be for flow-initialize to register a click handler on edit buttons (using the container+selector thing so newly loaded posts are automatically listened to as well) and do the swap when edit is clicked
[20:27:41] <RoanKattouw>	 Well, sustainable isn't the right word
[20:27:48] <RoanKattouw>	 s/sustainable/less crazy/
[20:28:08] <RoanKattouw>	 Yeah well, that also depends on what the scope of this post widget is
[20:28:28] <RoanKattouw>	 If it encompasses all the menu buttons and the watch star and stuff, I think it'd get way too complicated, that's the rabbit hole I was afraid of
[20:28:52] <stephanebisson>	 yeah
[20:29:04] <RoanKattouw>	 But if it's a very small scope, just rendering either the current content or an editor, then it shouldn't be hard to make them look consistent
[20:29:23] <RoanKattouw>	 In the case of BoardDescriptionWidget, when it's not in edit mode it does nothing special apart from showing an edit button
[20:29:44] <RoanKattouw>	 It's just a <div> containing the post content rendered by the server
[20:30:34] <stephanebisson>	 so, right now, when we build widgets, does it allow us to get rid of the handlebar templates?
[20:31:24] <RoanKattouw>	 When all the editors are converted, we can get rid of some of the editor-related handlebars stuff
[20:31:49] <RoanKattouw>	 flow_reply_form.partial.handlebars for example
[20:31:56] <stephanebisson>	 for board description, for example, do we still need the templates now that we have a widget?
[20:32:09] <RoanKattouw>	 Ooh, for board description we may be able to kill some things
[20:32:14] <RoanKattouw>	 Because it's also a widget on the PHP side now
[20:32:20] <RoanKattouw>	 Actually, I think that killing has already happened
[20:32:44] <RoanKattouw>	 There's a dummy template somewhere that just uses {{oouify}}
[20:33:06] <RoanKattouw>	 flow_header_detail.partial.handlebars
[20:33:25] <RoanKattouw>	 Unfortunately flow_header_detail_oldsystem.partial.handlebars is still kicking around :(
[20:33:29] <RoanKattouw>	 let me refresh my memory as to why
[20:33:31] <stephanebisson>	 so that's the architecture: a widget on the client and one on the server and they have to stay roughly in sync, right?
[20:33:56] <RoanKattouw>	 Yeah
[20:34:05] <RoanKattouw>	 With ideally the server-side one being quite simple
[20:35:41] <matt_flaschen>	 If PostWidget was implemented fully in OO UI PHP, it probably wouldn't be that simple even though it's just no-JS.  Agree that shouldn't be done now.
[20:36:05] <RoanKattouw>	 Yeah PostWidget would be one of the most complex no-JS things
[20:37:04] <stephanebisson>	 ok, I'll do the simplest thing for now
[20:41:19] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1581735 (10Mattflaschen)
[20:46:22] <matt_flaschen>	 Can someone review https://gerrit.wikimedia.org/r/#/c/233657/ when you get a chance?  It makes MediaWiki-Vagrant actually use FancyCaptcha (the one we use in prod) as intended.
[20:47:49] <grrrit-wm>	 (03PS1) 10Mattflaschen: Initial refactoring to create ContentWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234423 (https://phabricator.wikimedia.org/T109000) 
[20:52:46] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Change title (document.title) when the user has an editor open - https://phabricator.wikimedia.org/T107356#1581796 (10Quiddity) Copying my comments from the merged task:  As a user who has many browser tabs/windows open, I want to find the one where I'm currently typing a r...
[20:55:02] <quiddity>	 matt_flaschen, also, I think your https://phabricator.wikimedia.org/T94449 is a duplicate of https://phabricator.wikimedia.org/T96895  ?
[20:56:11] <matt_flaschen>	 quiddity, no.  T96895 is about a snapshot of the whole board or whole topic.
[20:56:47] <matt_flaschen>	 T94449 is about permalink technically referring to a snapshot in time and a specific post, where as post link links to the post (which could change).
[20:57:15] <matt_flaschen>	 They're related, but even if https://phabricator.wikimedia.org/T96895 was implemented, there would still be use cases for both permalinks to posts and post links.
[20:57:59] <quiddity>	 ah, right.
[21:04:24] <mooeypoo>	 Ah! I finally realized what bugged me since this morning about the tick mark. It's backwards. But not RTL/LTR wise, Left-handed wise. 
[21:04:53] <mooeypoo>	 Which basically means I'm not only backwards because I RTL, I am also backwards because I'm left handed.
[21:04:55] <mooeypoo>	 Thanks, world.
[21:19:34] <James_F>	 mooeypoo: Are you backwards-backwards?
[21:20:37] <quiddity>	 https://www.google.com/search?q=pushmi-pullyu&tbm=isch
[21:28:04] <mooeypoo>	 James_F, I think I am
[21:34:28] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Flow, 7Accessibility, 7Easy: Fix accessibility for the new grey quiet Notification numbers - https://phabricator.wikimedia.org/T98526#1582027 (10Quiddity)
[21:40:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Enable the checkbox to leave a redirect behind when moving a Flow Board - https://phabricator.wikimedia.org/T96631#1582050 (10Quiddity)
[21:40:13] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Add redirect capability to Flow - https://phabricator.wikimedia.org/T102300#1361833 (10Quiddity)
[21:50:47] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Flow: "You have new messages" stuck after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1582079 (10Quiddity) The requested solution for the original bug here, conflicts with the request in {T110048}.  The latter requests that we make it imp...
[21:51:49] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Wikidata: Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#1582085 (10Ainali) 3NEW
[21:54:26] <wikibugs>	 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-T-2015-04-08, 10Echo, 7Schema-change, 7WorkTypeNewFunctionality: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1582098 (10Etonk...
[22:06:09] <grrrit-wm>	 (03PS1) 10Catrope: Use wikitext icon from VE for the VE->WT switch tool [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234435 (https://phabricator.wikimedia.org/T101316) 
[22:06:58] <wikibugs>	 6Collaboration-Team-Backlog, 5Patch-For-Review: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1582144 (10Catrope) >>! In T101316#1582137, @gerritbot wrote: > Change 234435 had a related patch set uploaded (by Catrope): > Use wikitext icon from VE for the VE->WT switch...
[22:16:03] <dannyh>	 matt_flaschen RoanKattouw_away going by the model used on other pages, it should be "Topic on Talk:Flow: Revision history" 
[22:16:51] <matt_flaschen>	 dannyh, good point, I'll add that to the task.
[22:18:26] <dannyh>	 matt_flaschen cool
[22:20:31] <matt_flaschen>	 dannyh, actually, that is an override on enwiki (and maybe the old standard message).  The current standard message is "Revision history of \"$1\", like at https://www.mediawiki.org/wiki/Collaboration/Team?action=history
[22:23:16] <matt_flaschen>	 dannyh, so I'm not sure what to write:  Bug is https://phabricator.wikimedia.org/T72472
[22:27:58] <dannyh>	 matt_flaschen "Revision history of Topic on Talk:Flow" is fine too
[22:28:37] <matt_flaschen>	 That sounds good, will post.
[22:31:23] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1582254 (10Mattflaschen) @DannyH suggested (analogous to the message used for regular pages):  ``` Revision history of Topic on $1 ```...
[22:33:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Add categories to the sidebar (0313 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo)
[22:33:31] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Documentation, 7I18n: In Flow, "Moderation" and its derivatives need better documentation - https://phabricator.wikimedia.org/T94345#1582261 (10Quiddity)
[22:40:36] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Show diff links when showing old version of header (or diff version of header), like normal pages - https://phabricator.wikimedia.org/T76719#1582274 (10Quiddity)
[22:48:07] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Confusing error message in Flow when there is a conflict of comments being posted (needs to be reproduced) - https://phabricator.wikimedia.org/T78718#1582304 (10Quiddity) Just tried, and cannot reproduce. I used to account to: * create a new topic (1 each) at https://www.me...
[22:55:50] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Lock logging is completely unformatted - https://phabricator.wikimedia.org/T90319#1582332 (10Quiddity)
[22:58:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Flow: "You have new messages" stuck after all messages are 'Mark as read' - https://phabricator.wikimedia.org/T106033#1582336 (10Mattflaschen) >  The latter requests that we make it impossible to "ignore/dismiss" a usertalkpage message without even looking at it.  I don...
[23:00:37] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Confusing error message in Flow when there is a conflict of comments being posted (needs to be reproduced) - https://phabricator.wikimedia.org/T78718#1582341 (10Qgil) Reading the original description, I think the test needs to be done by two users using this sequence:  # So...
[23:09:13] <wikibugs>	 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkTypeNewFunctionality: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1582382 (10Mattflaschen) 5Open>3Resolved
[23:09:21] <wikibugs>	 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review, 7WorkTypeNewFunctionality: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1559924 (10Mattflaschen) 5Resolved>3Open
[23:11:18] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Pressing Ctrl+1 in Flow VE causes exception - https://phabricator.wikimedia.org/T103418#1582391 (10Quiddity)
[23:11:20] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow's keyboard-shortcuts / access-keys / hotkeys (tracking) - https://phabricator.wikimedia.org/T108739#1582390 (10Quiddity)
[23:24:55] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Rich-pasted link not displaying correctly in Flow VisualEditor - https://phabricator.wikimedia.org/T101045#1582460 (10Quiddity) Possibly related to {T101376} ?
[23:25:39] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Confusing error message in Flow when there is a conflict of comments being posted (needs to be reproduced) - https://phabricator.wikimedia.org/T78718#1582464 (10KRLS) Last months, there were several conflict editions in flows pages of ca.wiki and anybody say about this type...
[23:30:11] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow doesn't respect user interface language direction - https://phabricator.wikimedia.org/T106726#1582473 (10Quiddity)