[01:01:13] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/230016/ [01:02:19] legoktm: Apparently I should ask you to merge https://gerrit.wikimedia.org/r/#/c/230016/ :-) [01:32:49] Our SWAT never gone done. I pinged greg about it. [01:36:18] I think he's out to dinner with Terry and a number of other visiting management people [01:36:30] (There's an engineering management "offsite" tomorrow and Thursday) [01:36:44] "offsite" being in scare quotes because, to quote Terry, "this offsite is on-site" [01:37:20] Which Terry? Anyway, should I reschedule it for tomorrow, or just do it? [01:37:35] ^ RoanKattouw [01:37:42] Gilbey [01:37:45] Meh just do it [01:39:14] (03CR) 10Mattflaschen: [C: 032] Don't open two editors when clicking a nested reply link [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233650 (https://phabricator.wikimedia.org/T109748) (owner: 10Mattflaschen) [01:41:29] (03Merged) 10jenkins-bot: Don't open two editors when clicking a nested reply link [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233650 (https://phabricator.wikimedia.org/T109748) (owner: 10Mattflaschen) [02:04:24] (03CR) 10Catrope: Split alerts and messages in Echo (0365 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [02:04:38] (03CR) 10Catrope: [C: 04-1] "Comments on PS30" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [02:05:58] Deploy is complete, testing looks good. [03:23:46] James_F|Away: that extension scares me [03:55:00] 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review: Flow extension is disabled in fawikibooks - https://phabricator.wikimedia.org/T109816#1574053 (10Mattflaschen) [03:55:18] 3Collaboration-Team-Current, 10Wikimedia-Extension-setup, 5Patch-For-Review: Re-enable Flow on fawikibooks - https://phabricator.wikimedia.org/T109816#1574054 (10Mattflaschen) [05:41:44] 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1574161 (10Florian) It seems to work now (I got some notifications about new topics on mediawiki.org). Thanks for the fast fix :) [06:25:51] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update Echo to use AuthManager - https://phabricator.wikimedia.org/T110285#1574283 (10Tgr) 3NEW [06:28:11] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update Echo to use AuthManager - https://phabricator.wikimedia.org/T110285#1574294 (10Tgr) Calls `$wgAuth->allowPropChange( 'emailaddress' )`. [06:28:39] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update Echo to use AuthManager - https://phabricator.wikimedia.org/T110285#1574297 (10Tgr) [06:29:18] 6Collaboration-Team-Backlog, 10MoodBar, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update MoodBar to use AuthManager - https://phabricator.wikimedia.org/T110286#1574300 (10Tgr) 3NEW [08:09:18] 6Collaboration-Team-Backlog: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1574511 (10Pginer-WMF) My main concern is with the alignment of prominence with the frequency of use. I'm assuming that most of the time replies in the discussions Flow supports are based on plain... [08:52:55] 6Collaboration-Team-Backlog, 10Echo: Important batches of mentions are not always distributed - https://phabricator.wikimedia.org/T110306#1574571 (10Trizek-WMF) 3NEW [08:55:09] 6Collaboration-Team-Backlog, 10Echo: Provide feedback when you mention an other user - https://phabricator.wikimedia.org/T110308#1574589 (10Trizek-WMF) 3NEW [09:18:47] 6Collaboration-Team-Backlog, 10Flow: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1574637 (10Pginer-WMF) Using a big font size can help with scalability (which is useful in long boards especially when search and filtering is not available) but does not work t... [09:47:36] 6Collaboration-Team-Backlog, 10Flow: Board description is not sufficiently visually distinguished from the buttons that let you edit it - https://phabricator.wikimedia.org/T102014#1574662 (10Pginer-WMF) One of the tricky aspects of this is that content in descriptions can vary significantly: they can be empty,... [09:51:59] 6Collaboration-Team-Backlog, 10Flow: Editing pencil for Flow descriptions is always blue - https://phabricator.wikimedia.org/T110309#1574664 (10Pginer-WMF) 3NEW [09:56:35] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow, 10pywikibot-core, 3Google-Summer-of-Code-2015: Implement Flow support in Pywikibot - https://phabricator.wikimedia.org/T67119#1574692 (10jayvdb) [09:57:01] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow, 10pywikibot-core, 3Google-Summer-of-Code-2015: Implement Flow support in Pywikibot - https://phabricator.wikimedia.org/T67119#1094821 (10jayvdb) [09:58:52] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow, 10pywikibot-core, 3Google-Summer-of-Code-2015: Implement Flow support in Pywikibot - https://phabricator.wikimedia.org/T67119#1574702 (10jayvdb) While there is still a lot of Flow functionality not yet supported, the foundations are in place and soli... [09:59:01] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow, 10pywikibot-core, 7Tracking: Pywikibot and Flow (tracking) - https://phabricator.wikimedia.org/T110042#1574704 (10jayvdb) [09:59:03] 6Collaboration-Team-Backlog, 10Flow, 10Pywikibot-Flow, 10pywikibot-core, 3Google-Summer-of-Code-2015: Implement Flow support in Pywikibot - https://phabricator.wikimedia.org/T67119#1574703 (10jayvdb) 5Open>3Resolved [10:25:07] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7Wikimedia-log-errors: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#1574736 (10jcrespo) I think the issue I saw is related to this commit, please tell me otherwise: I've seen... [11:16:32] (03CR) 10Sbisson: "You did everything right but this patch depends on https://gerrit.wikimedia.org/r/#/c/233066/ that still isn't merged." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [12:01:34] (03PS3) 10Matthias Mullie: Fix removal/addition of categorylinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233432 (https://phabricator.wikimedia.org/T94569) [12:03:55] (03CR) 10jenkins-bot: [V: 04-1] Fix removal/addition of categorylinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233432 (https://phabricator.wikimedia.org/T94569) (owner: 10Matthias Mullie) [12:08:00] (03PS4) 10Matthias Mullie: Fix removal/addition of categorylinks [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233432 (https://phabricator.wikimedia.org/T94569) [12:13:17] 3Collaboration-Team-Current, 10Flow: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1575034 (10matthiasmullie) 3NEW [12:25:34] (03PS1) 10Sbisson: Browser tests: various fixes for firefox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233944 [12:28:19] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: various fixes for firefox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233944 (owner: 10Sbisson) [12:29:55] (03PS2) 10Sbisson: Browser tests: various fixes for firefox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233944 [12:32:43] (03CR) 10Matthias Mullie: [C: 032] Use placeholder HTML rather than rendering the board in getParserOutput [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) (owner: 10Mattflaschen) [12:35:02] (03Merged) 10jenkins-bot: Use placeholder HTML rather than rendering the board in getParserOutput [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) (owner: 10Mattflaschen) [12:36:04] stephanebisson: I just saw “You did everything right but this patch depends on https://gerrit.wikimedia.org/r/#/c/233066/ that still isn't merged.” [12:36:29] If it depends on another patch, you can just check that one out (git review -d id), cherry-pick yours on top of it, then git-review. Gerrit will then recognize the dependency. Checking out the child will then also checkout the dependency. [12:37:59] mlitn: right [12:38:15] I'll be less lazy next time ;) [12:38:48] mlitn: any idea what is causing those errors: https://phabricator.wikimedia.org/P1927 ? [12:39:59] yeah [12:40:40] this one [12:40:41] https://gerrit.wikimedia.org/r/#/c/136280/ [12:40:56] it has had different versions of the db updates over it’s very long history [12:41:07] you probably ran one of them at some point :p [12:41:26] you should be able to just run https://gerrit.wikimedia.org/r/#/c/136280/20/db_patches/patch-reference_wiki.sql manually, I believe [12:41:43] and ignore any SQL failure (because you may already have the columns from earlier) [12:42:28] (or follow the deployment plan in commit msg, but it’s probably overkill for local machine) [12:44:33] mlitn: I'm doing a full git-update and provision (which does update.php) every morning, I never run individual scripts [12:45:39] I tried patch-reference_wiki.sql just now [12:45:51] it says: Error Code: 1060. Duplicate column name 'ref_src_wiki' [12:46:53] is there anything I can test to find out if my db is ok? [12:46:54] ooh [12:47:34] (03CR) 10Matthias Mullie: Segregate Reference objects by source wiki. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [12:47:52] see ^ [12:47:59] there was a typo in that file [12:48:23] so update.php first ran this script [12:48:28] executed the first query [12:48:38] failed on the second because the index (with typo) doesn’t exist [12:48:45] then stopped executing I believe [12:49:06] manually trying to run it, you got another error for the first query, becuase that one had already been executed already and that column now exists [12:49:31] I assume you didn’t execute the rest of the queries? [12:49:54] if no: just delete flow_wiki_ref.ref_src_wiki [12:50:10] then fix the typo (I’ll submit a new patch in a minute) and run update.php again :p [12:51:01] I commented out the first statement, fixed the typo, and run the rest [12:51:37] (03PS26) 10Matthias Mullie: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [12:51:39] perfect [12:53:13] (03PS1) 10Matthias Mullie: Fix typo in sql patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233952 [13:00:51] mlitn: can you look at my browser tests patch? https://gerrit.wikimedia.org/r/#/c/233944 [13:01:21] sure [13:30:49] (03PS1) 10Alex Monk: Fix fatal DB exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233964 (https://phabricator.wikimedia.org/T105890) [13:31:53] (03PS2) 10Alex Monk: Fix fatal DB exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233964 (https://phabricator.wikimedia.org/T105890) [13:33:24] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-01_(1.26wmf21), 7WorkTypeNewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1575210 (10QuimGil) >>! In T98270#1573756, @gerritbot wrote: > Change 233881 merged by jenkins-bot:... [14:17:00] (03CR) 10Matthias Mullie: [C: 032] Browser tests: various fixes for firefox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233944 (owner: 10Sbisson) [14:19:15] (03Merged) 10jenkins-bot: Browser tests: various fixes for firefox [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233944 (owner: 10Sbisson) [14:19:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1575371 (10matthiasmullie) >>! In T94569#1566271, @Mattflaschen wrote: > Should we block this on {T107204... [14:39:44] (03PS32) 10Pginer: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [14:53:32] (03CR) 10Pginer: [C: 04-1] "I submitted a new patchset adjusting colors, positions, and making JS and No-JS versions more consistent." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [14:57:54] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkTypeNewFunctionality, and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1575579 (10Pginer-WMF) I reviewed the current patchset, adjusted the styling and added some more comments to it. [15:43:45] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7Design: Encourage users who are currently ignoring their talk pages to read them - https://phabricator.wikimedia.org/T110048#1575807 (10Pginer-WMF) The ticket seems to be based on a deeper problem for which "forcing" the user to read the... [16:45:58] (03CR) 10Mooeypoo: "The icon issue was a problem with OOUI. We've solved it (there was a merged patch) but OOUI was released to mediawiki yesterday afternoon." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [16:58:17] (03CR) 10Mooeypoo: "As for the icons, they're supposedly maintained by the standardization team, and (from what I understand) we're supposed to use the existi" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [16:59:48] anybody knows what happened to en.wikipedia.beta.wmflabs.org/? 'This page is not available' [17:01:13] nvm - it's back :) [17:06:54] stephanebisson, eeek :( ever since pulling your fix, my entire wiki has no Flow boards. I am sure I did something wrong there, though. [17:07:32] I have "{"flow-workflow":"skabseyjtqtm96dl"}" in place of a board [17:08:09] matt_flaschen: I am checking "Fix new topic notification on MediaWiki.org" https://phabricator.wikimedia.org/T107835 -- only one notification about a new topic comes [17:08:59] matt_flaschen: adding the second topic etc will never send notification... cannot believe it... [17:12:26] stephanebisson, and when I run update.php now, I am getting errors :\ http://pastebin.com/TXPYBm6E [17:13:02] It's really weird if that patch did all of that, though [17:23:04] (03PS3) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [17:24:11] BTW, I have scrum of scrums today, contrary to my email. [17:24:47] mooeypoo: I had the same problem this morning, caused by https://gerrit.wikimedia.org/r/#/c/233952/ [17:24:50] etonkovi_, did you check if it was bundled (it would say something like '2 new topics on Talk:Flow'? [17:25:14] matt_flaschen: yes, I checked it [17:25:38] mooeypoo: matthias helped me manually fix it, it's 100% unrelated and annoying [17:25:44] matt_flaschen: only one new topic per flow board sends notification [17:25:58] stephanebisson, oops [17:26:36] matt_flaschen: was checking timestamps in flow-workflow and revision - not sure that's relevant - still looking... [17:27:26] mooeypoo: what if you do a full update on from master... [17:27:45] mooeypoo, which page is broken? Is it one of the occupied pages? [17:28:47] matt_flaschen, mooeypoo I had the same problem after the occupation ended, I had to Special:EnableFlow on Talk:Flow_QA to make it work again [17:28:58] I.E. Talk:Flow_QA and Talk:Sandbox. [17:29:15] Sorry, I forget to mention this (though it is at Extension:Flow); I only mentioned the update.php. [17:29:49] 6Collaboration-Team-Backlog, 10Echo, 7Documentation: Add documentation file for Echo hooks - https://phabricator.wikimedia.org/T110356#1576103 (10Glaisher) 3NEW [17:30:06] mooeypoo, you can go back to d90073b42711772c7fe8d3537555afcfb3e3ac83 and run maintenance/FlowUpdateRevContentModelFromOccupyPages.php . [17:30:44] Don't remember if https://phabricator.wikimedia.org/T104278 is also required for this. [17:31:06] That's the Flow commit (d900). Have to go to Scrum of Scrums. [17:31:43] Anyone have anything for SoS? [17:32:59] 3Collaboration-Team-Current, 10Flow, 7Regression: Pressing ESC to close VE inspector also cancels your post - https://phabricator.wikimedia.org/T110146#1576122 (10Catrope) https://gerrit.wikimedia.org/r/#/c/233834/ [17:33:12] 3Collaboration-Team-Current, 10Flow, 7Regression: Pressing ESC to close VE inspector also cancels your post - https://phabricator.wikimedia.org/T110146#1576127 (10Catrope) a:3Catrope [17:33:14] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeMaintenance: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1576131 (10DannyH) [17:33:16] 3Collaboration-Team-Current, 10Flow, 7WorkTypeMaintenance: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1576129 (10DannyH) 5Open>3Resolved [17:33:22] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), and 2 others: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1576133 (10DannyH) 5Open>3Resolved [17:43:58] 3Collaboration-Team-Current, 10Flow: Editing an empty Flow board description gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1576179 (10Quiddity) 3NEW [17:44:15] 3Collaboration-Team-Current, 10Flow: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1576196 (10Quiddity) [17:46:51] 6Collaboration-Team-Backlog, 10Flow: EnableFlow -- don't copy "welcome" templates into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1576209 (10DannyH) [17:48:41] 3Collaboration-Team-Current, 10Flow: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1576215 (10Catrope) a:3Mooeypoo [17:51:37] matt_flaschen: when you have a minute [17:51:47] stephanebisson, sure, I'll ping you when SoS is done. [17:56:03] 6Collaboration-Team-Backlog, 10Flow: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1576249 (10DannyH) 1.5em still looks very big to me. Can we see what it looks like, going down past the level that's actually too small? It would help to see what that whole ran... [17:57:15] stephanebisson, hey. [17:57:26] matt_flaschen: it's about https://phabricator.wikimedia.org/T109931 [17:58:17] 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Tweak importer to allow converting opt-out wikis (LQT->Flow) - https://phabricator.wikimedia.org/T109931#1576259 (10Mattflaschen) [17:58:36] matt_flaschen: does it make sense to modify convertLqtPagesWithProp to choose a page iterator based on the site config? [17:58:56] based on $wgLqtTalkPages [18:00:39] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Switch Flow to RESTBase - https://phabricator.wikimedia.org/T94574#1576277 (10mobrovac) Any ETA on this? Note that the Parsoid v1 Varnish cache still exists, but there are no update jobs running any more for it, meaning that cached content still... [18:01:01] stephanebisson, yeah, I think keeping the same entry points (for both site configs) and auto-adjusting at runtime is better than needing to choose the right command to run. However script should be renamed (and the implementation will be different), because if $wgLqtTalkPages is true, need to look for pages without useliquidthreads:0 (but they might still have useliquidthreads:1. [18:01:22] true [18:01:36] so looking for useliquidthreads:1 should be done anyway [18:01:55] but adding NS_USER_TALK only when $wgLqtTalkPages is true [18:03:07] stephanebisson, what's special about NS_USER_TALK? [18:03:47] (03CR) 10Catrope: [C: 032] Fix typo in sql patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233952 (owner: 10Matthias Mullie) [18:04:00] matt_flaschen: isn't it where the LQT pages are, when $wgLqtTalkPages=true ? [18:04:26] $wgLqtNamespaces doesn't seem to be used [18:04:54] stephanebisson, it could be any talk namespace (NS_USER_TALK, NS_TALK, NS_PROJECT_TALK, whatever. [18:04:54] (03CR) 10Catrope: "Release has happened, this can be reviewed now" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232883 (owner: 10Catrope) [18:05:08] ohh [18:05:22] any way to list all the talk ns? [18:06:16] Looking [18:06:24] other than ns%2 === 1 ? [18:06:38] Yeah, MWNamespace::getTalkNamespaces(). [18:06:47] Yeah, I was thinking %2 at first, but I'm not sure it's 100% accurate. [18:06:58] (03Merged) 10jenkins-bot: Fix typo in sql patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233952 (owner: 10Matthias Mullie) [18:07:38] alright, thanks! [18:07:43] No problem [18:08:06] (03CR) 10Catrope: [C: 032] Create all templates Flow uses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232489 (https://phabricator.wikimedia.org/T105421) (owner: 10Matthias Mullie) [18:11:07] (03Merged) 10jenkins-bot: Create all templates Flow uses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232489 (https://phabricator.wikimedia.org/T105421) (owner: 10Matthias Mullie) [18:14:02] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Switch Flow to RESTBase - https://phabricator.wikimedia.org/T94574#1576354 (10Mattflaschen) >>! In T94574#1576277, @mobrovac wrote: > Any ETA on this? > > Note that the Parsoid v1 Varnish cache still exists, but there are no update jobs running a... [18:19:27] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Switch Flow to RESTBase - https://phabricator.wikimedia.org/T94574#1576378 (10ssastry) Yes, we do want to kill Parsoid's v1 API. Maintaining multiple versions of the API adds to maintenance burden. While we've refactored the code internally over t... [18:25:01] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase: Switch Flow to RESTBase - https://phabricator.wikimedia.org/T94574#1576389 (10cscott) The POST API still exists; the URL scheme is just slightly different. Flow should use the VRS service for Parsoid like everyone else; see https://gerrit.wikimed... [18:35:02] mooeypoo, is your Vagrant fixed? [18:35:06] matt_flaschen, yes [18:35:13] I pulled matthias' sql fix [18:35:25] matt_flaschen: can you help me with the syntax to run the conversion script? [18:35:30] and then ran the maintenance/FlowUpdateRevContentModelFromOccupyPages.php script [18:35:37] that fixed things [18:35:55] matt_flaschen, also, i ran mw maintenance/update.php [18:36:10] mooeypoo, oh, I forgot, you don't have to go back for FlowUpdateRevContent, only for the page model one. [18:37:26] stephanebisson, sure. BTW, one thing I should mention is that convertLqtPagesWithProp.php has not been run in production for a long time (I'm not sure if ever) since we had to use a different approach due to the page ordering constraints. [18:38:22] matt_flaschen: did you convert pages one by one with ConvertLqtPageOnLocalWiki? [18:39:13] stephanebisson, yes, with a wrapper script, because of the page order and batching specified for MediaWiki.org (Day xyz). [18:40:07] the same approach could be considered here... we would just have to generate a list of all lqt pages based on the config... [18:41:11] Yeah. I'd rather use the whole-wiki script, unless there's some reason not to, though. The resumability actually works really well (I know this from hard experience), and with a whole-wiki conversion it seems conceptually simple. [18:41:14] matt_flaschen, now that the occupation is over, if I want a talk page to be Flow, I need to specifically Special:EnableFlow it? [18:41:18] no more full namespaces, right? [18:41:40] mooeypoo, no, you can still do a full namespace with $wgNamespaceContentModels. [18:41:55] matt_flaschen, ah, that's waht it is. Missed that one [18:41:57] thanks! [18:42:19] matt_flaschen: the resumability with startId/stopId? [18:43:32] hmmmm [18:43:40] No, the --logfile. That file actually records what has already been imported (and to where), so it knows not to double-import if you have to re-import. --startid, --stopid seems to just be a non-essential optimization AFAICT (convertLqtPageOnLocalWiki.php which we used on MW.org also doesn't have the id ones). [18:43:48] So the syntax would be something like: [18:43:52] When did we change the Special:EnableFlow page to demand a description? is that recent? [18:44:17] mooeypoo, yes, working on removing that requirement again. [18:44:21] https://phabricator.wikimedia.org/T110358 <-- these pages existed before said change, right? [18:44:27] matt_flaschen: so with th elog file, you build the same iterator but just skip a whole bunch when you resume, right? [18:44:31] yeah I can't reproduce it because I can't create a board without description. [18:44:38] I'm pretty sure I know why the bug happens, though. [18:44:51] BoardDescriptionWidget looks for a previous uuid for diff [18:45:06] but there is none when it's the first description, so the API call needs to be a little different [18:45:34] stephanebisson, yes, the skipping is done internally in Importer.php. [18:46:35] wait, actually, I should be able to reproduce this with occupying a namespace [18:46:35] mooeypoo, there are lots of ways to create a board without a description. E.g. in a Flow namespace just create a topic. [18:46:36] yeah I just realized [18:46:36] Okay, maybe only two ways. :) [18:46:44] hm also $wgNamespaceContentModels what does that accept? [18:47:10] stephanebisson: mwscript extensions/Flow/maintenance/convertLqtPagesWithProp.php --wiki=wiki --debug --logfile wikiname.sourceStore [18:47:11] matt_flaschen: I have a draft here, it's really not optimized: https://phabricator.wikimedia.org/P1931 [18:47:13] not namespaces...? it crashed for me with this $wgNamespaceContentModels = array( NS_USER_TALK, NS_FLOW_TEST_TALK ); [18:47:34] matt_flaschen: depending on the situation that may or may not be good enough [18:47:38] mooeypoo, sorry, I forgot to link you to the config: https://git.wikimedia.org/blob/operations%2Fmediawiki-config/HEAD/wmf-config%2FCommonSettings.php#L2476 [18:47:48] $namespace is a number index like NS_USER_TALK [18:49:28] hm [18:49:59] still not working. [18:50:02] I'm doing something wrong. [18:50:10] mooeypoo, paste? [18:50:18] It seems to read wgFlowOccupyNamespaces so if I have that it should work [18:50:42] http://pastebin.com/HxRenar1 [18:50:47] this is from the LocalSettings.php [18:51:09] mooeypoo, yes, wgFlowOccupyNamespaces should go away soon, though. [18:52:04] matt_flaschen, so doing $wgNamespaceContentModels[ NS_USER_TALK ] = CONTENT_MODEL_FLOW_BOARD; should make all my user talk pages Flow [18:52:06] right? [18:52:14] Yes. [18:52:22] mooeypoo, is it running after Flow is loaded (for the const)? [18:52:34] matt_flaschen, here we go [18:52:41] yeah it's the Vagrant LocalSettings [18:52:46] after everything loaded, supposedly [18:53:06] ok it's working now [18:53:53] stephanebisson, yeah, it seems like it should work due to the double-checking elsewhere (isConversionFinished), but might be hard to see whether the wiki is done. [18:54:52] matt_flaschen, ok, i went to User_talk:12312312123123 for testing a new description. I edit the description, add some words, then save, and I get this error: [18:54:54] Exception Caught: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script Query: SELECT * FROM `flow_ext_ref` WHERE ref_src_wiki = 'wiki' AND ref_src_namespace = '3' AND ref_src_title = '123123123123123' ORDER BY ref_src_object_id ASC LIMIT 500 Function: Flow\Data\Storage\BasicDbStorage::find (flow_ext_ref) Error: 1054 Unk [18:54:54] nown column 'ref_src_wiki' in 'where clause' (127.0.0.1) [18:55:06] I ran maintenance/update.php just in case, but that didn't help [18:55:18] what did I forget to do? another patch maybe missing? [18:56:07] stephanebisson, I think it could be done with EchoBatchRowIterator (similarly to PagesWithProp) and a LEFT OUTER JOIN to check that it's not 0 (but null and 1 mean 'yes, LQT'). But like you said, it might be enough. [18:57:05] mooeypoo, hmm, can you paste your update.php? It should create that column. [18:57:15] (03CR) 10Mooeypoo: "Answers to review on PS30." (0312 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:57:20] matt_flaschen, hang on [18:58:19] matt_flaschen, http://pastebin.com/Qq3MSMeG [18:58:30] matt_flaschen: I ran it on my setup it took 7 minutes the first time. I had almost no LQT pages but it had to check all the talk pages to know. The second time it took 7 seconds to skip them all based on the log file. [18:59:17] stephanebisson, sounds good. sewikimedia is also a small wiki, anyway. [18:59:54] stephanebisson, doesn't it only log pages that are converted, though? [19:00:16] Or maybe those 7 minutes are mostly just actual conversion time? [19:00:22] mooeypoo, sorry, I meant the output. [19:01:16] yeah I was wondering if that's helpful at all :p let me repaste, hang on [19:01:49] matt_flaschen, http://pastebin.com/F7NC63UA [19:01:58] matt_flaschen, I'm going for a lunch meeting, I'll be back in a bit [19:03:10] matt_flaschen: one would think, something strange is happening... https://phabricator.wikimedia.org/P1932 [19:03:32] mooey|lunch, due to the earlier SQL bug, you have an inconsistent state (ref_src_wiki in one table, but not the other) so it doesn't know to run it. Easiest fix is to remove ref_src_wiki from flow_wiki_ref table. [19:03:36] Completed import to User talk:New user 46844854434100081934731290796947672104 from User talk:New user 46844854434100081934731290796947672104/LQT Archive 1 [19:03:38] Page previously archived from User talk:New user 188557775701969900080662028874949268839/Archive 1 to User talk:New user 188557775701969900080662028874949268839 [19:05:12] matt_flaschen: the logic around $movedFrom = $this->getPageMovedFrom( $title ); is kicking in because I have tons of users who have opted in [19:05:50] stephanebisson, I was wondering why it had a bunch of stuff about /Archive_1. [19:08:16] I guess it's a good thing it skips those, but it's somewhat confusing. [19:08:28] But won't be an issue on sewikimedia. [19:09:10] Actually it doesn't skip them. [19:11:23] The Flow opt in feature just wouldn't work without #useliquidthreads:0 on the archive page on such a wiki, since even subpages like https://se.wikimedia.org/wiki/Anv%C3%A4ndardiskussion:Made_up_page/Arkiv_1 are still LQT. [19:16:46] yeah, it looks like LqtDispatch::isLqtPage is fooled by $title->isTalkPage() && $wgLqtTalkPages [19:17:09] it is thinking: "this page really should be LQT" [19:18:55] 6Collaboration-Team-Backlog, 10Echo: Echo should warn users who tries to mention more than N other users that they won't be notified - https://phabricator.wikimedia.org/T108293#1576616 (10Mattflaschen) [19:19:31] 6Collaboration-Team-Backlog, 10Echo: When there are more than 20 mentions in a single post, none are sent - https://phabricator.wikimedia.org/T110306#1576618 (10Mattflaschen) [19:20:01] 6Collaboration-Team-Backlog, 10Echo: When there are more than 20 mentions in a single post, none are sent - https://phabricator.wikimedia.org/T110306#1574571 (10Mattflaschen) See also {T108293}. [19:20:13] 6Collaboration-Team-Backlog, 10Echo: When there are more than 20 mentions in a single post, none are sent - https://phabricator.wikimedia.org/T110306#1576628 (10Mattflaschen) [19:20:28] 6Collaboration-Team-Backlog, 10Echo: Echo should warn users who tries to mention more than 20 other users that they won't be notified - https://phabricator.wikimedia.org/T108293#1576629 (10Mattflaschen) [19:25:16] 6Collaboration-Team-Backlog, 10Echo: Provide feedback when you mention an other user - https://phabricator.wikimedia.org/T110308#1576644 (10Mattflaschen) This is a duplicate, but I can't find the other one. /cc @quiddity. [19:26:12] matt_flaschen: I think if we do this that should work: 1. convert; 2. freeze LQT; 3. enable opt-in and or start using Special:EnableFlow [19:30:04] (03CR) 10Mattflaschen: "You mean 'specific columns'." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233093 (https://phabricator.wikimedia.org/T105890) (owner: 10Nemo bis) [19:31:44] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7Wikimedia-log-errors: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#1576679 (10Mattflaschen) p:5High>3Unbreak! [19:32:57] matt_flaschen, mind +2ing my patch? [19:33:44] (03CR) 10Nemo bis: "Sure, that was a typo." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233093 (https://phabricator.wikimedia.org/T105890) (owner: 10Nemo bis) [19:33:51] Krenair, I'm looking at it now. I only saw this because I happened to be reading through IRC. Please ping people and add Collaboration team reviewers next time. [19:34:11] matt_flaschen, what, when I upload patches to the Echo extension? [19:34:31] Krenair, yes, we should know about a fatal in our extensions. [19:34:42] You should be watching your gerrit projects :) [19:35:25] Krenair, we do. We go over open patches every so often. [19:35:43] That's not watching a project. [19:36:15] Watching a project = you get email notifications when anything happens in the project [19:37:12] Krenair, I don't know if anyone does that or not. But it's clear not every change has the same priority. This had a high priority, and pinging us would have been a reasonable courtesy. [19:45:09] (03CR) 10Mattflaschen: [C: 032] Fix fatal DB exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233964 (https://phabricator.wikimedia.org/T105890) (owner: 10Alex Monk) [19:46:32] (03PS1) 10Alex Monk: Fix fatal DB exception [extensions/Echo] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/234082 (https://phabricator.wikimedia.org/T105890) [19:46:42] (03CR) 10Alex Monk: [C: 032] Fix fatal DB exception [extensions/Echo] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/234082 (https://phabricator.wikimedia.org/T105890) (owner: 10Alex Monk) [19:47:05] (03Merged) 10jenkins-bot: Fix fatal DB exception [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233964 (https://phabricator.wikimedia.org/T105890) (owner: 10Alex Monk) [19:47:11] (03PS1) 10Sbisson: Allow converting entire LQT namespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) [19:49:12] (03Merged) 10jenkins-bot: Fix fatal DB exception [extensions/Echo] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/234082 (https://phabricator.wikimedia.org/T105890) (owner: 10Alex Monk) [19:50:30] (03CR) 10Mattflaschen: "It only needed to be removed from the second one. I'll do a follow-up." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233964 (https://phabricator.wikimedia.org/T105890) (owner: 10Alex Monk) [19:52:05] (03CR) 10jenkins-bot: [V: 04-1] Allow converting entire LQT namespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) (owner: 10Sbisson) [19:52:30] 3Collaboration-Team-Current, 10Flow: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1576773 (10Etonkovidova) In betalabs: 1. Delete a content from a board descirption. 2. In wikitex... [19:53:07] (03CR) 10Alex Monk: "Probably. I was just changing it back to select the same columns as it did before." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233964 (https://phabricator.wikimedia.org/T105890) (owner: 10Alex Monk) [20:02:52] (03PS2) 10Sbisson: Allow converting entire LQT namespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234089 (https://phabricator.wikimedia.org/T109931) [20:08:35] (03PS1) 10Mattflaschen: Put back notification_timestamp for web. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234126 [20:09:24] 3Collaboration-Team-Current, 10Flow: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1576824 (10Etonkovidova) >If I blank an existing description, that does Not cause the bug to appea... [20:10:16] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 2 others: Missing database prefix for echo_event - https://phabricator.wikimedia.org/T105890#1576825 (10Mattflaschen) [20:11:55] (03CR) 10Mattflaschen: "This one does not need to be rushed or cherry-picked." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234126 (owner: 10Mattflaschen) [20:12:41] (03CR) 10Mattflaschen: "Follow-ups:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233093 (https://phabricator.wikimedia.org/T105890) (owner: 10Nemo bis) [20:12:44] 6Collaboration-Team-Backlog, 10Flow: Keyboard shortcut for "Reply" - https://phabricator.wikimedia.org/T110387#1576828 (10eranroz) 3NEW [20:20:44] 6Collaboration-Team-Backlog, 10Echo: Provide feedback when you mention an other user - https://phabricator.wikimedia.org/T110308#1576867 (10Quiddity) [20:20:45] 6Collaboration-Team-Backlog, 10Echo: When mentioning other users, indicate mention notifications in the "your edit was saved" message - https://phabricator.wikimedia.org/T68078#1576868 (10Quiddity) [20:20:56] stephanebisson, yeah, opt-in should work fine once it's frozen (part of freezing sets wgLqtTalkPages false). [20:21:54] (03CR) 10Catrope: [C: 032] Use $wgNamespaceContentModels instead of $wgFlowOccupyNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228268 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie) [20:24:17] (03Merged) 10jenkins-bot: Use $wgNamespaceContentModels instead of $wgFlowOccupyNamespaces [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228268 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie) [20:27:26] RoanKattouw, what's an example of moveCursorToEnd I could test? [20:30:27] 3Collaboration-Team-Current, 10Wikibugs, 5Patch-For-Review: Add Collaboration-Team-Current to #wikimedia-collaboration - https://phabricator.wikimedia.org/T110186#1576900 (10Etonkovidova) Additionally checked on labs / tools/wikibugs2. Looks consistent with what other teams - e.g. #wikimedia-analytics, #me... [20:33:28] matt_flaschen, awesome, that fixed it [20:33:49] But I can't reproduce the bug. New Flow board with empty descriptions let me add a description without a problem. [20:34:08] 3Collaboration-Team-Current, 10Flow: Reduce title font size and footprint of topic header - https://phabricator.wikimedia.org/T108263#1576907 (10DannyH) a:5Pginer-WMF>3None [20:34:24] matt_flaschen, Could there be any substantial difference between recent things we did in master and the board that is on mw.org ? This bug doesn't happen for me in master at all. [20:35:32] matt_flaschen: Switching editors [20:36:16] matt_flaschen: https://gerrit.wikimedia.org/r/#/c/232883/1/modules/flow/ui/widgets/editor/editors/mw.flow.ui.WikitextEditorWidget.js should be a no-op in terms of user-observed behavior. It should be true now and should continue to be true that when you switch from VE to WT, the cursor is put at the end [20:36:45] mooeypoo: https://gerrit.wikimedia.org/r/231483 [20:36:52] RoanKattouw, I can't get it to work (on MediaWiki.org either). [20:38:05] 3Collaboration-Team-Current, 10Flow: Editing an empty Flow board description (that has previously contained a category?) gives "Previous revision identifier is missing" - https://phabricator.wikimedia.org/T110358#1576918 (10Mattflaschen) >>! In T110358#1576824, @Etonkovidova wrote: > I thought that it was neve... [20:38:33] mooeypoo, looking at the stacktrace code (32ec9d4d) Elena posted. [20:40:38] matt_flaschen, I got it [20:40:43] It's not actually a new board [20:40:45] it's BETTER [20:40:54] It's a board (not new) with a description whose content is '' [20:41:25] mooeypoo, so why does it think that revision doesn't exist? [20:42:00] matt_flaschen, because I, in my infinite wisdom, have this if statement wrapping the "populate the dm" : if ( content && format ) { ... } [20:42:13] it was supposed to prevent populating when there's no revision (when the board is new) [20:42:26] mooeypoo, that's not the === way! [20:42:26] ... and yet, content = '' is.. uncaught... [20:42:30] :D [20:42:53] ;) [20:43:29] (03PS1) 10Mooeypoo: Populate the Description data model even if content is empty [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234135 (https://phabricator.wikimedia.org/T110358) [20:43:34] Elena's thing is something else (can someone ask her to rejoin IRC?) [20:43:35] * mooeypoo whistles and walks away [20:44:14] Yeah she was just showing me several very scary backend errors when undoing board description edits [20:45:24] mooeypoo, is that also the reason for the VE part of https://phabricator.wikimedia.org/T110358#1576773 ? [20:45:36] Otherwise, I'll file it separately. [20:45:50] hm [20:46:17] I don't think so.. [20:47:03] (03CR) 10Catrope: [C: 032] Populate the Description data model even if content is empty [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234135 (https://phabricator.wikimedia.org/T110358) (owner: 10Mooeypoo) [20:47:10] (03CR) 10Alex Monk: [C: 031] Put back notification_timestamp for web. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234126 (owner: 10Mattflaschen) [20:48:45] (03PS33) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [20:49:12] 3Collaboration-Team-Current: Exception Caught: Row has null primary key - https://phabricator.wikimedia.org/T110390#1576945 (10Mattflaschen) 3NEW a:3Mattflaschen [20:49:21] (03Merged) 10jenkins-bot: Populate the Description data model even if content is empty [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234135 (https://phabricator.wikimedia.org/T110358) (owner: 10Mooeypoo) [20:50:37] 3Collaboration-Team-Current, 10Flow: VE error editing board description - https://phabricator.wikimedia.org/T110393#1576976 (10Mattflaschen) 3NEW [20:56:53] who is the primary designer working on Flow these days? [20:58:17] Pau [20:58:44] is he ever around on irc? [20:59:10] i'm asking because i just saw the roadmap get updated, and it includes "Workflow builder". [20:59:28] jorm, yes, it's just after-hours for him. [20:59:33] and i was going to offer some time and thoughts to explain to him what i originally meant. [20:59:45] He's in Spain. [20:59:46] and how i came to the conclusion that a workflow builder was required. [20:59:48] yes, i know. [20:59:59] i just didn't remember if he idled or not. [21:04:23] 6Collaboration-Team-Backlog, 10Flow: Keyboard shortcut for "Reply" - https://phabricator.wikimedia.org/T110387#1577059 (10Quiddity) [21:04:27] 6Collaboration-Team-Backlog, 10Flow: Flow lacking accesskeys for preview/submit - https://phabricator.wikimedia.org/T63517#1577060 (10Quiddity) [21:06:40] jorm: He's on IRC as pginer IIRC, but he usually ends his day around 11am-noon Pacific [21:07:01] And doesn't idle in here overnight [21:07:32] aight. [21:07:43] i'm glad pau is on the project. [21:09:38] 6Collaboration-Team-Backlog, 10Flow: Flow lacking accesskeys for preview/submit - https://phabricator.wikimedia.org/T63517#1577089 (10Josve05a) I use alt(+shift)+s to save in articles, which is specified when hovering over the save-button (in wikicode-mode). That should be standard for Flow as well. [21:10:36] 3Collaboration-Team-Current: Exception Caught: Row has null primary key - https://phabricator.wikimedia.org/T110390#1577095 (10Etonkovidova) View history - http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:ET27&action=undo-edit-header&header_startId=snqym44903kru3qj&header_endId=snqymnq9cqwc71g8 Undo... [21:29:19] I know the SQL typo affected Beta as well, but I'm trying to figure out what's going on a little better. [21:29:25] If I can't, I'll fix the tables and see what that does. [21:36:00] 3Collaboration-Team-Current, 10Flow, 7Regression: Pressing ESC to close VE inspector also cancels your post - https://phabricator.wikimedia.org/T110146#1577180 (10Etonkovidova) Checked in betalabs. [21:49:44] legoktm: Does https://gerrit.wikimedia.org/r/#/c/233639/1 fix the read/seen race condition? [21:50:33] RoanKattouw: yes, but mooeypoo already worked around that by not firing the requests in parallel [21:51:31] and I have another patch somewhere to combine the two API requests [22:09:32] 6Collaboration-Team-Backlog, 6Editing-Analysis, 6Editing-Department: Define performance indicators for the Collaboration team - https://phabricator.wikimedia.org/T107353#1577290 (10Jdforrester-WMF) [22:16:26] (03PS1) 10Mattflaschen: Fix another issue with patch-reference_wiki.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234162 (https://phabricator.wikimedia.org/T107204) [22:19:03] ^ Alright, there's a couple issues on Beta, including that one (another typo in the update.php SQL script. :( Would appreciate if someone could review soon so I can continue fixing Beta. [22:19:21] ^ mooeypoo, RoanKattouw, legoktm [22:23:02] (03CR) 10Catrope: [C: 032] Fix another issue with patch-reference_wiki.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234162 (https://phabricator.wikimedia.org/T107204) (owner: 10Mattflaschen) [22:25:02] Thanks RoanKattouw. I will also send out a workaround script. [22:25:24] (03Merged) 10jenkins-bot: Fix another issue with patch-reference_wiki.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234162 (https://phabricator.wikimedia.org/T107204) (owner: 10Mattflaschen) [22:27:01] 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1577372 (10Etonkovidova) Tested in betalabs&production 1) first new topic on a Flow page - email notification is sent immediately 2) posting more new topic... [22:29:20] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkTypeNewFunctionality: Pressing ESC to close VE inspector also cancels your post - https://phabricator.wikimedia.org/T110146#1577377 (10DannyH) [22:29:27] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkTypeNewFunctionality: Pressing ESC to close VE inspector also cancels your post - https://phabricator.wikimedia.org/T110146#1577379 (10DannyH) 5Open>3Resolved [22:34:10] hm. I'm not getting notifications (on my local wiki) for 'thank' in flow [22:39:05] mooeypoo, check if it's enabled, I don't remember the default. [22:39:37] mooeypoo, I mean the user pref. [22:43:47] should be default on, we want to give people thanks :) [22:44:24] I used to get those, though. Weird [22:45:02] ebernhardson, I just don't want to context-switch to check the default. [22:50:41] RoanKattouw, is bug triage really bug triage, or something else? [22:50:52] (03PS1) 10Catrope: Reduce font size and vertical padding of topic header [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234171 (https://phabricator.wikimedia.org/T108263) [22:51:05] matt_flaschen: What do you mean? [22:51:47] RoanKattouw, like the estimation meeting this morning was really just talking about the workflow builder. Which is fine, I'm just trying to figure out if I can skip this or come late to try to finish the Beta thing. [22:52:56] Or the meeting yesterday, rather. [22:54:05] I intend for the bug triage meeting to be actual triage, not talking about workflow stuff or anything else [22:54:27] Okay, that really was not meant as a complaint. [22:54:37] RoanKattouw, then is it alright if I come late? [22:54:43] Sure [22:54:54] You have a SWAT to do? [22:57:15] RoanKattouw, no, it's on Beta. I guess I'll come and just fix it afterwards, just need to write some stuff down. [23:00:05] 3Collaboration-Team-Current: Exception Caught: Row has null primary key - https://phabricator.wikimedia.org/T110390#1577510 (10Mattflaschen) This might be fixed by Matthias's change, https://gerrit.wikimedia.org/r/#/c/233432/ . We also need to set that $wgFlowMigrateReferenceWiki to false on Beta after I fix th... [23:05:32] (03CR) 10Quiddity: [C: 031] "Untested, but looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/234171 (https://phabricator.wikimedia.org/T108263) (owner: 10Catrope) [23:07:11] 6Collaboration-Team-Backlog, 10Echo, 7Documentation: Add documentation file for Echo hooks - https://phabricator.wikimedia.org/T110356#1577563 (10Catrope) p:5Triage>3Normal [23:08:53] 6Collaboration-Team-Backlog, 10Flow: Editing pencil for Flow descriptions is always blue - https://phabricator.wikimedia.org/T110309#1577594 (10Catrope) This is a regression from the editor refactor. OOUI doesn't currently support icon color changes on hover very well (we used a hack before). I guess we could... [23:09:23] 6Collaboration-Team-Backlog, 10Flow: Editing pencil for Flow descriptions is always blue - https://phabricator.wikimedia.org/T110309#1577603 (10Catrope) p:5Triage>3Normal [23:15:08] 6Collaboration-Team-Backlog, 10Echo: When there are more than 20 mentions in a single post, none are sent - https://phabricator.wikimedia.org/T110306#1577618 (10Catrope) It's suggested we up the limit to something more practical like 50. If someone spams notifications, it's clear who's responsible, because the... [23:15:42] 6Collaboration-Team-Backlog, 10Echo: When there are more than 20 mentions in a single post, none are sent - https://phabricator.wikimedia.org/T110306#1577620 (10Catrope) p:5Triage>3Normal [23:16:00] (03PS34) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [23:16:00] 6Collaboration-Team-Backlog, 10Echo: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1577621 (10Catrope) [23:16:43] 3Collaboration-Team-Current, 10Echo: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1574571 (10Catrope) a:3Mattflaschen [23:16:50] 3Collaboration-Team-Current, 10Echo: Increase number of mentions allowed in a single post - https://phabricator.wikimedia.org/T110306#1577627 (10EBernhardson) This was originally set so low at 20 because while the person who spammed the notifications is obvious, they blamed us rather than mz. [23:16:52] (03CR) 10Mooeypoo: Split alerts and messages in Echo (0349 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:17:18] (03PS1) 10Mattflaschen: Bump mention limit to 50 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234179 (https://phabricator.wikimedia.org/T110306) [23:18:09] 6Collaboration-Team-Backlog, 10MoodBar, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update MoodBar to use AuthManager - https://phabricator.wikimedia.org/T110286#1577634 (10Catrope) p:5Triage>3Low [23:18:10] (03CR) 10Mattflaschen: "Not tested." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234179 (https://phabricator.wikimedia.org/T110306) (owner: 10Mattflaschen) [23:18:19] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Authentication-and-authorization, 6Reading-Infrastructure-Team: Update Echo to use AuthManager - https://phabricator.wikimedia.org/T110285#1577638 (10Catrope) p:5Triage>3Low [23:18:50] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1577645 (10Catrope) a:3Legoktm [23:19:04] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1572362 (10Catrope) p:5Triage>3Normal [23:21:14] 6Collaboration-Team-Backlog, 10Flow: Permalink mw-ui-icon-link button displays tooltip(s) in lower case - https://phabricator.wikimedia.org/T110211#1577678 (10Catrope) [23:21:16] 6Collaboration-Team-Backlog, 10Flow: Remove tooltips from dropdown menu in post and topic header - https://phabricator.wikimedia.org/T101198#1577679 (10Catrope) [23:25:37] 6Collaboration-Team-Backlog, 10Flow: Reconsider Flow's use of .mw-ui-hovericon (dropdown menu items that gain progressive/constructive/destructive styling on hover) - https://phabricator.wikimedia.org/T110051#1577708 (10Catrope) p:5Triage>3Normal [23:27:53] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7Design: Encourage users who are currently ignoring their talk pages to read them - https://phabricator.wikimedia.org/T110048#1577711 (10Catrope) p:5Triage>3Low [23:29:18] 6Collaboration-Team-Backlog, 10Flow: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1577723 (10Catrope) 21px happens because we have `font-size: 14px;` and the icons are 1.5em. We could make the icons 1.6em to render them at 24px if that helps. But these icons are SVGs, right? Or ar... [23:29:31] 6Collaboration-Team-Backlog, 10Flow: Some icons in Flow look blurry - https://phabricator.wikimedia.org/T110035#1577724 (10Catrope) p:5Triage>3Low [23:32:16] (03PS1) 10Aaron Schulz: Defer clearTalkNotification() updates as they often happen on GET requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/234183 (https://phabricator.wikimedia.org/T92357) [23:37:58] 6Collaboration-Team-Backlog, 10Echo: "You have new messages" is highlighted in orange whenever you view your talk page - https://phabricator.wikimedia.org/T109997#1577743 (10Catrope) This happens because pages you viewed while you had notifications get cached by your browser, and when your browser checks wheth... [23:38:31] 6Collaboration-Team-Backlog, 10Echo: "You have new messages" is highlighted in orange whenever you view your talk page - https://phabricator.wikimedia.org/T109997#1577744 (10Catrope) p:5Triage>3High [23:39:46] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkTypeNewFunctionality: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1577747 (10Catrope) [23:39:47] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks: Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks - https://phabricator.wikimedia.org/T109984#1577746 (10Catrope) [23:41:37] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkTypeNewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1577749 (10Mattflaschen) [23:41:52] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks: Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks - https://phabricator.wikimedia.org/T109984#1577752 (10Catrope) See also T59153 where it is proposed we use the edit summary parser for topic titles. In any case,... [23:43:07] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks: Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks - https://phabricator.wikimedia.org/T109984#1577755 (10Catrope) p:5Triage>3Normal [23:44:42] 6Collaboration-Team-Backlog, 10Flow: Error when trying to edit topic title in new tab / noJS mode - https://phabricator.wikimedia.org/T100851#1577761 (10Quiddity) [23:44:43] 6Collaboration-Team-Backlog, 10Flow: Page container different width for topic-page between js and no-js - https://phabricator.wikimedia.org/T109978#1577760 (10Quiddity) [23:44:45] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#1577759 (10Quiddity) [23:45:06] 6Collaboration-Team-Backlog, 10Flow, 5WMF-deploy-2015-08-25_(1.26wmf20): Page container different width for topic-page between js and no-js - https://phabricator.wikimedia.org/T109978#1577764 (10Catrope) Fixed by https://gerrit.wikimedia.org/r/#/c/231476/ which was deployed yesterday in wmf20. [23:45:13] 6Collaboration-Team-Backlog, 10Flow, 5WMF-deploy-2015-08-25_(1.26wmf20): Page container different width for topic-page between js and no-js - https://phabricator.wikimedia.org/T109978#1577767 (10Catrope) 5Open>3Resolved a:3Catrope [23:45:14] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#1577769 (10Catrope) [23:45:46] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#606005 (10Catrope) [23:45:48] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review, 7Tracking: Don't show unusable TOC link ("Browse topics") without JS - https://phabricator.wikimedia.org/T86844#1577770 (10Catrope) 5Open>3Resolved a:3Catrope [23:46:29] 6Collaboration-Team-Backlog, 10Flow: No-JS for adding Flow topics to your watchlist: message fixes - https://phabricator.wikimedia.org/T100257#1577781 (10Quiddity) [23:46:30] 6Collaboration-Team-Backlog, 10Flow: Table of Contents: No-JS version - https://phabricator.wikimedia.org/T90043#1577782 (10Quiddity) [23:46:32] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#1577780 (10Quiddity) [23:47:34] 6Collaboration-Team-Backlog, 10Flow: Protection log entries for Flow pages link to broken action=history&offset=... URLs - https://phabricator.wikimedia.org/T109936#1577789 (10Catrope) [23:47:57] 6Collaboration-Team-Backlog, 10Flow: Protection log entries for Flow pages link to broken action=history&offset=... URLs - https://phabricator.wikimedia.org/T109936#1563182 (10Catrope) Flow should override the protection log entry to point the history link to something that does work. [23:48:16] 6Collaboration-Team-Backlog, 10Flow: Protection log entries for Flow pages link to broken action=history&offset=... URLs - https://phabricator.wikimedia.org/T109936#1577793 (10Catrope) p:5Triage>3Normal [23:49:42] 6Collaboration-Team-Backlog, 10Flow: 'Change title' does not update 'Reply to[title]' - https://phabricator.wikimedia.org/T109898#1577806 (10Catrope) p:5Triage>3Low [23:51:46] 6Collaboration-Team-Backlog, 10Flow: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1577812 (10Catrope) p:5Triage>3Normal [23:52:31] 3Collaboration-Team-Current, 10Flow: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1577822 (10Catrope) [23:54:11] 6Collaboration-Team-Backlog, 10Flow, 7Parsoid-Nowiki: Flow puts nowiki around a mailto: link with spaces in query string - https://phabricator.wikimedia.org/T109806#1577831 (10Catrope) p:5Triage>3Normal This is probably a Parsoid issue, but I'd have to try a few things to narrow it down. [23:55:10] 6Collaboration-Team-Backlog, 10Flow: Email notification: The new renamed topic title is displayed in place for the previos title - https://phabricator.wikimedia.org/T109784#1577839 (10Catrope) p:5Triage>3High [23:55:48] 6Collaboration-Team-Backlog, 10Flow: Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1577844 (10Catrope) p:5Triage>3Normal [23:56:45] 6Collaboration-Team-Backlog, 10Flow: Indicate in the page title that an edit is ongoing - https://phabricator.wikimedia.org/T109767#1577850 (10Catrope) [23:56:47] 6Collaboration-Team-Backlog, 10Flow: Change title (document.title) when the user has an editor open - https://phabricator.wikimedia.org/T107356#1577851 (10Catrope) [23:57:11] 6Collaboration-Team-Backlog, 10Flow: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" - https://phabricator.wikimedia.org/T109750#1577855 (10Catrope) [23:57:13] 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Port remaining editor uses to EditorWidget - https://phabricator.wikimedia.org/T109000#1577856 (10Catrope) [23:57:49] 6Collaboration-Team-Backlog, 10Flow: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" - https://phabricator.wikimedia.org/T109750#1577857 (10Catrope) p:5Triage>3Normal [23:59:20] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Blockers before allowing Flow opt-in on sv.wp (tracking) - https://phabricator.wikimedia.org/T109685#1577868 (10Catrope) p:5Triage>3High