[00:05:55] 10Echo, 3Collaboration-Team-Current, 7Schema-change: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1569717 (10Mattflaschen) [00:08:09] 10Flow, 3Collaboration-Team-Current, 7WorkTypeMaintenance: addurl CAPTCHA broken (HTML is rendered as text and CAPTCHA always fails you even if you fill in the form right) - https://phabricator.wikimedia.org/T109554#1569719 (10Mattflaschen) [00:08:44] 10Flow, 3Collaboration-Team-Current, 7WorkTypeMaintenance: addurl CAPTCHA broken (HTML is rendered as text and CAPTCHA always fails you even if you fill in the form right) - https://phabricator.wikimedia.org/T109554#1551869 (10Mattflaschen) Even with the formatting fixed, it still doesn't work because there'... [00:20:23] Sorry, my computer froze. [00:28:08] 10Flow, 3Collaboration-Team-Current, 7WorkTypeMaintenance: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1569787 (10Mattflaschen) >>! In T109671#1569659, @Etonkovidova wrote: > Not sure if it's relevant: > > There is no results - http://quarry.w... [00:30:13] (03PS1) 10Aaron Schulz: Added $rclass to BagOStuff lock() method to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233646 [00:49:35] 10Flow, 6Collaboration-Team-Backlog: Problems with custom color themes - https://phabricator.wikimedia.org/T110145#1569807 (10Mattflaschen) 3NEW [00:49:41] 10Flow, 6Collaboration-Team-Backlog: Problems with custom color themes - https://phabricator.wikimedia.org/T110145#1569817 (10Mattflaschen) [00:51:57] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeNewFunctionality: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1569819 (10Mattflaschen) If this is the same error that happens whe... [00:53:08] (03PS1) 10Mattflaschen: Don't open two editors when clicking a nested reply link [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233650 (https://phabricator.wikimedia.org/T109748) [00:58:06] 10Flow, 6Collaboration-Team-Backlog, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1569826 (10Mattflaschen) Shouldn't this be resolved? [00:58:36] 10Flow, 6Collaboration-Team-Backlog: Allow canceling a reply by pressing ESC - https://phabricator.wikimedia.org/T87284#1569828 (10Mattflaschen) [00:58:37] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 5WMF-deploy-2015-08-25_(1.26wmf20): Press ESC to cancel a message - https://phabricator.wikimedia.org/T101178#1569830 (10Mattflaschen) [00:58:40] 10Flow, 6Collaboration-Team-Backlog: Flow for users with white text on black background - https://phabricator.wikimedia.org/T105759#1569833 (10Quiddity) [00:58:41] 10Flow, 6Collaboration-Team-Backlog: Problems with custom color themes - https://phabricator.wikimedia.org/T110145#1569832 (10Quiddity) [00:59:05] 10Flow, 6Collaboration-Team-Backlog: Flow for users with light text on dark background, and other custom color themes - https://phabricator.wikimedia.org/T105759#1569835 (10Quiddity) [01:00:18] 10Flow, 6Collaboration-Team-Backlog: Flow for users with light text on dark background, and other custom color themes - https://phabricator.wikimedia.org/T105759#1450954 (10Quiddity) [01:02:38] 10Flow, 6Collaboration-Team-Backlog, 7Accessibility: Flow for users with light text on dark background, and other custom color themes - https://phabricator.wikimedia.org/T105759#1569837 (10Quiddity) [01:04:49] 10Flow, 3Collaboration-Team-Current, 7Regression: Pressing ESC to close VE inspector also cancels your post - https://phabricator.wikimedia.org/T110146#1569838 (10Mattflaschen) 3NEW [01:08:52] 10Flow, 6Collaboration-Team-Backlog, 7Accessibility: Flow for users with light text on dark background, and other custom color themes - https://phabricator.wikimedia.org/T105759#1569861 (10Mattflaschen) >>! In T105759#1473470, @Catrope wrote: > We probably shouldn't be setting `background: white;` on our edi... [01:09:24] (03CR) 10Legoktm: [C: 032] Added $rclass to BagOStuff lock() method to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233646 (owner: 10Aaron Schulz) [01:11:32] (03Merged) 10jenkins-bot: Added $rclass to BagOStuff lock() method to match core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233646 (owner: 10Aaron Schulz) [01:14:20] (03PS2) 10Aaron Schulz: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (owner: 10Legoktm) [01:16:39] (03CR) 10Aaron Schulz: [C: 031] Use db-replicated objectcache for storing last seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (owner: 10Legoktm) [01:29:22] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeMaintenance: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1569894 (10Mattflaschen) TLDR: Everything works fine, but it would be good to spot check (not all, just some subset) other o... [01:30:00] wgFlowOccupyChanges config change doesn't seem to have caused any regressions (I checked all the pages to verify they at least load as Flow). [01:30:13] Glad we didn't wait for the branch cut. [01:53:15] Wish the Firefox built-in web inspector wouldn't lie to me. [01:54:14] (03CR) 10Legoktm: Use db-replicated objectcache for storing last seen time (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (owner: 10Legoktm) [02:16:21] awesome, good stuff matt_flaschen :) and yeah. (what was it lying about this time?) [02:16:41] quiddity, what was inside a DOM element. [02:16:57] DomDomdommmmmmmm... [02:17:09] * quiddity hears it everytime [02:17:31] also, boxesboxesboxes. [tickytacky] [02:18:15] legoktm, do you know if there's a recommended way to add additional info to a Status? [02:18:39] matt_flaschen: $status->value ? [02:19:03] legoktm, is it okay to use that if it's a failure? [02:19:39] ehhh it depends on how you use the status :P [02:20:32] $s = Status::newFatal( 'foobar' ); $s->value = $thing; $s->isOK() <-- false; $s->hasMessage( 'foobar' ) <-- true; [02:20:46] I don't remember how that affects methods like Status::getWikiText() [02:20:48] or getHTML [02:22:26] That looks okay, as long as people don't think value !== null means OK... [02:22:32] But maybe there's another way. [02:25:10] you could also return a message object or an array? [02:39:45] legoktm, I think for my current purposes I can just add $status->getMessage()->getKey(). I didn't realize right away that was distinct, but it is. [02:40:01] I actually don't need to change the Status at all. [02:43:13] ok :) [02:44:47] I need to distinguish between the different SpamFilter failures, but this will be the only one with flow-spam-confirmedit-form. [03:45:56] (03PS1) 10Mattflaschen: Fix CAPTCHA on new editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) [03:47:21] (03CR) 10Mattflaschen: "There is a little code duplication, which would be good to avoid. Roan and I will discuss how to resolve this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [03:47:31] 10Flow, 10WMF-Server-Backports, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeMaintenance: addurl CAPTCHA broken (HTML is rendered as text and CAPTCHA always fails you even if you fill in the form right) - https://phabricator.wikimedia.org/T109554#1569986 (10Mattflaschen) [03:47:54] (03CR) 10jenkins-bot: [V: 04-1] Fix CAPTCHA on new editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [04:14:10] (03PS2) 10Mattflaschen: Fix CAPTCHA on new editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) [06:40:53] 10Echo, 6Collaboration-Team-Backlog: Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent - https://phabricator.wikimedia.org/T110158#1570163 (10Legoktm) 3NEW [06:41:03] 10Echo, 6Collaboration-Team-Backlog: Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent - https://phabricator.wikimedia.org/T110158#1570171 (10Legoktm) p:5Triage>3Lowest [06:45:02] 10Echo, 3Collaboration-Team-Current, 7Schema-change: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1570177 (10jcrespo) I performed an online ALTER TABLE, with the same structure as the or... [06:45:30] 10Echo, 6Collaboration-Team-Backlog: Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent - https://phabricator.wikimedia.org/T110158#1570180 (10Mooeypoo) I am not sure we should reflect either of those in the API (as we discussed before) the API should pro... [06:48:07] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1570194 (10jcrespo) I've performed an emergency alter following the directions of the reopened T94427, on mediawikiwiki, officewiki, metawiki and labswiki. P... [08:02:43] 10Echo, 6Collaboration-Team-Backlog: Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent - https://phabricator.wikimedia.org/T110158#1570341 (10matmarex) If you're migrating it to OOUI, then not 'overlay' please, as that has a different meaning for OOUI wi... [09:37:51] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality, and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1570507 (10Pginer-WMF) > Given where we are in the quarter, we don't have time to do any more testing on current Flow fun... [10:17:55] 10Flow, 6Collaboration-Team-Backlog: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1570594 (10Pginer-WMF) From the comments I read about the issue, the problem does not seem to be about identifying the topics as closed/collapsed (for which the lack of conte... [11:39:12] 10Flow, 6Collaboration-Team-Backlog: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1570734 (10Aklapper) It took me a while to realize that and how I can access content of resolved conversations on Flow pages and I would have appreciated a pointer. GNOME tr... [12:18:00] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1570803 (10Florian) >>! In T107835#1570194, @jcrespo wrote: > Please indicate if that helps on fixing the issue. Thanks for your work! Maybe I'm to impatien... [12:50:20] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1570865 (10jcrespo) Please also be aware that some jobs (including, probably, notifications) may have been lost for a short period of time due to an [[ https... [13:15:26] hey pginer [13:15:43] Hi Stephane [13:15:56] still need help with your mw-vagrant setup? [13:16:16] yes [13:16:43] based on what you're describing, I would probably just recreate it from scratch [13:16:53] Vagrant is like one of those teletransportation machines, great when it works but if a fly enters the cabin, I don’t know how to solve the mess [13:16:55] I'll give you the commands if you want [13:17:11] ok. That will be helpful [13:17:19] Thanks [13:17:25] `vagrant destroy` to get rid of the old on [13:17:27] one [13:17:43] this will kill the man-fly [13:18:06] ok. Destroyed [13:18:10] git pull [13:18:19] to get the new version of the machine [13:18:57] (That will also solve the issue of having to do —provision all the time) [13:19:02] done [13:19:16] ./setup.sh [13:19:19] just in case [13:19:45] ok: You're all set! Simply run `vagrant up` to boot your new environment [13:19:51] right [13:19:58] but make sure there is no fly this time [13:20:15] should I just run vagrant up ? [13:20:21] yes [13:21:43] machine booted and is mounting some virtual folders [13:22:11] The next step will be to enable the different roless, I guess [13:22:42] it could have kept your config... run `vagrant roles list` to find out [13:23:37] It is still working [13:24:13] Now it is sending very informative messages such as ==> default: Notice: /Stage[main]/Mwv/Package[build-essential]/ensure: ensure changed 'purged' to 'present' [13:30:46] 10Flow, 6Collaboration-Team-Backlog: Flow: Make Preview and Wikitext Edit available simultaneously - https://phabricator.wikimedia.org/T69258#1571005 (10He7d3r) [13:32:59] (03CR) 10Sbisson: [C: 032] Fix CAPTCHA on new editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [13:34:52] (03CR) 10jenkins-bot: [V: 04-1] Fix CAPTCHA on new editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [13:35:26] (03PS1) 10Mjbmr: Add Western Balochi namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233702 [13:36:40] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [13:45:19] It seems it remembers my roles [13:45:55] Vagrant is showing a * when listing the roles next to flow, echo and other roles I recall were enabled [13:47:03] and the wiki loads without issues [13:47:52] Thanks for the detailed instructions stephanebisson, I’ll keep them in case of future emergencies [13:48:14] pginer: great! [14:00:36] 10Flow, 6Collaboration-Team-Backlog: Change the location of Flow's timestamps within posts - https://phabricator.wikimedia.org/T108096#1571039 (10Pginer-WMF) **Problem to solve** From what I see in the description, it seems that we are talking about an activity that involves moving across different usernames a... [14:24:13] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [14:27:28] (03CR) 10Mattflaschen: [C: 032] "Per Sbisson" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [14:27:40] (03PS24) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [14:28:45] (03PS25) 10Sbisson: Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [14:29:17] (03CR) 10jenkins-bot: [V: 04-1] Fix CAPTCHA on new editors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [14:30:09] (03CR) 10jenkins-bot: [V: 04-1] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [14:37:14] stephanebisson or mlitn, do you mind being available for morning SWAT for the CAPTCHA change? [14:38:26] I'm thinking of forcing Jenkins since it's only failing on one due to an apparent CI bug (https://phabricator.wikimedia.org/T110184) and it has already passed that a couple times on this patch set. [14:39:23] matt_flaschen: that’s in 20 min? [14:39:29] I’ll be around [14:40:07] mlitn, yeah. I'll force Jenkins and list it. Thank you. [14:41:16] (03CR) 10Mattflaschen: [V: 032] "Forcing, since it is only failing on QUnit due to a bug (https://integration.wikimedia.org/ci/job/mwext-qunit/4397/console / https://phabr" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [14:44:40] (03PS1) 10Mattflaschen: Fix CAPTCHA on new editors [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233718 (https://phabricator.wikimedia.org/T109554) [14:46:18] (03CR) 10jenkins-bot: [V: 04-1] Fix CAPTCHA on new editors [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233718 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [14:49:05] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233718 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [14:56:26] 10Flow, 6Collaboration-Team-Backlog, 7Design: Editing toolbar(s) for Flow (VE and/or wikitext toolbar) - https://phabricator.wikimedia.org/T78346#1571181 (10He7d3r) See also https://www.mediawiki.org/wiki/Topic:Smsn1ofyp04kqxle. [15:05:14] (03CR) 10Alex Monk: [C: 032 V: 032] Fix CAPTCHA on new editors [extensions/Flow] (wmf/1.26wmf19) - 10https://gerrit.wikimedia.org/r/233718 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [15:10:39] This was bash worthy -- https://tools.wmflabs.org/bash/quip/AU9laGWt1oXzWjit5Ubt [15:13:12] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [15:13:38] matt_flaschen: deployed, works fine [15:41:33] 10Flow, 10Browser-Tests, 6Collaboration-Team-Backlog: Flow's Edit existing post test fails if post not in view - https://phabricator.wikimedia.org/T59702#1571315 (10zeljkofilipin) 5Open>3Invalid a:3zeljkofilipin No reply in more than a month. Resolving as invalid. Please reopen if this is still a problem. [15:46:58] 10WikiLove, 10Browser-Tests, 6Collaboration-Team-Backlog: Update WikiLove repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99660#1571336 (10zeljkofilipin) p:5High>3Normal [15:47:02] 10WikiLove, 10Browser-Tests, 6Collaboration-Team-Backlog: Update WikiLove repository to mediawiki_selenium Ruby gem 1.1 - https://phabricator.wikimedia.org/T99660#1571339 (10zeljkofilipin) p:5Normal>3High a:3zeljkofilipin [15:50:06] (03CR) 10Raimond Spekking: [C: 032] Add Western Balochi namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233702 (owner: 10Mjbmr) [15:52:12] (03Merged) 10jenkins-bot: Add Western Balochi namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233702 (owner: 10Mjbmr) [16:09:43] mooey|away: I thought about it a bit more, and making two parallel API requests seems silly. We should just add a &markseen=1 parameter to action=echomarkread that updates it. [16:18:51] matt_flaschen: what's the php command to trigger the opt-in guided tour? [16:43:52] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: 14 Chrome browser test failures - https://phabricator.wikimedia.org/T109785#1571880 (10SBisson) I am able to run all tests with chrome # locally # locally against beta # in saucelabs The only test that is failing for me is `features/descr... [16:47:04] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeMaintenance: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1571895 (10DannyH) [16:47:05] 10Flow, 3Collaboration-Team-Current: flow-action-unsupported only content on en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA - https://phabricator.wikimedia.org/T109982#1571893 (10DannyH) 5Open>3Resolved [17:01:03] stephanebisson, mooeypoo and I were talking (partly async), and I think the best way is for you set a custom cookie. E.g. WebResponse->setcookie( '-flow-opt-in-user-talk', 1 ) (the leading dash is to take into account the auto-prefixing) [17:02:08] matt_flaschen: sounds good but I think it should be part of the guided tour task [17:02:16] stephanebisson, that's fine. [17:02:29] or whichever task is mergged last so it can be tested [17:02:38] (can get the response from $wgOut->getRequest()->response(), and can also get the request from a ContextSource). [17:02:59] n.b. should be '1', not 1 [17:04:05] WorkTypeNewFunctionality has been poping up everywhere on our tickets... [17:04:19] I think it is slightly abused [17:06:21] 10Echo, 6Collaboration-Team-Backlog: Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent - https://phabricator.wikimedia.org/T110158#1572020 (10Mattflaschen) Popup is fine. Agreed it should not be in the API response. [17:11:14] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1572034 (10Mattflaschen) [17:13:48] (03PS2) 10Legoktm: [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) [17:15:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up and refactor formatting system [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [17:19:22] 10Flow, 6Collaboration-Team-Backlog, 7Accessibility: Flow for users with light text on dark background, and other custom color themes - https://phabricator.wikimedia.org/T105759#1572262 (10Elvey) FYI, the biggest advantage of OLED displays, which are becoming steadily more prevalent (Samsung phones and table... [17:21:55] 10Flow, 6Collaboration-Team-Backlog: Change the location of Flow's timestamps within posts - https://phabricator.wikimedia.org/T108096#1572281 (10DannyH) Yeah, I think moving the timestamp closer to the username makes sense. I'm not sure about how that would work with the hover state -- both the name and the... [17:23:34] (03CR) 10Legoktm: "PS2 changes:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [17:24:19] 10Flow, 6Collaboration-Team-Backlog: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1572294 (10DannyH) Pau -- yes, I think your analysis of the situation is correct. The problem is helping people to understand that there's hidden content that they can access. [17:25:41] (03PS1) 10Sbisson: Browser tests: handle empty board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233754 [17:26:20] 10Flow, 6Collaboration-Team-Backlog: Permalink mw-ui-icon-link button displays tooltip(s) in lower case - https://phabricator.wikimedia.org/T110211#1572314 (10Etonkovidova) 3NEW [17:27:42] (03Abandoned) 10Legoktm: Get rid of API action=echomarkseen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223468 (owner: 10Legoktm) [17:28:51] 10Echo, 6Collaboration-Team-Backlog: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1572362 (10Legoktm) 3NEW [17:29:25] 10Echo, 3Collaboration-Team-Current, 7Schema-change: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1572373 (10Mattflaschen) >>! In T94427#1570177, @jcrespo wrote: > Please indicate if we... [17:32:44] (03CR) 10Pginer: "Regarding the discrepancy between the no-JS and regular versions. The issue seems that a different set of classes are applied to the eleme" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [17:34:18] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1572415 (10Mattflaschen) I got one apparent success 8 hours ago, but I'm still testing. [17:35:10] (03PS2) 10Matthias Mullie: [WIP] Fix references/storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233432 (https://phabricator.wikimedia.org/T94569) [17:36:04] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Port remaining editor uses to EditorWidget - https://phabricator.wikimedia.org/T109000#1572419 (10Catrope) a:5Catrope>3None [17:38:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fix references/storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233432 (https://phabricator.wikimedia.org/T94569) (owner: 10Matthias Mullie) [17:43:09] 10Flow, 3Collaboration-Team-Current: Clicking "reply" on specific posts in Flow, will open multiple edit-areas - https://phabricator.wikimedia.org/T110219#1572456 (10Quiddity) 3NEW [17:43:34] 10Flow, 3Collaboration-Team-Current: Clicking "reply" on specific posts in Flow, will open multiple edit-areas - https://phabricator.wikimedia.org/T110219#1572464 (10Quiddity) [17:50:12] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeNewFunctionality: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1572483 (10Mattflaschen) [17:51:00] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeNewFunctionality: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1572487 (10Mattflaschen) 5duplicate>3Open [17:51:29] 10Flow, 3Collaboration-Team-Current: Clicking "reply" on specific posts in Flow, will open multiple edit-areas - https://phabricator.wikimedia.org/T110219#1572456 (10Mattflaschen) [17:51:29] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeNewFunctionality: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1558118 (10Mattflaschen) [17:52:06] (03PS1) 10Legoktm: [WIP] Add markseen support to API action=echomarkread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233757 (https://phabricator.wikimedia.org/T110216) [17:54:12] (03CR) 10Catrope: [C: 032] Browser tests: handle empty board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233754 (owner: 10Sbisson) [17:55:09] (03CR) 10Catrope: [C: 031] Use mw.Api#postWithToken for echomarkseen requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233640 (owner: 10Legoktm) [17:55:32] (03CR) 10Catrope: "Let's rebase+squash this into Moriel's commit" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233640 (owner: 10Legoktm) [17:56:40] (03Merged) 10jenkins-bot: Browser tests: handle empty board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233754 (owner: 10Sbisson) [17:56:50] 10Flow, 6Collaboration-Team-Backlog: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#1572521 (10Mattflaschen) [18:03:17] (03PS2) 10Matthias Mullie: Create all templates Flow uses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232489 (https://phabricator.wikimedia.org/T105421) [18:04:40] 3Collaboration-Team-Current: wikibugs test bug - https://phabricator.wikimedia.org/T1152#1572559 (10Legoktm) [18:05:22] 3Collaboration-Team-Current, 10Wikibugs, 5Patch-For-Review: Add Collaboration-Team-Current to #wikimedia-collaboration - https://phabricator.wikimedia.org/T110186#1572562 (10Legoktm) 5Open>3Resolved a:3Legoktm [11:04:18] !log tools.wikibugs Updated channels.yaml to: a541227fe36479f99a74f8d56... [18:16:53] (03PS3) 10Matthias Mullie: Create all templates Flow uses [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232489 (https://phabricator.wikimedia.org/T105421) [18:56:18] stephanebisson, yeah, we talked about it a while back (I even went around correcting a couple), not sure if it's in your scrollback. Basically, AFAICT, WorkTypeMaintenance actually means WorkTypeInterrupt (something that comes up all of a sudden, e.g. an unbreak now or an urgent request from another team) and WorkTypeNewFunctionality is everything else. Not how I would do it either. [18:57:20] matt_flaschen: yeah, I just hope nobody is acting on those "metrics" [18:57:49] but still, many are wrong based on that definition [18:58:42] James_F said it's currently an experiment. [19:00:30] (03CR) 10Hashar: "You should refrain from force merging, or you have no way to ensure the mwext-qunit job is actually passing!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [19:04:04] (03CR) 10Mattflaschen: "> You should refrain from force merging, or you have no way to ensure the mwext-qunit job is actually passing!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233660 (https://phabricator.wikimedia.org/T109554) (owner: 10Mattflaschen) [19:05:59] marxarelli: Hi [19:06:11] stephanebisson: hey! [19:06:25] marxarelli: quick browser-test question for you... [19:07:29] marxarelli: when I run with chrome, the browser window is almost full screen, with firefox it's pretty small, and it causes some elements to be offscreen and it fails [19:07:32] any idea why? [19:07:50] locally, or through ci? [19:07:59] marxarelli: locally [19:08:08] but I suspect the same is happening in ci [19:08:51] not sure why the firefox browser would open at an unusually small size [19:08:58] how small are we talking? [19:09:22] square, about 80% of screen height [19:09:38] not like small small but it's a bit too small [19:10:12] and some elements are off to the right/left? [19:10:59] down [19:11:26] and it doesn't scroll them into view [19:13:17] hmm. sounds like you'll want to scroll the element into view [19:13:28] rather than make the browser taller [19:14:14] as the latter would be affected by the constraints of a user's resolution, and web pages generally shouldn't really care about browser height [19:14:50] if it were a horizontal sizing issue, i'd say enforce a minimum resolution with `browser.window.size` and `browser.window.resize_to` [19:14:52] that would make sense [19:15:19] the driver is supposed to scroll stuff into view already, the chrome driver does that very well, and the firefox one does 'sometimes' [19:16:19] right, i'm pretty sure that's the case for click actions at least [19:16:39] 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Fix new topic notification on MediaWiki.org - https://phabricator.wikimedia.org/T107835#1572854 (10Mattflaschen) I got the two tests I did then (as a bundled, since they were to the same page). And there's nothing in the current exception.log.... [19:16:59] I can try to do it specifically in some cases to ensure the menu has enough room to open and be all visible [19:18:56] I have a button that opens a menu and another button that is an option within that menu [19:19:39] the first button is already on screen, it opens the menu but the menu is partly offscreen and it fails to interact with the last open in the menu [19:21:38] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-T-2015-04-08, 10Echo, 7Schema-change: Perform schema change to echo_target_page changing from a 1 to 1 mapping between pages and user/notification to a 1 to many. - https://phabricator.wikimedia.org/T94427#1572878 (10Mattflaschen) >>! In T94427#15701... [19:28:21] stephanebisson, did you (or someone) fix the other 13 tests, or is it really just that unreliable? [19:28:59] matt_flaschen: I updated a bunch to work with the new editor (merged yesterday) but there's also some luck [19:29:45] and I'm currently fixing some more to work on firefox, thanks to marxarelli [19:30:21] * marxarelli doesn't feel like he's helped much :) [19:30:26] matt_flaschen: and I fixed another one today (description:10) and it was merged [19:31:12] marxarelli: I needed to be told the obvious: of course I have to scroll to make them reliable [19:31:28] stephanebisson, yeah, I saw the description one. [19:31:30] marxarelli, thank you too. [19:32:30] no problem [19:33:39] 6Collaboration-Team-Backlog, 10Flow: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" - https://phabricator.wikimedia.org/T109750#1572930 (10Etonkovidova) [19:34:20] Think we should ask for a window earlier for https://phabricator.wikimedia.org/T109748 or wait until 4 PM Pacific? [19:36:14] (03CR) 10Mattflaschen: [C: 032] "Per Matthias (branch cut is done)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [19:37:51] (03CR) 10Mattflaschen: "Branch cut is done." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) (owner: 10Mattflaschen) [19:38:38] 3Collaboration-Team-Current, 10Flow, 7WorkTypeNewFunctionality: Tweak importer to allow converting opt-out wikis (LQT->Flow) - https://phabricator.wikimedia.org/T109931#1572958 (10SBisson) a:3SBisson [19:47:03] (03Merged) 10jenkins-bot: Segregate Reference objects by source wiki. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [19:56:49] 3Collaboration-Team-Current, 10Flow, 7Blocked-on-Operations, 5Patch-For-Review, and 2 others: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1573004 (10Mattflaschen) @Etonkovidova This is a multi-phase task. You can do regression testing now and look at the DB, but it will o... [20:00:23] (03PS7) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:01:46] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [20:02:10] After updating Flow, you should run: [20:02:12] vagrant git-update [20:02:36] or otherwise run update.php for the separate 'separate reference tables' patch. [20:16:50] matt_flaschen, I pushed a fix for the guided tour, but it's a blind fix, because vagrant just crapped out on me [20:17:02] mooeypoo, okay, will review later today. [20:17:08] matt_flaschen, also, I think I'm doing the cookie wrong. Should I even handle it directly? I couldn't find mw stuff for it in the documentation [20:17:14] but I assume MW *has* something for cookies [20:17:26] mooeypoo, yeah, it does. You use WebResponse. [20:17:40] WebResponse->setcookie (you can spell it setCookie if you prefer ...) [20:17:49] matt_flaschen, ooh awesome, I'll read about it now [20:18:02] btw, do we have some basic naming styles for cookies? I just invented a name [20:18:20] "mw_Flow_optIn_guidedTour" [20:21:00] mooeypoo, there's sort of a convention of using SnakeCase, but it's not done everywhere (GuidedTour itself uses dashes). Also, you don't need mw_ since it's auto-prefixed. [20:21:14] oh, ok [20:24:43] (03PS8) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:25:39] (03PS9) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:25:43] matt_flaschen, fixed, I think. [20:28:45] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [20:32:57] (03PS10) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:36:23] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [20:38:15] (03PS11) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:40:29] (03CR) 10jenkins-bot: [V: 04-1] [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [20:43:19] 3Collaboration-Team-Current, 10Flow, 7WorkTypeMaintenance: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1573145 (10Etonkovidova) Checked mediawikiwiki_p and enwiki_p from the list on https://gerrit.wikimedia.org/r/#/c/228271/2/wmf-config/Initial... [20:44:22] (03PS12) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:44:29] * mooeypoo stares at Jenkins intently [20:46:52] \o/ [20:47:06] (03PS13) 10Mooeypoo: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [20:47:26] https://i.imgur.com/zuGQrYX.png [20:58:44] 6Collaboration-Team-Backlog, 10Flow: Flow: username links for post-author have an extra space attached - https://phabricator.wikimedia.org/T72214#1573214 (10Quiddity) 5Open>3Invalid a:3Quiddity Fixed at some point in the past. Closed as invalid. [20:59:18] 6Collaboration-Team-Backlog, 10Flow: Clicking "reply" on specific posts in Flow, will open multiple edit-areas - https://phabricator.wikimedia.org/T110219#1573218 (10SBisson) [21:04:24] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1573245 (10Mooeypoo) The guided tour commit now checks if a Flow-specific cookie exists before it loads itself. We should, in a followup c... [21:04:48] hm actually [21:05:13] matt_flaschen, actually, I think I"m missing another thing here. I am, on the server side, checking to see if we're in the right page + have the cookie and then load flow opt-in guided tour [21:05:32] but I need to also *start* it [21:06:06] matt_flaschen, but then, if I am clearing that cookie in the back end, I lose the option to check and activate in the front end -- unless I also set up the guided tour cookie [21:07:20] so matt_flaschen, which is better: 1) In the back end check for the Flow-specific cookie to register+load the module, but not delete it, then in the front end, check for that cookie, start the tour, and delete the cookie. *or* 2) Do everything from the back end, including setting up the guided tour cookie, and then (assuming that works?) have the guided tour itself delete after it's done. [21:07:37] #2 saves us from doing anything in the front end, but may be a bit more risky because it involves 2 cookies. [21:07:48] The GuidedTour normally kills its cookie when it's done. One sec. [21:15:56] 6Collaboration-Team-Backlog, 10Flow: Change the location of Flow's timestamps within posts - https://phabricator.wikimedia.org/T108096#1573287 (10Quiddity) Re: timestamp //placement// - The main reason for placing it on the opposite side, are so that All the timestamps (in a topic, or a page) can easily be ski... [21:16:51] mooeypoo, I'm sorry, it's been a while since I worked on GuidedTour, so I think I forgot that detail. [21:17:07] mooeypoo, I guess you tested and adding the module does not auto-start the tour, right? [21:19:23] I'm testing now. [21:19:28] But I'm pretty sure it doesn't. [21:21:29] is somebody flowifying my user talk pages here and there? :) [21:21:35] and everywhere? [21:22:09] mooeypoo, I think #2 is simpler despite the two cookies. I need to make the change I thought I had to originally to GuidedTour, so you don't have to re-implement the cookie logic. [21:27:43] mooeypoo, could you try https://gerrit.wikimedia.org/r/#/c/233851/ ? [21:28:04] GuidedTourHooks::addTour( $outputPage, $tourName ) [21:28:27] And then just delete the custom cookie immediately after that. [21:30:41] mooeypoo, sorry, that's not right. [21:35:05] that's not right? [21:37:57] mooeypoo, my commit. [21:37:58] Fixing it now. [21:38:20] aharoni, Danny might be. (Are you requesting, or are asking because it has been happening recently? :) [21:38:37] has beeh happening [21:38:55] ah, yes. I think Danny is doing a batch of the requests, this afternoon. [21:39:26] hmm hmm hmm https://www.wikidata.org/w/index.php?title=User_talk:Amire80&action=history [21:40:34] Hmm! dannyh ^ Were there problems at aharoni's usertalkpage at wikidata? [21:40:51] yeah, it was the "separate reference tables" problem [21:41:12] it moved his wikitext page but couldn't create the board -- I think a conflict between French and Wikidata or something [21:41:27] aharoni, that's https://phabricator.wikimedia.org/T107204 [21:41:34] when the "separate ref" fix is released, should be able to do it for real [21:41:46] ty dannyh :) [21:41:49] oh, hi aharoni I didn't scroll up and see the rest of the conversation :) [21:42:08] -- [21:42:08] dev question: "On my wiki the JS runs after the window is done. This leads to annoying visible changes like the time ago conversion.. How can I add position top to the RL modules in Flow?" -- Either tell me the answer for copy-pasting, or answer directly at https://www.mediawiki.org/wiki/Topic:Snov6y16qryz6btt please and thanks :) [21:42:24] aharoni yeah, catching up -- it's done I think on all except Wikidata because reasons [21:46:26] matt_flaschen, yeah I"m getting a lot of js errors with this patch about flowOptIn guided tour not existing -- I"m not sure if this is because of something in your patch or mine [21:46:57] mooeypoo, hmm, actually it should still exist, but disregard, since I'm doing the patch differently anyway. [21:47:12] * mooeypoo nods [21:51:17] 6Collaboration-Team-Backlog, 10Flow, 7Design: Flow: Preview message looks like an error and has question mark cursor - https://phabricator.wikimedia.org/T75679#1573421 (10Quiddity) 5Open>3Invalid a:3Quiddity Resolving, because we no longer have a wikitext-preview. There is only a switcheditor button, w... [21:56:24] mooeypoo: just FYI: https://developers.google.com/web/updates/2015/03/push-notificatons-on-the-open-web [22:02:16] quiddity: Krinkle kind of killed the position=top concept [22:02:20] We should fix the FOUC issues instead [22:02:36] Or flash of unconverted timestamp in this case [22:12:10] (03PS14) 10Mooeypoo: [wip] Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [22:16:21] RoanKattouw, not sure how that would be done. Maybe it's better for the timestamp to appear delayed rather than show unconverted, then converted, though. [22:16:59] But why are we recomputing the timestamp client-side at all? [22:17:02] I filed a bug about that [22:17:24] The server-side computation should be good enough (and in prod is actually more accurate because it doesn't ignore the user's tz pref) [22:17:37] (03PS1) 10Mooeypoo: [wip] Activate guided tour from opt in process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233868 (https://phabricator.wikimedia.org/T98270) [22:17:40] (03CR) 10jenkins-bot: [V: 04-1] [wip] Activate guided tour from opt in process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233868 (https://phabricator.wikimedia.org/T98270) (owner: 10Mooeypoo) [22:20:06] RoanKattouw, because we update it as you sit on the page. Plus it should be cached for anons, so if there's relative time, you can't just show them the reltime from when it was cached. [22:31:38] mooeypoo, sorry, updated the GuidedTour patch: https://gerrit.wikimedia.org/r/#/c/233851/ [22:31:40] Should be: [22:32:09] GuidedTourLauncher::launchTourByCookie( 'flowOptIn', 'newTopic' ); [22:32:26] And you don't need to add the tour module since it takes care of that. [22:59:24] 6Collaboration-Team-Backlog, 10Flow, 7Design: Change the button in Flow to something more intuitive, perhaps a text label for the button - https://phabricator.wikimedia.org/T110259#1573624 (10Quiddity) 3NEW [23:01:11] (03PS30) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [23:02:35] 6Collaboration-Team-Backlog, 10Flow, 7Design: Change the button in Flow to something more intuitive, perhaps a text label for the button - https://phabricator.wikimedia.org/T110259#1573636 (10Quiddity) Subfader in the first example, links to https://www.goodui.org/#47 ("Try **Icon Labels** instead of ope... [23:03:25] quiddity: I think that's a dupe of or strongly related to Danny's "make switch to VE button more discoverable" [23:03:43] i looked for that, but couldnt find. thanks! [23:03:53] He filed it like a few days ago [23:03:56] * quiddity shakes fist at phab search [23:05:20] found it, merging [23:05:44] (03PS15) 10Mooeypoo: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [23:05:49] matt_flaschen, ^ woot [23:06:02] 6Collaboration-Team-Backlog: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1573653 (10Quiddity) [23:06:06] 6Collaboration-Team-Backlog, 10Flow, 7Design: Change the button in Flow to something more intuitive, perhaps a text label for the button - https://phabricator.wikimedia.org/T110259#1573651 (10Quiddity) [23:06:40] (03PS16) 10Mooeypoo: Create a guided tour for first-time users [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) [23:06:53] 6Collaboration-Team-Backlog: Make the VE/source toggle more discoverable - https://phabricator.wikimedia.org/T101316#1335689 (10Quiddity) Copy from merged task: The switcheditor button, for switching between wikitext and visual editor modes, is currently not intuitive. Experienced editors who want to write thei... [23:06:57] :) [23:10:12] mooeypoo, there is a convention that we're supposed to have ops look at cookie changes (due to some Unfortunate Events). I don't think this cookie name has any of the magic strings that break everything, but I'll add them nonetheless. [23:13:18] (03CR) 10Mattflaschen: "Needs cookie review by ops." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [23:14:34] 3Collaboration-Team-Current, 10Flow, 7Blocked-on-Operations, 5Patch-For-Review, 7WorkTypeNewFunctionality: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1573666 (10Mattflaschen) Can ops double-check the cookie name (https://gerrit.wikimedia... [23:16:50] (03CR) 10BBlack: [C: 031] "Flow_optIn_guidedTour is not a problematic cookie name" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [23:17:43] 3Collaboration-Team-Current, 10Flow: EnableFlow -- don't copy "welcome" templates into the siderail during conversion - https://phabricator.wikimedia.org/T110261#1573675 (10DannyH) 3NEW [23:27:21] matt_flaschen, awesome, we got an approval \o/ [23:27:38] also, I added the setting of the cookie as a dependent commit on top of stephane's commit [23:27:51] Sounds good [23:28:11] matt_flaschen, and your GuidedTour fix wfm. Should I +2 ? [23:28:20] mooeypoo, no, I'm going to add tests. [23:28:31] oh, tests, I forgot about those. [23:28:36] * mooeypoo stands in the corner [23:29:35] Not sure if I should change it to a singleton (rather than static). Probably won't unless someone thinks it's worth it. [23:29:47] It's still testable as is, just not mockable. [23:30:47] 3Collaboration-Team-Current, 10Flow, 7Blocked-on-Operations, 5Patch-For-Review, 7WorkTypeNewFunctionality: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1573701 (10Mattflaschen) Cookie name reviewed. [23:31:00] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkTypeNewFunctionality: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1573702 (10Mattflaschen) [23:31:04] ok I"m testing the cookie creation, which, incidentally, will also test the opt in feature in general [23:35:23] hm, I don't have flow in beta features. What am I doing wrong.... [23:36:14] 6Collaboration-Team-Backlog, 10Echo: Figure out whether the Echo notification popup is called a "flyout" or "overlay" and make usage consistent - https://phabricator.wikimedia.org/T110158#1573717 (10Quiddity) The documentation all calls it a flyout. According to https://en.wikipedia.org/wiki/Web_navigation#St... [23:36:28] found it [23:36:57] (03PS3) 10Aaron Schulz: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [23:42:56] my brain is full. https://s-media-cache-ak0.pinimg.com/736x/18/07/24/1807241efbce79660f587e80212b9935.jpg [23:43:08] (03CR) 10Mooeypoo: [C: 04-1] "I tested and ran into a problem:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) (owner: 10Sbisson) [23:49:39] (03CR) 10Aaron Schulz: [C: 032] Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [23:50:43] (03PS4) 10Aaron Schulz: Use db-replicated objectcache for storing last seen time [extensions/Echo] - 10https://gerrit.wikimedia.org/r/233639 (https://phabricator.wikimedia.org/T95839) (owner: 10Legoktm) [23:54:48] I put up a change to have Flow depend on BetaFeatures in MWV. [23:54:57] https://gerrit.wikimedia.org/r/#/c/233881/ [23:59:01] (03PS31) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190)