[00:01:34] (03CR) 10Legoktm: [wip] Split alerts and messages in Echo (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [00:02:20] mooeypoo: you probably want to copy my cache invalidation part of https://gerrit.wikimedia.org/r/#/c/232872/1/includes/model/Notification.php,cm [00:06:27] Also, I just noticed I'm not storing the boolean in the cache, so it will never be fetched. Fixing that too [00:12:39] meh it doesn't work now. Whaaat [00:14:37] meh, the memcache value is always false. [00:21:45] (03PS17) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [00:22:17] legoktm, this works now. Apparently, memcache retusn "false" when something doesn't exist... bah. Also, boo, no 'undefined' in php [00:22:56] You can use `null` [00:23:42] legoktm, I just casted to numbers [00:23:52] 0 or 1 in the cache, casted back into boolean in the method response [00:24:09] Some cache backends return false for missing keys, some return null [00:24:13] (yay :S ) [00:24:17] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [00:24:21] so "false" means the value doesn't exist--- wait, what? [00:25:00] (03PS18) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [00:26:20] mooeypoo, you can probably just set 1 in the cache, and if get() returns truthy treat is as 'they have messages'. [00:27:13] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [00:27:56] legoktm, it seems to not clearing the cache correctly for me [00:28:33] Are you updating the cache or deleting it? [00:29:52] Oh, use $wgMemc, not wan cache [00:30:15] I'm using wfMemcKey [00:30:22] which is what the other methods in this class seem to use [00:30:23] not good? [00:30:44] legoktm, everything works correctly for a first-time user and a user with messages [00:30:57] shouldn't be using wfGetCache( $wgSomeCacheType ) rather than wgMEmc? [00:31:08] however, if I use my existing user to post a topic in the new user's talk page, I still get 'hasEverHadMessages' as false [00:32:40] mooeypoo: you should call something like $wgMemc->set( $key, 1, 86400 ) instead of the WANCache stuff [00:32:56] (and ->get() as well) [00:33:04] legoktm, I'm not using WANCache at all [00:33:34] https://gerrit.wikimedia.org/r/#/c/231200/18/includes/NotifUser.php,cm [00:33:42] 296 +» public function clearHasEverHadMessages() { [00:33:43] 297 +» » ObjectCache::getMainWANInstance()->delete( $this->getHasEverHadMessagesKey() ); [00:33:43] 298 +» } [00:33:55] legoktm: She blames you for that : [00:33:57] :P [00:34:00] Apparently she copied it from your code [00:34:08] lol [00:34:10] yes and I am silly, I didn't notice there's "$this->cache" [00:34:15] in NotifUser [00:34:34] Ha I missed that too [00:35:52] meh, still not working [00:46:43] legoktm, update: I'm an idiot. I used wfMemcKey() nested inside a wfMemcKey() ! \o/ [00:51:24] it woooorks [00:52:01] (03PS19) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [00:52:27] legoktm, if you're curious, see the diff between ps 18 and 19, and laugh at me to your php's heart's content. [00:52:35] ;) [00:52:40] mooeypoo, PHP has no heart. [00:52:44] I learned that a long time ago. [00:53:01] matt_flaschen, you're right. I meant to say "your php'ed heart's content" [00:53:21] wait wait, does a PHP heart look like < [00:53:24] I ruined my own joke with a premature line break. [00:53:43] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [00:55:27] And with that, I bid you good night. [00:55:30] see you tomorrow [01:00:15] i think something horrible is flowering in my vicinity. that or i shouldn't have gone near yesterday. my sinuses are not my friends. [01:00:26] * quiddity gets more water, and collapses again. [01:38:14] (03PS1) 10Catrope: Don't open two editors when clicking a nested reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232881 (https://phabricator.wikimedia.org/T109748) [01:44:47] (03PS1) 10Catrope: Use moveCursorToEnd from OOjs UI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232883 [01:45:15] (03CR) 10Catrope: [C: 04-2] "Do not merge until the next OOUI release" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232883 (owner: 10Catrope) [03:20:46] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T97290#1559656 (10Catrope) [03:21:13] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T97290#1238153 (10Catrope) >>! In T97290#1558144, @Catrope wrote: > I haven't yet figured out why focusing VE doesn't w... [03:49:08] 10Flow, 6Collaboration-Team-Backlog, 7Parsoid-Nowiki: Flow puts nowiki around a mailto: link with spaces in query string - https://phabricator.wikimedia.org/T109806#1559674 (10Spage) 3NEW [07:40:37] 10Flow, 6Collaboration-Team-Backlog: Links from Flow topics to special pages are incorrectly included in link tables - https://phabricator.wikimedia.org/T109814#1559881 (10TTO) 3NEW [09:55:37] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog: Install PageTriage on fa.wp - https://phabricator.wikimedia.org/T109820#1560055 (10Ladsgroup) 3NEW [09:55:59] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog: Install PageTriage on fa.wp - https://phabricator.wikimedia.org/T109820#1560063 (10Ladsgroup) [09:56:02] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog, 7I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552#1560064 (10Ladsgroup) [09:57:30] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog, 10Wikimedia-Site-Requests: Install PageTriage on fa.wp - https://phabricator.wikimedia.org/T109820#1560066 (10Krenair) I happened to see this because I was looking at the feed in #wikimedia-dev. Please see https://meta.wikimedia.org/wiki/Reque... [09:59:05] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog, 10Wikimedia-Extension-setup, 10Wikimedia-Site-Requests: Install PageTriage on fa.wp - https://phabricator.wikimedia.org/T109820#1560069 (10Krenair) [10:03:13] 10MediaWiki-extensions-PageCuration, 6Collaboration-Team-Backlog, 10Wikimedia-Extension-setup, 10Wikimedia-Site-Requests: Install PageTriage on fa.wp - https://phabricator.wikimedia.org/T109820#1560076 (10Ladsgroup) Thanks @Krenair but It seems to be a complicated problem in T50552 that prevents us to enab... [12:28:03] 10Flow, 6Collaboration-Team-Backlog, 10Wikidata, 10Wikidata.org: Enable Flow for Wiki Loves Open Data discussion page - https://phabricator.wikimedia.org/T107584#1560323 (10Qgil) Requested in https://www.wikidata.org/wiki/Wikidata:Flow#Community_page [12:31:51] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1560337 (10SBisson) > enables + disables + enables again, they probably shouldn't get the guided tour twice. Is that possible? I think so. @Mattflaschen and @Mooeypoo... [14:17:15] 10Flow, 3Collaboration-Team-Current: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1560559 (10matthiasmullie) I believe I've figured out why this is happening (see below), but I'm still working on it. * FeatureIndex::onAfterInsert (the o... [14:27:29] (03PS14) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [16:40:55] (03CR) 10Mooeypoo: Create a guided tour for first-time users (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [16:47:33] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 5WMF-deploy-2015-08-25_(1.26wmf20): Add width-expanding toggle on Topic pages - https://phabricator.wikimedia.org/T103584#1560897 (10Etonkovidova) Checked in betalabs - tooltips "Read at fixed width" and "Read at... [16:54:10] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1560925 (10DannyH) [16:54:27] 10Flow, 10Wikimedia-Extension-setup, 3Collaboration-Team-Current: Enable Extension:Flow on se.wikimedia.org and convert LQT->Flow - https://phabricator.wikimedia.org/T106302#1560927 (10DannyH) [16:54:29] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1560926 (10DannyH) 5Open>3Resolved [16:54:46] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1443434 (10DannyH) [16:55:47] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 5WMF-deploy-2015-08-25_(1.26wmf20): Add width-expanding toggle on Topic pages - https://phabricator.wikimedia.org/T103584#1560945 (10DannyH) 5Open>3Resolved [17:11:32] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): Missing preventDefault on 'preview the result' - https://phabricator.wikimedia.org/T109664#1561038 (10Etonkovidova) Checked in betalabs - flow-ui-wikitextEditorWidget-label-preview works smoothly. [17:33:03] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1561170 (10Mattflaschen) a:3Catrope [17:33:53] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): Missing preventDefault on 'preview the result' - https://phabricator.wikimedia.org/T109664#1561178 (10DannyH) 5Open>3Resolved [17:34:34] 10Flow, 3Collaboration-Team-Current: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1561185 (10Catrope) a:3Mattflaschen [17:44:39] (03CR) 10Mattflaschen: [C: 032] Cleanup debugging code for isTalkpageManagerUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232576 (https://phabricator.wikimedia.org/T109063) (owner: 10Mattflaschen) [17:45:29] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T97290#1561248 (10Jdforrester-WMF) [17:45:57] mooeypoo, yeah, it will auto-add the tour module from the cookie. [17:46:36] matt_flaschen, but I still need to register it conditionally, no? [17:48:07] (03Merged) 10jenkins-bot: Cleanup debugging code for isTalkpageManagerUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232576 (https://phabricator.wikimedia.org/T109063) (owner: 10Mattflaschen) [17:49:42] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Allow user to create new board at Special:EnableFlow without description - https://phabricator.wikimedia.org/T108348#1561260 (10Mattflaschen) a:5Mattflaschen>3None [17:50:48] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Allow user to create new board at Special:EnableFlow without description - https://phabricator.wikimedia.org/T108348#1518743 (10Mattflaschen) [17:59:33] matt_flaschen: if you can help with creating a board without description later today, you can do so on Special:EnableFlow. Whatever you end up with will be reused (or reusable) from my end and it might be simpler for you to dive into. [18:01:00] stephanebisson, okay. I'll take a look at your code first, but I may take that approach. [18:02:23] mooeypoo, I think it should work to add the cookie when they enable it for the first time, then stop the tour (by returning from the function rather than defining it) if it's not their user talk page. [18:06:00] mooeypoo, actually, your way is better. I would set a separate cookie (not the standard GuidedTour one) when they first enable the tour, then if it's their user talk page and that separate cookie is set, kill the separate cookie and add the tour. [18:06:09] mooeypoo, I'll put up a minor change to GuidedTour to allow that. [18:07:10] mooey|away, never mind, we don't need to change to GuidedTour, you can just call addModules after killing the other cookie. [18:11:46] (03PS15) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [18:17:54] (03PS20) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [18:19:51] (03CR) 10jenkins-bot: [V: 04-1] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:20:03] (03PS21) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [18:20:26] (03PS16) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [18:22:20] (03CR) 10jenkins-bot: [V: 04-1] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:33:23] (03PS17) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [18:42:55] (03PS22) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [18:43:58] (03CR) 10jenkins-bot: [V: 04-1] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:44:02] (03PS23) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [18:45:51] (03CR) 10jenkins-bot: [V: 04-1] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [18:46:46] crap [18:47:07] 18:45:26 1) ResourcesTest::testMissingDependencies [18:47:07] 18:45:26 The module 'ext.echo.base' required by 'mobile.notifications.overlay' must exist [18:47:07] 18:45:26 Failed asserting that an array contains 'ext.echo.base'. [18:48:29] I renamed modules, which means ext.echo.base is no longer there. What do I do? [18:48:37] RoanKattouw_away, matt_flaschen help [18:50:30] mooeypoo, looking. [18:50:51] It sounds like this is on mobile frontend [18:51:23] thing is... if I need to change it in mobile frontend, then how do we merge both? I mean, mobile frontend would fail because the new module isn't merged in Echo, but echo would fail because mobile frontend requires the old module. [18:51:44] Also, FOOOOOOO do we need to split notifications there too!? [18:52:54] mooeypoo, if you want to do it nicely (without forcing), you can do it in three steps: [18:53:08] * Include a no-op ext.echo.base module in your split commit. [18:53:41] * Put up a separate MobileFrontend commit to fix the dependency. [18:53:56] * Remove the no-op ext.echo.base in a third commit. [18:54:13] All of these should preferably make the same branch cut, so there should be notes pointing between them. [18:56:05] mooeypoo, also, when removing modules you need to check that there are no addModules or addModuleStyles calls directly naming the module for anon users. [18:56:18] (03PS18) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [18:56:20] If there are, you need to take special provisions to avoid cached HTML causing problems. [18:56:30] In this case it's okay since the only such mention is in logged-in HTML. [18:58:14] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1561503 (10Mattflaschen) Good to have another two-pointer done. [19:02:38] matt_flaschen: i was able to make it work with $description = ' '; [19:02:56] I don't like it but I don't like going crazy either [19:03:58] stephanebisson, yeah, I will spend some more time working on trying to allow it with no description, but try not to get too bogged down. [19:04:42] the edit-header actions appear in history as the current user, not TalkpageManagerUser [19:05:13] stephanebisson, is that on purpose, or not? [19:06:05] yes. but that's not what I want. I would prefer everything, all the moved and edit, to be done by TPMU [19:06:25] $loader->handleSubmit needs a context, I give it RequestContext::getMain() and that's the user it has [19:06:36] I was not able to successfully create a context [19:09:16] stephanebisson, this should work: [19:09:33] $context = new DerivativeContext( RequestContext::getMain() ); [19:09:53] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: We should update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1561523 (10Catrope) >>! In T105421#1556793, @matthiasmullie wrote: > Below is the content of all import-related... [19:10:00] $context->setUser( Flow\TalkpageManager::getTalkpageManager() ); [19:10:19] stephanebisson, I think this issue also applies to Special:EnableFlow. [19:10:45] probably [19:12:18] it fails to create the board, I'll debug to see what's happening [19:12:38] stephanebisson, oh, probably because they don't have flow-create-board. [19:12:59] TPMU doesn't have it? [19:14:04] stephanebisson, no, never mind. I got it backwards. [19:14:15] TPMU does have it. [19:14:21] ahhh [19:14:27] "Formatting for wrong user: Flow talk page manager instead of Beta user 41" [19:15:09] matt_flaschen: So looking over https://gerrit.wikimedia.org/r/#/c/136280/20 , Jaime makes a good point that the wiki_ref and ext_ref tables don't have primary keys [19:15:20] Ug, that's cropped up before in other situations. [19:15:38] That was about the 'wrong user', not about DB. [19:16:02] RoanKattouw, yeah, I already filed a bug for it. Do you want to move it into current/up the backlog? [19:16:08] https://phabricator.wikimedia.org/T109676 [19:16:42] Matthias removed the unique constraint, so I would like to discuss it with him. [19:19:02] that's in Block.php:152 [19:19:09] I have no idea why this is there [19:19:20] even after reading the commit [19:20:41] stephanebisson, I think it's a consistency check to make sure the user is not seeing things they're not authorized to see. [19:21:48] it would make sense [19:23:17] stephanebisson, if it's important to you that it doesn't use the current user for the edit, we can work around it by extending the container. It should be safe since it's a new board anyway, so there's no information we're accidentally revealing. [19:24:24] it's not fundamental for what I do but it makes the history a bit weird [19:25:11] matt_flaschen: if you want an idea that would make the code cleaner and less hacky, I'm all for it [19:25:19] *have [19:26:25] stephanebisson, I have an idea (to workaround the 'wrong user' consistency check), but it doesn't fit that criteria. [19:26:32] https://phabricator.wikimedia.org/P1914 [19:27:06] stephanebisson, I would just accept it being under the user's name. They took an affirmative action (checked a box and clicked save), so while maybe slightly confusing it's acceptable to attribute it to them. [19:27:33] that's true [19:27:47] but the moves and edits are under TPMU [19:27:55] should it all be the current user? [19:30:41] stephanebisson, that would be less hacky than all under TPMU, probably (since this way, it matches the original request user). I think all you have to do then is add a flag to allowCreation checkFlowCreateBoard, defaulted to true, but override it false here. [19:34:10] stephanebisson, Plus change the usernames passed in, and you should probably also use 0 (instead of the flags) if it's under the user's name (since you don't want regular users suppressing RC or forcing bot edits and this path should be low-volume so we're not worried about flooding RC). [19:34:51] but al the edits will generate notifications, it won't get caught by the filter on TPMU [19:35:54] well, it probably doesn't notify when you edit your own talk page... right? [19:37:27] stephanebisson, probably not, but other people could have your talk page watched: https://phabricator.wikimedia.org/T101540 [19:37:40] (Or your user page watched, since they're linked). [19:37:54] I guess use the P1914 hack and try to put it all under TPMU. [19:38:13] Unless one of us thinks of something better. [19:39:05] i'll try [19:41:22] matt_flaschen: can you explain the P1914 hack? [19:41:31] where does it go? [19:43:45] Looking. [19:45:41] (03PS1) 10Mjbmr: Update Mazandarani namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233031 [19:51:23] stephanebisson, I think anytime before $loader->handleSubmit should work, but the beginning of createFlowBoard is the most natural place. What it does is basically override the container so when code asks for the 'permissions' key it gets the new one instead. [19:51:45] ok [19:56:11] stephanebisson, the importer code doesn't hit that issue since it's much more low level (otherwise, it would, since the context user is 127.0.0.1 I believe). [19:59:21] Would be good to have a comment about why too. [19:59:34] (why the container override I mean) [20:05:03] (03CR) 10Catrope: [C: 032] Update Mazandarani namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233031 (owner: 10Mjbmr) [20:09:02] matt_flaschen: it enters Block.php:152 a second time with the view as context and I get the same error with the usernames swapped: Formatting for wrong user: Beta user 47 instead of Flow talk page manager [20:14:45] (03Merged) 10jenkins-bot: Update Mazandarani namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233031 (owner: 10Mjbmr) [20:16:46] stephanebisson, does it say where the View is being called from? I'm guessing BoardContent, but I could be wrong. [20:17:57] matt_flaschen: yes, board_content somewhere [20:18:17] all triggered from $page->doEditContent( [20:23:18] matt_flaschen: I sent you the stacktrace by email [20:23:31] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1561807 (10DannyH) [20:24:32] it starts in $loader->commit [20:25:19] stephanebisson, right, thanks. [20:25:19] it's almost like I would need to change the container for $loader->handleSubmit and change it back for $loader->commit [20:25:32] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeNewFunctionality: Missing preventDefault on 'preview the result' - https://phabricator.wikimedia.org/T109664#1561812 (10DannyH) [20:25:59] stephanebisson, yeah, you could do that, but I'm trying to see if there's a more general solution. getParserOutput is already wrangling with the context, so maybe there's a general approach there. [20:26:02] 10Flow, 7Blocked-on-Operations, 3Collaboration-Team-Current, 5Patch-For-Review, and 2 others: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1561814 (10DannyH) [20:28:26] stephanebisson, hmm, it's going through TemplateData, which has functionality that is totally irrelevant to us. If we can get that to bail early, it might simplify things. [20:30:45] what is TemplateData? [20:31:07] stephanebisson: System of structured data about how to use templates. [20:31:12] stephanebisson: VisualEditor thing. [20:31:23] stephanebisson, yeah, metadata about which parameters mean what, and how to use them. [20:32:27] stephanebisson, e.g. https://en.wikipedia.org/wiki/Template:Citation_needed#Template_data [20:32:38] stephanebisson, if you disable VisualEditor and TemplateData, does it work or just fail somewhere else? Guessing the latter but doesn't hurt to check. If it works, we may be able to stop TemplateData from taking actions on Flow pages. [20:33:08] let me check [20:34:04] I don't have the templatedata role enabled in mw-vagrant [20:35:02] stephanebisson, it's a dependency of VisualEditor. [20:40:14] matt_flaschen: exact same thing [20:41:14] stephanebisson, skipped TemplateDataHooks but still went through doEditContent/prepareContentForEdit/etc./View? [20:41:53] yes [20:42:21] stephanebisson, okay, keep it disabled for now. I'd still rather debug that version. [20:43:09] BoardContent.php:191 [20:43:25] View.php:54 [20:43:26] etc [20:44:05] 10Flow, 6Collaboration-Team-Backlog: 'Change title' does not update 'Reply to[title]' - https://phabricator.wikimedia.org/T109898#1561863 (10Etonkovidova) 3NEW [20:44:49] why do we have $context->user if half of the code is looking at $GLOBALS['wgUser'] ? [20:46:45] it shouldn't look at globals :P [20:52:31] stephanebisson, okay, here's what I'm thinking. [20:53:07] We're formatting for the context user, and we want to make sure the permissions match, so why don't we just create a permissions object from the context user? [20:54:37] matt_flaschen: directly in Block.php? [20:55:45] Ug, the problem is, the container permissions is already used by the formatters and queries. [20:57:13] yes, all over the place in the container [21:02:17] stephanebisson, okay, totally different idea: [21:03:16] Sorry, one sec. [21:06:45] I was thinking: [21:06:47] $childContext->setUser( $options->getUser() ); [21:07:12] but that would still be a mismatch unless the permissions were also changed, and I'm not even sure changing them again will work since it might already be bound. [21:08:49] in block, we can create a new permissions obj with the context user instead of throwing [21:10:03] or do permissions.setUser [21:10:15] to keep the same permissions instance [21:10:42] Yeah, that's a hack, but I can't think of any reason it wouldn't work. I've got a question for ebernhardson, though. [21:11:02] ebernhardson, do you recall why generateHtml generates real HTML? [21:11:44] Is that actually necessary (it doesn't seem like it since it's re-rendered on an actual view)? [21:12:41] This is not ideal anyway, since it generates the whole user interface too, not just the content. [21:13:17] matt_flaschen: hmm, trying to remember. andrew wrote all that stuff so the first hand knowledge is lost [21:13:26] well, not lost but not easily available :) [21:13:28] ebernhardson, okay, already git-blaming. [21:14:52] matt_flaschen: a cursory look arround suggests it might only be used for onShowMissingArticle, but there might be something in core that wants the parser output to have html. i'm just not sure what [21:15:06] i know that parser output is used for writing things to the links table, but that doesn't need the html [21:16:05] ebernhardson, yeah, I'm sure things might call getText() if generateHtml is passed (they're allowed to at any rate), but that doesn't mean we need to provide real HTML. We can probably save time, too, without hurting any useful functionality. [21:16:25] This is from when werdna he initially implemented content model (except originally it always generated HTML regardless of the parameter). [21:17:05] This causes stuff like https://phabricator.wikimedia.org/T107170 too. [21:17:31] (not an issue anymore, but it should never have happened to begin with since it's not like that output was useful for hover cards). [21:22:26] Hmm, Wikibase does this for real, but it's not quite the same thing. [21:24:32] 10Flow, 6Collaboration-Team-Backlog: Flow fails to delete topics from RecentChanges - https://phabricator.wikimedia.org/T107975#1509033 (10DannyH) [21:24:33] 10Flow, 6Collaboration-Team-Backlog: Deleted topics should not appear in RecentChanges - https://phabricator.wikimedia.org/T108136#1513129 (10DannyH) [21:26:16] stephanebisson, alright, I'm going to try putting placeholder HTML. [21:29:32] (03PS19) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [21:30:19] matt_flaschen: I have to go, I'll check back later [21:30:40] stephanebisson, okay, see you then. [22:02:05] (03PS1) 10Mattflaschen: Use placeholder HTML rather than rendering the board in getParserOutput [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) [22:04:33] (03CR) 10Mattflaschen: "See also T107170." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) (owner: 10Mattflaschen) [22:15:24] 10Flow, 6Collaboration-Team-Backlog: Bots and Flow living in harmony (tracking) - https://phabricator.wikimedia.org/T107093#1562356 (10DannyH) [22:15:26] 10Flow, 6Collaboration-Team-Backlog: Documentation for Flow bots usergroup - https://phabricator.wikimedia.org/T93250#1562354 (10DannyH) 5Open>3Resolved I made a redirect to the Collaboration team page. If anybody has questions, then they'll know who to ask. [22:20:58] 10Flow, 6Collaboration-Team-Backlog: Documentation for Flow bots usergroup - https://phabricator.wikimedia.org/T93250#1562380 (10Quiddity) [22:23:00] 10Flow, 6Collaboration-Team-Backlog: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1401106 (10DannyH) [22:23:01] 10Flow, 6Collaboration-Team-Backlog: Collapsed topic header: Make it easier to tell that it can be clicked and uncollapsed - https://phabricator.wikimedia.org/T108264#1562403 (10DannyH) [22:24:30] 10Flow, 6Collaboration-Team-Backlog: Collapsed topic header: Make it easier to tell that it can be clicked and uncollapsed - https://phabricator.wikimedia.org/T108264#1562415 (10DannyH) a:5Pginer-WMF>3None [22:24:58] 10Flow, 6Collaboration-Team-Backlog: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1562422 (10DannyH) a:3Pginer-WMF [22:30:11] 10Flow, 6Collaboration-Team-Backlog: Enable Flow on a single wikitext talk page that already exists, choosing archive name and handling archiving automatically - https://phabricator.wikimedia.org/T96302#1562468 (10DannyH) 5Open>3Resolved a:3DannyH [22:51:35] (03PS2) 10Mattflaschen: Use placeholder HTML rather than rendering the board in getParserOutput [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) [23:01:17] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Allow user to create new board at Special:EnableFlow without description - https://phabricator.wikimedia.org/T108348#1562632 (10Mattflaschen) a:3Mattflaschen [23:07:22] matt_flaschen: I am checking RC table and 'suppress' action is not recorded that. Is it deliberate? [23:07:54] etonkovidova, you mean suppress-topic/suppress-post? [23:08:12] etonkovidova, or EDIT_SUPPRESS_RC? [23:08:45] matt_flaschen: I checked only for suppress-topic - from UI click on Suppress topic and there is nothing in RC; History displays it [23:09:15] 10Echo, 6Collaboration-Team-Backlog: Notification emails should embed icons as data URIs - https://phabricator.wikimedia.org/T55479#1562668 (10Catrope) [23:09:17] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1562669 (10Catrope) [23:09:18] matt_flaschen: RC displays all other changes -incl Hide and delete. [23:09:36] matt_flaschen: so I wondered why Suppress was singled out [23:10:19] It might be because supress is super secret [23:10:36] If you're not privileged, you're often not even allowed to see *that* something is suppressed [23:10:42] Shouldn't it also be hidden from history, then? [23:11:15] etonkovidova, I think it's deliberate because it's considered especially sensitive data. Normally you would only use it when someone posted either private information (like someone's phone number) or really bad stuff. That you don't even want visible to admins. It goes to the suppression log, though. [23:11:31] mooeypoo, I thought it is unless you have flow-suppress. [23:11:35] etonkovidova, where are you testing? [23:11:36] (03CR) 10Catrope: [C: 031] Use placeholder HTML rather than rendering the board in getParserOutput [extensions/Flow] - 10https://gerrit.wikimedia.org/r/233066 (https://phabricator.wikimedia.org/T98270) (owner: 10Mattflaschen) [23:11:51] 10Flow, 6Collaboration-Team-Backlog, 7Easy: You are seeing a preview. Click "Add topic" to post, or click "Keep editing" to continue writing. - https://phabricator.wikimedia.org/T93850#1562713 (10DannyH) p:5Low>3Normal [23:11:57] etonkovidova, and with what username? [23:12:10] matt_flaschen: betalabs , enwiki Etonkovidova [23:12:22] matt_flaschen: rc_user=4462 [23:14:18] 10Flow, 6Collaboration-Team-Backlog, 6operations: Setup separate logical External Store for Flow - https://phabricator.wikimedia.org/T107610#1562728 (10DannyH) p:5High>3Normal [23:14:26] 10Flow, 6Collaboration-Team-Backlog, 6operations, 7WorkTypeMaintenance: Setup separate logical External Store for Flow - https://phabricator.wikimedia.org/T107610#1562731 (10DannyH) p:5Normal>3High [23:14:30] etonkovidova, yeah, you have oversight: http://en.wikipedia.beta.wmflabs.org/wiki/Special:ListUsers/Etonkovidova?limit=1 [23:14:40] oversight == suppression. I'm not sure which is more Orwellian. [23:15:29] matt_flaschen: well, seems to be ok - other users do no see suppressed topics from History [23:15:29] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), and 3 others: Catchable fatal error: Argument 1 passed to Flow\Formatter\RevisionFormatter::formatApi() must be an instance of Flow\Formatter\FormatterRow, bool give... - https://phabricator.wikimedia.org/T109537#1562733 [23:15:50] etonkovidova, yeah. You should also see it at http://en.wikipedia.beta.wmflabs.org/wiki/Special:Log/suppress . That log is restricted but you have the right to see it since you're in the oversight group. [23:15:51] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), and 2 others: Catchable fatal error: Argument 1 passed to FlowHooks::isTalkpageManagerUser() must be an instance of User, null given in /srv/mediawiki/php-1.26wmf18/... - https://phabricator.wikimedia.org/T109063#1562735 [23:16:32] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 7WorkTypeNewFunctionality: Switching between source & VE in Flow entry field should keep the cursor focus in the entry field - https://phabricator.wikimedia.org/T101189#1562736 (10DannyH) [23:16:39] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 7WorkTypeNewFunctionality: F4. Add legal text to Flow side rail - https://phabricator.wikimedia.org/T97371#1562737 (10DannyH) [23:16:45] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1562738 (10DannyH) [23:16:46] matt_flaschen: thx! Seems all right then :) [23:16:50] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: E4. Refactor the editor to be able to use it from ooui widgets - https://phabricator.wikimedia.org/T103572#1562747 (10DannyH) [23:17:33] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1562749 (10DannyH) [23:17:39] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeMaintenance: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1562750 (10DannyH) [23:17:51] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1558118 (10DannyH) [23:18:01] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeNewFunctionality: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1562753 (10DannyH) [23:18:09] 10Flow, 3Collaboration-Team-Current, 7Design, 5Patch-For-Review, 7WorkTypeNewFunctionality: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1562755 (10DannyH) [23:18:12] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Move "left a message on your talk page" Echo notification from Alerts to Messages - https://phabricator.wikimedia.org/T108760#1562756 (10DannyH) [23:18:19] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Remove wgFlowMigrateReferenceWiki - https://phabricator.wikimedia.org/T108104#1562758 (10DannyH) [23:18:24] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: We should update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1562759 (10DannyH) [23:18:29] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 7WorkTypeNewFunctionality: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T97290#1562760 (10DannyH) [23:18:35] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality, and 2 others: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1562761 (10DannyH) [23:18:57] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Allow user to create new board at Special:EnableFlow without description - https://phabricator.wikimedia.org/T108348#1562762 (10DannyH) [23:19:02] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1562763 (10DannyH) [23:19:05] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1562764 (10DannyH) [23:19:18] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1562765 (10DannyH) [23:19:38] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), and 3 others: Catchable fatal error: Argument 1 passed to Flow\Formatter\RevisionFormatter::formatApi() must be an instance of Flow\Formatter\FormatterRow, bool give... - https://phabricator.wikimedia.org/T109537#1562767 [23:20:04] 10Flow, 3Collaboration-Team-Current, 7WorkTypeMaintenance: addurl CAPTCHA broken (HTML is rendered as text) - https://phabricator.wikimedia.org/T109554#1562769 (10DannyH) [23:20:08] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: 14 Chrome browser test failures - https://phabricator.wikimedia.org/T109785#1562771 (10DannyH) [23:20:13] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Port remaining editor uses to EditorWidget - https://phabricator.wikimedia.org/T109000#1562773 (10DannyH) [23:20:18] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Fix new topic notification on wikis with job queue - https://phabricator.wikimedia.org/T107835#1562775 (10DannyH) [23:20:24] 10Flow, 10Wikimedia-Extension-setup, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Enable Extension:Flow on se.wikimedia.org and convert LQT->Flow - https://phabricator.wikimedia.org/T106302#1562777 (10DannyH) [23:20:29] 10Flow, 10Datasets-General-or-Unknown, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality, 7notice: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1562778 (10DannyH) [23:20:33] 10Flow, 6Collaboration-Team-Backlog, 7Easy: You are seeing a preview. Click "Add topic" to post, or click "Keep editing" to continue writing. - https://phabricator.wikimedia.org/T93850#1562780 (10Mattflaschen) 5Open>3declined We don't have preview anymore, per se, as @Ebernardson said. We just switch yo... [23:20:37] 10Flow, 3Collaboration-Team-Current, 7Regression, 7WorkTypeNewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1562782 (10DannyH) [23:20:40] 10Flow, 3Collaboration-Team-Current, 7Regression, 7WorkTypeNewFunctionality: Clicking 'edit' should always refetch from the server - https://phabricator.wikimedia.org/T109660#1562783 (10DannyH) [23:20:45] 10Flow, 3Collaboration-Team-Current, 7WorkTypeNewFunctionality: Update MediaWiki-Vagrant for removal of wgFlowOccupyPages and wgFlowOccupyNamespaces - https://phabricator.wikimedia.org/T109553#1562784 (10DannyH) [23:21:11] 10Flow, 6Collaboration-Team-Backlog, 7Easy: You are seeing a preview. Click "Add topic" to post, or click "Keep editing" to continue writing. - https://phabricator.wikimedia.org/T93850#1562785 (10Mattflaschen) a:5Devirk>3None [23:22:02] dannyh, how accurate does this WorkType thing need to be? [23:25:43] matt_flaschen: Not hugely. ±10% or so, ish. [23:25:48] matt_flaschen: It's an experiment. [23:26:15] Okay, it looks a little lower than that, so I'll make some fixes. [23:27:19] 10Flow, 3Collaboration-Team-Current, 7WorkTypeMaintenance: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1562792 (10Mattflaschen) [23:27:57] 10Flow, 10MediaWiki-extensions-Maintenance, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): F3. End the occupation - https://phabricator.wikimedia.org/T105574#1562802 (10Mattflaschen) [23:28:11] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20), 7WorkTypeMaintenance: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1446970 (10Mattflaschen) [23:28:39] matt_flaschen: Hmm. I think that classification on T105574 is now wrong. [23:28:56] James_F, what new functionality does it provide? [23:29:07] matt_flaschen: Being able to roll out to more wikis without going mad. [23:29:33] matt_flaschen: "Maintenance" is stuff like "RL async will break your code" or "security issue" or "sudden demand for data". [23:29:41] Not "Making the world different intentionally". [23:29:47] But it's a little fuzzy. [23:29:48] James_F, it's already rolled out to all the wikis (minus maybe 10). dannyh could enable Talk:Main_Page on all of them today if we wanted quiddity to get really mad. [23:30:16] matt_flaschen: "Roll out" as in occupy a namespace. Just I've been told off for using the 'o' word. ;-) [23:30:57] James_F, you can also do that already in mediawiki-config, and afterwards it will still require a mediawiki-config change. [23:31:20] (Only for namespaces, not individual pages) [23:31:26] Although as part of the change we no longer use the edit summary 'Taken over by Flow' :) [23:31:44] What disaster did you forestall by doing T105574 then? That's the justification for it being "Maintenance". [23:32:30] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeMaintenance: Remove wgFlowMigrateReferenceWiki - https://phabricator.wikimedia.org/T108104#1562808 (10Mattflaschen) [23:32:59] James_F, where does "old tech debt that makes things annoying" fit? [23:33:23] Also, how about long-standing bugs? [23:33:38] matt_flaschen: I'd put both those in "Improvements" rather than "Maintenance". [23:34:23] James_F, that's not one of the choices. :) I'll just drop it, I guess. [23:34:34] matt_flaschen: Sadly. :-) Kk. [23:34:57] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkTypeNewFunctionality: Remove wgFlowMigrateReferenceWiki - https://phabricator.wikimedia.org/T108104#1562828 (10Mattflaschen) [23:37:35] It sounds like WorkTypeMaintenance should really be called WorkTypeInterrupt. [23:52:05] matt_flaschen, RoanKattouw_away https://gerrit.wikimedia.org/r/233081 [23:52:55] mooeypoo, you should try: [23:52:57] git add -p [23:53:24] mooeypoo, people will review your changes faster if they affect fewer files. :) [23:54:11] James_F matt_flaschen the definition I came up with for Maintenance is: Unbreak/High priority tasks for an existing feature, triggered by an external change [23:54:17] matt_flaschen, baaaah I went over the diff to make sure and missed half the nonessential changes in there. [23:54:18] boo [23:54:21] I'll fix that. [23:54:45] James_F matt_flaschen I showed it to Joel, he said that was good. [23:55:08] Kk. [23:55:27] dannyh, like I said, that sounds like Interrupt, not Maintenance. I would consider working on long-standing tech debt that is slowing down development classic maintenance. But I'll drop it. [23:55:48] matt_flaschen, sorry, refresh. [23:58:40] (03PS24) 10Mooeypoo: Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [23:59:18] (03CR) 10Mattflaschen: [C: 04-1] "You need the no-op ext.echo.base I mentioned on IRC if you want this to merge cleanly." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo)