[00:01:42] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18), and 2 others: Catchable fatal error: Argument 1 passed to FlowHooks::isTalkpageManagerUser() must be an instance of User, null given in /srv/mediawiki/php-1.26wmf18/... - https://phabricator.wikimedia.org/T109063#1555650 [00:05:51] Can anyone post a test message on my discussion page? I'm testing unread notifications. https://www.mediawiki.org/wiki/User_talk:MSchottlender-WMF [00:06:04] It won't let me post anything as anonymous user... user is blocked :\ [00:06:19] mooeypoo: Done [00:06:24] mooeypoo: Blame quiddity [00:06:26] much obliged [00:06:41] RoanKattouw, Blame him for everything, or specifically in this case? [00:06:44] I can do either. [00:06:46] specifically! [00:06:51] and everything ;_; [00:06:55] :D [00:07:08] uh.. [00:07:13] no notification. [00:07:48] RoanKattouw, no notification. CAn you 'thank' the reply I just left on that same thread? [00:08:51] mooeypoo: Done [00:09:26] 10Flow, 3Collaboration-Team-Current: Missing preventDefault on 'preview the result' - https://phabricator.wikimedia.org/T109664#1555662 (10Mattflaschen) 3NEW [00:18:51] 10Flow, 3Collaboration-Team-Current: Missing preventDefault on 'preview the result' - https://phabricator.wikimedia.org/T109664#1555698 (10Catrope) a:3Catrope [00:20:40] (03PS1) 10Catrope: WikitextEditorWidget: Prevent preview link from being followed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232664 (https://phabricator.wikimedia.org/T109664) [00:25:20] 10Echo, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1555718 (10Mattflaschen) >>! In T107823#1554680, @Legoktm wrote: > The architecture I came up with is: > > * `EchoEventFormatter` (more accurat... [00:45:15] (03PS10) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [00:50:08] 10Flow, 6Collaboration-Team-Backlog: Entire Flow page is reloaded when using browser back/forward navigation - https://phabricator.wikimedia.org/T109218#1555786 (10Mattflaschen) @Catrope How did you figure out that bfcache isn't working for any MW page? [00:51:33] 10Flow, 6Collaboration-Team-Backlog: Entire Flow page is reloaded when using browser back/forward navigation - https://phabricator.wikimedia.org/T109218#1555789 (10Catrope) >>! In T109218#1555786, @Mattflaschen wrote: > @Catrope How did you figure out that bfcache isn't working for any MW page? I'm not quite... [00:59:21] 10Flow, 6Collaboration-Team-Backlog: Entire Flow page is reloaded when using browser back/forward navigation - https://phabricator.wikimedia.org/T109218#1555826 (10Mattflaschen) >>! In T109218#1555789, @Catrope wrote: >>>! In T109218#1555786, @Mattflaschen wrote: >> @Catrope How did you figure out that bfcache... [01:02:52] (03CR) 10Mattflaschen: "I prefer to use evt.preventDefault(), since return false also does stopPropagation, which would affect e.g. a click listener on the body." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232664 (https://phabricator.wikimedia.org/T109664) (owner: 10Catrope) [01:34:09] 10Flow, 3Collaboration-Team-Current: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1555898 (10Mattflaschen) 3NEW [01:34:33] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): F3. End the occupation - https://phabricator.wikimedia.org/T105574#1555905 (10Mattflaschen) [01:45:00] (03CR) 10Mattflaschen: "> I think - at least for now - we shouldn't allow anyone to edit the contentmodel through any means other than Special:EnableFlow." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228269 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie) [01:59:53] 10Flow, 6Collaboration-Team-Backlog: Wrong message dates in Flow - https://phabricator.wikimedia.org/T109528#1555940 (10Mattflaschen) >>! In T109528#1552314, @gregoire wrote: > @Catrope they are dated January 1, 1970. This sounds suspiciously like the unix epoch but the date is not constant (i.e. time passes,... [02:10:23] 10Flow, 6Collaboration-Team-Backlog: Drop unused flow_subscription table - https://phabricator.wikimedia.org/T109673#1555966 (10Mattflaschen) 3NEW [02:10:54] 10Flow, 6Collaboration-Team-Backlog: Drop unused flow_subscription table - https://phabricator.wikimedia.org/T109673#1555980 (10Mattflaschen) [02:12:07] 10Flow, 6Collaboration-Team-Backlog: Drop unused flow_subscription table - https://phabricator.wikimedia.org/T109673#1555989 (10Mattflaschen) p:5Triage>3Normal [02:13:34] 10Flow, 6Collaboration-Team-Backlog, 7Database: Add primary key or unique constraint to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1555990 (10Mattflaschen) 3NEW a:3Springle [02:14:50] 10Flow, 6Collaboration-Team-Backlog, 7Database: Add primary key or unique constraint to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1556004 (10Mattflaschen) a:5Springle>3None [02:17:54] (03PS20) 10Mattflaschen: Segregate Reference objects by source wiki. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [02:23:17] (03CR) 10Mattflaschen: "Config patch is Ied5d56a75ae73cf1589ee871dec74eb2a6d14901 ." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [02:29:34] (03CR) 10Mattflaschen: "It can be started by either URL parameter (https://en.wikipedia.org/wiki/User talk:Mattflaschen-WMF?tour=flowOptIn) or cookie." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:07:18] (03CR) 10Mattflaschen: [C: 04-1] "Looks good overall. Main suggestion is to use ResourceLoaderRegisterModules." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230924 (https://phabricator.wikimedia.org/T108266) (owner: 10Mooeypoo) [04:22:14] 10Flow, 6Collaboration-Team-Backlog: Run subset of Flow browser tests from Jenkins - https://phabricator.wikimedia.org/T109678#1556087 (10Mattflaschen) 3NEW [04:23:14] 10Echo, 6Collaboration-Team-Backlog: Run subset of Echo browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109679#1556097 (10Mattflaschen) 3NEW [04:23:45] 10Echo, 6Collaboration-Team-Backlog: Run subset of Flow browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109678#1556105 (10Mattflaschen) [04:24:04] 10Flow, 6Collaboration-Team-Backlog: Run subset of Flow browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109678#1556087 (10Mattflaschen) [04:25:09] 10Echo, 6Collaboration-Team-Backlog: Run subset of Echo browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109679#1556097 (10Mattflaschen) [04:25:10] 10Flow, 6Collaboration-Team-Backlog: Run subset of Flow browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109678#1556087 (10Mattflaschen) [04:34:23] 10Flow, 10WMF-Server-Backports, 3Collaboration-Team-Current, 5Patch-For-Review, and 2 others: New flow topics not appearing in watchlist - https://phabricator.wikimedia.org/T108396#1556116 (10Mattflaschen) >>! In T108396#1551315, @Etonkovidova wrote: > 1) Looks weird that **adding** topics to my watched b... [06:49:52] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1556230 (10Josve05a) 3NEW [06:50:33] 10Flow, 6Collaboration-Team-Backlog: Blockers before allowing opt-in on sv.wp [Tracking] - https://phabricator.wikimedia.org/T109685#1556238 (10Josve05a) 3NEW [06:51:15] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1556247 (10Josve05a) [06:51:17] 10Flow, 6Collaboration-Team-Backlog, 7Performance: Flow JS loading / defered loading is very slow - https://phabricator.wikimedia.org/T108313#1556248 (10Josve05a) [06:51:19] 10Flow, 6Collaboration-Team-Backlog: Flow: Prettify thread permalink URLs (they are not human readable!) - https://phabricator.wikimedia.org/T59154#1556249 (10Josve05a) [06:51:21] 10Flow, 6Collaboration-Team-Backlog: Blockers before allowing opt-in on sv.wp [Tracking] - https://phabricator.wikimedia.org/T109685#1556246 (10Josve05a) [06:51:45] 10Flow, 6Collaboration-Team-Backlog, 7Tracking: Blockers before allowing opt-in on sv.wp [Tracking] - https://phabricator.wikimedia.org/T109685#1556238 (10Josve05a) [07:09:22] 10Flow, 6Collaboration-Team-Backlog, 7Tracking: Blockers before allowing Flow opt-in on sv.wp [Tracking] - https://phabricator.wikimedia.org/T109685#1556299 (10Qgil) [07:19:36] 10Flow, 6Collaboration-Team-Backlog, 7Database: Add primary key or unique constraint to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1556310 (10jcrespo) Allow me to help with this at any time (ping me for support). If the real primary key is unsuitable, because it is too large,... [07:35:40] hmm. i seem to have a permanent "There are new messages for you. [07:35:59] stuck on my watchlist that now leads to a /dev/null :) [11:44:29] (03CR) 10Matthias Mullie: "We shouldn't have to cherry-pick AFAIK. Current code is running fine and assuming the wgFlowMigrateReferenceWiki config flag is set, new c" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [11:59:43] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: We should update the database with all necessary new templates that Flow needs upon installation - https://phabricator.wikimedia.org/T105421#1556793 (10matthiasmullie) Below is the content of all import-related templates, as taken from mediawiki.org. Wh... [12:01:07] (03CR) 10Matthias Mullie: "Suggested template changes at https://phabricator.wikimedia.org/T105421#1556793" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232489 (https://phabricator.wikimedia.org/T105421) (owner: 10Matthias Mullie) [12:03:16] (03CR) 10Matthias Mullie: [C: 032] WikitextEditorWidget: Prevent preview link from being followed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232664 (https://phabricator.wikimedia.org/T109664) (owner: 10Catrope) [12:05:33] (03CR) 10Matthias Mullie: [C: 031] Cleanup debugging code for isTalkpageManagerUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232576 (https://phabricator.wikimedia.org/T109063) (owner: 10Mattflaschen) [12:05:57] (03Merged) 10jenkins-bot: WikitextEditorWidget: Prevent preview link from being followed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232664 (https://phabricator.wikimedia.org/T109664) (owner: 10Catrope) [12:06:20] (03CR) 10Matthias Mullie: "LGTM. Feel free to merge once you no longer need the debugging code." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232576 (https://phabricator.wikimedia.org/T109063) (owner: 10Mattflaschen) [12:21:57] (03PS3) 10Sbisson: Clean up width toggle styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231476 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:22:53] (03CR) 10Matthias Mullie: [C: 032] Make pressing Escape key in new topic title input also cancel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232575 (https://phabricator.wikimedia.org/T101178) (owner: 10Catrope) [12:23:54] (03CR) 10Sbisson: [C: 032] Clean up width toggle styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231476 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:25:56] (03Merged) 10jenkins-bot: Make pressing Escape key in new topic title input also cancel [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232575 (https://phabricator.wikimedia.org/T101178) (owner: 10Catrope) [12:26:40] (03Merged) 10jenkins-bot: Clean up width toggle styles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231476 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:29:39] (03CR) 10Sbisson: [C: 032] Use messages that actually exist for tooltips in SidebarExpandWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231477 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:29:59] (03PS4) 10Sbisson: Use messages that actually exist for tooltips in SidebarExpandWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231477 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:31:57] (03CR) 10Sbisson: Use messages that actually exist for tooltips in SidebarExpandWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231477 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:32:06] (03CR) 10Sbisson: [C: 032] Use messages that actually exist for tooltips in SidebarExpandWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231477 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [12:37:02] (03Merged) 10jenkins-bot: Use messages that actually exist for tooltips in SidebarExpandWidget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/231477 (https://phabricator.wikimedia.org/T103584) (owner: 10Catrope) [13:17:00] (03PS1) 10Matthias Mullie: Use rc_source instead of rc_type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232719 [13:20:14] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1556984 (10matthiasmullie) a:3matthiasmullie [14:00:48] 10Flow, 6Collaboration-Team-Backlog: Warnings on data loss are not applied when VE is used - https://phabricator.wikimedia.org/T97292#1557047 (10Ciencia_Al_Poder) On [[ https://www.mediawiki.org/wiki/Project:Support_desk | mediawiki.org ]] it currently doesn't warn you when you navigate to other pages, back an... [14:04:24] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Warnings on data loss are not applied when VE is used - https://phabricator.wikimedia.org/T97292#1557051 (10Josve05a) [15:05:23] (03PS12) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [16:12:07] 10Flow, 6Collaboration-Team-Backlog, 10LiquidThreads, 3Collaboration-Team-Current, 5Patch-For-Review: Prevent people from creating new LQT pages on wikis that have converted LQT to Flow - https://phabricator.wikimedia.org/T107068#1557532 (10Etonkovidova) Checked in mediawiki. [16:13:48] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1557540 (10Quiddity) [16:14:18] quiddity: Decline? [16:15:31] James_F, I was just fixing the wording. It was submitted as a blocker for opt-in rollout at svwp. https://phabricator.wikimedia.org/T109685 [16:15:43] quiddity: Hmm. [16:29:02] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1557572 (10Josve05a) >>! **https://sv.wikipedia.org/wiki/Wikipedia:Bybrunnen#.22Krav.22_.28blockers.29 (machine translated):** > For me it's a great blocker to have Flow based mainly on VE. Y... [16:32:15] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1557586 (10Josve05a) Personally I do not believe it is a blocker to do/not this before allowing otp-in on sv.wp, however I'm just realying the comments people made in the discussion on the sv... [16:37:43] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1557602 (10Jdforrester-WMF) If Flow are going to implement this, I'd recommend making it re-use the `visualeditor-betatempdisable` config option rather than inventing their own. [16:56:31] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): Make "recently active topics" the default? - https://phabricator.wikimedia.org/T108314#1557761 (10Etonkovidova) Checked in betalabs - the sort order 'Recently active topics' is a def... [17:08:31] (03PS2) 10Sbisson: Browser tests: update for new Flow editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232480 [17:15:32] uh, I just realized today's standup is the same time as the tech talk? [17:22:56] I may be 5 min late for standup. On my way home. [17:23:03] 10Flow, 6Collaboration-Team-Backlog: 'Mark as resolved' on a topic with a summary will attribute the summary to a user - https://phabricator.wikimedia.org/T109741#1557887 (10Etonkovidova) 3NEW [17:24:09] 10Flow, 6Collaboration-Team-Backlog: 'Mark as resolved' requires 'Update summary' - https://phabricator.wikimedia.org/T109741#1557897 (10Etonkovidova) [17:29:59] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1557947 (10Mattflaschen) It is already possible to use Flow without VE. Just click the icon to switch to wikitext. It will never show you VE again, unless you switch back. Note, the pr... [17:40:18] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow without VE - https://phabricator.wikimedia.org/T109684#1557961 (10Josve05a) It's true that it is 'possible' to use Flow without VE, but it isn't possible to have Flow without VE. - Normal editors allow the disbale of VE compleatly (not showing... [17:44:11] what's the correct way to generate a url to a page (e.g. Project:Flow) for the current site in php? [17:45:33] stephanebisson: Obtain a Title for the page if you don't have one already [17:45:35] $title = Title::newFromText( 'Project:Flow' ); // Can return null if input is invalid [17:45:42] Then you can do $title->getFullURL() [17:46:08] Or $title->getLocalURL(), I'm not always sure which one to use [17:46:47] Title::newFromText( 'Project:Flow' )->getFullURL() [17:47:03] any reason it would give "http://127.0.0.1:8080/wiki/Wiki:Flow" ? [17:50:40] it works with other values but the Project NS gets replaced by Wiki: [17:52:23] Most likely "Wiki" is the name you gave your project namespace when you set up the wiki [17:52:30] So Project: gets canonicalized to Wiki: [17:56:27] why does it do that? [17:58:34] it does indeed redirect from Project:Flow to Wiki:Flow on my mw setup [18:02:42] stephanebisson, it's deliberate. The project namespace can be given a friendly name. [18:03:03] E.g. https://en.wikipedia.org/wiki/Project:Adopt-a-user redirects to https://en.wikipedia.org/wiki/Wikipedia:Adopt-a-user [18:05:38] I think ordinarily getLocalURL is best, so you don't accidentally switch protocols or from desktop to mobile. [18:09:27] sounds good [18:09:29] thanks [18:10:19] thedj, it's fixed in master. We should go ahead and SWAT that out (https://gerrit.wikimedia.org/r/#/c/232493/), since it is a broken link. [18:10:32] so matt_flaschen, with the occupation going away, wht is the correct wayto change the content model of a page from wikitext to flow_board? [18:13:15] stephanebisson, at a low level, ensureFlowRevision. I think you can use the two paths at EnableFlow, though (one for existing pages, one for new). [18:14:23] There's an if/else based on $title->exists( Title::GAID_FOR_UPDATE ) ), which maybe can be refactored out. [18:14:47] i'm not using the Special:EnableFlow code directly [18:15:02] matt_flaschen: thx for checking [18:15:12] i'm using the underlying building blocks [18:16:08] stephanebisson, right, so you can either pull that out somewhere, or do something similar. Basically, for a new page that calls handleSubmit with an edit-header action. Creating the header creates the page. [18:16:26] stephanebisson, are you thinking about existing pages, new ones, or both right now? [18:16:43] matt_flaschen: I'm thinking about new board _without_ a header [18:17:11] Okay, so you want to create it totally blank. [18:18:12] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Make Flow respect VE's opt-out preference and not show any trace of it to the user - https://phabricator.wikimedia.org/T109684#1558073 (10Jdforrester-WMF) [18:18:32] matt_flaschen: dannyh wants it so I'm trying [18:18:37] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Warnings on data loss are not applied in Flow when VE is used - https://phabricator.wikimedia.org/T97292#1558075 (10Jdforrester-WMF) [18:18:52] oh, yeah - I'm writing on that ticket. I can do it here [18:19:19] Adding the template for pages that have wikitext archives is good, that information will still be worthwhile next year [18:19:49] But putting "Welcome to Flow" or whatever on brand new boards leaves junk text that's not useful and has to be taken out [18:21:15] is it possible for us to create it with a blank header? [18:22:00] BRB [18:23:30] dannyh: trying to figure it out [18:23:37] awesome, thanks [18:23:53] Back [18:24:09] Let me take a look. [18:26:11] matt_flaschen: I tried ensureFlowRevision and I got: "content-not-allowed-here" in $status [18:26:21] stephanebisson, you also need allowCreation. [18:26:27] If it's not in a Flow namespace. [18:28:47] it works, but I don't have external storage in mw-vagrant. I think it was the original issue... [18:29:25] It might not be an issue if there's no header at all and you just insert the board workflow. [18:29:32] I'm looking at the empty string thing now. [18:37:02] 10Flow, 6Collaboration-Team-Backlog: "Exception Caught: Must have data to write to external storage" when blanking topic summary - https://phabricator.wikimedia.org/T109560#1558114 (10Mattflaschen) It turns out in production, the blank test I did ended up in External store with length 2 (so not really blank).... [18:37:34] stephanebisson, okay, so there are two main options I see: [18:37:50] * Do an edit-header with a no-op 1-character space header. [18:38:14] * Do allowCreation/ensureFlowRevision/insert board workflow without creating any header or topics (low level option). [18:38:46] 10Flow, 3Collaboration-Team-Current: [betalabs] Regression: 'Cancel' for Nested Replies(>two levels) broken - https://phabricator.wikimedia.org/T109748#1558118 (10Etonkovidova) 3NEW [18:38:53] sounds good [18:38:54] External Store will fail only if the final HTML it tries to store is a 0-length string. [18:39:07] i prefer the low-level less-hacky option [18:40:52] stephanebisson, I don't recall us doing that anywhere. I do think it should work, but we might need to do some troubleshooting. [18:41:31] matt_flaschen: I'm updating my code and re-running all tests, it looks promising [18:44:44] 10Flow, 3Collaboration-Team-Current: [betalabs] Regression: 'Cancel' for Nested Replies(>two levels) broken - https://phabricator.wikimedia.org/T109748#1558130 (10Etonkovidova) [18:48:38] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1558137 (10DannyH) [18:50:40] (03PS1) 10Catrope: After switching editors, move cursor to end [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232785 (https://phabricator.wikimedia.org/T97290) [18:51:56] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T97290#1238153 (10Catrope) >>! In T97290#1558143, @gerritbot wrote: > Change 232785 had... [18:54:22] 10Flow, 6Collaboration-Team-Backlog: 'Mark as resolved' requires 'Update summary' - https://phabricator.wikimedia.org/T109741#1558156 (10Mattflaschen) > The user who does 'Mark as resolved' is forced to click on 'Update summary' option. You don't actually have to. It's already resolved by that point. Testin... [18:59:44] RoanKattouw_away I gave stephanebisson text for the opt-in email notification, which includes adding the project name: "Flow is enabled on your user talk page on (project name)." What's the best way to get that name? [19:04:55] 10Flow, 6Collaboration-Team-Backlog: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" - https://phabricator.wikimedia.org/T109750#1558185 (10Etonkovidova) 3NEW [19:06:07] 10Flow, 6Collaboration-Team-Backlog: [betalabs] 'Cancel' Summarize gives "Cannot read property 'commandRegistry'" - https://phabricator.wikimedia.org/T109750#1558194 (10Etonkovidova) [19:18:37] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): Make "recently active topics" the default? - https://phabricator.wikimedia.org/T108314#1558219 (10DannyH) 5Open>3Resolved Yes, the two points that @Etonkovidova brings up are expec... [19:18:48] 10Flow, 6Collaboration-Team-Backlog, 10LiquidThreads, 3Collaboration-Team-Current, 5Patch-For-Review: Prevent people from creating new LQT pages on wikis that have converted LQT to Flow - https://phabricator.wikimedia.org/T107068#1558221 (10DannyH) 5Open>3Resolved [19:18:51] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1558222 (10DannyH) [19:20:19] dannyh, {{SITENAME}} should work. Only caveat is it's e.g. Viquipèdia, not Catalan Viquipèdia. [19:24:12] matt_flaschen thanks, I knew there was a magic word but I couldn't remember what it was. Using Viquipèdia is perfect. [19:24:41] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1558224 (10DannyH) [19:24:58] stephanebisson I updated the opt-in ticket with matt_flaschen's suggestion [19:25:46] good [19:26:14] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, and 2 others: Press ESC to cancel a message - https://phabricator.wikimedia.org/T101178#1558232 (10Etonkovidova) Checked in betalabs: | Action |Esc works? |---------|------------ | Create a new topic |Yes | Create a fi... [20:03:11] matt_flaschen: you still around? [20:03:19] Yep [20:03:31] any idea why "$revision->getContent()->getWorkflowId()" would be null? [20:03:53] I call ensureFlowRevision the first time to creat the board and it seems to work [20:04:33] it gets called later on when I edit the description in 1 case, and at that point, the workflowId in the content obj is null [20:05:28] getContent() here is BoardContent [20:06:54] stephanebisson, it looks like that might happen if BoardContentHandler->unserializeContent returns this->makeEmptyContent. [20:07:00] How did you get $revision? [20:07:12] $page->getRevision(); [20:07:20] we're inside ensureFlowRevision [20:08:21] If you didn't change ensureFlowRevision, then that's not the right revision. [20:08:43] That $revision is before the edit, you would need to get a new revision after it. [20:11:19] stephanebisson, maybe: [20:12:15] Actually, the new revision should be in: [20:12:31] $value['revision'] if I'm understanding correctly. [20:16:03] it puts a revision in the status but it's the same one it reads from line 153, supposedly the latest [20:18:30] 10Flow, 6Collaboration-Team-Backlog, 10Wikidata: Wikidata - Flow bugs and feature reqs (tracking) - https://phabricator.wikimedia.org/T100844#1558414 (10DannyH) [20:18:30] stephanebisson, is it returning early, or doing the edit? [20:18:32] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Switching between source & VE in Flow entry field should keep the cursor focus in the entry field - https://phabricator.wikimedia.org/T101189#1558412 (10DannyH) 5Open>3stalled I'm... [20:19:15] matt_flaschen: doing the edit the first time, it gets there a second time when setting the header and then, the workflowId is null [20:19:50] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, and 2 others: Press ESC to cancel a message - https://phabricator.wikimedia.org/T101178#1558438 (10DannyH) 5Open>3Resolved [20:19:51] 10Flow, 6Collaboration-Team-Backlog, 10Wikidata: Wikidata - Flow bugs and feature reqs (tracking) - https://phabricator.wikimedia.org/T100844#1322053 (10DannyH) [20:20:41] matt_flaschen: I'm using the blocks and action/params to set set the header and the commit contains a call to ensureFlowRevision [20:20:58] wondering if maybe I didn't create the workflow correctly the first time [20:21:28] when I called $this->occupationController->ensureFlowRevision( new Article( $title ), $workflow ); to create the board initially [20:21:47] $workflow is coming from: [20:21:49] $loader = Container::get( 'factory.loader.workflow' )->createWorkflowLoader( $title ); [20:21:49] $workflow = $loader->getWorkflow(); [20:24:29] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1558496 (10DannyH)... [20:25:07] stephanebisson, that looks right. One sec, let me put together a query for you to check the revision table. [20:27:35] 10Flow, 3Collaboration-Team-Current: Regression on production: 'Cancel' for Nested Replies (>two levels) broken - https://phabricator.wikimedia.org/T109748#1558505 (10DannyH) p:5Triage>3Unbreak! [20:30:50] stephanebisson: [20:30:53] SELECT page_namespace, page_title, rev_id, rev_content_model, old_text FROM revision JOIN text ON rev_text_id = old_id JOIN page ON rev_page = page_id ORDER BY rev_id DESC LIMIT 10; [20:31:15] That should let you check for the JSON directly in the DB. There is also an API, but if it's confused about the content model the API will also be confused. [20:32:20] where would the json be? [20:32:47] stephanebisson, in old_text. [20:33:04] "[]" it is [20:33:33] so it wasn't saved right [20:33:39] Yeah [20:34:39] new BoardContent( CONTENT_MODEL_FLOW_BOARD, $workflow->isNew() ? null : $workflow->getId() ), [20:34:49] I blame this line [20:34:51] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current: Deleted topics should not appear in RecentChanges - https://phabricator.wikimedia.org/T108136#1558529 (10DannyH) p:5Normal>3High [20:35:01] 10Flow, 6Collaboration-Team-Backlog, 10Wikimedia-Extension-setup, 3Collaboration-Team-Current: Enable Extension:Flow on se.wikimedia.org and convert LQT->Flow - https://phabricator.wikimedia.org/T106302#1558532 (10DannyH) p:5Normal>3High [20:35:09] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 7Regression: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1558534 (10DannyH) p:5Normal>3High [20:35:18] I'm going to step through to be sure [20:35:58] 10Flow, 3Collaboration-Team-Current: Cancel keeps temporary text in editors - https://phabricator.wikimedia.org/T109365#1558539 (10DannyH) p:5High>3Normal [20:37:02] indeed [20:37:04] 10Flow, 6Collaboration-Team-Backlog: Cancel keeps temporary text in editors - https://phabricator.wikimedia.org/T109365#1547194 (10DannyH) [20:37:12] the workflow is "new" [20:38:34] 10Flow, 6Collaboration-Team-Backlog: After clicking on 'Edit description', Board description is displayed empty while its content loads - https://phabricator.wikimedia.org/T109493#1558544 (10DannyH) [20:39:15] 10Flow, 3Collaboration-Team-Current: Update MediaWiki-Vagrant for removal of wgFlowOccupyPages and wgFlowOccupyNamespaces - https://phabricator.wikimedia.org/T109553#1558551 (10DannyH) p:5High>3Normal [20:39:31] I can create it with "$workflow = Workflow::create( 'discussion', $title );" but it doesn't save it [20:41:08] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current: Fix new topic notification on wikis with job queue - https://phabricator.wikimedia.org/T107835#1558555 (10DannyH) p:5High>3Normal [20:41:22] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current: Fix new topic notification on wikis with job queue - https://phabricator.wikimedia.org/T107835#1505375 (10DannyH) p:5Normal>3High [20:41:50] 10Flow, 6Collaboration-Team-Backlog: Deleted topics should not appear in RecentChanges - https://phabricator.wikimedia.org/T108136#1558559 (10DannyH) p:5High>3Normal [20:42:12] 10Flow, 6Collaboration-Team-Backlog, 10VisualEditor: Warnings on data loss are not applied in Flow when VE or wikitext is used - https://phabricator.wikimedia.org/T97292#1558561 (10Quiddity) [20:44:08] (03PS12) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [20:44:11] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [20:45:09] hm. Guys, anyone knows how to handle a rebase conflict about a deleted file? I need the file deleted in my version [20:45:28] Do I just git rm it and rebase --continue ? [20:45:44] yep [20:46:15] (03PS13) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [20:46:20] * mooeypoo goes to check the damage [20:47:49] stephanebisson, I was looking and wondering how this ever works. It looks like there is a bug (or at least confusing behavior) that causes it to insert a [] first, then the right one. [20:47:51] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [20:49:14] matt_flaschen: is it around Block/Header.php:172 ? [20:50:22] 10Flow, 6Collaboration-Team-Backlog: Indicate in the page title that an edit is ongoing - https://phabricator.wikimedia.org/T109767#1558602 (10Quiddity) 3NEW [20:50:27] stephanebisson, the 'discussion' workflow line? No, that looks okay to me. The empty array means there is no metadata. [20:50:51] ok [20:51:52] where is it happening? [20:52:43] 10Flow, 6Collaboration-Team-Backlog: Board is first created with empty array, then with real JSON - https://phabricator.wikimedia.org/T109768#1558619 (10Mattflaschen) 3NEW [20:54:09] stephanebisson, I think exactly where you said before ( new BoardContent( CONTENT_MODEL_FLOW_BOARD, $workflow->isNew() ? null : $workflow->getId() ),). [20:54:18] This probably has been like that for a while, though. [20:54:40] stephanebisson, it still doesn't explain why it's not working for you. Since getWorkflowId returns null it should continue and make the second edit. [20:56:18] Since in this path you said you're setting the header. it looks like it may cause problems (or require a hack) for the board-only approach, though. [20:59:19] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1558646 (10Mattflasc... [20:59:23] 10Flow, 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1558648 (10Mattflasc... [21:01:04] 10Flow, 6Collaboration-Team-Backlog, 10OOjs-UI, 10VisualEditor, and 3 others: [Regression pre-wmf19] Inspectors insta-close on open due to OOUI breakage - https://phabricator.wikimedia.org/T108966#1558650 (10Ryasmeen) [21:01:22] matt_flaschen: it tries and fails to do the 2nd edit: "Invalid workflow requested by id" [21:02:01] WorkflowLoaderFactory.php:118 [21:04:07] stephanebisson, can you upload your WIP? I want to run the maintenance script for 'end the occupation', and I have a meeting coming up, but I will look at it tonight. [21:04:22] quiddity: regarding https://phabricator.wikimedia.org/T107897: Implement feature flag to disable LQT Special:NewMessages [21:05:26] quiddity: matt_flaschen: have you ever noticed 'you have new messages' after you logged out? [21:05:46] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): OOjs UI reply widget - https://phabricator.wikimedia.org/T108719#1558661 (10DannyH) [21:05:51] 10Flow, 6Commons, 3Collaboration-Team-Current, 5Patch-For-Review: Enable Flow on Polish Wikipedia and Commons - https://phabricator.wikimedia.org/T107301#1558662 (10DannyH) [21:05:58] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Transform the 'add new topic' section to an OOUI widget - https://phabricator.wikimedia.org/T107915#1558664 (10DannyH) [21:05:58] matt_flaschen: cannot reproduce it ... I saw it only once. [21:06:01] matt_flaschen: sure [21:06:03] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1558665 (10DannyH) [21:06:07] 10Flow, 3Collaboration-Team-Current: Fix new topic notification on wikis with job queue - https://phabricator.wikimedia.org/T107835#1558666 (10DannyH) [21:06:13] etonkovidova, not that I recall. [21:06:14] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): [betalabs] Board description still partially displayed when collapsed - https://phabricator.wikimedia.org/T107948#1558667 (10DannyH) [21:06:16] Thanks, stephanebisson [21:06:19] 10Flow, 3Collaboration-Team-Current: [betalabs] Browser crash - ve.init.target is null when attempting to switch to VE in Board description - https://phabricator.wikimedia.org/T107899#1558669 (10DannyH) [21:06:27] 10Flow, 3Collaboration-Team-Current, 7Design, 5Patch-For-Review: Display categories in Flow side rail - https://phabricator.wikimedia.org/T92874#1558670 (10DannyH) [21:06:30] etonkovidova, the LQT one spelled out (not orange) in the upper right? [21:06:30] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 5WMF-deploy-2015-08-25_(1.26wmf20): Add width-expanding toggle on Topic pages - https://phabricator.wikimedia.org/T103584#1558671 (10DannyH) [21:06:36] 10Flow, 3Collaboration-Team-Current, 7Regression: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1558674 (10DannyH) [21:06:40] 10Flow, 10Datasets-General-or-Unknown, 3Collaboration-Team-Current, 7notice: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1558675 (10DannyH) [21:06:44] matt_flaschen: right! [21:06:46] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1558676 (10DannyH) [21:06:51] 10Flow, 7Blocked-on-Operations, 3Collaboration-Team-Current, 5Patch-For-Review, 7Schema-change: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1558677 (10DannyH) [21:06:58] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): 'Undo' action from 'View history' cannot be completed - https://phabricator.wikimedia.org/T107232#1558678 (10DannyH) [21:07:07] 10Echo, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Don't send "Flow page manager" notification or email when a user talk page is converted to Flow - https://phabricator.wikimedia.org/T78576#1558682 (10DannyH) [21:07:10] (03PS13) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [21:07:12] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: D9. Flow BoardDescriptionWidget - https://phabricator.wikimedia.org/T101278#1558683 (10DannyH) [21:07:19] matt_flaschen: ^ [21:07:19] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Switching between source & VE in Flow entry field should keep the cursor focus in the entry field - https://phabricator.wikimedia.org/T101189#1558684 (10DannyH) [21:07:24] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): F3. End the occupation - https://phabricator.wikimedia.org/T105574#1558686 (10DannyH) [21:07:24] matt_flaschen: and another one - right on the logged out page. I saw it only on local [21:07:27] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19), 5WMF-deploy-2015-08-25_(1.26wmf20): Press ESC to cancel a message - https://phabricator.wikimedia.org/T101178#1558687 (10DannyH) [21:07:28] etonkovidova, ditto matt. I don't recall ever seeing it [21:07:30] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T97290#1558688 (10DannyH) [21:07:33] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: F1. Enable Flow on all public wikis - https://phabricator.wikimedia.org/T106562#1558689 (10DannyH) [21:07:50] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18), 5WMF-deploy-2015-08-18_(1.26wmf19): F4. Add legal text to Flow side rail - https://phabricator.wikimedia.org/T97371#1558690 (10DannyH) [21:07:52] matt_flaschen: and I deleted the screenshot. Sigh. it'd be sensational :) [21:07:55] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: E4. Refactor the editor to be able to use it from ooui widgets - https://phabricator.wikimedia.org/T103572#1558691 (10DannyH) [21:08:01] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: F2. All Flow edits are shown as new pages - https://phabricator.wikimedia.org/T93765#1558692 (10DannyH) [21:08:05] matt_flaschen: quiddity: - ok then [21:08:39] etonkovidova, okay. Can you still mention it on the task? [21:08:52] Someone can check for it in the code later. [21:10:10] matt_flaschen: Yes. Even if I do not quite like mentioning things that I have no tangible evidence for :) [21:17:21] 10Flow, 3Collaboration-Team-Current: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1558742 (10Mattflaschen) Beta: ``` mattflaschen@deployment-bastion:~$ foreachwiki extensions/Flow/maintenance/FlowUpdateRevContentModelFromOccupyPages.php -----------... [21:17:31] RoanKattouw_away, dannyh guess what I just did? [21:17:45] dannyh, RoanKattouw_away, going to run it in production now. [21:30:15] 10Flow, 3Collaboration-Team-Current: Run FlowUpdateRevContentModelFromOccupyPages.php in production - https://phabricator.wikimedia.org/T109671#1558815 (10Mattflaschen) Run in production. There are five pages that didn't exist: The cawiki one is Flow anyway because of the namespace. ``` cawiki: WARNING: Sk... [21:30:37] mooeypoo: ? [21:30:49] mooeypoo: Did making the buffer configurable work? [21:31:35] RoanKattouw_away, buffer + ading $footer to the popup widget [21:31:40] I'm about to submit the patch [21:31:47] yaya [21:31:50] *yay [21:31:53] I mean that's a terrible hack [21:31:57] But it works :) [21:31:59] Not that terrible, to be honest [21:32:07] No, I guess not [21:32:11] Now you can define $footer to popups [21:32:19] I wanted to make the buffer automatically detect the footer [21:32:20] Ooh [21:32:23] You added $footer? [21:32:26] yes [21:32:28] And then just made $body clippable? [21:32:40] RoanKattouw_away, yep, and the buffer = $footer.height() + 7 [21:32:46] I mean popup's usage for clippable is still terrible then [21:32:59] (only that didn't work (the dynamic calculation) so I have buffer as a config option from the popup [21:33:02] Clippable should support different $elements for measuring and making scrollable [21:33:16] maybe MatmaRex can help me make it better by having the buffer automatically calculate the $footer height [21:33:24] That's kind of what I mean, yes [21:33:26] I can look into that [21:33:33] let me push the patch [21:48:14] 10Flow, 6Collaboration-Team-Backlog, 7Browser-Support-Internet-Explorer, 5Patch-For-Review, 7Tracking: IE 8 support - Flow issues (tracking) - https://phabricator.wikimedia.org/T87121#1558905 (10Aklapper) Is there a browser support matrix for Flow? For example VE does not support MSIE 8.0 according to... [22:00:14] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-25_(1.26wmf20): F3. End the occupation - https://phabricator.wikimedia.org/T105574#1558970 (10Mattflaschen) [22:05:42] Now that script is run, I'm also going to have SWATed a comment (just so people don't think it's a good idea to occupy more pages) (https://gerrit.wikimedia.org/r/#/c/232854/), plus https://gerrit.wikimedia.org/r/#/c/232671/ (which allows the next step of "Segregate Reference objects by source wiki." [22:06:02] i'm out with a headache. hopefully back later. [22:09:11] quiddity, sorry, hope it clears up soon. [22:16:30] 10Flow, 6Collaboration-Team-Backlog: Email notification: The new renamed topic title is displayed in place for the previos title - https://phabricator.wikimedia.org/T109784#1559080 (10Etonkovidova) 3NEW [22:25:22] 10Flow, 3Collaboration-Team-Current: 14 Chrome browser test failures - https://phabricator.wikimedia.org/T109785#1559125 (10Mattflaschen) 3NEW [22:35:04] (03PS14) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [22:37:09] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:06:48] matt_flaschen, do you know how, in Echo's back end, to check whether a user has ever had any messages? I'm trying to figure out how to decide whether to output the message indicator [23:07:15] (03CR) 10Catrope: [C: 032] Use rc_source instead of rc_type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232719 (owner: 10Matthias Mullie) [23:07:40] legoktm, or maybe you know ? [23:07:57] mooeypoo, people have been saying that, but as far as I know there is not such a thing. I think you just want to check if they have any messages (read or unread). But yeah, legoktm might know. [23:08:25] matt_flaschen, yeah the problem is what to present to a user that has no messages at all. [23:08:47] hm good point about checking for message numbers. Though don't we want to add a 'welcome' notice to messages too, like there is in alerts, now that they're separate? [23:08:51] dannyh, ^ [23:09:08] If there are no read or unread messages, I think it should hide the Messages indicator. [23:09:25] mooeypoo, I didn't think we were going to add a welcome message. [23:09:37] (03CR) 10Catrope: [C: 032] Browser tests: update for new Flow editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232480 (owner: 10Sbisson) [23:09:53] matt_flaschen, but if messages are going to be showing talk page notices too, shouldn't we show the user both despite not having any? [23:09:56] Um [23:09:59] (03Merged) 10jenkins-bot: Use rc_source instead of rc_type [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232719 (owner: 10Matthias Mullie) [23:10:38] if the user does not have and has never had anything in the Messages panel, we don't show the Messages icon with a blank dropdown [23:11:10] when they get their first talk page message or Flow notification, then the icon shows up [23:11:37] legoktm, MWEchoNotifUser getNotificationCount() returns only the *unread* notification count. I split that out to ask for message vs alerts -- but I need to get *all* messages. Any ideas? Am I missing it in the code? [23:11:49] dannyh, alrighty [23:12:20] isn't that going to be weird for new users? [23:12:36] they have an alert due to the welcome notification [23:12:37] (03Merged) 10jenkins-bot: Browser tests: update for new Flow editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232480 (owner: 10Sbisson) [23:12:42] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1559256 (10DannyH) @SBisson, if the user enables + disables + enables again, they probably shouldn't get the guided tour twice. Is that possible? [23:12:46] legoktm, I guess they won't have anything there, and only when someone posted a note on their talk page they'll get the indicator [23:12:49] then someone writes on their talk page and poof, a brand new icon that will never go away [23:13:07] Once you go message, you never go back... [23:13:10] :P [23:13:12] that's kind of the same now, isn't it? [23:13:21] Well, now it's tabs, so it's less obvious [23:13:28] I think the badges make it super obvious [23:13:35] you get your welcome alert, but then people don't start thanking / linking / etc [23:14:47] it's currently using notifications.message.rawcount from the API [23:15:03] legoktm, yeah, how do I get this out of the PHP side [23:15:25] legoktm, I need to get it in Hooks::onPersonalUrls [23:15:45] that's where we're building the link. The JS piece will gracefully stop if the PHP side doesn't give it the badge [23:15:53] but all the methods I see are for *unread* notifications [23:16:01] I can't see how to pull the number for *all* notifications [23:16:17] we don't store it right now, aside from doing the full query to get the actual notifications [23:16:19] well, all notifications of type 'message' [23:16:27] hm [23:16:32] Maybe we should :\ [23:16:41] If we need to use it... [23:16:56] we can store a small setting that indicates whether a user has ever received a message [23:17:04] Perfect [23:17:21] legoktm, mooeypoo, do you think it would be performant enough to just query if they have one of that type? [23:18:02] I think it could be a pretty bad worst-case [23:18:22] Also don't we currently avoid connecting to that database entirely right now? [23:18:33] (on normal page views, not the API) [23:20:19] Caching a flag is probably best, no? [23:20:29] matt_flaschen: we could do lazy population of this setting, if it is set to null -> run query, false -> no messages, true -> has had messages [23:20:31] legoktm, oh, yeah, it gets it from memcached. But we shouldn't add another preference, since aaron is already objecting to echo-seen-time (2a0e98e9a90029bcc7862ed6b3d5d923ef97c1d1). [23:20:43] yes, I was just thinking of sticking it in memcache [23:20:53] or, WANCache [23:21:14] The problem with a setting like that is that we'll have to update it when the user gets their first message [23:21:40] yeah, but we already have to do cache invalidations at that point [23:21:50] hm, good point [23:22:13] mooeypoo, you can recalculate it (if memcached expires) from fetchByUser. [23:22:50] To get the list of message event types, getMessageEvents() [23:26:41] should I start writing code for this? or is mooeypoo going to? [23:26:52] legoktm, I'm.. uh.. experimenting [23:27:46] if this is a 5minute exercise for you, go for it. Otherwise, I'm experimenting with memcache keys and fetchByUser [23:32:00] 10Flow, 10Wikimedia-Extension-setup, 3Collaboration-Team-Current: Enable Extension:Flow on se.wikimedia.org and convert LQT->Flow - https://phabricator.wikimedia.org/T106302#1559344 (10DannyH) [23:33:37] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice: Convert LQT pages on MediaWiki.org to Flow (tracking) - https://phabricator.wikimedia.org/T92303#1559346 (10DannyH) [23:38:11] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1559366 (10DannyH) [23:38:12] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review: Move "left a message on your talk page" Echo notification from Alerts to Messages - https://phabricator.wikimedia.org/T108760#1559367 (10DannyH) [23:38:15] 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1559369 (10DannyH) [23:38:19] 10Flow, 3Collaboration-Team-Current: Old references are not removed properly when removing them from the content - https://phabricator.wikimedia.org/T94569#1559371 (10DannyH) [23:38:24] 10Echo, 3Collaboration-Team-Current, 5Patch-For-Review, 7notice, 7user-notice: Split notifications into Alerts and Messages - https://phabricator.wikimedia.org/T108190#1559372 (10DannyH) [23:39:33] matt_flaschen, legoktm ok I wrote something that works. [23:39:57] .... notice I say "something that works" and not "something that works well".. I'm not entirely sure if I did the memcache things right, or the count, for that matter. [23:39:59] Let me push it [23:40:16] (03PS15) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [23:40:19] (03PS1) 10Legoktm: [WIP] Add NotifUser::hasEverHadMessages() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232872 [23:40:26] ooh [23:40:32] nevermind, I'l lremove mine :D [23:41:13] I haven't tested that this actually works yet :P [23:41:37] legoktm, well, mine is worse, I'm fairly sure [23:41:43] see line #233 https://gerrit.wikimedia.org/r/#/c/231200/15/includes/NotifUser.php [23:41:49] It does work.......... [23:42:04] in theory, that should work :) [23:42:14] (and yes, I know I should document, still in the process) [23:42:18] we don't do any kind of time based pruning so the answe rwill be correct [23:42:43] someone could dos you with 2000 alerts? [23:42:53] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:42:58] but that's very edgecasey [23:43:10] legoktm, uh, no, the limit is 10 [23:44:08] and is cached. I think. [23:44:15] er, which limit? [23:44:50] legoktm, assuming I did this right, I'm checkign the cache first, and if it isn't there, I'm fetching from the mapper [23:44:55] but the fetchByUser has 'limit' [23:45:07] which I use 10. I can actually just use 1, really [23:45:41] are you also going to hide the alerts flyout if they have no alerts? [23:45:48] nope [23:45:54] just messages [23:47:19] matt_flaschen a question about the empty header on non-existent pages (T108348) -- you wrote that the user doesn't get an exception anymore. Am I the user? I'm still seeing the error message on beta [23:48:41] dannyh, are you getting the error, "To create a Flow board where no page currently exists, you must provide a description"? [23:48:43] If so, that's a user facing error, not an exception. [23:49:07] dannyh, before, an internal exception was bubbling up when I tested that locally. [23:49:32] matt_flaschen oh, you're right -- it's an error message, not exception. [23:50:00] (03PS16) 10Mooeypoo: [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) [23:50:23] legoktm, this works for me, but I assume your version is better? [23:51:13] I'm not sure, I got distracted reading the rest of your patch [23:51:33] legoktm, if you are, update it, I just pushed another ps [23:51:39] (03CR) 10jenkins-bot: [V: 04-1] [wip] Split alerts and messages in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:51:39] Updated mine a bit. [23:51:40] * legoktm refreshes [23:52:09] mooeypoo, yeah, you can use 1. And I would call the method hasMessages(), since you're not really returning an accurate count. [23:52:46] matt_flaschen, yeah I just corrected that (look at new ps) [23:52:51] copied legoktm's name :P [23:54:20] 10Flow, 6Collaboration-Team-Backlog: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T107375#1559397 (10DannyH) [23:54:21] 10Flow, 10Wikimedia-Extension-setup, 3Collaboration-Team-Current: Enable Extension:Flow on se.wikimedia.org and convert LQT->Flow - https://phabricator.wikimedia.org/T106302#1559396 (10DannyH) [23:54:40] 10Flow, 6Collaboration-Team-Backlog: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T107375#1493453 (10DannyH) [23:54:41] 10Flow, 10Wikimedia-Extension-setup, 3Collaboration-Team-Current: Enable Extension:Flow on se.wikimedia.org and convert LQT->Flow - https://phabricator.wikimedia.org/T106302#1464163 (10DannyH) [23:57:30] (03CR) 10Legoktm: [C: 04-1] [wip] Split alerts and messages in Echo (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo) [23:57:40] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, small things." (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/231200 (https://phabricator.wikimedia.org/T108190) (owner: 10Mooeypoo)