[09:26:57] 10Flow, 6Collaboration-Team-Backlog: Switch this page https://www.mediawiki.org/wiki/Talk:MediaWiki/Homepage_redesign/Preview#Adding_updated_updated_header to flow - https://phabricator.wikimedia.org/T108569#1523572 (10Paladox) 3NEW [12:30:56] 10Flow, 6Collaboration-Team-Backlog, 7Easy: You are seeing a preview. Click "Add topic" to post, or click "Keep editing" to continue writing. - https://phabricator.wikimedia.org/T93850#1523790 (10Devirk) a:3Devirk [12:58:42] (03CR) 10Sbisson: [C: 032] Fix legal text issues: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230279 (https://phabricator.wikimedia.org/T97371) (owner: 10Mattflaschen) [13:00:52] (03Merged) 10jenkins-bot: Fix legal text issues: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230279 (https://phabricator.wikimedia.org/T97371) (owner: 10Mattflaschen) [13:05:33] (03CR) 10Sbisson: [C: 032] Correctly show the navigation bar again when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230047 (https://phabricator.wikimedia.org/T108279) (owner: 10Mattflaschen) [13:07:37] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1523872 (10SBisson) What do you think about making the d... [13:08:36] (03Merged) 10jenkins-bot: Correctly show the navigation bar again when needed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230047 (https://phabricator.wikimedia.org/T108279) (owner: 10Mattflaschen) [13:17:33] 10Flow, 6Collaboration-Team-Backlog, 7Easy: Flow: texts of topic summary history and change mention "post summary" - https://phabricator.wikimedia.org/T66390#1523902 (10Devirk) a:3Devirk [13:22:43] 10Flow, 6Collaboration-Team-Backlog, 7Easy: Flow: texts of topic summary history and change mention "post summary" - https://phabricator.wikimedia.org/T66390#1523920 (10Devirk) a:5Devirk>3None [16:07:11] 10Echo, 6Collaboration-Team-Backlog: Ability to "ping" all users from a given usergroup? - https://phabricator.wikimedia.org/T108465#1524315 (10Quiddity) I think that {T76199} (a current GSoC project) might be a better solution for this. That will send Echo notifications to a predefined list, and allow opt-ou... [16:14:50] 10Echo, 6Collaboration-Team-Backlog: Ability to "ping" all users from a given usergroup? - https://phabricator.wikimedia.org/T108465#1524331 (10Krenair) 5Open>3declined a:3Krenair [17:03:40] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): 'Undo' action from 'View history' cannot be completed - https://phabricator.wikimedia.org/T107232#1524511 (10Etonkovidova) Checked - undo-edit-post - undo-edit-topic-summary - undo... [17:04:18] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: Add width-expanding toggle on Topic pages - https://phabricator.wikimedia.org/T103584#1524513 (10DannyH) I don't think there's a reason to have the big margin on old rev and diff pages at all, actually. Those could just b... [17:12:08] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): F4. Add legal text to Flow side rail - https://phabricator.wikimedia.org/T97371#1524521 (10Mattflaschen) Add space above footer regardless. [17:13:06] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): Change "About this discussion" in side rail to "About this board" - https://phabricator.wikimedia.org/T104775#1524525 (10DannyH) 5Open>3Resolved [17:14:50] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): 'Undo' action from 'View history' cannot be completed - https://phabricator.wikimedia.org/T107232#1524538 (10DannyH) 5Open>3Resolved [17:15:52] 10Flow, 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 5Patch-For-Review, and 2 others: Flow CAPTCHA integration broken - https://phabricator.wikimedia.org/T108145#1524540 (10DannyH) [17:16:01] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): Change "About this discussion" in side rail to "About this board" - https://phabricator.wikimedia.org/T104775#1524543 (10DannyH) [17:16:06] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): 'Undo' action from 'View history' cannot be completed - https://phabricator.wikimedia.org/T107232#1490195 (10DannyH) [17:16:12] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review, 5WMF-deploy-2015-08-04_(1.26wmf17), 5WMF-deploy-2015-08-11_(1.26wmf18): [betalabs] "Uncaught ReferenceError: mw is not defined" on any Flow Talk page - https://phabricator.wikimedia.org/T107945#1524548 (10DannyH) [17:16:48] (03CR) 10Jdlrobson: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/207286 (owner: 10Mooeypoo) [17:29:41] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review: Argument 6 passed to Flow\Model\WikiReference::__construct() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.24wmf5/extensions/Flow/includes/Model/Reference.php on... - https://phabricator.wikimedia.org/T67802#1524615 [17:32:14] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): [betalabs] Board description still partially displayed when collapsed - https://phabricator.wikimedia.org/T107948#1524625 (10Etonkovidova) Checked on betalbs - FF 39, Chrome, and Safa... [17:33:42] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): F4. Add legal text to Flow side rail - https://phabricator.wikimedia.org/T97371#1524627 (10Mattflaschen) And make the «li> render without bullet: http://en.wikipedia.beta.wmflabs.org/... [17:36:14] 10Flow, 6Collaboration-Team-Backlog: Fix memory leak in LQT->Flow conversion script - https://phabricator.wikimedia.org/T108601#1524635 (10Mattflaschen) 3NEW a:3Mattflaschen [17:47:06] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: Fix memory leak in LQT->Flow conversion script - https://phabricator.wikimedia.org/T108601#1524695 (10DannyH) [17:48:17] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1524700 (10Mattflaschen) >>! In T108348#1523872, @SBisso... [17:50:38] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: F9. Run LQT conversion script on mediawiki.org Project:Support desk - https://phabricator.wikimedia.org/T106614#1524712 (10Mattflaschen) [17:50:39] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: Fix memory leak in LQT->Flow conversion script - https://phabricator.wikimedia.org/T108601#1524713 (10Mattflaschen) [17:53:15] (03PS6) 10Catrope: Corrected documentation of compare-revisions-revision-header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230290 (https://phabricator.wikimedia.org/T96511) (owner: 10Haritha28) [17:54:55] quiddity: Do you know if https://phabricator.wikimedia.org/T96511 (lack of hover behavior) is intended behavior? [17:55:54] (03CR) 10Catrope: [C: 04-1] Corrected documentation of compare-revisions-revision-header message (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230290 (https://phabricator.wikimedia.org/T96511) (owner: 10Haritha28) [17:57:23] RoanKattouw, there should not be a hover, on diff pages' timestamps. It should be Exact only. (possibly with a tooltip showing the Elapsed, if someone wants to get fancy) [17:57:34] OK, so right now it's the other way around [17:58:14] quiddity: See e.g. https://fr.wikipedia.org/w/index.php?title=Sujet:Sfp6ygy1usn8hb9k&action=compare-post-revisions&topic_newRevision=sfr2t01bnnfzdsiv (add &uselang=en if you don't feel like exercising your mandatory French education) [17:59:27] sadly, yes. :< and that's also mentioned at https://phabricator.wikimedia.org/T95087 [17:59:37] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10VisualEditor: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1524752 (10Mattflaschen) Log is at http://people.wikimedia.org/~mattflaschen/2015_07_30_LQT_Flow_VE_Feedback_and_Support_... [17:59:41] OK [17:59:59] (03CR) 10Catrope: [C: 032] Show friendly error if no description on EnableFlow fresh creation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230368 (https://phabricator.wikimedia.org/T108348) (owner: 10Mattflaschen) [18:00:08] So that's already in the backlog, good to know [18:00:13] Thanks quiddity [18:00:18] I put tons of notes into the main task about this issue: https://phabricator.wikimedia.org/T94648 [18:00:31] 10Thanks, 6Collaboration-Team-Backlog, 10MobileFrontend, 7Jenkins, 3Reading-Web: mwext-Thanks-qunit-mobile is failing on unrelated commit - https://phabricator.wikimedia.org/T108409#1524756 (10Jdlrobson) The `mwext-Thanks-qunit-mobile` job got broken by the async changes. You can safely remove that, as `... [18:00:41] specifically the list of best practices elsewhere, at https://phabricator.wikimedia.org/T94648#1178640 [18:00:46] (03CR) 10Catrope: [C: 032] Urdu namespace l10n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230312 (https://phabricator.wikimedia.org/T108479) (owner: 10Dereckson) [18:02:16] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: F9. Run LQT conversion script on mediawiki.org Project:Support desk - https://phabricator.wikimedia.org/T106614#1524760 (10Mattflaschen) So it turned out to have a memory leak (@hoo noticed it last night). It was about 16 GB when I had to ki... [18:03:18] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1524769 (10DannyH) Sorry, I need to back up a step. :) I... [18:03:25] (03Merged) 10jenkins-bot: Show friendly error if no description on EnableFlow fresh creation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230368 (https://phabricator.wikimedia.org/T108348) (owner: 10Mattflaschen) [18:03:28] (03Merged) 10jenkins-bot: Urdu namespace l10n [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230312 (https://phabricator.wikimedia.org/T108479) (owner: 10Dereckson) [18:03:55] (03CR) 10Sbisson: [C: 04-1] "Undefined variable: categoryObject" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [18:05:07] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review: Localization of namespace "topic" in Urdu - https://phabricator.wikimedia.org/T108479#1524779 (10Dereckson) 5Open>3Resolved Change has been merged in the code repository. It will be live soon when deployed on the Wikimedia cluster. [18:05:46] 10Thanks, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10MobileFrontend, and 2 others: mwext-Thanks-qunit-mobile is failing on unrelated commit - https://phabricator.wikimedia.org/T108409#1524781 (10Mattflaschen) [18:07:26] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1524783 (10Mattflaschen) >>! In T108348#1524769, @DannyH... [18:12:15] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10VisualEditor: F8. Run LQT conversion script on mediawiki.org VE/Feedback - https://phabricator.wikimedia.org/T106613#1524820 (10Jdforrester-WMF) Thank you again! [18:12:17] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1524821 (10DannyH) I just created a board at a brand new... [18:17:05] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1524843 (10Mattflaschen) >>! In T108348#1524821, @DannyH... [18:19:00] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 7Blocked-on-Operations, and 2 others: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1524850 (10Mattflaschen) [18:21:08] 10Flow, 6Collaboration-Team-Backlog: Legal text partially covered by footer when the board is edited - https://phabricator.wikimedia.org/T108609#1524856 (10Etonkovidova) 3NEW [18:27:09] 10Flow, 6Collaboration-Team-Backlog: "By saving changes" description legal message partially covered by page footer when the description is being edited - https://phabricator.wikimedia.org/T108609#1524865 (10Mattflaschen) [18:28:04] (03PS1) 10Legoktm: Only require event type to construct a formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/230590 [18:29:15] 10Flow, 6Collaboration-Team-Backlog: Make "recently active topics" the default? - https://phabricator.wikimedia.org/T108314#1524876 (10DannyH) I thought it already was the default... [18:29:36] stephanebisson, gah, I'm running make compile-lightncandy, everything actually works, but there's no new file "handlebars/compiled/flow_block_topic_single_view.handlebars.php" for me to add to this commit. WTF ? [18:29:43] am I missing something? [18:30:04] I changed the handlebars version of that file... [18:30:46] mooeypoo: weird, let me try [18:31:39] (03CR) 10Catrope: [C: 032] Only require event type to construct a formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/230590 (owner: 10Legoktm) [18:32:43] mooeypoo: it changes handlebars/compiled/flow_block_topic_single_view.handlebars.php when I do it [18:33:41] Breaking for lunch [18:34:03] mooeypoo: are you running mw-vagrant? [18:36:32] stephanebisson, yeah. But I do the make compile-lightncandy from ssh [18:36:35] let me try again [18:37:07] it worked now... O.o [18:37:09] (03PS3) 10Mooeypoo: Allow for expanding/collapsing single topic view [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229996 (https://phabricator.wikimedia.org/T103584) [18:37:53] (03Merged) 10jenkins-bot: Only require event type to construct a formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/230590 (owner: 10Legoktm) [18:39:42] mooeypoo: if you look at View.php:247, there's an attempt at generating page-specific classes since template sharing is quite confusing [18:40:03] maybe that can be helpful with what you are doing [18:40:51] stephanebisson, yeah. I ended up reading the class of the body [18:40:54] which seems to work [18:41:40] stephanebisson, also, they are all "topic-page" :\ [18:41:51] Even diff, which isn't really a topic page. [18:42:01] I said an "attempt"... [18:42:06] hehe [18:42:14] Yeah we need to clean this up at some point [18:42:15] there is more work to do to make it precise [18:42:33] By "precise" you mean "to make it work" [18:43:14] it has been refined to separate board vs topic vs history as needed [18:43:37] now you may need to separate topic single view vs. diff vs old rev [18:44:36] stephanebisson, "$( 'body' ).hasClass( 'action-view' )" covers all non diff non old rev non history options [18:44:53] good [18:45:04] mooeypoo: BTW, I pushed "Add categories to the sidebar" back to dev... [18:46:17] stephanebisson, no, I did... [18:46:23] and then I moved it to needs review just now [18:46:30] oh oh no [18:46:31] wait [18:46:35] according to jenkins the patch is completely broken [18:47:03] okay I'm confused. So, add categories is in development. I moved the siderail expand thing to dev and then to needs review again [18:47:23] hold on, let me refresh a few times [18:47:27] oh... whaaaaat... eh. [18:48:03] ok, categories is in needs review, I push it back to dev right now to let you fix the patch [18:49:42] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10pywikibot-core, and 3 others: paraminfo for flow submodule view-topic-history fails - https://phabricator.wikimedia.org/T108317#1524961 (10Etonkovidova) Checked on betalabs - no 503 status requests were observed for history actions(view-t... [18:49:53] (03PS4) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [18:50:46] and topic expand toggle is in "ready for pickup"?!, I put it back in dev [18:51:05] stephanebisson, in any case the categories commit relies on unmerged stuff [18:51:24] stephanebisson, oops, did I drag it there by accident? I put it at first in dev but then moved it into needs review again [18:51:31] stephanebisson, i fixed it, it is good to be reviewed [18:51:34] (03CR) 10jenkins-bot: [V: 04-1] Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [18:51:38] good [18:51:39] boo [18:51:48] no this one will fail until the editor is fixed [18:52:06] but at least it won't fail on its own merit anymore (hopefully) [18:52:35] I'm questioning if it belongs in "needs review" then, sounds like it's blocked [18:52:45] It should still be looked at, right? [18:52:51] I would like to keep things actionable [18:54:04] what does it depend on? [18:54:53] BoardDescriptionWidget, because that's what it's part of [18:55:03] Which in turn depends on the EditorWidget change, which I'm working on right nwo [18:55:39] (03PS5) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [18:57:04] (03CR) 10jenkins-bot: [V: 04-1] Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [18:57:55] 10Thanks, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 10Continuous-Integration-Config, and 2 others: mwext-Thanks-qunit-mobile is failing on unrelated commit - https://phabricator.wikimedia.org/T108409#1524984 (10Legoktm) [18:58:17] (03CR) 10Catrope: [C: 04-1] Create a reply widget with the new editor (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [18:59:03] RoanKattouw: nice bug in flow :) [18:59:25] try writing an email address in response to someone [18:59:36] the mention thing get all fussy [19:00:07] i'll open a ticket in phab [19:00:16] lol [19:00:36] matanya: Before you do, have you tried (and this might not be ideal) pressing Escape right after typing @ ? [19:00:43] Like, roan@[Esc]wikimedia.org [19:00:58] I have RoanKattouw [19:01:07] urgh [19:01:17] You need to press escape twice *and* then it drops the cursor at the beginning :( [19:01:21] it works only if the mail doesn't contain a real username [19:02:16] so if do user@ then it goes all nasty [19:02:27] (03CR) 10Mooeypoo: Create a reply widget with the new editor (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [19:02:50] (03PS8) 10Mooeypoo: Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 [19:03:01] (03PS9) 10Mooeypoo: Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 [19:03:13] wfm [19:03:19] username@ (click cancel) wikimedia.org [19:03:40] Yup, that was implemented in https://phabricator.wikimedia.org/T94216 [19:03:48] RoanKattouw: RTL ... [19:03:59] i'll create an example on my tp [19:04:42] (03CR) 10jenkins-bot: [V: 04-1] Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [19:06:47] great, not i can't reproduce [19:06:51] *now [19:09:18] guosh, now the mention thing doesn't work at all [19:10:54] whatever, i'll try someother time. sorry for the noise friends [19:32:53] 10Flow, 6Collaboration-Team-Backlog: History pagination controls not displayed if the number of history entries is less than selected control option - https://phabricator.wikimedia.org/T108619#1525084 (10Etonkovidova) 3NEW [19:33:21] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): Board history pagination controls are missing - https://phabricator.wikimedia.org/T108279#1525094 (10Etonkovidova) Checked in betalabs. If there is the number of history entries doe... [19:55:43] > Ingress Damage Report: Entities attacked by mooeypoo [19:55:54] :( [19:58:38] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1525153 (10SBisson) a:3SBisson [20:12:26] (03PS31) 10Catrope: [WIP] Create an OOUI editor widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [20:14:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create an OOUI editor widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [20:17:59] 10Flow, 6Collaboration-Team-Backlog, 10Design Research Archive: Finding topics on Flow - https://phabricator.wikimedia.org/T96997#1525267 (10ggellerman) [20:25:48] (03PS10) 10Catrope: Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [20:25:50] legoktm, and I only attacked once! [20:27:28] (03CR) 10jenkins-bot: [V: 04-1] Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [20:45:09] (03PS1) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [20:48:00] (03CR) 10Mattflaschen: [C: 04-1] "Jaime (Jcrespo) started looking at this. He said if it affects more than 1000 rows (which it does by quite a margin), we need to batch th" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/136280 (https://phabricator.wikimedia.org/T107204) (owner: 10Werdna) [20:48:35] 10Flow, 6Collaboration-Team-Backlog: Text wrap issues in board description - https://phabricator.wikimedia.org/T108262#1525442 (10Etonkovidova) The footer covers the part of the legal text in description independently of the browser width. And it happens not only on new boards. Merging the bug with T108609. [20:50:24] 10Flow, 6Collaboration-Team-Backlog: Text wrap issues in board description - https://phabricator.wikimedia.org/T108262#1525450 (10Mattflaschen) [20:50:26] 10Flow, 6Collaboration-Team-Backlog: "By saving changes" description legal message partially covered by page footer when the description is being edited - https://phabricator.wikimedia.org/T108609#1525451 (10Mattflaschen) [20:58:00] legoktm: do you have some time? [20:58:12] stephanebisson: what's up? [20:58:35] working on the beta feature to enable Flow on user talk page [20:58:46] 10Flow, 6Collaboration-Team-Backlog: History pagination controls not displayed if the number of history entries is less than selected control option - https://phabricator.wikimedia.org/T108619#1525480 (10Mattflaschen) This is intentional behavior, and the same for core. See e.g. https://en.wikipedia.org/w/in... [20:59:13] legoktm: I have to run the conversion script when the user enable the feature [20:59:19] look at https://gerrit.wikimedia.org/r/#/c/230648/1/Hooks.php [20:59:22] hmm [20:59:37] I have a hard time reading the "old value" to know if it's just been enabled [21:00:26] in this code, $before = BetaFeatures::isFeatureEnabled( $user, BETA_FEATURE_FLOW_USER_TALK_PAGE ); returns the new value [21:00:52] this seems a little weird. [21:01:10] If someone clicks "Reset to defaults" we're going to convert their talk page back? [21:01:31] legoktm: according to the ticket, yes [21:01:40] https://phabricator.wikimedia.org/T98270 [21:02:04] we would just move pages around, not really convert [21:02:06] Yes, we debated this a whole lot (I preferred to do it on the page level, but this is where the spec ended up). [21:02:36] stephanebisson, you should be able to use the same technique as https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/WikimediaEventsHooks.php#L125 . The hook firing arguments should be more helpful, but that should work. [21:03:04] stephanebisson: well, this won't work with the criteria of "This feature will NOT be automatically enabled, even if the user has "Automatically enable all new beta features" checked." [21:03:56] betafeatures are fundamentally centered around user preferences, which this is not [21:05:44] I did not prefer the Beta Feature option either, but I think the solution discussed for 'automatically enable' was to show a notification to such users, but not immediately enable it. [21:05:48] Not sure if that's in the current spec. [21:06:02] Doesn't look like it. [21:06:33] if it has to be in BF, it should be some kind of fake preference that just links you to a special page where you convert your talk page [21:07:07] trying to do it post save on Special:Prefs with a hook is hacky and going to have odd side-effects [21:07:31] legoktm, what side effects? [21:07:51] like clicking reset converts your talk page back? [21:08:22] legoktm, I don't really think that's unexpected, if we want 'I choose to use Flow on user talk' to map in the user's mind to a user preference. [21:08:27] I'm mainly concerned about the auto-enrollment, BF (rightly) doesn't let things opt out [21:08:32] I guess... [21:09:05] convert back is just moving the flow board to an archive and moving the wikitext talk page back [21:10:10] I'm also worried about the auto-enrollment, I don't know how that would work [21:10:42] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1525530 (10Mattflaschen) > This feature will NOT be automatically enabled, even if the user has "Automatically enable all new beta feat... [21:11:11] Yes, I think auto-enrollment is the biggest problem. Just commented on the task. [21:33:03] (03PS2) 10Sbisson: [WIP] Beta feature Flow on user talk page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230648 (https://phabricator.wikimedia.org/T98270) [21:43:04] (03PS32) 10Catrope: [WIP] Create an OOUI editor widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [21:43:07] (03PS11) 10Catrope: Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [21:44:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create an OOUI editor widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [21:45:45] (03CR) 10jenkins-bot: [V: 04-1] Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [21:58:35] dannyh: Do we care about continuing to collect data for https://meta.wikimedia.org/wiki/Schema:FlowReplies given that we don't seem to look at it any more and it would take additional effort to port to the new editor system? [21:58:55] no, you can kill it -- I thought we killed it a while ago :) [21:59:08] No, it's still trucking along [21:59:19] But thanks, you've just accelerated E4 significantly :) [21:59:23] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1525744 (10DannyH) All the options that we've talked about are problematic in one way or another. We can put a note in the text about n... [21:59:51] It's pretty close to done, I think we can probably start merging E4 and its friends after the cut on Tuesday [22:00:38] E4? i think it only went up to E3. *zing* [22:06:34] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): F4. Add legal text to Flow side rail - https://phabricator.wikimedia.org/T97371#1525809 (10DannyH) [22:06:36] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): [betalabs] Board description still partially displayed when collapsed - https://phabricator.wikimedia.org/T107948#1525807 (10DannyH) 5Open>3Resolved [22:06:36] (03CR) 10Catrope: [C: 04-1] Create a new topic widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [22:06:43] 10Flow, 6Collaboration-Team-Backlog, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): [betalabs] Board description still partially displayed when collapsed - https://phabricator.wikimedia.org/T107948#1508110 (10DannyH) [22:08:00] 10Echo, 6Collaboration-Team-Backlog: No notification after mention notif on ja.wp (due to additional lines after sender signature?) - https://phabricator.wikimedia.org/T108278#1525825 (10Aklapper) [22:10:09] (03PS5) 10Catrope: Create a new topic widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [22:12:15] (03CR) 10jenkins-bot: [V: 04-1] Create a new topic widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [22:13:10] (03CR) 10Catrope: [C: 04-1] "The add topic button should be disabled when title input is empty." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [22:16:23] (03PS6) 10Catrope: Create a new topic widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [22:16:26] (03PS33) 10Catrope: [WIP] Create an OOUI editor widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [22:27:42] (03PS12) 10Catrope: Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [22:36:28] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1525931 (10DannyH) [22:37:22] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1263393 (10DannyH) Here's the text for the Beta features page. Anybody have comments or changes? Heading: Flow on user talk Text: E... [22:39:13] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: [betlabs] switchEditor is missing - https://phabricator.wikimedia.org/T108639#1525934 (10DannyH) p:5Triage>3Unbreak! [22:40:24] 10Flow, 6Collaboration-Team-Backlog: Old categories are not removed properly when removing and re-adding a template to summary or header (or just adding new categories) - https://phabricator.wikimedia.org/T94569#1525939 (10DannyH) [22:41:44] 10Echo, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current: Rewrite EchoNotificationFormatter - https://phabricator.wikimedia.org/T107823#1525944 (10DannyH) a:3Legoktm [22:44:02] matt_flaschen RoanKattouw Is Thanks-qunit-mobile failing really an Unbreak now? https://phabricator.wikimedia.org/T108409 [22:44:14] dannyh, yes, it's blocking all merges to that extension. [22:44:56] does Kunal's patch fix it? [22:45:16] yeah, it just needs to be turned off [22:45:28] but since there are no urgent patches to Thanks I was going to deploy it later [22:45:35] (unless there are urgent patches?) [22:45:38] later = this evening [22:46:15] It should work around the broken job. I also don't have +2 for that, but it looks fine. jdlrobson already +1'ed. [22:46:54] I don't know of any urgent ones, but there are two open. [22:51:00] matt_flaschen: is not recognized on Flow pages? [22:51:11] etonkovidova, I haven't tested. [22:51:39] matt_flaschen: it's not displayed - well, not important at the moment, I guess... [22:51:59] etonkovidova, you can go ahead and file it. is a nice feature, would be nice to be able to propose them on talk. [22:52:39] matt_flaschen: and what about hcards? I cannot see them either ... [22:52:47] (03CR) 10Catrope: [C: 04-1] Create a reply widget with the new editor (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [22:53:09] matt_flaschen: sorry... hcards are fine, actually. [22:53:22] (03CR) 10Catrope: Create a new topic widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [22:53:32] (03PS28) 10Catrope: Output the board description as an ooui widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/216038 (https://phabricator.wikimedia.org/T101278) (owner: 10Mooeypoo) [22:53:37] (03PS29) 10Catrope: Output the board description as an ooui widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/216038 (https://phabricator.wikimedia.org/T101278) (owner: 10Mooeypoo) [22:58:22] (03CR) 10Catrope: [C: 04-1] Output the board description as an ooui widget (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/216038 (https://phabricator.wikimedia.org/T101278) (owner: 10Mooeypoo) [23:00:52] 10Flow, 6Collaboration-Team-Backlog: Cannot use graph on Flow pages? - https://phabricator.wikimedia.org/T108644#1526025 (10Etonkovidova) 3NEW [23:01:04] (03PS30) 10Catrope: Create an OOUI widget for board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/219208 (https://phabricator.wikimedia.org/T101278) (owner: 10Mooeypoo) [23:06:21] (03CR) 10Mooeypoo: [WIP] Create an OOUI editor widget (0321 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [23:06:35] (03CR) 10Mooeypoo: [C: 04-1] "Comments on ps31" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/220665 (https://phabricator.wikimedia.org/T103572) (owner: 10Mooeypoo) [23:06:41] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1526041 (10Mattflaschen) a:5Mattflaschen>3None [23:11:58] (03CR) 10Mooeypoo: Output the board description as an ooui widget (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/216038 (https://phabricator.wikimedia.org/T101278) (owner: 10Mooeypoo) [23:15:11] (03PS30) 10Mooeypoo: Output the board description as an ooui widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/216038 (https://phabricator.wikimedia.org/T101278) [23:16:29] matt_flaschen: I am looking into https://phabricator.wikimedia.org/T107170 "Data Model JavaScript, including tokens..." and [23:17:06] matt_flaschen: the solution is to display: content model 'flow-board', which is not supported; returning an empty extract ? [23:17:08] 10Flow, 6Collaboration-Team-Backlog, 10Graph: Cannot use graph on Flow pages? - https://phabricator.wikimedia.org/T108644#1526070 (10Mattflaschen) [23:17:28] (03CR) 10Mooeypoo: Create a new topic widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [23:18:16] etonkovidova, when you use Hover Cards and mouse over a link to a Flow board (e.g. Talk:Flow) on http://en.wikipedia.beta.wmflabs.org/ you should get no hover card. [23:18:18] (03PS7) 10Mooeypoo: Create a new topic widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) [23:18:27] etonkovidova, internally in the API, it's implemented like you said. [23:19:22] matt_flaschen: ok then :) [23:20:05] (03CR) 10Mooeypoo: Create a reply widget with the new editor (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [23:20:57] (03CR) 10jenkins-bot: [V: 04-1] Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 (owner: 10Mooeypoo) [23:21:02] (03PS13) 10Mooeypoo: Create a reply widget with the new editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229293 [23:22:45] (03PS8) 10Mooeypoo: Create a new topic widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) [23:23:49] (03PS31) 10Mooeypoo: Create an OOUI widget for board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/219208 (https://phabricator.wikimedia.org/T101278) [23:24:00] (03CR) 10Mattflaschen: "I'm de-assigning myself from this for now, but there are notes on what I was going to follow up on next." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/228269 (https://phabricator.wikimedia.org/T105574) (owner: 10Matthias Mullie) [23:24:46] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1526108 (10Mattflaschen) I'm de-assigning myself from this for now. Next thing I was going to follow up on was https://gerrit.wikimedia.org/r/#/c/228269/... [23:24:53] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review: F3. End the occupation - https://phabricator.wikimedia.org/T105574#1526109 (10Mattflaschen) See very last comment in that file. [23:25:14] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): F4. Add legal text to Flow side rail - https://phabricator.wikimedia.org/T97371#1526112 (10Mattflaschen) a:5Mattflaschen>3None [23:26:42] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1518743 (10Mattflas... [23:29:38] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-08-11_(1.26wmf18): "Must have data to write to external storage" when using Special:EnableFlow on non-existent page with header field empty - https://phabricator.wikimedia.org/T108348#1526124 (10Mattflas... [23:30:59] Phabricator's column-jumping is killing me too. [23:31:27] 10Flow, 6Collaboration-Team-Backlog, 10Collaboration-Team-Current, 6Security, and 3 others: Data Model JavaScript, including tokens, appears in TextExtracts and HoverCards - https://phabricator.wikimedia.org/T107170#1526131 (10Etonkovidova) Checked in betalabs http://en.wikipedia.beta.wmflabs.org/w/api.ph... [23:51:43] (03CR) 10jenkins-bot: [V: 04-1] Create a new topic widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/229614 (https://phabricator.wikimedia.org/T107915) (owner: 10Mooeypoo) [23:52:36] (03CR) 10jenkins-bot: [V: 04-1] Create an OOUI widget for board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/219208 (https://phabricator.wikimedia.org/T101278) (owner: 10Mooeypoo) [23:55:12] 10Flow, 6Collaboration-Team-Backlog, 10Graph: Cannot use graph on Flow pages? - https://phabricator.wikimedia.org/T108644#1526236 (10Yurik) The URL fails because for some reason the graph has not been stored in a property page of any of the articles. See http://en.wikipedia.beta.wmflabs.org/wiki/Special:Pag...