[13:13:42] <Zppix>	 paladox: you around?
[13:17:31] <Zppix>	 paladox: im merging https://gerrit.wikimedia.org/r/#/c/323712/ can you deploy
[13:17:41] <Zppix>	 Give me a min
[13:20:54] <Zppix>	 !log merging https://gerrit.wikimedia.org/r/#/c/323712/
[13:20:56] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lolrrit-wm/SAL
[15:26:35] <paladox>	 ok
[15:26:37] <paladox>	 i am now
[15:28:49] <paladox>	 Zppix hi, you merged https://gerrit.wikimedia.org/r/#/c/323712/2 but we had problems with it.
[15:31:27] <paladox>	 I see that https://gerrit.wikimedia.org/r/#/c/323712/ is deploy.
[15:31:49] <paladox>	 Can we revert it then revert that again so we can have an open patch to try and fix it before merging it again?
[15:31:56] <paladox>	 marktraceur ^^
[15:32:35] <marktraceur>	 paladox: What problems? Nobody CR'd it until Zppix.
[15:32:54] <paladox>	 marktraceur rember that the bot kept creating new bots
[15:32:59] <paladox>	 like grrrit-wm1
[15:33:03] <paladox>	 then grrrit-wm2
[15:33:13] <marktraceur>	 I'm not sure that was this patch's fault, but okay
[15:33:14] <paladox>	 when we did grrrit-wm: force-restart.
[15:33:20] <marktraceur>	 Zppix: Did that happen when you tested it?
[15:40:27] <marktraceur>	 Zppix: Did that happen when you tested it?
[15:48:35] <Zppix>	 No
[15:48:57] <marktraceur>	 OK then! Sounds like we're good. Turns out code review works.
[15:49:11] <marktraceur>	 paladox: If you find it not working in practice, then we can try to fix it in a follow-up.
[15:49:30] <paladox>	 Ok, want me to deploy it?
[15:49:32] <Zppix>	 We dont go reverting unless its a major problem
[15:49:34] <Zppix>	 Yes
[15:49:44] <paladox>	 ok.
[15:50:48] <paladox>	 !log deploying https://gerrit.wikimedia.org/r/#/c/323712/
[15:50:50] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lolrrit-wm/SAL
[15:55:35] <paladox>	 grrrit-wm-test: force-restart
[16:38:17] <paladox>	 grrrit-wm-test: force-restart
[16:38:57] <paladox>	 grrrit-wm-test1: nick
[16:39:07] <paladox>	 grrrit-wm-test2: nick
[16:39:13] <paladox>	 marktraceur ^^ strange
[16:49:20] <paladox>	 grrrit-wm-test: force-restart
[16:49:45] <paladox>	 grrrit-wm-test1: force-restart
[16:52:41] <paladox>	 grrrit-wm-test: force-restart
[16:53:12] <paladox>	 grrrit-wm-test1: nick
[16:53:26] <paladox>	 marktraceur ^^
[16:53:41] <paladox>	 uh
[16:53:56] <paladox>	 most likly related to your functions you added
[16:53:57] <paladox>	 function bothConnected() {
[16:53:57] <paladox>	     if ( sshUp && ircUp && savedTo !== undefined ) {
[16:53:57] <paladox>	         ircClient.say( savedTo, "Successfully connected to IRC and SSH." );
[16:53:57] <paladox>	         savedTo = undefined;
[16:53:58] <paladox>	     }
[16:53:59] <paladox>	 }
[16:54:12] <paladox>	 function ircConnected( to ) {
[16:54:12] <paladox>	     ircUp = true;
[16:54:12] <paladox>	     savedTo = to;
[16:54:12] <paladox>	     logging.info( 'Connected to IRC.' );
[16:54:12] <paladox>	     bothConnected();
[16:54:13] <paladox>	 }
[16:55:43] <paladox>	 grrrit-wm-test: force-restart
[16:55:43] <marktraceur>	 paladox: Why would it be related to that?
[16:56:12] <paladox>	 because adding ircUp = undefined to function bothConnected() { made it do ^^
[16:56:30] <paladox>	 oh wait never mind, sorry.
[16:56:38] <paladox>	 grrrit-wm-test1: force-restart
[16:56:48] <paladox>	 grrrit-wm-test1: nick
[16:56:51] <marktraceur>	 paladox: Don't just add random things and see what happens. Try to explain what's happening based on the code.
[16:57:08] <paladox>	 Ok.
[16:57:15] <marktraceur>	 paladox: I think grrrit-wm-test1 is the phantom connection.
[16:57:22] <paladox>	 Yep.
[16:57:42] <paladox>	 I see nothing in the log. except from
[16:57:43] <paladox>	 error:  prefix=karatkievich.freenode.net, server=karatkievich.freenode.net, command=err_cannotsendtochan, rawCommand=404, commandType=error, args=[grrrit-wm-test, #wikimedia-bot-gerrit, Cannot send to channel]
[16:57:50] <paladox>	 i am going to enable debug: true
[17:00:10] <paladox>	 grrrit-wm-test: force-restart
[17:00:38] <paladox>	 15 Dec 17:00:20 - MODE: grrrit-wm-test sets mode: +Zi
[17:00:38] <paladox>	 15 Dec 17:00:21 - SEND: NICK grrrit-wm-test1
[17:00:42] <paladox>	 marktraceur ^^
[17:01:11] <paladox>	 15 Dec 17:00:55 - Connection got "end" event
[17:01:11] <paladox>	 15 Dec 17:00:55 - Connection got "close" event
[17:01:11] <paladox>	 15 Dec 17:00:55 - Disconnected: reconnecting
[17:01:11] <paladox>	 15 Dec 17:00:55 - Waiting 2000ms before retrying
[17:01:20] <paladox>	 ^^
[17:01:32] <marktraceur>	 ...hm
[17:03:27] <paladox>	 grrrit-wm-test: nick
[17:03:33] <paladox>	 grrrit-wm-test1: nick
[17:03:42] <marktraceur>	 paladox: Wait, was that the full log?
[17:03:48] <paladox>	  nope
[17:03:52] <marktraceur>	 Can you pastebin what happened between those bits?
[17:03:53] <paladox>	 there is a bigger log
[17:03:54] <paladox>	 yeh
[17:09:45] <paladox>	 https://phabricator.wikimedia.org/P4629
[17:12:54] <paladox>	 grrrit-wm-test: force-restart
[17:13:19] <paladox>	 grrrit-wm-test1: nick
[17:14:50] <marktraceur>	 paladox: Interesting, it looks like there's an untouched ping cycler that may be causing the issue?
[17:14:59] <paladox>	 Oh
[17:15:56] <paladox>	 marktraceur could it be a regression to a fix done in https://github.com/martynsmith/node-irc/issues/76 ?
[17:16:40] <marktraceur>	 I don't think it's a library problem, but we'll see
[17:16:53] <paladox>	 https://github.com/martynsmith/node-irc/pull/176
[17:16:55] <paladox>	 oh ok
[17:17:35] <paladox>	 https://github.com/martynsmith/node-irc/pull/176#issuecomment-25537049
[17:17:44] <paladox>	 what about that workaround ^^
[17:17:45] <paladox>	 ?
[17:18:00] <paladox>	 https://github.com/martynsmith/node-irc/pull/418
[17:18:15] <marktraceur>	 paladox: I dunno. I'm busy for now, I'll come back and help in a bit
[17:18:21] <paladox>	 Ok
[17:37:10] <paladox>	 grrrit-wm-test2: nick
[18:16:33] <Zppix>	 Its kina weird that 2 ppl tested and it worked fine
[18:16:48] <Zppix>	 marktraceur:
[18:16:51] <Zppix>	 paladox:
[18:17:15] <paladox>	 Yep, are you sure Zppix you tested it long enough for it to show what it showed in this channel?
[18:18:44] <Zppix>	 I tested it just as marktraceur did
[18:19:01] <paladox>	 yes but did you have the bot running long enough for it to do what it did for me
[18:19:07] <marktraceur>	 Zppix: I think I noticed some strangeness, but not enough to worry me.
[18:19:08] <paladox>	 did you also run the commands?
[18:19:40] <Zppix>	 I noticed an error that we already knew about the [] thing
[18:19:56] <Zppix>	 I run them all but the help command paladox
[18:20:08] <paladox>	 Ok
[21:11:51] <Zppix>	 paladox: can you merge my config change
[21:12:30] <paladox>	 https://gerrit.wikimedia.org/r/#/c/327121/
[21:12:31] <paladox>	 ?
[21:13:25] <Zppix>	 Yes
[21:13:48] <paladox>	 ok
[21:14:36] <Zppix>	 Dont forget to log the merge
[21:14:39] <paladox>	 ok
[21:14:46] <paladox>	 !log merging https://gerrit.wikimedia.org/r/#/c/327121/
[21:14:48] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lolrrit-wm/SAL
[21:19:52] <paladox>	 !log deploying https://gerrit.wikimedia.org/r/#/c/327121/
[21:19:55] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Nova_Resource:Tools.lolrrit-wm/SAL
[21:24:30] <Zppix>	 Is it deployed?
[21:24:37] <paladox>	 Yep
[21:27:08] <Zppix>	 Im not gonna log your fix
[21:27:12] <Zppix>	 Since its so minor
[21:28:01] <paladox>	 ok
[21:29:06] <paladox>	 Zppix https://gerrit.wikimedia.org/r/#/c/327587/1
[21:29:23] <Zppix>	 Go ahead and merge it
[21:29:38] <paladox>	 Ok, but you need to merge it
[21:29:44] <paladox>	 as i carnt merge my own patches
[21:29:45] <paladox>	 please
[21:29:48] <Zppix>	 K
[21:30:07] <paladox>	 Thanks
[21:33:09] <Zppix>	 Hmm why did grrrit-wm leave my chan
[21:33:18] <marktraceur>	 Spite?
[21:33:22] <Zppix>	 Nm
[21:33:39] <paladox>	 It is restarting
[21:33:54] <paladox>	 when you deploy changes it leaves the channels then rejoins
[21:34:33] <Zppix>	 Spite?
[21:34:38] <Zppix>	 marktraceur: ?
[21:35:17] <marktraceur>	 Zppix: https://en.wiktionary.org/wiki/spite