[18:36:36] paladox how did my quit msg change work out? [18:36:51] Zppix it did not work [18:37:39] paladox damn, what have you tried? [18:37:54] Haven't tryed much yet [18:38:08] hold on imma edit the patch on gerrit and i want you to try that ok? [18:38:17] Trying to add tag support in the web ui here https://gerrit-review.googlesource.com/#/c/92147/ [18:40:50] i added the new code i want tested [18:40:55] can you test it real quick? [18:42:42] Where [18:42:49] i carn't see any updates on the patch [18:42:51] Zppix ^^ [18:43:26] it helps if you publish the edit... [18:43:35] Ok [18:43:41] Zppix why change the nick? [18:43:56] we already attempted to do quit message [18:43:57] Because it will most likly cause problems when it trys to rejoin [18:44:08] Good point I prob will need to change its name again. [18:44:11] one sec [18:44:34] Zppix https://github.com/martynsmith/node-irc/issues/486 [18:44:39] I filled the issue there ^^ [18:45:28] I guess we could try sending messages to all channels [18:45:35] I will see if i can do that later [18:45:36] there [18:45:38] Zppix ^^ [18:45:51] paladox we cannot send messgae to all chans it will give a flood prevention kick [18:46:14] Zppix not really, since we can use a for each code i think [18:47:44] Still, sending every chan a message instead of renaming or quit msg is uneeded noise [18:48:14] But wont the changing nick be noise too? [18:48:48] Also it is changing it to Restarting so from grrrit-wm to Restarting [18:48:57] It may be rejected by marktraceur. [18:49:16] unless you can get a quit message working i see no other way [18:49:36] * marktraceur is summoned. [18:49:43] unless i go to freenode staff and ask for a flood prevention exemption for the bot [18:49:44] Why didn't the quit message work? [18:49:49] marktraceur we dont know [18:49:55] What did you try? [18:50:30] marktraceur apparently irc may be flakly [18:50:32] ircClient.send('QUIT','Message'); and ircClient.disconnect('Message') [18:50:39] as the package author says it works for him [18:50:43] So it is strange. [18:51:36] https://gerrit.wikimedia.org/r/323342 [18:52:16] So...first, Restarting is undefined [18:52:33] Second, it looks like the message you're sending is the default "Quit" anyway, so of course that's what would show up [18:53:00] marktraceur i have been trying on the test bot a different msg [18:53:08] but that dosen't work [18:53:19] Can you show me the code and run the test here? [18:53:22] Ok [18:54:39] marktraceur ^^ [18:54:44] I see the join, yes. [18:54:48] i am going to do the restarting command now. [18:54:58] grrrit-wm-test: force-restart [18:54:59] Re-connecting to Gerrit and IRC. [18:55:05] It says Client Quit [18:55:37] paladox: What happens if you change it to disconnect( 'restarting' ); [18:55:44] Let me try that one [18:55:46] thanks [18:57:01] grrrit-wm-test: force-restart [18:57:01] Re-connecting to Gerrit and IRC. [18:57:06] Wait. [18:57:08] oh [18:57:10] woops sorry [18:57:26] There must be an error or something causing it to fail, because it doesn't come back [18:57:35] It will be back in a sec [18:57:40] takes a bit to reconnect to irc [18:57:42] Oh wait [18:57:43] It didn't last time. [18:57:49] disconnect disconnects the whole thing [18:57:57] so it wont rejoin [18:59:13] paladox: So you need to reinitialize the connection, I guess [18:59:19] Ok [18:59:24] i have done [18:59:24] ircClient.addListener('join', waitForChannelJoins); [18:59:31] under the disconnect one [18:59:36] Why? [18:59:38] grrrit-wm-test: force-restart [18:59:39] Re-connecting to Gerrit and IRC. [18:59:43] so it can reconnect [18:59:50] That's not a reconnect command. [18:59:54] It's a listener command. [18:59:57] Oh [19:00:02] Do you still not understand what an event listener is? [19:00:13] Yes i know what an event listener is [19:00:21] Then explain to me what that line does. [19:00:43] It listens to events done by the code. [19:01:01] paladox: Which events, specifically? [19:01:15] waitForChannelJoins [19:01:25] It listens to join, but calls waitForChannelJoins); [19:01:35] Right. [19:01:40] grrrit-wm-test: force-restart [19:01:40] Re-connecting to Gerrit and IRC. [19:01:45] paladox: So explain to me how the line reconnects the client. [19:02:04] I thought it did a minute ago, but looking again it dosen't [19:02:09] OK then. [19:02:20] paladox: How much time have you spent looking at the node-irc documentation? [19:02:20] this waitForChannelJoins function calls startRelay(); [19:02:25] did the freenode just netsplit? [19:02:27] I have spent alot of time. [19:02:48] paladox: Funny because it only took me about fifteen seconds to find the documentation for the connect() function. [19:03:18] marktraceur i've read the offical node irc documentatino and and every other unoffical documentation and i still cant find out why the hell this quit message wont work [19:03:22] Oh [19:03:29] i wasent looking at the connect function [19:03:44] i was looking at how to get the quit msg working so i may have missed that [19:03:51] but i was skimming the text [19:03:52] We're working on that Zppix, but the suggestion from the dev to use disconnect() instead of send( 'QUIT' ) seems like a good place to start [19:04:04] paladox: How about this, do the bot's logs say anything about any errors? [19:04:11] Nope [19:04:24] Odd. [19:04:41] marktraceur you kidding me my coding never give errors, im just that stealthy :P jk [19:04:54] Helpful [19:05:14] Zppix: Given you're the one who forgot to put quotes around "Restarting", causing an undefined variable reference, I wouldn't be so cocky [19:05:27] marktraceur i've done it both ways seeing if that was the issue [19:05:38] What version of node-irc are you guys using? [19:05:43] latest i believe [19:05:51] Can you confirm? [19:05:57] The very latest [19:05:58] 0.5.2 [19:06:12] paladox has shell open and i dont but i can open it if you wish [19:06:18] ... nevermind i see now that paladox beat me to it [19:06:22] grrrit-wm-test: force-restart [19:06:23] Re-connecting to Gerrit and IRC. [19:06:27] OK, latest version is 2.1 [19:06:40] marktraceur latest stable? [19:06:40] re-connected to Gerrit and IRC. [19:06:49] we dislike unstablity [19:06:56] I don't know what stable is. Looking. [19:07:10] marktraceur https://github.com/martynsmith/node-irc/releases/tag/v0.5.2 [19:08:08] Ah, looks like their releases aren't well indexed by the documentation. [19:08:19] Yep [19:08:40] paladox: What code are you using for the disconnect command currently? [19:08:58] ircClient.disconnect( 'restarting' ); [19:09:10] OK... [19:09:12] I have now set this [19:09:12] ircClient.disconnect( 'restarting' ); [19:09:12] ircClient.connect(); [19:09:35] but connect seems to cause the nick to change on rejoinning to add a 1 to the nick. [19:09:35] paladox: Wait, you immediately try connect()? Why not do that in the callback? [19:09:52] Yeah, because the IRC connection isn't instantaneous [19:10:02] Oh because i thought we need to do it after disconnect [19:10:17] We do, but not until the disconnect is complete. [19:10:31] either that or add the timeout func [19:10:40] If you had spent more time reading the documentation, you would have seen the callback argument for the disconnect method [19:10:45] Zppix: Oh my god no [19:11:48] whynot [19:11:57] what does the optional callback do? [19:12:04] paladox: It's a CALLBACK FUNCTION. [19:12:17] This is basic asynchronous programming, people [19:12:19] paladox waits until the disconnect in this case to complete [19:12:27] Oh thanks, what would go in there? [19:12:36] connect [19:12:37] The call to connect(). [19:12:41] Oh [19:12:42] thanks [19:13:04] so is this possible Client.disconnect([message[, Client.connect]]) [19:13:07] NO. [19:13:09] message being 'test' [19:13:13] oh [19:13:33] ircClient.disconnect( 'test', function () { ircClient.connect(); } ); [19:13:47] Ah [19:13:48] thanks [19:14:10] But you should be doing much, much more with the callbacks. [19:14:26] Yeh, i will need to change the nick on rejoin [19:14:32] so instead of it adding a number [19:14:49] grrrit-wm-test: force-restart [19:14:49] Re-connecting to Gerrit and IRC. [19:14:58] No, if you wait for the disconnect to finish, the number won't be added. [19:15:06] re-connected to Gerrit and IRC. [19:15:14] oh [19:15:20] ^^ it seemed it did. [19:15:30] Well, fair enough, not too hard to change the nick [19:15:37] Ok [19:17:17] paladox: Is the code you're testing available on a gerrit change somewhere? [19:17:39] Nope [19:17:51] Could you make it so, then I can check it [19:18:01] Ok [19:19:21] marktraceur https://gerrit.wikimedia.org/r/#/c/323709/ [19:21:25] grrrit-wm-test: force-restart [19:21:25] Re-connecting to Gerrit and IRC. [19:21:27] paladox: I suspect there may be a problem with the ircClient.say calls that are after disconnect() and outside a callback. [19:21:33] Oh [19:21:42] re-connected to Gerrit and IRC. [19:21:55] paladox: Try removing the "Ended SSH connection" message, it never fires anyway. [19:22:02] Ok [19:24:35] grrrit-wm-test: force-restart [19:24:36] Re-connecting to Gerrit and IRC. [19:24:49] Hmmm [19:24:53] re-connected to Gerrit and IRC. [19:25:40] error: prefix=adams.freenode.net, server=adams.freenode.net, command=err_nosuchnick, rawCommand=401, commandType=error, args=[grrrit-wm-test2, grrrit-wm-test, No such nick/channel] [19:25:52] Oh [19:25:57] Thaaat's the problem [19:25:59] LOL it joined twice. [19:26:22] grrrit-wm-test: nick [19:26:22] Nick is already grrrit-wm-test not changing the nick. [19:26:22] Nick is already grrrit-wm-test not changing the nick. [19:26:34] oi vey [19:26:41] Oh wait, that may be ssh [19:26:49] no thats not ssh [19:26:53] thats the code [19:28:38] grrrit-wm-test: force-restart [19:28:39] Re-connecting to Gerrit and IRC. [19:28:57] re-connected to Gerrit and IRC. [19:29:32] grrrit-wm-test1: nick [19:29:35] grrrit-wm-test1: nick [19:29:38] grrrit-wm-test2: nick [19:29:42] wtf [19:29:53] LOL. [19:29:59] atleast it can count... [19:30:25] im curious what does the prod bot do (does it act the same?) [19:30:43] Probably not. I'd guess that the callbacks are broken. [19:30:58] so we may have to resort to timeout functions? [19:31:01] No. [19:31:03] Never. [19:31:05] Never that. [19:31:07] Stop suggesting that. [19:31:10] That is never the solution. [19:31:12] we do that for the nick command? [19:31:22] Yeah, because you couldn't figure out how to do it properly [19:31:35] actually disregard its the old force-restart code [19:31:38] I'll fix that once I figure out why this disconnect message isn't working [19:31:54] marktraceur could it be the new precise deprication? [19:32:07] No. The depr*e*cation of precise is probably not to blame. [19:32:25] This is almost certainly some unseen error in the code that is causing problems. [19:32:29] grrrit-wm-test: force-restart [19:32:29] Re-connecting to Gerrit and IRC. [19:32:40] paladox: Can you try resetting the code to what it is currently? [19:32:46] re-connected to Gerrit and IRC. [19:32:47] Ok [19:32:58] i know what it is doing [19:33:00] thats my fault [19:33:17] paladox when it reconnects its renaming itself back to grrrit-wm-test [19:33:21] causing the number [19:33:30] done [19:33:35] starting it up now# [19:33:36] no [19:33:37] Cool. [19:33:38] now [19:33:50] grrrit-wm-test: force-restart [19:33:53] Re-connecting to Gerrit and IRC. [19:33:57] Same problem. [19:34:03] Yep [19:34:08] The problem exists in the current master, so it's not a new issue [19:34:11] re-connected to Gerrit and IRC. [19:34:17] hey i fixed the other problem! [19:34:19] marktraceur apparently it works for the author of the package [19:34:33] marktraceur https://github.com/martynsmith/node-irc/issues/486#issuecomment-263034831 [19:34:37] paladox: I'm going to send you a test change on the same gerrit patch. [19:34:42] Ok [19:36:07] paladox: Pull it and try again [19:36:18] It won't do everything but it might help us diagnose the issue. [19:36:33] Ok [19:36:54] marktraceur should we just do disconnect msg and then start implementing the reconnect stuff after we find out the disconnect msg [19:37:04] Zppix: No, I think we can do both. [19:37:15] starting up now [19:37:29] grrrit-wm-test: force-restart [19:37:33] Hmm [19:37:40] marktraceur is it possible that the bot code for disconnection is quitting the code line too early for it read the quit message? [19:37:58] grrrit-wm-test1: nick [19:38:10] paladox: I removed more code from the beginning of that path, try pulling again [19:38:14] Ok [19:38:21] Zppix: No [19:38:30] what nows there 2 [19:38:31] again [19:39:14] starting up [19:39:20] Zppix disconnect again [19:39:23] seems broken [19:39:28] grrrit-wm-test: force-restart [19:39:32] Hmmm [19:39:36] i think quit you can reuse the connection so that's why it worked. [19:39:45] OK I'm starting to seriously question what is happening here. [19:39:58] grrrit-wm-test1: nick [19:40:12] grrrit-wm-test: force-restart [19:40:24] grrrit-wm-test1: force-restart [19:40:28] grrrit-wm-test: force-restart [19:40:39] grrrit-wm-test: force-restart [19:40:40] paladox: New PS, trying to log the error. [19:40:42] grrrit-wm-test2: force-restart [19:40:43] ok [19:40:54] That whole code path has a try-catch around it that would suppress any errors. [19:41:31] Oh [19:41:47] started [19:41:59] grrrit-wm-test: force-restart [19:42:06] paladox: Check for errors. [19:42:21] nope no errors [19:42:22] tools.lolrrit-wm@tools-bastion-03:~/gerrit$ vi src/r* [19:42:22] tools.lolrrit-wm@tools-bastion-03:~/gerrit$ node src/relay.js [19:42:22] info: joining channels 0=#wikimedia-bot-gerrit, 1=#wikimedia-bots-testing [19:42:22] info: grrrit-wm-test joined #wikimedia-bot-gerrit [19:42:22] info: Joined channel #wikimedia-bot-gerrit [19:42:23] info: grrrit-wm-test joined #wikimedia-bots-testing [19:42:25] info: Joined channel #wikimedia-bots-testing [19:42:27] info: Joined 2 channels. Starting relay [19:42:29] info: Connecting to gerrit.. [19:42:31] info: Connected; requesting stream-events [19:42:33] info: Connected to event stream! [19:42:37] error: prefix=weber.freenode.net, server=weber.freenode.net, command=err_alreadyregistred, rawCommand=462, commandType=error, args=[grrrit-wm-test, You may not reregister] [19:42:46] paladox tip: use pastebin or phab pastes [19:42:50] Sorry [19:43:22] why is nickserv saying its already registered i dont remember ever registering grrrit-wm-test's nick? [19:43:48] Because it registers automatically, probably. [19:44:02] It is not registered in nickserv [19:44:14] and it is probaly using the wrong password . [19:44:28] Maybe it's using a duplicate e-mail address. [19:44:39] Oh [19:45:20] * marktraceur sighs [19:45:53] Maybe it's labs [19:45:54] ? [19:46:00] I doubt it. [19:46:03] for the problem with quit not showing the message [19:46:19] I'm going to try fixing some of the myriad other problems with this code. [19:46:21] We can go from there. [19:46:32] Ok [19:46:32] thanks [19:47:58] marktraceur if the quit messages dont work i can try to get a fllood prevention exemption for the prod bot [19:48:06] No. [19:48:15] keyword: IF [19:48:18] Zppix: Don't give up on the correct solution just because it's hard. [19:48:30] And don't implement the wrong solution just because you can't fix something. [19:48:44] marktraceur i'm not infact im reading every piece of documentation i can find rn [19:49:12] who the hell is host86-131-250-252.range86-131 [19:49:47] That would be me [19:49:52] why? [19:49:52] i am trying it on my machine [19:49:58] grrrit-wm-test: force-restart [19:49:59] Re-connecting to Gerrit and IRC. [19:50:09] confirmed not labs problem [19:50:12] it's the code [19:50:17] paladox we already knew that [19:50:22] Ok [19:51:20] all labs is, is a server, with a firewall protection and a company-level network, if it was a labs issue it wouldnt even connect to irc in the first place. [19:51:52] ok [19:52:00] Some of these functions have four logging calls, none of which are correct [19:52:07] This is terrible, guys. [19:52:50] Sorry. [19:53:08] grrrit-wm-test: force-restart [19:53:49] brb [19:53:50] dinner [20:11:22] Zppix, paladox, can one of you tell me how to alter config so I can test my change? [20:12:01] Oh, god [20:12:05] It's saved in the repository [20:16:22] ? [20:16:42] what is [20:17:58] Never mind. [20:20:49] grrrit-mt-test: force-restart [20:20:54] Hm. [20:20:58] Still not doing it properly [20:21:15] grrrit-mt-test1: nick [20:22:05] grrrit-mt-test2: nick [20:22:22] it can count [20:22:29] and why is it mt lol [20:22:42] Zppix: Because it's my instance. [20:23:11] (CR) jenkins-bot: [V: -1] Use P31 instead of P2 in one of docs [extensions/Wikibase] - https://gerrit.wikimedia.org/r/323679 (owner: Ladsgroup) [20:23:14] But anyway, it's working and I've cleaned up a bunch of problems [20:24:34] Going to look into the disconnect issue now. [20:30:28] grrrit-mt-test: force-restart [20:31:19] Huh. [20:34:23] grrrit-mt-test: force-restart [20:35:34] grrrit-mt-test: force-restart [20:41:47] grrrit-mt-test: force-restart [20:41:55] God damn it. [20:42:52] grrrit-mt-test: force-restart [20:44:58] grrrit-mt-test: force-restart [20:50:45] (CR) VolkerE: "+1 besides one minor question." (2 comments) [extensions/Echo] - https://gerrit.wikimedia.org/r/323554 (owner: Ladsgroup) [20:53:00] paladox: When you get back, can you confirm that you see my part message above? [20:53:09] Because I am at the basest level of sanity check right now. [20:53:35] Oh, I guess I could do it. [20:54:39] OK, so, it seems like part messages are visible, but for some reason, they're getting lost with unregistered users [20:57:00] I think the message works, just not with the test bot, because the test bot isn't registered. [20:57:11] I imagine that's a problem with Freenode, not the bot. [21:04:33] Hi sorry for being late back [21:08:50] marktraceur i did handle = setInterval(startRelay, 10000); so it could keep retrying to connect through ssh when ssh is closed. [21:09:11] Ugh [21:09:18] So why wouldn't you do it in the EVENT HANDLER [21:09:56] Not sure, just that the maintainer of ssh2 told me to do that [21:10:11] paladox: Did they do that publicly? Can you show me the thread? [21:10:19] Yep let me find it [21:11:16] marktraceur https://github.com/mscdex/ssh2/issues/491#issuecomment-258047263 [21:12:33] paladox: That thread only says that setInterval caused problems. [21:13:00] No i was trying to restart the ssh connection [21:13:16] so that is how he told me to do it, i had to change it though [21:13:23] paladox: Show me the message the maintainer sent to you that says "use setInterval". [21:13:54] Because I'm doing Ctrl+F interval on that page, and I only see you saying "oh, setInterval caused the bug" and him saying "yeah, setInterval would obviously cause that bug." [21:14:00] Because of course it would cause the bug. [21:14:37] He did not tell me to use that, but told me to do subscribeToGerritStream(host, port, username, keypath, listener); in there [21:14:40] Yeah [21:14:48] Which we changed to startRelay later. [21:14:53] Yep [21:15:04] paladox: So what's the problem with the patch again? [21:15:17] It wont reconnect to ssh when it disconnects [21:15:20] IE auto reconnect [21:15:23] Yes. It will. [21:15:29] oh, let me try [21:15:34] I'll show you. [21:15:41] grrrit-mt-test: restart [21:15:42] Ended SSH connection to Gerrit. [21:16:09] It didn't log, but it's reconnected. We can wait for an event. [21:17:05] Ok [21:17:25] grrrit-wm-test: force-restart [21:17:26] Oops. [21:17:40] grrrit-mt-test: restart [21:17:41] Ended SSH connection to Gerrit. [21:19:59] grrrit-wm-test1: nick [21:20:11] grrrit-wm-test2: nick [21:20:16] (CR) Magul: [C: -1] New page generators (T150222). (5 comments) [pywikibot/core] - https://gerrit.wikimedia.org/r/321089 (https://phabricator.wikimedia.org/T150222) (owner: XXN) [21:20:17]