[00:02:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Cursor position jumps when starting to edit on tablet - https://phabricator.wikimedia.org/T222318 (10XanonymusX) [00:19:35] (03Merged) 10jenkins-bot: ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507704 (https://phabricator.wikimedia.org/T221289) (owner: 10Bartosz Dziewoński) [00:21:02] (03CR) 10jenkins-bot: ve.ui.MWSaveDialog: More save panel disappearing on iOS Safari [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507704 (https://phabricator.wikimedia.org/T221289) (owner: 10Bartosz Dziewoński) [02:44:09] 10VisualEditor: [Regression pre-wmf.4] There is a "Publish changes" button under Insert drop down - https://phabricator.wikimedia.org/T222325 (10Ryasmeen) [07:18:39] 10VisualEditor: [Regression pre-wmf.4] There is a "Publish changes" button under Insert drop down - https://phabricator.wikimedia.org/T222325 (10Schnark) Probably caused by {f9330c8564ee} (now that it is a tool, the insert menu includes it because it includes all "other" tools by default). [08:24:50] 10Citoid: Citoid extension should pass through BCP47 language codes to the accept-language param instead of MW codes to the citoid api - https://phabricator.wikimedia.org/T222343 (10Mvolz) [08:25:29] 10Citoid: Citoid extension should pass through BCP47 language codes to the accept-language param instead of MW codes to the citoid api - https://phabricator.wikimedia.org/T222343 (10Mvolz) p:05Triage→03Normal [08:30:00] 10Citoid: Citoid extension should pass through BCP47 language codes to the accept-language param instead of MW codes to the citoid api - https://phabricator.wikimedia.org/T222343 (10Mvolz) [08:30:15] 10Citoid, 10VisualEditor: Citoid extension should pass through BCP47 language codes to the accept-language param instead of MW codes to the citoid api - https://phabricator.wikimedia.org/T222343 (10Mvolz) [10:40:39] 10VisualEditor, 10Patch-For-Review: Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10Esanders) Switching from WTE to VE with changes shouldn't be possible on a non-restbase setup. Restbase is required to stash the modified HTML version of... [11:33:40] (03PS6) 10Mvolz: [WIP] Remove dependancy on VE, add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) [11:35:29] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Remove dependancy on VE, add wikibase module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/496748 (https://phabricator.wikimedia.org/T196353) (owner: 10Mvolz) [12:41:04] (03CR) 10Esanders: [C: 04-1] "Comment on task" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507711 (https://phabricator.wikimedia.org/T222312) (owner: 10Bartosz Dziewoński) [13:06:27] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Editing Design: Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10iamjessklein) [13:10:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Editing Design: Remove "internal" and "external" tabs from the link inspector - https://phabricator.wikimedia.org/T222082 (10iamjessklein) a:03iamjessklein +1 thanks for writing this up @Esanders - I agree! In my latest round of mockups for [[ https://phab... [14:46:53] 10VisualEditor: Edit cards: instrument revised "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221305 (10ppelberg) [14:46:55] 10VisualEditor: Edit cards: instrument existing "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221306 (10ppelberg) [14:46:57] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10ppelberg) [14:46:59] 10VisualEditor: Edit card: confirm instrumentation for existing VE linking flow - https://phabricator.wikimedia.org/T221254 (10ppelberg) [14:47:01] 10VisualEditor: Edit card: get legal approval for workflow instrumentation - https://phabricator.wikimedia.org/T221250 (10ppelberg) [14:47:03] 10VisualEditor: Edit card: implement workflow instrumentation - https://phabricator.wikimedia.org/T221252 (10ppelberg) [14:47:05] 10VisualEditor: Edit cards: instrument revised "adding/modifying links" flow - https://phabricator.wikimedia.org/T221249 (10ppelberg) [14:47:16] 10VisualEditor: Edit cards: instrument revised "adding/modifying links" flow - https://phabricator.wikimedia.org/T221249 (10ppelberg) [14:47:48] 10VisualEditor: Edit card: get legal approval for workflow instrumentation - https://phabricator.wikimedia.org/T221250 (10ppelberg) [14:47:54] 10VisualEditor: Edit card: implement workflow instrumentation - https://phabricator.wikimedia.org/T221252 (10ppelberg) [14:48:10] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10ppelberg) [14:48:16] 10VisualEditor: Edit cards: instrument revised "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221305 (10ppelberg) [14:48:21] 10VisualEditor: Edit cards: instrument existing "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221306 (10ppelberg) [14:48:35] 10VisualEditor: Edit card: confirm instrumentation for existing VE linking flow - https://phabricator.wikimedia.org/T221254 (10ppelberg) [15:03:03] (03PS4) 10DLynch: TableNode: Change mobile behavior so initial tap enters the cell [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) [15:08:16] (03CR) 10DLynch: "Okay, disabled it on mobile. Also fixed a bug where it'd have an error if you tried to drag the TableSelection from the currently selected" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [15:57:45] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 11 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784 (10Jdlrobson) [16:00:40] 10VisualEditor, 10MobileFrontend, 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Tracking): AbuseFilter warnings and errors are handled badly by the editor - https://phabricator.wikimedia.org/T202460 (10Jdlrobson) [16:00:59] 10Editing-team, 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: [EPIC] Cleanup Mobile editor error handling - https://phabricator.wikimedia.org/T202374 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson I'm closing this epic as it seems to... [16:17:54] 10VisualEditor: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10DLynch) I recall poking around for this in the past, and we've been fairly good at avoiding the model knowing about its views. Which is sensible design, but inconvenient at times like this. [17:05:48] (03PS1) 10DLynch: MWInternalLinkAnnotationWidget: adjust the input for relative links to subpages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507841 (https://phabricator.wikimedia.org/T110413) [17:10:20] (03CR) 10DLynch: "This is an alternate approach to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/503441 in response to Bartosz's conc" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507841 (https://phabricator.wikimedia.org/T110413) (owner: 10DLynch) [17:13:28] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) [17:14:54] 10VisualEditor: Can't reliably gather list of annotation views from a DM offset - https://phabricator.wikimedia.org/T221967 (10Esanders) That's correct, but the pattern for nodes is `view.getNodeFromOffset( modelOffset )` which doesn't violate that rule, so we should have something similar for annotations. [18:17:52] (03CR) 10Esanders: [C: 04-1] "Properties/Delete now don't work as the selection is linear." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [18:28:25] (03PS1) 10Esanders: TableNode performance: Only change selection when endCell changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507857 [18:32:23] (03CR) 10DLynch: "> Patch Set 4: Code-Review-1" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/507369 (https://phabricator.wikimedia.org/T211240) (owner: 10DLynch) [19:44:31] 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Verified, 10VisualEditor (Current work): [Regression pre-wmf.2] Switching back from the diff panel to the save form on mobile VE makes the form go empty - https://phabricator.wikimedia.org/T221289 (10Ryasmeen) [19:58:19] 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Jdforrester-WMF) [19:59:32] 10VisualEditor: Edit cards: instrument existing "adding/modifying links" flow - https://phabricator.wikimedia.org/T221296 (10ppelberg) a:03DLynch [20:17:14] 10VisualEditor: Edit cards: instrument revised "adding/modifying citations" flow - https://phabricator.wikimedia.org/T221305 (10ppelberg) a:05ppelberg→03DLynch [20:21:19] 10VisualEditor: Edit cards: instrument revised "adding/modifying links" flow - https://phabricator.wikimedia.org/T221249 (10ppelberg) a:05ppelberg→03DLynch [20:30:37] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10thcipriani) > Someone... [20:36:49] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Niedzielski) I've reb... [22:14:13] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10User-Ryasmeen, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on so... - https://phabricator.wikimedia.org/T222229 [22:17:47] 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10User-Ryasmeen, and 2 others: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (... [22:46:57] 10VisualEditor: [Regression pre-wmf.4] There is a "Publish changes" button under Insert drop down - https://phabricator.wikimedia.org/T222325 (10Ryasmeen) p:05Triage→03High [22:58:06] (03PS1) 10Jforrester: Follow-up f9330c8564ee: Don't auto-add MWSaveTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507899 (https://phabricator.wikimedia.org/T222325) [22:58:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: [Regression pre-wmf.4] There is a "Publish changes" button under Insert drop down - https://phabricator.wikimedia.org/T222325 (10Jdforrester-WMF) [23:13:38] (03CR) 10Esanders: [C: 03+2] "I think you only need the catch-all, but whatever." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507899 (https://phabricator.wikimedia.org/T222325) (owner: 10Jforrester) [23:35:47] (03Merged) 10jenkins-bot: Follow-up f9330c8564ee: Don't auto-add MWSaveTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507899 (https://phabricator.wikimedia.org/T222325) (owner: 10Jforrester) [23:37:26] (03CR) 10jenkins-bot: Follow-up f9330c8564ee: Don't auto-add MWSaveTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/507899 (https://phabricator.wikimedia.org/T222325) (owner: 10Jforrester)