[07:36:10] 10VisualEditor, 10VisualEditor-MediaWiki: Width of suggestions for edit summaries doesn't match width of input - https://phabricator.wikimedia.org/T220177 (10Schnark) [07:47:33] 10VisualEditor, 10Advanced Mobile Contributions, 10MobileFrontend, 10Readers-Web-Backlog, 10Browser-Support-Google-Chrome: Scroll springs back on Chrome for iOS when in desktop mode - https://phabricator.wikimedia.org/T220174 (10RhinosF1) [11:21:52] 10VisualEditor-MediaWiki, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used - https://phabricator.wikimedia.org/T50274 (10Esanders) [12:41:20] (03PS1) 10Esanders: EditSummaryWidget: Don't show suggestions on focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501558 (https://phabricator.wikimedia.org/T220176) [13:04:42] (03PS2) 10Esanders: EditSummaryWidget: Don't show suggestions on focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501558 (https://phabricator.wikimedia.org/T220176) [13:15:07] (03CR) 10Esanders: [C: 03+2] Update VE core submodule to master (8653ce4bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501431 (https://phabricator.wikimedia.org/T220091) (owner: 10Jforrester) [13:17:54] (03PS2) 10Esanders: Filibuster: display backward selections differently from forward ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498345 (owner: 10Divec) [13:17:58] (03CR) 10Esanders: [C: 03+2] Filibuster: display backward selections differently from forward ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498345 (owner: 10Divec) [13:19:58] (03Merged) 10jenkins-bot: Filibuster: display backward selections differently from forward ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498345 (owner: 10Divec) [13:21:43] (03CR) 10jenkins-bot: Filibuster: display backward selections differently from forward ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498345 (owner: 10Divec) [13:26:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (8653ce4bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501431 (https://phabricator.wikimedia.org/T220091) (owner: 10Jforrester) [13:29:10] (03CR) 10jenkins-bot: Update VE core submodule to master (8653ce4bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501431 (https://phabricator.wikimedia.org/T220091) (owner: 10Jforrester) [13:29:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review: Suggestion for edit comments can appear without interaction - https://phabricator.wikimedia.org/T220176 (10Esanders) [13:29:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10OOUI: Width of suggestions for edit summaries doesn't match width of input - https://phabricator.wikimedia.org/T220177 (10Esanders) [13:46:13] (03PS1) 10Esanders: EditSummaryWidget: Disable pending animation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501572 [13:48:57] (03PS1) 10Esanders: Remove unnecessary duplications of 'default' theme files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501573 [13:51:16] 10VisualEditor, 10RESTBase, 10Core Platform Team (RESTBase Split (CDP2)), 10Core Platform Team Backlog (Later), 10Services (designing): Consider deprecating section editing API in RESTBase - https://phabricator.wikimedia.org/T216636 (10ssastry) I read both tickets closely now and here are my thoughts. I... [13:54:01] (03PS2) 10Esanders: Use nullSelectionOnBlur=false for ArticleTargets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/500757 (https://phabricator.wikimedia.org/T208826) [15:27:12] (03CR) 10Jforrester: "Hmm. The native browser behaviour is to how suggestions on focus, though… Maybe only do this when the content is not empty?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501558 (https://phabricator.wikimedia.org/T220176) (owner: 10Esanders) [15:49:19] (03PS5) 10Divec: Call handleInsertion on beforeinput [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/498528 (https://phabricator.wikimedia.org/T217223) [18:05:12] 10Citoid, 10Release Pipeline, 10serviceops, 10Patch-For-Review, and 2 others: Migrate citoid to kubernetes - https://phabricator.wikimedia.org/T213194 (10mobrovac) \o/ Thank you @akosiaris and @jijiki :) [18:39:47] 10VisualEditor: Focusable nodes don't scroll past toolbar when focused - https://phabricator.wikimedia.org/T220227 (10Esanders) [18:42:15] (03PS1) 10Jforrester: Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) [18:53:38] (03PS1) 10Esanders: ve.ce.Selection: Introduce getSelectionFocusRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501665 [18:59:20] (03PS1) 10Esanders: Distinguish between $scrollContainer and $scrollListener [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501667 [19:38:59] (03PS1) 10Esanders: Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) [19:40:26] (03CR) 10jerkins-bot: [V: 04-1] Unify selection scroll code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/501678 (https://phabricator.wikimedia.org/T220227) (owner: 10Esanders) [19:56:10] (03CR) 10Esanders: [C: 03+2] Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [20:00:17] (03CR) 10Esanders: "Are any skins still using this? Was implemented in T95528..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [20:04:17] (03CR) 10Esanders: "Timeless has a fixed header and works around this issue with CSS. I say we drop this completely." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [20:08:02] (03CR) 10Isarra: "I'm not sure what this is, but based on the above, I have to ask: what about other skins with fixed headers? Will they all need special st" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [20:35:40] (03CR) 10Jforrester: "> Patch Set 1:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [20:41:47] (03CR) 10Esanders: [C: 03+2] "Ugh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [22:24:51] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [22:25:43] (03CR) 10Jforrester: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501771 (owner: 10L10n-bot) [22:42:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501771 (owner: 10L10n-bot) [22:44:53] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) [22:54:33] (03CR) 10Krinkle: [C: 03+2] "Gerrit 2.15 remembers +2 scores on new comments, but only if they're your own." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [23:07:10] (03Merged) 10jenkins-bot: Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [23:09:56] (03CR) 10jenkins-bot: Hooks: Don't set wgVisualEditorToolbarScrollOffset in RL when 0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/501661 (https://phabricator.wikimedia.org/T220158) (owner: 10Jforrester) [23:16:52] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) I was surprised to see this task open. This als... [23:41:14] 10VisualEditor, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10JJMC89)