[05:14:07] 10VisualEditor, 10Technical-Debt: .oo-ui-tool-headingN: Don't use px just so that padding is not changed by font size - https://phabricator.wikimedia.org/T126030#2003075 (10Volker_E) With `padding: 0`: {F13090885} [06:44:23] 10VisualEditor, 10VisualEditor-VisualDiffs: VisualDiff shows incorrect diff when start of lines match eachother - https://phabricator.wikimedia.org/T186580#3948279 (10TerraCodes) [07:20:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Chinese-Sites: &viewsource=1 is not supported - https://phabricator.wikimedia.org/T185911#3948312 (10Whatamidoing-WMF) Do you suppose that it's related to https://en.wikipedia.org/wiki/User_talk:Misza13#View_source_script_is_not_working ? [10:35:09] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10CirrusSearch, 10Discovery, 10Discovery-Search: Allow autocomplete (search) link selection in VE to tolerate more typos - https://phabricator.wikimedia.org/T186469#3948557 (10dcausse) Plugin a stemmer in the completion suggester is possible but I'm having... [11:25:59] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Beta-Feature, 10Patch-For-Review, 10User-notice: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708#3948647 (10Deskana) >>! In T185708#3933512, @Johan wrote: > When do you expect this to move from URL parameter to beta featu... [12:11:58] 10VisualEditor: Text goes in the wrong direction? - https://phabricator.wikimedia.org/T186595#3948728 (10Elitre) [12:16:51] 10Cite: tag does not interpret underscores as spaces in the name attribute anymore - https://phabricator.wikimedia.org/T181812#3948742 (10Aklapper) p:05Triage>03Lowest [13:18:12] (03CR) 10Esanders: "not easily" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408289 (https://phabricator.wikimedia.org/T186472) (owner: 10Esanders) [14:04:09] 10VisualEditor, 10VisualEditor-ContentEditable, 10Patch-For-Review, 10Technical-Debt: Abstract more selection handling by selection type - https://phabricator.wikimedia.org/T121347#3948865 (10Esanders) [15:00:32] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Community-Liaisons: Help some smaller Wikipedias' communities by writing the TemplateData and enabling citoid for them - https://phabricator.wikimedia.org/T127354#3949054 (10Ivi104) >>! In T127354#3922034, @Whatamidoing-WMF wrote: > Thanks fo... [15:06:48] 10VisualEditor, 10Wikidata: "Your skin is incompatible with VisualEditor" in Wikidata - https://phabricator.wikimedia.org/T186308#3949085 (10Deskana) p:05Triage>03Low The text of this error is obviously incorrect, but given that the visual editor is not meant to work on Wikidata, this is not high priority. [15:38:17] 10VisualEditor: How can I change title and url in Wikipedia? - https://phabricator.wikimedia.org/T186605#3949216 (10TereCanive) [15:54:18] (03PS1) 10Esanders: Always capture Ctrl/Meta+Enter and emit a 'submit' event on the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408542 [16:20:25] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Beta-Feature, 10Patch-For-Review, 10User-notice: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708#3923509 (10TheDJ) {F13124738} Any reason the visualdiff content adds 15px of left padding ? It's a bit jarring for historica... [16:22:39] (03CR) 10DLynch: [C: 032] "Yeah, I think you're right about my thought process in the earlier patch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408289 (https://phabricator.wikimedia.org/T186472) (owner: 10Esanders) [16:25:25] (03Merged) 10jenkins-bot: scrollCursorIntoView: Collapse selection to 'to' (anchor) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408289 (https://phabricator.wikimedia.org/T186472) (owner: 10Esanders) [16:28:14] (03CR) 10jenkins-bot: scrollCursorIntoView: Collapse selection to 'to' (anchor) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408289 (https://phabricator.wikimedia.org/T186472) (owner: 10Esanders) [16:30:41] 10VisualEditor: How can I change title and url in Wikipedia? - https://phabricator.wikimedia.org/T186605#3949431 (10Esanders) 05Open>03Invalid Hi, I think https://en.wikipedia.org/wiki/Wikipedia:Help_desk would be a better place to ask your question. Phabricator is for reporting problems with the software, r... [16:37:06] 10VisualEditor: Text goes in the wrong direction? - https://phabricator.wikimedia.org/T186595#3949456 (10Esanders) 05Open>03stalled [17:36:28] (03CR) 10Jforrester: [C: 031] Use .isNull check for NullSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408316 (https://phabricator.wikimedia.org/T121347) (owner: 10Esanders) [17:37:08] (03CR) 10Jforrester: [C: 031] Always capture Ctrl/Meta+Enter and emit a 'submit' event on the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408542 (owner: 10Esanders) [17:40:31] 10Citoid, 10VisualEditor, 10Patch-For-Review: Prevent citoid from being enabled unless all required keys are present in MediaWiki:Citoid-template-type-map.json - https://phabricator.wikimedia.org/T186276#3949719 (10Mvolz) >>! In T186276#3947240, @Jdforrester-WMF wrote: > ^^^ This proof of concept checks on i... [17:41:37] (03CR) 10Bartosz Dziewoński: [C: 032] "Rather elegant, actually." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408542 (owner: 10Esanders) [17:45:59] (03Merged) 10jenkins-bot: Always capture Ctrl/Meta+Enter and emit a 'submit' event on the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408542 (owner: 10Esanders) [17:48:02] (03CR) 10jenkins-bot: Always capture Ctrl/Meta+Enter and emit a 'submit' event on the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408542 (owner: 10Esanders) [17:58:31] (03CR) 10DLynch: [C: 032] Use .isNull check for NullSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408316 (https://phabricator.wikimedia.org/T121347) (owner: 10Esanders) [18:00:59] (03Merged) 10jenkins-bot: Use .isNull check for NullSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408316 (https://phabricator.wikimedia.org/T121347) (owner: 10Esanders) [18:02:42] (03CR) 10jenkins-bot: Use .isNull check for NullSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/408316 (https://phabricator.wikimedia.org/T121347) (owner: 10Esanders) [18:18:06] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (ef55ee03a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [18:29:06] (03PS2) 10Jforrester: VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [18:56:20] (03PS3) 10Jforrester: VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [18:58:46] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3950017 (10kaldari) [19:04:42] (03CR) 10Arlolra: "I2b5c7ff552b3322be74f79a81936c41d58fecabc was deployed today" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/403751 (owner: 10Arlolra) [19:09:16] (03PS1) 10Jforrester: Re-crush beta feature SVG screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 [19:12:33] (03PS4) 10Jforrester: VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [19:23:30] (03PS2) 10Hashar: Update VE core submodule to master (ef55ee03a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [19:23:54] (03CR) 10Hashar: [C: 032] Update VE core submodule to master (ef55ee03a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [19:26:19] (03CR) 10Hashar: [C: 04-2] "Please do not CR+2 this change. CI can't process it right now :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [19:29:17] (03PS5) 10Jforrester: VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [19:29:39] (03CR) 10Jforrester: [C: 032] VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [19:34:13] (03PS2) 10Jforrester: Re-crush beta feature SVG screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 [19:43:54] (03CR) 10VolkerE: "Why are we doing this and not I882f0c6e2b5011fd51edb6106a3e22581989b834?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [19:44:04] (03CR) 10VolkerE: "Or was this just a test?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [19:44:09] 10VisualEditor, 10VisualEditor-VisualDiffs: VisualDiff shows incorrect diff when start of lines match eachother - https://phabricator.wikimedia.org/T186580#3950159 (10Deskana) 05Open>03Invalid This is tricky. Which diff is right and which diff is wrong depends on your perspective; both are possible interpr... [19:44:15] (03Merged) 10jenkins-bot: VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [19:45:57] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Beta-Feature, 10Patch-For-Review, 10User-notice: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708#3950163 (10Deskana) >>! In T185708#3949390, @TheDJ wrote: > {F13124738} > Any reason the visualdiff content adds 15px of lef... [19:47:17] 10VisualEditor, 10VisualEditor-VisualDiffs: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3950168 (10Deskana) [19:47:31] 10VisualEditor, 10VisualEditor-VisualDiffs: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3950180 (10Deskana) p:05Triage>03Low [19:47:58] 10VisualEditor, 10VisualEditor-VisualDiffs: Remove added 15px of left margin from historical visual diffs - https://phabricator.wikimedia.org/T186636#3950168 (10Deskana) [19:49:52] 10VisualEditor, 10VisualEditor-CopyPaste, 10Patch-For-Review: Copying a reference list in visual editor copies the list's original state when the document was loaded - https://phabricator.wikimedia.org/T186407#3950190 (10Deskana) p:05Triage>03Normal a:03Esanders [19:52:10] (03CR) 10Hashar: [C: 032] "OK lets try to land this one. It has no depends-on so it should be processed just fine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [19:52:40] 10VisualEditor, 10Collaboration-Team-Triage, 10StructuredDiscussions: Broken section links in VE in StructuredDiscussions - https://phabricator.wikimedia.org/T186088#3933316 (10Etonkovidova) Checked in 1.31.0-wmf.17. @Mattflaschen-WMF - please check if below are the exact steps for the issue: 1. On SD b... [19:53:14] 10VisualEditor, 10WikiEditor, 10Design: Add "create redirect" too toolbar button when creating new article in VE/Wikieditor - https://phabricator.wikimedia.org/T186350#3950202 (10Deskana) p:05Triage>03Low Creating a redirect is not a particularly common action, and I'm worried about cluttering the toolba... [19:53:26] 10VisualEditor, 10WikiEditor, 10Design: Add "create redirect" toolbar button when creating new article in VE/Wikieditor - https://phabricator.wikimedia.org/T186350#3950206 (10Deskana) [19:55:54] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3950218 (10cscott) [19:55:56] 10VisualEditor, 10VisualEditor-VisualDiffs, 10Beta-Feature, 10User-notice: Make historical VisualDiffs a BetaFeature - https://phabricator.wikimedia.org/T185708#3950220 (10Jdforrester-WMF) Code's merged and will ride next week's train, all that's needed now is a config patch to enable. [19:56:56] (03CR) 10Jforrester: "This was a semi-manual adjustment, renaming IDs etc. that svgo won't catch." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408582 (owner: 10Jforrester) [19:58:37] 10TemplateData, 10VisualEditor, 10Parsoid, 10User-Ryasmeen: Create shortcut/alias for aligned parameter style in TemplateData - https://phabricator.wikimedia.org/T186632#3950226 (10cscott) Argument name space-padding is (apparently) considered a discouraged practice on dewiki, if I understand correctly. W... [19:59:59] (03CR) 10Jforrester: "Depends on I39bbbce203." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408466 (https://phabricator.wikimedia.org/T185917) (owner: 10Bartosz Dziewoński) [20:02:35] (03Merged) 10jenkins-bot: Update VE core submodule to master (ef55ee03a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [20:03:47] (03CR) 10jenkins-bot: VisualDiffs: Create an optional BetaFeature for historical diffs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/406250 (https://phabricator.wikimedia.org/T185708) (owner: 10Esanders) [20:15:43] (03CR) 10jenkins-bot: Update VE core submodule to master (ef55ee03a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408295 (owner: 10Jforrester) [20:16:37] (03PS1) 10Umherirrender: Split assignment and return statement [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 [20:16:52] 10VisualEditor, 10WikiEditor, 10Design: Add "create redirect" toolbar button when creating new article in VE/Wikieditor - https://phabricator.wikimedia.org/T186350#3950279 (10Mvolz) >>! In T186350#3950202, @Deskana wrote: > Creating a redirect is not a particularly common action, and I'm worried about clutte... [20:23:15] (03CR) 10Fomafix: Split assignment and return statement (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 (owner: 10Umherirrender) [20:40:02] (03PS2) 10Umherirrender: Split assignment and return statement [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 [20:41:15] (03CR) 10Umherirrender: "Patch Set 2: Addressed comment" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 (owner: 10Umherirrender) [20:43:12] 10VisualEditor, 10VisualEditor-MediaWiki-References: References list dialog opens with unfocused input - https://phabricator.wikimedia.org/T186640#3950341 (10Tchanders) [20:47:46] (03CR) 10Fomafix: [C: 032] Split assignment and return statement [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 (owner: 10Umherirrender) [21:42:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/408678 (owner: 10L10n-bot) [21:53:44] (03CR) 10Hashar: [C: 032] "Revoting CR+2 due to an issue with the CI infrastructure T186381" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 (owner: 10Umherirrender) [21:57:00] 10Citoid, 10VisualEditor, 10Services (done), 10User-Ryasmeen: unable to make citation for http://apps.who.int/iris/handle/10665/70863 - https://phabricator.wikimedia.org/T186395#3950577 (10Jdforrester-WMF) [22:04:58] (03Merged) 10jenkins-bot: Split assignment and return statement [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/408603 (owner: 10Umherirrender) [22:08:55] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10User-Ryasmeen: References list dialog opens with unfocused input - https://phabricator.wikimedia.org/T186640#3950617 (10Jdforrester-WMF) 05Open>03Resolved a:03Tchanders [22:25:34] 10VisualEditor, 10VisualEditor-CopyPaste, 10User-Ryasmeen: Copying a reference list in visual editor copies the list's original state when the document was loaded - https://phabricator.wikimedia.org/T186407#3950723 (10Jdforrester-WMF) 05Open>03Resolved [23:56:25] (03CR) 10Bartosz Dziewoński: [C: 032] Add trailing linebreak to NWE's temporary wikitext editor (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/407499 (https://phabricator.wikimedia.org/T185632) (owner: 10Esanders) [23:59:11] 10VisualEditor, 10VisualEditor-Performance, 10Performance-Team: Performance review of Editing features - https://phabricator.wikimedia.org/T171093#3453831 (10Alsee) Note: VisualEditor already sends load time values back to the server, however actual user-experienced load times are almost twice as long as rep...