[00:24:40] (03CR) 10Catrope: [C: 04-1] "One unclear comment, LGTM otherwise" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [00:29:39] (03CR) 10Jforrester: [C: 032] MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/375937 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [00:38:34] (03Merged) 10jenkins-bot: MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/375937 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [00:40:43] (03CR) 10jenkins-bot: MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/375937 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [01:59:30] 10VisualEditor, 10VisualEditor-VisualDiffs: Consider clarifying the visual language for Visual Diffs - https://phabricator.wikimedia.org/T169325#3583001 (10Volker_E) Agree with @Tchanders of option C above being too crowded. @Prtksxna Links could be an interesting idea, but is the need for knowing where some... [02:25:06] 10VisualEditor, 10VisualEditor-VisualDiffs: Consider clarifying the visual language for Visual Diffs - https://phabricator.wikimedia.org/T169325#3583023 (10Prtksxna) >>! In T169325#3583001, @Volker_E wrote: > @Prtksxna Links could be an interesting idea, but is the need for knowing where something has moved wo... [05:47:48] (03PS1) 10Prtksxna: Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/376174 (https://phabricator.wikimedia.org/T76630) [05:47:51] (03PS1) 10Prtksxna: Use findFirstSelectableitem instead of getFirstSelectableItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376175 (https://phabricator.wikimedia.org/T76630) [05:47:58] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3583082 (10kaldari) @Niharika: I think Max's solution is the same as the one suggested by James, he's just elaborating on it... [05:48:08] (03PS1) 10Prtksxna: Use findFirstSelectableitem instead of getFirstSelectableItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376177 (https://phabricator.wikimedia.org/T76630) [05:54:19] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3583088 (10kaldari) Hmm, looks like the SkinTemplateNavigation hook lets you change the classes, but not the ID :( [06:20:04] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3583129 (10kaldari) The [[https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateOutputPageBeforeExec|SkinTemplateOutputPag... [07:11:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Copy and paste added no-wiki - https://phabricator.wikimedia.org/T174898#3583185 (10Schnark) Editors can specify the MIME type for copied content. I don't know how this works in Java, just for reference: https://developer.mozilla.org/en-US/docs/Web/A... [08:03:26] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: First letter of parameters should be capitalized in template editor - https://phabricator.wikimedia.org/T174771#3583318 (10The_RedBurn) I don't know what you meant in T174771#3581686, there's no TemplateData for https://simple.wikipedia.beta... [09:35:18] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: First letter of parameters should be capitalized in template editor - https://phabricator.wikimedia.org/T174771#3583493 (10Deskana) >>! In T174771#3583318, @The_RedBurn wrote: > I don't know what you meant in T174771#3581686, there's no Temp... [09:50:52] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Copy and paste added no-wiki - https://phabricator.wikimedia.org/T174898#3583596 (10Deskana) 05stalled>03declined >>! In T174898#3582169, @Drewmutt wrote: > Okay, so I think I found the issue, which is actually complicating things. I'm copy and p... [09:55:42] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review, 10User-Ryasmeen: Insertions with references too easily cause rebase conflicts - https://phabricator.wikimedia.org/T175059#3583624 (10Deskana) 05Open>03Resolved [09:58:56] 10VisualEditor, 10VisualEditor-VisualDiffs: Removal of template parameter inside the reference tag not shown in changes - https://phabricator.wikimedia.org/T172141#3583646 (10Deskana) 05Open>03Invalid [10:00:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10User-Ryasmeen: Save dialog checkboxes' tooltips have duplicate accesskey hints - https://phabricator.wikimedia.org/T174686#3583649 (10Deskana) 05Open>03Resolved [11:02:50] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#3583946 (10Elitre) I feel like unfortunately we already have enough tasks open about how long translations look ugly and make... [11:59:35] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#3584006 (10Pginer-WMF) >>! In T44138#3579770, @Jan_Dittrich wrote: > From observing the users and further corroborated by the... [12:47:58] 10VisualEditor, 10VisualEditor-MediaWiki: Citation previews in subpages give incorrect internal redlinks - https://phabricator.wikimedia.org/T169675#3584166 (10matmarex) [12:52:48] (03PS1) 10Bartosz Dziewoński: Use .length instead of .size() for jQuery objects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376239 [12:57:59] 10VisualEditor, 10VisualEditor-MediaWiki: Previews of citations generated by templates in subpages give incorrect internal redlinks - https://phabricator.wikimedia.org/T169675#3584181 (10matmarex) [13:43:27] 10VisualEditor, 10Africa-Wikimedia-Developers, 10MinervaNeue, 10Patch-For-Review, 10User-Ryasmeen: Text area not obvious when creating New talk page on MF with MinervaB - https://phabricator.wikimedia.org/T174158#3584333 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson Fixed now on beta cluster [14:14:11] (03PS1) 10Bartosz Dziewoński: ve.ui.PreviewElement: Add a FIXME about rendering 'for clipboard' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376262 [14:15:22] (03PS2) 10Bartosz Dziewoński: ve.ui.PreviewElement: Add a FIXME about rendering 'for clipboard' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/376262 [14:33:50] 10VisualEditor, 10VisualEditor-MediaWiki: Copy-paste of template-generated link from a subpage in VE gives the wrong href - https://phabricator.wikimedia.org/T175157#3584470 (10matmarex) [14:35:31] 10VisualEditor, 10VisualEditor-MediaWiki: Previews of citations generated by templates in subpages give incorrect internal redlinks - https://phabricator.wikimedia.org/T169675#3584484 (10matmarex) The root cause is {T175157}, because apparently these previews use the same rendering mode as rendering for clipbo... [14:36:38] 10VisualEditor, 10VisualEditor-MediaWiki: Copy-paste of template-generated link from a subpage in VE gives the wrong href - https://phabricator.wikimedia.org/T175157#3584470 (10matmarex) [14:36:40] 10VisualEditor, 10VisualEditor-MediaWiki: Previews of citations generated by templates in subpages give incorrect internal redlinks - https://phabricator.wikimedia.org/T169675#3584488 (10matmarex) [15:00:00] 10VisualEditor, 10VisualEditor-MediaWiki: Copy-paste of template-generated link from a subpage in VE gives the wrong href - https://phabricator.wikimedia.org/T175157#3584581 (10matmarex) ve.ce.Surface.prototype.onCopy renders the HTML into the current document: ```ve.dm.converter.getDomSubtreeFromModel( slice,... [15:23:20] (03CR) 10Jforrester: [C: 032] Use .length instead of .size() for jQuery objects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376239 (owner: 10Bartosz Dziewoński) [15:31:17] (03Merged) 10jenkins-bot: Use .length instead of .size() for jQuery objects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376239 (owner: 10Bartosz Dziewoński) [15:33:36] (03CR) 10jenkins-bot: Use .length instead of .size() for jQuery objects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376239 (owner: 10Bartosz Dziewoński) [15:40:20] edsanders: before i start working on it, can you check the idea at the end of https://phabricator.wikimedia.org/T175157#3584581 and say if it makes sense? [16:21:24] * edsanders looking [16:22:15] hmm [16:22:33] 10VisualEditor, 10VisualEditor-MediaWiki: Copy-paste of template-generated link from a subpage in VE gives the wrong href - https://phabricator.wikimedia.org/T175157#3584889 (10Esanders) Pinging @catrope. [16:23:57] I'm not sure what the use cases are for those resolve attribute things [16:24:09] I think it's more that just copy paste, but @RoanKattouw would probably know better [16:27:41] Hmm not sure why we have attribute resolution in toDomElements [16:28:30] We need it for rendering purposes to be sure, but I don't see how we need it for Parsoid output purposes [16:29:04] CE deals with both rendering and copy, so I'm skeptical of DM doing any resolution at all [16:29:23] But maybe we should git blame those calls and see if we can discover why they were introduced [16:31:04] RoanKattouw: resolveAttrivutes() in toDomElements() is only called for converting to clipboard [16:31:24] (except we also use the clipboard mode sometimes when not actually converting to clipboard) [16:32:05] RoanKattouw: edsanders: blame points to https://phabricator.wikimedia.org/T111927 ;) [16:32:51] Ha OK [16:33:06] So maybe that was the wrong place to put that and uses the wrong document? [16:33:52] Either way, moving that stuff around between toDomElements and ce.Surface.onCopy should be safe then [16:34:04] In the sense that it shouldn't break anything else [16:53:17] (03CR) 10Divec: TransactionProcessor: modify DM tree branches instead of rebuilding them (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [16:54:13] (03PS15) 10Divec: TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) [16:59:49] 10VisualEditor, 10VisualEditor-MediaWiki: Copy-paste of template-generated link from a subpage in VE gives the wrong href - https://phabricator.wikimedia.org/T175157#3585106 (10matmarex) a:03matmarex ``` [18:23] I'm not sure what the use cases are for those resolve attribute things [18:24] 10Editing-team, 10VisualEditor, 10Performance-Team, 10Patch-For-Review: Decommission webperf/ve.py daemon - https://phabricator.wikimedia.org/T175083#3585347 (10Krinkle) p:05Triage>03Low [18:58:00] 10VisualEditor, 10MediaWiki-extensions-ArticleCreationWorkflow, 10Community-Tech-Sprint: ACW should intercept page creation via VisualEditor - https://phabricator.wikimedia.org/T173605#3585961 (10Niharika) @kaldari Max pointed out yesterday that we still won't be able to stop people who click on redlinks and... [18:59:00] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to make block-level items centred (and other styles) - https://phabricator.wikimedia.org/T72484#3585974 (10Whatamidoing-WMF) [20:07:15] (03CR) 10Catrope: [C: 032] TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [20:07:22] dun dun dunnnnn [20:09:50] (03Merged) 10jenkins-bot: TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [20:14:55] (03CR) 10jenkins-bot: TransactionProcessor: modify DM tree branches instead of rebuilding them [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/357171 (https://phabricator.wikimedia.org/T162762) (owner: 10Divec) [20:22:54] RoanKattouw: \o/ [20:23:05] RoanKattouw: Aka OMG I hope this doesn't break too much. [20:36:32] (03CR) 10Arlolra: "The dependency here was deployed today," [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/371074 (https://phabricator.wikimedia.org/T118520) (owner: 10Arlolra) [20:44:45] (03PS1) 10Jforrester: Update VE core submodule to master (834fd702f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376396 (https://phabricator.wikimedia.org/T162762) [21:01:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/376413 (owner: 10L10n-bot) [21:05:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376422 (owner: 10L10n-bot) [21:06:52] 10Citoid, 10VisualEditor, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, and 2 others: Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3586525 (10Tbayer) According to [[https://blog.wiki... [21:09:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Copy and paste added no-wiki - https://phabricator.wikimedia.org/T174898#3586528 (10Drewmutt) Yeah, all that makes sense. Turns out IntelliJ has "Copy as plain text", which resolves the issue. Do people really expect formatting to carry over during e... [22:07:57] 10VisualEditor, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Regression, 10User-Ryasmeen, and 2 others: The pulsating blue dots of educational popups for links and citations are appearing misaligned for the toolbar inside Media and Ref... - https://phabricator.wikimedia.org/T174120#3586768 [22:12:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10User-Ryasmeen, and 2 others: Inconsistencies around textbox highlighting in link inspector - https://phabricator.wikimedia.org/T172159#3586790 (10Ryasmeen) [23:17:28] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (834fd702f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376396 (https://phabricator.wikimedia.org/T162762) (owner: 10Jforrester) [23:26:01] (03Merged) 10jenkins-bot: Update VE core submodule to master (834fd702f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376396 (https://phabricator.wikimedia.org/T162762) (owner: 10Jforrester) [23:27:42] (03CR) 10jenkins-bot: Update VE core submodule to master (834fd702f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/376396 (https://phabricator.wikimedia.org/T162762) (owner: 10Jforrester)