[00:10:30] <wikibugs>	 (03PS1) 10Jforrester: Add the alerts, content and interactions icon packs overall [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356779
[00:18:59] <wikibugs>	 (03CR) 10Catrope: [C: 032] Add the alerts, content and interactions icon packs overall [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356779 (owner: 10Jforrester)
[00:20:24] <wikibugs>	 (03CR) 10Jforrester: [C: 032] Update for deprecation of OOjs UI openWindow/closeWindow promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356767 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński)
[00:20:44] <wikibugs>	 (03CR) 10Jforrester: [C: 032] Update for deprecation of OOjs UI openWindow/closeWindow promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356766 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński)
[00:26:35] <wikibugs>	 (03Merged) 10jenkins-bot: Update for deprecation of OOjs UI openWindow/closeWindow promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356766 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński)
[00:31:30] <wikibugs>	 (03CR) 10jenkins-bot: Update for deprecation of OOjs UI openWindow/closeWindow promise [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/356766 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński)
[00:32:39] <wikibugs>	 (03Merged) 10jenkins-bot: Add the alerts, content and interactions icon packs overall [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356779 (owner: 10Jforrester)
[00:32:41] <wikibugs>	 (03Merged) 10jenkins-bot: Update for deprecation of OOjs UI openWindow/closeWindow promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356767 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński)
[00:34:15] <wikibugs>	 (03PS1) 10Jforrester: Update VE core submodule to master (05375f324) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356782
[00:36:34] <wikibugs>	 (03CR) 10jenkins-bot: Add the alerts, content and interactions icon packs overall [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356779 (owner: 10Jforrester)
[00:40:42] <wikibugs>	 (03CR) 10jenkins-bot: Update for deprecation of OOjs UI openWindow/closeWindow promise [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356767 (https://phabricator.wikimedia.org/T166729) (owner: 10Bartosz Dziewoński)
[02:52:15] <wikibugs>	 (03CR) 10DLynch: [C: 032] Update VE core submodule to master (05375f324) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356782 (owner: 10Jforrester)
[03:01:11] <wikibugs>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (05375f324) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356782 (owner: 10Jforrester)
[03:07:34] <wikibugs>	 (03CR) 10jenkins-bot: Update VE core submodule to master (05375f324) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356782 (owner: 10Jforrester)
[06:31:10] <eranroz>	 hi, how do I enable upload dialog to use commons from some local test wiki? (or other workaround for CORS issues)
[09:47:55] <eranroz>	 VE upload dialog always create ForeignStructuredUpload? \:
[14:43:22] <cscott>	 James_F: it's more likely i'll refactor ve core to allow annotations to handle their own children in toDataElement
[14:43:34] * James_F nods.
[14:45:03] <cscott>	 James_F: that would allow me to handle the common inline case as an annotation, and fall back to a LeafNode for the block case
[14:45:10] <cscott>	 James_F: 2x the inspectors though, ugh.
[14:45:29] <James_F>	 Hmm. Yeah.
[14:46:29] <cscott>	 Other benefit of handling common case as an annotation is that I can hide the new UX under the Languages submenu, instead of taking up more prime UX real estate
[14:46:56] <cscott>	 in fact, maybe the right thing is not to implement the block case at all, leave that as an alien
[14:47:15] <cscott>	 and offer really good edit tools for the sane markup
[14:48:33] <James_F>	 I'm not keen on re-using the lang=xx dialog to do variant editing.
[14:48:49] <James_F>	 Given that you can plausibly wrap the latter within the former.
[14:57:06] <cscott>	 well, it would actually be nice if LanguageConverter input text were annotated with the language it corresponds to
[14:57:12] <cscott>	 there's some crossover there
[14:57:30] <cscott>	 currently anything which "looks" like language A is converter to language B (if the current language is B), and vice versa
[14:58:06] <cscott>	 which more-or-less works for simplified and traditional scripts, but wouldn't work at all for (say) figuring out how to convert "lift" between en-gb and en-us
[14:58:50] <cscott>	 that is, if the character class for the possible variants overlaps, things get ugly quickly
[14:59:11] <cscott>	 <p lang="en-gb">....</p> would disambiguate nicely.
[14:59:55] <cscott>	 and then if you edited a <p lang="en-gb"> while using the en-us variant, it would be nice if the result was <p lang="en-gb"> ... <span lang="en-us">lift</span> ... </p>
[15:00:45] <cscott>	 which could get serialized to -{lift}- (say) indicating that this needed to be protected from the usual en-gb translation of lift to elevator
[15:01:16] <cscott>	 lots of hand-waving here.  but my point is that proper operation of language converter is not independent of specifying the particular language/variant of a piece of text
[15:01:34] <James_F>	 Yeah.
[15:01:45] <cscott>	 so (IMNSHO) it makes sense to unify the dialog.  of course, i haven't actually mocked up what a unified dialog would look like yet
[15:01:47] <James_F>	 I've got a vague plan of block-level editing through a control in the left gutter.
[15:01:50] <cscott>	 so maybe i'll reconsider
[15:01:56] <mooeypoo>	 err I'm getting a fatal "Class undefined: ResourceLoaderOOUIModule" from ve icon packs... anyone knows what's up?
[15:02:00] <James_F>	 (For <div> and so on.)
[15:02:18] <James_F>	 mooeypoo: Update everything. Major breaking changes in MW/OOUI integration this week.
[15:02:22] <cscott>	 yeah, part of the issue is that wikitext doesn't have a good mechanism (other than explicit <div ...attribs..> tags) for putting properties on blocks.
[15:02:43] <James_F>	 cscott: Also <ul style="…"> edits.
[15:03:23] <cscott>	 i think i vaguely proposed something like {{#lang:foo}} for setting/resetting language context in some phab ticket.
[15:03:45] <James_F>	 Maybe. I worry about adding Yet More Damn Syntax.
[15:03:50] <cscott>	 heredoc templates would work too: https://phabricator.wikimedia.org/T114432
[15:04:21] <James_F>	 mooeypoo: If that doesn't work shout and I'll try to fix things.
[15:04:31] <cscott>	 {{<<lang|en-gb}} ..... {{>>lang}}  (or one of the alternate syntaxes)
[15:04:59] * James_F shudders.
[15:05:08] <cscott>	 or annotations. ;)
[15:06:08] <cscott>	 actually, this would be a great use of annotations.  your <ul style> not so much.
[15:06:30] <cscott>	 but i guess you could invent new block-level UX for both, regardless of how they are stored
[15:06:41] <James_F>	 Yup.
[15:08:13] <cscott>	 anyway, my plan is to implement the bones and then throw it over the wall to you VE folks for UX prettification as needed :)
[15:08:20] <James_F>	 WFM.
[15:10:55] <cscott>	 it might need revisiting after zhwiki folks actually try it out, too.  what seems logical to me might not make sense to a user.
[15:11:03] <cscott>	 so i'll try to get a crappy first draft done
[15:11:19] <cscott>	 what's the status of VE on zhwiki?  could we turn it on as a beta feature easily?
[15:39:52] <James_F>	 It's on as a beta feature already.
[15:40:01] <James_F>	 But given the current experience, few try to use it.
[16:29:26] <wikibugs>	 (03PS2) 10C. Scott Ananian: WIP: Specialized inspector for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411)
[16:29:28] <wikibugs>	 (03PS1) 10C. Scott Ananian: WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865
[16:30:20] <cscott>	 James_F: ok, cool.  that will make it easy for me to test as well ;)
[16:37:35] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Specialized inspector for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian)
[16:37:37] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865 (owner: 10C. Scott Ananian)
[16:48:10] <wikibugs>	 (03PS2) 10Tchanders: WIP Visual Diff: add internal list diff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/355716 (https://phabricator.wikimedia.org/T162819)
[20:18:04] <wikibugs>	 (03PS3) 10C. Scott Ananian: WIP: Specialized inspector for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411)
[20:18:06] <wikibugs>	 (03PS2) 10C. Scott Ananian: WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865
[20:19:40] <cscott>	 James_F: https://gerrit.wikimedia.org/r/356739 is a working "read-only" patch for languageconverter markup.
[20:20:08] <cscott>	 James_F: no inspector yet, but all the markup renders reasonably
[20:24:40] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Specialized inspector for LanguageConverter markup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411) (owner: 10C. Scott Ananian)
[20:28:52] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865 (owner: 10C. Scott Ananian)
[20:30:41] <cscott>	 you barbarians over in VE land don't seem to have an eslint --fix command set up in your gruntfile
[20:34:07] <cscott>	 MatmaRex_mobile: can I poke you about pig latin again? https://gerrit.wikimedia.org/r/72053
[20:34:32] <MatmaRex_mobile>	 cscott: argh yes, sorry
[20:35:23] <MatmaRex_mobile>	 cscott: we made a breaking release of OOjs UI this week, and it broke a bit more things than we anticipated, so i was busy firefighting. and now i'm at a conference over the weekend
[20:35:38] <cscott>	 no worries, it can wait
[20:36:05] <cscott>	 there was a languageconverter fix in wmf.2 and i was also eagerly awaiting news about whether or not i managed to break the train this week ;)
[20:38:44] <MatmaRex_mobile>	 cscott: by the way, is there anything you want to ask Polish Wikimedians about? ;)
[20:39:18] <MatmaRex_mobile>	 i'll look at the pig latin thing next week. i also want that to mke it in
[20:39:47] <James_F>	 cscott: Interesting.
[20:40:06] <James_F>	 cscott: We got rid of eslint:fix a few months ago because we'd migrated.
[20:40:18] <cscott>	 MatmaRex_mobile: preferred image thumbnail sizes?  isn't plwiki one of those still using a template to manually select an alternate default thumbnail size?
[20:41:05] <MatmaRex_mobile>	 cscott: nnnno
[20:41:24] <MatmaRex_mobile>	 we only have some funky uprights
[20:41:34] <cscott>	 oh, upright.  yeah, that's fun too.
[20:50:28] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/356937 (owner: 10L10n-bot)
[20:58:49] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356945 (owner: 10L10n-bot)
[21:31:25] <wikibugs>	 (03PS4) 10C. Scott Ananian: Display LanguageConverter markup in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411)
[21:31:27] <wikibugs>	 (03PS3) 10C. Scott Ananian: WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865
[21:36:21] <wikibugs>	 (03PS5) 10C. Scott Ananian: Display LanguageConverter markup in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356739 (https://phabricator.wikimedia.org/T49411)
[21:36:23] <wikibugs>	 (03PS4) 10C. Scott Ananian: WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865
[21:47:31] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] WIP: Use annotations for inline LanguageConverter markup. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/356865 (owner: 10C. Scott Ananian)