[06:49:52] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: TemplateData parameters should not be case sensitive - https://phabricator.wikimedia.org/T146060#2649221 (10Zache) AlexMonk-WMF, Can you confirm if i understand correctly. TemplateData aliases should work so that if there is in TemplateData... [12:54:50] (03PS3) 10TheDJ: MWAceEditorWidget: Configure Ace with its base path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) [12:55:12] (03CR) 10TheDJ: MWAceEditorWidget: Configure Ace with its base path (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [13:06:45] (03CR) 10TheDJ: [C: 04-1] "Why would this suddenly be required and not before ?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (owner: 10Fomafix) [13:31:48] (03CR) 10Fomafix: "I95c93286e5e6c9c177f17ed8dd0fa44c132b35bb in core moved the style from always loaded mediawiki.legacy.shared to a separate style module, w" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (owner: 10Fomafix) [13:43:36] (03CR) 10Alex Monk: [C: 032] MWAceEditorWidget: Configure Ace with its base path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [13:50:42] (03Merged) 10jenkins-bot: MWAceEditorWidget: Configure Ace with its base path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [13:59:01] (03CR) 10Fomafix: "This is the wrong reference. Maybe the styles get never loaded." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (owner: 10Fomafix) [14:15:21] (03CR) 10TheDJ: "I was wondering why the stock live preview feature wasn't effected, but it seems that: 'mediawiki.action.edit.preview' has these styleshee" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (owner: 10Fomafix) [14:39:50] (03CR) 10Fomafix: "A dependency is also a solution. I think this lazy loading of the style is enough." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (owner: 10Fomafix) [14:53:20] (03CR) 10Fomafix: "I found the reason: In 6627f2cd947d88d9ec144783a591bfde1a224bb2 you removed" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (owner: 10Fomafix) [15:03:17] (03PS3) 10Fomafix: Load module 'mediawiki.diff.styles' on show changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) [15:03:25] 10WikiEditor, 13Patch-For-Review: Changes/Diff preview in WikiEditor not styled properly in 0.0.5 (1.27.0) - https://phabricator.wikimedia.org/T142845#2667435 (10Fomafix) a:03Fomafix [15:27:08] (03PS4) 10Fomafix: Load module 'mediawiki.diff.styles' on show changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) [16:19:54] 10VisualEditor: [Regression pre-wmf.21] VE crashes while adding images, showing error "TypeError: xhr.abort is not a function" - https://phabricator.wikimedia.org/T146661#2667687 (10Ryasmeen) [16:28:41] 10VisualEditor: [Regression pre-wmf.21] VE crashes while adding images, showing error "TypeError: xhr.abort is not a function" - https://phabricator.wikimedia.org/T146661#2667720 (10matmarex) p:05Triage>03Unbreak! This is because https://gerrit.wikimedia.org/r/#/c/309767/ was merged without merging https://... [17:54:06] (03CR) 10Krinkle: MWAceEditorWidget: Configure Ace with its base path (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [18:10:47] edsanders: have you seen https://phabricator.wikimedia.org/T146661 ? [18:11:00] edsanders: are you planning to review the dependency, or should i revert it? [18:24:10] (03CR) 10Bartosz Dziewoński: [C: 032] Change mid-upload 'cancel' button to 'back' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312253 (https://phabricator.wikimedia.org/T114938) (owner: 10Matthias Mullie) [18:31:44] (03PS5) 10TheDJ: Load module 'mediawiki.diff.styles' on show changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) (owner: 10Fomafix) [18:34:39] (03Merged) 10jenkins-bot: Change mid-upload 'cancel' button to 'back' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312253 (https://phabricator.wikimedia.org/T114938) (owner: 10Matthias Mullie) [18:35:13] (03CR) 10TheDJ: "Right, I now understands why this slipped through. If you have the "uselivepreview" option enabled in your preferences, AND you have this " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) (owner: 10Fomafix) [18:36:19] (03CR) 10Fomafix: [C: 04-1] Load module 'mediawiki.diff.styles' on show changes (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) (owner: 10Fomafix) [18:46:58] Krenair: dying to know what the blockers on that are :D https://phabricator.wikimedia.org/T111630 [18:49:01] (03PS1) 10Bartosz Dziewoński: Revert "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312856 (https://phabricator.wikimedia.org/T143279) [18:49:13] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312856 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [18:49:28] mvolz, three restricted tasks [18:54:46] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, 07Design: Provide a way during the upload stage for the user to change their mind about what file to upload once they've started it uploading - https://phabricator.wikimedia.org/T114938#2668365 (10matmarex) 05Open>03R... [18:55:14] (03Merged) 10jenkins-bot: Revert "ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312856 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [18:55:54] 10VisualEditor, 13Patch-For-Review: [Regression pre-wmf.21] VE crashes while adding images, showing error "TypeError: xhr.abort is not a function" - https://phabricator.wikimedia.org/T146661#2668370 (10matmarex) That revert should fix the issue. [18:57:17] (03PS1) 10Bartosz Dziewoński: ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312857 (https://phabricator.wikimedia.org/T143279) [18:57:42] (03CR) 10Bartosz Dziewoński: "Reverted in https://gerrit.wikimedia.org/r/#/c/312856/ . Retrying in https://gerrit.wikimedia.org/r/#/c/312857/ ." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [19:26:37] 10VisualEditor, 10MediaWiki-ResourceLoader: Startup module error "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T146686#2668440 (10Mooeypoo) [19:29:22] (03PS6) 10TheDJ: Load module 'mediawiki.diff.styles' on show changes [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) (owner: 10Fomafix) [19:30:04] (03CR) 10TheDJ: Load module 'mediawiki.diff.styles' on show changes (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/308759 (https://phabricator.wikimedia.org/T142845) (owner: 10Fomafix) [19:35:11] (03PS1) 10TheDJ: Use slice instead of substring per code conventions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312864 [19:38:20] 10VisualEditor, 10VisualEditor-MediaWiki: Startup module error "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T146686#2668478 (10Krinkle) Most likely caused by {c0cf9c1e75525e9d19522581ee83e6679d099593}. Previously it used ResourceLoaderContext::msg(). Now it statically calls... [19:38:43] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: VE fails startup module with "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T146686#2668481 (10Krinkle) [19:38:51] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: VE fails startup module with "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T146686#2668485 (10Krinkle) p:05Triage>03Unbreak! [19:42:19] 10VisualEditor: Literal figure tags emitted for some VE edits - https://phabricator.wikimedia.org/T146688#2668489 (10ssastry) [19:43:16] (03CR) 10Krinkle: [C: 032] Use slice instead of substring per code conventions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312864 (owner: 10TheDJ) [19:49:56] (03Merged) 10jenkins-bot: Use slice instead of substring per code conventions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312864 (owner: 10TheDJ) [21:40:23] 10VisualEditor, 10MediaWiki-Page-editing, 06Community-Liaisons (Jan-Mar 2017): CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#2668976 (10Whatamidoing-WMF) [21:40:56] 10VisualEditor, 10MediaWiki-Page-editing, 06Community-Liaisons (Oct-Dec-2016): CLs to communicate the Save/Publish change - https://phabricator.wikimedia.org/T134580#2270044 (10Whatamidoing-WMF) [21:43:51] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016): Support the VisualEditor team with the "Iterate on the New Wikitext Editor Beta Feature" goal - https://phabricator.wikimedia.org/T145529#2668989 (10Whatamidoing-WMF) Step one is {T142645}. [21:45:46] 10VisualEditor, 10VisualEditor-MediaWiki, 06Community-Liaisons (Oct-Dec-2016), 07Notice: Announce the new 2017 wikitext editor - https://phabricator.wikimedia.org/T142645#2541868 (10Whatamidoing-WMF) The current version can be seen via Beta Features at https://en.wikipedia.beta.wmflabs.org/wiki/Special:Pre... [22:56:15] 10VisualEditor, 07Beta-Cluster-reproducible, 13Patch-For-Review, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): [Regression pre-wmf.21] VE crashes while adding images, showing error "TypeError: xhr.abort is not a function" - https://phabricator.wikimedia.org/T146661#2669149 (10greg) The screenshot shows this is... [23:56:30] 10VisualEditor, 07Beta-Cluster-reproducible, 13Patch-For-Review, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): [Regression pre-wmf.21] VE crashes while adding images, showing error "TypeError: xhr.abort is not a function" - https://phabricator.wikimedia.org/T146661#2669436 (10matmarex) Right.