[00:14:34] James_F, I'm thinking about https://phabricator.wikimedia.org/T137424 [00:14:42] For logged in users this makes sense [00:14:52] I think [00:15:21] But for logged out users we can't change this stuff based on a cookie [00:16:45] So we're left with JavaScript changing it? [00:16:52] Why do I feel like I've done this before [00:30:07] It also appears to be the main tab as well? [00:30:30] no [00:35:56] okay, WTF was I doing messing with $( '#ca-edit a' ) at the beginning of activatePageTarget? [00:36:10] https://gerrit.wikimedia.org/r/#/c/258230/6/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js [00:36:13] What. [01:14:14] (03PS1) 10Alex Monk: Attempt to make changing of edit tabs when our remember-last preference changes work, also change edit section links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296680 (https://phabricator.wikimedia.org/T137424) [01:20:34] 10VisualEditor, 10VisualEditor-MediaWiki: On SET wikis/"Remember my last editor", section edit links say "Edit" even when they mean "Edit source" - https://phabricator.wikimedia.org/T137424#2416750 (10AlexMonk-WMF) a:03AlexMonk-WMF Uploaded something that should hopefully address this while Phab was down: ht... [01:57:27] (03CR) 10DLynch: "So, this would come up when there's mixed numeric and named namespaces in the configs, and the same one is referenced both ways, right?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [02:04:45] (03CR) 10Alex Monk: "I think that's the case it comes up in, yes. E.g. in my development install it fixes this: " It will be available in the following namespa" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [04:18:49] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikidata: TemplateData: TemplateData should have a parameter to support Wikidata - https://phabricator.wikimedia.org/T69659#2416874 (10eranroz) Just to comment to TheDJ example, in hewiki we use meta template (actually - Lua Module) for wikidata i... [05:19:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource, and 2 others: Get rid of
which spans multiple sections, so that each section is balanced HTML - https://phabricator.wikimedia.org/T133294#2416892 (10Mpaa) >>! In T133294#2416306, @Mpaa wrote: > And if I try to f... [10:02:02] 10VisualEditor: VisualEditor 1.25: Image alignment causes VisualEditor to not load in REL1_25 - https://phabricator.wikimedia.org/T123471#2417240 (10Raftab) I've tried to disable all extensions, same issue. I've pinned it down in the Parsoid code to the differences between this snippet (no pipes in images): ``... [10:19:12] Krenair: Yeah, I agree, it's a logged-in-user-only feature (same as varying the tab label) [10:20:00] Aha, there's a patch. [10:20:46] 10VisualEditor, 10VisualEditor-MediaWiki: On SET wikis/"Remember my last editor", section edit links say "Edit" even when they mean "Edit source" - https://phabricator.wikimedia.org/T137424#2367924 (10Jdforrester-WMF) (Only possible to vary this for logged-in editors, of course.) [10:22:46] (03PS2) 10Jforrester: DAT.init#setEditorPreference: Change section edit alongside tab labels [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296680 (https://phabricator.wikimedia.org/T137424) (owner: 10Alex Monk) [10:35:34] 10VisualEditor: VisualEditor 1.26: Image alignment causes VisualEditor to not load in REL1_26 - https://phabricator.wikimedia.org/T123471#2417343 (10Raftab) [10:36:19] 10VisualEditor: VisualEditor 1.26: Image alignment causes VisualEditor to not load in REL1_26 - https://phabricator.wikimedia.org/T123471#1930792 (10Raftab) [11:12:21] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): If a parameter is marked as suggested or required in TemplateData, then always display that parameter in the template dialog - https://phabricator.wikimedia.org/T97482#2417451 (10Jdforrester-WMF) >>! In T97482#2416492... [11:30:57] edsanders: hi :) I updated to mw 1.27, ve too. I noticed span tags are now handled by default. It's a big problem for my extension. So I ch [11:31:48] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 4 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2417480 (10Elitre) [11:31:52] 10VisualEditor, 10MediaWiki-Page-editing, 06Community-Liaisons (Jul-Sep-2016): CLs to socialize the Save/Publish change - https://phabricator.wikimedia.org/T134580#2417478 (10Elitre) 05stalled>03Open The related page is on Meta at https://meta.wikimedia.org/wiki/Editing/Publish . [11:32:07] Switched the tag to a custom one. But, if I edit the page again the tag is not recognized [11:33:22] It has some data-* attributes. [11:33:47] Could be it the problems in tag recognize process? [11:33:56] 10VisualEditor, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2413838 (10Esanders) It could, but experimenting it seems any colour reduces the contrast between links and non-links significantly (it isn't very high to begin with). It doesn't help... [11:39:28] 10VisualEditor, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417492 (10Esanders) current: {F4216197} hue rotations: {F4216222} {F4216206} {F4216208} {F4216210} {F4216213} {F4216215} {F4216219} Blue actually has a quite high contrast - but coul... [11:45:53] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2414935 (10Esanders) Your link takes me to 'Bad title'. [11:52:57] 10VisualEditor: Unchecking Styled (Wikitable) does not change the table property - https://phabricator.wikimedia.org/T138896#2417510 (10Esanders) Seems to work in cases when the table is also sortable - so looks like the bug is with settings the class list to empty. [11:56:53] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 2 others: Re-label the "Save" button to use "Save page" when creating and "Save changes" when modifying an existing page - https://phabricator.wikimedia.org/T139033#2417525 (10Jdforrester-WMF) [12:03:27] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417546 (10Jdforrester-WMF) p:05Triage>03Normal a:03Esanders [12:03:45] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2413838 (10Jdforrester-WMF) 05Open>03Resolved Thanks, Ed; I'm content that the current colour is sufficient. [12:05:16] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417564 (10Elitre) So this is declined? [12:05:53] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417566 (10Jdforrester-WMF) >>! In T138914#2417564, @Elitre wrote: > So this is declined? The consideration was accepted and done; the decision is to st... [12:09:36] (03PS1) 10Esanders: Don't restore class attribute on class attribute nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296720 (https://phabricator.wikimedia.org/T138896) [12:25:12] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417640 (10Esanders) I don't actually object to a different shade of green, or even purple/pink, if that helps. [12:25:23] (03CR) 10Jforrester: [C: 031] Don't restore class attribute on class attribute nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296720 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [12:32:21] (03PS1) 10Esanders: Test removing all table classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296722 (https://phabricator.wikimedia.org/T138896) [12:36:06] (03CR) 10jenkins-bot: [V: 04-1] Test removing all table classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296722 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [12:41:32] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: start building a volunteer, cross-wiki taskforce to help with the community side of VE work - https://phabricator.wikimedia.org/T130533#2417704 (10Elitre) The taskforce page has now been linked from newsletter-related announcements, from th... [12:43:28] 10VisualEditor, 10MediaWiki-General-or-Unknown, 07I18n: Text in information pop-up for edit modes on first-time use does not adjust size for text lenght - https://phabricator.wikimedia.org/T138731#2408312 (10Esanders) Medium: {F4216370} SV: {F4216379} We probably also shouldn't be using such long messages... [12:44:25] (03PS1) 10Esanders: Make edit tab dialog wider to accommodate long messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296725 (https://phabricator.wikimedia.org/T138731) [12:45:12] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417719 (10Esanders) 05Resolved>03Open [12:47:58] 10VisualEditor: Log in when running screenshot tests - https://phabricator.wikimedia.org/T139042#2417722 (10Esanders) [12:48:31] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417736 (10Elitre) >>! In T138914#2417492, @Esanders wrote: > {F4216206} > > Blue actually has a quite high contrast - but could be confused with a nor... [12:50:28] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 3 others: Re-label the "Save" button to use "Save page" when creating and "Save changes" when modifying an existing page - https://phabricator.wikimedia.org/T139033#2417525 (10Johan) When will this happen? [12:50:34] edsanders, hi, in js, how do you insert an icon from the extension? This seems wrong - mw.html.element( 'img', { [12:50:34] src: '/w/extensions/Kartographer/modules/wikivoyage/images/Wikimedia-logo.png', [12:50:34] srcset: '/w/extensions/Kartographer/modules/wikivoyage/images/Wikimedia-logo@1.5.png 1.5x, /w/extensions/Kartographer/modules/wikivoyage/images/Wikimedia-logo@2x.png 2x' } [13:02:34] (03CR) 10Jforrester: [C: 032] Make edit tab dialog wider to accommodate long messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296725 (https://phabricator.wikimedia.org/T138731) (owner: 10Esanders) [13:03:05] 10VisualEditor, 10VisualEditor-MediaWiki, 07I18n: Text in information pop-up for edit modes on first-time use does not adjust size for text lenght - https://phabricator.wikimedia.org/T138731#2417753 (10Jdforrester-WMF) p:05Triage>03Low a:03Esanders [13:03:12] 10VisualEditor, 10VisualEditor-MediaWiki, 07I18n: Text in information pop-up for edit modes on first-time use does not adjust size for text lenght - https://phabricator.wikimedia.org/T138731#2408312 (10Jdforrester-WMF) 05Open>03Resolved [13:10:56] (03CR) 10jenkins-bot: [V: 04-1] Make edit tab dialog wider to accommodate long messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296725 (https://phabricator.wikimedia.org/T138731) (owner: 10Esanders) [13:16:26] James could I ask you something? [13:17:02] James_F could I ask you something? [14:00:34] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417889 (10Esanders) Not really: {F4216542} [14:03:08] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2417960 (10Elitre) I guess that depends on browsers etc. [14:08:39] (03PS1) 10Jforrester: Show a different label for buttons on create vs. modify [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296745 (https://phabricator.wikimedia.org/T139033) [14:08:41] (03PS1) 10Jforrester: Vary the 'save' labels to 'publish' for public wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) [14:15:35] (03CR) 10jenkins-bot: [V: 04-1] Vary the 'save' labels to 'publish' for public wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [14:18:37] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 3 others: Re-label the "Save" button to use "Save page" when creating and "Save changes" when modifying an existing page - https://phabricator.wikimedia.org/T139033#2418060 (10Jdforrester-WMF) >>! In T139033#2417737,... [14:23:16] 10VisualEditor: VisualEditor 1.26: Image alignment causes VisualEditor to not load in REL1_26 - https://phabricator.wikimedia.org/T123471#2418086 (10Raftab) I've downgraded my node from 5.2.x to v0.10.29 (as suggested by the parsoid install). I've upgraded my parsoid to 0.5.1. Still getting {F4216690} [14:37:45] (03PS2) 10Jforrester: Vary the 'save' labels to 'publish' for public wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) [14:38:39] (03PS2) 10Jforrester: Show a different label for buttons on create vs. modify [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296745 (https://phabricator.wikimedia.org/T139033) [14:39:11] (03CR) 10Jforrester: [C: 04-1] "We won't be doing this for a few weeks to make sure that we have enough translations." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296745 (https://phabricator.wikimedia.org/T139033) (owner: 10Jforrester) [14:39:48] (03CR) 10Jforrester: [C: 04-1] "We won't be doing this for a few weeks to make sure that we have enough translations." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [14:44:16] James_F: is there documentation somewhere of what all the visualeditor-related preferences do? I'm working on enabling VE and getting all the settings standardized, and I'm not sure what some of them do. [14:44:55] (incidentally, what does the 'visualeditor-enable' preference do? I tried setting that via OAuth, and I get a warning that it isn't a valid preference.) [14:45:38] I'm assuming the way to bypass the VE off-by-default behavior on enwiki for a new account is to set visualeditor-betatempdisable=1 [14:45:40] ragesoss: Err, yes? But there are between 0 and 1 user-settable preferences in WMF production. [14:45:56] ragesoss: No. [14:46:46] ragesoss: The list is https://www.mediawiki.org/wiki/Extension:VisualEditor#Complete_list_of_configuration_options but what you want is a hack, not a preference. [14:47:45] James_F: these are the ones that show up via the API: "visualeditor-enable":1,"visualeditor-betatempdisable":"1","visualeditor-enable-experimental":0,"visualeditor-enable-language":0,"visualeditor-hidebetawelcome":"1","visualeditor-autodisable":0,"visualeditor-tabs":"remember-last","visualeditor-editor":"wikitext","visualeditor-hidetabdialog":0, [14:47:51] although some are editable, others are not. [14:48:21] is that the same thing described in that table, just with CamelCase instead? [14:48:55] ragesoss: You want to set 'visualeditor-editor' to 'visualeditor' [14:49:09] ragesoss: No, most are hard-config'ed. [14:50:19] aletundo: Hey. [14:51:13] okay. so, I can set visualeditor-editor, and I can bypass the welcome with hidebetawelcome and hidebetadialog, and I can probably set the tabs as well. [14:51:20] that'll probably suffice. [14:52:38] James_F hey, so the problem is: I'm using tag to make some 'custom annotations' but now my tool is in conflict with SpanAnnotation model. First time I use m [14:52:56] So now I switched to a custom tag [14:53:05] * James_F nods. [14:53:42] Does that work? [14:54:01] You'd need to make the serialise method more specific than I guess. [14:54:27] But after page is saved, if I edit the page again the custom tag is not recognized and the all the code is display [14:55:10] what does your DM node code look like? [14:55:46] Just a moment I'm going to use pastebin [14:57:32] 10VisualEditor, 10Parsoid: VisualEditor 1.26: Image alignment causes VisualEditor to not load in REL1_26 - https://phabricator.wikimedia.org/T123471#2418198 (10Raftab) [14:58:32] http://pastebin.com/MzK1LL93 edsanders, James_F [14:59:00] * James_F looks. [15:05:27] oh - well you have matchTagNames = ['easlink'] [15:05:34] so you are only matching tags [15:06:35] oh - are you creating easylink tags in the model - I see [15:06:50] I'm not sure if Parsoid will handle those... [15:06:56] you might have to use a valid HTML5 tag [15:07:31] is supposed to be a wikitext tag? [15:08:26] edsanders: aletundo_ Said that originally they were using a but VE didn't like it. [15:08:40] yes, i handle it with a parser hook. in fact in View mode it's okay [15:08:42] I'd have thought you could have a more specific selector? [15:08:57] But that shouldn't be a problem. [15:09:17] Parsoid will not convert it wikitext tags to an html/xml tag [15:09:30] it will convert it to [15:09:53] Also, Parsoid will handle it if it's a registered parser hook, as long as you restarted Parsoid since that code went live so it's not caching. [15:10:39] in which case you want matchTagNames = ['span'], and matchRdfaTypes = ['mw:Extension/easylink'] [15:10:47] (03CR) 10Jforrester: [C: 032] "Don't be difficult, CI." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296725 (https://phabricator.wikimedia.org/T138731) (owner: 10Esanders) [15:11:00] Before 1.27 update i use span tags and everything is okay, now span tag are handled by SpanAnnotation model and content editable..so when i open the visual editor again my annotations are handled by SpanAnnotation and not by my model [15:11:40] If you register as handling you'll take precedence over SpanAnnotation as you're more specific. [15:12:06] James_F oh, it sounds great! [15:12:31] * James_F tries to remember how to do that. :-) [15:12:40] so i have to add to my model the static property mathRDFatype? [15:12:49] *match [15:13:30] yeah [15:13:37] Ah, yes, that's it. [15:14:45] okay, so this should take precedence over SpanAnnotation..I will have to make more changes? I mean to the ContentEditable too or the parserhook? [15:16:56] anything wil more than just a matchTagNames will take precendence [15:17:22] *with more [15:19:13] (03Merged) 10jenkins-bot: Make edit tab dialog wider to accommodate long messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296725 (https://phabricator.wikimedia.org/T138731) (owner: 10Esanders) [15:25:50] edsanders sorry if i seems "stupid" but it isn't clear if i will have to change my span parser hook and add a rdfa type to it [15:27:55] aletundo_: You should only have to change things inside the VE code (in JS), not your PHP stuff. [15:29:27] ok thank you so much..consider is the first time i develop a mw-extension...moreover it's my university intership..so i'm scared about not finish before the deadline :) [15:30:01] i'm going to try between this night and next morning..i will give you feedback asap [15:43:32] 10VisualEditor, 10VisualEditor-MediaWiki: SET broke my keyboard shortcuts - https://phabricator.wikimedia.org/T129488#2418462 (10Whatamidoing-WMF) a:05Whatamidoing-WMF>03None [15:44:14] 10VisualEditor: {{Better source}} template displays the |reason= as a span tag, rather than the template, in VisualEditor - https://phabricator.wikimedia.org/T103724#2418467 (10Whatamidoing-WMF) a:05Whatamidoing-WMF>03None [15:44:52] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 3 others: Re-label the "Save" button to use "Save page" when creating and "Save changes" when modifying an existing page - https://phabricator.wikimedia.org/T139033#2418471 (10Johan) OK, thanks. [15:45:26] 10VisualEditor, 06Community-Liaisons: Update "Known Problems" page for VE - https://phabricator.wikimedia.org/T94382#2418474 (10Whatamidoing-WMF) p:05Triage>03Normal [15:47:19] (03PS1) 10Jforrester: Follow-up e2f6d798: Make MWTemplateModel#addPromptedParameters work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296761 [15:47:30] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Offer the visual editor to Wikivoyages - https://phabricator.wikimedia.org/T139070#2418484 (10Whatamidoing-WMF) [15:48:27] (03CR) 10Esanders: [C: 032] Follow-up e2f6d798: Make MWTemplateModel#addPromptedParameters work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296761 (owner: 10Jforrester) [15:48:50] edsanders the problem is the same, with RDFa type the annotations are rendered as I set into parser hook, but if I click on the annotation the content editable showed is from SpanAnnotation not mine [15:51:53] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Offer the visual editor to Wikivoyages - https://phabricator.wikimedia.org/T139070#2418507 (10Whatamidoing-WMF) p:05Triage>03High Result: The Russian Wikivoyage expressed some concerns about how the visual editor interacted with their listing and geo te... [15:52:03] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Offer the visual editor to Wikivoyages - https://phabricator.wikimedia.org/T139070#2418511 (10Whatamidoing-WMF) 05Open>03Resolved [15:53:36] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Per-wiki customizable drop down menu for templates - https://phabricator.wikimedia.org/T96710#1225122 (10Whatamidoing-WMF) The Russian Wikivoyage has a single listing template, `{{listing}}`, but they would like multiple entries in this menu (equivalent to `{... [15:55:42] (03Merged) 10jenkins-bot: Follow-up e2f6d798: Make MWTemplateModel#addPromptedParameters work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296761 (owner: 10Jforrester) [15:57:57] edsanders http://picpaste.com/Schermata_da_2016-06-30_175045.jpg this is when i edit the page the first time [15:59:16] edsanders http://picpaste.com/Schermata_da_2016-06-30_175104-Y5FZL9aO.jpg and this after i saved the page, and open the visual editor again. I already added the matchRdfaTypes static property [16:00:43] aletundo_webchat: in the Network tab you should be able to find the HTML that Parsoid is sending you [16:00:50] (or RESTBase) [16:02:39] Or use ve.init.target.surface.getHtml() [16:04:23] 10VisualEditor, 10VisualEditor-Tables: There should be a visual indication that setting a table's properties to 'sortable' worked - https://phabricator.wikimedia.org/T139072#2418553 (10Whatamidoing-WMF) [16:10:16] 10VisualEditor, 10VisualEditor-MediaWiki: On SET wikis/"Remember my last editor", section edit links say "Edit" even when they mean "Edit source" - https://phabricator.wikimedia.org/T137424#2418585 (10AlexMonk-WMF) Hopefully my JS should help with logged out users but it needs better testing. [16:11:38] i found it and it's completely wrong. in the hook i convert the my span annotations into buttons with popover elements (i would like to use oojs elements but popups are not implemented into php) [16:12:21] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Community Liaisons' support to visual editor's rollout on Wikivoyages - https://phabricator.wikimedia.org/T139070#2418589 (10Elitre) [16:13:10] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Community Liaisons' support to visual editor's rollout on Wikivoyages - https://phabricator.wikimedia.org/T139070#2418484 (10Elitre) [16:13:12] 10VisualEditor, 10VisualEditor-MediaWiki, 07Category: Enable VisualEditor by default for all users of all Wikivoyages - https://phabricator.wikimedia.org/T132495#2418593 (10Elitre) [16:16:25] edsanders i found it and it's completely wrong. in the hook i convert the my span annotations into buttons with popover elements (i would like to use oojs elements but popups are not implemented into php). http://pastebin.com/MsQsktSf this is the response. as you can see ther's a button and the span tag [16:17:26] i'm so sad because before the upgrade it works well [16:17:41] aletundo_webchat: what is the wikitext for that page - and have you restarted Parsoid? [16:18:29] Orso [16:18:36] that's the wikitext [16:19:59] (03CR) 10DLynch: [C: 032] Don't restore class attribute on class attribute nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296720 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [16:21:31] (03CR) 10DLynch: [C: 032] Fix preference namespace list to handle duplicates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [16:22:36] (03Merged) 10jenkins-bot: Don't restore class attribute on class attribute nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296720 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [16:24:38] edsanders i restarted, but the problem still occurs [16:25:57] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Community Liaisons' support to visual editor's rollout on Wikivoyages - https://phabricator.wikimedia.org/T139070#2418612 (10Elitre) [16:26:16] is your Parsoid up to date, and are you using RESTBase? [16:29:50] (03Merged) 10jenkins-bot: Fix preference namespace list to handle duplicates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [16:31:36] (03CR) 10DLynch: [C: 04-1] Hack to not show menu immediately upon meta dialog opening for redirect change (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) (owner: 10Alex Monk) [16:33:32] (03Abandoned) 10Jforrester: Revert "MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296759 (owner: 10Jforrester) [16:34:08] 10VisualEditor, 06Community-Liaisons (Jul-Sep-2016): Add a few things to the FAQ page for the visual editor - https://phabricator.wikimedia.org/T127822#2418668 (10Elitre) [16:34:45] edsanders yes we use RESTBase, I'm not sure about parsoid version. I will try tomorrow again taking care of parsoid version. I'm going to work now, so I will ping you tomorrow. Thx a lot [16:35:34] (03CR) 10Jforrester: "We're actually going in a slightly different direction now, based on feedback – both labels will be available, and the site admin will pic" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281462 (https://phabricator.wikimedia.org/T131132) (owner: 10DLynch) [16:37:32] 10VisualEditor, 06Community-Liaisons (Jul-Sep-2016): Deliver multilingual June newsletter for VE - https://phabricator.wikimedia.org/T139076#2418673 (10Elitre) [16:41:18] (03PS1) 10Jforrester: Update VE core submodule to master (513f0bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296776 [16:41:49] (03PS2) 10Jforrester: Test removing all table classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296722 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [16:42:56] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-Tables: Unchecking Styled (Wikitable) does not change the table property - https://phabricator.wikimedia.org/T138896#2418697 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [16:47:46] 10VisualEditor, 10Parsoid: VisualEditor 1.26: Image alignment causes VisualEditor to not load in REL1_26 - https://phabricator.wikimedia.org/T123471#2418713 (10Raftab) I've fixed this my self by editing the source code of Mediawiki. Inside of resources/lib/oojs/oojs.jquery.js:256 I added a check to see if ori... [16:49:55] James_F: is there a preference that suppresses the educationPopup blue dots? [16:50:26] aha [16:50:27] visualeditor-hideusered [17:01:48] aletundo: have you tried editing the page to clear the RESTBase cache? [17:05:01] ragesoss: Yeah. [17:05:32] (03CR) 10Jforrester: [C: 032] Test removing all table classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296722 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [17:07:47] edsanders I think so, I shutdown now. Anyway in the parser hook I disabled the cache [17:08:44] you can as in #mediawiki-parsoid, but should not be parsed as an extension [17:10:20] edsanders, so what you suggest to me to do? [17:10:49] To make it the properly and cleany way [17:20:20] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (513f0bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296776 (owner: 10Jforrester) [17:29:07] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (513f0bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296776 (owner: 10Jforrester) [17:29:10] (03CR) 10jenkins-bot: [V: 04-1] Test removing all table classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296722 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [17:39:26] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on more wikis - https://phabricator.wikimedia.org/T134949#2419012 (10AlexMonk-WMF) [17:42:36] James_F, I'd say there's maybe 6-8 hours worth of fixing several pages on many individual wikis left there :( [17:46:15] maybe less once some momentum is built, but I don't like to rush messing with random wiki's notice templates and MW namespace pages in languages I don't speak [17:46:24] Krenair: FWIW I was looking precisely at that task today and checking if I could maybe fix it.voy, but closed all the tabs screaming. it's out of my league. [17:46:47] maybe we could work together on the Italian pages though? [17:47:07] there's also it.wikivoyage [17:47:18] that was it [17:47:22] uh [17:47:26] I mean it.wiktionary [17:47:37] yup yup [17:47:57] happy to help one of these days if I can. [17:48:02] We could work together although I'm not quite sure what it'd look like it. you edit some pages and I do others? [17:48:28] some things have to be done in a specific order [17:48:48] I thought more, maybe you tell me if there's anything on those pages I can translate for you, or something. [17:49:27] To be honest most of these templates are copy+pasted from english [17:50:13] the language thing is me worrying about local admins who don't understand my english edit summaries [17:50:39] though so far I've done quite a few wikis and encountered no problems [17:50:59] then I can find translators for the edit summaries and you can edit once we have them :) [17:51:00] so maybe I'm just being unreasonably nervous about that [17:51:16] it makes sense, it's nice you're worrying about it. [18:32:21] 10VisualEditor, 10VisualEditor-EditingTools, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2419213 (10Esanders) We don't override Firefox because it doesn't (yet) let use set the selection colour consistently: {F4217697} [18:38:38] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (513f0bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296776 (owner: 10Jforrester) [18:38:51] (03CR) 10Esanders: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296776 (owner: 10Jforrester) [18:39:42] heyhey, I just got an error in Special:Notifications (having nothing to do with VE loading, theoretically) "Exception in module-execute in module ext.visualEditor.desktopArticleTarget.init:" "ypeError: conf.namespaces.indexOf is not a function TypeError: conf.namespaces.indexOf is not a function" [18:39:48] Is this known? [18:41:05] Krenair, it sounds related to what you fixed yesterday? I think? Something-namespaces and arrays...? [18:41:39] is the preference visualeditor-enable somehow special? ragesoss says he cannot set it via the API [18:42:10] I don't think so tgr [18:42:13] but why is he trying to change it? [18:42:39] mooeypoo, it sounds different to what I fixed yesterday [18:43:12] mooeypoo, mw.config.get( 'wgVisualEditorConfig' ).namespaces returns [100, 108, 118, 2, 6, 12, 14, 2, 6, 14, 0] [18:43:12] I suppose he wants different defaults for education program users [18:43:19] mw.config.get( 'wgVisualEditorConfig' ).namespaces.indexOf [18:43:20] indexOf() { [native code] } [18:43:32] Krenair, ok, I'll see if it happens again and report if so [18:43:38] Krenair: what I'm trying to do is enable VE as the default for students using an OAuth app. But James explained to me that visualeditor-editor: visualeditor is the setting that I wanted. [18:43:58] I don't know what 'visualeditor-enable' does, but it's one of the hard-coded preferences and cannot be changed. [18:44:06] It enables VE. [18:44:24] visualeditor-editor is a SET preferences and I make no guarantees what might happen if you mess with it. [18:44:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (513f0bd) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296776 (owner: 10Jforrester) [18:45:07] Krenair: what does that mean, a SET preference? [18:45:18] All preferences can be changed. [18:45:46] ragesoss, Single Edit Tab, we look at visualeditor-editor preference if the wiki has SET enabled and the user has the 'remember-last' visualeditor-tabs value [18:46:30] Whenever visualeditor-editor gets changed a cookie is also set. [18:46:39] Krenair: my goal is to basically work around the en-wiki situation of VE being not the default for new editors anymore. [18:46:40] By VE code anyway [18:47:04] It's not the default for new editors anymore? [18:47:09] James_F? [18:47:23] I think I got it working with these settings: 'visualeditor-editor=visualeditor', # enables VE as default editor [18:47:23] 'visualeditor-hidebetawelcome=1', # skips the 'start editing' dialog on first edit [18:47:23] 'visualeditor-hideusered=1', # disables the blue dots on cite and link buttons [18:47:23] 'visualeditor-tabs=multi-tab' # enables both Edit and Edit Source tabs [18:48:05] trying to change visualeditor-enable via the API returns a warning that it is not a valid preference. [18:48:12] Why are you setting visualeditor-editor=visualeditor but then visualeditor-tabs=multi-tab? This makes no sense [18:48:16] (03Merged) 10jenkins-bot: Test removing all table classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296722 (https://phabricator.wikimedia.org/T138896) (owner: 10Esanders) [18:49:21] Krenair: how do those settings interact? visualeditor-editor is irrelevant if multi-tab is selected? [18:49:22] Oh, looking at the code I think you need BetaFeatures disabled for visualeditor-enable to be a proper preference [18:49:28] It should be [18:50:19] If BetaFeatures is enabled magic happens which I'm not familiar with [18:50:35] I was very confused by this magic. [18:51:35] 10VisualEditor, 10VisualEditor-MediaWiki: VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419278 (10Mooeypoo) [18:54:15] 10VisualEditor, 10VisualEditor-MediaWiki: VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419278 (10AlexMonk-WMF) I don't see this error [19:10:41] 10VisualEditor, 10VisualEditor-MediaWiki: VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419278 (10Esanders) Likewise - where did you see this? [19:12:53] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2419334 (10Esanders) Looks like the page has been deleted. [19:18:54] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2419341 (10Amire80) >>! In T138956#2419334, @Esanders wrote: > Looks like the page has been deleted. Heh. Moved to Draft space, and that diff has b... [19:24:12] 10VisualEditor, 10VisualEditor-MediaWiki: VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419353 (10Esanders) Seeing it on http://en.wikipedia.beta.wmflabs.org/wiki/Gallery?veaction=edit [19:24:24] 10VisualEditor, 10VisualEditor-MediaWiki: VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419354 (10Esanders) p:05Triage>03Unbreak! [19:26:38] ^ looking into that [19:27:00] thanks [19:27:10] looks like the changes we made yesterday [19:28:23] conf.namespaces should be a list but is now a dictionary [19:29:52] think it was my "Fix preference namespace list to handle duplicates" [19:31:32] Yeah that screwed things up [19:32:04] I forgot how array_unique messed with array keys [19:32:37] If array_unique removes indexes 3 and 4, indexes 5 and 6 don't get changed, so it looks like an object to the JSON formatter [19:32:50] array_values fixes this [19:33:26] we must be using half of PHP's array functions in ApiVisualEditor::getAvailableNamespaceIds by now [19:33:43] fix coming up [19:36:27] (03PS1) 10Alex Monk: Follow-up I9202066d: array_unique leaves gaps in keys, we need to run array_values on it afterwards [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296810 (https://phabricator.wikimedia.org/T139094) [19:36:55] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419412 (10AlexMonk-WMF) a:03AlexMonk-WMF Yep it's all over beta, and is my fault [19:37:37] mooeypoo, sorry about that, I was attempting to reproduce it on production before [19:49:33] (03PS3) 10Alex Monk: Hack to not show menu immediately upon meta dialog opening for redirect change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) [20:46:37] Krenair, no probs, I figured it's something related to yesterday since it was in master (I should have specified that I was using master rather than production, though, sorry!) [20:48:44] Krenair, it looks good to me, and I just tested. Anything preventing me from +2ing? Just want to make sure I don't step on anyone's toes here or on some ongoing fixes [20:49:14] (03CR) 10Esanders: [C: 032] Follow-up I9202066d: array_unique leaves gaps in keys, we need to run array_values on it afterwards [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296810 (https://phabricator.wikimedia.org/T139094) (owner: 10Alex Monk) [20:49:25] oh, that solves it [20:49:52] mooeypoo, we were changing this code yesterday but we also merged another change of mine today which broke things [20:50:21] (03CR) 10Krinkle: Trigger a custom event on #wpTextbox1 when we need to get the latest wikitext out of it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk) [20:50:37] (03CR) 10Krinkle: [C: 04-1] Trigger a custom event on #wpTextbox1 when we need to get the latest wikitext out of it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk) [20:51:20] mooeypoo, there wasn't anything preventing you from +2ing, but yes that solves it :) [20:51:27] anyway thanks again [20:55:04] (03Merged) 10jenkins-bot: Follow-up I9202066d: array_unique leaves gaps in keys, we need to run array_values on it afterwards [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296810 (https://phabricator.wikimedia.org/T139094) (owner: 10Alex Monk) [21:09:14] ryasmeen: on every page in betalabs I see TypeError: conf.namespaces.indexOf is not a function TypeError: conf.namespaces.indexOf is not a function(…) [21:09:28] ryasmeen: is it a known issue? [21:09:38] etonkovidova: yes, https://phabricator.wikimedia.org/T139094 [21:09:49] ryasmeen: ah ok then :) [21:10:28] We thought we just fixed it though [21:10:40] beta may not have picked up our fix yet [21:12:02] yeah, it takes time :) [21:12:38] It's working for me now? [21:12:40] mooeypoo, can you confirm? [21:13:40] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): VE throws an exception in all pages - https://phabricator.wikimedia.org/T139094#2419985 (10AlexMonk-WMF) 05Open>03Resolved Thanks @Mooeypoo, and Ed for merging [21:27:33] (03CR) 10DLynch: [C: 032] Hack to not show menu immediately upon meta dialog opening for redirect change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) (owner: 10Alex Monk) [21:35:24] (03Merged) 10jenkins-bot: Hack to not show menu immediately upon meta dialog opening for redirect change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) (owner: 10Alex Monk) [21:52:13] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: On auto-focusing the redirect entry box when editing a redirect, don't suggest replacements unless the user does something - https://phabricator.wikimedia.org/T137309#2420128 (10AlexMonk-WMF) 05Open>03Resolved [21:54:59] (03CR) 10Alex Monk: Trigger a custom event on #wpTextbox1 when we need to get the latest wikitext out of it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk) [21:56:37] Krenair, sorry, was distracted by a meeting -- it works well for me in master [21:56:45] ok [22:11:30] 10VisualEditor, 06Community-Liaisons (Jul-Sep-2016): Deliver multilingual June newsletter for VE - https://phabricator.wikimedia.org/T139076#2420175 (10Whatamidoing-WMF) [22:11:36] (03CR) 10Krinkle: Trigger a custom event on #wpTextbox1 when we need to get the latest wikitext out of it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk)