[00:01:04] (03CR) 10jenkins-bot: [V: 04-1] Update mediawiki_api gem to 1.7.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290854 (https://phabricator.wikimedia.org/T135884) (owner: 10Gergő Tisza) [04:43:53] 10VisualEditor, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2328940 (10KartikMistry) [06:28:04] 10VisualEditor: Switching from source section editing to visual editing says "Discard my changes and switch" without explaining why - https://phabricator.wikimedia.org/T136267#2329036 (10Amire80) [06:44:25] 10VisualEditor, 10VisualEditor-MediaWiki, 06Community-Liaisons: Roll back "Start editing" popup feature - https://phabricator.wikimedia.org/T136076#2329065 (10Ricordisamoa) Popups: "Back despite popular demand" (cit.) ;-) [08:37:48] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 4 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2156848 (10Scott) I agree that pages in the draft namespace sh... [09:27:04] 10VisualEditor, 06Editing-Department: JS Error when trying to insert template in Firefox - https://phabricator.wikimedia.org/T136279#2329359 (10Jhernandez) [09:47:27] James_F|Away: have there been any updates on the worldcat contract that Jake brought you? [10:11:48] 10VisualEditor, 06Editing-Department, 07JavaScript: JS Error when trying to insert template in Firefox - https://phabricator.wikimedia.org/T136279#2329453 (10Danny_B) [10:51:34] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 06Collaboration-Team-Interested, 10Flow, 07Regression: [Regression wmf23] On creating a wikilink/an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1649374 (10MSGJ) Just reported the same issue at... [11:56:39] (03CR) 10JanZerebecki: [C: 04-1] "Needs update of Gemfile.lock" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290854 (https://phabricator.wikimedia.org/T135884) (owner: 10Gergő Tisza) [11:59:45] 10VisualEditor, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2328940 (10Prtksxna) On Fedora and MacOS, I see the `str.replace` error but it does not stop the dialog from opening and functioning. My interface language is set to hindi. [12:07:45] (03PS1) 10Esanders: Append surface & toolbar components in the correct places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290918 [12:07:47] (03PS1) 10Esanders: Clear save caches when toolbar is re-attached [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290919 [12:09:04] (03PS27) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) [12:12:40] (03CR) 10jenkins-bot: [V: 04-1] Append surface & toolbar components in the correct places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290918 (owner: 10Esanders) [12:13:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders) [12:15:48] (03CR) 10jenkins-bot: [V: 04-1] Clear save caches when toolbar is re-attached [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290919 (owner: 10Esanders) [13:14:46] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor by default for all users of French Wikinews - https://phabricator.wikimedia.org/T133263#2329843 (10Mattho69) Bon je sais bien que vous vous fichez bien de Wikinews mais la dernière fois il a fallu 2 jours pour obtenir l'installation de l'éditeur vi... [13:15:31] (03CR) 10Hashar: "recheck" [unicodejs] - 10https://gerrit.wikimedia.org/r/276213 (owner: 10Paladox) [13:15:37] (03CR) 10Hashar: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/290464 (owner: 10Esanders) [14:05:24] (03PS2) 10Gergő Tisza: Update mediawiki_api gem to 1.7.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290854 (https://phabricator.wikimedia.org/T135884) [14:31:34] (03CR) 10JanZerebecki: [C: 032] Update mediawiki_api gem to 1.7.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290854 (https://phabricator.wikimedia.org/T135884) (owner: 10Gergő Tisza) [14:39:56] (03Merged) 10jenkins-bot: Update mediawiki_api gem to 1.7.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290854 (https://phabricator.wikimedia.org/T135884) (owner: 10Gergő Tisza) [14:52:14] mvolz: Not yet; I'll ping Jake. [14:52:39] James_F: don't worry about it, he got back to me since :D [14:52:45] Oh, OK. :-) [14:52:51] * James_F won't, then. :-) [15:16:31] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: start building a volunteer, cross-wiki taskforce to help with the community side of VE work - https://phabricator.wikimedia.org/T130533#2330423 (10Elitre) [15:17:07] (03PS1) 10Esanders: Pass dataTransferHandler to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/290951 [15:21:24] (03CR) 10jenkins-bot: [V: 04-1] Pass dataTransferHandler to surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/290951 (owner: 10Esanders) [15:39:39] (03PS2) 10Esanders: [BREAKING CHANGE] Always get registries/factories via surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/290951 [15:40:49] 10VisualEditor, 06Editing-Department, 07JavaScript: JS Error when trying to insert template in Firefox - https://phabricator.wikimedia.org/T136279#2329359 (10Krinkle) I can reproduce this bug in Chrome. 1. https://www.mediawiki.org/wiki/ResourceLoader/Version_1_Design_Specification?action=edit 2. Insert par... [15:41:17] 10VisualEditor, 06Editing-Department, 07JavaScript: Inserting template may throw "Uncaught Error: Invalid retain length, cannot retain backwards:-1" - https://phabricator.wikimedia.org/T136279#2330523 (10Krinkle) [15:41:24] 10VisualEditor, 10VisualEditor-MediaWiki, 06Editing-Department: Inserting template may throw "Uncaught Error: Invalid retain length, cannot retain backwards:-1" - https://phabricator.wikimedia.org/T136279#2329359 (10Krinkle) [15:42:59] (03CR) 10Jforrester: [C: 032] "Lovely." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290653 (https://phabricator.wikimedia.org/T58289) (owner: 10Esanders) [15:43:26] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Always get registries/factories via surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/290951 (owner: 10Esanders) [15:44:04] 10VisualEditor, 10VisualEditor-MediaWiki, 07User-notice: VisualEditor: When editing a file/category page, show the non-page composite components outside the VE surface in their "normal" place - https://phabricator.wikimedia.org/T58289#2330541 (10Jdforrester-WMF) 05Open>03Resolved a:05AlexMonk-WMF>03Es... [15:48:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422#2330577 (10AlexMonk-WMF) [15:49:56] (03Merged) 10jenkins-bot: Genericise target initialisation across namespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290653 (https://phabricator.wikimedia.org/T58289) (owner: 10Esanders) [15:52:37] (03PS2) 10Jforrester: Append surface & toolbar components in the correct places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290918 (owner: 10Esanders) [15:52:59] (03CR) 10Jforrester: [C: 032] Append surface & toolbar components in the correct places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290918 (owner: 10Esanders) [15:53:06] (03PS2) 10Jforrester: Clear save caches when toolbar is re-attached [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290919 (owner: 10Esanders) [15:53:23] (03CR) 10Jforrester: [C: 032] Clear save caches when toolbar is re-attached [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290919 (owner: 10Esanders) [15:56:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 06Editing-Department: Inserting template into a block slug(?) throws "Uncaught Error: Invalid retain length, cannot retain backwards:-1", crashes editor - https://phabricator.wikimedia.org/T136279#2330600 (10Jdforrester-WMF) p:0... [15:56:23] edsanders: Argh ^^^ [15:59:37] (03Merged) 10jenkins-bot: Append surface & toolbar components in the correct places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290918 (owner: 10Esanders) [16:00:10] (03Merged) 10jenkins-bot: Clear save caches when toolbar is re-attached [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290919 (owner: 10Esanders) [16:01:10] Oh, umm. [16:02:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 06Editing-Department: Inserting template into a block slug(?) throws "Uncaught Error: Invalid retain length, cannot retain backwards:-1", crashes editor - https://phabricator.wikimedia.org/T136279#2329359 (10Ryasmeen) I tried to... [16:07:12] (03PS1) 10Jforrester: Follow-up 1dc933be: Don't fatal when editing non-NS0/6/14 pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290958 [16:10:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: Math nodes are not getting rendered for the first time in a login session - https://phabricator.wikimedia.org/T132620#2330717 (10TerraCodes) Can reproduce on testwiki. {F4057490} [16:12:03] (03PS1) 10Esanders: Use insertContent with templates when range is collapsed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290961 (https://phabricator.wikimedia.org/T136279) [16:12:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 06Editing-Department: Inserting template into a block slug(?) throws "Uncaught Error: Invalid retain length, cannot retain backwards:-1", crashes editor - https://phabricator.wikimedia.org/T136279#2330726 (10Esanders) It happens... [16:14:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 06Editing-Department: Inserting template into a block slug(?) throws "Uncaught Error: Invalid retain length, cannot retain backwards:-1", crashes editor - https://phabricator.wikimedia.org/T136279#2330745 (10Esanders) https://ger... [16:15:18] 10VisualEditor, 10Math: Fix empty math editing box for users of MathML rendering mode - https://phabricator.wikimedia.org/T118435#2330746 (10Physikerwelt) The JS console shows `this.context.getSurface(...).executeComamnd is not a function` ``` 12:13:21.726 TypeError: this.context.getSurface(...).executeComamn... [16:17:10] 10VisualEditor, 10Math: Fix empty math editing box for users of MathML rendering mode - https://phabricator.wikimedia.org/T118435#1800301 (10Jdforrester-WMF) Not a duplicate. [16:19:31] 10VisualEditor, 10Math: Fix empty math editing box for users of MathML rendering mode - https://phabricator.wikimedia.org/T118435#2330757 (10Jdforrester-WMF) >>! In T118435#2330746, @Physikerwelt wrote: > The JS console shows `this.context.getSurface(...).executeComamnd is not a function` > > ``` > 12:13:21.7... [16:20:09] 10VisualEditor, 10Math: [Regression] When using MathML mode, the "quick editor" edit box is missing - https://phabricator.wikimedia.org/T118435#2330758 (10Jdforrester-WMF) p:05Normal>03High [16:20:29] 10VisualEditor, 10Math: [Regression] Quick Edit button in the math popup in VE dies on load - https://phabricator.wikimedia.org/T132736#2330764 (10Jdforrester-WMF) 05duplicate>03Open p:05Triage>03Unbreak! [16:20:36] James_F: Is it a known bug that "[edit]" shows up when using VisualEditor? I see it often on pages where part of it is transcluded. [16:20:56] E.g. the last section on https://www.mediawiki.org/wiki/Gerrit?action=edit [16:21:06] It also leaks into the edit summary if you change something below that part. [16:21:14] "/* See also[edit] */" [16:22:39] s/transcluded/special/ (e.g. blocks) [16:22:43] 10VisualEditor, 10Math: [Regression] When using MathML mode, the "quick editor" edit box is missing - https://phabricator.wikimedia.org/T118435#2330773 (10Physikerwelt) The editor does not crash entirely. You can still use the normal edit mode instead. [16:24:03] Krinkle: Not now. [16:25:48] (03CR) 10Jforrester: [C: 032] Use insertContent with templates when range is collapsed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290961 (https://phabricator.wikimedia.org/T136279) (owner: 10Esanders) [16:27:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 06Editing-Department: [Regression wmf.3] Inserting template into a block slug(?) throws "Uncaught Error: Invalid retain length, cannot retain backwards:-1", crashes editor - https://phabricator.wikimedia.org/T136279#2330804 (10Jdf... [16:31:33] 10VisualEditor, 10Math, 13Patch-For-Review: [Regression 1.27.0-wmf.21] Quick Edit button in the math popup in VE dies on load - https://phabricator.wikimedia.org/T132736#2330818 (10Jdforrester-WMF) a:03Jdforrester-WMF [16:32:08] (03Merged) 10jenkins-bot: Use insertContent with templates when range is collapsed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290961 (https://phabricator.wikimedia.org/T136279) (owner: 10Esanders) [16:34:01] (03PS1) 10Jforrester: Use insertContent with templates when range is collapsed [extensions/VisualEditor] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/290972 (https://phabricator.wikimedia.org/T136279) [16:34:09] (03CR) 10Jforrester: [C: 032] Use insertContent with templates when range is collapsed [extensions/VisualEditor] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/290972 (https://phabricator.wikimedia.org/T136279) (owner: 10Jforrester) [16:35:28] (03CR) 10Jforrester: [C: 04-1] "Unit test failure." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/290951 (owner: 10Esanders) [16:41:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: Math nodes are not getting rendered for the first time in a login session - https://phabricator.wikimedia.org/T132620#2330874 (10Physikerwelt) Can you please explain what you did, to reproduce the problem? I can not understand the title "Math nodes are not ge... [16:43:18] (03CR) 10Alex Monk: [C: 031] "Looks good but I didn't test yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [16:43:41] Krenair: Welcome back. :-) [16:43:45] hi [16:44:41] you noticed I was gone? [16:45:05] (03Merged) 10jenkins-bot: Use insertContent with templates when range is collapsed [extensions/VisualEditor] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/290972 (https://phabricator.wikimedia.org/T136279) (owner: 10Jforrester) [16:46:55] YUP. [16:47:01] Err. Yup. [16:48:15] There's going to be more days like yesterday, this was just the first exam [16:48:26] * James_F nods. [16:48:37] Good luck. [16:50:42] (03PS28) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) [16:51:05] I'm not sure how this previous code worked at all. . . [16:54:03] Krenair: Well, yeah… I wrote it, so "not well" is a possibility. [16:54:11] Krenair: Also, can I grab a super-quick +2 on https://gerrit.wikimedia.org/r/#/c/290958/ [16:55:17] Well, part of the previous code anyway [16:56:26] (03CR) 10Alex Monk: [C: 032] "Looks right, I didn't test the patch that caused this yet" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290958 (owner: 10Jforrester) [16:56:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: Math nodes are not getting rendered for the first time in a login session - https://phabricator.wikimedia.org/T132620#2330963 (10Ryasmeen) This is indeed VisualEditor bug, but it does not occur first time of each VisualEditor session (which your title was imp... [16:57:49] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2330964 (10Jdforrester-WMF) [16:57:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders) [16:58:21] James_F, no actually I think you carried forward the one line that didn't work [16:58:35] !User::getDefaultOption( 'visualeditor-editor' ) [16:58:48] Shouldn't that be checking visualeditor-enable instead? [16:59:14] Ooh. [16:59:17] Yeah, possibly. [17:00:34] 10VisualEditor, 10Math: [Regression] When using MathML mode, the "quick editor" edit box is missing - https://phabricator.wikimedia.org/T118435#2330976 (10Physikerwelt) 05Open>03Resolved a:03Physikerwelt @Jdforrester-WMF I'm tempted to argue that this was a duplicate... but who cares about a bug that was... [17:01:59] (03CR) 10Esanders: [C: 04-1] Follow-up 1dc933be: Don't fatal when editing non-NS0/6/14 pages (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290958 (owner: 10Jforrester) [17:03:05] ... It still seems to work though [17:03:36] (03Merged) 10jenkins-bot: Follow-up 1dc933be: Don't fatal when editing non-NS0/6/14 pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290958 (owner: 10Jforrester) [17:04:11] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2330986 (10Jdforrester-WMF) >>! In T104479#2304211, @Tpt wrote: > My 2cents: please not a 3rd Wikitext editor that will have to be supported by tool... [17:07:22] actually nope [17:07:36] I just had the default set to the wrong value [17:07:43] It really doesn't work, I think [17:08:57] (03CR) 10Alex Monk: [C: 04-1] Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [17:10:45] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1418337 (10Danny_B) Also {T28918} [17:11:06] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331024 (10Esanders) And as long as we need to support non-JS editors (core editor) and legacy gadgets (WikiEditor) that's not really an option. [17:11:08] (03PS4) 10Alex Monk: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [17:12:20] (03CR) 10Alex Monk: [C: 031] "James, if you agree with the change, I think either one of us can +2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [17:14:27] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331035 (10Esanders) >>! In T104479#2293326, @Paladox wrote: > Just one question with this we doint need to enable anything else so for example we d... [17:15:20] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331039 (10Esanders) [17:15:47] (03PS1) 10Alex Monk: Followup I9280fe4d: Merge main case with default, they are identical [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290991 [17:15:58] edsanders, James_F ^ [17:16:27] (03CR) 10Esanders: [C: 032] Followup I9280fe4d: Merge main case with default, they are identical [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290991 (owner: 10Alex Monk) [17:17:56] James_F: did you say there was a third ubreak now? [17:18:53] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting a link to a page (except user page) on Flow sometimes can't be pasted (invalid/blacklisted HTML?) - https://phabricator.wikimedia.org/T135621#2331072 (10Esanders) Can you retest as I suspect this is not fixed. [17:20:15] 10VisualEditor, 10Math: [Regression] When using MathML mode, the "quick editor" edit box is missing - https://phabricator.wikimedia.org/T118435#2331076 (10Jdforrester-WMF) Hmm. OK. :-) [17:20:31] 10VisualEditor, 10Math, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3), 05WMF-deploy-2016-05-31_(1.28.0-wmf.4): [Regression] When using MathML mode, the "quick editor" edit box is missing - https://phabricator.wikimedia.org/T118435#2331077 (10Jdforrester-WMF) [17:21:38] 10VisualEditor, 10Math, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3), 05WMF-deploy-2016-05-31_(1.28.0-wmf.4): [Regression 1.27.0-wmf.21] Quick Edit button in the math popup in VE dies on load - https://phabricator.wikimedia.org/T132736#2331097 (10Jdforrester-WMF) 05Open>03Resolved [17:22:05] 10VisualEditor, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2328940 (10Esanders) Works for me: https://en.wikipedia.org/wiki/Astagaon?veaction=edit&uselang=hi Have you tried logged out or in a clean browser session (e.g. private)? [17:23:41] edsanders: The Math-quick-edit-crash, the "whoops James just broke editing User: pages" one, and the can't-insert-templates-in-slugs one. [17:26:16] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331125 (10AlexMonk-WMF) >>! In T136109#2325334, @Nikerabbit wrote: > Is it confirmed that this... [17:27:31] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331145 (10AlexMonk-WMF) >>! In T136109#2327139, @Krinkle wrote: > Now happening in production... [17:28:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: Math nodes are not getting rendered for the first time in a login session - https://phabricator.wikimedia.org/T132620#2331149 (10Physikerwelt) > first time after you log in and opened VisualEditor and tried to add a math node Do you have any specific settings... [17:31:55] (03CR) 10Jforrester: [C: 032] Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [17:32:10] such self-merge [17:32:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Authentication-and-authorization, 06Reading-Infrastructure-Team, and 2 others: Update VisualEditor for AuthManager - https://phabricator.wikimedia.org/T135071#2331180 (10Jdforrester-WMF) 05Open>03Resolved [17:32:21] ;) [17:33:18] (03Merged) 10jenkins-bot: Followup I9280fe4d: Merge main case with default, they are identical [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/290991 (owner: 10Alex Monk) [17:34:15] legoktm: Yeah yeah. [17:34:30] legoktm: Feel free to fix the rest of https://phabricator.wikimedia.org/T110282 ;-) [17:36:14] 10VisualEditor, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2328940 (10Jdforrester-WMF) Hmm, also fatals for me. Possibly a default gadget or something? [17:38:54] 10VisualEditor, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2331198 (10KartikMistry) My common.js is https://en.wikipedia.org/wiki/User:KartikMistry/common.js anything in it? Gadgets: HotCat, Twinkle etc. [17:39:17] (03Merged) 10jenkins-bot: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [17:42:00] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting a link to a page (except user page) on Flow sometimes can't be pasted (invalid/blacklisted HTML?) - https://phabricator.wikimedia.org/T135621#2331221 (10Trizek-WMF) # links already included on some topics (quoting) -> Works # on a Topic, w... [17:44:08] James_F: https://youtu.be/CbtcgoV4VlE [17:48:41] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331243 (10Esanders) >>! In T104479#2294644, @Niharika wrote: > Thanks @Esanders. This looks really good. Could you possibly put it up on a test ins... [17:50:45] 10VisualEditor, 10VisualEditor-MediaWiki-References: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#2331251 (10Protonk) >>! In T92432#1862609, @Krinkle wrote: > I ran into this earlier today. `name=":0"` is too generic and easily causes problems when bringing in c... [17:52:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: Math nodes are not getting rendered for the first time in a login session - https://phabricator.wikimedia.org/T132620#2204608 (10AlexMonk-WMF) At http://en.wikipedia.beta.wmflabs.org/wiki/test?veaction=edit we somehow end up with .mwe-math-fallback-image-inli... [17:52:23] edsanders: Eurgh. Just an hour ago I was telling TrevorParscal that switching was likely to be quite hard and take a while. :-) [17:52:52] it was quite hard [17:54:17] It's still a bit hacky - Krenair will need to make is RestBASE friendly [17:54:29] so we can switch back [17:58:08] we have existing code to do the conversion from wikitext to html but it'll need changing, or maybe rewriting to work with Ed's code [17:58:25] * James_F nods. [17:58:37] All the SET code will need massive re-writing too, of course. [17:58:38] Fun times! [17:58:58] Krenair: BTW, could you sanity-check https://gerrit.wikimedia.org/r/#/c/284680/ and merge? Ed says that the code he's replacing never worked, I'm not sure. [17:59:27] Lovely... [18:04:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math: Math nodes are not getting rendered for the first time in a login session - https://phabricator.wikimedia.org/T132620#2331298 (10Ryasmeen) Nope no special settings. See if this screen capture helps. {F4057808} [18:05:35] (03CR) 10Alex Monk: [C: 04-1] Allow extensions to support extra namespaces and content models (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 (owner: 10Esanders) [18:19:47] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331333 (10Ryasmeen) Cant reproduce it anywhere either. [18:20:07] 10VisualEditor, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2328940 (10matmarex) I can't reproduce. [18:20:31] 10VisualEditor, 10VisualEditor-MediaWiki, 06Multimedia: Can't open Add Media dialog in VE - https://phabricator.wikimedia.org/T136263#2331336 (10matmarex) [18:22:52] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331340 (10Jdforrester-WMF) I'm OK with declaring this a Beta Cluster infrastructure temporary... [18:30:57] I did have a test instance in labs for demonstrating experimental VE stuff, but it looks like it's broken in various ways since :( [18:31:04] edsanders, James_F I could set up a new one later if it'd be useful [18:32:10] Krenair: Maybe. I like using Beta Cluster for testing. ;-) [18:52:53] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331536 (10Krinkle) This was definitely in production as shown above. I believe this may've bee... [18:53:50] Krenair: Do you see a way the session exception from LinkRenderer would cause wikitext to be "parsed" as unparsed but htmlescaped wikitext? [18:53:58] Maybe that $html parameter that was passed and not null [18:54:21] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331537 (10Jdforrester-WMF) Oh, hmm. Yeah, that looks plausible. [18:54:27] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2331538 (10Jdforrester-WMF) [18:54:35] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Cluster-reproducible, 07Regression: Interface messages on Save Dialog are not getting parsed, showing up as plain text - https://phabricator.wikimedia.org/T136109#2323555 (10Jdforrester-WMF) 05Open>03Resolved [18:58:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser, 07Wikimedia-log-errors: VisualEditorDataModule triggers "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T136124#2331544 (10Jdforrester-WMF) [18:59:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Parser, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3), and 2 others: VisualEditorDataModule triggers "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T136124#2324164 (10Jdforrester-WMF) [19:03:21] (03PS1) 10Esanders: Fix surface hiding hack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291015 [19:07:49] (03CR) 10Jforrester: [C: 031] "I think this is good enough for now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [19:08:19] James_F: I can break the test off into a separate commit, certainly. [19:08:35] Kemayo: Sure, though adding it isn't bad. [19:09:02] Kemayo: I was mostly concerned that we were getting sucked into the "this isn't perfect in so let's not do it at all until it is". :-) [19:09:25] Krenair: Can I throw two SWATs into your lap? I need to leave. :-( [19:09:46] yes [19:09:50] Kk. [19:11:07] Krinkle, those calls go through the parser :/ [19:12:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 06Editing-Department, 13Patch-For-Review: [Regression wmf.3] Inserting template into a block slug(?) throws "Uncaught Error: Invalid retain length, cannot retain backwards:-1", ... - https://phabricator.wikimedia.org/T136279#2331567 [19:13:00] Krenair: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=576467&oldid=576246 [19:13:02] Thank you! [19:16:43] Krenair: Yeah, but see the stack at https://phabricator.wikimedia.org/T136124 [19:16:47] It originates from Message::parse() [19:17:11] And after Linker::link(), it seems possible that $html would become $text [19:17:13] or something.. [19:17:21] BUt yeah, that s houldn't affect the whole parse output, just the link. [19:17:41] We saw html comments and showing up literally too [19:18:37] 10WikiEditor, 06Multimedia, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2331587 (10Prtksxna) >>! In T135917#2325575, @Schnark wrote: > Perhaps put the button below the field for the file name? > Something like this: > > Enter... [19:19:39] 10WikiEditor, 06Multimedia, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2331591 (10Nemo_bis) Yes, the vicinity of the filename field is the logical place. (Which doesn't necessarily mean it would be intuitive to users!) > Ano... [19:29:20] (03PS12) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [19:32:06] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331667 (10Paladox) >>! In T104479#2331035, @Esanders wrote: >>>! In T104479#2293326, @Paladox wrote: >> Just one question with this we doint need t... [19:33:04] 10WikiEditor, 06Multimedia, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2331668 (10Prtksxna) >>! In T135917#2331591, @Nemo_bis wrote: > Yes, the vicinity of the filename field is the logical place. (Which doesn't necessarily m... [19:33:48] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331672 (10Paladox) @Esanders would you be able to upload the source codes for that somewhere please. [19:35:16] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2331678 (10Danny_B) >>! In T104479#2331024, @Esanders wrote: > And as long as we need to support non-JS editors (core editor) and legacy gadgets (Wi... [19:47:11] (03PS1) 10Aaron Schulz: Send edit stash metrics for cache attempts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291022 [19:52:03] (03CR) 10jenkins-bot: [V: 04-1] Send edit stash metrics for cache attempts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291022 (owner: 10Aaron Schulz) [21:27:35] (03PS2) 10Aaron Schulz: Send edit stash metrics for cache attempts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291022 [22:29:57] (03PS1) 10Alex Monk: Track ETag header responses in special event logging schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291124 (https://phabricator.wikimedia.org/T135171) [22:31:06] (03CR) 10Alex Monk: "I8ee1a6f7 is needed to make this do anything useful" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291124 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [22:31:08] edsanders, ^ [22:43:49] edsanders, I need the VE change as well... [22:51:28] (03CR) 10Esanders: [C: 032] Track ETag header responses in special event logging schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291124 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [22:52:32] (03CR) 10Ori.livneh: [C: 032] Send edit stash metrics for cache attempts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291022 (owner: 10Aaron Schulz) [22:53:46] Thanks Ed [22:57:38] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2332401 (10Esanders) >>! In T104479#2331678, @Danny_B wrote: >>>! In T104479#2331024, @Esanders wrote: >> And as long as we need to support non-JS e... [23:00:54] (03Merged) 10jenkins-bot: Track ETag header responses in special event logging schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291124 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [23:01:36] (03Merged) 10jenkins-bot: Send edit stash metrics for cache attempts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/291022 (owner: 10Aaron Schulz) [23:22:54] 10VisualEditor, 10VisualEditor-MediaWiki, 06Community-Liaisons: Roll back "Start editing" popup feature - https://phabricator.wikimedia.org/T136076#2332465 (10sladen) 05Open>03stalled p:05Triage>03High Quim: please can you schedule getting this changeset rolled back until when/if it is in a suitable...