[00:00:03] Ta. [00:00:05] James_F: also, https://grafana.wikimedia.org/dashboard/db/edit-count [00:00:15] (wil be in this motht's perf notice mail) [00:00:44] Nice. [00:00:53] Woudl appear this week significantly fewer edits [00:01:01] But not super certain yet [00:02:37] Hmm. [00:02:57] Why did it go up so much in mid-January? [00:03:17] https://grafana.wikimedia.org/dashboard/db/edit-count?panelId=12&fullscreen [00:10:32] Krinkle: 'Cos currently weekly median (839), though 25% down from last week, is still very significantly above the weekly median then (694,578,626,…). [00:11:02] Krinkle: Last time we looked there was a massive bot run on svwiki and ? viwiki that was totally skewing the numbers on pages created/articles edited. [00:11:59] Krinkle: Also, have you been having issues with Chrome mis-painting the window chrome on Mac recently? See http://imgur.com/4RH8zoC (top right, etc.). [00:17:26] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog gets stuck when trying to save while logged out on a private wiki - https://phabricator.wikimedia.org/T128934#2090560 (10Catrope) [00:20:42] (03Merged) 10jenkins-bot: Update VE core submodule to master (f77ac2b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275134 (owner: 10Jforrester) [00:32:32] James_F: Hm.. what am I looking for that in screenshot? [00:32:52] OH top *left* [00:32:55] Krinkle: Top and especially top-left. [00:32:56] the window controls? [00:32:56] Oh, yeah. [00:33:03] Havent' seen that [00:33:05] looks weird indeed [00:33:13] I also notice it is behind the menu bar [00:33:16] which shouldn't be possible [00:33:20] And the title being half-under the menu bar. [00:33:21] or do you have a custom control for that? [00:33:30] That's the bug, in fact. [00:33:34] Right [00:33:50] Haven't seen that myself in either stable nor canary [00:33:55] The "old" window controls aren't unpainted, and the new ones are written (by the OS?) but Chrome paints everything else assuming it's still in the right place. [00:34:07] I think I only trigger it when opening a window full-screen. [00:34:16] Krenair: January spike to my knowledge is recovery from annual holiday edit dip [00:34:27] But this particular metric doesn't go back further than November so no idea [00:34:49] context? [00:34:54] James_F: ^ [00:34:55] sorry [00:35:14] IRCCloud has a bug where it changes autocomplete tab order based on all channel rather than how it used to be (just the current channel) [00:35:27] Helpful. [00:35:28] sometimes! [00:35:33] Krinkle: I'd not get too worried for now. [00:35:54] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog gets stuck when trying to save while logged out on a private wiki - https://phabricator.wikimedia.org/T128934#2090635 (10Catrope) So what actually happens is VE sends a visualeditoredit API request, which for some strange reason doesn't fail with readapiden... [00:46:49] (03PS1) 10Catrope: Follow-up 2c24efae: fix typo in event name for unknown save errors. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 [00:48:37] Woo! Microsoft :) Way to go [00:48:37] https://support.microsoft.com/en/lifecycle#gp/Microsoft-Internet-Explorer [00:48:41] Happy redirect chain [00:48:47] (03CR) 10Jforrester: Follow-up 2c24efae: fix typo in event name for unknown save errors. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 (owner: 10Catrope) [00:48:48] en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/en/ [00:50:03] (03PS2) 10Krinkle: Follow-up 2c24efae: fix typo in event name for unknown save errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 (owner: 10Catrope) [00:50:19] (03CR) 10Krinkle: [C: 031] "If null really can be passed, that if check may need expansion." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 (owner: 10Catrope) [00:50:45] (03PS3) 10Catrope: Follow-up 2c24efae: fix typo in event name for unknown save errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 [00:51:19] (03PS4) 10Catrope: Follow-up 2c24efae: fix typo in event name for unknown save errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 [00:51:52] (03CR) 10Catrope: "I didn't check very thoroughly if data can be null, but both the docs of this method and of its caller claim it can be, so I added a check" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 (owner: 10Catrope) [01:31:48] (03PS5) 10Catrope: Follow-up 2c24efae: fix typo in event name for unknown save errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 [01:36:33] (03PS1) 10Catrope: Handle API errors when refetching the edit token [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275148 (https://phabricator.wikimedia.org/T128934) [01:37:37] (03CR) 10Catrope: "The error message probably needs work, and we may want to include a link to Special:Userlogin that opens in a new tab. The most common cau" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275148 (https://phabricator.wikimedia.org/T128934) (owner: 10Catrope) [01:38:02] James_F: --^^ fixes the bug but needs wordsmithing [01:52:09] (03CR) 10Jforrester: [C: 032] Follow-up 2c24efae: fix typo in event name for unknown save errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 (owner: 10Catrope) [02:01:59] (03Merged) 10jenkins-bot: Follow-up 2c24efae: fix typo in event name for unknown save errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275140 (owner: 10Catrope) [02:03:10] (03PS2) 10Jforrester: Handle API errors when refetching the edit token [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275148 (https://phabricator.wikimedia.org/T128934) (owner: 10Catrope) [02:05:47] (03PS3) 10Jforrester: Handle API errors when refetching the edit token [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275148 (https://phabricator.wikimedia.org/T128934) (owner: 10Catrope) [02:05:56] (03CR) 10Jforrester: [C: 032] Handle API errors when refetching the edit token [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275148 (https://phabricator.wikimedia.org/T128934) (owner: 10Catrope) [02:06:30] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog gets stuck when trying to save while logged out on a private wiki - https://phabricator.wikimedia.org/T128934#2090811 (10Jdforrester-WMF) p:5Triage>3Normal a:3Catrope [02:06:38] 10VisualEditor, 10VisualEditor-MediaWiki: Save dialog gets stuck when trying to save while logged out on a private wiki - https://phabricator.wikimedia.org/T128934#2090560 (10Jdforrester-WMF) 5Open>3Resolved [02:16:33] (03Merged) 10jenkins-bot: Handle API errors when refetching the edit token [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275148 (https://phabricator.wikimedia.org/T128934) (owner: 10Catrope) [02:47:24] (03PS31) 10Alex Monk: Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) [03:13:04] 10VisualEditor, 10VisualEditor-ContentEditable, 7Accessibility, 7Browser-Support-Firefox: VisualEditor: In Firefox's High Contrast mode, buttons on the toolbar are unidentifiable - https://phabricator.wikimedia.org/T54675#2090892 (10Volker_E) Visual Editor in Windows 7 High Contrast Mode in Firefox 44 {F35... [07:00:44] 10VisualEditor, 10VisualEditor-ContentEditable, 7Accessibility, 7Browser-Support-Firefox: VisualEditor: In Firefox's High Contrast mode, buttons on the toolbar are unidentifiable - https://phabricator.wikimedia.org/T54675#2090917 (10TheDJ) id call this an OS bug... [07:21:39] 10VisualEditor: Trying to add http pefi led to nowiki tags - https://phabricator.wikimedia.org/T128943#2090922 (10Magioladitis) [07:21:55] 10VisualEditor: Trying to add http prefix led to nowiki tags - https://phabricator.wikimedia.org/T128943#2090934 (10Magioladitis) [10:06:36] 10VisualEditor: Trying to add http prefix led to nowiki tags - https://phabricator.wikimedia.org/T128943#2090922 (10Sjoerddebruin) Links should be added with the appropriate tools, I think VE thinks this is wikitext. [10:08:08] 10VisualEditor: VisuaEditor popup for single tab is too small - https://phabricator.wikimedia.org/T128909#2089900 (10Sjoerddebruin) Can confirm in Dutch, please think about other languages. Those can use more words for the same thing. {F3526694} [12:56:56] 10VisualEditor, 10Math: Improve the coverage and organisation of the math dialog functions - https://phabricator.wikimedia.org/T123402#2091111 (10Esanders) [12:56:58] 10VisualEditor, 10Math, 13Patch-For-Review: Give SVGs in the math dialog menu the same baseline - https://phabricator.wikimedia.org/T123397#1928368 (10Esanders) 5Open>3Resolved [13:44:48] (03PS1) 10Ricordisamoa: Update ArticleTarget for new API token handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275168 [14:07:53] 10VisualEditor: VisualEditor edit incorrectly flagged as removing categories and reflist - https://phabricator.wikimedia.org/T128952#2091161 (10JeanFred) [15:31:53] 10VisualEditor: Use keyboards arrows with an inline template produces an unexpected behavior on VE. - https://phabricator.wikimedia.org/T128861#2088390 (10Pols12) This problem occurs with **combination** of a template and a formatting markup (bold, italic...). [15:47:56] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps: Switching edit source <-> edit shows map as markup every other time - https://phabricator.wikimedia.org/T128956#2091246 (10Yurik) [15:48:12] edsanders, you will love this one :) ^ [15:49:58] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps: Switching edit source <-> edit shows map as markup every other time - https://phabricator.wikimedia.org/T128956#2091259 (10Yurik) [16:04:59] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps: Switching edit source <-> edit shows map as markup every other time - https://phabricator.wikimedia.org/T128956#2091266 (10Esanders) I purged the RESTBase cache (action=purge) and it appears as syntax every time. [16:17:58] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps: Switching edit source <-> edit shows map as markup every other time - https://phabricator.wikimedia.org/T128956#2091268 (10Yurik) I just went to http://vem4.wmflabs.org/wiki/A and did action=purge. Afterwards I did a full reload (with local cache flush),... [16:18:05] edsanders, ^ something is still amiss there [16:20:56] sounds like the restbase cache [16:24:13] I think yesterday almost every second edit on VE loaded old version (with warning about that) so this may explain it too [16:26:42] edsanders, even after the new version of the page was created? [16:55:12] (03PS1) 10Esanders: Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275193 [16:57:44] (03PS2) 10Esanders: Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275193 (https://phabricator.wikimedia.org/T128805) [17:00:27] (03CR) 10Florianschmidtwelzow: "@Alex: The user input is fixed and works now, thanks :) However, if I switch to "plain wikitext input" for a suggested parameter, it still" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [17:02:35] (03CR) 10jenkins-bot: [V: 04-1] Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275193 (https://phabricator.wikimedia.org/T128805) (owner: 10Esanders) [21:18:53] (03CR) 10Alex Monk: "Florian: WFM" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [22:46:13] (03PS1) 10Jforrester: build: Bump various devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275264 [22:47:23] (03PS3) 10Esanders: Wikitext paste: Move MWWikitextStringTransferHandler matchRegExp into a registry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275193 (https://phabricator.wikimedia.org/T128805) [22:54:17] (03CR) 10Florianschmidtwelzow: "@Alex: Hmm, after restarting the VM (where my MW instance runs), it seems to work for me, too. Maybe cache related or something weird in m" (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [23:05:45] (03CR) 10Alex Monk: Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [23:24:00] (03CR) 10Esanders: [NEVERMERGE] Changes to link suggestion dialog from Ashwin (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274154 (owner: 10Esanders) [23:26:08] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#641557 (10Tgr) +1 to //that "better" method is live, a... [23:29:22] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#2091839 (10Tgr) Maybe whenever someone changes the lin... [23:33:26] 10VisualEditor: VisuaEditor popup for single tab is too small - https://phabricator.wikimedia.org/T128909#2089900 (10Esanders) May also happen with the welcome dialog: {F3531092} [23:33:37] 10VisualEditor: VisuaEditor popup for single tab is too small - https://phabricator.wikimedia.org/T128909#2091859 (10Esanders) As these are buttons with centred text it wouldn't make sense to wrap the text, although if it isn't possible to shorten the messages perhaps we should reconsider which UI components to... [23:39:14] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#2091860 (10NicoV) @Whatamidoing-WMF In addition to the... [23:49:02] (03CR) 10Florianschmidtwelzow: Use widgets for wiki-page-name, wiki-user-name, wiki-template-name, boolean, URL and line template fields (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [23:50:50] 10VisualEditor: How to switch the visual editor off in the mediawiki.org wiki? - https://phabricator.wikimedia.org/T128984#2091866 (10Purodha) [23:51:19] 10VisualEditor: How to switch the visual editor off in the mediawiki.org wiki? - https://phabricator.wikimedia.org/T128984#2091878 (10Purodha) [23:51:51] 10VisualEditor: Fire wikipage.diff hook when showing a diff in VE - https://phabricator.wikimedia.org/T128843#2087923 (10Esanders) Are there any examples of consumers of this hook? [23:53:15] 10VisualEditor: Visual Editor alert message goes out of bounds - https://phabricator.wikimedia.org/T128729#2091881 (10Esanders) [23:53:18] 10VisualEditor: VisuaEditor popup for single tab is too small - https://phabricator.wikimedia.org/T128909#2091882 (10Esanders) [23:57:34] 10VisualEditor: How to switch the visual editor off in the mediawiki.org wiki? - https://phabricator.wikimedia.org/T128984#2091866 (10Peachey88) https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-editing Editing tabs dropdown