[00:06:49] (03CR) 10Divec: [C: 04-1] "To solve the issue with non-text node offsets I mentioned on patch set 4, I propose rebasing on top of I17ca52f23b1a1daedf9f1f79f6c028ba31" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/260057 (https://phabricator.wikimedia.org/T114376) (owner: 10DLynch) [01:43:46] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Templates, 10Parsoid, 15User-Josve05a: Template inside a link renders weirdly after the page gets VEdited - https://phabricator.wikimedia.org/T113717#1946745 (10Josve05a) [01:44:14] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1946747 (10Josve05a) [01:44:35] 10Citoid: Date extraction fails on Jessie && Node 4.2 - https://phabricator.wikimedia.org/T124084#1946749 (10mobrovac) So, my local version (Trusty, Node 4.2) fails to get the data from Zotero and resorts to the native scraper, as seen in this trace: ``` [2016-01-20T01:37:34.082Z] TRACE: citoid/7943 on wiki-ist... [01:53:16] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1946770 (10Mvolz) a:5Nirzar>3None [02:27:38] 10VisualEditor, 10OOjs-UI, 10UI-Standardization, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Duplicate icons: 'Translation' and 'TextLanguage' - https://phabricator.wikimedia.org/T111040#1946809 (10violetto) @pginer-wmf your desc [[ https://phabricator.wikimedia.org/T111040#1938194 | here ]] is accurate. It's... [02:52:46] 10Citoid: Date extraction fails on Jessie && Node 4.2 - https://phabricator.wikimedia.org/T124084#1946850 (10mobrovac) Ok, nevermind. It was the fault of Zotero, naturally :( [02:53:12] 10Citoid: Date extraction fails on Jessie && Node 4.2 - https://phabricator.wikimedia.org/T124084#1946851 (10mobrovac) 5Open>3Resolved a:3mobrovac [02:53:14] 10Citoid, 6Services: Switch Citoid to Node 4.2 and Jessie - https://phabricator.wikimedia.org/T107304#1946853 (10mobrovac) [02:57:38] 10Citoid, 6Services: Switch Citoid to Node 4.2 and Jessie - https://phabricator.wikimedia.org/T107304#1946856 (10mobrovac) Ok, Citoid tested in Labs, works on Node 4.2 and Jessie. [03:05:55] 10Citoid, 10MediaWiki-Page-editing: Implementation of form driven bibliographic reference editing for wiki articles. - https://phabricator.wikimedia.org/T8535#1946866 (10Mvolz) [03:05:57] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1946864 (10Mvolz) 5Open>3Resolved a:3kaldari [03:06:09] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1157891 (10Mvolz) [03:06:12] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic, 5Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#1946868 (10Mvolz) [03:06:51] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T94223#1157891 (10Mvolz) @kaldari added support to reftoolbar as a temporary measure until wikieditor has surface [03:10:33] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1946870 (10Mvolz) [03:11:35] (03PS1) 10Mvolz: [WIP] Allow users to select cite template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265200 (https://phabricator.wikimedia.org/T97936) [03:13:32] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1946874 (10Mvolz) @Josve05a I guess this means I can do whatever I want! See screenshot! Muahaha, horrib... [03:30:47] (03CR) 10Alex Monk: "You asked me to review this but it doesn't work yet... Do you want me to try to make it actually work?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259017 (owner: 10Jforrester) [03:42:42] 10VisualEditor, 10VisualEditor-MediaWiki: Indicate the default for magic words like FORCETOC, INDEX, and NEWSECTIONLINK - https://phabricator.wikimedia.org/T122440#1946927 (10Krenair) Don't think we have one for FORCETOC? [03:45:47] TIL $wgArticleRobotPolicies :| [03:52:28] 10VisualEditor, 10VisualEditor-MediaWiki: Indicate the default for magic words like FORCETOC, INDEX, and NEWSECTIONLINK - https://phabricator.wikimedia.org/T122440#1946959 (10Krenair) Trying to guess defaults could get messy. E.g. Article::getRobotPolicy sets nofollow/noindex on user root pages who've been blo... [03:54:03] 10Citoid: Two Citoid tests failing - https://phabricator.wikimedia.org/T124079#1946960 (10mobrovac) 5Open>3Resolved a:3mobrovac After they have been failing for me for 2 weeks, they've started passing now. Damn you, Zotero! [03:59:10] 10VisualEditor, 10VisualEditor-MediaWiki: Indicate the default for magic words like FORCETOC, INDEX, and NEWSECTIONLINK - https://phabricator.wikimedia.org/T122440#1946973 (10Krenair) NEWSECTIONLINK might be okay... SkinTemplate (okay, so this can be overridden by the skin) does this: ```$showNewSection = !$ou... [04:20:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Padding of caption box (SurfaceWidget) in the Media Settings dialog is wrong - https://phabricator.wikimedia.org/T123126#1946990 (10Krenair) This is what I see locally and on en.wikipedia.org: {F3244754} [04:41:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Listings: Wikivoyage "Add listing" isn't present after saving a page in VisualEditor - https://phabricator.wikimedia.org/T122454#1947001 (10Krenair) I don't see [add listing] when I add this extension to my wiki? [04:43:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Listings: Wikivoyage "Add listing" isn't present after saving a page in VisualEditor - https://phabricator.wikimedia.org/T122454#1947012 (10Krenair) Oh: ```enwikivoyage MediaWiki:Gadget-ListingEditor.css enwikivoyage MediaWiki:Gad... [04:44:18] 10VisualEditor, 10VisualEditor-MediaWiki: "Add listing" section link added by ListingEditor gadget present on some Wikivoyage isn't present after saving a page in VisualEditor - https://phabricator.wikimedia.org/T122454#1947013 (10Krenair) [05:04:14] 10VisualEditor, 10VisualEditor-MediaWiki: "Add listing" section link added by ListingEditor gadget present on some Wikivoyage isn't present after saving a page in VisualEditor - https://phabricator.wikimedia.org/T122454#1947022 (10Krenair) a:3Krenair Fixed on enwikivoyage with this edit: https://en.wikivoyag... [06:28:51] 10Cite, 5Patch-For-Review, 5WMF-deploy-2016-01-26_(1.27.0-wmf.12): Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1947063 (10tstarling) >>! In T7984#1939973, @MGChecker wrote: > Does the Patch also work if a ref isn't defined (with name=) in the section you... [07:42:51] 10Cite, 7Easy: Ignore
in when adding
- https://phabricator.wikimedia.org/T124144#1947128 (10Danny_B) 3NEW [07:46:01] 10Cite, 5Patch-For-Review, 7user-notice: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#1947139 (10Danny_B) {T123896} relevant. [08:04:17] 10VisualEditor, 6Editing-Department: Obviate the need for wikis' wrapper and functionality-replacement templates - https://phabricator.wikimedia.org/T95543#1947176 (10Danny_B) [08:36:28] anyone around? [08:39:38] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1947242 (10Josve05a) The screenshot is....ok. But I'd like to see it as an epic for VE to also be allowe... [10:27:04] (03PS8) 10Florianschmidtwelzow: MediaSizeWidget: Allow an user to really use a custom size [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243979 [10:27:19] (03PS3) 10Florianschmidtwelzow: [PULLTHROUGH] Follow up change for change in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/261198 [11:03:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Display all the required and suggested parameters for a template, rather than just some of them - https://phabricator.wikimedia.org/T122578#1947434 (10Elitre) 5stalled>3Invalid a:3Elitre When I filed this task (and even befor... [11:04:45] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1947440 (10Mvolz) Sorry, that was me being punchy after staying up too late :). I'll work on it more. F... [11:09:11] 10VisualEditor: Activate VisualEditor for a single page - https://phabricator.wikimedia.org/T123231#1947445 (10JEumerus) [11:09:39] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 5Patch-For-Review, 15User-Josve05a: Allow user to switch cite template in limited circumstances - https://phabricator.wikimedia.org/T97936#1947448 (10Josve05a) Howabout if you know that the fields populated are the same in both templates, and... [13:10:25] (03CR) 10Nikerabbit: "I have not seen this message reuse pattern used before. It might work (I did not try), but I don't quite understand why it is being done t" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/258783 (https://phabricator.wikimedia.org/T26191) (owner: 10Paladox) [13:28:45] 10VisualEditor, 10VisualEditor-MediaWiki: "Add listing" section link added by ListingEditor gadget present on some Wikivoyage isn't present after saving a page in VisualEditor - https://phabricator.wikimedia.org/T122454#1947729 (10Wrh2) ListingEditor2 is just the beta listing editor gadget (not enabled by defa... [13:35:13] 10Cite, 5Patch-For-Review: Error generation of unbalanced : No error is shown if missing -tag is the last ref tag - https://phabricator.wikimedia.org/T17712#1947748 (10matmarex) https://gerrit.wikimedia.org/r/#/c/255258/ "Preprocessor: Don't allow unclosed extension tags (matching until... [14:53:29] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1948003 (10TheDJ) [15:00:03] I've done a attempt at getting VE working in mw 1.25.5, checking out REL1_25 and running the init command. Running curl -L http://localhost:8142/w125/v3/page/html/Main_Page works fine and the settings in localsettings.php are 'url' => 'http://localhost:8124', 'domain' => 'w125' [15:00:53] I'm now getting the error "Error loading data from server: 0: parsoidserver-http: HTTP 0. Would you like to retry?", but the parsoid logs doesn't show it trying to connect.. [15:01:31] tried running nc at 8000, just to check if mw was trying to access the dev-version, but no luck [15:02:47] found this on the extension talk page, but disabeling caching doesn't seem to make much of a differencehttps://www.mediawiki.org/wiki/Topic:Slfskc3j2n1c22p3 [15:03:31] also enabled debugging in mw, hoping it would give clues to what/where it's trying to connect, but alas :/ [15:03:40] help? [15:04:12] (03CR) 10Esanders: "Apex should be fixed upstream." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/264962 (owner: 10Esanders) [15:07:37] (03CR) 10Jforrester: "Shouldn't MediaWIki theme be fixed upstream instead? Apex is using browser native controls…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/264962 (owner: 10Esanders) [15:17:51] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Type-ahead search for templates (etc.?) isn't great for sub-page templates (e.g. userboxen), as you have to enter the "User:Foo/" prefix - https://phabricator.wikimedia.org/T122740#1948054 (10Sunpriat) [15:34:26] 10Cite, 5WMF-deploy-2016-01-26_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1948104 (10matmarex) 5Open>3Resolved [15:46:32] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1948146 (10Nemo_bis) How to share the blacklist (or whatever cleanup method VisualEditor is currently using) with other c... [16:21:03] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1948228 (10Jdforrester-WMF) >>! In T54327#1948146, @Nemo_bis wrote: > How to share the blacklist (or whatever cleanup met... [16:21:14] (03CR) 10DLynch: [C: 032] Refactor unicorn handling in ve.ce.Document#getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265161 (owner: 10Divec) [16:25:10] (03Merged) 10jenkins-bot: Refactor unicorn handling in ve.ce.Document#getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265161 (owner: 10Divec) [17:07:01] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1948468 (10Trizek-WMF) @matmarex Keep going! :) There is still that need for some languages. What do you need to move forward? [17:08:26] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1948475 (10matmarex) I need the VE team to accept the design I proposed ("  is now displayed with a light grey background and has a toolti... [17:22:00] 10VisualEditor, 10VisualEditor-ContentEditable, 5Patch-For-Review: Make non-breaking spaces (nbsp) visible in VisualEditor - https://phabricator.wikimedia.org/T96666#1948515 (10Trizek-WMF) I'll see what I can do :) [17:37:59] 10VisualEditor, 10VisualEditor-MediaWiki: "Add listing" section link added by ListingEditor gadget present on some Wikivoyage isn't present after saving a page in VisualEditor - https://phabricator.wikimedia.org/T122454#1948596 (10Krenair) 5Open>3Resolved * https://it.wikivoyage.org/w/index.php?title=Media... [17:52:58] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData: Add property to indicate a template must be substituted - https://phabricator.wikimedia.org/T67550#1948636 (10Krenair) @Jdforrester-WMF: Are you okay with this being a "must"? I'm wondering if perhaps we want to go with "should" instead. [18:16:59] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 10 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1948761 (10Aklapper) Wikimedia Developer Summit 2016 ended two weeks ago. This task is still open. **If the sessio... [18:32:38] (03CR) 10Krinkle: [C: 04-1] [WIP] Add a parameter key to limit possible valid values to a given set (034 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) (owner: 10Alex Monk) [18:32:45] (03CR) 10Esanders: "Both themes use custom padding - but they were out of sync. Fixed in I6337ef3d." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/264962 (owner: 10Esanders) [18:33:12] (03CR) 10Jforrester: [C: 032] SaveDialog: Fix alignment of checkboxes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/264962 (owner: 10Esanders) [18:36:27] 10VisualEditor, 10VisualEditor-Performance, 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, and 9 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784#1948896 (10GWicke) [18:44:33] anyone awake? [19:29:05] 10Cite, 5WMF-deploy-2016-01-26_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1949144 (10MGChecker) I don't think this bug is resolved completely. Yes, the basic functionality works well and as expected (thank you really muich... [19:57:16] 10Cite: Nested references rendered in wrong order in reflist - https://phabricator.wikimedia.org/T124213#1949286 (10matmarex) 3NEW [19:58:49] 10Cite: Nested references rendered in wrong order in reflist - https://phabricator.wikimedia.org/T124213#1949299 (10matmarex) [19:59:32] 10Cite: Nested references rendered in wrong order in reflist - https://phabricator.wikimedia.org/T124213#1949286 (10matmarex) (Parsoid produces the correct output.) [20:12:12] 10Cite: False duplicate errors ("defined multiple times with different content") when using {{#tag:ref}} with XML-style tags inside - https://phabricator.wikimedia.org/T118603#1949362 (10matmarex) >>! In T118603#1917274, @matmarex wrote: > @bawolff suggested that we could call unstripBoth() to replace the strip... [20:25:08] 10Cite: False duplicate errors ("defined multiple times with different content") when using {{#tag:ref}} with XML-style tags inside - https://phabricator.wikimedia.org/T118603#1949432 (10matmarex) a:5matmarex>3None I think this is impossible to fix without a serious time expenditure, and I do not have any mo... [20:42:01] 10Cite, 5WMF-deploy-2016-01-26_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1949531 (10TheDJ) @MGChecker no not a simple possibility. You cannot know what is inside 'the rest of the page', without parsing the whole page. And... [20:43:17] 10TemplateData: When importing new TemplateData parameters, there's no reason to warn about the old parameters - https://phabricator.wikimedia.org/T124223#1949544 (10maiden_taiwan) 3NEW [20:52:09] 10Cite: No duplicate ref error when duplicate refs are defined inside {{#tag:references}} - https://phabricator.wikimedia.org/T124227#1949587 (10matmarex) 3NEW [20:52:24] 10Cite, 5Patch-For-Review: Duplicate refs inside don't cause a citation error - https://phabricator.wikimedia.org/T116377#1747891 (10matmarex) (Actually, that's weird enough for a separate task, see T124227.) [21:00:42] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: The forecast for Better Link Editing and for Formula Editing is wrong - https://phabricator.wikimedia.org/T123550#1949644 (10JAufrecht) Researching ... 1) Design error in forecasting. It was using the "points" and "count" columns to mean both resolved and ope... [21:03:33] 10VisualEditor, 10Phlogiston, 15User-JAufrecht: The forecasts for Better Link Editing and for Formula Editing are wrong - https://phabricator.wikimedia.org/T123550#1949669 (10JAufrecht) [21:08:09] 10TemplateData: When importing new TemplateData parameters, there's no reason to warn about the old parameters - https://phabricator.wikimedia.org/T124223#1949691 (10maiden_taiwan) I thought about setting the associated system message, `templatedata-modal-errormsg-import-paramsalreadyexist`, to the empty string.... [21:14:14] 10Cite, 5WMF-deploy-2016-01-26_(1.27.0-wmf.12), 7user-notice: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1949709 (10MGChecker) I'm not a coder, but I think it could work if MediaWiki tries to find the necessary definitions in the saved page (with some b... [21:30:45] 10Cite, 5Patch-For-Review: No duplicate ref error when duplicate refs are defined inside {{#tag:references}} - https://phabricator.wikimedia.org/T124227#1949766 (10matmarex) p:5Triage>3Normal a:3matmarex [22:02:47] (03CR) 10Krinkle: SET: Set user's editor to wikitext if the browser doesn't do JS (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/259771 (https://phabricator.wikimedia.org/T121257) (owner: 10Alex Monk) [22:34:23] (03PS1) 10Alex Monk: Don't show warning about already-known parameters that weren't imported [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265410 (https://phabricator.wikimedia.org/T124223) [22:34:25] (03PS1) 10Alex Monk: Fix mw.TemplateData.SourceHandler.prototype.extractParametersFromTemplateCode return doc [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/265411 [23:11:10] (03PS13) 10Alex Monk: [WIP] Add a parameter key to limit possible valid values to a given set [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) [23:28:38] (03PS1) 10Esanders: Show deactivated selection when cursor is collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/265423