[00:02:32] [13grunt-banana-checker] 15Krinkle pushed 1 new commit to 06translationchecking: 02https://github.com/wikimedia/grunt-banana-checker/commit/a757c90a16c89061ce424233fd5f444951d18a69 [00:02:32] 13grunt-banana-checker/06translationchecking 14a757c90 15Timo Tijhof: fixup: Coding style nitpicks... [00:04:24] (03CR) 10Krinkle: [C: 031] Remove compatibility aliases for old ve init modules [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229442 (owner: 10Jforrester) [00:06:22] wikimedia/grunt-banana-checker#91 (translationchecking - a757c90 : Timo Tijhof): The build passed. [00:06:22] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/b50ab1e01ef4...a757c90a16c8 [00:06:22] Build details : https://travis-ci.org/wikimedia/grunt-banana-checker/builds/78323324 [00:13:59] [13grunt-banana-checker] 15jdforrester pushed 1 new commit to 06translationchecking: 02https://github.com/wikimedia/grunt-banana-checker/commit/31befa2f32d202c8e127173ec741ecca6d991517 [00:13:59] 13grunt-banana-checker/06translationchecking 1431befa2 15James D. Forrester: Fix up result of bad rebase [00:15:04] wikimedia/grunt-banana-checker#93 (translationchecking - 31befa2 : James D. Forrester): The build passed. [00:15:04] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/a757c90a16c8...31befa2f32d2 [00:15:04] Build details : https://travis-ci.org/wikimedia/grunt-banana-checker/builds/78324326 [00:15:10] [13grunt-banana-checker] 15jdforrester pushed 1 new commit to 06translationchecking: 02https://github.com/wikimedia/grunt-banana-checker/commit/ed6e3fe060b22e27c2c008b378d879d630e6517b [00:15:10] 13grunt-banana-checker/06translationchecking 14ed6e3fe 15James D. Forrester: Instead of return;, throw in error conditions [00:16:19] wikimedia/grunt-banana-checker#94 (translationchecking - ed6e3fe : James D. Forrester): The build passed. [00:16:19] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/31befa2f32d2...ed6e3fe060b2 [00:16:19] Build details : https://travis-ci.org/wikimedia/grunt-banana-checker/builds/78324408 [00:45:17] (03PS1) 10Alex Monk: Make ve.ui.Sequence#execute return false if the command is missing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235387 (https://phabricator.wikimedia.org/T106060) [00:49:38] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 7Technical-Debt: ve.ui.Sequence#execute should silently ignore missing commands - https://phabricator.wikimedia.org/T106060#1595545 (10Krenair) a:3Krenair [00:55:51] [13grunt-banana-checker] 15jdforrester closed pull request #27: Be able to require complete translations, or specific messages in all translations (06master...06translationchecking) 02https://github.com/wikimedia/grunt-banana-checker/pull/27 [00:56:28] [13grunt-banana-checker] 15Krinkle 04deleted 06translationchecking at 14ed6e3fe: 02https://github.com/wikimedia/grunt-banana-checker/commit/ed6e3fe [00:57:00] James_F, no bouncer accounts for github/travis-ci yet? :) [00:57:05] wikimedia/grunt-banana-checker#96 (master - 946d916 : James D. Forrester): The build passed. [00:57:05] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/21619cc0bea6...946d916f1dfa [00:57:05] Build details : https://travis-ci.org/wikimedia/grunt-banana-checker/builds/78327871 [00:57:18] Krenair: Is that a thing? [00:57:43] yeah can do that to make such bots appear to idle on your channel instead of continually joining/quitting, yeah [00:57:53] Might be cleaner. [00:57:57] Right. Send msg to channel without joining [00:57:59] in the hooks settings [00:58:06] but require channel config, which can also let in spam [00:58:18] yeah, this is +n [00:58:21] (which is hard to block iirc) [00:58:34] Krenair: And it's set? [00:58:36] Which do you mean? [00:58:44] Allowing /notices is an anti-pattern. [00:58:47] what happens if you tell it to send without joining, but the channel doesn't allow it? [00:58:51] But you said 'bouncer'. [00:58:52] James_F: It requires ChanServ re-config to allow sending messages to this channel from users not in it. [00:58:54] Which is different. [00:59:00] and then github reconfig to have it use that [00:59:05] ChanServ re-config? Can't you just set the mode normally? [00:59:07] Krenair: I don't think that's what Krenair is talking about? [00:59:16] Krenair: Can. Won't. Can. :-) [00:59:29] Krinkle is talking about another way to avoid them joining/quitting [00:59:35] Oh [00:59:40] IRC will let you send to a channel you're not on. [00:59:47] Assuming that channel doesn't have the +n flag. [00:59:55] Right [00:59:57] FreeNode gives +nt by default and we have it on this channel [01:00:10] Yeah, with /ca you can disable that [01:00:13] restriction [01:00:23] yes. you can also do it without /ca [01:00:24] Krenair: You're saying we can configure github to send to a bouncer instead of freenode [01:00:28] so it stays permanently [01:00:30] That's another possibility [01:00:44] to achieve the same thing, without having to -n [01:00:59] Or we can just ignore it and let them continue joining/quitting [01:01:04] Yeah [01:02:12] [13grunt-banana-checker] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/wikimedia/grunt-banana-checker/commit/7bad46bf644b8f8606f610cdb89d07d5a12c6278 [01:02:12] 13grunt-banana-checker/06master 147bad46b 15Timo Tijhof: build: Use more compact Travis CI message template... [01:02:58] [13grunt-banana-checker] 15jdforrester created 06translationchecking (+7 new commits): 02https://github.com/wikimedia/grunt-banana-checker/compare/b50ab1e01ef4^...b093e350fb90 [01:02:58] 13grunt-banana-checker/06translationchecking 14b50ab1e 15James D. Forrester: Be able to require complete translations, or specific messages in all translations [01:02:58] 13grunt-banana-checker/06translationchecking 14a757c90 15Timo Tijhof: fixup: Coding style nitpicks... [01:02:58] 13grunt-banana-checker/06translationchecking 1431befa2 15James D. Forrester: Fix up result of bad rebase [01:03:13] Umm. [01:03:19] Oh, you deleted the branch [01:03:20] Bah. [01:03:45] Standard practice for a PR [01:03:54] Yes, but I was writing code based off it. [01:04:01] 10VisualEditor, 10VisualEditor-EditingTools, 10Math: Cancel button does not work in editing tool for mathematical formulae - https://phabricator.wikimedia.org/T110992#1595562 (10Krenair) Looks like we have the same issue with SyntaxHighlight [01:04:05] and pushing back to the same name? [01:04:12] Seemingly. [01:04:14] * James_F fixes. [01:04:38] 10VisualEditor, 10VisualEditor-EditingTools, 10Math: Cancel button does not work in editing tool for mathematical formulae - https://phabricator.wikimedia.org/T110992#1595566 (10Krenair) And I'm guessing maybe wikihiero as well? [01:04:56] [13grunt-banana-checker] 15jdforrester created 06release-0.3.0 (+3 new commits): 02https://github.com/wikimedia/grunt-banana-checker/compare/6aebf5a3fa6c^...101eaf95cc68 [01:04:56] 13grunt-banana-checker/06release-0.3.0 146aebf5a 15James D. Forrester: build: Bump grunt-jscs to latest version [01:04:56] 13grunt-banana-checker/06release-0.3.0 14e4f495a 15James D. Forrester: Enforce disallowBlankTranslations, disallowDuplicateTranslations and disallowUnusedTranslations [01:04:56] 13grunt-banana-checker/06release-0.3.0 14101eaf9 15James D. Forrester: Tag v0.3.0 [01:05:24] [13grunt-banana-checker] 15jdforrester opened pull request #28: Release 0.3.0 (06master...06release-0.3.0) 02https://github.com/wikimedia/grunt-banana-checker/pull/28 [01:05:36] easiest way to remove branch is from https://github.com/wikimedia/grunt-banana-checker/branches - and for your own view, git remote prune origin (git remote update doesn't remove old branches by default) [01:05:41] [13grunt-banana-checker] 15jdforrester 04deleted 06translationchecking at 14b093e35: 02https://github.com/wikimedia/grunt-banana-checker/commit/b093e35 [01:05:43] wikimedia/grunt-banana-checker#98 (translationchecking - b093e35 : James D. Forrester): The build passed. [01:05:44] Change view : https://github.com/wikimedia/grunt-banana-checker/compare/b50ab1e01ef4^...b093e350fb90 [01:05:44] Build details : https://travis-ci.org/wikimedia/grunt-banana-checker/builds/78328444 [01:05:44] :) [01:05:52] Yes, I know. [01:06:26] Krinkle: The new ssh prompt with a key character instead of a '*' confuses me still. :-) [01:06:41] key character? [01:08:01] Maybe it's 26BF [01:08:37] btw, this is the part of German almost nobody learns properly, including Germans [01:08:38] https://en.wiktionary.org/wiki/zweite#Declension [01:08:48] Oh, did I get it wrong? [01:09:02] I should have asked you or Roan. :_) [01:09:28] 10VisualEditor, 10VisualEditor-EditingTools, 10Math: Cancel button does not work in editing tool for mathematical formulae - https://phabricator.wikimedia.org/T110992#1595568 (10Krenair) And galleries... [01:09:36] Maybe this needs to be made into a more generic bug at this point [01:09:56] Krenair: It's probably a bug in FragmentInspector? [01:10:35] I can't really tell to be honest. It takes like 5 minutes to decode [01:11:08] Krinkle: Ha. [01:11:19] RoanKattouw: https://github.com/wikimedia/grunt-banana-checker/commit/e4f495a7dc78ba1df135ad26ae60c538b96f003e [01:11:44] James_F: I'm not exactly sure where to place the blame. [01:12:12] James_F: This is nominative, right? [01:13:12] Yeah [01:13:20] and masculine [01:13:21] So it would be erste Nachricht, zweite Nachricht, etc [01:13:28] so zweite or zweiter [01:13:30] Maybe MWExtensionInspector [01:13:40] hm [01:13:46] Oh right, it's Nachrichtswert or whatever, right? [01:13:53] So the gender comes from Wert, not Nachricht [01:14:02] Indeed [01:14:06] I mean, Nachrichtwert is also a silly word [01:14:13] It's not a word I'd say [01:14:13] That's not an acceptable translation for "message value" [01:14:28] I think it's MWExtensionInspector#getTeardownProcess call to insertOrUpdateNode [01:15:01] Ahyeah, Nachrich is feline [01:15:22] feline? xD [01:15:25] eh. [01:15:38] femenine [01:15:38] Yeah die Nachricht [01:15:44] But what is Wert? Der Wert? [01:15:47] feminine [01:15:49] Das? [01:15:51] Oh! [01:15:53] OK [01:15:53] Das [01:15:55] Der [01:15:57] Yep [01:16:05] Wait, das or der? [01:16:14] Depends on context. [01:16:25] Of course it f-ing does [01:16:35] Even "Die Man" can be correct. [01:16:44] Eventhough it's masculine which means der in the typical case. [01:17:27] Oh OK yes that's what I meant [01:17:36] So it'd have to be erster, zweiter, etc [01:17:38] Hm.. okay not that one. But the reverse is true. Feminine words can be 'der' if genetiv. [01:17:45] Yes [01:17:50] Also dative [01:17:51] Zweiter Wert. [01:17:58] yeah [01:18:11] Zweite Nachricht. [01:18:25] But I'm not sure Nachricht makes sense, either. [01:18:28] It's not a news message [01:18:31] broadcast [01:18:33] Exactly [01:18:39] But what is the word we want here? [01:18:48] My German vocab isn't good enough to translate "i18n message" [01:18:53] ascsa works for me [01:18:57] :P [01:19:39] https://translatewiki.net/wiki/MediaWiki:Allmessages/de [01:19:43] Systemnachrichten [01:19:45] Hm.. [01:20:03] hah OK [01:21:57] * Krinkle wants feline words [01:22:22] (where feline is an adjective, there's plenty of words for feline) [01:25:36] Or... maybe it wasn't MWExtensionInspector [01:29:27] Oh, it sort of it. [01:29:31] sort of is* [01:33:39] (03PS1) 10Alex Monk: Fix cancelling of extension inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235389 (https://phabricator.wikimedia.org/T110992) [01:33:53] 10VisualEditor, 10VisualEditor-EditingTools, 10Math, 5Patch-For-Review: Cancel button does not work in editing tool for mathematical formulae - https://phabricator.wikimedia.org/T110992#1595591 (10Krenair) a:3Krenair [01:34:25] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: Cancel button does not work in inspectors for extensions - https://phabricator.wikimedia.org/T110992#1595592 (10Krenair) [01:35:44] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/235387/ [01:35:48] RoanKattouw: Hello. [01:36:10] (03CR) 10Catrope: [C: 031] Make ve.ui.Sequence#execute return false if the command is missing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235387 (https://phabricator.wikimedia.org/T106060) (owner: 10Alex Monk) [01:54:29] 10VisualEditor: [Regression wmf20] Media search is not returning any result unless there is a change in the search term by typing or deleting something inside the search box - https://phabricator.wikimedia.org/T110570#1595603 (10Krenair) Cannot reproduce issue on localhost or beta [06:37:16] 10VisualEditor: VE creates duplicated (and unnecessary) font tags - https://phabricator.wikimedia.org/T111151#1595922 (10Magioladitis) 3NEW [06:38:53] 10VisualEditor: VE adds ul/il tags - https://phabricator.wikimedia.org/T111152#1595931 (10Magioladitis) 3NEW [06:39:59] 10VisualEditor: VE adds broken section tasks - https://phabricator.wikimedia.org/T111153#1595938 (10Magioladitis) 3NEW [07:39:54] 10VisualEditor: Odd ref names being added by VisualEditor - https://phabricator.wikimedia.org/T94712#1596014 (10NicoV) I haven't seen an other example recently, but I'm not monitoring VE edits, so I don't know [08:51:56] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1596155 (10Amire80) [08:52:20] 10VisualEditor, 6Editing-Department, 10MediaWiki-extensions-ContentTranslation, 7Design, 7Epic: [Epic] replace plain contenteditable with VisualEditor in ContentTranslation - https://phabricator.wikimedia.org/T105447#1444044 (10Amire80) [11:01:42] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Design: Make it easier to type '{{' when you don't want to insert a template - https://phabricator.wikimedia.org/T110800#1596406 (10Pginer-WMF) One option to explore could be to bring the autocompletion template selection in-place. That can help to keep... [11:48:14] (03CR) 10Esanders: [C: 032] Fix cancelling of extension inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235389 (https://phabricator.wikimedia.org/T110992) (owner: 10Alex Monk) [11:50:21] (03Merged) 10jenkins-bot: Fix cancelling of extension inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235389 (https://phabricator.wikimedia.org/T110992) (owner: 10Alex Monk) [12:01:04] 10Citoid: Enable Citoid in ru.wiki - https://phabricator.wikimedia.org/T95994#1596539 (10Sunpriat) Thanks, it works [12:01:27] 10Citoid: Enable Citoid in ru.wiki - https://phabricator.wikimedia.org/T95994#1596540 (10Sunpriat) 5Open>3Resolved [12:22:44] hi again, some online for a question about templates? [12:41:01] 10VisualEditor, 10MediaWiki-General-or-Unknown, 6WMF-Design-Research: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#1596683 (10Elitre) Kudos to both of you! [13:05:34] how to make a button for customize first section of the special character inserter for the double quotation marks that are inserted on either side of the text you selected? [13:06:55] https://ru.wikipedia.org/w/index.php?title=MediaWiki:Visualeditor-quick-access-characters.json&diff=73101007&oldid=70543151 this does not work [13:08:48] hi sunpriat [13:09:19] sunpriat: look at https://pl.wikipedia.org/wiki/MediaWiki:Visualeditor-quick-access-characters.json for an example. the syntax is somewhat messy, but this works [13:10:26] It seems this is what I need, thank you! [13:12:58] hi, someone who can help me out? I cant use the virtual editor in templates.... [13:18:30] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 4 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1596759 (10Anomie) [13:21:55] (03CR) 10Cscott: "Ok, people, Flow migrated. It's just VE which is holding up the boat now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/217995 (https://phabricator.wikimedia.org/T110780) (owner: 10Cscott) [14:10:07] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Cancel button does not work in inspectors for extensions - https://phabricator.wikimedia.org/T110992#1596865 (10Krenair) 5Open>3Resolved [14:36:18] (03CR) 10Esanders: [C: 032] Make ve.ui.Sequence#execute return false if the command is missing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235387 (https://phabricator.wikimedia.org/T106060) (owner: 10Alex Monk) [14:39:36] (03Merged) 10jenkins-bot: Make ve.ui.Sequence#execute return false if the command is missing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235387 (https://phabricator.wikimedia.org/T106060) (owner: 10Alex Monk) [14:43:52] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#1596993 (10Sunpriat) + I see it on Meta.wikimedia.org https://meta.wikimedia.org/wiki/VisualEditor/Newsl... [14:45:45] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 7Technical-Debt: ve.ui.Sequence#execute should silently ignore missing commands - https://phabricator.wikimedia.org/T106060#1597005 (10Krenair) 5Open>3Resolved [14:57:32] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#1597092 (10Krenair) >>! In T95822#1596993, @Sunpriat wrote: > + I see it on Meta.wikimedia.org https://m... [15:05:40] Krenair: while you're there. can you help me unbreak VE on my local wiki? [15:06:03] one moment, trying to deploy things to production here [15:06:08] Krenair: since the recent restbase-related changes it's unable to contact parsoid [15:06:13] heh, alright [15:08:24] hi, someone who can help me out? I cant use the virtual editor in templates.... [15:09:14] Hi, I also have a problem. I am getting 404 errors to a Parsoid server that exists. All the settings and LocalSettings are correct - can anyone help at all? [15:26:03] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 7Design: Make it easier to type '{{' when you don't want to insert a template - https://phabricator.wikimedia.org/T110800#1597271 (10Jdforrester-WMF) '`{{`' is not a major feature. It's a very minor accessibility hack for old-hand Wikimedians who forget... [15:31:55] 10VisualEditor, 10VisualEditor-MediaWiki-References: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1597302 (10Elitre) No progress on this? `` is not just ugly, it looks like an error code or something. [15:32:28] 10VisualEditor, 10VisualEditor-MediaWiki-References: Come up with a better way to auto-label references - https://phabricator.wikimedia.org/T92432#1597308 (10Jdforrester-WMF) >>! In T92432#1597302, @Elitre wrote: > No progress on this? `` is not just ugly, it looks like an error code or somethin... [15:54:55] Krenair: when you're free, please take a look at my VE woes. it worked until a week ago or so. here's my config: http://pastebin.com/HSzPNxtK http://pastebin.com/md5VJ43e . trying to edit any page results in "Error loading data from server: 404: parsoidserver-http: HTTP 404. Would you like to retry?". it runs in a VM, i can give you HTTP or SSH access if you need it. [15:59:33] MatmaRex: see https://www.mediawiki.org/wiki/User_talk:Trevor_Parscal_(WMF)#OOjs_UI_documentation [16:02:16] TrevorParscal: has that ever worked? https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.LabelWidget works correctly for me, https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/OO.ui.LabelWidget doesn't and never had [16:02:35] TrevorParscal: if anyone can fix it, it's Krinkle_ [16:05:14] MatmaRex, what port is parsoid listening on? [16:05:20] 10VisualEditor, 10VisualEditor-EditingTools, 7Technical-Debt, 5WMF-deploy-2015-09-08_(1.26wmf22): ve.ui.Sequence#execute should silently ignore missing commands - https://phabricator.wikimedia.org/T106060#1597699 (10Jdforrester-WMF) [16:05:43] Krenair: the default debian/ubuntu one, 8142 or something? [16:06:14] or i think so, at least. [16:06:57] MatmaRex: It definitely worked last month when I was showing S things [16:07:08] It also worked when Kirsten was around, but I had to fix it 2 or 3 times during her time here [16:07:30] RoanKattouw: the mediawiki doc one? not the oojs-ui one? [16:07:43] Oh, shit [16:07:44] right [16:07:45] RoanKattouw: the mediawiki doc has never been loading the necessary modules, in my experience. it only loads mediawiki.js [16:07:59] MatmaRex, try checking out f5c874cbaf2c1408342305fbc87dc6db36728e07^ in mediawiki core [16:08:05] MatmaRex: Ed's got a fix for it but it doesn't work. [16:08:11] https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.LabelWidget works [16:08:18] assuming you're not running that from a debian package too :P [16:10:32] Krenair: ha, that works. [16:11:30] * MatmaRex grumbles [16:11:47] so is f5c874cbaf2c1408342305fbc87dc6db36728e07 broken, or is it something with my config, or…? [16:12:37] f5c874cbaf2c1408342305fbc87dc6db36728e07 was not backwards compatible with older parsoid versions without v3 api support [16:13:07] the mediawiki and parsoid debian packages should be compatible with each other though [16:13:13] so you're saying that the debian package is hopelessly outdated? [16:13:34] (it's the package from wmf's repository or something) [16:15:14] I've responded on Trevor's talk page [16:15:19] And I'm also trying to fix the MW JS docs now [16:25:04] Krenair: should i file a parsoid bug about this or something? [16:25:29] since you guys basically threw everyone using the default recommended setup under the bus right now [16:25:43] MatmaRex, I'm not sure. I would ask cscott but as you probably know, he's a bit busy [16:26:08] meh. alright, filing it then [16:27:15] MatmaRex, default recommended setup includes mediawiki master? [16:27:43] Krenair: when you're running VE, yes… [16:28:18] ( https://gerrit.wikimedia.org/r/235496 ) [16:28:30] for example, iirc MW 1.25 and VE 1.25 are subtly incompatible, because we backported only half of some breaking change [16:32:39] https://phabricator.wikimedia.org/T111213 [16:59:34] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1598121 (10Elitre) Just checked, all is fine. [17:03:43] 10VisualEditor, 10VisualEditor-MediaWiki: Thoughts about VisualEditor interface when the user is blocked - https://phabricator.wikimedia.org/T111217#1598141 (10matmarex) 3NEW [17:08:57] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): [Regression wmf21] Cancel button does not work in inspectors for extensions - https://phabricator.wikimedia.org/T110992#1598198 (10Jdforrester-WMF) [17:09:07] (03PS1) 10Jforrester: Fix cancelling of extension inspectors [extensions/VisualEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235511 (https://phabricator.wikimedia.org/T110992) [17:19:58] James_F, do you want that out before 1.26wmf21 hits group 1 sites? [17:20:07] Krenair: I was thinking it should be. [17:21:02] (03CR) 10Alex Monk: [C: 032] Fix cancelling of extension inspectors [extensions/VisualEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235511 (https://phabricator.wikimedia.org/T110992) (owner: 10Jforrester) [17:21:12] I agree [17:21:17] Cool. [17:24:34] (03Merged) 10jenkins-bot: Fix cancelling of extension inspectors [extensions/VisualEditor] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235511 (https://phabricator.wikimedia.org/T110992) (owner: 10Jforrester) [17:26:55] * Krenair grumbles about gerrit [17:42:32] 10VisualEditor: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#1598400 (10JAufrecht) 3NEW a:3JAufrecht [18:15:33] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Autovalue is intermittently not working at en.wp's [[Template:Citation needed]] - https://phabricator.wikimedia.org/T111230#1598531 (10Whatamidoing-WMF) 3NEW [18:58:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1574002 (10Jdlrobson) mobileMode could be replaced by skin (it's on my todo list) and could have value 'minerva' or 'minerva-beta'. [18:59:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1598652 (10Jdforrester-WMF) >>! In T110272#1598647, @Jdlrobson wrote: > mobileMode could be replaced by skin (it's on my todo list) and could have value 'mine... [18:59:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1598655 (10Jdlrobson) isTestA was used for A/B testing. It might come in useful in future. I'm not sure how you plan to run A/B tests in future. Token was for... [19:00:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1598666 (10Jdforrester-WMF) >>! In T110272#1598655, @Jdlrobson wrote: > isTestA was used for A/B testing. It might come in useful in future. I'm not sure how... [19:15:18] Krenair: Ooh, are we getting close on https://gerrit.wikimedia.org/r/#/c/189178/ ? That'd be awesome. [19:27:20] James_F, umm. maybe. [19:27:36] MatmaRex: TrevorParscal: Those previews are broken because they're meant for oojs-ui, not mediawiki-core. The eg-iframe of jsduck in mediawiki is very different. [19:27:42] Krenair: Kk. [19:27:45] I don't remember whether I've tested it or not. [19:27:56] Krenair: Might be worth doing. ;-) [19:28:02] We wrongly include oojs and oojs-ui in meidawiki jsduck build so that we don't have to add anhything to jsduck.external.js [19:28:09] but that's a lazy approach we should probably stop. [19:28:30] Although simply loading oojs.js in mediawiki egiframe will fix it. [19:28:44] Which has a core patch. [19:29:19] Krinkle: https://gerrit.wikimedia.org/r/235496 [19:30:25] (There's also Ed's attempt at doing this for VE's one, which doesn't work yet.) [19:30:38] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Autovalue is intermittently not working at en.wp's [[Template:Citation needed]] - https://phabricator.wikimedia.org/T111230#1598782 (10GermanJoe) Thanks for adding this task. To clarify a bit: not only the "Autovalue" function is not working... [19:31:03] OOjs UI only requires OOjs. VE is more elaborate due to ve.init.platform still being a global async singleton, which is a design flaw we'll be stuck with for a while. [19:31:10] Yeah. [19:31:46] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Autovalue is intermittently not working at en.wp's [[Template:Citation needed]] - https://phabricator.wikimedia.org/T111230#1598786 (10Jdforrester-WMF) Hmm. Intermittent load issues are horrendous to track down (just see {T93800}). [19:32:16] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor is intermittently failing to load TemplateData for en.wp's [[Template:Citation needed]] (possibly others?) - https://phabricator.wikimedia.org/T111230#1598789 (10Jdforrester-WMF) p:5Triage>3High [19:32:22] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: TemplateData with AutoValue intermittently not available at en.wp's [[Template:Citation needed]] - https://phabricator.wikimedia.org/T111230#1598792 (10GermanJoe) p:5High>3Triage [19:32:43] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: TemplateData with AutoValue intermittently not available at en.wp's [[Template:Citation needed]] - https://phabricator.wikimedia.org/T111230#1598796 (10Jdforrester-WMF) Yay edit conflicts. [19:32:53] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor is intermittently failing to load TemplateData for en.wp's [[Template:Citation needed]] (possibly others?) - https://phabricator.wikimedia.org/T111230#1598802 (10Jdforrester-WMF) p:5Triage>3High [19:33:10] Also, yay edit-warring in Phabricator. [19:35:22] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor is intermittently failing to load TemplateData for en.wp's [[Template:Citation needed]] (possibly others?) - https://phabricator.wikimedia.org/T111230#1598813 (10matmarex) ({T78236}.) [19:35:34] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor is intermittently failing to load TemplateData for en.wp's [[Template:Citation needed]] (possibly others?) - https://phabricator.wikimedia.org/T111230#1598815 (10GermanJoe) Sorry - didn't mean to mess up the task info. [19:35:50] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor is intermittently failing to load TemplateData for en.wp's [[Template:Citation needed]] (possibly others?) - https://phabricator.wikimedia.org/T111230#1598817 (10Jdforrester-WMF) >>! In T111230#1598815, @GermanJoe wrote: > Sorry... [19:41:50] 10VisualEditor: [Regression pre-wmf22] Clicking on any other option from the toolbar while the link inspector is open crashes VE - https://phabricator.wikimedia.org/T111241#1598854 (10Ryasmeen) 3NEW [19:42:27] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression pre-wmf22] Clicking on any other option from the toolbar while the link inspector is open crashes VE - https://phabricator.wikimedia.org/T111241#1598861 (10Jdforrester-WMF) p:5Triage>3High [19:43:52] Oh dear. [19:44:00] Krenair: Could you have a look at that? ^^^ [19:46:29] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression pre-wmf22] Clicking on any other option from the toolbar while the link inspector is open crashes VE - https://phabricator.wikimedia.org/T111241#1598997 (10Krenair) I get Uncaught TypeError: Cannot read property 'convert' of undefined [19:58:40] 10VisualEditor: VE focus issues in REL 1_25: Unable to use the Summary and Search box - https://phabricator.wikimedia.org/T106419#1599073 (10Quiddity) There's a new suggestion at https://www.mediawiki.org/w/index.php?title=Topic:Sikx3284w9gfhw6t&topic_showPostId=so4tyj3gdlz0be8q#flow-post-so4tyj3gdlz0be8q >A hac... [20:20:32] 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression pre-wmf22] Cancelling link inspector crashes VE - https://phabricator.wikimedia.org/T111241#1599175 (10Krenair) [20:30:32] James_F, I think other things are broken too [20:31:19] (03PS1) 10Alex Monk: Don't break when you cancel the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235613 (https://phabricator.wikimedia.org/T111241) [20:32:00] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 4 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1599220 (10ksmith) I spoke with @anomie, and while he would prefer a clientside solution, and has concerns ab... [20:32:21] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: [Regression pre-wmf22] Cancelling link inspector crashes VE - https://phabricator.wikimedia.org/T111241#1599221 (10Krenair) a:3Krenair Caused by https://gerrit.wikimedia.org/r/#/c/233669/11/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotation... [20:37:20] ../Citoid/modules/ve.ui.CiteFromIdInspector.js: this.referenceModel = new ve.dm.MWReferenceModel(); [20:37:21] :| [20:37:37] Ahm [20:37:40] Didn't I fix that? [20:38:28] I'm probably running an older version of it [20:38:30] Krenair: https://gerrit.wikimedia.org/r/#/c/234334/ [20:38:31] Yeah [20:40:28] okay, so that's fine [20:40:31] thanks [20:42:44] 10VisualEditor: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#1599249 (10JAufrecht) p:5Triage>3Normal [20:48:08] (03CR) 10Esanders: [C: 032] Don't break when you cancel the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235613 (https://phabricator.wikimedia.org/T111241) (owner: 10Alex Monk) [20:51:54] (03CR) 10jenkins-bot: [V: 04-1] Don't break when you cancel the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235613 (https://phabricator.wikimedia.org/T111241) (owner: 10Alex Monk) [20:55:14] Fun. [20:56:02] Krenair: ^^^ Looks like something's broken in core/someone else [20:56:09] 's extension? ("mw.tooltip exists") [21:00:29] James_F, considering that test both succeeded and failed on the same patch set, sounds more like jenkins is broken [21:01:06] Krenair: Oh, hmm. Yeah. [21:01:09] * James_F re-triggers. [21:01:28] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235613 (https://phabricator.wikimedia.org/T111241) (owner: 10Alex Monk) [21:01:31] (03PS28) 10Divec: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [21:03:39] (03CR) 10Jforrester: [C: 032] Don't break when you cancel the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235613 (https://phabricator.wikimedia.org/T111241) (owner: 10Alex Monk) [21:05:24] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [21:17:18] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 5WMF-deploy-2015-09-08_(1.26wmf22): [Regression pre-wmf22] Cancelling link inspector crashes VE - https://phabricator.wikimedia.org/T111241#1599370 (10Jdforrester-WMF) 5Open>3Resolved [21:26:41] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Consider interface options for VisualEditor when the user is blocked - https://phabricator.wikimedia.org/T111217#1599428 (10Jdforrester-WMF) [21:26:48] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design: Consider interface options for VisualEditor when the user is blocked - https://phabricator.wikimedia.org/T111217#1598141 (10Jdforrester-WMF) p:5Triage>3Normal [21:27:49] 10VisualEditor: VE adds ul/il tags - https://phabricator.wikimedia.org/T111152#1599441 (10Jdforrester-WMF) Looks like the user copy-pasted it from somewhere… [21:29:08] 10VisualEditor, 10VisualEditor-CopyPaste, 10Parsoid: User edit (copy paste?) added a list whose HTML
  • came through into the wikitext somehow - https://phabricator.wikimedia.org/T111152#1599446 (10Jdforrester-WMF) p:5Triage>3Low [21:30:18] 10VisualEditor, 10Parsoid: In scrubWikitext mode, Parsoid should drop tags with no attributes - https://phabricator.wikimedia.org/T111151#1599456 (10Jdforrester-WMF) [21:30:25] 10VisualEditor, 10Parsoid: In scrubWikitext mode, Parsoid should drop tags with no attributes - https://phabricator.wikimedia.org/T111151#1595922 (10Jdforrester-WMF) Turned this into a feature request. [21:31:35] 10VisualEditor: VE adds broken section tasks - https://phabricator.wikimedia.org/T111153#1599470 (10Jdforrester-WMF) I'm going to merge this with {T111152} because it's the same user and almost certainly the same issue. [21:32:08] 10VisualEditor: VE adds broken section tasks - https://phabricator.wikimedia.org/T111153#1599477 (10Jdforrester-WMF) [21:32:11] 10VisualEditor, 10VisualEditor-CopyPaste, 10Parsoid: User edit (copy paste?) added a list whose HTML
  • came through into the wikitext somehow - https://phabricator.wikimedia.org/T111152#1595931 (10Jdforrester-WMF) [21:44:01] 10VisualEditor, 10OOjs-UI, 7Regression, 7Verified-in-Phase0, and 2 others: Icons repeating in toolbar dropdown menu - https://phabricator.wikimedia.org/T109995#1599576 (10Ryasmeen) [21:45:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10SyntaxHighlight, and 2 others: Prompt the user with a drop-down list of available languages when VE-editing a SyntaxHighlight block - https://phabricator.wikimedia.org/T103756#1599578 (10Krenair) 5Open>3Resolved If there are... [21:45:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10SyntaxHighlight, 5WMF-deploy-2015-09-01_(1.26wmf21): Prompt the user with a drop-down list of available languages when VE-editing a SyntaxHighlight block - https://phabricator.wikimedia.org/T103756#1599580 (10Krenair) [21:50:59] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 7Verified-in-Phase0, 5WMF-deploy-2015-09-01_(1.26wmf21): When inserting an image on a sub-page (Foo/Bar), the target of links in captions link to sibling pages (Foo/Baz) rather than uncle pages (Baz) - https://phabricator.wikimedia.org/T109599#1599603 (10Ryasm... [21:51:52] 10VisualEditor, 10OOjs-UI, 7Regression, 7Verified-in-Phase0, 5WMF-deploy-2015-09-01_(1.26wmf21): Icons repeating in toolbar dropdown menu - https://phabricator.wikimedia.org/T109995#1599605 (10Ryasmeen) [22:05:39] (03CR) 10Jforrester: "Is this good to go?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/217995 (https://phabricator.wikimedia.org/T110780) (owner: 10Cscott) [22:07:46] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-09-01_(1.26wmf21): Highlights not hidden when mouse out on gallery - https://phabricator.wikimedia.org/T110195#1599714 (10Ryasmeen) [22:09:00] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Browser-Support-Microsoft-Edge, 7Technical-Debt: Check if IE hacks are still required in Edge - https://phabricator.wikimedia.org/T111081#1599726 (10Esanders) 1. Confirmed the triple-click bug is fixed in Edge: http://jsfiddle.net/jo3zf3xL/ [22:36:15] (03CR) 10Cscott: "AFAIK. You've been the only reviewer so far. But it works for me. (And I'm pretty sure it worked for krenair as well.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/217995 (https://phabricator.wikimedia.org/T110780) (owner: 10Cscott) [22:58:55] James_F, so you guys just couldn't hear me? [22:59:12] could you hear anything at all? buzzing, or..? [22:59:14] I wasn't muted [22:59:25] Krenair: You echoed a bunch or buzzing or crackling or bouncing. [22:59:31] Krenair: Depending on the second. [23:09:49] mooeypoo: I just tried [Manage TemplateData] of bad templatedata, VE's alert is now comprehensive. I think that was you, Nice job! [23:15:43] 10VisualEditor: Flow eats paragraph breaks in lists - https://phabricator.wikimedia.org/T110986#1600174 (10Catrope) [23:15:49] 10VisualEditor: Flow eats paragraph breaks in lists - https://phabricator.wikimedia.org/T110986#1591491 (10Catrope) Maybe a Parsoid bug, but if not that, this is a VE bug. [23:18:23] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-09-01_(1.26wmf21): Inspector is misplaced when inserting focusable content - https://phabricator.wikimedia.org/T110323#1600194 (10Ryasmeen) [23:20:52] spagewmf, yay! [23:23:19] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified-in-Phase0, 5WMF-deploy-2015-09-01_(1.26wmf21): Inspector not repositioned when inserting new extension node - https://phabricator.wikimedia.org/T110314#1600208 (10Ryasmeen) [23:24:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10SyntaxHighlight, and 2 others: Prompt the user with a drop-down list of available languages when VE-editing a SyntaxHighlight block - https://phabricator.wikimedia.org/T103756#1600218 (10Ryasmeen) [23:45:32] James_F, my stat1003 access works, by the way. [23:45:35] Docs could be better. [23:45:37] Oh well. [23:46:25] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 5WMF-deploy-2015-09-01_(1.26wmf21): Find-Replace: When 'Regular expression' search evaluates search criteria as invalid - the Find field should be cleared from previous search results count. - https://phabricator.wikimedia.org/T86789#1600302... [23:46:34] 10VisualEditor, 10VisualEditor-MediaWiki: On user's first use of VE-MW, provide a couple of educational pop-ups for links and for citations with some toolbar highlights to trigger them - https://phabricator.wikimedia.org/T108620#1600303 (10Krenair) a:3Krenair