[00:22:27] hi [00:23:03] have a problem to insert image into a table: https://cs.wikipedia.org/w/index.php?title=Seznam_%C5%BEidovsk%C3%BDch_pam%C3%A1tek_ve_St%C5%99edo%C4%8Desk%C3%A9m_kraji&diff=12149473&oldid=11846555 [00:26:49] Juandev: how did you manage to do that? :o [00:27:05] just wanted to insert an image to table cell [00:27:27] MatmaRex: maybe you better ask Parsoid [00:27:56] Juandev: can you file a bug? i just tried inserting the same image in the same cell (editing the older version) and it worked okay, at least according to the "review changes" screen. [00:28:50] MatmaRex: well, I am not sure it is a bug [00:29:05] recently different scripts are stopping [00:29:28] I dont know if it is caused by VE or because these pages are to big for my browser [00:29:53] sure looks like a bug to me [00:30:20] if the page is too big, all actions will probably just get very slow… it shouldn't break the layout [00:33:42] ok, lets make a bug [00:37:53] 3VisualEditor, VisualEditor-ContentEditable: An image inserted to table cell, break the table - https://phabricator.wikimedia.org/T86501#969541 (10Juandev) 3NEW [00:38:17] have fun [00:43:31] 3VisualEditor, VisualEditor-ContentEditable: Allow to edit table from the middle - https://phabricator.wikimedia.org/T86502#969548 (10Juandev) 3NEW [00:58:24] 3VisualEditor-Tables, VisualEditor: Be able to set table cell background (and other formatting options) - https://phabricator.wikimedia.org/T54180#969564 (10Juandev) >>! In T54180#966351, @Jdforrester-WMF wrote: > There's a strong use case to //not// let this be something people do. The colour in your example ad... [01:15:32] (03CR) 10Jforrester: [C: 032] ve.dm.{MWTransclusionModel,MWTemplateModel}: Remove unused parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184231 (owner: 10Bartosz Dziewoński) [01:17:27] (03Merged) 10jenkins-bot: ve.dm.{MWTransclusionModel,MWTemplateModel}: Remove unused parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184231 (owner: 10Bartosz Dziewoński) [01:19:44] (03CR) 10Jforrester: [C: 032] "For now this probably is worth doing, to prevent confusion. However, note that the MediaWiki theme is not really part of OOjs UI and soon " [oojs/ui] - 10https://gerrit.wikimedia.org/r/184204 (owner: 10Ricordisamoa) [01:21:40] (03Merged) 10jenkins-bot: demo: Switch the default theme from 'Apex' to 'MediaWiki' [oojs/ui] - 10https://gerrit.wikimedia.org/r/184204 (owner: 10Ricordisamoa) [01:21:47] (03CR) 10Jforrester: [C: 031] MediaWiki Theme: Adjust toolbar popups' border and shadows [oojs/ui] - 10https://gerrit.wikimedia.org/r/184194 (https://phabricator.wikimedia.org/T78083) (owner: 10Bartosz Dziewoński) [01:23:24] 3VisualEditor, VisualEditor-MediaWiki, OOjs-UI: VisualEditor: saveOptions.summary is not updated if the summary is inserted using a tool (InputWidget relies on 'change' events rather than checking the value) - https://phabricator.wikimedia.org/T71749#969581 (10Jdforrester-WMF) 5Open>3declined a:3Jdforrester... [01:30:34] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki-Links: the first time that the VisualEditor link inspector appears, it takes a very long time - https://phabricator.wikimedia.org/T85225#969587 (10Jdforrester-WMF) p:5Triage>3Normal [01:34:22] (03CR) 10Jforrester: "Awesome. Thanks!" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [03:57:27] (03CR) 10Catrope: "I thin you might have seen this at https://phabricator.wikimedia.org/T76204#955076" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184234 (owner: 10Bartosz Dziewoński) [03:58:24] (03CR) 10Catrope: [C: 032] Don't rely on 'user' and 'site' modules working correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184234 (owner: 10Bartosz Dziewoński) [03:58:46] I don't have time to track it down right now, but https://www.mediawiki.org/w/index.php?title=Manual:$wgEnableCanonicalServerLink&oldid=667291&veaction=edit is not working properly when logged into my personal account. [03:58:54] E.g. the template at the top can not be selected as a normal template. [03:59:10] And I see a 404 request to: [03:59:12] https://www.mediawiki.org/w/null?ve.performance.system.domLoad.mwTarget=498ms&ve.performance.system.activation.mwTarget=1602ms [03:59:39] Sometimes it seems to load forever too. [04:00:17] (03Merged) 10jenkins-bot: Don't rely on 'user' and 'site' modules working correctly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184234 (owner: 10Bartosz Dziewoński) [04:01:32] (03CR) 10Catrope: [C: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183605 (owner: 10Anomie) [04:07:54] 3UI-Standardization, VisualEditor: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#969611 (10Mattflaschen) 3NEW [04:08:50] 3UI-Standardization, VisualEditor: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#969611 (10Mattflaschen) [04:15:44] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Transclusion dialog makes it too easy for users to remove the newlines between parameters - https://phabricator.wikimedia.org/T52584#969626 (10Mattflaschen) 5Open>3Resolved [04:17:56] 3VisualEditor-EditingTools, VisualEditor: VisualEditor: Transclusion dialog makes it too easy for users to remove the newlines between parameters - https://phabricator.wikimedia.org/T52584#969628 (10Mattflaschen) Agreed, looks fixed. I can no longer reproduce the problem I had before on $wgEnableCanonicalServer... [04:26:01] 3MediaWiki-Page-editing: Give editnotices an own css id/class - https://phabricator.wikimedia.org/T70749#718041 (10MZMcBride) Nice, thanks @MC8 and @matmarex! [06:57:42] (03PS1) 10Gerrit Patch Uploader: Remove style for wpSummary and wpSummaryLabel [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184289 [06:57:45] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184289 (owner: 10Gerrit Patch Uploader) [09:08:18] (03PS1) 10Gerrit Patch Uploader: Escape messages [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184300 [09:08:21] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184300 (owner: 10Gerrit Patch Uploader) [09:24:31] (03PS1) 10Gerrit Patch Uploader: Use background-image instead of for spinner [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 [09:24:34] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/184301 (owner: 10Gerrit Patch Uploader) [11:33:27] moorning [11:37:10] good morning [11:39:03] Morning ^-^ [11:42:21] whats up guys? [15:03:22] 3MediaWiki-Page-editing: Give editnotices an own css id/class - https://phabricator.wikimedia.org/T70749#970875 (10He7d3r) [15:09:18] 3VisualEditor, VisualEditor-MediaWiki: It is very difficult to edit pages wrapped with {{Indentar}} and {{Indentar/fim}} - https://phabricator.wikimedia.org/T62541#970879 (10He7d3r) [16:26:59] Heya. [16:39:41] (03PS2) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 [16:43:07] (03PS3) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 [16:43:27] hi [16:46:04] 3VisualEditor, VisualEditor-Tables: Be able to set table cell background (and other formatting options) - https://phabricator.wikimedia.org/T54180#971085 (10Whatamidoing-WMF) I wonder if it could be a feature that is configurable per-wiki, or ideally per-namespace at each wiki. Then you could get (for example)... [17:11:24] 3VisualEditor: VE busted on beta labs - https://phabricator.wikimedia.org/T86550#971136 (10Cmcmahon) 3NEW [17:19:45] James_F: feel free to make that "Unbreak now" if you want. I'm always reluctant to start off with that status for anything on beta labs. ^^ [17:21:29] chrismcmahon: No, it appears aa53148 broke things. [17:21:35] * James_F blames MatmaRex and Catrope. [17:28:41] (03PS1) 10Jforrester: Don't load OOjs UI i18n strings as core does this already [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184379 [17:30:40] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=110842011 [17:30:40] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33920590 [17:30:40] Corruption alert: visualeditor-needcheck on ukwiki: https://uk.wikipedia.org/?diff=15417853 [17:30:40] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=67869269 [17:34:47] (03CR) 10Esanders: "I think setTimeout would be a hack too. Also I strongly suspect this is a problem with the MWLinkInspector only. I would check if this is " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk) [17:38:22] (03PS42) 10Mooeypoo: Transform the search widget to show image details [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (https://phabricator.wikimedia.org/T78161) [17:39:29] edsanders, can we discuss/do something about this? https://gerrit.wikimedia.org/r/#/c/183303/ [17:40:21] edsanders, this is about a bug in both media dialog and reference dialog, where if you add a link to the caption or the reference text, even if you apply that link, the "Apply" button of the dialog is not enabled. Can we see if the hasBeenModified() method can check for staged stuff too? [17:47:48] hm [17:47:55] let me have a look [17:51:31] the problem is that applyStaging doesn't emit history> [17:51:36] can't we just fix that? [17:56:09] (03PS4) 10Mvolz: [WIP] Use html-metadata library [services/citoid] - 10https://gerrit.wikimedia.org/r/182975 [18:25:44] edsanders|away, sure, then the dialog can listen to 'history' and 'transact' both [18:30:39] (03CR) 10Anomie: Update ApiResult handling for mediawiki/core change I7b37295e (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183605 (owner: 10Anomie) [18:48:17] (03CR) 10Alex Monk: "Caused T86550 ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184234 (owner: 10Bartosz Dziewoński) [18:48:58] Krenair: Hey. If you revert that does master work for you? I'm trying to work out why I can't get anything to work locally even with it reverted… [18:49:07] yes [18:49:22] OK, revert time. [18:49:40] (03PS1) 10Jforrester: Revert "Don't rely on 'user' and 'site' modules working correctly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) [18:49:48] (03CR) 10Jforrester: [C: 032] Revert "Don't rely on 'user' and 'site' modules working correctly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) (owner: 10Jforrester) [18:50:09] (03CR) 10Alex Monk: [C: 032] Revert "Don't rely on 'user' and 'site' modules working correctly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) (owner: 10Jforrester) [18:50:16] ;-) [18:50:53] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf15] VE busted on beta labs; caused by I3abecacf - https://phabricator.wikimedia.org/T86550#971348 (10Jdforrester-WMF) p:5High>3Unbreak! a:3Krenair [18:51:32] (03CR) 10jenkins-bot: [V: 04-1] Revert "Don't rely on 'user' and 'site' modules working correctly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) (owner: 10Jforrester) [18:52:01] Eurgh, the npm issue again. [18:55:20] mooeypoo, the [18:55:30] Apply button should only have to listen to 'history' [18:55:42] like the MW toolbarSaveButton [18:56:28] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) (owner: 10Jforrester) [18:56:39] edsanders: No. [18:56:56] NO! [18:57:06] edsanders: It's also having to listen to the dozen other fields as well. [18:57:20] I meant as opposed to history and transact [18:57:26] Oh. Hmm. [18:57:42] but yes - other fields too [18:57:49] Oh, there's been a regression here. [18:57:54] That's odd. [18:58:10] Open VE; click on a work; click link – no Save button enabled yet (as before). [18:58:23] Click out; link is created, save button goes active (as before). [18:58:43] Click the link again, edit the target in the field; click the save button. [18:59:01] Before: Link is altered before the save dialog opens. Now: Link edit is abandonned. [18:59:08] Did we change that deliberately? [19:00:30] (03Merged) 10jenkins-bot: Revert "Don't rely on 'user' and 'site' modules working correctly" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184397 (https://phabricator.wikimedia.org/T86550) (owner: 10Jforrester) [19:02:40] James_F: thanks for keeping the word "busted" in the renamed title. I've known so many testers use it to mean "totally fubar" that it approaches being a technical term. [19:03:04] It's been like that for a while - we just close all open windows when you hit save [19:03:08] but not with a specific message [19:03:17] the inspector requires a 'done' message to apply the changes [19:03:26] otherwise it'll be like you pressed ESC [19:03:56] from a UX point of view this is the same problem as I was talking about before [19:04:10] of when we are telling the user the change has been made, and how we tell them [19:04:21] edsanders, I'll add that event, but when RoanKattouw_away and I tested, that didn't fix anything. Something should also be updated on that event [19:04:56] if applyStaging emits 'history' and the 'Apply changes [19:05:03] edsanders: Hmm. [19:05:05] ' button listens to 'history' you should be ok [19:05:53] James_F, given that no longer have a cancel button on the link inspector we should probably reconsider the ability to press ESC, and if we should be staging those transactions [19:06:18] one could argue it's sensible for those changes to apply instantly, but we should be consistent [19:06:32] e.g. put them in the undo queue [19:06:48] edsanders: Yeah. [19:10:03] or you can argue the changes don't apply until you press 'done', in which case we shouldn't show them in the doc (i.e. underline a new link), or we should make it visually clear the link isn't real yet (grey/dotted?) [19:10:46] as ever, it's a case of having the model match the view [19:11:26] edsanders: I think we should restore it so that it applies when the window closes. [19:11:42] edsanders: But I could be convinced otherwise. [19:11:46] whenever you break that rule it screws you later [19:11:58] Yeah. [19:12:30] that's fine - it just needs to be visually clear it hasn't been applied yet - so if the window is closed by a cancelling action you aren't surprised [19:12:44] or if the save button is still greyed out [19:14:11] Yeah. [19:14:26] In the meantime we can blame TrevorParscal [19:14:53] Frequently. [19:18:30] edsanders, okay, if I make the dialog listen to "history," then the "apply" button is enabled the second the inspector is open (without "Done") [19:18:35] 3VisualEditor: [Regression pre-wmf15] Switch to source editing while keeping changes is not retaining the edits - https://phabricator.wikimedia.org/T86562#971461 (10Ryasmeen) 3NEW [19:18:46] so... something seems to be inconsistent with the way the surface widget is checking for these things regardless...? [19:19:30] James_F: Hey. Are you aware of the IME input problem in table cell? I was searching for it in phabricator but can't find. [19:19:56] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf15] VE busted on beta labs; caused by I3abecacf - https://phabricator.wikimedia.org/T86550#971468 (10Krenair) Well it's unbroken now, do we want to keep this open for Roan and Bartosz to try again? [19:20:48] InezK: Which problem? [19:21:05] Krenair: Gah, did my closing not save? [19:21:15] mooeypoo, that doesn't seem right [19:21:16] edsanders, okay, I'm really confused. The bug vanished. like, on *clean* master, if I add a link now, the 'apply' button is active. Did anything change? [19:21:23] nope [19:21:26] ... [19:21:41] 3VisualEditor, VisualEditor-MediaWiki: [Regression pre-wmf15] VE busted on beta labs; caused by I3abecacf - https://phabricator.wikimedia.org/T86550#971472 (10Jdforrester-WMF) 5Open>3Resolved [19:21:46] edsanders, can you verify real quick? I... don't know what to say. Maybe I'm checking with a dirty master? I've updated it twice. [19:21:47] maybe you have some code cached from experimentation [19:21:54] yeah I just cleaned it all out [19:22:02] but I'll reset cache again [19:22:34] according to my codebase applyStaging *does* emit history [19:22:36] already [19:22:42] line 275 [19:22:49] yeah but the media dialog didn't listen to it [19:23:19] right [19:23:35] oh, I know what's going on... meh, mediawiki [19:23:36] so I'll change the media dialog to listen to history instead [19:23:47] edsanders: And reference? [19:23:49] edsanders, yeah I was testing that but I have another bug that's masking things, give me a second [19:23:59] James_F: You select cell (just one click) and start typing with IME - input does not appear, and IME thingy appears in top left corner (0,0) [19:24:09] * mooeypoo stares at parsoid's hard-coded sizing for emphasis [19:24:47] mooeypoo, the existing code is listening to tranact on the document [19:24:49] InezK: Well, it's an IME on a null selection… [19:24:58] edsanders, yeah I'm adding 'history' on the surface [19:25:01] so you'll need to get rid of ".getDocument()" from that chain [19:25:02] right [19:25:11] dmsurface [19:25:15] edsanders, should I listen to both, or just history [19:25:21] just history [19:25:30] which is what 'Save page', and the undo/redo buttons do [19:25:41] anything else would be redundant [19:25:48] * mooeypoo nods [19:26:05] great, that fixed it [19:26:12] I still think the behavior is off, but that's a different discussion [19:26:13] yea that WFM locally [19:26:15] in media at least [19:26:17] right [19:26:40] it's at least consistent [19:26:40] 3VisualEditor: [Regression pre-wmf15] New section is not getting added while trying to attempt add one for the first time in a page - https://phabricator.wikimedia.org/T86566#971505 (10Ryasmeen) 3NEW [19:28:18] edsanders, the same issue exists in the reference dialog [19:28:21] i'm going to change that too [19:32:33] yup [19:32:43] (03PS1) 10Mooeypoo: SurfaceWidgets should listen to history [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184409 (https://phabricator.wikimedia.org/T85845) [19:32:49] (03Abandoned) 10Mooeypoo: Check staged changes in surface hasBeenModified [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/183303 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [19:33:28] (03Abandoned) 10Mooeypoo: Attach a parent document to image caption documents [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183199 (owner: 10Mooeypoo) [19:40:17] (03CR) 10Esanders: [C: 04-1] SurfaceWidgets should listen to history (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184409 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [19:50:03] 3VisualEditor: [Regression pre-wmf15] Switch to source editing while keeping changes is not retaining the edits - https://phabricator.wikimedia.org/T86562#971596 (10Krenair) Works for me... [19:50:17] actually ryasmeen, where did you find that? [19:50:35] (I tested on the latest copy of VE...) [19:52:10] (03PS2) 10Mooeypoo: SurfaceWidgets should listen to history [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184409 (https://phabricator.wikimedia.org/T85845) [19:57:38] (03PS2) 10Mooeypoo: Add filename to the media dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/183729 (https://phabricator.wikimedia.org/T54459) [20:04:18] I'm confused by https://phabricator.wikimedia.org/T86566 [20:04:38] I don't think the "New Section" stuff is related to VE... James_F? [20:05:33] Krenair: Don't have time right now. Meetings until, essentially, February. [20:06:02] Fun... [20:06:07] Yeah. :-( [20:09:27] (03PS5) 10Mooeypoo: [WIP] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) [20:13:18] ryasmeen, hey [20:19:07] (03CR) 10Esanders: [C: 032] SurfaceWidgets should listen to history [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184409 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [20:21:26] (03Merged) 10jenkins-bot: SurfaceWidgets should listen to history [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/184409 (https://phabricator.wikimedia.org/T85845) (owner: 10Mooeypoo) [20:22:32] 3VisualEditor, VisualEditor-MediaWiki-References, VisualEditor-MediaWiki-Media: The "Apply Changes" button in Media Settings dialog for newly added images does not get enabled after applying/changing the link of the caption, when the cursor is at the beginning index - https://phabricator.wikimedia.org/T85845#97170... [20:40:03] 3VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-MediaWiki-Media, OOjs-UI: [Regression wmf14] The top border for context menus and inspectors inside Media Settings and Reference dialog are missing in the MediaWiki theme - https://phabricator.wikimedia.org/T85842#971813 (10Esanders) Changing popupwi... [20:52:35] James_F: So does that mean you are aware of it already and have it in phabricator? [20:53:01] InezK: I don't know whether it is, sorry. edsanders might? [20:53:56] (03PS6) 10Mooeypoo: [WIP] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) [20:54:24] TrevorParscal, I will need your help with this ^^ the CSS looks REALLY wonky, and I can't manage to fix it [20:54:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add an ActionFieldLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/175568 (https://phabricator.wikimedia.org/T76634) (owner: 10Mooeypoo) [20:55:24] InezK, I wasn't aware of that bug, but it makes sense [20:55:29] that it would be broken [20:55:39] please file a bug for it though [20:57:24] yup [20:57:51] !newbug [20:58:25] I'll make a key for that for vw project later. Need to cook supper. [20:58:42] I looked a little bit into to... for IME input handleInsertion is not called right away... but for normal input it is. And that method inside is responsible for handling cell selection [21:05:32] 3UI-Standardization, VisualEditor: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#971898 (10Jaredzimmerman-WMF) a:3KHammerstein [21:05:54] 3UI-Standardization, VisualEditor: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#969611 (10Jaredzimmerman-WMF) I agree, but deferring to @KHammerstein [21:15:18] 3VisualEditor-MediaWiki, VisualEditor, UI-Standardization: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#971933 (10Jdforrester-WMF) p:5Triage>3Normal [21:23:05] (03PS1) 10Ricordisamoa: Show "no description" in italic grey also for deprecated parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) [21:24:53] (03CR) 10Ricordisamoa: Show "no description" in italic grey also for deprecated parameters (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184440 (https://phabricator.wikimedia.org/T69794) (owner: 10Ricordisamoa) [21:46:18] 3VisualEditor, Mobile-Web: [jsduck] Various custom tags should be easily shareable between projects - https://phabricator.wikimedia.org/T86587#972038 (10Florian) 3NEW [21:55:17] (03CR) 10Esanders: [C: 04-1] "Managed to install everything, but with a dummy Cite_news it was generating empty references. The regular cite_news tool was pulling in te" (0310 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/168746 (owner: 10Mvolz) [21:55:48] 3VisualEditor: After selecting table cell by single clicking typing with IME (any IME) does not work - https://phabricator.wikimedia.org/T86589#972078 (10Inez) 3NEW [21:57:53] TrevorParscal, James_F, mooeypoo I'm playing around with toolbar-ised special character inserter [21:58:12] and I'm wondering about various use cases [21:58:48] the current use case is "infrequently, I require one rare character" [21:59:25] the other case we've seen wikis hard code in is "Permanently I need a virtual keyboard for accents no on my standard keyboard" [21:59:46] e.g. Welsh people on a English keyboard (although I can't see that tool on cy.wiki anymore) [22:00:22] 3VisualEditor: After selecting table cell by single clicking typing with IME (any IME) does not work - https://phabricator.wikimedia.org/T86589#972096 (10Inez) [22:00:25] Should these be the same tool, and if so, how does it behave to serve these cases? [22:01:43] e.g. the hard coded toolbar would need to be shown-by-default and always-on, which doesn't fit with our current 'one window at a time' model [22:02:53] Hmm. Yeah. Using Special Character and Search-And-Replace at the same time would need to be possible… [22:03:27] edsanders: BTW, the list of languages waiting solely for this is in https://www.mediawiki.org/wiki/VisualEditor/Rollouts – look for languages tagged as "phase 5". [22:09:25] ori, hey [22:10:36] Krenair: hoi [22:10:45] have been wondering about https://gerrit.wikimedia.org/r/#/c/130543/ [22:11:41] 3VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki: VE page save time at 75th percentile up 70% from February - https://phabricator.wikimedia.org/T66171#972128 (10Jdforrester-WMF) a:5Catrope>3Krenair [22:12:05] 3VisualEditor: In 2-Set Korean IME when typing inside a table cell and pressing space selection and cursor disappear - https://phabricator.wikimedia.org/T86592#972129 (10Inez) 3NEW [22:12:07] I went back looking through older comments there [22:12:14] (03CR) 10Jforrester: WIP Bug 64171: Log Parsoid request timings to eventlogging (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [22:12:31] You want this moved to ProfilerSimpleUDP? [22:13:20] Am also wondering if it was a good idea to suggest I could really help here... [22:17:32] ori, ^ [22:18:01] Krenair: I'll take a look in a few, got pulled into a meeting. K? [22:18:03] Haven't touched EventLogging or ProfilerSimpleUDP before but it doesn't look too difficult. [22:18:04] ok [22:20:35] 3Editing, VisualEditor: "Future of Editing" session at 2015 MediaWiki Developer Summit - https://phabricator.wikimedia.org/T85152#972166 (10Qgil) [22:26:40] 3Editing, VisualEditor: "Future of Editing" session at 2015 MediaWiki Developer Summit - https://phabricator.wikimedia.org/T85152#972179 (10Qgil) Today we agreed that this session would not be plenary. You still want to have it scheduled in the main room, right? [22:29:41] 3VisualEditor-Tables, VisualEditor: Merging cells to 'delete' entire rows or columns causes errors - https://phabricator.wikimedia.org/T86160#972186 (10Etonkovidova) Checked in beta - no JS errors. [22:30:12] 3UI-Standardization, OOjs-UI: "Our new front-end platform – OOjs UI" talk for MediaWiki Developer Summit 2015 - https://phabricator.wikimedia.org/T86072#972200 (10Qgil) We have agreed to have a plenary session about {T86593}. Can you clarify the status of this session about OOjs UI? Are they in fact the same, or... [22:30:15] 3VisualEditor, MediaWiki-Configuration, VisualEditor-MediaWiki, MediaWiki-Core-Team: convertExtensionToRegistration.php does not set defaults for globals, so $wgResourceModules += array(...) and similar cause fatals - https://phabricator.wikimedia.org/T86311#972204 (10Legoktm) [22:31:47] 3VisualEditor, MediaWiki-Configuration, VisualEditor-MediaWiki, MediaWiki-Core-Team: convertExtensionToRegistration.php does not set defaults for globals, so $wgResourceModules += array(...) and similar cause fatals - https://phabricator.wikimedia.org/T86311#972219 (10Jdforrester-WMF) >>! In T86311#968918, @Lego... [22:42:49] (03PS7) 10Alex Monk: WIP: Log Parsoid request timings to EventLogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (https://phabricator.wikimedia.org/T66171) (owner: 10GWicke) [22:42:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: Log Parsoid request timings to EventLogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (https://phabricator.wikimedia.org/T66171) (owner: 10GWicke) [22:43:53] 3VisualEditor: [Regression pre-wmf15] New section is not getting added while trying to attempt add one for the first time in a page - https://phabricator.wikimedia.org/T86566#972262 (10Krenair) I'm confused by https://phabricator.wikimedia.org/T86566 I don't think the "New Section" stuff is r... [22:45:01] Krenair: Wow, gerrit really sucks. [22:45:22] what did it do? [22:45:36] It can't auto-merge that. [22:46:16] Isn't that a JGit thing? [22:46:52] Blaming your components/dependencies is cheating. :-) [22:46:54] But yeah. [22:47:05] And my local copy of git has the same issue [22:47:36] Hmm. [22:49:03] (03PS8) 10Alex Monk: WIP: Log Parsoid request timings to EventLogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (https://phabricator.wikimedia.org/T66171) (owner: 10GWicke) [22:51:56] 3VisualEditor-MediaWiki, VisualEditor, OOjs-UI: Clash between rounded corners and text content is jarring for the category editor in VisualEditor when using the OOjs UI MediaWiki theme - https://phabricator.wikimedia.org/T78039#972304 (10Etonkovidova) Checked in betalabs - see the attached screenshot.{F28262} [22:58:19] 3UI-Standardization, VisualEditor-MediaWiki, VisualEditor: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#972329 (10KHammerstein) Yes, it should be blue progressive. Good point, thanks! [22:59:50] edsanders: so... https://gerrit.wikimedia.org/r/#/c/184008/ [23:00:04] 3UI-Standardization, VisualEditor-MediaWiki, VisualEditor: "Save page" on VisualEditor toolbar should be progressive - https://phabricator.wikimedia.org/T86507#972332 (10Jdforrester-WMF) Isn't this going to be a bit jarring, having different colours for the two different save buttons… [23:08:25] TrevorParscal, yeah - looks good [23:08:33] left a my thoughts on the naming [23:12:33] edsanders, another use case is diacritics -- for Hebrew, for instance, it's not really a whole keyboard, but those are things you want open in front of you while you write a sentence you need to add diacritics to. [23:15:20] mooeypoo, those buttons look complex - are they functionally any different to the special character inserter? [23:19:09] edsanders, no, they work with the special char inserter now too -- the only thing they require (Which the special char has right now) is that they must have a different label than the "insertion" value, because the diacritic itself is often hidden or hard to spot, so the value usually has an example letter. [23:19:21] edsanders, and the use case is that you do need to have it open for more than an occasional insertion [23:19:41] but it's not like it's a full keyboard. You'd write a sentence and then go and insert the diacritics in between the characters [23:25:46] (03CR) 10Catrope: [C: 032] Emit position after opening/closing a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184279 (https://phabricator.wikimedia.org/T85844) (owner: 10Esanders) [23:28:58] 3MediaWiki-Vagrant, MediaWiki-ResourceLoader: Possible performance degradation in lessc - Local vagrant super slow - https://phabricator.wikimedia.org/T78733#972401 (10Jdlrobson) This is resurfacing. It seems to become an issue as soon as I install multiple wikis (I just had a fresh install and installed both wi... [23:29:41] (03Merged) 10jenkins-bot: Emit position after opening/closing a window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/184279 (https://phabricator.wikimedia.org/T85844) (owner: 10Esanders) [23:33:26] (03PS1) 10Mooeypoo: Trim aliases on save [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184513 (https://phabricator.wikimedia.org/T85330) [23:42:09] (03CR) 10Jforrester: [C: 031] Trim aliases on save [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/184513 (https://phabricator.wikimedia.org/T85330) (owner: 10Mooeypoo)