[00:10:07] 3VisualEditor / 3Editing Tools: VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width - 10https://bugzilla.wikimedia.org/71652 (10James Forrester) 5PATC>3RESO/FIX [00:20:55] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf3]Extra wide space appearing between the search box and the list of existing references inside Re-Use dialog in mobile VE - 10https://bugzilla.wikimedia.org/72110 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16780... [00:31:24] 3VisualEditor / 3Mobile: VisualEditor Mobile: A small arrow is appearing in an incorrect position next to Citation icon in Mobile VE - 10https://bugzilla.wikimedia.org/72111 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16781 --> https://bugzilla.wikimedia.org/attachment.c... [00:34:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf3] A small arrow is appearing in an incorrect position next to Citation icon in Mobile VE - 10https://bugzilla.wikimedia.org/72111 (10Rummana Yasmeen) [00:39:40] 3VisualEditor / 3Mobile: VisualEdito Mobile:[Regression wmf3] The fields inside Citations dialog are appearing at a much smaller size in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16782 --> https://bugzilla.wikimedia.or... [00:42:26] (03Merged) 10jenkins-bot: Apply mw-body-content styles to SurfaceWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166918 (https://bugzilla.wikimedia.org/71652) (owner: 10Trevor Parscal) [00:58:05] copy/paste is still a mess :( [00:58:45] (03CR) 10Krinkle: [C: 032] Refine global event handling in non-isolated window managers [oojs/ui] - 10https://gerrit.wikimedia.org/r/166019 (owner: 10Esanders) [00:58:49] when I copy random text, it now puts the cursor at the top of the page .. [00:59:43] (03PS2) 10Krinkle: WindowManager: Wait for window to open before trying to close it [oojs/ui] - 10https://gerrit.wikimedia.org/r/166613 (https://bugzilla.wikimedia.org/69918) (owner: 10Bartosz Dziewoński) [01:00:00] (03CR) 10Krinkle: [C: 032] "> 37417:2014-10-15 23:45:26,536 INFO zuul.DependentPipelineManager: Unable to merge change " [oojs/ui] - 10https://gerrit.wikimedia.org/r/166613 (https://bugzilla.wikimedia.org/69918) (owner: 10Bartosz Dziewoński) [01:01:15] (03PS4) 10Krinkle: Element: Correct method name reference in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 (owner: 10Bartosz Dziewoński) [01:01:23] (03CR) 10Krinkle: [C: 032] Element: Correct method name reference in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 (owner: 10Bartosz Dziewoński) [01:09:59] (03Merged) 10jenkins-bot: ButtonWidget: Fix titled button [oojs/ui] - 10https://gerrit.wikimedia.org/r/166214 (owner: 10Bartosz Dziewoński) [01:10:01] (03CR) 10jenkins-bot: [V: 04-1] Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [01:10:03] (03Merged) 10jenkins-bot: MediaWiki theme: Fix styling of SearchWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/165763 (https://bugzilla.wikimedia.org/71889) (owner: 10Esanders) [01:10:05] (03Merged) 10jenkins-bot: Refine global event handling in non-isolated window managers [oojs/ui] - 10https://gerrit.wikimedia.org/r/166019 (owner: 10Esanders) [01:10:07] (03Merged) 10jenkins-bot: WindowManager: Wait for window to open before trying to close it [oojs/ui] - 10https://gerrit.wikimedia.org/r/166613 (https://bugzilla.wikimedia.org/69918) (owner: 10Bartosz Dziewoński) [01:10:09] (03Merged) 10jenkins-bot: Element: Correct method name reference in documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/166199 (owner: 10Bartosz Dziewoński) [01:19:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c12 (10Rummana Yasmeen) 5VERI>3REOP This started happening within last couple of hours [01:19:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131 (10Rummana Yasmeen) 5REOP>3ASSI [01:20:52] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c13 (10Rummana Yasmeen) But the difference is, this time it does not try to parse each time a character is inserted , j... [01:31:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] Cannot open the dropdown box for "Use this group" field inside References List dialog box - 10https://bugzilla.wikimedia.org/72100#c3 (10Rummana Yasmeen) Verified the fix in Betalabs [01:32:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The dropdown box for "Use this group" field inside Reference dialog is not closing upon de-focusing - 10https://bugzilla.wikimedia.org/72099#c5 (10Rummana Yasmeen) Verified the fix in Betalabs [01:34:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] After placing the cursor on a slug, placing it anywhere in the page which follows that particular slug throws "TypeError: Cannot read property 'getSelection' of null" - 10https://bugzilla.wikimedia.org/72095#c4 (10Rummana Yasmeen) Verified t... [01:38:38] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541#c2 (10Rummana Yasmeen) 5RESO/FIX>3REOP The opacity of Formula icon and Special Character did not get fixed with other icons.Is that intentional? [01:39:37] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541 (10Rummana Yasmeen) 5REOP>3ASSI [01:39:39] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541#c3 (10Rummana Yasmeen) Created attachment 16785 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16785&action=edit Screenshot [02:00:40] 3VisualEditor: Link autocompletion broken in reference dialog - 10https://bugzilla.wikimedia.org/72121 (10Erik Moeller) 3NEW p:3Unprio s:3normal a:3None Created attachment 16786 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16786&action=edit buggy link dialog Links don't correctly autocomplet... [05:19:43] (03PS1) 10Catrope: Position popup anchors correctly in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/166947 [05:42:34] (03PS2) 10Catrope: Position popups and their anchors correctly in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/166947 [05:42:54] mooeypoo, TrevorParscal: https://gerrit.wikimedia.org/r/166947 fixes the positioning of all the popup things [05:45:15] (03CR) 10Trevor Parscal: [C: 032] Position popups and their anchors correctly in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/166947 (owner: 10Catrope) [05:47:20] (03Merged) 10jenkins-bot: Position popups and their anchors correctly in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/166947 (owner: 10Catrope) [05:49:02] (03PS1) 10Catrope: noflip left: 0; rule for overlays [oojs/ui] - 10https://gerrit.wikimedia.org/r/166949 [05:49:04] (03PS1) 10Catrope: Rewrite OO.ui.Element.getRelativePosition() to be smarter [oojs/ui] - 10https://gerrit.wikimedia.org/r/166950 [05:55:06] (03PS1) 10Catrope: Use relative positioning category popups out of overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166952 [05:58:21] (03PS2) 10Catrope: Use relative positioning for category popups, move out of overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166952 [11:31:52] 3MediaWiki / 3Page editing: First line in edit window is sometimes hidden in Safari - 10https://bugzilla.wikimedia.org/71909 (10Andre Klapper) p:5Unprio>3Normal [12:25:07] 3VisualEditor / 3Mobile: VisualEditor Mobile:[Regression wmf3] The fields inside Citations dialog are appearing at a much smaller size in mobile VE - 10https://bugzilla.wikimedia.org/72112 (10Andre Klapper) [13:01:52] 3MediaWiki extensions / 3WikiEditor: Toolbar missing on custom skin - 10https://bugzilla.wikimedia.org/69357#c2 (10Andre Klapper) 5UNCO>3RESO/INV Server not found -- closing as INVALID. If this is still an issue, please bring it up on https://www.mediawiki.org/wiki/Project:Support_desk [14:28:39] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf3]:Math/Formula inspector is not working. - 10https://bugzilla.wikimedia.org/72136 (10Ritu Swain) 3UNCO p:3Unprio s:3major a:3None Created attachment 16788 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16788&action=edit screenshot E... [14:28:52] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf3]:Math/Formula inspector is not working. - 10https://bugzilla.wikimedia.org/72136 (10Ritu Swain) [14:31:37] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf3]:Math/Formula inspector is not working. - 10https://bugzilla.wikimedia.org/72136#c1 (10Ritu Swain) Also only in beta, the inspector closes while i am still typing and before even clicking on done. [14:59:56] (03PS1) 10Esanders: Prevent observeration during copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167003 [14:59:58] (03PS1) 10Esanders: Factor out selection of entire pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167004 [15:00:00] (03PS1) 10Esanders: Fix clipboardData API path on copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167005 [15:00:34] RoanKattouw_away, so as of some version of Chrome, clipboardData.setData starting returning undefined [15:01:00] so it was taking the (more buggy) Firefox path [15:02:39] (03CR) 10jenkins-bot: [V: 04-1] Fix clipboardData API path on copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167005 (owner: 10Esanders) [15:02:53] (03CR) 10jenkins-bot: [V: 04-1] Factor out selection of entire pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167004 (owner: 10Esanders) [15:29:39] 3VisualEditor / 3ContentEditable: VisualEditor: Moving the cursor with keyboard over a footnote number goes back and forth - 10https://bugzilla.wikimedia.org/72137 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None 1. Go to https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/Ruby&... [15:30:07] (03PS53) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [16:03:48] (03PS2) 10Alex Monk: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) [16:18:16] Something very weird is happening with my ooui dialog. [16:20:53] The buttons are unclickable for a bit and then they're clickable. Looks like some events are looping or something, but I can't see which event. [16:22:22] 3VisualEditor / 3Editing Tools: VisualEditor:Math/Formula inspector is not working. - 10https://bugzilla.wikimedia.org/72136 (10Ritu Swain) [16:30:40] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108255165 [16:30:40] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108262688 [16:30:40] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108268434 [16:30:40] Corruption alert: visualeditor-needcheck on idwiki: https://id.wikipedia.org/?diff=8225636 [16:30:40] Corruption alert: visualeditor-needcheck on fiwiki: https://fi.wikipedia.org/?diff=14377299 [16:48:56] (03PS1) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [16:52:22] 3VisualEditor / 3Editing Tools: VisualEditor:Math/Formula inspector is not working. - 10https://bugzilla.wikimedia.org/72136#c2 (10Ritu Swain) (In reply to Ritu Swain from comment #1) > Also only in beta, the inspector closes while i am still typing and before > even clicking on done. Although it is not vis... [16:56:07] (03PS2) 10Esanders: Fix clipboardData API path on copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167005 [16:56:09] (03PS2) 10Esanders: Factor out selection of entire pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167004 [17:09:06] (03PS1) 10Cmcmahon: [BrowserTest] update for autopopulated fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167023 [17:10:16] (03CR) 10SuchetaG: "The one in MWTemplateModel has the call this.sequence.push.apply. Needs change?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG) [17:16:38] mooeypoo, Won't be there in November then? [17:16:55] I was thinking of getting you tea. [17:17:00] I still am. [17:17:39] sucheta: You're visiting SF in November? [17:17:51] marktraceur, Yo! [17:18:07] sucheta, no, I'm trying to plan for moving in December 10th [17:18:10] If all goes well [17:18:18] and find an apartment before Christmas [17:19:05] marktraceur will be somewhere else, I bet. Moving everywhere, you are. [17:19:52] James_F, I think I heard you say I was fixing something that wasn't being reviewed? What was that? [17:20:36] sucheta: I mean, moving one place. I'm in MN for good now. [17:20:46] Except for mid-November when I'll be visiting the Old World. [17:21:28] (03PS16) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [17:21:41] mooeypoo, Hmm, OK. I can get someone to keep your share of tea till you visit SF, I guess [17:21:50] (03CR) 10Catrope: "Yeah" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG) [17:22:21] TrevorParscal: is anything still missing from that patch? (still WIP?) [17:23:21] sucheta: We've stored chocolate for mooeypoo before. CHOCOLATE. For TWO MONTHS. The tea should be no problem ;) [17:24:17] YES!!! TEA!!! [17:24:28] I'm so running out! I have preemptive shakes [17:26:51] (03CR) 10Catrope: [C: 032] Prevent observeration during copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167003 (owner: 10Esanders) [17:27:38] (03CR) 10Catrope: [C: 032] Factor out selection of entire pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167004 (owner: 10Esanders) [17:27:59] (03PS3) 10Catrope: Fix clipboardData API path on copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167005 (owner: 10Esanders) [17:28:19] (03CR) 10Catrope: [C: 032] Fix clipboardData API path on copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167005 (owner: 10Esanders) [17:28:39] (03Merged) 10jenkins-bot: Prevent observeration during copy and paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167003 (owner: 10Esanders) [17:30:12] (03Merged) 10jenkins-bot: Factor out selection of entire pasteTarget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167004 (owner: 10Esanders) [17:32:26] MatmaRex: meeting? [17:32:36] front-end standards group needs you [17:32:37] (03Merged) 10jenkins-bot: Fix clipboardData API path on copy [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167005 (owner: 10Esanders) [17:32:43] oookay [17:35:12] sucheta: Re your code review comment: yes [17:38:21] (03PS2) 10SuchetaG: Replacing push.apply in VE-MW with ve.batchPush from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) [17:38:41] RoanKattouw, Re your comment: the patch ^ [17:38:54] sweet [17:39:07] 3VisualEditor / 3Editing Tools: VisualEditor:Math/Formula inspector is not working. - 10https://bugzilla.wikimedia.org/72136#c3 (10Rummana Yasmeen) 5UNCO>3RESO/DUP *** This bug has been marked as a duplicate of bug 71131 *** [17:39:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c14 (10Rummana Yasmeen) *** Bug 72136 has been marked as a duplicate of this bug. *** [17:39:27] sucheta: this.ve.batchPush( should be ve.batchPush( [17:39:36] Dammit [17:39:40] Dammit [17:39:54] :| [17:40:37] yes, it should be. i'm sorry, was out of my mind. [17:42:24] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Math/Formula inspector is not working again - 10https://bugzilla.wikimedia.org/72136#c4 (10James Forrester) 5RESO/DUP>3REOP p:5Unprio>3High a:3Ed Sanders Splitting out from bug 71131 as it's probably a different cause even if the same... [17:42:30] (03PS3) 10SuchetaG: Replacing push.apply in VE-MW with ve.batchPush from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) [17:42:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it - 10https://bugzilla.wikimedia.org/71131#c15 (10James Forrester) 5ASSI>3RESO/FIX Moving back to "FIXED" and re-using bug 72136. [17:42:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Math/Formula inspector is not working again - 10https://bugzilla.wikimedia.org/72136 (10James Forrester) 5REOP>3ASSI [17:43:22] (03CR) 10Catrope: [C: 032] Replacing push.apply in VE-MW with ve.batchPush from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG) [17:44:52] (03Merged) 10jenkins-bot: Replacing push.apply in VE-MW with ve.batchPush from VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166799 (https://bugzilla.wikimedia.org/66206) (owner: 10SuchetaG) [17:46:44] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167023 (owner: 10Cmcmahon) [17:48:09] (03Merged) 10jenkins-bot: [BrowserTest] update for autopopulated fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167023 (owner: 10Cmcmahon) [17:56:49] edsanders: Could you +2 https://gerrit.wikimedia.org/r/167031 please? [18:05:04] MatmaRex: Thank you. :-) [18:05:16] :) [18:06:40] James_F, I think I heard you say I was fixing something that wasn't being reviewed? What was that? [18:07:20] Krenair: I was just needling RoanKattouw for not getting around to reviewing some of your WIPs and self-reviewed -2s, which he should. [18:07:33] Krenair: Specifically the "put a reference list at the bottom of the page if there isn't one already" one. [18:08:36] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (99ec31d9b9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167035 [18:11:13] ah [18:11:16] (03CR) 10Jforrester: [C: 032] Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [18:11:40] (03CR) 10Jforrester: [C: 032] noflip left: 0; rule for overlays [oojs/ui] - 10https://gerrit.wikimedia.org/r/166949 (owner: 10Catrope) [18:12:16] (03PS2) 10Jforrester: [BREAKING CHANGE] Remove deprecated Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165761 [18:12:23] MatmaRex: Want to pull the cord on https://gerrit.wikimedia.org/r/#/c/165761/ ? :-) [18:12:51] if it's unused already, then sure [18:13:27] It is. [18:13:37] (03PS12) 10Esanders: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [18:13:47] (03Merged) 10jenkins-bot: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [18:15:54] (03PS10) 10Esanders: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [18:16:00] (03PS7) 10Esanders: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [18:16:50] (03Merged) 10jenkins-bot: noflip left: 0; rule for overlays [oojs/ui] - 10https://gerrit.wikimedia.org/r/166949 (owner: 10Catrope) [18:16:53] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of $.proxy, use native .bind() - 10https://bugzilla.wikimedia.org/62762 (10James Forrester) 5PATC>3ASSI [18:17:48] (03CR) 10Bartosz Dziewoński: [C: 032] [BREAKING CHANGE] Remove deprecated Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165761 (owner: 10Jforrester) [18:17:54] Whee. [18:19:03] whoo. [18:19:23] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541#c4 (10James Forrester) 5ASSI>3RESO/FIX Maths icon fixed in gerrit 167031, which will be in wmf5 but is relatively minor. [18:20:09] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Remove deprecated Minerva theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/165761 (owner: 10Jforrester) [18:27:41] (03PS13) 10Esanders: WIP: Record intention in ve.dm.Transaction object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [18:27:43] (03PS8) 10Esanders: Add ve.dm.Transaction.newFromIntention() method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [18:27:45] (03PS11) 10Esanders: Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [18:28:11] Wheres a cscott_a` these days? [18:28:27] Vacation [18:29:57] Do you know why his intention commit was WIP, is it just because the tests failed? [18:30:03] I don't know [18:30:50] (03CR) 10Esanders: [C: 031] "Now has tests, but I wrote them." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [18:31:07] (03CR) 10Esanders: [C: 032] Add ve.dm.Transaction.newNoOp() constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [18:31:45] (03CR) 10Esanders: [C: 031] "Fixed up to pass tests, also marked as WIP(?)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151777 (owner: 10Cscott) [18:37:19] o hi TrevorParscal [18:37:20] TrevorParscal: i'm rebasing the stack, turns out we will need to override $this->target in some cases (GroupElement, use in ButtonGroupWidget) - i'll let caller do it the same way as in JS (additional config param) [18:37:20] cool [18:37:20] question is, do we want to support that everywhere in PHP, or just GroupElement? [18:39:37] basically, the answer is always going to be to match the JS api as close as possible [18:39:38] aight. i'm getting sick of isset()s [18:44:20] hm. So... most of the oouifying work is done. Now making sure the small stuff work, like translating deprecated params and reordering params. [18:44:22] hmmm [18:44:30] reordering is going to be interesting in ooui. [18:45:05] Krenair: James_F: Unfortunately the sad truth is that switching to native .bind() makes all affected code about 10-20 times slower. [18:45:16] There's something horendously wrong with native bind() in V8. [18:45:22] It's micro optisation so probably OK. [18:45:38] But if we find a noticable regression, we'll want to do $.proxy in a few critical code paths that run in a tight loop. [18:46:11] This is why I originally recommended against replacing bind = proxy with bind.bind.bind(bind). [18:46:21] but using native directly is better than a bounded version of bind with bind. [18:46:27] ... there's a bind.bind.bind(bind) ? [18:46:38] ... that makes yesterday's conversation with RoanKattouw even more confusing now. [18:46:59] No I think that's wrong [18:47:02] mooeypoo: yeah, you can't do OO.ui.bind = Function.prototype.bind because bind() takes function as first arugment, whereas native bind is a method, not a static utility. [18:47:03] ugh [18:47:10] it's not really bind.bind.bind(bind) [18:47:11] It's more like Function.prototype.call.bind( Function.prototype.bind ) or something [18:47:21] double-binding? [18:47:21] why does IconElement accept both '$icon' and 'icon' parameters [18:47:23] stab stab stab [18:47:28] it's actually the other way around [18:47:32] you're binding call to bind [18:47:39] right, that [18:48:12] bind.call( myfunction, params.. ) [18:48:43] MatmaRex, iirc, icon is a string for the CSS, so icon-left or oo-ui-icon-parameter or something like that [18:48:43] so straight native bind is probably only like 5-10x slower than proxy [18:48:50] and $icon accepts an icon element [18:48:57] yep [18:49:08] i'm converting that to PHP and having problems naming things [18:49:23] haha [18:49:31] Yeah good luck distinguishing icon from $icon in PHP [18:49:43] hah [18:50:02] $iconName vs $iconElement ? [18:51:21] i named it iconElement for now, versus just icon [18:51:30] but that's super poopy [18:51:35] label and indicator have the same thing [18:51:35] oh well [18:51:39] happens [18:52:54] it's okay, I believe TrevorParscal pre-stated that ooui-php is going to be named ooui-something-poo-ph [18:52:57] so that fits. [18:53:19] Though finding a logo for ooui-poo-ph might be tricky. [18:56:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - 10https://bugzilla.wikimedia.org/51423#c21 (10Alex Monk) 5RESO/FIX>3REOP a:5Alex Monk>3None Still seems to be happening, e.g. https://fr.wikipedia.org/?diff=10825... [18:58:21] TrevorParscal, you around? [18:58:53] yo [18:59:07] TrevorParscal, I'm having a really weird problem with my dialog. All the action buttons take a few seconds to react; it's as if something's overlaying on top of them -- if you click any none of them reacts (and even sometimes the page behind it gets selected) -- and then suddenly they start to work [18:59:12] I don't know what I'm doing wrong :\ [19:01:56] (03PS6) 10Bartosz Dziewoński: [WIP] Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 [19:01:58] (03PS5) 10Bartosz Dziewoński: [WIP] OoUiGroupElement, OoUiButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 [19:02:00] (03PS5) 10Bartosz Dziewoński: [WIP] OoUiTitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 [19:02:02] (03PS17) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [19:02:04] (03PS3) 10Bartosz Dziewoński: [WIP] Remaining widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 [19:02:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński) [19:02:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Remaining widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 (owner: 10Bartosz Dziewoński) [19:02:11] (rebased) [19:03:02] mooeypoo: do you have a patch I can checkout and try? [19:03:08] or at least look at? [19:03:12] let me upload it [19:03:14] but it's ugly [19:03:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] OoUiGroupElement, OoUiButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 (owner: 10Bartosz Dziewoński) [19:03:48] blergh, the stack doesn't merge anymore [19:03:50] (03PS1) 10Mooeypoo: [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [19:03:54] TrevorParscal, ^^ [19:04:10] https://gerrit.wikimedia.org/r/#/c/167046/1/modules/ext.templateDataGenerator.ui.tdDialog.js <-- the dialog [19:04:51] (03CR) 10jenkins-bot: [V: 04-1] [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [19:05:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [19:05:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] OoUiTitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 (owner: 10Bartosz Dziewoński) [19:06:34] TrevorParscal: okay so, any reason not to start merging the stack? [19:06:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Needs stuff done" [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 (owner: 10Bartosz Dziewoński) [19:10:48] (03PS1) 10Esanders: Get rid of toHashObject from ranges/selection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167052 [19:12:12] (03PS18) 10Bartosz Dziewoński: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [19:12:53] RoanKattouw: hey, I heard citoid was puppetised. Where does it live? :) [19:13:02] The puppet manifests you mean? [19:13:06] yeah [19:13:10] Or do you mean where does the service run [19:13:17] um, both [19:13:17] The puppet manifests are in the operations/puppet.git repository [19:13:45] basically I want to puppetise the one I have in services [19:13:49] by copying you. [19:13:52] Oh I already did that [19:13:56] oh okay. [19:13:59] sweet [19:14:01] In the deployment-prep project [19:14:06] deployment-sca01 [19:14:16] It runs Citoid and Mathoid, it's basically a clone of sca1001/1002 in production [19:14:27] yeah I meant in the "services" project [19:14:34] ("sca" = "Services Cluster A"; I didn't invent this) [19:14:36] OK [19:14:51] In that case, all you need to do is configure an instance to use role::citoid::labs IIRC [19:15:16] Sorry, role::citoid::beta [19:15:36] Actually that includes a bunch of deployment-prep specific stuff :( [19:16:00] ....why do we need a separate citoid instance in the services project? [19:16:12] TrevorParscal, if you want, I can show you on my screen, since it's templatedata extension [19:16:14] I don't know, that's how it began its life. [19:16:23] at any rate that's what the gadget uses. [19:16:28] Right [19:16:37] The gadget could switch to using citoid.wmflabs.org [19:16:41] Which maps to the deployment-prep one [19:16:49] TrevorParscal, I have a feeling I have clashing/looping events, but I can't figure out what. [19:16:50] right now a cron job is keeping it alive. [19:16:53] wait, it does? [19:16:57] I think so? [19:17:01] um [19:17:06] Or was it citoid-something.wmflabs.org [19:17:15] Oh yes, citoid-beta.wmflabs.org [19:17:26] I think you might already have been using citoid.wmflabs.org for the one in services [19:17:48] In any case; in the longer term we'll use the production one [19:17:54] Right now it's not exposed to the public internet [19:17:55] ... TrevorParscal I found it. I was silly with my events. Fixed it now. [19:18:17] I haven't decided yet whether I want to expose it or tunnel requests to it though an API module, I need to pick gwicke's brain about that [19:18:26] RoanKattouw: you stole my proxy! :) [19:18:49] well okay I don't have access to the deployment project [19:18:54] TrevorParscal, my "add parameter" event looped in on itself; i was checking to see if parameter existed (and only then trigger the event) but the test was wrong, so it kept triggering on loop. Fixed now, whoops, sorry for the hassle [19:19:15] I'll try out your role, thank you [19:19:36] mvolz: Maybe we should fix that; but we have a script that allegedly automatically deploys new commits to the deployment project as they get merged [19:20:12] I think that's what the deployment-specific stuff in role::citoid::beta does [19:20:22] (03PS31) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [19:20:24] (03PS33) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [19:20:26] (03PS4) 10Esanders: [BREAKING CHANGE] Allow tools to specify which selection types they support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166768 [19:20:28] (03PS5) 10Esanders: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 [19:20:30] (03PS36) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [19:20:31] So if you don't want that, or if it doesn't work outside of deployment-prep (which is somewhat likely), you could try using role::citoid instead [19:20:32] (03PS5) 10Esanders: Fix getAnnotationsFromRange when starting with an element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166773 [19:22:52] 3VisualEditor / 3Technical Debt: VisualEditor: Replace uses of push.apply with something safe - 10https://bugzilla.wikimedia.org/66206 (10James Forrester) 5PATC>3RESO/FIX [19:24:59] RoanKattouw: where do you set the subdomain again? Manage ...addresses? [19:25:29] Manage proxies I think [19:29:52] (03PS1) 10Krinkle: Clean up unneeded use of bind() [oojs/ui] - 10https://gerrit.wikimedia.org/r/167054 [19:30:03] (03CR) 10Krinkle: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [19:31:27] (03CR) 10Alex Monk: [C: 032] Clean up unneeded use of bind() [oojs/ui] - 10https://gerrit.wikimedia.org/r/167054 (owner: 10Krinkle) [19:33:06] (03CR) 10Alex Monk: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/166155 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [19:33:31] (03Merged) 10jenkins-bot: Clean up unneeded use of bind() [oojs/ui] - 10https://gerrit.wikimedia.org/r/167054 (owner: 10Krinkle) [19:47:15] (03CR) 10Esanders: [C: 04-1] Add ve.dm.Transaction.newFromIntention() method (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151798 (owner: 10Cscott) [19:47:55] (03PS1) 10Alex Monk: Replace calls to ve.bind( fn, ... ) with fn.bind( ... ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) [19:47:59] (03CR) 10jenkins-bot: [V: 04-1] Replace calls to ve.bind( fn, ... ) with fn.bind( ... ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [19:50:50] (03PS2) 10Alex Monk: Replace calls to ve.bind( fn, ... ) with fn.bind( ... ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) [19:57:17] (03PS7) 10Bartosz Dziewoński: OOUI PHP: Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 [19:57:19] (03PS6) 10Bartosz Dziewoński: OOUI PHP: GroupElement, ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 [19:57:21] (03PS6) 10Bartosz Dziewoński: OOUI PHP: TitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 [19:57:23] (03PS4) 10Bartosz Dziewoński: OOUI PHP: Widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 [19:57:25] (03CR) 10jenkins-bot: [V: 04-1] OOUI PHP: Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński) [19:57:27] (03CR) 10jenkins-bot: [V: 04-1] OOUI PHP: Widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 (owner: 10Bartosz Dziewoński) [19:59:03] TrevorParscal: okay so, any reason not to start merging the stack? [19:59:30] i think everything i pushed is done, needs CR of course [19:59:47] TrevorParscal: i reviewed your part and looks good to me, i also tweaked some bits that i don't know if you've seen [20:00:05] but i want to +2 as soon as you remove the 'WIP" tag :) [20:13:15] (03CR) 10Jforrester: "Shouldn't this also remove ve.bind from ve.js, and a couple of references to it are still around?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:15:37] (03CR) 10Alex Monk: "I didn't do it in OOjs UI either. I don't want to break external things depending on our code." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:16:17] mooeypoo: glad you sorted your problem [20:16:37] TrevorParscal, asking it caused me to go "wait a minute..." [20:16:39] MatmaRex: let's have a merge party [20:16:40] so you helped. [20:16:42] :D [20:16:51] TrevorParscal: Whee. :-) [20:16:54] hah [20:17:02] * TrevorParscal breaks out the sparkling cider [20:17:24] (03PS19) 10Trevor Parscal: PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 [20:17:29] TrevorParscal: James_F: i also wonder, have we settled on a name yet? [20:17:39] or the name, rather. [20:17:40] MatmaRex: you merge mine, and I'll merge yours [20:17:59] name for what? [20:18:06] oo-ui-php [20:18:20] OOjs UI Minus [20:18:33] (03PS20) 10Bartosz Dziewoński: PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [20:18:35] (03PS7) 10Trevor Parscal: OOUI PHP: TitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 (owner: 10Bartosz Dziewoński) [20:18:41] (03CR) 10Bartosz Dziewoński: [C: 032] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [20:19:14] (03CR) 10Jforrester: "OK, but at least this should fix the use in demos/ve/demo.js and clear up a few other places where it's in a comment, perhaps?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) (owner: 10Alex Monk) [20:19:33] MatmaRex: "OOUI" for everything? [20:19:33] (03CR) 10Trevor Parscal: [C: 032] OOUI PHP: TitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 (owner: 10Bartosz Dziewoński) [20:19:43] MatmaRex: Maybe we just call it "Gareth". [20:19:48] :D [20:20:04] (03CR) 10Trevor Parscal: [C: 032] OOUI PHP: GroupElement, ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 (owner: 10Bartosz Dziewoński) [20:21:32] (03PS7) 10Trevor Parscal: OOUI PHP: GroupElement, ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 (owner: 10Bartosz Dziewoński) [20:22:22] MatmaRex: https://gerrit.wikimedia.org/r/#/c/166191/ won't rebase because it introduces the getDir method already present [20:22:23] (03Merged) 10jenkins-bot: PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [20:22:33] could you rebase it nicely? [20:23:13] (03PS3) 10Alex Monk: Replace calls to ve.bind( fn, ... ) with fn.bind( ... ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167055 (https://bugzilla.wikimedia.org/62762) [20:23:55] on it [20:24:04] (03Merged) 10jenkins-bot: OOUI PHP: TitledElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/166081 (owner: 10Bartosz Dziewoński) [20:26:51] (03PS8) 10Bartosz Dziewoński: OOUI PHP: Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 [20:26:53] (03PS5) 10Bartosz Dziewoński: OOUI PHP: Widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 [20:26:57] TrevorParscal: ^ was a silly conflict in FieldLayout.js [20:27:11] oh [20:27:13] cool [20:27:41] (03CR) 10Trevor Parscal: [C: 032] OOUI PHP: Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński) [20:28:13] (03CR) 10Trevor Parscal: [C: 032] OOUI PHP: Widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 (owner: 10Bartosz Dziewoński) [20:28:35] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/166950/ [20:29:04] (03CR) 10Jforrester: "Did we decide on a way forward here?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [20:29:27] (03CR) 10Trevor Parscal: [C: 032] Rewrite OO.ui.Element.getRelativePosition() to be smarter [oojs/ui] - 10https://gerrit.wikimedia.org/r/166950 (owner: 10Catrope) [20:31:38] meh [20:31:41] (03CR) 10Bartosz Dziewoński: "Yes, I need to rewrite the thing, unless you want it merged as-is." [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [20:31:42] >>> typeof {} [20:31:42] mooeypoo: (string) 'object' [20:31:45] >>> typeof [] [20:31:45] mooeypoo: (string) 'object' [20:31:49] ahha. [20:31:58] >>> $.isPlainObject( [] ) [20:31:59] mooeypoo: ReferenceError: $ is not defined [20:32:02] oh [20:32:03] (03Merged) 10jenkins-bot: OOUI PHP: GroupElement, ButtonGroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/166082 (owner: 10Bartosz Dziewoński) [20:32:07] (03Merged) 10jenkins-bot: OOUI PHP: Layouts: Field, Fieldset, Form, Panel, Grid [oojs/ui] - 10https://gerrit.wikimedia.org/r/166191 (owner: 10Bartosz Dziewoński) [20:32:09] (03Merged) 10jenkins-bot: OOUI PHP: Widgets: Icon, Indicator, Label, Input, TextInput, CheckboxInput [oojs/ui] - 10https://gerrit.wikimedia.org/r/166398 (owner: 10Bartosz Dziewoński) [20:32:11] (03Merged) 10jenkins-bot: Rewrite OO.ui.Element.getRelativePosition() to be smarter [oojs/ui] - 10https://gerrit.wikimedia.org/r/166950 (owner: 10Catrope) [20:36:58] RoanKattouw, I think we've had this discussion before, but i must verify because it *always* confuses me. I know that && comes above || --> but just to make sure. If I go if ( A || B && C || D && F ) then the three "or" segments are evaluated indeendently.. so if A it will skip the rest of the conditions and get into the condition. [20:37:34] I remember having my brain in a twist when we discussed how the compiler works with those and tried to convert them to MIPS once. Ew that was terrible. [20:47:22] mooeypoo: isnt ( A || B && C || D && F ) equivalent to: ( A || B ) && ( C || D ) && F ? [20:50:56] MatmaRex: raster images are broken in ooui demo? [20:50:56] hashar: mooeypoo: who cares? if you don't parenthesize that expression, i will find you and i will hurt you :> [20:51:02] ah I mixed it up bah ( A ) || ( B && C ) || ( D && F ) [20:51:15] MatmaRex: agreed :-] [20:52:08] mooeypoo: Do not rely on the order of operations, always parenthesize [20:52:38] RoanKattouw: because math is not a science [20:52:41] oh wait [20:53:37] But then I get comments of "redundant parentheses" [20:53:49] * mooeypoo will do as you say and go "HA!" when someone comments on it [20:53:53] TrevorParscal: hmm, indeed. [20:54:52] mooeypoo: Parentheses that promote understanding are not redundant ;) [20:55:01] * mooeypoo agrees [20:55:19] RoanKattouw, part of this is also a small issue with js' "typeof" result [20:55:32] Why are you using typeof? [20:55:38] * RoanKattouw looks at mooeypoo suspiciously [20:55:41] I'm trying to see if two objects are the same type, but "typeof" doesn't separate between object and array [20:55:49] RoanKattouw, I'm comparing objects outside of VE [20:55:57] so, I'm creating myself a slightly simpler version of ve.compare() [20:56:10] the first thing is to check that both variables are the same type [20:56:21] but 'typeof' doesn't distinguish between array and object [20:56:23] so.. I have to do this: [20:56:24] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way to label auto-numbered external links - 10https://bugzilla.wikimedia.org/72150 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None Steps to reproduce: 1. Open a page that already contains an external link without a label: [http://example.co... [20:57:10] if ( ( typeof obj1 !== typeof obj2 ) || ( $.isArray( obj1 ) && !$.isArray( obj2 ) ) || ( $.isPlainObject( obj1 ) && !$.isPlainObject( obj2 ) ) || ( !$.isArray( obj1 ) && $.isArray( obj2 ) ) || ( !$.isPlainObject( obj1 ) && $.isPlainObject( obj2 ) ) ) { return false; } [20:57:35] (03PS1) 10Bartosz Dziewoński: Gruntfile: Fix PNG image generation [oojs/ui] - 10https://gerrit.wikimedia.org/r/167067 [20:57:37] TrevorParscal: ^ that fixes it for me [20:57:55] RoanKattouw, unless I am going at it wrong, that seems to be accounting for same type + both are arrays or both are objects [20:58:07] mooeypoo: dirty little secret: === works for booleans [20:58:21] yes [20:58:34] ? where? [20:58:44] So, $.isArray( foo ) === $.isArray( bar ) works :D [20:58:57] but I don't want to return it yet [20:59:19] this is the first test, it returns false if one of those isn't the same as the other [20:59:25] oh [20:59:28] i see what you mean here [21:00:15] RoanKattouw, ( typeof obj1 !== typeof obj2 ) || ( $.isArray( obj1 ) !== $.isArray( obj2 ) ) || ( $.isPlainObject( obj1 ) !== $.isPlainObject( obj2 ) ) [21:00:22] Krenair: also, Roan shouldn't have merged this: https://gerrit.wikimedia.org/r/#/c/163300/ [21:00:24] (03CR) 10Bartosz Dziewoński: "This broke raster distribution. Fix: https://gerrit.wikimedia.org/r/167067" [oojs/ui] - 10https://gerrit.wikimedia.org/r/164904 (owner: 10Krinkle) [21:00:38] RoanKattouw, that does make things a bit simpler :p [21:00:39] it breaks combo boxes that don't specify an overlay and aren't inside a window [21:00:44] see the demo [21:01:24] RoanKattouw, ^ [21:06:18] basically, dd9fd577f064eb875a3d5847dfa6f7a71f82f993 works, 05290409354dd8e86b928beaae773b958f5bf1a1 does not [21:07:18]