[02:20:11] (03CR) 10Bartosz Dziewoński: "The dependency might actually not be necessary now that https://gerrit.wikimedia.org/r/#/c/151281/ has been merged. Someone needs to reche" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [06:18:25] 3VisualEditor / 3Editing Tools: VisualEditor: Dialog for inserting new templates doesn't play well with search results - 10https://bugzilla.wikimedia.org/69358 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Goal: Insert a new template. Steps to reproduce: 1. Insert > Template 2. Start typin... [06:22:23] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should have a "cancel" button next to "Apply changes" - 10https://bugzilla.wikimedia.org/52462#c7 (10WhatamIdoing) There is still no "Cancel" button on the link tool. [06:27:26] 3VisualEditor / 3Editing Tools: VisualEditor: If you can't use a button, please display it as disabled/grayed out - 10https://bugzilla.wikimedia.org/69359 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None For example, if you open the link tool on a blank page, there is nothing to "Remove" and nothin... [07:52:10] hooray! i found it. :) [07:52:41] i have visualeditor installed and can see it on new pages, but the existing ones fail. curl validates that parsoid is installed correctly and returning HTMLified markup [07:53:12] the existing pages show me the ajax conversion animations (TOC collapse, ajax loader thing appearing in top right) however never actually render the editor [07:53:41] firefox developer tools network tab doesn’t show any hanging network requests, and wiki log on the server doesn’t shed light either [07:53:44] how to debug? [08:06:44] hrrm, seems i had the wrong wgVisualEditorParsoidURL [08:40:51] (03PS2) 10Jforrester: Update token handling for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153108 (owner: 10Anomie) [08:42:42] (03CR) 10jenkins-bot: [V: 04-1] Update token handling for core API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153108 (owner: 10Anomie) [08:54:51] (03PS1) 10Jforrester: [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 [08:54:56] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move modules to src and tests and i18n, UnicodeJS to lib [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153282 (owner: 10Jforrester) [10:28:04] (03CR) 10Catrope: [C: 032] Add bidi isolation to language annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153052 (owner: 10Mooeypoo) [10:29:20] (03Merged) 10jenkins-bot: Add bidi isolation to language annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153052 (owner: 10Mooeypoo) [10:40:25] (03PS2) 10Jforrester: build: Switch from qunit directly to karma for code coverage reports [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151299 [10:42:47] (03CR) 10Catrope: [C: 04-1] "I haven't quite wrapped my mind around this change yet, but here are some cleanliness things I noticed" (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152017 (owner: 10Cscott) [10:50:50] (03CR) 10Catrope: [C: 04-1] Show metadata in the debug bar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152261 (owner: 10Esanders) [10:51:55] (03CR) 10Catrope: [C: 04-1] Queue up annotation changes to make operations safer (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152776 (https://bugzilla.wikimedia.org/68892) (owner: 10Esanders) [11:03:59] RoanKattouw: Feel like merging https://gerrit.wikimedia.org/r/151299 for me? :-) [11:39:24] (03PS3) 10Divec: WIP: Kleptologging and interesting thing detection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/152123 [13:10:25] 3VisualEditor / 3Editing Tools: Create link button is not easily discoverable - 10https://bugzilla.wikimedia.org/69364 (10che) 3NEW p:3Unprio s:3normal a:3None Yesterday I tried VisualEditor for the first time, after nine years of editing wikitext. I took me several minutes to find out how to make a... [13:18:57] (03CR) 10Legoktm: [C: 031] "Test failures look unrelated?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153108 (owner: 10Anomie) [13:20:24] (03CR) 10Alex Monk: "Yes, that error was affecting other unrelated VE patches as well." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153108 (owner: 10Anomie) [15:29:32] Krenair: https://gerrit.wikimedia.org/r/#/c/153078/ etc. [15:31:35] (03PS2) 10Jforrester: Update VE core submodule to master (3cfccf8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152111 [15:33:30] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (3cfccf8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152111 (owner: 10Jforrester) [15:37:05] (03PS3) 10Krinkle: Update token handling for MediaWiki API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153108 (owner: 10Anomie) [15:38:50] (03CR) 10jenkins-bot: [V: 04-1] Update token handling for MediaWiki API change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/153108 (owner: 10Anomie) [15:54:41] (03CR) 10Jforrester: [C: 04-2] "Still doesn't work yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141091 (owner: 10Jforrester) [15:57:05] (03CR) 10Jforrester: [C: 04-1] "I'm not sure about this from a UX/design perspective; normally switches that enable/disable behaviour appear before, not after, the behavi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/152054 (https://bugzilla.wikimedia.org/69164) (owner: 10Amire80) [16:30:35] Corruption alert: visualeditor-needcheck on idwiki: https://id.wikipedia.org/?diff=8115476 [17:35:38] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c3 (10NicoV) 5RESO/WON>3REOP Please read my comment: the main problem is ESC key not working at all as could be expected by any user. [18:59:08] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c4 (10James Forrester) 5REOP>3RESO/WON (In reply to NicoV from comment #2) > But the main problem with this is that the ESC key is not working correctly > (it should cancel t... [19:05:08] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c5 (10NicoV) 5RESO/WON>3REOP Well, give me one example of a software behaving like that: in any software I know, when you click on a button that open a dialog, if you cancel... [19:34:39] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs should have a "cancel" button next to "Apply changes" - 10https://bugzilla.wikimedia.org/52462#c8 (10John Broughton) 5RESO/FIX>3REOP As noted previously, there no "Cancel" button on the link tool (dialog? insert window?). Also, there is no "Cancel" bu... [19:36:08] 3VisualEditor: VisualEditor: Don't allow a linking action if no text was highlighted before - 10https://bugzilla.wikimedia.org/68101#c6 (10James Forrester) 5REOP>3RESO/WON Please don't edit war on Bugzilla. Create a new bug about an actual issue if you wish. [19:49:55] 3VisualEditor: VisualEditor: s in a section-edit get re-numbered - 10https://bugzilla.wikimedia.org/69373 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None https://en.wikipedia.org/wiki/Sonic_Adventure#Development When I go here and click "edit beta", the s are re-numbered when ?veaction=edit l... [19:58:38] 3MediaWiki extensions / 3TemplateData: TemplateData: Please suppress the "Manage template documentation" button when the template doesn't exist - 10https://bugzilla.wikimedia.org/69268#c3 (10James Forrester) (In reply to WhatamIdoing from comment #2) > Is your idea of the template workflow "First document t... [19:59:08] 3VisualEditor / 3ContentEditable: VisualEditor: Cursoring off focusable nodes scrolls viewport to the top of the document - 10https://bugzilla.wikimedia.org/68589 (10Bartosz Dziewoński) [21:21:49] (03CR) 10Jforrester: [C: 032] Rename MWLinkInspector → MWLinkAnnotationInspector to match file name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149636 (owner: 10Bartosz Dziewoński) [21:23:30] (03CR) 10jenkins-bot: [V: 04-1] Rename MWLinkInspector → MWLinkAnnotationInspector to match file name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149636 (owner: 10Bartosz Dziewoński) [21:24:48] (03PS2) 10Jforrester: Rename MWLinkInspector → MWLinkAnnotationInspector to match file name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149636 (owner: 10Bartosz Dziewoński) [21:24:55] (03PS7) 10Jforrester: Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [21:26:31] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to create autonumbered external links from link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [21:26:35] (03CR) 10jenkins-bot: [V: 04-1] Rename MWLinkInspector → MWLinkAnnotationInspector to match file name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/149636 (owner: 10Bartosz Dziewoński) [22:26:48] why are VE tests broken D: [22:30:44] MatmaRex: Roan's working on it. [22:30:50] MatmaRex: But it's your fault. Ish. [22:31:04] :o [22:31:15] MatmaRex: (Your removal of Vector from MW broke one of the core tests in VE-MW .) [22:31:31] oh. hah [22:31:51] just one? i kinda expected it to be worse ;) [22:35:08] MatmaRex: Just one we know of so far. :-) [23:02:40] (03PS1) 10Esanders: Use hasOwnProperty check in registry and lookup in factory [oojs/core] - 10https://gerrit.wikimedia.org/r/153356 [23:30:58] (03PS1) 10Catrope: Actually check annotations in paste test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/153359 [23:35:06] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/151299/