[00:15:06] <grrrit-wm>	 (03PS10) 10Catrope: [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:15:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:24:27] <grrrit-wm>	 (03PS11) 10Catrope: [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:24:29] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Remove repositionOnly parameter in DesktopContext.update() - 10https://bugzilla.wikimedia.org/66507 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Trevor Parscal It's unused now.
[00:25:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:25:11] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Remove repositionOnly parameter in DesktopContext.update() - 10https://bugzilla.wikimedia.org/66507 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3enhanc
[00:26:21] <grrrit-wm>	 (03PS12) 10Catrope: [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:30:13] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:31:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Update OOjs UI to v0.1.0-pre (9f4f250f88) for window process cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138113 (https://bugzilla.wikimedia.org/66016) (owner: 10Trevor Parscal)
[00:32:18] <grrrit-wm>	 (03PS1) 10Catrope: Rebuild .html files for ContextWidget addition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139044 
[00:33:00] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to cf1945f60e3d1d7bc54c9ef5f90ac3ebd1f3d42b [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139045 
[00:33:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to cf1945f60e3d1d7bc54c9ef5f90ac3ebd1f3d42b [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139045 (owner: 10Catrope)
[00:33:48] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Rebuild .html files for ContextWidget addition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139044 (owner: 10Catrope)
[00:33:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Rebuild .html files for ContextWidget addition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139044 (owner: 10Catrope)
[00:35:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "No, really…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139044 (owner: 10Catrope)
[00:35:32] <grrrit-wm>	 (03PS1) 10Alex Monk: Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) 
[00:35:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to cf1945f60e3d1d7bc54c9ef5f90ac3ebd1f3d42b [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139045 (owner: 10Catrope)
[00:36:01] <James_F>	 RoanKattouw: 65343 65924
[00:36:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rebuild .html files for ContextWidget addition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139044 (owner: 10Catrope)
[00:36:41] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: adding a new link shows the target of the previously-added link for a few moments in the link inspector - 10https://bugzilla.wikimedia.org/66016 (10James Forrester) 5PATC>3RESO/FIX
[00:36:58] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Remove repositionOnly parameter in DesktopContext.update() - 10https://bugzilla.wikimedia.org/66507 (10James Forrester) 5ASSI>3RESO/FIX a:5Trevor Parscal>3Roan Kattouw
[00:37:39] <grrrit-wm>	 (03PS10) 10Catrope: [BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal)
[00:38:19] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Overlapping template boxes make some transclusions difficult or impossible to access - 10https://bugzilla.wikimedia.org/51933#c8 (10James Forrester) 5PATC>3ASSI Partially mitigated by the above but I believe not fixed. Resetting.
[00:38:27] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Remove repositionOnly parameter in DesktopContext.update() - 10https://bugzilla.wikimedia.org/66507#c1 (10Roan Kattouw) 5RESO/FIX>3REOP a:5Roan Kattouw>3Trevor Parscal We still need to 1) get Trevor to look at whether it actually needs to die and 2) upda...
[00:39:26] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Work out whether removing repositionOnly parameter in DesktopContext.update() was a good idea - 10https://bugzilla.wikimedia.org/66507#c2 (10James Forrester) 5REOP>3ASSI Fair point. Whoops. :-) Relabelling.
[00:41:44] <James_F>	 RoanKattouw: 60843
[00:42:15] <grrrit-wm>	 (03PS11) 10Catrope: [BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal)
[00:42:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Inline images don't display correctly if converted to floating images and then back - 10https://bugzilla.wikimedia.org/65924#c9 (10James Forrester) 5PATC>3ASSI (In reply to Gerrit Notification Bot from comment #8) > Change 138114 had a related patch set uplo...
[00:42:35] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal)
[00:42:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343 (10James Forrester) 5PATC>3RESO/FIX a:3Trevor Parscal
[00:43:27] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is adding just a link text while opening up the inspector for the second time selecting another element - 10https://bugzilla.wikimedia.org/60843 (10James Forrester) 5PATC>3RESO/FIX a:3Trevor Parscal
[00:44:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Update VE core submodule to master (43a48cb) for window process cleanup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138114 (https://bugzilla.wikimedia.org/65705) (owner: 10Trevor Parscal)
[00:48:05] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/139006
[00:48:24] <grrrit-wm>	 (03Abandoned) 10Catrope: Update OOjs UI to v0.1.0-pre (063ec067fa) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138857 (owner: 10Trevor Parscal)
[00:53:32] <ryasmeen>	 RoanKattouw:https://bugzilla.wikimedia.org/show_bug.cgi?id=66083
[00:55:28] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/138833/
[00:56:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Merging because this seems to help, but I'd like to get answers to those questions at some point." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders)
[00:56:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "The same issue (selecting </p>) needs to be fixed in a lot of other cases as well, such as when you use the image dialog to change an inli" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137040 (owner: 10Esanders)
[00:57:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't refocus the document in onModelSelect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138833 (https://bugzilla.wikimedia.org/65882) (owner: 10Esanders)
[00:57:46] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Create 'next' and 'previous' indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/139006 (owner: 10Jforrester)
[00:59:12] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Viewport scrolls to top after drag-and-dropping image - 10https://bugzilla.wikimedia.org/65882 (10James Forrester) 5PATC>3RESO/FIX
[00:59:26] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: The reference list dialog opens with a bit wiggly animation while trying to open it first for every session - 10https://bugzilla.wikimedia.org/65705 (10James Forrester) 5PATC>3RESO/FIX
[00:59:41] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Work out whether removing repositionOnly parameter in DesktopContext.update() was a good idea - 10https://bugzilla.wikimedia.org/66507 (10James Forrester)
[01:00:12] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868 (10James Forrester)
[01:00:21] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Create 'next' and 'previous' indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/139006 (owner: 10Jforrester)
[01:00:32] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341 (10James Forrester) a:3Alex Monk
[01:00:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Create 'next' and 'previous' indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/139006 (owner: 10Jforrester)
[01:01:11] <InezK>	 James_F: So you can write code?
[01:01:18] <InezK>	 Just looking at https://github.com/jdforrester/grunt-banana-checker  :)
[01:01:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Create 'next' and 'previous' indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/139006 (owner: 10Jforrester)
[01:02:23] <RoanKattouw>	 InezK: He's written our support for __NOTOC__ and __NOCC__ and __NOEDITSECTION__ etc etc :)
[01:02:54] <InezK>	 wow!
[01:04:55] <James_F>	 InezK: Yeah, well… ;-)
[01:09:12] <James_F>	 InezK: I should finish off v.0.2.0 of that.
[01:09:44] <grrrit-wm>	 (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (c5ae888f67) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139055 
[01:09:58] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (c5ae888f67) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139055 (owner: 10Catrope)
[01:10:41] <RoanKattouw>	 James_F: And https://gerrit.wikimedia.org/r/139056
[01:11:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (c5ae888f67) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139055 (owner: 10Catrope)
[01:15:23] <grrrit-wm>	 (03PS3) 10Catrope: Improved layout of language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders)
[01:21:56] <grrrit-wm>	 (03PS4) 10Catrope: Improved layout of language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders)
[01:22:38] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Improved layout of language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders)
[01:23:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improved layout of language input widget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138841 (owner: 10Esanders)
[01:27:58] <grrrit-wm>	 (03PS6) 10Catrope: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) (owner: 10Alex Monk)
[01:30:43] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) (owner: 10Alex Monk)
[01:32:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow VE users to change displaytitle in advanced settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129065 (https://bugzilla.wikimedia.org/56868) (owner: 10Alex Monk)
[02:27:44] <grrrit-wm>	 (03PS19) 10Jagori79: WIP: [Browser test] Adding step definition and page object for external link scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) 
[03:57:02] <grrrit-wm>	 (03PS1) 10Mooeypoo: Add inline images into existing paragraphs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139064 (https://bugzilla.wikimedia.org/65924) 
[04:21:00] <grrrit-wm>	 (03CR) 10Jforrester: "Ping on this patchset." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131078 (owner: 10Krinkle)
[04:22:10] <grrrit-wm>	 (03CR) 10Jforrester: "Update on this patchset?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (owner: 10Esanders)
[04:23:00] <grrrit-wm>	 (03PS2) 10Jforrester: [WIP] Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 
[04:24:33] <grrrit-wm>	 (03CR) 10Jforrester: "Trivial point about naming. :-)" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (https://bugzilla.wikimedia.org/63104) (owner: 10Jagori79)
[04:33:14] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868 (10James Forrester) 5PATC>3RESO/FIX
[04:33:59] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit behaviour flags in the page metadata panel (tracker) - 10https://bugzilla.wikimedia.org/56865#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3James Forrester No remaining children tickets; closing for now. We can re-open if it turn...
[04:54:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector does not show suggestions dropdown on open if link target is the same as the target of the most recently inspected link - 10https://bugzilla.wikimedia.org/55839#c6 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Trevor Parscal Thi...
[04:56:15] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector doesn't save changes when closing while XHR is pending - 10https://bugzilla.wikimedia.org/62818#c1 (10James Forrester) 5ASSI>3RESO/FIX a:5Ed Sanders>3Trevor Parscal This looks like it's now been fixed. I think.
[04:58:41] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link tooltip is not updated if link inspector is not explicitly closed - 10https://bugzilla.wikimedia.org/54984#c1 (10James Forrester) 5ASSI>3RESO/FIX This has now been fixed.
[04:59:26] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Opening and closing the link inspector dirties the link, adding a pointless transaction - 10https://bugzilla.wikimedia.org/57205#c2 (10James Forrester) 5ASSI>3RESO/FIX a:5Ed Sanders>3Trevor Parscal Now fixed by Trevor's work on the link inspector and window...
[05:00:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector opens up in the wrong place after inside Media Settings dialog - 10https://bugzilla.wikimedia.org/62857#c2 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders I believe that this one is now fixed courtesy of Ed's changes this week or last.
[05:00:55] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should have bottom margin to avoid UX ambiguity - 10https://bugzilla.wikimedia.org/52436 (10James Forrester) s:5normal>3minor
[05:03:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector suggestions sometimes aren't displayed in Firefox - 10https://bugzilla.wikimedia.org/55465#c6 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal I believe that this is now fixed, at least as far as I can tell.
[05:04:12] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: External links with single brackets around it should be indicated as invalid external link inside link inspector - 10https://bugzilla.wikimedia.org/65547#c2 (10James Forrester) a:3Alex Monk Is our regex not anchored to the start of the string somehow?
[05:08:10] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Link input widget outwits itself with the leading colon for Category/file links - 10https://bugzilla.wikimedia.org/50279#c1 (10James Forrester) p:5Low>3Normal Two different things look like they're pre-pending the ":". Helpful. :-)
[05:08:58] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Caption of a thumb image starting with a link means link inspector icon appears in slug, confusingly - 10https://bugzilla.wikimedia.org/49680#c4 (10James Forrester) 5ASSI>3RESO/FIX a:3Ed Sanders I believe that this was fixed by Ed's work on this last week.
[05:10:12] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal I think that we fixed this recently, though I...
[05:11:58] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Wrong link rendered in edit mode when you click link in drop-down - 10https://bugzilla.wikimedia.org/55724#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders This was fixed by Ed's re-working of these recently, I think.
[05:14:26] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Demote the "New Page" part of the link inspector to below the "External link" one when inserting a link as URL pattern - 10https://bugzilla.wikimedia.org/56482#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc We don't want to do t...
[05:14:57] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Page Suggestions in link inspector are not appearing in FireFox on Betalabs - 10https://bugzilla.wikimedia.org/61284#c1 (10James Forrester) 5NEW>3RESO/WOR I'm going to write this one us as a server issue.
[05:16:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link is not getting added when the clear formatting is used while the link inspector was open - 10https://bugzilla.wikimedia.org/57604#c3 (10James Forrester) 5NEW>3RESO/WOR We now close the inspector when you click into the toolbar, which essentially fixes th...
[05:17:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: No way to identify destination, rather than link text, of links - 10https://bugzilla.wikimedia.org/49928#c5 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal This is now done with the new context widget system.
[05:30:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget sometimes picks wrong link target - 10https://bugzilla.wikimedia.org/62492#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal Fixed as part of the general link inspector work this week.
[05:33:14] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Save dialog animates size while animating open if it was large when it was closed - 10https://bugzilla.wikimedia.org/62859#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal Yay Trevor. :-)
[05:51:27] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Editing a link in a reference leaves both the old and new link in DM, but not in CE surface - 10https://bugzilla.wikimedia.org/52127 (10James Forrester) s:5normal>3major
[05:53:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Links can point to wrong page if not matching case exactly and when not first option in the list - 10https://bugzilla.wikimedia.org/52634 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal
[05:56:13] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor:The cursor position for newly inserted link should be at the end of the link that is being created - 10https://bugzilla.wikimedia.org/56429#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders This was fixed a few months ago (the curso...
[05:57:28] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: It should be possible to add a link with only pressing enter once - 10https://bugzilla.wikimedia.org/56434#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal s:5normal>3enhanc Now fixed with the changes to the link inspector.
[05:59:11] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Links should do pre-annotations in both directions (not just down-page but also up-page) - 10https://bugzilla.wikimedia.org/58554 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5minor>3enhanc
[06:00:26] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: You can't click on a scrollbar to move down a suggestions list to pick a lower item (because it closes on click) - 10https://bugzilla.wikimedia.org/65774 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High
[06:01:56] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description page - 10https://bugzilla.wikimedia.org/50321#c3 (10James Forrester) *** Bug 64974 has been marked as a duplicate of this bug. ***
[06:01:56] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] "Middle click" / Cmd+Click on mac no longer open links' targets in a new tab - 10https://bugzilla.wikimedia.org/64974#c1 (10James Forrester) 5ASSI>3RESO/DUP Turns out I was wrong and this did already exist - sorry!  *** This bug has been marked...
[06:02:25] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Link input widget outwits itself with the leading colon for Category/file links - 10https://bugzilla.wikimedia.org/50279 (10James Forrester)
[06:03:40] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Provide a way (beyond Ctrl-Click, middle-click, or right-click/tab) to open links in another window - 10https://bugzilla.wikimedia.org/54759 (10James Forrester)
[06:03:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Demote the "New Page" part of the link inspector to below the "External link" one when inserting a link as URL pattern - 10https://bugzilla.wikimedia.org/56482 (10James Forrester)
[06:05:26] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor:  ISBN link labels (from magic words) can be changed, but not the underlying links - 10https://bugzilla.wikimedia.org/61558 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal
[06:06:46] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: The link inspector opens after gallery , if there is gallery just after the text on which the link is getting applied - 10https://bugzilla.wikimedia.org/63200#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders I /think/ Ed fixed thi...
[06:08:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Gallery inspector/Link inspector opens with an animation from left to right for a specific case - 10https://bugzilla.wikimedia.org/60501#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Trevor Parscal This looks like it's now fixed.
[06:11:57] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:The link icon appears on the template while attempting to apply a format on the article - 10https://bugzilla.wikimedia.org/57783#c3 (10James Forrester) 5NEW>3RESO/FIX Possibly maybe this is now fixed? I couldn't reproduce, but I may have been doing it wrongly.
[06:13:28] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: wiki markup for link shows up if a template is selected with another text and applied link onto them together - 10https://bugzilla.wikimedia.org/56749#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal This appears to be fixed from what I can tell....
[06:16:26] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc
[06:17:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When tabbing inside the template inspector, don't skip the "Add Parameter" option - 10https://bugzilla.wikimedia.org/63014#c1 (10James Forrester) 5NEW>3RESO/DUP I believe this was fixed with bug 65474 being completed. Sorry for getting this out of order.  ***...
[06:17:57] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Template editor is missing accessibility features - 10https://bugzilla.wikimedia.org/65474#c3 (10James Forrester) *** Bug 63014 has been marked as a duplicate of this bug. ***
[06:19:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Long parameter names get hidden under their input fields - 10https://bugzilla.wikimedia.org/63065#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Trevor Parscal We fixed this by making them not on the side but above.
[06:20:12] <wikibugs>	 3MediaWiki extensions / 3TemplateData: TemplateData: Allow templates to express whether they should be laid out inline or with each parameter on its own line in wikitext - 10https://bugzilla.wikimedia.org/63813 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5minor>3enhanc
[06:21:56] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Fail gracefully (not "fatal exception") when being run on MW 1.22.6 rather than supported version - 10https://bugzilla.wikimedia.org/64971 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal
[06:23:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: "Insert Transclusion" button remains enabled while adding an empty content section - 10https://bugzilla.wikimedia.org/63341 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor a:5Trevor Parscal>3None
[06:25:46] <wikibugs>	 3VisualEditor / 3Technical Debt: VisualEditor: Rewrite converter to be bottom-up - 10https://bugzilla.wikimedia.org/51501#c2 (10James Forrester) Ping on this bug.
[06:27:28] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: It should be possible to add a link with only pressing enter once - 10https://bugzilla.wikimedia.org/56434 (10James Forrester) a:3Trevor Parscal
[07:41:43] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Fail gracefully (not "fatal exception") when being run on MW 1.22.6 rather than supported version - 10https://bugzilla.wikimedia.org/64971#c3 (10Hermann Schwärzler) This also happens with master and MW 1.23
[08:20:44] <wikibugs>	 3VisualEditor: VisualEditor: Creating a new page shows footer above the article - 10https://bugzilla.wikimedia.org/66517 (10Jan Ainali) 3NEW p:3Unprio s:3normal a:3None Created attachment 15634   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15634&action=edit Screencast of the behaviour.  When I...
[08:41:14] <wikibugs>	 3VisualEditor: VisualEditor not working with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519 (10Hermann Schwärzler) 3UNCO p:3Unprio s:3major a:3None After a fresh installation of MW 1.23 (from the tarball), adding VisualEditor and configuring parsoid, the "Edit" (or "Create") link of any page i...
[08:42:26] <wikibugs>	 3VisualEditor: VisualEditor not working with MediaWiki 1.23 - 10https://bugzilla.wikimedia.org/66519#c1 (10Hermann Schwärzler) Created attachment 15635   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15635&action=edit Response of POST to api.php
[09:46:11] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: No way to identify destination, rather than link text, of links - 10https://bugzilla.wikimedia.org/49928#c6 (10This, that and the other) It's nice, but doesn't really address the workflow in comment 3.  (In reply to James Forrester from comment #3) > However, thi...
[10:45:05] <grrrit-wm>	 (03PS1) 10Esanders: Tidy up SVG sources and fix pixel snapping [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 
[12:02:05] <grrrit-wm>	 (03PS1) 10Esanders: [BREAKING CHANGE] Move language functions to the platform [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 
[12:02:09] <grrrit-wm>	 (03PS1) 10Esanders: Implement new language platform functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 
[12:03:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Move language functions to the platform [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 (owner: 10Esanders)
[12:03:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement new language platform functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[12:18:34] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] Accessibility: Set role=dialog on dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/139039 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk)
[12:22:02] <grrrit-wm>	 (03CR) 10TheDJ: [C: 031] "looks good, you could also set role=window on a window if you want btw." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk)
[13:50:26] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Up and down cursor keys don't let you cursor from a focusable node into a slug - 10https://bugzilla.wikimedia.org/62542#c1 (10Oliver Buchtala) It happened that I ran over that issue while debugging. Here some details that may help:  The problem is, that after f...
[14:22:09] <grrrit-wm>	 (03PS1) 10Esanders: Fix alien demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139111 
[14:22:11] <grrrit-wm>	 (03PS1) 10Esanders: Alien node styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139112 
[14:22:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix alien demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139111 (owner: 10Esanders)
[15:09:29] <grrrit-wm>	 (03PS5) 10Esanders: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 
[15:09:31] <grrrit-wm>	 (03PS10) 10Esanders: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[15:10:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[15:17:06] <Krenair>	 James_F|Away, https://bugzilla.mozilla.org/show_bug.cgi?id=727125#c57
[15:24:34] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Accessibility: Restore element focus when a window closes (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk)
[15:30:56] <grrrit-wm>	 (03PS2) 10Alex Monk: Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) 
[15:30:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) (owner: 10Alex Monk)
[15:31:30] <grrrit-wm>	 (03PS3) 10Alex Monk: Accessibility: Restore element focus when a window closes [oojs/ui] - 10https://gerrit.wikimedia.org/r/139047 (https://bugzilla.wikimedia.org/65473) 
[15:31:40] <Krenair>	 jenkins, wat
[15:32:16] <grrrit-wm>	 (03CR) 10Krinkle: [WIP] Add a clean-up script for use as a pre-commit hook (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester)
[15:33:40] <grrrit-wm>	 (03CR) 10Krinkle: [WIP] Add a clean-up script for use as a pre-commit hook (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester)
[15:35:24] <grrrit-wm>	 (03CR) 10Krinkle: [WIP] Add a clean-up script for use as a pre-commit hook (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester)
[15:40:23] <MatmaRex>	 Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=hash-mismatch
[15:40:32] <MatmaRex>	 good luck geting it fixed
[15:40:38] <Krenair>	 heh
[15:40:50] <MatmaRex>	 i failed
[16:06:41] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: External links with single brackets around it should be indicated as invalid external link inside link inspector - 10https://bugzilla.wikimedia.org/65547#c3 (10Alex Monk) Currently, the regex looks something like this (based on wgUrlProtocols):  /^bitcoin\:|ftp\:\/\...
[16:06:55] <grrrit-wm>	 (03PS1) 10Alex Monk: Wrap external URL protocols regex in brackets. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139128 (https://bugzilla.wikimedia.org/65547) 
[16:09:26] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Non-'bitcoin:' external links with single brackets around it should be indicated as invalid external link inside link inspector - 10https://bugzilla.wikimedia.org/65547 (10Alex Monk)
[16:15:24] <grrrit-wm>	 (03PS1) 10Cmcmahon: [BrowserTest] create a Template at run time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139131 
[16:16:43] <wikibugs>	 3VisualEditor: VisualEditor: Performance issues (tracker) - 10https://bugzilla.wikimedia.org/49685 (10James Forrester)
[16:16:44] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453 (10James Forrester)
[16:18:02] <chrismcmahon>	 James_F: quick question: If I create the page Template:Foo, is "Foo" available to the Template inspector immediately, or is there a delay of some sort?
[16:18:08] <James_F>	 Krenair: Nice movement on the Firefox bug. :-)
[16:18:19] <Krenair>	 yep
[16:18:25] <James_F>	 chrismcmahon: It depends on the search back-end, but yes, there's a delay in many cases.
[16:18:51] <chrismcmahon>	 James_F: delay is while the search indexes changes?
[16:19:13] <chrismcmahon>	 s/changes/updates/
[16:20:12] <James_F>	 chrismcmahon: I think so, yes.
[16:21:18] <chrismcmahon>	 thanks James_F I am fixing the last test failure for VE on a bare wiki, we have a fully working Vagrant VM with VE and browsertests today.
[16:21:41] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Non-'bitcoin:' external links with single brackets around it should be indicated as invalid external link inside link inspector - 10https://bugzilla.wikimedia.org/65547#c5 (10James Forrester) Do we need to upstream a fix for wgUrlProtocols?
[16:21:53] <James_F>	 chrismcmahon: Nice!
[16:25:49] <grrrit-wm>	 (03PS2) 10Cmcmahon: [BrowserTest] create a Template at run time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139131 
[16:27:56] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341#c4 (10Alex Monk) So now that the dependency is merged, Parsoid now recognises {{DISPLAYTITLE:stuff}} as a meta property (instead of a template), and VE provides a box on...
[16:28:56] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Non-'bitcoin:' external links with single brackets around it should be indicated as invalid external link inside link inspector - 10https://bugzilla.wikimedia.org/65547#c6 (10Alex Monk) I don't think so. I think things including the wgUrlProtocols regex should be de...
[16:31:00] <Krenair>	 James_F, hm... actually, what about updating the title displayed once the options dialog is closed?
[16:33:07] <James_F>	 Krenair: That'd be even better.
[16:33:52] <James_F>	 Krenair: We may want to think about displaytitle/defaultsort interactions (if you're changing one you may well want to change the other), but that can probably wait.
[16:36:56] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Don't let the user enter multiple consecutive spaces (except in preformatted blocks), because that's not how HTML works - 10https://bugzilla.wikimedia.org/51056#c2 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal This is going to be a pain to get the us...
[16:41:47] <Krenair>	 James_F, actually it might be easier to just do it on save
[16:42:46] <Krenair>	 MW does some weird things (CoreParserFunctions::displaytitle) to generate this :/
[16:43:36] <grrrit-wm>	 (03PS1) 10Esanders: Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 
[16:43:38] <grrrit-wm>	 (03PS1) 10Esanders: Indent demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139134 
[16:44:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Indent demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139134 (owner: 10Esanders)
[16:45:32] <MatmaRex>	 Krenair: i apologize, some of them are my fault :(
[16:50:42] <James_F>	 Krenair: Lovely.
[16:58:47] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Wrap external URL protocols regex in brackets. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139128 (https://bugzilla.wikimedia.org/65547) (owner: 10Alex Monk)
[17:01:25] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] [BrowserTest] create a Template at run time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139131 (owner: 10Cmcmahon)
[17:05:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Wrap external URL protocols regex in brackets. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139128 (https://bugzilla.wikimedia.org/65547) (owner: 10Alex Monk)
[17:05:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BrowserTest] create a Template at run time [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139131 (owner: 10Cmcmahon)
[17:14:03] <grrrit-wm>	 (03CR) 10Dduvall: "I was too late with my comment. It's a really minor point anyway." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139131 (owner: 10Cmcmahon)
[17:22:11] <mooeypo>	 edsanders, so, I just realized that there's another case where node X can go into a paragraph -- inline templates
[17:25:37] <mooeypo>	 TrevorParscal, also, unrelated, but I started working with ooui for my grad project, so I may start making random suggestions or questions on it. There are a couple of things I wish it supported
[17:29:28] <edsanders>	 Can you describe the transaction you are fixing up?
[17:30:22] <mooeypo>	 edsanders, up until now, when we insert inline images (or in our case turn a block into an image, because that's the only way atm to insert an inline image) the image was surrounded by its own paragraph
[17:30:39] <mooeypo>	 so we had inconsistencies between the wikitext and VE -- most notably in lists
[17:30:55] <edsanders>	 can you describe precisely what is happening and what you want to happen
[17:30:57] <mooeypo>	 see the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=65924
[17:31:41] <edsanders>	 from a transaction level
[17:31:44] <mooeypo>	 edsanders, instead of having the inline image be wrapped with its OWN paragraph, I want to check if the image is inside a parent that already *has* a paragraph closeby. If it does, then insert the inline image into the close paragraph
[17:32:07] <edsanders>	 i.e. the linear data before, the expected linear data, and the broken linear data we are getting now
[17:32:31] <mooeypo>	 hm
[17:32:35] <edsanders>	 mooeypo, that seems quite fudgy
[17:32:45] <mooeypo>	 Why?
[17:32:49] <edsanders>	 possibly something that shouldn't be as low level as fixUpInsertion
[17:33:29] <mooeypo>	 fixupInsertion is the one that wraps the image in its own paragraph, though. It always does for inline images which seems a bit weird, since they're *inline*. no? 
[17:33:48] <edsanders>	 So you have <p>Foo</p><blockimage/><p>Bar</p> ?
[17:33:49] <mooeypo>	 and there are other nodes that are inline too.. how is this done with inline templates? I'm trying to test now
[17:33:59] <edsanders>	 and you remove the blockimage and insert an inline image at it's offset?
[17:34:13] <mooeypo>	 edsanders, yes.
[17:34:25] <mooeypo>	 no no wait
[17:34:27] <mooeypo>	 in this case, no
[17:34:49] <mooeypo>	 wait, okay, I am getting confused myself. edsanders taking a step back, let me explain the bug instead.
[17:34:57] <edsanders>	 with html
[17:35:09] <mooeypo>	 consider a list element in wikitext * [[File:whatever.jpg]] Blah
[17:35:24] <edsanders>	 lets talk in html
[17:35:40] <mooeypo>	 this is inline image, in VE it will render as <li><p><inline image>text</p></li>
[17:36:22] <edsanders>	 ok
[17:37:58] <mooeypo>	 (one sec, I'm verifying one thing)
[17:38:33] <eranroz>	 mooeypo, hi
[17:38:57] <mooeypo>	 ok, sorry. Anyways edsanders if I make the above inline image into block, we'll have <li><p>text</p><blockimage></li>
[17:38:58] <eranroz>	 mooeypo, i think there is concensus in hewiki village pump for installing templatedata editor
[17:39:01] <mooeypo>	 which is still fine
[17:39:31] <mooeypo>	 eranroz, awesome, I think the next step is to add it to bugzilla with the consensus?
[17:39:47] <eranroz>	 mooeypo, yes
[17:40:08] <mooeypo>	 edsanders, so here's the issue: if I want to bring that image back into being an inline image, VE will do this: <li><p><inlineimage></p><p>text</p></li>
[17:40:23] <mooeypo>	 edsanders, but the wikitext will remain the same * [[File:whatever.jpg]] text
[17:40:52] <mooeypo>	 edsanders, so I'm trying to see if the image is inside a node that *already* has a paragraph within it, add the inline image into the existing paragraph instead of wrapping it with its own
[17:40:54] <edsanders>	 ok, so if the list item wasn't there that would make sense
[17:41:03] <mooeypo>	 edsanders, not sure about that either
[17:41:26] <edsanders>	 if you started with <blockimage><p>foo</p> and converted it to inline
[17:41:30] <mooeypo>	 consider this wikitext: [[File:whatever.jpg|thumb]]Text text
[17:41:50] <edsanders>	 you'd probably want <p><inlineimage></p><p>Foo<p>
[17:42:11] <edsanders>	 If you think in wikitext you're going to have a bad time
[17:42:26] <mooeypo>	 not in the above case. If we have the above thumb and we transform it into block, it's reasonable to assume we actually want the result to be <p><inlineimage>Text text</p>
[17:42:38] <mooeypo>	 Bring the image back into the paragraph it "belongs to"
[17:42:55] <mooeypo>	 s/transform it into block/transform it into inline
[17:43:21] <edsanders>	 Well no, because it renders as two separate lines. Someone using VE doesn't know about wikitext whitespace
[17:43:27] <mooeypo>	 eranroz, want me to add the bugzilla thing, or can you?
[17:43:52] <edsanders>	 what if the wikitext was <blockimage> \n\n Foo ? that would convert to the same DM HTML
[17:44:13] <edsanders>	 we can't let wikitext whitespace affect functionality
[17:44:19] <eranroz>	 mooeypo, i will
[17:44:50] <mooeypo>	 edsanders, sure, I gave the wikitext example as a way to demonstrate the image belongs to the paragraph, but I think that in general if you added an image into the document in an existing paragraph (and that's how we allow users to do it now, we add the image where their cursor's at) then making the image inline should bring it into the paragraph it was inserted to
[17:45:05] <mooeypo>	 edsanders, right now we can't insert inline images directly; users need to insert a block and then transform it into inline
[17:45:16] <edsanders>	 if it's block we don't know what paragraph if was inserted into
[17:45:25] <edsanders>	 if it's between two paragraphs it could've been either
[17:45:49] <edsanders>	 or neither, it could've been drag-dropped there
[17:46:02] <edsanders>	 I don't think that case is broken
[17:46:07] <edsanders>	 (the list case clear is though)
[17:46:11] <edsanders>	 *clearly
[17:46:31] <mooeypo>	 Yeah, I guess so. I think it makes more sense assuming the image belongs to whatever paragraph preceded it, but it's more of a personal user expectation (mine) than actual logic here. I see what you're saying.
[17:47:15] <mooeypo>	 Okay, so I'll concentrate on the list case only. I'm trying to see how we deal with this in the case of inserting inline templates into lists
[17:47:37] <edsanders>	 Well I don't mind you adding logic for that, but it shouldn't be at the fixUpInsertion level
[17:47:59] <mooeypo>	 which? the list case or the general paragraph case?
[17:48:05] <edsanders>	 anything in fixUpInsertion means it's _impossible_ to ever generate a transaction that does that
[17:48:17] <mooeypo>	 oh
[17:48:18] <edsanders>	 paragraph for now, possible the list case too
[17:48:42] <edsanders>	 so even if I actually intended to do something, having it in FUI will prevent it
[17:48:53] <mooeypo>	 Oh, I see what you mean.
[17:48:56] <mooeypo>	 Hm.
[17:48:56] <wikibugs>	 3VisualEditor / 3Initialisation: VisualEditor: From a cold start using debug=true, there's no indication VE is loading for a few seconds; move some init stuff further up? - 10https://bugzilla.wikimedia.org/65453#c1 (10Roan Kattouw) There are a few issues with how things are initialized. The delay until the l...
[17:49:13] <mooeypo>	 Okay, so the case of the list makes sense to be there (we have problems with multiline list items *anyways* )
[17:49:21] <edsanders>	 well....
[17:49:31] <mooeypo>	 so adding a paragraph to an inline image inside a list is impossible at the moment anyways
[17:49:34] <edsanders>	 having two paragraphs in a list is fine in html
[17:49:38] <edsanders>	 just not wikitext
[17:49:47] <mooeypo>	 parsoid's not quite doing that yet though
[17:49:48] <edsanders>	 so really it's a property of MWListItem (which doesn't exist)
[17:50:06] <edsanders>	 we do have some MW extensions of core nodes
[17:50:15] <mooeypo>	 oh, I see what you're saying.
[17:50:16] <edsanders>	 which we use to 'suggest' good HTML practices
[17:50:35] <mooeypo>	 edsanders, but wait, even outside of MW, isn't it more logical to *not* wrap the image in paragraph inside the list?
[17:50:40] <edsanders>	 such as MWHeadingNode, which says a heading should only have a Document as its parent
[17:50:53] <RoanKattouw>	 mooeypo: Re hewiki stuff, if you want you can write the patch for that, against the operations/mediawiki-config repo. If not, you can get James to do it
[17:51:10] <mooeypo>	 RoanKattouw, I have no idea how to do that?
[17:51:16] <edsanders>	 mooeypo, it's the same argument as outside a list
[17:51:29] <edsanders>	 but you could say that lists should only contain one paragraph in core too
[17:51:35] <RoanKattouw>	 mooeypo: Edit wmf-config/InitialiseSettings.php in that repo, look for TemplateDataGUI, add 'hewiki' => true
[17:51:42] <edsanders>	 due to the behaviour of the enter key
[17:51:45] <RoanKattouw>	 The config format is pretty easy to understand once you see it
[17:52:01] <mooeypo>	 edsanders, not sure, I think lists are different, most times you'd expect a user to want non multiline lists, but I accept this more of a discussion than a fact of life.
[17:52:31] <mooeypo>	 edsanders, yeah I think it makes more sense intuitively, but I can live without that, I can see merit in both cases.
[17:53:11] <James_F>	 mooeypo: Ha.
[17:53:24] <James_F>	 RoanKattouw, mooeypo: Already done.
[17:53:30] <mooeypo>	 oh, whee!
[17:53:31] <James_F>	 https://gerrit.wikimedia.org/r/139155
[17:53:43] <mooeypo>	 James_F, thanks!
[17:53:54] * James_F didn't see the discussions, sorry.
[17:54:05] <James_F>	 Got pinged by the bug, did the change, then came here to mention it to mooeypo. :_)
[17:54:08] <eranroz>	 James_F, thanks :)
[17:54:16] <mooeypo>	 yay :D
[17:54:30] <mooeypo>	 eranroz, and thanks for the help with the process and on-wiki :)
[17:54:59] <James_F>	 eranroz: Happy to help.
[17:55:02] <edsanders>	 mooeypo, so we have been meaning for a while to sort out multiple paragraphs in lists
[17:55:34] <edsanders>	 we need to still support them incase they are supplied as html
[17:57:12] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Quickly clicking on "Apply Changes" button multiple times on Media Settings throws console error and cannot make any more changes to any media settings dialog after that - 10https://bugzilla.wikimedia.org/66389#c3 (10ryasmeen) Verified the fix on Betalabs
[17:57:17] <edsanders>	 not sure if you can solve both problems in one go though
[17:59:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf9] Hovering over a context menu is not highlighting the entire context menu - 10https://bugzilla.wikimedia.org/66444#c2 (10ryasmeen) Verified the fix in Betalabs
[18:01:28] <mooeypo>	 edsanders, yeah, supporting them in wikitext cases might result in dirty diff
[18:01:58] <mooeypo>	 I think in the case of this specific bug fix, transforming a block image that's inside an <li> into an image in the existing paragraph is reasonable.
[18:02:59] <mooeypo>	 edsanders, multiline list items can come in the case where the user intends them, so if the image goes into the paragraph, the user can intentionally hit shift-enter and we have the more "normal" case of multiline (and we can be sure then that the user intended it on purpose)
[18:03:16] <edsanders>	 so for that case I don't think it's unreasonable when doing the conversion to inline to make sure you are inserting into a content offset
[18:03:26] * mooeypo nods
[18:03:42] <mooeypo>	 edsanders, btw, is it possible to force/mark a <br /> ? 
[18:04:08] <mooeypo>	 that too will solve the bug at least in terms of the difference between wikitext and VE's presentation. Though I think that's less optimal as a fix
[18:04:10] <edsanders>	 I don't think we do much with <br />s
[18:05:27] <wikibugs>	 3VisualEditor / 3Data Model: VisualEditor: Non-'bitcoin:' external links with single brackets around it should be indicated as invalid external link inside link inspector - 10https://bugzilla.wikimedia.org/65547 (10James Forrester) 5PATC>3RESO/FIX
[18:07:36] <mooeypo>	 hm.
[18:08:06] <mooeypo>	 edsanders, okay, so what should we do in the case of lists, then? should we keep it in core and assume general non-multiline behavior unless the user specifies otherwise, or move it to mw or anywhere else?
[18:14:04] <edsanders>	 I think it's okay to do it in every case where we convert from block to inline
[18:15:29] <wikibugs>	 3VisualEditor / 3Editing Tools: Inspector of FocusNodes with embedded menu should not be embedded per se - 10https://bugzilla.wikimedia.org/66542 (10Oliver Buchtala) 3UNCO p:3Unprio s:3normal a:3None Currently, if the menu for a FocusNode gets embedded, this also happens for the Inspector. It would b...
[18:15:50] <edsanders>	 as that's the case where we try to insert inline content and a non-content offset
[18:16:09] * mooeypo nods
[18:16:52] <mooeypo>	 edsanders, do we have an indication of inline'ness though? just can have children/content which doesn't seem to be a good indicator here in the case of images
[18:17:06] <edsanders>	 so 1) remove block image, 2) find nearest content offset 3) insert inline there
[18:17:38] <edsanders>	 RoanKattouw, thoughts
[18:18:30] <RoanKattouw>	 edsanders: Summary?
[18:19:50] <edsanders>	 so you have <li><p>foo</p><blockimage></li>
[18:19:58] <edsanders>	 and you want to convert blockimage to inlineimage
[18:20:17] <edsanders>	 normally you'd remove and get <li><p>foo</p>|</li>
[18:20:23] <mooeypo>	 edsanders, yes, but only in case of list; and I thought that's what I was doing (except for the problems with mwInlineImage being in fixupInsertion etc) ? or was I going at it wrong?
[18:20:26] <edsanders>	 then when you try to insert, FUI wraps a new paragraph
[18:20:44] <edsanders>	 I think we can have this logic for non-list cases too
[18:21:33] <mooeypo>	 Can we ? Didn't we say we can't know which "nearest" paragraph to insert to in the case of outside a list item though? 
[18:21:41] <mooeypo>	 Also, you made a good point about drag/drop
[18:22:45] <edsanders>	 We don't, which means that as it is, the logic isn't broken for a normal paragraph case
[18:23:26] <mooeypo>	 oh, so what did you mean about having this logic for non-list cases?
[18:23:51] <edsanders>	 <p>Foo</p><blockimage><p>Bar</p>
[18:24:13] <RoanKattouw>	 edsanders: Isn't FUI supposed to adjust the insertion offset in that case?
[18:24:15] <edsanders>	 if it makes our lives easier in the list case, it would be ok if we pick one of Foo/Bar paragraphs to marged the inline image into
[18:24:36] <edsanders>	 RoanKattouw, I think that's a slightly different case
[18:24:41] <RoanKattouw>	 Like, if you do <p>Foo</p>|  and insert inline stuff at |, aren't we supposed to be moving the insertion point?
[18:24:51] <edsanders>	 hmm
[18:25:36] * edsanders looks at FUI test cases
[18:26:55] <Krenair>	 Ew, just triggered another snowman somehow
[18:27:55] <RoanKattouw>	 Maybe it's only if you insert before, not after?
[18:28:44] <edsanders>	 the case we test for is <ul>|<li><p>Foo</p></li></ul> insert <p>Bar</p>
[18:28:55] <edsanders>	 that shifts the insertion left one
[18:29:16] <RoanKattouw>	 Oh, so is moving the insertion offset to do with child type restrictions rather than inline/block restrictions
[18:29:18] <RoanKattouw>	 ?
[18:29:27] <Krenair>	 Move your cursor anywhere in the document and select nothing, then open the link inspector, set target anywhere. Click back to the document in the same position, press any key
[18:29:39] <Krenair>	 ♙
[18:29:41] <RoanKattouw>	 That's a pawn
[18:29:44] <RoanKattouw>	 Is there a JS error in the console?
[18:29:49] <Krenair>	 oh yeah
[18:30:00] <Krenair>	 Don't think so...
[18:30:05] <Krenair>	 Nope
[18:30:39] <Krenair>	 (Just found on officewiki, didn't check master)
[18:30:41] <RoanKattouw>	 Hmm I feel like we've had this bug before
[18:30:54] <Krenair>	 Regressions? In VE? :P
[18:30:54] <mooeypo>	 I thought we fixed that bug..
[18:32:45] <edsanders>	 RoanKattouw, yup
[18:33:27] <wikibugs>	 3VisualEditor / 3Editing Tools: Inspector of FocusNodes with embedded menu should not be embedded per se - 10https://bugzilla.wikimedia.org/66542#c1 (10Oliver Buchtala) ... or better:  /**  * @returns {boolean}  */ Inspector.prototype.isEmbeddable = function() {   return true; };  A custom inspector can then...
[18:33:35] <mooeypo>	 RoanKattouw, edsanders the insertion seems to work perfectly for inline templates inside lists
[18:33:49] <mooeypo>	 we need to make inline image act the same.
[18:34:03] <edsanders>	 mooeypo, when converting from a block?
[18:34:38] <mooeypo>	 edsanders, I didn't check about conversion, but on insertion
[18:34:57] <edsanders>	 insertion isn't the problem
[18:35:00] <mooeypo>	 wait.. okay, I see what you mean here
[18:35:14] <mooeypo>	 and then I can just fix this in the model if that's the case
[18:35:17] <mooeypo>	 if we're inside a list, insert at different offset.
[18:37:18] <RoanKattouw>	 Krenair: I get different behavior: the first character is selected and overwritten by the second character
[18:37:35] <RoanKattouw>	 This is if I open the link inspector on an empty line, click back there, then type
[18:40:11] <RoanKattouw>	 The inspector also fails to close in that case
[18:45:16] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 
[18:48:52] <Krenair>	 RoanKattouw, yeah, I see that behaviour on master
[18:49:03] <RoanKattouw>	 Right
[18:49:06] <RoanKattouw>	 Could you file a bug about that?
[18:49:24] <Krenair>	 ok
[18:51:01] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 
[18:53:35] <Krenair>	 RoanKattouw, hang on, did you set the target? 
[18:53:45] <Krenair>	 (of the link)
[18:53:56] <wikibugs>	 3VisualEditor / 3Editing Tools: Inspector of FocusNodes with embedded menu should not be embedded per se - 10https://bugzilla.wikimedia.org/66542#c2 (10Oliver Buchtala) (In reply to Oliver Buchtala from comment #1)  Maybe it could look like this:  https://github.com/oliver----/VisualEditor/commit/26baf0bf57f...
[18:54:50] <Rosencrantz>	 How is VE re-displaying the page after a save? I'm using HeaderTabs and it's not displaying immediately after save (although it does after a reload).
[18:55:29] <Krenair>	 Rosencrantz, VE updates the page content when saving based on the information it gets back from its API call
[18:55:44] <Krenair>	 It may not work with other extensions/gadgets, and even some core features aren't handled currently
[18:56:33] <Rosencrantz>	 Ah, so it's saving, and then updating the page content without a reload after the save?
[18:56:34] <mooeypo>	 hm. Isn't test2 updated with master every few minutes?
[18:56:53] <Krenair>	 RoanKattouw, I managed to reproduce the pawn on master... Not quite sure what I did differently this time.
[18:57:02] <Krenair>	 Rosencrantz, yes, no reload.
[18:57:08] <Rosencrantz>	 ok, thanks.
[18:57:16] <Krenair>	 Rosencrantz, what is HeaderTabs?
[18:57:17] <mooeypo>	 James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=66353 <-- the patch for this was merged on the 10th, it's fixed in master, but it's not fixed in test2... that makes sense?
[18:57:44] <Rosencrantz>	 It's an extension that uses javascript to put tabs into a pages based on first level headers
[18:58:57] <wikibugs>	 3VisualEditor / 3Editing Tools: Inspector of FocusNodes with embedded menu should not be embedded per se - 10https://bugzilla.wikimedia.org/66542#c3 (10Oliver Buchtala)  (In reply to Oliver Buchtala from comment #2)  > https://github.com/oliver----/VisualEditor/commit/ > 26baf0bf57fb3fb23ce7ae5971b25f29ac818...
[18:59:10] <Rosencrantz>	 It's useful for large pages or to split up content some without putting into a different page.
[19:03:27] <RoanKattouw>	 mooeypo: No it is not
[19:03:30] <RoanKattouw>	 It's on wmf9
[19:03:35] <RoanKattouw>	 beta labs is the one that's updated from master
[19:04:26] <RoanKattouw>	 Or rather, it will be on wmf9 soon, when Sam is done with the update
[19:04:29] <mooeypo>	 oh bah, sorry, that was a brainfart moment. 
[19:04:42] <mooeypo>	 and after you *explained* it to me last week! I walk away in shame now.
[19:10:41] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 
[19:11:18] <Krenair>	 Sigh
[19:11:25] <Krenair>	 Sometimes I get a pawn, sometimes it's just highlighted.
[19:13:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Move language functions to the platform (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 (owner: 10Esanders)
[19:13:52] <Krenair>	 RoanKattouw, also if you end up with this highlighted character, undo and redo, you get a pawn
[19:14:01] <grrrit-wm>	 (03CR) 10Catrope: [BREAKING CHANGE] Move language functions to the platform (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 (owner: 10Esanders)
[19:14:04] <RoanKattouw>	 ha
[19:14:11] <RoanKattouw>	 I wrote something to fix this in November
[19:14:20] <RoanKattouw>	 It had something to do with handling focus events and closing inspectors
[19:14:34] <RoanKattouw>	 However, Ed rewrote handling of focus events and Trevor rewrote closing inspecotrs
[19:14:42] <RoanKattouw>	 So who knows how much of that still works
[19:16:14] <wikibugs>	 3VisualEditor: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None * Move your cursor anywhere in the document, don't select anything. * Open the link insp...
[19:16:35] <Krenair>	 RoanKattouw, sigh. So I just did it again
[19:17:01] <Krenair>	 New link, random target, then type one character for the text. Pawn appears
[19:17:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor:  Make it possible to click on a link or URL that's inside a template (to open the link in another tab) - 10https://bugzilla.wikimedia.org/66549 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None There are a lot of templates that create or display links to...
[19:17:27] <grrrit-wm>	 (03PS1) 10Jforrester: Provide a script to automatically list recent commits for pre-deployment review [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139174 
[19:17:55] <Krenair>	 In addition to the highlighted char
[19:17:57] <wikibugs>	 3VisualEditor: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548#c1 (10Roan Kattouw) Additionally, if you put your cursor in a block slug, open the link inspector in creation mode, and click back into the sur...
[19:19:26] <wikibugs>	 3VisualEditor: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548#c2 (10Alex Monk) Sometimes I've managed to get this to create a pawn character at the same time as making the highlighted text. Appears to be t...
[19:25:35] <grrrit-wm>	 (03PS2) 10Esanders: [BREAKING CHANGE] Move language functions to the platform [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 
[19:26:35] <grrrit-wm>	 (03CR) 10Esanders: [BREAKING CHANGE] Move language functions to the platform (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 (owner: 10Esanders)
[19:27:24] <grrrit-wm>	 (03PS2) 10Esanders: Implement new language platform functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 
[19:28:04] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Provide a script to automatically list recent commits for pre-deployment review (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139174 (owner: 10Jforrester)
[19:28:18] <grrrit-wm>	 (03PS1) 10Esanders: Update eg-iframe with build script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139180 
[19:28:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update eg-iframe with build script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139180 (owner: 10Esanders)
[19:29:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement new language platform functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:29:27] <grrrit-wm>	 (03PS2) 10Jforrester: Provide a script to automatically list recent commits for pre-deployment review [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139174 
[19:29:48] <grrrit-wm>	 (03PS4) 10Trevor Parscal: [WIP] Add navigation widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/139165 
[19:29:51] <grrrit-wm>	 (03CR) 10Jforrester: Provide a script to automatically list recent commits for pre-deployment review (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139174 (owner: 10Jforrester)
[19:30:50] <edsanders>	 James_F, the ve pull through script should run grunt build to avoid https://gerrit.wikimedia.org/r/139180
[19:31:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update eg-iframe with build script [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139180 (owner: 10Esanders)
[19:31:37] <James_F>	 edsanders: That's what the pre-commit hook we're writing will do, but yes.
[19:31:50] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Implement new language platform functions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:32:12] <James_F>	 edsanders: Also, thanks for noticing and fixing that. Normally I have to do it. :-)
[19:32:21] <grrrit-wm>	 (03CR) 10Catrope: Implement new language platform functions (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:33:52] <grrrit-wm>	 (03CR) 10Catrope: "Never mind the jsduck failure, it's because the VE core version isn't merged and pulled through yet." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:33:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Implement new language platform functions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:34:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Provide a script to automatically list recent commits for pre-deployment review [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139174 (owner: 10Jforrester)
[19:35:18] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Move language functions to the platform [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 (owner: 10Esanders)
[19:36:14] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (356f325) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139183 
[19:36:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Provide a script to automatically list recent commits for pre-deployment review [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139174 (owner: 10Jforrester)
[19:36:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: [BREAKING CHANGE] Move language functions to the platform [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139097 (owner: 10Esanders)
[19:37:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (356f325) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139183 (owner: 10Catrope)
[19:39:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (356f325) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139183 (owner: 10Catrope)
[19:41:14] <grrrit-wm>	 (03PS3) 10Catrope: Update VE core submodule to master (4d919d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:42:37] <grrrit-wm>	 (03PS4) 10Catrope: Update VE core submodule to master (4d919d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:43:07] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4d919d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:44:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Add inline images into existing paragraphs (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139064 (https://bugzilla.wikimedia.org/65924) (owner: 10Mooeypoo)
[19:45:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (4d919d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139098 (owner: 10Esanders)
[19:46:37] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Fix alien demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139111 (owner: 10Esanders)
[19:48:55] <mooeypo>	 RoanKattouw, edsanders so what are we deciding regarding inline images in paragraphs in lists? should I fix the patch to match our concerns (add static property,etc) or do we want to go at it with a different strategy per our discussion?
[19:49:49] <edsanders>	 well I'm sticking with my suggestion which would put the code in the image dialog, but RoanKattouw hasn't expressed an opinion yet..
[19:50:01] <RoanKattouw>	 I think it should be in the image dialog too
[19:50:14] <RoanKattouw>	 We've talked about how we want the logic to be nicer in general
[19:50:17] <TrevorParscal>	 Krenair: fyi, you don't need to use deferMsg if you are working inside of a method, especially an instance method, it's only there to avoid loading order issues when declaring things statically
[19:50:26] <RoanKattouw>	 Like, we should find a place for the image where it doesn't randomly split a paragraph
[19:50:38] <RoanKattouw>	 The trickier part is also doing this for drag-and-drop
[19:51:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Alien node styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139112 (owner: 10Esanders)
[19:51:30] <mooeypo>	 okay, so I'll abandon the ve-core patch and work on putting this logic in the image model instead, when we're converting between block and image nodes
[19:51:36] <mooeypo>	 we can always revisit more general cases later?
[19:51:46] <RoanKattouw>	 Yeah sounds good
[19:51:48] <edsanders>	 RoanKattouw, I don't understand https://gerrit.wikimedia.org/r/#/c/139111/1/modules/ve/dm/nodes/ve.dm.AlienNode.js
[19:52:04] <RoanKattouw>	 edsanders: Are you familiar with registerExtensionSpecificType in ve.dm.ModelRegistry and how it's used by VE-MW?
[19:52:20] <edsanders>	 I've heard of it
[19:52:27] <edsanders>	 but not why it's necessary
[19:52:39] <RoanKattouw>	 In VE-MW we do ve.dm.modelRegistry.registerExtensionSpecificType( /^mw:/ );
[19:52:44] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Gallery and Math inspector closes with an animation from right to left after clicking on "<" to close them - 10https://bugzilla.wikimedia.org/66552 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce:  1.Open a page with VE 2.Open the gallery...
[19:52:56] <RoanKattouw>	 This causes ModelRegistry to be stricter with RDFa type matching when mw: types are involved
[19:53:15] <RoanKattouw>	 Specifically, anything with an mw: type is alienated unless that type is matched
[19:53:47] <Krenair>	 TrevorParscal, okay. Where did I do that?
[19:53:58] <TrevorParscal>	 confirm dialog, don't worry, i'm working on it
[19:54:12] <TrevorParscal>	 its getting cleaned up in my dialog mayhem of doom commit
[19:55:30] <edsanders>	 so what's wrong with an unregistered extension?
[19:56:08] <RoanKattouw>	 Well it's just that we already have a mechanism for "types matching this regex should be alienated unless proven otherwise"
[19:56:37] <RoanKattouw>	 Which we could use for the demo (and only for the demo), rather than encoding it into the definition of AlienNode
[19:56:39] <edsanders>	 except in core we have no registered extension
[19:57:06] <RoanKattouw>	 No, that's why they're called extensions
[19:57:14] <edsanders>	 so what do you suggest?
[19:57:22] <RoanKattouw>	 Basically what I'm saying is, if we register this ve:Alien thing in demo.js, then its scope is limited to the demo
[19:57:26] <RoanKattouw>	 and it doesn't pollute core
[20:01:41] <edsanders>	 so I considered that maybe it isn't necessarily demo code
[20:02:14] <edsanders>	 people generating documents for SA my very well want to mark some code as alienated
[20:02:41] <RoanKattouw>	 Right
[20:03:05] <RoanKattouw>	 OK, fine
[20:03:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "Approving after IRC discussion with Ed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139111 (owner: 10Esanders)
[20:04:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix alien demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139111 (owner: 10Esanders)
[20:05:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Alien node styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139112 (owner: 10Esanders)
[20:05:20] <RoanKattouw>	 urgh
[20:05:30] <RoanKattouw>	 Krinkle|detached: One of the npm backends is broken, see e.g. https://integration.wikimedia.org/ci/job/VisualEditor-npm/1765/console
[20:05:40] <RoanKattouw>	 integration-slave1003
[20:05:49] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Alien node styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139112 (owner: 10Esanders)
[20:07:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Alien node styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139112 (owner: 10Esanders)
[20:42:26] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Trevor should review and +2." [oojs/ui] - 10https://gerrit.wikimedia.org/r/139094 (owner: 10Esanders)
[20:50:21] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Indent demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139134 (owner: 10Esanders)
[21:01:11] <grrrit-wm>	 (03PS3) 10Jforrester: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 
[21:01:44] <grrrit-wm>	 (03CR) 10Jforrester: Add a clean-up script for use as a pre-commit hook (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester)
[21:06:36] <edsanders>	 RoanKattouw, so fixUpInsertion knows when it has wrapped your insertion
[21:06:43] <edsanders>	 (openingStack.length)
[21:06:56] <edsanders>	 but how can we get that data out of there?
[21:07:45] <edsanders>	 store it as a transaction property?
[21:08:05] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "This looks a lot better than before, but I think it could be improved. I'm sorry I wasn't able to give this advice earlier; it was only re" (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 (owner: 10Alex Monk)
[21:08:22] <RoanKattouw>	 edsanders: I was thinking about that earlier
[21:08:53] <RoanKattouw>	 For moved insertion offsets, I lucked out because the new insertion range can be derived from the operations themselves
[21:09:00] <edsanders>	 we can add a property ('originalDataOffset') to the FUI result
[21:09:18] <RoanKattouw>	 But I think it could also be nice to indicate which parts of the data were actually passed to the builder and which were added by it
[21:09:42] <RoanKattouw>	 cscott was in the office around this time and I was going to talk to him about his idea for using intents in transactions, but that never happened
[21:11:19] <edsanders>	 RoanKattouw, do we ever remove from the original data?
[21:11:56] <RoanKattouw>	 I don't think we do?
[21:12:06] <RoanKattouw>	 I was thinking the exact same thing
[21:12:12] <RoanKattouw>	 And I was going to audit the code to check
[21:12:14] <RoanKattouw>	 but I never did
[21:12:42] <edsanders>	 so it is as simple as if you insert 'X' you will get back insert:[A]X[B] as the operation
[21:13:09] <RoanKattouw>	 I think that's the case but I'm not fully confident there isn't some edge case
[21:13:27] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222#c11 (10ryasmeen) 5RESO/FIX>3REOP This i...
[21:14:13] <edsanders>	 looking at the code that looks correct
[21:14:26] <edsanders>	 well - the non-removal part at least
[21:15:03] <edsanders>	 we iterate over original data, and always call writeElement( data[i], i );
[21:15:20] <RoanKattouw>	 Right
[21:15:23] <edsanders>	 the only problem case is if we insert data inside 'X'
[21:15:24] <RoanKattouw>	 And we never skip a single data[i] ?
[21:16:28] <edsanders>	 the only 'continue' is for unattached unicode combining marks
[21:16:44] <edsanders>	 so no
[21:16:46] <RoanKattouw>	 Holy crap we filter those?
[21:17:41] <edsanders>	 yeah, it's left over from when we had the more complex unicode model
[21:17:41] <wikibugs>	 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341#c5 (10Alex Monk) Yeah it's actually kind of a pain to do that. Let's update it on save.
[21:18:15] <edsanders>	 but it would only affect an external copy-paste
[21:18:36] <grrrit-wm>	 (03PS1) 10Alex Monk: Update displaytitle on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139205 (https://bugzilla.wikimedia.org/50341) 
[21:20:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update displaytitle on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139205 (https://bugzilla.wikimedia.org/50341) (owner: 10Alex Monk)
[21:20:31] <InezK>	 Do you guys know how index.html.template for tests is generated?
[21:20:41] <InezK>	 If you crate new *.test.js file, how it gets added there?
[21:20:59] <RoanKattouw>	 InezK: A human adds it
[21:21:08] <InezK>	 human? what's that
[21:21:30] <InezK>	 sudo npm install human
[21:21:42] <grrrit-wm>	 (03PS2) 10Alex Monk: Update displaytitle on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139205 (https://bugzilla.wikimedia.org/50341) 
[21:21:43] <RoanKattouw>	 InezK: You forgot -g ;)
[21:23:18] <grrrit-wm>	 (03PS1) 10Catrope: *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139207 (https://bugzilla.wikimedia.org/66222) 
[21:24:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798#c3 (10James Forrester) a:3Alex Monk As a start, maybe add the (?) icon next to each of the page settings controls so we can give some blurb for...
[21:24:24] <edsanders>	 RoanKattouw, InezK no, tests files are defined in modules.json now
[21:24:32] <RoanKattouw>	 Oh?
[21:24:38] <RoanKattouw>	 Or is "now" in an unmerged commit
[21:24:56] <RoanKattouw>	 (Sorry, I don't know why I'm being so sarcastic today)
[21:24:58] <edsanders>	 master
[21:25:00] <edsanders>	 <!DOCTYPE html>
[21:25:00] <edsanders>	 <html>
[21:25:00] <edsanders>	 	<head>
[21:25:00] <edsanders>	 		<meta charset="utf-8">
[21:25:00] <edsanders>	 		<title>VisualEditor Tests</title>
[21:25:01] <edsanders>	 		<!-- STYLES -->
[21:25:02] <RoanKattouw>	 hah
[21:25:03] <edsanders>	 	</head>
[21:25:05] <edsanders>	 	<body>
[21:25:07] <edsanders>	 		<div id="qunit"></div>
[21:25:09] <edsanders>	 		<div id="qunit-fixture">test markup</div>
[21:25:13] <edsanders>	 		<!-- SCRIPTS -->
[21:25:15] <edsanders>	 	</body>
[21:25:17] <edsanders>	 </html>
[21:25:52] <edsanders>	 RoanKattouw, (Back to FUI) looking through the test cases, none of them modify the original insertion data, just padding
[21:26:13] <InezK>	 oh right
[21:26:13] <InezK>	 https://github.com/wikimedia/VisualEditor-VisualEditor/blob/master/build/modules.json
[21:28:29] <edsanders>	 merged a whole month ago
[21:28:41] <edsanders>	 just add to modules.json and run 'grunt build'
[21:28:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Provide a way for users to insert variable magic words - 10https://bugzilla.wikimedia.org/49996#c1 (10James Forrester) a:3Alex Monk Feel like taking this on? It'd be a step towards fixing bug 50855 in general… Big fun challenge. :-)
[21:28:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Transclusions editor should have a special mode for Parser Function and Magic Word calls - 10https://bugzilla.wikimedia.org/50855 (10James Forrester)
[21:28:46] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Create a sensible system for adding Babel boxes (parser functions) - 10https://bugzilla.wikimedia.org/62740 (10James Forrester)
[21:29:07] <RoanKattouw>	 edsanders: That's encouraging. Is there any code that looks like it might try to insert in the middle?
[21:29:13] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Transclusions editor should have a special mode for Parser Function and Magic Word calls - 10https://bugzilla.wikimedia.org/50855 (10James Forrester)
[21:29:14] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Create a sensible system for adding Babel boxes (parser functions) - 10https://bugzilla.wikimedia.org/62740 (10James Forrester) a:3Alex Monk
[21:29:38] <InezK>	 thanks guys
[21:30:56] <grrrit-wm>	 (03CR) 10Catrope: [C: 032 V: 032] *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139207 (https://bugzilla.wikimedia.org/66222) (owner: 10Catrope)
[21:31:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Console shows "TypeError: jQuery_xxxxx is not a function" when cross-domain ajax request is aborted - 10https://bugzilla.wikimedia.org/59604 (10James Forrester) a:3Alex Monk
[21:31:29] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Add support for <blockquote>s - 10https://bugzilla.wikimedia.org/51009 (10James Forrester) a:3Ed Sanders
[21:31:41] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Add support for <blockquote>s - 10https://bugzilla.wikimedia.org/51009 (10James Forrester) s:5minor>3enhanc
[21:31:51] <grrrit-wm>	 (03PS1) 10Catrope: Update submodule for cherry-pick of I7d2f2f28a7 [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139211 
[21:34:31] <Krenair>	 James_F, meh, FF patch got backed out
[21:34:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Allow replacing file by changing the file name - 10https://bugzilla.wikimedia.org/52580#c2 (10James Forrester) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 51033 ***
[21:34:50] <James_F>	 Krenair: Boo. :-(
[21:34:56] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Ability to switch image used whilst maintaining the caption and other settings - 10https://bugzilla.wikimedia.org/51033#c2 (10James Forrester) *** Bug 52580 has been marked as a duplicate of this bug. ***
[21:36:42] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Indent buttons should be used for in-/out-denting paragraphs as well as lists. - 10https://bugzilla.wikimedia.org/48010 (10James Forrester)
[21:36:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Add support for <blockquote>s - 10https://bugzilla.wikimedia.org/51009 (10James Forrester)
[21:37:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget should recognise input text that look like urls without protocol as external links (e.g. "www.example.org/foo") - 10https://bugzilla.wikimedia.org/50360#c2 (10James Forrester) *** Bug 56490 has been marked as a duplicate of this bug. ***
[21:37:58] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Make the external link option available when a user types a valid URL pattern - 10https://bugzilla.wikimedia.org/56490#c4 (10James Forrester) 5ASSI>3RESO/DUP   *** This bug has been marked as a duplicate of bug 50360 ***
[21:38:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Demote the "New Page" part of the link inspector to below the "External link" one when inserting a link as URL pattern - 10https://bugzilla.wikimedia.org/56482 (10James Forrester) a:3Alex Monk
[21:50:34] <edsanders>	 RoanKattouw, I don't think so
[21:52:48] <Krenair>	 RoanKattouw, applyChanges needs the saving promise, so I think we must create it there...
[21:53:35] <RoanKattouw>	 applyChanges calls this.save(), right?
[21:53:38] <RoanKattouw>	 Sorry, target.save()
[21:53:47] <RoanKattouw>	 So target.save() can create the promise and return it
[21:53:52] <Krenair>	 It emits 'save', and then VPT ends up calling save()
[21:53:59] <RoanKattouw>	 Urgh
[21:54:20] <Krenair>	 We can still do this without reaching back in to the dialog
[21:54:31] <Krenair>	 applyChanges already passes the deferred through the event
[21:54:34] <Krenair>	 We just don't use it
[21:54:39] <RoanKattouw>	 Oh, hah
[21:54:48] <Krenair>	 We can set this.saveDeferred = saveDeferred; and then use that to resolve/reject
[21:54:59] <RoanKattouw>	 I would still like to reduce the event indirection there but we can do that later
[21:58:43] <grrrit-wm>	 (03PS2) 10Jforrester: Add more authors from `git shortlog -s -n` [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137951 (owner: 10Amire80)
[21:58:46] <grrrit-wm>	 (03CR) 10Jforrester: Add more authors from `git shortlog -s -n` (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/137951 (owner: 10Amire80)
[22:04:16] <mooeypoo>	 damnit,I don't understand why this doesn't work. meh.
[22:04:24] <mooeypoo>	 I'm doing the same thing I did with fixupInsertion
[22:07:27] <grrrit-wm>	 (03PS1) 10Mooeypoo: Don't create new paragraph for inline image inside list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139269 (https://bugzilla.wikimedia.org/65924) 
[22:08:06] <grrrit-wm>	 (03PS2) 10Mooeypoo: [wip] Don't create new paragraph for inline image inside list [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139269 (https://bugzilla.wikimedia.org/65924) 
[22:08:10] <mooeypoo>	 oops, forgot to 'wip' it
[22:08:54] <mooeypoo>	 RoanKattouw, do you have a second to help me?
[22:09:29] <mooeypoo>	 I am getting an error when I convert a block image into inline inside a list with the code above. "TypeError: newListNode is null" in ve.dm.Transaction
[22:09:59] <mooeypoo>	 I don't understand why.. I'm building a transaction with the offset of the paragraph -- basically what I did for fixupInsertion (moving the offset down to the child)
[22:10:02] <mooeypoo>	 and yet, errors. :\ 
[22:13:42] <mooeypoo>	 it's something with my document.
[22:13:43] <mooeypoo>	 eh.
[22:15:45] <mooeypoo>	 ha! found it.
[22:17:29] <grrrit-wm>	 (03PS3) 10Mooeypoo: Insert inline image inside list to the existing paragraph [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/139269 (https://bugzilla.wikimedia.org/65924) 
[22:18:57] <InezK>	 edsanders: do execute with grunt all the VE tests now? even the MW specific ones?
[22:19:52] <edsanders>	 MW still runs in the browser
[22:20:07] <mooeypoo>	 edsanders, RoanKattouw new patchset for your review. I moved things to the image model.
[22:20:39] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: Add inline images into existing paragraphs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139064 (https://bugzilla.wikimedia.org/65924) (owner: 10Mooeypoo)
[22:22:52] <edsanders>	 mooeypoo, I thought we were going for "1) remove block image, 2) find nearest content offset 3) insert inline there" ?
[22:23:49] <mooeypoo>	 1 and 3 are done in that method, as for 2, I thought we said look for paragraph, but I can change.
[22:24:07] <mooeypoo>	 didn't we end up saying we'll only do this inside lists?
[22:25:25] <InezK>	 edsanders: so you don't run them somehow automatically?
[22:25:29] <InezK>	 or Jenkins somehow does?
[22:26:08] <edsanders>	 InezK, I think jenkins runs them with phantomJS
[22:26:13] <InezK>	 I see
[22:26:27] <InezK>	 but calling real mediawiki instance? not "fake" index.html?
[22:26:41] <edsanders>	 mooeypoo, I think it adds unnecessary complexity
[22:27:12] <edsanders>	 I think we have a method for finding content offsets
[22:29:22] <mooeypoo>	 edsanders, ok, i'll look into it again.
[22:29:36] <edsanders>	 getNearestContentOffset
[22:30:07] <mooeypoo>	 ah!
[22:30:22] <edsanders>	 should make things cleaner
[22:31:14] <mooeypoo>	 indeed. Thanks! I wasn't aware of this one. 
[22:45:52] <RoanKattouw>	 edsanders, InezK: There's some evilness in our Jenkins config to set up a web server that runs MW so we can then point PhantomJS to that server and run qunit
[22:46:05] <RoanKattouw>	 So you can't just run the MW tests through grunt right now
[22:46:11] <RoanKattouw>	 The VE core tests do run from grunt though
[22:50:59] <Krinkle>	 James_F: Not an npm backend issue. It would seem the actual package fetched from npmjs.org is corrupt.
[22:51:15] <Krinkle>	 Maybe the cluster had a network corruption and it somehow got a corrupt response
[22:51:23] <Krinkle>	 did it happen again since? (e.g. is it cached?)
[22:53:02] <RoanKattouw>	 Krinkle: It seems to be happening frequently but only on 1003
[22:53:03] <RoanKattouw>	 AFAICT
[22:53:18] <Krinkle>	 OK
[22:53:27] <Krinkle>	 strange, I'll look at the cache file and just nuke it
[22:53:45] <Krinkle>	 it says the node-async's module package.json is invalid json. That's kinda impossible
[22:54:00] <Krinkle>	 I mean, you can't publish to npmjs.org with an invalid file. It's validated the hell out of.
[22:54:18] <Krinkle>	 so must be on our end somewhere between that instance and npmjs.org
[22:56:26] <Krinkle>	 Weird, cat /mnt/home/jenkins-deploy/.npm/async/0.2.10/package/package.json on slave1002 is prettified
[22:56:32] <Krinkle>	 cat /mnt/home/jenkins-deploy/.npm/async/0.2.10/package/package.json on slave1003 is minified
[23:00:08] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update submodule for cherry-pick of I7d2f2f28a7 [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139211 (owner: 10Catrope)
[23:01:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update submodule for cherry-pick of I7d2f2f28a7 [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/139211 (owner: 10Catrope)
[23:01:44] <Krinkle>	 RoanKattouw: Do you know if this started with a particular change that got merged?
[23:01:45] <Krinkle>	 James_F: 
[23:01:55] <James_F>	 Krinkle: Not off the top of my head.
[23:02:59] <RoanKattouw>	 I don't think so
[23:06:01] <Krinkle>	 RoanKattouw: Filed https://github.com/npm/npm/issues/5472
[23:06:11] <Krinkle>	 will nuke 304 cache to see if that fixes it
[23:06:20] <grrrit-wm>	 (03PS9) 10Alex Monk: Port MWSaveDialog to use ActionDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/135945 
[23:08:24] <grrrit-wm>	 (03PS4) 10Krinkle: Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 (owner: 10Jforrester)
[23:08:30] <grrrit-wm>	 (03PS3) 10Krinkle: Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[23:12:57] <James_F>	 Krinkle: Can I make a start on an es5_shim RL module?
[23:13:07] <Krinkle>	 James_F: go for it :)
[23:13:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Editable blockquotes in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/134838 (https://bugzilla.wikimedia.org/51009) (owner: 10Esanders)
[23:13:52] <Krinkle>	 Hm.. intertesting, none of the mwext-VisualEditor-npm builds had this issue on 1003 right? ( James_F, RoanKattouw )
[23:13:57] <Krinkle>	 only ve core npm tests
[23:14:09] <James_F>	 Krinkle: You said there were very well known PD shims that we could just steal?
[23:14:21] <Krinkle>	 not PDF afaik, but certainly FOSS
[23:14:25] <James_F>	 Krinkle: Yeah, that sounds reasonable.
[23:14:33] <Krinkle>	 and yes, do not spend any time writing a single line of actual shim code
[23:14:48] <Krinkle>	 either pick a lib or compose it of pieces :)
[23:14:51] * James_F nods.
[23:14:55] <James_F>	 That sounds reasonable. :-)
[23:14:59] <Krinkle>	 I'd start with es5-shim.js
[23:15:24] <Krinkle>	 but it has a known stance against Object.create because there is no way to polyfill a specific edge case so they decided to not polyfill it at all.
[23:15:29] <James_F>	 Krinkle: https://github.com/es-shims/es5-shim you mean?
[23:16:02] <Krinkle>	 which we need. But only a very basic use of it. So we'll probably want to copy that out of the sham.js file (not shim) or use a simplified version of another lib for that.
[23:16:34] <grrrit-wm>	 (03PS6) 10Krinkle: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 (owner: 10Esanders)
[23:16:39] <grrrit-wm>	 (03PS11) 10Krinkle: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester)
[23:16:42] <grrrit-wm>	 (03PS2) 10Krinkle: Edit HTML mode in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139133 (owner: 10Esanders)
[23:16:46] <grrrit-wm>	 (03PS2) 10Krinkle: Indent demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/139134 (owner: 10Esanders)
[23:16:57] * Krinkle is just triggering different shit to throw at jenkins
[23:17:10] <Krinkle>	 seems to be good
[23:18:18] <Krinkle>	 also weird how all the build logs exhibit some  kind of weird colour parsing bug
[23:18:22] <Krinkle>	 half the flow text is green
[23:18:27] <James_F>	 Yeah.
[23:18:28] <Krinkle>	 (as opposed to just the '>>')
[23:38:43] <InezK>	 RoanKattouw_away: Do you know if it is a goal to be able to run all tests with grunt + phantomjs (without mediawiki)?
[23:52:38] <James_F>	 InezK: The unit tests for VE-core? Yes.
[23:52:48] <James_F>	 InezK: Or do you mean for VE-MW
[23:52:48] <James_F>	 ?
[23:53:26] <InezK>	 VE-mw
[23:53:30] <InezK>	 VE-MW
[23:54:06] <James_F>	 Ah. No, VE-MW code will always need MW, or it should be upstreamed into VE-core.
[23:54:26] <InezK>	 bummer
[23:54:35] <InezK>	 it would be nice to execute those tests without having to set up MW
[23:54:53] <InezK>	 that should be doable, and dependencie should be mocked perhaps
[23:55:07] <James_F>	 But headless phantomjs browser testing of the MW code is definitely what we're doing.
[23:56:21] <InezK>	 of MW code on MW instance