[00:07:32] RoanKattouw, Vector was the other [00:07:50] Krenair: Yay breakage. :-( [00:08:06] unfortunately VE still doesn't load for me. no errors anymore though [00:10:25] Krenair: Look at the network panel to see what the contents of the modules=ext.visualEditor.core request are [00:10:32] If there are errors it'll start with a comment describing the errors [00:10:55] edsanders: https://code.google.com/p/chromium/issues/detail?id=314291 [00:10:58] Then click New issue [00:12:33] exception 'MWException' with message 'ResourceLoaderFileModule::readStyleFile: style file not found: "/var/www/MediaWiki/Git/extensions/VisualEditor/lib/ve/modules/ve/ui/styles/ve.ui.DimensionsWidget.css"' in /var/www/MediaWiki/Git/core/includes/resourceloader/ResourceLoaderFileModule.php:715 [00:13:24] Oh, hah [00:13:28] Have you run git submodule update? [00:13:56] sigh. there was the issue [00:16:32] (03PS3) 10Jdlrobson: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 [00:41:37] (03PS1) 10Catrope: Use the correct classname in MobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126883 [00:42:02] edsanders: ---^^ [00:42:52] James_F: Or you could review that ---^^ [00:43:43] (03CR) 10Jforrester: [C: 032] Use the correct classname in MobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126883 (owner: 10Catrope) [00:45:08] (03Merged) 10jenkins-bot: Use the correct classname in MobileViewTarget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126883 (owner: 10Catrope) [00:50:33] (03PS1) 10Esanders: Restore call to dm.Surface#startHistoryTracking removed in I9f8b840c [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126885 [00:53:13] (03CR) 10Catrope: [C: 032] Restore call to dm.Surface#startHistoryTracking removed in I9f8b840c [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126885 (owner: 10Esanders) [00:54:30] (03Merged) 10jenkins-bot: Restore call to dm.Surface#startHistoryTracking removed in I9f8b840c [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126885 (owner: 10Esanders) [00:58:21] (03PS1) 10Catrope: Call stopHistoryTracking() when destroying ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126886 [01:01:23] edsanders: --^^ [01:01:40] (03CR) 10Catrope: [C: 04-1] Re-split the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:14:42] (03CR) 10Catrope: Re-split the transclusion dialog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:16:04] (03CR) 10Esanders: [C: 032] Call stopHistoryTracking() when destroying ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126886 (owner: 10Catrope) [01:17:09] (03Merged) 10jenkins-bot: Call stopHistoryTracking() when destroying ui.Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126886 (owner: 10Catrope) [01:23:25] (03PS1) 10Jforrester: Update VE core submodule to master (4366f20) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126889 [01:23:27] (03PS1) 10Jforrester: Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 [01:23:36] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (4366f20) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126889 (owner: 10Jforrester) [01:23:38] (03CR) 10Catrope: Re-split the transclusion dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:23:40] (03Abandoned) 10Jforrester: Update VE core submodule to master (4366f20) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126889 (owner: 10Jforrester) [01:23:47] (03CR) 10jenkins-bot: [V: 04-1] Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 (owner: 10Jforrester) [01:23:51] (03PS2) 10Jforrester: Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 [01:25:22] (03CR) 10jenkins-bot: [V: 04-1] Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 (owner: 10Jforrester) [01:27:08] (03PS3) 10Jforrester: Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 [01:28:36] (03CR) 10jenkins-bot: [V: 04-1] Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 (owner: 10Jforrester) [01:31:24] (03PS9) 10Catrope: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:32:32] RoanKattouw: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-doc-test/9081/console [01:34:11] (03PS10) 10Catrope: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:34:30] (03PS4) 10Jforrester: Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 [01:39:20] (03PS11) 10Catrope: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:40:18] James_F: v [01:40:21] James_F: https://gerrit.wikimedia.org/r/126869 [01:40:42] (03CR) 10Catrope: [C: 032] Check for left click and disabled state on ButtonedElements [oojs/ui] - 10https://gerrit.wikimedia.org/r/126872 (owner: 10Esanders) [01:40:56] (03CR) 10Jforrester: [C: 032] Followup 099f26ec: fix $content in FieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/126869 (owner: 10Catrope) [01:41:08] (03Merged) 10jenkins-bot: Check for left click and disabled state on ButtonedElements [oojs/ui] - 10https://gerrit.wikimedia.org/r/126872 (owner: 10Esanders) [01:41:23] (03Merged) 10jenkins-bot: Followup 099f26ec: fix $content in FieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/126869 (owner: 10Catrope) [01:44:25] (03CR) 10Catrope: [C: 032] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [01:45:02] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (9d291a9222) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126892 [01:45:25] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (9d291a9222) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126892 (owner: 10Jforrester) [01:45:56] RoanKattouw: https://gerrit.wikimedia.org/r/126893 [01:46:50] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (9d291a9222) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126892 (owner: 10Jforrester) [01:46:53] (03Merged) 10jenkins-bot: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [02:17:20] (03PS1) 10Jforrester: Sub-class MWExtensionInspector with MWLiveExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 [02:43:07] (03CR) 10Jforrester: [C: 032] Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [02:44:42] (03Merged) 10jenkins-bot: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [02:55:03] (03PS1) 10Catrope: [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126903 [02:55:05] (03PS1) 10Catrope: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126904 [02:55:07] (03PS1) 10Catrope: Only hide popups on selection change [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126905 [02:55:09] (03PS1) 10Catrope: Create ve#contains [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126906 [02:55:11] (03PS1) 10Catrope: Prevent pasteTarget selection while already selected [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126907 [02:55:13] (03PS1) 10Catrope: Make ve.dm.Surface#breakpoint not crash [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126908 [02:56:01] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126903 (owner: 10Catrope) [02:56:06] (03CR) 10Catrope: [C: 032] Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126904 (owner: 10Catrope) [02:56:08] (03CR) 10Catrope: [C: 032] Only hide popups on selection change [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126905 (owner: 10Catrope) [02:56:10] (03CR) 10Catrope: [C: 032] Create ve#contains [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126906 (owner: 10Catrope) [02:56:12] (03CR) 10Catrope: [C: 032] Prevent pasteTarget selection while already selected [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126907 (owner: 10Catrope) [02:56:14] (03CR) 10Catrope: [C: 032] Make ve.dm.Surface#breakpoint not crash [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126908 (owner: 10Catrope) [02:56:52] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126903 (owner: 10Catrope) [02:57:07] (03Merged) 10jenkins-bot: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126904 (owner: 10Catrope) [02:57:29] (03Merged) 10jenkins-bot: Only hide popups on selection change [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126905 (owner: 10Catrope) [02:57:31] (03Merged) 10jenkins-bot: Create ve#contains [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126906 (owner: 10Catrope) [02:57:33] (03Merged) 10jenkins-bot: Prevent pasteTarget selection while already selected [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126907 (owner: 10Catrope) [02:57:35] (03Merged) 10jenkins-bot: Make ve.dm.Surface#breakpoint not crash [VisualEditor/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126908 (owner: 10Catrope) [02:59:06] (03PS1) 10Catrope: Update VE core submodule for cherry-picks to make math inspector work [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126911 [03:00:12] (03CR) 10Catrope: [C: 032] Update VE core submodule for cherry-picks to make math inspector work [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126911 (owner: 10Catrope) [03:02:48] (03Merged) 10jenkins-bot: Update VE core submodule for cherry-picks to make math inspector work [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/126911 (owner: 10Catrope) [03:15:42] James_F: Mostly been catching up on e-mail and in/out of bed (jetlagged a bit). Will look trough jjb changes in a bit. [03:19:45] (03CR) 10Catrope: [C: 032] Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 (owner: 10Jforrester) [03:21:18] (03Merged) 10jenkins-bot: Allow MWExtensionInspector to be set to forced LTR status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 (owner: 10Jforrester) [03:23:22] (03CR) 10Catrope: [C: 04-1] Add checkboxes to set some metadata on page metadata panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [03:27:39] (03PS1) 10Catrope: Expose OO.ui.Window#canOpen and #canClose [oojs/ui] - 10https://gerrit.wikimedia.org/r/126915 [03:28:13] RoanKattouw: https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/1912/console [03:33:31] (03PS4) 10Jforrester: Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [03:34:52] (03Abandoned) 10Catrope: Expose OO.ui.Window#canOpen and #canClose [oojs/ui] - 10https://gerrit.wikimedia.org/r/126915 (owner: 10Catrope) [03:35:13] (03PS2) 10Jforrester: Sub-class MWExtensionInspector with MWLiveExtensionInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 [03:37:08] (03CR) 10Catrope: [C: 032] Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [03:38:52] (03Merged) 10jenkins-bot: Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [03:46:14] (03PS1) 10Jforrester: Remove Object.prototype.bind from compatibility check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 [03:47:06] (03PS2) 10Jforrester: Remove Function.prototype.bind from compatibility check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 [03:48:35] (03PS1) 10Catrope: Clear inspector fragment from teardown(), not close() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126921 [03:48:46] (03PS1) 10Jforrester: Update VE core submodule to master (83be91a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126922 [03:49:04] (03PS3) 10Catrope: Remove Function.prototype.bind from compatibility check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [03:49:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (83be91a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126922 (owner: 10Jforrester) [03:49:41] (03CR) 10jenkins-bot: [V: 04-1] Clear inspector fragment from teardown(), not close() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126921 (owner: 10Catrope) [03:52:23] (03Merged) 10jenkins-bot: Update VE core submodule to master (83be91a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126922 (owner: 10Jforrester) [03:53:41] (03PS2) 10Catrope: Clear inspector fragment from teardown(), not close() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126921 [03:56:55] (03CR) 10Catrope: [C: 04-2] Use mw.message's plain method for JSON in SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118621 (owner: 10Trevor Parscal) [05:25:00] (03CR) 10Krinkle: [C: 04-1] "Except that we are using it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [06:16:48] (03CR) 10Krinkle: "Hm.. I fixed all callers to use ve.bind a while back I think. Either way, last I checked the only reason we're not using it directly is be" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [08:17:20] (03PS1) 10Nikerabbit: Remove useless isset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126930 [09:15:46] (03CR) 10Addshore: [C: 032] Remove useless isset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126930 (owner: 10Nikerabbit) [09:17:29] (03Merged) 10jenkins-bot: Remove useless isset [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126930 (owner: 10Nikerabbit) [10:05:25] (03CR) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [10:06:43] (03PS6) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [10:06:55] (03CR) 10jenkins-bot: [V: 04-1] Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [10:14:01] (03PS7) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [11:00:01] (03CR) 10AndyRussG: "Finally got a chance to look at this, sorry for the delay. I don't see the EP namespace being included in $wgContentNamespaces anywhere. O" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [14:06:21] (03PS1) 10Nikerabbit: Add whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126983 [14:06:23] (03PS1) 10Nikerabbit: Remove getVersion from api module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126984 [14:59:05] (03PS1) 10Alex Monk: Check useeditwarning preference before showing warning when browsing away from editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126994 [16:31:29] (03PS1) 10Alex Monk: Add cancel & discard changes button to save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 [16:40:08] James_F: so, I'm changing oo.ui.GroupElement's aggregations feature (makes events emitted by child items bubble up and be emitted from the group with the item as the first parameter for context) not be a config option (which sucks because subclasses have to deep extend the config to step around each other and it's akward in general) to use a method [16:40:57] something like aggregateEvent( itemEventName, groupEventName ) or propagateItemEvent( itemEventName, groupEventName ) [16:42:27] I want to also provide a way to remove the aggregation (for completeness), so, I could either consider groupEventName being falsey as a way to turn it off, or use a new method like removeAggregateEvent or stopItemEventPropagation [16:42:40] any naming ideas? [16:42:46] these all sound crap to me [16:44:17] maybe: addAggregateItemEvent( 'select', 'selectItem' ) to set, removeAggregateItemEvent( 'select' ) [16:44:58] TrevorParscal: Hey, sorry. [16:45:10] no worries [16:45:23] I'm just talking to a wall over here! lol:) srsly, take your time man [16:45:29] :-) [16:45:35] Was not looking at IRC. [16:45:48] I'm leaning toward add/remove pattern [16:45:55] the one I suggested a few lines ago [16:46:01] A charge which has never been levelled at you. :-) [16:46:03] works well with add/remove items methods [16:46:17] Is "aggregate" the term normally used? [16:46:21] could also have clear, a la clear items [16:46:25] it's the one used now [16:46:34] maybe we could improve on that name [16:46:39] I would normally say "inherited" or something like that. [16:46:54] They're not grouped together, they actually ascend through the tree, right? [16:47:24] we are propagating the events, but not just passing them through, we are changing the event name (usually) and passing the item the event occurred on as an argument [16:47:39] Hmm. [16:47:59] So "ascendant"? [16:48:33] so, if items emit 'click', the group might aggregate all item 'click' events to an 'itemClick' event, which is similar to this.emit( 'itemClick', item, ... ) [16:48:43] ascendant seems less clear to me [16:49:21] or at least, has less of a visual for me - not so sure aggregate is good [16:49:27] propagate is ok [16:50:01] browsers use that terminology, but it has a different meaning, because the event object doesn't change it just keeps getting passed around, and the event name also stays the same [16:51:53] the form of aggregate I mean to use is the adjective: "formed or calculated by the combination of many separate units or items; total." [16:52:12] does it not come off as that? [16:52:47] ok, I will proceed, we will hash it out, if needed, in CR [16:58:33] Sorry, dragged into meeting. [16:58:51] Propagate is bad, yes. [16:58:55] It implies it doesn't change. [16:59:01] * James_F goes to KIT. [18:03:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 (owner: 10Alex Monk) [19:04:22] (03PS1) 10Trevor Parscal: Add getCurrentItem method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127120 [19:04:35] (03PS1) 10Trevor Parscal: Add aggregate method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127121 [19:15:05] James_F: this hasn't been pulled through? https://gerrit.wikimedia.org/r/#/c/126869/ [19:15:50] TrevorParscal: I think it was? [19:16:05] ok, didn't appear to be on my localhost [19:16:09] not sure [19:16:28] seems ok in prod [19:16:59] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/126892/ in VE-VE and https://gerrit.wikimedia.org/r/#/c/126893/ in MW-Core. [19:18:09] working on the issue where in citation dialog vs simple template dialog, things are visible (like titles of fieldsets) that shouldn't be [19:19:29] well... hmm - my patch that breaks the transclusion, reference and citation dialogs' content out into pages would solve this I think... [19:19:36] * TrevorParscal returns to patch of doom [19:19:44] TrevorParscal: Courage, mon brave. [19:59:08] (03PS1) 10Esanders: Add focusing state flag to ce.Surface when programatically focusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127136 [19:59:51] (03CR) 10jenkins-bot: [V: 04-1] Add focusing state flag to ce.Surface when programatically focusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127136 (owner: 10Esanders) [21:09:47] (03PS1) 10Esanders: Extension inspector directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127156 [21:10:21] (03CR) 10Esanders: Allow MWExtensionInspector to be set to forced LTR status (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126890 (owner: 10Jforrester) [21:59:06] (03CR) 10Jforrester: Extension inspector directionality (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127156 (owner: 10Esanders) [22:00:39] (03PS2) 10Jforrester: Extension inspector directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127156 (owner: 10Esanders) [22:02:22] (03PS1) 10Trevor Parscal: Remove animation of grid layout inside booklets [oojs/ui] - 10https://gerrit.wikimedia.org/r/127165 [22:02:29] (03PS1) 10Trevor Parscal: Add push/pop pending to Dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 [22:02:41] Ooh, fancy. [22:05:45] (03PS2) 10Trevor Parscal: Add push/pop pending to Dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 [22:06:24] (03PS1) 10Trevor Parscal: Disable transclusion dialog mode button while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127168 [22:06:33] (03PS1) 10Trevor Parscal: Make transclusion dialog "pending" while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127169 [22:15:00] James_F: you see it in action? [22:15:49] TrevorParscal: I skimmed the CSS and used the box model in my head. [22:16:15] It helps to add an argument like 2000 to the setTimeout toward the end of the load method in ve.dm.MWTransclusionModel [22:17:26] TrevorParscal: Show me tomorrow. When it's merged. :-) [22:17:35] Sure [22:49:05] (03CR) 10Esanders: Extension inspector directionality (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127156 (owner: 10Esanders) [22:51:54] (03CR) 10Jforrester: [C: 032] Extension inspector directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127156 (owner: 10Esanders) [22:52:18] (03PS1) 10Jforrester: Extension inspector directionality [extensions/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127174 [22:53:23] (03Merged) 10jenkins-bot: Extension inspector directionality [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127156 (owner: 10Esanders) [22:56:59] (03CR) 10Krinkle: "Also, 'static' probably fails as well." [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (owner: 10Jforrester) [23:22:25] Krinkle: Probably. Where's the ES5-checker-in-RL so we can make OOjs and OOjs UI only load on platforms where it won't break? [23:22:54] The QUnit race condition is completely gone now. Finally. [23:23:07] Yay. Great work by you and hashar. :-) [23:25:03] Krinkle: Has RoanKattouw_away talked to you about how he got the browser tests working locally? [23:25:17] Not that I know of [23:25:44] Kk. He's made good progress and wants to work out a small set that we can run in jenkins if possible. [23:26:42] k [23:34:44] James_F, okay, I am confused about mediawiki/extensions/Parsoid.git [23:35:06] Krenair: OK? [23:36:48] (03PS1) 10Esanders: Tests for ce.Surface#getNearestCorrectOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127182 [23:36:57] James_F, according to my Special:Version I'm not using it [23:37:24] Krenair: Yeah, you don't need it except for performance. [23:37:37] Krenair: mediawiki/services/parsoid.git != mediawiki/extensions/Parsoid.git [23:37:44] when I do VE stuff I just run the parsoid JS file from mediawiki/services/parsoid.git [23:37:52] Okay [23:38:11] Krenair: The first is Parsoid, the second a PHP hook that throws new pages to the service to be cached. [23:38:37] I just started looking at the source and it deals with caching and stuff, ok [23:38:42] So in https://bugzilla.wikimedia.org/show_bug.cgi?id=63983 you want to start depending on this extension..? [23:39:16] Yeah; it will probably break current Vagrant installs, good point. [23:39:38] (Boo.) [23:40:00] (03PS2) 10Esanders: Tests for ce.Surface#getNearestCorrectOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127182 [23:40:22] And then we can just set the VE RL module to depend on Parsoid's one [23:40:30] hopefully [23:40:36] That sounds plausible. [23:41:03] Longer-term the Parsoid RL module will become a skin style, I assume.