[00:11:54] (03PS2) 10Jforrester: Filter calls to selectItem and highlightItem on SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121281 (owner: 10Trevor Parscal) [00:27:14] (03PS1) 10Divec: DO NOT MERGE: Annotation tests proof of concept. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121284 [00:27:56] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE: Annotation tests proof of concept. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121284 (owner: 10Divec) [00:41:57] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e697490c9b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121289 [00:42:21] Krinkle: Please +2 https://gerrit.wikimedia.org/r/121288 and https://gerrit.wikimedia.org/r/121289 [00:42:37] Krinkle: Bug fixes and minor tweaks; no breaking changes; wanted by Multimedia in particular. [02:01:57] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (e697490c9b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121289 (owner: 10Jforrester) [02:03:37] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e697490c9b) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121289 (owner: 10Jforrester) [02:28:47] (03PS1) 10Jforrester: Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 [02:29:50] Krinkle: ^^^^ Please merge. No (known) breaking changes, lots of bug fixes, wanted out by end of today. [02:30:24] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [02:40:13] (03PS2) 10Jforrester: Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 [02:41:42] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [04:31:04] (03PS3) 10Catrope: Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [04:32:36] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [04:33:58] (03PS4) 10Catrope: Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [04:36:04] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [04:38:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (9c19df0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121293 (owner: 10Jforrester) [04:53:04] (03PS1) 10Catrope: Deal with Parsoid's protocol-relative tags in a DOMParser world [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121303 [04:56:29] (03PS2) 10Catrope: Deal with Parsoid's protocol-relative tags in a DOMParser world [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121303 [05:00:56] (03CR) 10Catrope: "To test:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121303 (owner: 10Catrope) [05:04:08] (03CR) 10Jforrester: [C: 031] Deal with Parsoid's protocol-relative tags in a DOMParser world [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121303 (owner: 10Catrope) [05:04:36] (03CR) 10Trevor Parscal: [C: 032] Deal with Parsoid's protocol-relative tags in a DOMParser world [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121303 (owner: 10Catrope) [05:05:57] (03Merged) 10jenkins-bot: Deal with Parsoid's protocol-relative tags in a DOMParser world [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121303 (owner: 10Catrope) [05:19:16] (03PS8) 10Jforrester: [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [05:19:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [08:24:45] Hi. I would like to ask one question which i couldn't find elsewhere. Is it possible to have WYSIWYG tag in standalone version? [15:50:04] (03PS5) 10Cmcmahon: [browser test] updates for no beta warning to dismiss [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120832 [16:21:45] RoanKattouw_away: if we definitely pencil in the May 10-24 timeframe for real-time collaboration work, i wonder if i/we should submit a wikimania proposal about real-time collaboration? [16:22:08] real-time editing with the plaintext editor already works with my towtruck extension, so there's a fallback even if we hit roadblocks with VE [16:24:28] (03PS6) 10Zfilipin: [browser test] updates for no beta warning to dismiss [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120832 (owner: 10Cmcmahon) [16:25:25] (03CR) 10Cmcmahon: [C: 032] "+1 from James and reviewed with Zeljko" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120832 (owner: 10Cmcmahon) [16:25:40] (03CR) 10Zfilipin: [C: 031] [browser test] updates for no beta warning to dismiss [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120832 (owner: 10Cmcmahon) [17:19:37] (03Merged) 10jenkins-bot: [browser test] updates for no beta warning to dismiss [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120832 (owner: 10Cmcmahon) [17:22:41] cscott: We could do that, I suppose [17:24:13] cscott: RTE is hard, though, from a UX perspective as well [17:24:34] So we will almost certainly not have a close-to-acceptable RTE implementation for VE by Wikimania [17:25:03] We're also not planning to make a concerted effort to attack those problems this quarter [17:25:16] So, while we could speak about RTE, it wouldn't be "look, RTE is done" [17:25:31] It would be more like "look, here's a basic proof of concept that shows the basic technology works" [17:27:56] L-x: is a MediaWiki-specific concept, so the plugin doesn't load in the standalone editor [17:28:33] But it would be possible to write something roughly like it for standalone [17:37:55] RoanKattouw: yes, the talk's purpose would partly be to surface the important UX questions. [17:38:57] Eloquence is going to be giving a talk on real time collaboration more generally, and i think he's got someone working on UX issues more generally as well. [17:39:37] RoanKattouw: so i think i could give a talk on the towtruck extension as-is, with whatever VE support it has at that point, as a focus of discussion about broader UX/community issues. [17:52:34] That seems fine [17:54:15] cscott: How are you going to make sure that you and Eloquence are talking about the same things, though? :-) [17:55:08] Eloquence has mind-control powers, didn't you know that? [17:55:37] i'm surprised he let you ask that question. ;) [17:59:35] * James_F is outside his clutches in the other side of the Bay. [17:59:55] (03PS1) 10Catrope: Move padding rules for OutlineItemWidget from core to skins. [oojs/ui] - 10https://gerrit.wikimedia.org/r/121417 [18:32:48] (03CR) 10Jforrester: [C: 032] Kill $wgVisualEditorEditNotices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121263 (owner: 10Alex Monk) [18:33:57] Krinkle: curl http://example.com | sudo tee filename [18:34:20] RoanKattouw: sudo -s; curl http://example.com > filename [18:34:26] (03CR) 10Jforrester: [C: 032] intro/outro: Keep local reference to OO inside closure [oojs/ui] - 10https://gerrit.wikimedia.org/r/119708 (owner: 10Krinkle) [18:34:40] (03Merged) 10jenkins-bot: Kill $wgVisualEditorEditNotices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121263 (owner: 10Alex Monk) [18:40:51] (03CR) 10Trevor Parscal: [C: 032] Move padding rules for OutlineItemWidget from core to skins. [oojs/ui] - 10https://gerrit.wikimedia.org/r/121417 (owner: 10Catrope) [18:41:14] (03Merged) 10jenkins-bot: Move padding rules for OutlineItemWidget from core to skins. [oojs/ui] - 10https://gerrit.wikimedia.org/r/121417 (owner: 10Catrope) [18:43:12] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e9e435be5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121427 [18:43:43] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e9e435be5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121427 (owner: 10Jforrester) [18:45:23] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e9e435be5e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121427 (owner: 10Jforrester) [18:51:32] (03CR) 10Jforrester: [C: 032] intro/outro: Keep local reference to OO inside closure [oojs/ui] - 10https://gerrit.wikimedia.org/r/119708 (owner: 10Krinkle) [18:51:54] (03Merged) 10jenkins-bot: intro/outro: Keep local reference to OO inside closure [oojs/ui] - 10https://gerrit.wikimedia.org/r/119708 (owner: 10Krinkle) [18:53:13] (03CR) 10Jforrester: [C: 032] Add documentation explaining what's going on in GroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119806 (owner: 10Catrope) [18:53:35] (03Merged) 10jenkins-bot: Add documentation explaining what's going on in GroupWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119806 (owner: 10Catrope) [19:19:49] (03PS1) 10Trevor Parscal: [CRITICAL] Add a missing period to a comment. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 [19:20:52] (03CR) 10jenkins-bot: [V: 04-1] [CRITICAL] Add a missing period to a comment. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 (owner: 10Trevor Parscal) [19:21:55] (03PS2) 10Trevor Parscal: [CRITICAL] Add a missing period to a comment. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 [19:25:09] (03PS3) 10Jforrester: Fix ClickableNode documentation comment to add a missing period. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 (owner: 10Trevor Parscal) [19:25:32] (03PS4) 10Jforrester: Fix ClickableNode documentation comment to add a missing period [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 (owner: 10Trevor Parscal) [19:25:42] (03CR) 10Jforrester: [C: 032] Fix ClickableNode documentation comment to add a missing period [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 (owner: 10Trevor Parscal) [19:27:45] (03Merged) 10jenkins-bot: Fix ClickableNode documentation comment to add a missing period [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121435 (owner: 10Trevor Parscal) [20:05:52] (03Abandoned) 10Krinkle: [WIP] Implement MWTemplateDialog (simplified MWTransclusionDialog) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/107275 (owner: 10Krinkle) [20:13:11] RoanKattouw, thanks for answer. I thought it was just disabled some way in standalone version and I tried to find out how to re-enable it. VisualEditor is the only WYSIWYG editor which allowed me to put inline reference/note tag which I could later use. [20:13:18] Nothing is easy at it seems to. [20:13:36] I will try to figure it out (-; [20:13:58] (03PS1) 10Jforrester: [WIP] Get rid of other clear() calls after change() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121449 [20:14:01] One more time thanks. You guys are doing great work here. [20:14:43] (03Abandoned) 10Jforrester: [WIP] Get rid of other clear() calls after change() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/73909 (owner: 10Catrope) [20:15:52] (03Abandoned) 10Jforrester: [WIP] Context rewrite [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/93513 (owner: 10Trevor Parscal) [20:17:38] L-x: Well the inline reference stuff is a MediaWiki feature, so we wrote a plugin to support that feature [20:17:48] It's not a native HTML feature [20:20:01] I know, but I couldn't find better solution. I want to create several articles (XML) with references and after that merge them, export them to footnotes. [20:22:20] and export references only to footnotes* [20:24:15] If there's any easy way to enable this MW feature, i would be glad to know. I am not js fluent, but I will try with some clues. ATM I gotta go. Have a great evening/night/day! [20:26:02] (03CR) 10Krinkle: Return null in Element#getDocument (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 (owner: 10Esanders) [20:28:00] (03Abandoned) 10Jforrester: WIP: Typing tests using jQuery.IME [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/83599 (owner: 10Divec) [20:28:38] (03PS1) 10Jforrester: [WIP] Typing tests using jQuery.IME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121452 [20:29:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Typing tests using jQuery.IME [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121452 (owner: 10Jforrester) [20:29:39] (03Abandoned) 10Jforrester: [WIP] Split out the guts of MediaEditDialog into separate page classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112146 (owner: 10Trevor Parscal) [20:30:11] (03PS1) 10Trevor Parscal: Introduce ve.ui.Tool and make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 [20:30:20] (03PS1) 10Trevor Parscal: Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 [20:30:57] (03CR) 10jenkins-bot: [V: 04-1] Introduce ve.ui.Tool and make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:31:05] (03CR) 10jenkins-bot: [V: 04-1] Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [20:31:51] (03CR) 10Krinkle: Disable tool groups when all its tools are disabled (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 (owner: 10Esanders) [20:32:10] (03PS7) 10Krinkle: [BREAKING CHANGE] Use registry for tool group types [oojs/ui] - 10https://gerrit.wikimedia.org/r/119744 (owner: 10Esanders) [20:32:14] (03PS8) 10Krinkle: Basic toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/119516 (owner: 10Esanders) [20:33:12] (03PS8) 10Krinkle: Styling for disabled toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119517 (owner: 10Esanders) [20:33:18] (03PS8) 10Krinkle: Force visible label for MenuToolGroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119518 (owner: 10Esanders) [20:33:22] (trivial rebase) [20:33:34] Krinkle: Are you CRing too? [20:33:43] (03PS1) 10Trevor Parscal: Make tools execute commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 [20:33:45] James_F: toolbar demo [20:33:50] The surrounding ones not yet [20:34:01] (03PS2) 10Trevor Parscal: Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 [20:34:02] *nods* [20:34:22] RoanKattouw: Can I trade https://gerrit.wikimedia.org/r/#/c/117444/ and https://gerrit.wikimedia.org/r/#/c/72534/ for something? [20:34:36] (or delegate that task to James_F) [20:34:37] (03PS2) 10Trevor Parscal: Introduce ve.ui.Tool and make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 [20:34:48] (of picking the trade) [20:35:54] (03CR) 10Trevor Parscal: [C: 032] Force visible label for MenuToolGroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119518 (owner: 10Esanders) [20:37:48] (03CR) 10Trevor Parscal: [C: 032] Basic toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/119516 (owner: 10Esanders) [20:37:57] (03CR) 10jenkins-bot: [V: 04-1] Make tools execute commands [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [20:38:21] (03CR) 10Trevor Parscal: [C: 032] Styling for disabled toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119517 (owner: 10Esanders) [20:38:26] (03CR) 10jenkins-bot: [V: 04-1] Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [20:38:56] (03CR) 10jenkins-bot: [V: 04-1] Introduce ve.ui.Tool and make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:39:40] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Use registry for tool group types [oojs/ui] - 10https://gerrit.wikimedia.org/r/119744 (owner: 10Esanders) [20:40:55] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Use registry for tool group types [oojs/ui] - 10https://gerrit.wikimedia.org/r/119744 (owner: 10Esanders) [20:40:57] (03Merged) 10jenkins-bot: Basic toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/119516 (owner: 10Esanders) [20:40:59] (03Merged) 10jenkins-bot: Styling for disabled toolgroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119517 (owner: 10Esanders) [20:41:01] (03Merged) 10jenkins-bot: Force visible label for MenuToolGroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119518 (owner: 10Esanders) [20:42:36] RoanKattouw: https://wikimania2014.wikimedia.org/wiki/Submissions/Real-time_Collaborative_Editing_with_TogetherJS [20:42:40] marktraceur: ^^ [20:43:04] Have fun! [20:43:41] Agh [20:43:49] mw.org has typography refresh on now [20:47:31] "Agh" is a pretty good summary. [21:00:27] RoanKattouw, "'wpStarttime': this.baseTimeStamp, 'wpEdittime': this.startTimeStamp" (ve.init.mw.Target.js) seems backwards to me [21:21:45] TrevorParscal, how's the split going? [21:22:12] Krinkle, RoanKattouw are there any plans of implementing source maps in RL? debug mode is not always reliable [21:23:24] jgonera: debug mode is going away (its crap, broken in many ways, removes too much), we'll add a basic non-minified mode instead (for debugging in older browsers), and source maps [21:23:32] See open bugs on bugzilla filed under ResourceLoader [21:23:53] cool, has the work on it started yet? [21:43:25] jgonera: so, I am going to have another look, but this morning I started in on the split and felt like I really didn't know what to split [21:43:38] and, I was looking for you on IRC, but then got distracted by other things [21:43:48] so, perhaps we could talk about it a bit now/today [21:44:40] TrevorParscal, so basically I think we want to do this: https://gerrit.wikimedia.org/r/#/c/119414/1/modules/ve-mw/ui/styles/ve.ui.MWWidget.css and this https://gerrit.wikimedia.org/r/#/c/119413/8/modules/ve/ui/styles/ve.ui.Inspector.css in a nicer way [21:45:04] (03PS6) 10Esanders: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [21:45:06] (03PS1) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 [21:46:09] (03CR) 10jenkins-bot: [V: 04-1] Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [21:46:11] (03CR) 10jenkins-bot: [V: 04-1] Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 (owner: 10Esanders) [21:46:25] ve team: https://etherpad.wikimedia.org/p/VisualEditorTeamLunchOrder20140327 [21:47:15] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (23fb1b6144) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120844 (owner: 10Esanders) [21:47:38] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/120844/ [21:47:38] jgonera: that seems like a small patch for something that should probably be more extensive - no? [21:47:48] jgonera: is it the case that most of the CSS is actually fine? [21:48:04] TrevorParscal, most of the link inspector CSS? [21:48:09] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (23fb1b6144) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120844 (owner: 10Esanders) [21:48:35] jgonera: I guess I'm feeling like this might be easier to do with a tandem commit [21:49:11] TrevorParscal, I'm fine with any way of doing it, I just want to get it done ;) [21:49:13] I can do the rigging, and a basic bit of moving around, and you can move things as you see fit [21:49:31] jgonera: I'm sorry it turned into a lengthy thing, it's really quite simple [21:49:58] sure, basically I just want a way of having custom CSS for desktop/mobile both in ve core and mw ve [21:50:04] Let me put a very basic set of commits together that don't really move anything, and then you can ammend them to move things as you see fit [21:50:20] I don't think we need to split everything now TrevorParscal as it is hard to foresee what will need to be splitted [21:50:20] I will make homes for the new CSS and make them switch and stuff [21:50:26] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (23fb1b6144) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120844 (owner: 10Esanders) [21:50:31] jgonera: yes, that was my issue [21:50:35] TrevorParscal: https://gerrit.wikimedia.org/r/121537 is the pull-through for MW-core. [21:50:38] TrevorParscal, sounds good [21:51:34] as I thought, "splitted" doesn't actually exist [21:51:34] (03PS1) 10Jforrester: Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 [21:51:56] TrevorParscal: https://gerrit.wikimedia.org/r/121538 is the VE-MW pull-through that will need manual adjustment. [21:52:44] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [21:55:15] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [21:56:24] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [21:56:31] mooeypoo: http://es5.github.io/#x7.6.1 [21:56:37] Those are not allowed as variable names. [21:56:44] Property names and object literal keys are fine though, you can use anything there. [21:56:59] so obj.if = { default: 'x' }; is fine [21:57:08] https://etherpad.wikimedia.org/p/VisualEditorTeamLunchOrder20140327 [21:57:09] but var if = '123'; and function default() {} are not [21:57:14] RoanKattouw: ^^ [21:57:50] Allowed, but discouraged via jslint et al. [21:57:59] See also "interface" which was annoying [21:59:05] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [22:00:38] marktraceur: jslint doesn't wince at any reserved word in object position in ES5. obj.if.default is fully valid and not reason for any warning [22:00:40] jshint* [22:00:50] Huh. [22:00:57] in variable declarations they are illegal and always have been [22:01:02] Krinkle: Oh, but you have to turn es5 mode on or so. [22:01:24] The only case for warning is if you need to support ES3 and are using them in dot position (obj.name), which was a bug in ES3 that was fixed in ES5. [22:01:35] But not ES4? :) [22:01:41] There never was ES4 [22:01:53] marktraceur: Yeah, we require Es3 support in mediawiki [22:01:56] *nod* [22:02:13] At least for a valid syntax tree. [22:03:00] (03PS2) 10Jforrester: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 (owner: 10Esanders) [22:03:10] (03PS7) 10Jforrester: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [22:22:09] (03PS8) 10Esanders: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [22:22:11] (03PS3) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 [22:37:43] RoanKattouw, TrevorParscal ve-core master gives me the following error when I try to open VE on mobile: [22:37:44] Exception thrown by ext.visualEditor.core load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20140327T…:145 [22:37:44] TypeError: undefined is not a function TypeError {stack: (...), message: "undefined is not a function"} [22:38:34] Weird [22:38:57] I don't have time to look right this second, will look later [22:40:49] thanks RoanKattouw [22:48:34] (03PS2) 10JGonera: [WIP] Limit some styles to desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119414 [22:49:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Limit some styles to desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119414 (owner: 10JGonera) [22:49:32] (03PS9) 10JGonera: [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 [22:50:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [23:36:13] TrevorParscal, I rebased those two patches, I noticed the CSS in one of them moved to a different file