[00:46:12] (03PS1) 10Jforrester: Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 [00:46:50] (03PS1) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [00:47:21] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [00:47:55] (03CR) 10jenkins-bot: [V: 04-1] Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 (owner: 10Jforrester) [00:50:38] (03PS2) 10Jforrester: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [00:50:59] (03CR) 10Bartosz Dziewoński: "Just wondering, why not make XML work instead? It'd probably require less code." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 (owner: 10Jforrester) [00:51:04] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [00:51:35] (03PS2) 10Jforrester: Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 [00:52:14] (03PS3) 10Jforrester: Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 [00:52:16] (03PS1) 10Catrope: Hack around Parsoid's href prefixing in rendering new links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119914 [00:54:50] (03PS2) 10Jforrester: Hack around Parsoid's href prefixing in rendering new links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119914 (owner: 10Catrope) [00:55:33] (03CR) 10Jforrester: [C: 04-1] Hack around Parsoid's href prefixing in rendering new links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119914 (owner: 10Catrope) [01:15:03] (03PS1) 10JGonera: [WIP] Move some styles to the Apex theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/119916 [01:19:14] (03PS3) 10JGonera: [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 [01:20:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [11:11:59] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [17:18:42] (03CR) 10Trevor Parscal: [C: 032] Split autoAdd into catchall and group specific settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/119902 (owner: 10Trevor Parscal) [17:19:10] (03Merged) 10jenkins-bot: Split autoAdd into catchall and group specific settings [oojs/ui] - 10https://gerrit.wikimedia.org/r/119902 (owner: 10Trevor Parscal) [17:19:36] (03CR) 10Trevor Parscal: Use transaction comparison to decide to render or not (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119901 (owner: 10Trevor Parscal) [17:32:50] hi PM [17:33:13] James_F: did you notice my last comment on the agenda, by chance? :) [17:33:23] Hey Elitre. [17:33:57] No, sorry. [17:34:01] E-mail me? [17:34:36] (03CR) 10Catrope: "This wasn't really a self-+2, I approved this code beforehand :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/119902 (owner: 10Trevor Parscal) [17:38:07] Ok James_F, I will :) [17:40:56] (03CR) 10Jforrester: "@MatmaRex: I can assure you that +2'ing simple code is a lot less work than trying to re-write APIs written purely for a single user JSON " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 (owner: 10Jforrester) [17:42:08] James_F: well, i mean, the MediaWiki API is designed to magically generate multiple output formats [17:42:54] and literally all you have to do is to call ApiResult::setIndexedTagName() on the arrays inside of the result "object", and it will Just Work afaics [17:43:50] but i don't really care about this particular piece. just saying. :) [17:51:13] James_F: I can provide details if you need me to? otherwise my weekend should start soon - but that looked like something that you might want to know before we meet again, I dunno. [17:55:40] (03PS3) 10Mooeypoo: [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [17:55:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [17:55:53] MatmaRex: Actively doing something for non-JSON access would suggest that we support it… [17:56:32] James_F: heh, okay [17:56:56] MatmaRex: I agree in the general case, though, that proper API support is important. [17:57:25] i'm not sure if i'd say this would be "actively doing something for non-JSON access" (it's just a common API convention), but it's your call :) [17:57:48] (03PS2) 10Mooeypoo: [WIP^2] Refactor Scalable and MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [17:59:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP^2] Refactor Scalable and MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [18:07:53] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (3b434d5388) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120043 [18:08:43] TrevorP|Away: https://gerrit.wikimedia.org/r/120041 [18:10:45] (03CR) 10Catrope: Ultra-mega-hyper-citation editing on crack (0315 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [18:15:33] ecmabot-wm: caniuse border-radius [18:15:34] Krinkle: Can I Use CSS3 Border-radius (rounded corners)? [IE3 9+ | FF3 4+ | Chrome3 5+ | Opera3 10.5+ | Safari3 5+ | iOS3 4.0-4.1+ | Android3 2.2+] Overall: 83.9% 2 [18:30:35] (03PS1) 10Krinkle: Remove border-radius prefixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120047 [18:30:37] (03PS1) 10Krinkle: Fix invalid use of border shorthand syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120048 [18:30:39] (03PS1) 10Krinkle: build: Clean up repo split left overs in Gruntfile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120049 [18:36:52] (03PS3) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [18:37:41] (03CR) 10Jforrester: [C: 032] build: Clean up repo split left overs in Gruntfile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120049 (owner: 10Krinkle) [18:38:52] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [18:38:57] (03CR) 10Krinkle: "O_O big commit. Nice." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [18:40:18] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (3b434d5388) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120043 (owner: 10Jforrester) [18:40:55] (03CR) 10Jforrester: [C: 032] Fix invalid use of border shorthand syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120048 (owner: 10Krinkle) [18:41:14] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (3b434d5388) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120043 (owner: 10Jforrester) [18:41:16] (03CR) 10Trevor Parscal: [C: 032] Remove border-radius prefixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120047 (owner: 10Krinkle) [18:42:21] (03Merged) 10jenkins-bot: Remove border-radius prefixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120047 (owner: 10Krinkle) [18:42:23] (03Merged) 10jenkins-bot: Fix invalid use of border shorthand syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120048 (owner: 10Krinkle) [18:42:25] (03Merged) 10jenkins-bot: build: Clean up repo split left overs in Gruntfile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120049 (owner: 10Krinkle) [18:45:54] (03PS1) 10Jforrester: Update VE core submodule to 04d67d2ec817e6f9d8c983570f6080ee7acd1110 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120050 [18:46:37] (03PS1) 10Jforrester: Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 [18:46:43] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to 04d67d2ec817e6f9d8c983570f6080ee7acd1110 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120050 (owner: 10Jforrester) [18:48:15] (03Merged) 10jenkins-bot: Update VE core submodule to 04d67d2ec817e6f9d8c983570f6080ee7acd1110 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120050 (owner: 10Jforrester) [18:48:43] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [18:49:16] (03PS2) 10Jforrester: Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 [18:49:27] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [18:50:24] (03PS3) 10Jforrester: Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 [18:53:30] (03CR) 10Krinkle: Ultra-mega-hyper-citation editing on crack (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [18:54:16] (increased hash to not be numerical, because.. gerrit) [18:54:22] (03PS4) 10Krinkle: Update VE core submodule to master (500390762265271d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [18:54:33] wow that's quite a long sequence of numbers :( [18:54:37] what're the odds ;) [18:56:50] Krinkle: Indeed! I blame Roan. :-) [18:57:32] (03PS1) 10Mooeypoo: Fix 'original dimensions' async call in MediaEdit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120057 [19:00:34] (03CR) 10Krinkle: Fix 'original dimensions' async call in MediaEdit dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120057 (owner: 10Mooeypoo) [19:02:24] (03PS1) 10Trevor Parscal: Fix left-over autoAdd property that didn't get fixed with Idaf3041 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120059 [19:03:30] (03PS5) 10Trevor Parscal: Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:03:43] (03PS4) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [19:04:20] (03CR) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:05:12] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:05:25] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:06:01] (03PS5) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [19:07:42] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:08:06] (03PS6) 10Jforrester: Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 [19:08:19] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:08:53] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:09:26] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/120041/ [19:10:28] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:11:16] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:15:13] (03CR) 10Jforrester: [C: 032] "Try again now that the version of OOjs UI that this depends on is live in MW-core." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:16:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (5003907) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120051 (owner: 10Jforrester) [19:21:47] (03PS6) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [19:23:15] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:29:26] (03PS7) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [19:29:37] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:30:42] (03PS8) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [19:32:08] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:35:18] (03PS2) 10Mooeypoo: Fix 'original dimensions' async call in MediaEdit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120057 [19:37:18] (03CR) 10Jforrester: [C: 032] Fix left-over autoAdd property that didn't get fixed with Idaf3041 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120059 (owner: 10Trevor Parscal) [19:38:17] (03Merged) 10jenkins-bot: Fix left-over autoAdd property that didn't get fixed with Idaf3041 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120059 (owner: 10Trevor Parscal) [19:40:26] (03PS9) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [19:40:36] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [19:41:17] (03PS10) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [20:14:53] (03PS2) 10Trevor Parscal: Split out omnibus CSS files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119351 (owner: 10Jforrester) [20:15:36] (03CR) 10Trevor Parscal: [C: 032] Split out omnibus CSS files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119351 (owner: 10Jforrester) [20:16:57] (03Merged) 10jenkins-bot: Split out omnibus CSS files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119351 (owner: 10Jforrester) [20:18:21] (03CR) 10GWicke: "Ping! We'd love to get this worked out for Flow & our own render testing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [20:25:03] (03PS3) 10Trevor Parscal: Split up omnibus CSS files into per-item ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119341 (owner: 10Jforrester) [20:29:50] (03CR) 10Trevor Parscal: [C: 032] Split up omnibus CSS files into per-item ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119341 (owner: 10Jforrester) [20:30:55] (03Merged) 10jenkins-bot: Split up omnibus CSS files into per-item ones [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119341 (owner: 10Jforrester) [20:32:25] (03PS1) 10Trevor Parscal: Fix a typo that causes crashes when using the wrong symbol for mwTocWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120070 [20:33:18] (03PS2) 10Jforrester: Fix a typo that causes crashes when using the wrong symbol for mwTocWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120070 (owner: 10Trevor Parscal) [20:33:32] (03CR) 10Jforrester: [C: 032] Fix a typo that causes crashes when using the wrong symbol for mwTocWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120070 (owner: 10Trevor Parscal) [20:34:55] (03Merged) 10jenkins-bot: Fix a typo that causes crashes when using the wrong symbol for mwTocWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120070 (owner: 10Trevor Parscal) [20:38:06] Krinkle, heeeelp. I need git help. My lib/ve submodule is behind and I can't manage to pull it properly. 'git pull' doesn't work, and.. nothing else does either, and so my rebasings fail miserably. [20:41:21] 'git checkout master' / 'git pull' results in "You asked me to pull without telling me which branch" [20:42:35] so 'git pull master' and 'git pull origin/master' don't work either ( does not appear to be a git repository) and 'git fetch' results in nothing. [20:42:39] http://eat24hours.com/raymond-chinese-cuisine [20:42:52] http://eat24hours.com/raymond-chinese-cuisine/5482 [20:43:14] http://eat24hours.com/share/d5ea41mkfq8gw4wo4k0s4ccow40k88g [20:54:26] mooeypoo: checking [20:55:03] mooeypoo: go to extensions/VisualEditor, what does git status say? [20:56:18] I have another commit in review there, but status says [20:56:31] # On branch review/trevor_parscal/image-model [20:56:32] # Changes not staged for commit: [20:56:38] # modified: lib/ve (new commits) [20:56:49] which makes sense.. I think. [20:57:42] Krinkle, also, in lib/ve the status shows i'm in 'master' branch.. it is usually in detached head mode, no? [20:57:57] mooeypoo: https://gerrit.wikimedia.org/r/#/c/120138/1/modules/ve-mw/i18n/sco.json [21:01:00] mooeypoo: okay, so lib/ve is definitely initialised [21:01:15] mooeypoo: (in that, git status in lib/ve does not give the same as git status in extensions/VisualEditor) [21:01:23] then in lib/ve, do 'git branch -ar' [21:01:27] (don't paste) [21:01:39] I mean 'git branch -a' sorry [21:01:45] what does the line for master say [21:02:08] It has 2 in red [21:02:19] "master" is in green with a star next to it [21:02:33] but I also have these two in red: [21:02:35] remotes/origin/master [21:02:35] remotes/origin/wmf/1.23wmf12 [21:11:11] (03PS11) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [21:32:13] (03CR) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [22:15:14] (03PS3) 10Mooeypoo: [WIP^2] Refactor Scalable and MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [22:16:25] (03CR) 10jenkins-bot: [V: 04-1] [WIP^2] Refactor Scalable and MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:21:56] (03PS4) 10Mooeypoo: [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [22:23:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [22:27:01] mooeypoo: sorry, (do ping me in replies, I watch IRC, but I do need pings, as I switch tabs often. [22:27:16] mooeypoo: so master has no remote set [22:27:18] Krinkle, thanks, James_F and I solved it [22:27:40] we removed the remote (it had one, but apparently it was bad?) and readded it, then did "git pull origin master" [22:27:40] git co --detach HEAD, git br -D master, git co master (re-creates it), or git branch master --set-upstream origin; to fx the existing one [22:28:04] mooeypoo: but does 'git checkout master && git pull' (without "origin master") work now? [22:28:17] Krinkle: Yes. [22:28:21] no [22:29:10] it works with origin master [22:29:13] James_F: Makes sense, since it only fixed the remote, not the local branch [22:29:13] but not without [22:29:52] mooeypoo: checkout a different branch than master (or go git checkout --detach), then git branch -D master; and git checkout master (recreates it with the right settings) [22:30:00] then git pull will work plainly again, when on master. [22:30:14] (03PS12) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [22:30:47] woot! it works [22:30:49] Krinkle, thanks! [22:31:16] yw [22:32:00] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [22:44:59] (03PS13) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [22:46:14] (03PS14) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [22:47:39] (03CR) 10jenkins-bot: [V: 04-1] Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 (owner: 10Trevor Parscal) [22:52:16] (03PS4) 10JGonera: [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 [22:53:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [22:59:25] (03PS15) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [22:59:59] (03PS16) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [23:03:56] (03PS17) 10Trevor Parscal: Ultra-mega-hyper-citation editing on crack [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119913 [23:08:36] does mw-ve use ooui from core-ve or from mw-core? [23:09:14] jgonera: MW. [23:09:21] ah, that explains a lot [23:09:30] jgonera: But from VE-core if MW doesn't supply (e.g. MW 1.22) [23:09:39] fun [23:12:32] (03PS5) 10Trevor Parscal: [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 [23:12:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [23:16:58] mooeypoo: How did you trigger the cloneNode warning https://gerrit.wikimedia.org/r/#/c/119799/ ? [23:17:05] I can't reproduce it, and thus can't verify the fix [23:17:15] Krinkle, it keeps popping up for me [23:17:15] I tried calling the relevant method directly from the console, but no warning. [23:17:40] Can you trigger it from the console by calling that function? Could you take a screenshot of the error on-screen? [23:17:48] checking [23:18:17] (also, feel free to checkout that patch and verify it fixes it yourself if you like, that'd help too, though I'd like to be able to verify it myself as well so I can find it in other libs maybe) [23:18:53] Krinkle, i don't need to do anything to get it to show, it shows automatically every time I load VE in master [23:21:28] mooeypoo: http://i.imgur.com/wuN8ueG.png [23:22:35] Krinkle, I only get it in Firefox 28.0 [23:23:09] As opposed to earlier or later versions? [23:23:26] I'm on 28.0 [23:26:47] I just started getting this yesterday [23:26:53] checking if I still get this with the patch [23:27:00] ok, I don't have it withthe patch on [23:33:52] mooeypoo: ooo, firefox is about to change [23:34:06] yeh it just started popping up [23:34:12] mooeypoo: Compare http://i.imgur.com/XtDRw6X.png to http://i.imgur.com/wuN8ueG.png [23:34:15] (03PS1) 10Trevor Parscal: Update VE core submodule to master (1adc9f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120160 [23:34:18] (Aurora 30a) [23:35:02] (03PS2) 10JGonera: Move some styles to the Apex theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/119916 [23:35:04] (03PS1) 10JGonera: [WIP] Add basic styling for Agora theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/120161 [23:35:19] Someone's been looking at Chrome [23:35:55] Krinkle: Indeed! [23:36:22] hah [23:36:37] hm, TrevorParscal, any idea why dist/oojs-ui-agora.css from https://gerrit.wikimedia.org/r/120161 contains a lot of rules that I did not define? [23:39:07] TrevorParscal, nevermind, I'm stupid [23:40:09] (03PS2) 10JGonera: [WIP] Add basic styling for Agora theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/120161 [23:40:35] (03PS2) 10Trevor Parscal: Update VE core submodule to master (1adc9f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120160 [23:42:38] (03PS3) 10Jforrester: Update VE core submodule to master (1adc9f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120160 (owner: 10Trevor Parscal) [23:47:48] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (1adc9f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120160 (owner: 10Trevor Parscal) [23:49:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (1adc9f5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120160 (owner: 10Trevor Parscal) [23:49:58] (03PS6) 10Trevor Parscal: [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 [23:50:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP^3] Centralize image handling into a stand-alone model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [23:58:51] (03PS3) 10JGonera: [WIP] Add basic styling for Agora theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/120161